GNU bug report logs - #19497
24.4; erc-tls uses wrong default port number

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19497 in the body.
You can then email your comments to 19497 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Łukasz Stelmach <stlman <at> poczta.fm>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4; erc-tls uses wrong default port number
Date: Sat, 03 Jan 2015 22:17:26 +0100

[Message part 1 (text/plain, inline)]

Hi,

By default `erc' suggests connecting to port 6667. As of now `erc-tls'
does not change this value as it should[1] to 6697.

A patch fixing this issue will follow this message.

[1] http://tools.ietf.org/html/rfc7194
-- 
Było mi bardzo miło.                                  --- Rurku. --- ...
>Łukasz<                                --- To dobrze, że mnie słuchasz.

... To była robota dla sześciu...

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 19497 <at> debbugs.gnu.org (full text, mbox):

From: Łukasz Stelmach <stlman <at> poczta.fm>
To: 19497 <at> debbugs.gnu.org
Cc: Łukasz Stelmach <stlman <at> poczta.fm>
Subject: [PATCH] erc: use a differnt default port number for TLS connections.
Date: Sat,  3 Jan 2015 22:20:57 +0100

---
 lisp/erc/erc.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 7b9a3eb..999b794 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1456,6 +1456,10 @@ Defaults to the server buffer."
 (defconst erc-default-port 6667
   "IRC port to use if it cannot be detected otherwise.")
 
+(defconst erc-default-port-tls 6697
+  "IRC port to use for encrypted connections if it cannot be
+  detected otherwise.")
+
 (defcustom erc-join-buffer 'buffer
   "Determines how to display a newly created IRC buffer.
 
@@ -2185,7 +2189,8 @@ be invoked for the values of the other parameters."
 (defun erc-tls (&rest r)
   "Interactively select TLS connection parameters and run ERC.
 Arguments are the same as for `erc'."
-  (interactive (erc-select-read-args))
+  (interactive (let ((erc-default-port erc-default-port-tls))
+		 (erc-select-read-args)))
   (let ((erc-server-connect-function 'erc-open-tls-stream))
     (apply 'erc r)))
 
-- 
2.0.5

Message #11 received at 19497 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Łukasz Stelmach <stlman <at> poczta.fm>
Cc: 19497 <at> debbugs.gnu.org
Subject: Re: bug#19497: 24.4; erc-tls uses wrong default port number
Date: Sat, 26 Dec 2015 03:47:44 +0100

Łukasz Stelmach <stlman <at> poczta.fm> writes:

> Hi,
>
> By default `erc' suggests connecting to port 6667. As of now `erc-tls'
> does not change this value as it should[1] to 6697.
>
> A patch fixing this issue will follow this message.
>
> [1] http://tools.ietf.org/html/rfc7194

Thanks; patch applied to trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.