From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 03 13:03:55 2015 Received: (at submit) by debbugs.gnu.org; 3 Jan 2015 18:03:55 +0000 Received: from localhost ([127.0.0.1]:35776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7T3L-0003cD-2u for submit@debbugs.gnu.org; Sat, 03 Jan 2015 13:03:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44408) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7PZf-0004MV-Vn for submit@debbugs.gnu.org; Sat, 03 Jan 2015 09:21:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7PZe-0003wk-IS for submit@debbugs.gnu.org; Sat, 03 Jan 2015 09:21:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7PZe-0003wf-Fk for submit@debbugs.gnu.org; Sat, 03 Jan 2015 09:21:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7PZd-0006QC-A0 for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 09:21:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7PZZ-0003ve-RB for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 09:21:01 -0500 Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:53931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7PZZ-0003vP-MJ for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 09:20:57 -0500 Received: by mail-qg0-f53.google.com with SMTP id l89so13673111qgf.40 for ; Sat, 03 Jan 2015 06:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=tqn87PsZ0tHewQOm78haFd2atY+DlScwLgvuUOguKjw=; b=wnK+gCdXjtqbl7UZ0qfWe+x4jAFDe4TbFJqkNXCZHaL0abWC2mW2tmKyyvgX9xL43+ jt6lN4ghQxUfXgpLuPDVpqkrjF7rHBC9oKk2y0+2b5H4B64Dcz7osguiV0Qb52ddjN7+ /vHea1HEb36lt8EjMbc99hm26P2YYZ1tc1Ff9W9FLM7n8M4W7mte9tTZQj3IS0IbnKFn gNlCPrLZHFONmgFvZXtmYfciLkyWwMebzN4mholjPGp5TrptFY0TyxTp1fFTp6M/Iuie EkGQr/Kevh4gktGdKn8M9i41aQwsEHLknAhP607N4iGo6xxdR3VSVaZXG92F/xO9PbyT vtXQ== X-Received: by 10.140.81.166 with SMTP id f35mr81599051qgd.0.1420294856230; Sat, 03 Jan 2015 06:20:56 -0800 (PST) Received: from firefly.scgilardi.net (c-76-24-159-52.hsd1.ma.comcast.net. [76.24.159.52]) by mx.google.com with ESMTPSA id a3sm45729164qag.22.2015.01.03.06.20.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 03 Jan 2015 06:20:55 -0800 (PST) From: "Stephen C. Gilardi" Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: 25.0.50; term.c, produce_composite_glyh, cmp->pixel_width uninitialized Message-Id: <0FD61621-E12F-4183-B1A3-BFA8482B7FA5@gmail.com> Date: Sat, 3 Jan 2015 09:20:52 -0500 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) X-Mailer: Apple Mail (2.1993) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 03 Jan 2015 13:03:52 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q open an emacs lisp file that contains (lambda ... ) turn on prettify-symbols-mode the lambda form is converted to (=CE=BB ... ), and should be displayed = that way, but instead it's displayed as (\ =CE=BB ...) This commit is the first on master to show the problem: = 20791069fa34b486c018ba7f27982bdc6ad2a4ea (found by git bisect) The problem is the calculation of the pixel_width of the composition in = the buffer. It's set to the pixel_width of the composition in the = composition table, but that field is not initialized. (There is no = mention of pixel_width anywhere in composite.c where the table entries = are made.) When I check the value of cmp->pixel_width, it's somewhere = near MAX_SHORT. It should be a small integer. Prior to this commit, in = my setup, the value is 1 which avoids the problem, but isn't a credible = pixel width. An apparently very wide pixel_width for the composition explains the = display anomaly. The composition appears to be thousands of characters = wide and if that were true, the anomalous display would have been = appropriate. I don't see an obvious fix. There seems to be some confusing use in the = code between "width in columns" and "width in pixels". It's possible = that the pixel_width field in "struct it" is not named precisely for how = it=E2=80=99s used--in a terminal, the width may actually be used as a = number of columns rather than a number of pixels. In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu) of 2015-01-03 on localhost Repository revision: 20791069fa34b486c018ba7f27982bdc6ad2a4ea System Description: Ubuntu 14.04.1 LTS Configured using: `configure --without-x' Configured features: SOUND GPM DBUS NOTIFY LIBSELINUX GNUTLS LIBXML2 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Prettify-Symbols mode enabled user-error: Beginning of history; no preceding item Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils regexp-opt vc-git diff-mode easymenu easy-mmode xterm time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify multi-tty emacs) Memory information: ((conses 16 82152 5459) (symbols 48 17585 0) (miscs 40 36 102) (strings 32 12557 4834) (string-bytes 1 332483) (vectors 16 8665) (vector-slots 8 349036 23681) (floats 8 65 657) (intervals 56 259 25) (buffers 976 12) (heap 1024 37582 1315)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 03 13:17:33 2015 Received: (at 19496) by debbugs.gnu.org; 3 Jan 2015 18:17:33 +0000 Received: from localhost ([127.0.0.1]:35784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7TGW-0003xG-OJ for submit@debbugs.gnu.org; Sat, 03 Jan 2015 13:17:33 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:57657) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7TGS-0003x1-UF for 19496@debbugs.gnu.org; Sat, 03 Jan 2015 13:17:30 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NHM006004WDEN00@a-mtaout21.012.net.il> for 19496@debbugs.gnu.org; Sat, 03 Jan 2015 20:17:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHM006325H29X70@a-mtaout21.012.net.il>; Sat, 03 Jan 2015 20:17:26 +0200 (IST) Date: Sat, 03 Jan 2015 20:17:26 +0200 From: Eli Zaretskii Subject: Re: bug#19496: 25.0.50; term.c, produce_composite_glyh, cmp->pixel_width uninitialized In-reply-to: <0FD61621-E12F-4183-B1A3-BFA8482B7FA5@gmail.com> X-012-Sender: halo1@inter.net.il To: "Stephen C. Gilardi" , Paul Eggert Message-id: <83fvbrafux.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <0FD61621-E12F-4183-B1A3-BFA8482B7FA5@gmail.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19496 Cc: Kenichi Handa , 19496@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: "Stephen C. Gilardi" > Date: Sat, 3 Jan 2015 09:20:52 -0500 > > emacs -Q > open an emacs lisp file that contains (lambda ... ) > turn on prettify-symbols-mode > the lambda form is converted to (λ ... ), and should be displayed that way, but instead it's displayed as > (\ > λ > ...) > > This commit is the first on master to show the problem: 20791069fa34b486c018ba7f27982bdc6ad2a4ea (found by git bisect) I think that commit was mistaken, and should be reverted, because before it this worked correctly. CC'ing Paul, who made the change, and Handa-san, who probably wrote it. Paul, was there a use case where you saw a problem with the original code? If so, can you show it? > I don't see an obvious fix. Why do you think the previous code is not TRT? > There seems to be some confusing use in the code between "width in columns" and "width in pixels". It's possible that the pixel_width field in "struct it" is not named precisely for how it’s used--in a terminal, the width may actually be used as a number of columns rather than a number of pixels. On a text terminal, each glyph is 1 pixel wide. So on a text terminal these two are identical. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 03 17:40:10 2015 Received: (at 19496-done) by debbugs.gnu.org; 3 Jan 2015 22:40:10 +0000 Received: from localhost ([127.0.0.1]:35860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7XMg-0001v8-0g for submit@debbugs.gnu.org; Sat, 03 Jan 2015 17:40:10 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:39200) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7XMd-0001uz-EL for 19496-done@debbugs.gnu.org; Sat, 03 Jan 2015 17:40:08 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id BA2FCA60003; Sat, 3 Jan 2015 14:40:05 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hT9oTHYJl5eF; Sat, 3 Jan 2015 14:39:57 -0800 (PST) Received: from [192.168.1.9] (pool-173-55-11-52.lsanca.fios.verizon.net [173.55.11.52]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id F0036A60002; Sat, 3 Jan 2015 14:39:56 -0800 (PST) Message-ID: <54A86FBC.5060509@cs.ucla.edu> Date: Sat, 03 Jan 2015 14:39:56 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii , "Stephen C. Gilardi" Subject: Re: bug#19496: 25.0.50; term.c, produce_composite_glyh, cmp->pixel_width uninitialized References: <0FD61621-E12F-4183-B1A3-BFA8482B7FA5@gmail.com> <83fvbrafux.fsf@gnu.org> In-Reply-To: <83fvbrafux.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19496-done Cc: Kenichi Handa , 19496-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Eli Zaretskii wrote: > Paul, was there a use case where you saw a problem with the original > code? If so, can you show it? Sorry, that was a thinko on my part. I reverted the change in master as commit 5395106. Thanks for reporting it. From unknown Wed Aug 20 02:46:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Feb 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator