From unknown Tue Aug 19 07:27:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19481 <19481@debbugs.gnu.org> To: bug#19481 <19481@debbugs.gnu.org> Subject: Status: package.el: support .tar archives featuring a pax_global_header entry Reply-To: bug#19481 <19481@debbugs.gnu.org> Date: Tue, 19 Aug 2025 14:27:13 +0000 retitle 19481 package.el: support .tar archives featuring a pax_global_head= er entry reassign 19481 emacs submitter 19481 Ivan Shmakov severity 19481 minor tag 19481 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 01 12:58:16 2015 Received: (at submit) by debbugs.gnu.org; 1 Jan 2015 17:58:17 +0000 Received: from localhost ([127.0.0.1]:34604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6k0m-0007a7-Es for submit@debbugs.gnu.org; Thu, 01 Jan 2015 12:58:16 -0500 Received: from fely.am-1.org ([78.47.74.50]:47269) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6k0h-0007Zw-Rk for submit@debbugs.gnu.org; Thu, 01 Jan 2015 12:58:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=D3eoZQi4Cdj1iJvZcWBpI4awQhZJUhlr2DfFAZRoLKM=; b=rPozwpWqFKHe9jTyWgTKePal5pOMF6Me2KBTgsw5mT42j3lgjI8cuLh6aD2o2fUkU9LjN4LUtuP9wrb6NK6QrGRMRNfz5wXHt3cyW4WZ7RJuHiQjMqXgQqwsjwTDJ4QGTGxDLsVqAqvwI5cNsR1zj83GYed00sq0ibf1JBD1QSM=; Received: from oneingray-1-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:1eb::2] helo=waterlily.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Y6k0f-0001z3-PG for submit@debbugs.gnu.org; Thu, 01 Jan 2015 17:58:09 +0000 Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by waterlily.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Y6k0Q-00046K-Cv for submit@debbugs.gnu.org; Fri, 02 Jan 2015 00:57:54 +0700 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y6jyN-0003jY-6z for submit@debbugs.gnu.org; Fri, 02 Jan 2015 00:55:47 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: package.el: support .tar archives featuring a pax_global_header entry Date: Thu, 01 Jan 2015 17:55:46 +0000 Message-ID: <871tne5qsd.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor As currently implemented, package.el signals an error trying to process a .tar archive which has a pax_global_header entry, =E2=80=93 such as the archives produced with $ git archive --format=3Dtar. Please thus consider the patch MIMEd. * lisp/emacs-lisp/package.el (package-untar-buffer): Ignore archive entries with link type being 55. (package-tar-file-info): Consider the second file name in the archive if the first one has no directory component. * lisp/tar-mode.el (tar-untar-buffer): Ignore archive entries with link type being 55 (pax global extended header.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -739,6 +739,8 @@ defun package-untar-buffer (dir) (dolist (tar-data tar-parse-info) (let ((name (expand-file-name (tar-header-name tar-data)))) (or (string-match regexp name) + ;; Ignore the pax_global_header entry. + (eq 55 (tar-header-link-type tar-data)) ;; Tarballs created by some utilities don't list ;; directories with a trailing slash (Bug#13136). (and (string-equal dir name) @@ -1245,8 +1247,10 @@ defun package-tar-file-info () "Find package information for a tar file. The return result is a `package-desc'." (cl-assert (derived-mode-p 'tar-mode)) - (let* ((dir-name (file-name-directory - (tar-header-name (car tar-parse-info)))) + (let* ((dir-name + ;; Take care of pax_global_header, if any. + (or (file-name-directory (tar-header-name (car tar-parse-info))) + (file-name-directory (tar-header-name (cadr tar-parse-info))))) (desc-file (package--description-file dir-name)) (tar-desc (tar-get-file-descriptor (concat dir-name desc-file)))) (unless tar-desc --- a/lisp/tar-mode.el +++ b/lisp/tar-mode.el @@ -479,10 +550,12 @@ defun tar-untar-buffer () (message "Extracting %s" name) (if (and dir (not (file-exists-p dir))) (make-directory dir t)) - (unless (file-directory-p name) - (let ((coding-system-for-write 'no-conversion)) - (write-region start end name))) - (set-file-modes name (tar-header-mode descriptor)))))))) + ;; Ignore the pax_global_header entry. + (unless (eq 55 (tar-header-link-type descriptor)) + (unless (or (file-directory-p name)) + (let ((coding-system-for-write 'no-conversion)) + (write-region start end name))) + (set-file-modes name (tar-header-mode descriptor))))))))) (defun tar-summarize-buffer () "Parse the contents of the tar file in the current buffer." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 01 13:27:39 2015 Received: (at 19481) by debbugs.gnu.org; 1 Jan 2015 18:27:39 +0000 Received: from localhost ([127.0.0.1]:34620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6kTC-0008Ib-Jv for submit@debbugs.gnu.org; Thu, 01 Jan 2015 13:27:38 -0500 Received: from mtaout25.012.net.il ([80.179.55.181]:51754) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6kT9-0008IQ-8j for 19481@debbugs.gnu.org; Thu, 01 Jan 2015 13:27:36 -0500 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NHI00C00FYJ7700@mtaout25.012.net.il> for 19481@debbugs.gnu.org; Thu, 01 Jan 2015 20:23:28 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHI007WKGF45U60@mtaout25.012.net.il>; Thu, 01 Jan 2015 20:23:28 +0200 (IST) Date: Thu, 01 Jan 2015 20:27:29 +0200 From: Eli Zaretskii Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry In-reply-to: <871tne5qsd.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83bnmibbla.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <871tne5qsd.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Thu, 01 Jan 2015 17:55:46 +0000 > > As currently implemented, package.el signals an error trying to > process a .tar archive which has a pax_global_header entry, – > such as the archives produced with $ git archive --format=tar. > > Please thus consider the patch MIMEd. > > * lisp/emacs-lisp/package.el (package-untar-buffer): Ignore > archive entries with link type being 55. > (package-tar-file-info): Consider the second file name in the > archive if the first one has no directory component. > > * lisp/tar-mode.el (tar-untar-buffer): Ignore archive entries > with link type being 55 (pax global extended header.) What about type 72? (See tar-mode.el for the details.) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 01 13:39:04 2015 Received: (at 19481) by debbugs.gnu.org; 1 Jan 2015 18:39:04 +0000 Received: from localhost ([127.0.0.1]:34624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6keF-00008b-Rs for submit@debbugs.gnu.org; Thu, 01 Jan 2015 13:39:04 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:58376) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6keD-00008C-Ea for 19481@debbugs.gnu.org; Thu, 01 Jan 2015 13:39:02 -0500 Received: by mail-wg0-f52.google.com with SMTP id x12so23201344wgg.25 for <19481@debbugs.gnu.org>; Thu, 01 Jan 2015 10:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=tQgKu/coxW0OD4R2xQ7MLsMCOD5+OqDcKakp9suP7xw=; b=gBm2iIGfr6Mqm+jJT6jk4bKfW5gAFV+w4mn7X9z2p7CGDVAdrnAh6s9kauKnUHFnsI ksP7TFEbH9nouGDSQolf5cT9421jvycZV8OQBjhe46BZ3xVs8rp1nPtlCi7B7gaaCTfX OCiu/jx0M1ynR49LvSfTr7efx7fXSkBt/5DZJ40fTvzLkoCQAV1c4VAn3B1TG3M0vJcS yUSjToSvkOaQ7zyUYqi4Ui46qjlncimBjGnwmzXt5Xvi/Cf5miWP5huCzGNSBPd35Agy cCYIIWeucMhTMCi8tg5cABXxroJtCFLuCJ3jY0ewHBWr6Q4GC5A2oVcL4OPCNjSxa/Ls DLEg== X-Received: by 10.180.90.206 with SMTP id by14mr127636418wib.67.1420137540827; Thu, 01 Jan 2015 10:39:00 -0800 (PST) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id x16sm36687057wia.15.2015.01.01.10.38.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jan 2015 10:39:00 -0800 (PST) Message-ID: <54A5943E.3050100@yandex.ru> Date: Thu, 01 Jan 2015 20:38:54 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 MIME-Version: 1.0 To: Ivan Shmakov , 19481@debbugs.gnu.org Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> In-Reply-To: <871tne5qsd.fsf@violet.siamics.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19481 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I think this patch should include a new test as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 01 13:49:26 2015 Received: (at 19481) by debbugs.gnu.org; 1 Jan 2015 18:49:26 +0000 Received: from localhost ([127.0.0.1]:34628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6koH-0000Nj-UL for submit@debbugs.gnu.org; Thu, 01 Jan 2015 13:49:26 -0500 Received: from fely.am-1.org ([78.47.74.50]:47277) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6koF-0000Na-33 for 19481@debbugs.gnu.org; Thu, 01 Jan 2015 13:49:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=mz+CDW+NLcC2XlU7Dh6rixGdV/jx2SWwJCG5SZmgHj8=; b=r7RvxDOT3rXFxw5FRz+VdSxrWXAQ15xjCQ3KpDjNCe2tirOL4o916+klGU7IsebYdw9ctZR+oFjEqMzwswXtedMj6zr0UyMgaGlwdveLf18Nx37ix7XdJAq5E7xJmoLN2getgbAOhEzE+0rSyVjvOwvb+cWfRUcCCInwaRgFhJY=; Received: from [2a02:2560:6d4:26ca::1] (helo=waterlily.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Y6koE-0002nY-A5 for 19481@debbugs.gnu.org; Thu, 01 Jan 2015 18:49:22 +0000 Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by waterlily.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Y6ko7-00049X-Po for 19481@debbugs.gnu.org; Fri, 02 Jan 2015 01:49:15 +0700 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y6ko6-00043h-Np for 19481@debbugs.gnu.org; Fri, 02 Jan 2015 01:49:14 +0700 From: Ivan Shmakov To: 19481@debbugs.gnu.org Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> Mail-Followup-To: 19481@debbugs.gnu.org Date: Thu, 01 Jan 2015 18:49:13 +0000 In-Reply-To: <83bnmibbla.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Jan 2015 20:27:29 +0200") Message-ID: <87wq5649qu.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19481 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Thu, 01 Jan 2015 17:55:46 +0000 [=E2=80=A6] >> * lisp/emacs-lisp/package.el (package-untar-buffer): Ignore archive >> entries with link type being 55. >> (package-tar-file-info): Consider the second file name in the >> archive if the first one has no directory component. >> * lisp/tar-mode.el (tar-untar-buffer): Ignore archive entries with >> link type being 55 (pax global extended header.) > What about type 72? Frankly, =E2=80=93 no idea; I don=E2=80=99t seem to recall seeing one so f= ar. In order not to place such checks all over the code, we may want either a separate tar-header-service-p function for the tar-untar-buffer callers to use to decide whether the file will be extracted or not, /or/ an optional filter function argument to tar-untar-buffer for the /caller/ to specify which files to filter out. > (See tar-mode.el for the details.) It doesn=E2=80=99t seem to provide anything beyond the name of the type. --=20 FSF associate member #7257 np. Helden =E2=80=94 Apocalyptica =E2=80=A6 3= 013 B6A0 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 11 04:36:02 2015 Received: (at control) by debbugs.gnu.org; 11 Jan 2015 09:36:02 +0000 Received: from localhost ([127.0.0.1]:42373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAEwE-0002q5-Ay for submit@debbugs.gnu.org; Sun, 11 Jan 2015 04:36:02 -0500 Received: from fely.am-1.org ([78.47.74.50]:48858) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAEwB-0002pe-5v for control@debbugs.gnu.org; Sun, 11 Jan 2015 04:36:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=v73J/orP+vLPbxX1AT3+vssyF6BfTNKlv6tLUTl9g3U=; b=Lv83EwjoPiSaL5iSCfTqOrdn3pSP+MgooaCCBu6k0mQ21NwJAfHp3QRJV2LR7Kct8ehMBZY1e4DgqExg8NiRGvsUDcWcANiLL0X5mnVpSmPSwxfeZ3mBIagrHPBzQcyl+1/4l7WVApb7cpN5D2t2c2uOLvhABFrVHFT2fVfktV4=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YAEw9-0002PO-DU for control@debbugs.gnu.org; Sun, 11 Jan 2015 09:35:57 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YAEw2-0004vq-0T for control@debbugs.gnu.org; Sun, 11 Jan 2015 16:35:50 +0700 From: Ivan Shmakov To: control@debbugs.gnu.org Subject: tweaking bugs Date: Sun, 11 Jan 2015 09:35:49 +0000 Message-ID: <87a91pzmkq.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) severity 19560 normal tags 19560 + patch merge 16415 19560 retitle 16415 24.3.50; Handle adjacent links correctly in shr=20 tags 19481 + patch tags 19555 + patch tags 19556 + patch thanks --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 28 15:54:49 2015 Received: (at 19481) by debbugs.gnu.org; 28 Jan 2015 20:54:49 +0000 Received: from localhost ([127.0.0.1]:56711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGZdQ-00010y-NU for submit@debbugs.gnu.org; Wed, 28 Jan 2015 15:54:49 -0500 Received: from fely.am-1.org ([78.47.74.50]:41014) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGZdN-00010l-Jn for 19481@debbugs.gnu.org; Wed, 28 Jan 2015 15:54:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=gCbDHr9e/6ifnRknLjHRPDv2hGAvSm0VK+J6lMNh0IE=; b=SKPqpDnZLwWWV/UB46Ja48roTwkKD0/byFIsemkbLDPofFo00sCybstosx4a2yxlkkt9XRXdDeSicMSNx2Qyr5mh6XLYXcVGMM5omoBEUVg9rzL2p8VqCPGAr5pEAmq8Wg1YR5MULg+VfveptDGvtO6k9lnRcjHyZ30kfGtgVLU=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YGZdJ-0004AE-Mw for 19481@debbugs.gnu.org; Wed, 28 Jan 2015 20:54:42 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YGZdC-0005Cm-II for 19481@debbugs.gnu.org; Thu, 29 Jan 2015 03:54:34 +0700 From: Ivan Shmakov To: 19481@debbugs.gnu.org Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> Mail-Followup-To: 19481@debbugs.gnu.org Date: Wed, 28 Jan 2015 20:54:33 +0000 In-Reply-To: <87wq5649qu.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Thu, 01 Jan 2015 18:49:13 +0000") Message-ID: <87386ulj7a.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19481 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Ivan Shmakov writes: >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Thu, 01 Jan 2015 17:55:46 +0000 [=E2=80=A6] >>> * lisp/tar-mode.el (tar-untar-buffer): Ignore archive entries with >>> link type being 55 (pax global extended header.) >> What about type 72? > Frankly, =E2=80=93 no idea; I don=E2=80=99t seem to recall seeing one so= far. > In order not to place such checks all over the code, we may want > either a separate tar-header-service-p function for the > tar-untar-buffer callers to use to decide whether the file will be > extracted or not, /or/ an optional filter function argument to > tar-untar-buffer for the /caller/ to specify which files to filter > out. Please consider the revised patch MIMEd. * lisp/tar-mode.el (tar-header-extractable-p): New function. (tar-untar-buffer): Use it; or use the value of the new optional argument instead. * lisp/emacs-lisp/package.el (package-untar-buffer): Use tar-header-extractable-p. (package-tar-file-info): Consider the second file name in the archive if the first one has no directory component. [=E2=80=A6] --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -757,6 +757,8 @@ defun package-untar-buffer (dir) (dolist (tar-data tar-parse-info) (let ((name (expand-file-name (tar-header-name tar-data)))) (or (string-match regexp name) + ;; Ignore non-extractable entries (e. g., pax_global_header.) + (not (tar-header-extractable-p tar-data)) ;; Tarballs created by some utilities don't list ;; directories with a trailing slash (Bug#13136). (and (string-equal dir name) @@ -1291,4 +1293,3 @@ defun package-tar-file-info () "Find package information for a tar file. The return result is a `package-desc'." (cl-assert (derived-mode-p 'tar-mode)) - (let* ((dir-name (file-name-directory e- (tar-header-name (car tar-parse-info)))) + (let* ((dir-name + ;; Take care of pax_global_header, if any. + (or (file-name-directory (tar-header-name (car tar-parse-info))) + (file-name-directory (tar-header-name (cadr tar-parse-info))))) (desc-file (package--description-file dir-name)) (tar-desc (tar-get-file-descriptor (concat dir-name desc-file)))) (unless tar-desc --- a/lisp/tar-mode.el +++ b/lisp/tar-mode.el @@ -331,6 +331,17 @@ (tar-roundup-512 size) 0)))) +(defun tar-header-extractable-p (descriptor) + "Return non-nil if DESCRIPTOR refers to a file we can extract. +Currently tar-mode only supports extracting regular files and (to a +limited extent) directories. + +If DESCRIPTOR is an integer, it is handled as a link type." + (let ((type (if (integerp descriptor) + descriptor + (tar-header-link-type descriptor)))) + (memq '(nil 0 5) type))) + (defun tar-parse-octal-integer (string &optional start end) (if (null start) (setq start 0)) (if (null end) (setq end (length string))) @@ -531,9 +542,17 @@ (concat (if (= type 1) " ==> " " --> ") link-name) "")))) -(defun tar-untar-buffer () - "Extract all archive members in the tar-file into the current directory." +(defun tar-untar-buffer (&optional filter) + "Extract all archive members in the tar-file into the current directory. + +Optional FILTER is a function called with the Tar header (descriptor) +as its only argument for each of archive members in turn. Any given +member will only be extracted if the function returns non-nil. + +If FILTER is not given or nil, use `tar-header-extractable-p'." (interactive) + (unless filter + (setq filter 'tar-header-extractable-p)) ;; FIXME: make it work even if we're not in tar-mode. (let ((descriptors tar-parse-info)) ;Read the var in its buffer. (with-current-buffer @@ -546,7 +565,8 @@ defun tar-untar-buffer () (file-name-directory name))) (start (tar-header-data-start descriptor)) (end (+ start (tar-header-size descriptor)))) - (unless (file-directory-p name) + (when (and (not (file-directory-p name)) + (funcall filter descriptor)) (message "Extracting %s" name) (if (and dir (not (file-exists-p dir))) (make-directory dir t)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 31 03:42:04 2015 Received: (at 19481) by debbugs.gnu.org; 31 Jan 2015 08:42:04 +0000 Received: from localhost ([127.0.0.1]:58420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHTcy-00070I-9F for submit@debbugs.gnu.org; Sat, 31 Jan 2015 03:42:04 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:48355) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHTcw-0006zo-9F for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 03:42:03 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NJ100J00986Z900@a-mtaout20.012.net.il> for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 10:41:55 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ100J9C9HVJQA0@a-mtaout20.012.net.il>; Sat, 31 Jan 2015 10:41:55 +0200 (IST) Date: Sat, 31 Jan 2015 10:41:56 +0200 From: Eli Zaretskii Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry In-reply-to: <87386ulj7a.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83zj8zjq97.fsf@gnu.org> References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Wed, 28 Jan 2015 20:54:33 +0000 > > Please consider the revised patch MIMEd. > > * lisp/tar-mode.el (tar-header-extractable-p): New function. > (tar-untar-buffer): Use it; or use the value of the new optional > argument instead. > > * lisp/emacs-lisp/package.el (package-untar-buffer): Use > tar-header-extractable-p. > (package-tar-file-info): Consider the second file name in the > archive if the first one has no directory component. Thanks. Can we have a test suite for this file, and in particular for these changes? Failing that, please describe how you tested these changes. Otherwise, I have no comments, and no objections to commit this, once we are sure it doesn't break anything. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 31 06:06:03 2015 Received: (at 19481) by debbugs.gnu.org; 31 Jan 2015 11:06:04 +0000 Received: from localhost ([127.0.0.1]:58464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHVsJ-0002FI-7x for submit@debbugs.gnu.org; Sat, 31 Jan 2015 06:06:03 -0500 Received: from fely.am-1.org ([78.47.74.50]:41477) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHVsG-0002Er-83 for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 06:06:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=HxSdMg/dD08GUC5adjzXJmUuUPTkFIGirBrXOuy2ecY=; b=b4v4ZnsgiHPHY4c2ZwBvwm3csuwwqm2mnfq2vUR4vzDarUGFDHU1Zuz8FZ8qbX+mQBK78CiZBq1LGo58WIEnTfRKxi08OkctR50yNn+APhw58qymD7zFUNdgi4lqr113CC0OZfJpgOkHiptfSxCsogQuTpY+PKvd+FeyTYJV2IY=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YHVsD-0002cf-7T for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 11:05:57 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YHVs5-0004Es-RY for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 18:05:49 +0700 From: Ivan Shmakov To: 19481@debbugs.gnu.org Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> Mail-Followup-To: 19481@debbugs.gnu.org Date: Sat, 31 Jan 2015 11:05:48 +0000 In-Reply-To: <83zj8zjq97.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Jan 2015 10:41:56 +0200") Message-ID: <87386ri50z.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19481 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Wed, 28 Jan 2015 20:54:33 +0000 >> Please consider the revised patch MIMEd. >> * lisp/tar-mode.el (tar-header-extractable-p): New function. >> (tar-untar-buffer): Use it; or use the value of the new optional >> argument instead. >> * lisp/emacs-lisp/package.el (package-untar-buffer): Use >> tar-header-extractable-p. >> (package-tar-file-info): Consider the second file name in the >> archive if the first one has no directory component. > Thanks. > Can we have a test suite for this file, Which of the two? (Or three, to count the .tar file produced by $ git archive.) > and in particular for these changes? I hope to come with a suitable addition for test/automated/package-test.el shortly. Or do you suggest adding a test suite for tar-mode as well? FTR, the two changes I suggest are not /inter/dependent, so I intend to push them as two separate commits. (And I wonder if eit makes sense to now file a separate Severity: wishlist bug report for tar-header-extractable-p, so to provide a somewhat extended background for the feature.) > Failing that, please describe how you tested these changes. I=E2=80=99ve tested these using my MW package, like: =E2=80=A2 C-x b *new-buffer* RET; =E2=80=A2 M-x cd RET ~/devel/mw-el-2015/ RET; =E2=80=A2 C-u M-! git archive --prefix=3Dmw-0.2/ --format=3Dtar HEAD 2> /dev/null RET; =E2=80=A2 M-x tar-mode RET; =E2=80=A2 M-x package-install-from-buffer RET. > Otherwise, I have no comments, and no objections to commit this, once > we are sure it doesn't break anything. ACK, thanks. --=20 FSF associate member #7257 np. La vita =E2=80=94 Roberto Ricioppo =E2=80= =A6 B6A0 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 31 06:22:31 2015 Received: (at 19481) by debbugs.gnu.org; 31 Jan 2015 11:22:31 +0000 Received: from localhost ([127.0.0.1]:58472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHW8E-0002dL-NK for submit@debbugs.gnu.org; Sat, 31 Jan 2015 06:22:31 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:56671) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHW8B-0002d6-O4 for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 06:22:28 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NJ100M00GX90S00@a-mtaout21.012.net.il> for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 13:22:21 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ100M1RGX80R00@a-mtaout21.012.net.il>; Sat, 31 Jan 2015 13:22:21 +0200 (IST) Date: Sat, 31 Jan 2015 13:22:21 +0200 From: Eli Zaretskii Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry In-reply-to: <87386ri50z.fsf_-_@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83mw4zjitu.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 31 Jan 2015 11:05:48 +0000 > > >> * lisp/tar-mode.el (tar-header-extractable-p): New function. > >> (tar-untar-buffer): Use it; or use the value of the new optional > >> argument instead. > > >> * lisp/emacs-lisp/package.el (package-untar-buffer): Use > >> tar-header-extractable-p. > >> (package-tar-file-info): Consider the second file name in the > >> archive if the first one has no directory component. > > > Thanks. > > > Can we have a test suite for this file, > > Which of the two? (Or three, to count the .tar file produced by > $ git archive.) I meant tar-mode.el, and specifically where the new function is used. > FTR, the two changes I suggest are not /inter/dependent, so I > intend to push them as two separate commits. Does the tar-header-extractable-p function make any sense without its use in package.el? If so, then yes, these should be 2 separate commits. > (And I wonder if > eit makes sense to now file a separate Severity: wishlist bug > report for tar-header-extractable-p, so to provide a somewhat > extended background for the feature.) Not sure it's worth your while. > > Failing that, please describe how you tested these changes. > > I’ve tested these using my MW package, like: > > • C-x b *new-buffer* RET; > > • M-x cd RET ~/devel/mw-el-2015/ RET; > > • C-u M-! git archive --prefix=mw-0.2/ --format=tar > HEAD 2> /dev/null RET; > > • M-x tar-mode RET; > > • M-x package-install-from-buffer RET. Did you try unpacking a "normal" tar archive, to see nothing is broken? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 07 15:10:56 2015 Received: (at 19481) by debbugs.gnu.org; 7 Feb 2015 20:10:56 +0000 Received: from localhost ([127.0.0.1]:36856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKBiR-0002n3-R9 for submit@debbugs.gnu.org; Sat, 07 Feb 2015 15:10:56 -0500 Received: from fely.am-1.org ([78.47.74.50]:42849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKBiO-0002mt-VD for 19481@debbugs.gnu.org; Sat, 07 Feb 2015 15:10:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=tpVYsePsdP/sxMCy5/seOfVAG0ZTnT6rZJYg4QcNjuc=; b=fX+C+q2TFbtoJqEy9nzCDiJuiwuWRUxXrwEVHjGNIHxcvda18JI2IhoYWCST8TU4AGSG+pInlI4jWUClqFm2dCla3xF7XPQuXAh8fP+TvbVAIv3cMRBRsaVHLJ1se370ximrS6QGHHXCTOYR51bb/IDpaKhvwAjBMFvuyGm2/ww=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YKBiK-0004Op-K8 for 19481@debbugs.gnu.org; Sat, 07 Feb 2015 20:10:48 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YKBiD-0007Ag-RS for 19481@debbugs.gnu.org; Sun, 08 Feb 2015 03:10:41 +0700 From: Ivan Shmakov To: 19481@debbugs.gnu.org Subject: Re: bug#19481: new tar-header-extractable-p, to use in tar-untar-buffer References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> <83mw4zjitu.fsf@gnu.org> Mail-Followup-To: 19481@debbugs.gnu.org Date: Sat, 07 Feb 2015 20:10:41 +0000 In-Reply-To: <83mw4zjitu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Jan 2015 13:22:21 +0200") Message-ID: <87r3u1eb3y.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19481 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 31 Jan 2015 11:05:48 +0000 [=E2=80=A6] >>> Can we have a test suite for this file, >> Which of the two? (Or three, to count the .tar file produced by >> $ git archive.) > I meant tar-mode.el, and specifically where the new function is used. ACK. How do I provide a sample .tar file to use in the test? >> FTR, the two changes I suggest are not /inter/dependent, so I intend >> to push them as two separate commits. > Does the tar-header-extractable-p function make any sense without its > use in package.el? If so, then yes, these should be 2 separate > commits. I believe that this function may indeed be useful to any third-party code which needs to examine a Tar file before passing it to tar-untar-buffer. Also, the changes suggested make it easier to use the latter to extract only the members matching specific (i. e., defined by the caller) criteria. [=E2=80=A6] --=20 FSF associate member #7257 np. Fly by Night =E2=80=94 Rush =E2=80=A6 3= 013 B6A0 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 07 15:27:00 2015 Received: (at 19481) by debbugs.gnu.org; 7 Feb 2015 20:27:00 +0000 Received: from localhost ([127.0.0.1]:36871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKBy0-00039t-F0 for submit@debbugs.gnu.org; Sat, 07 Feb 2015 15:27:00 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:50065) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKBxx-00039f-No for 19481@debbugs.gnu.org; Sat, 07 Feb 2015 15:26:58 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJF00J004JK6900@a-mtaout22.012.net.il> for 19481@debbugs.gnu.org; Sat, 07 Feb 2015 22:26:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJF00JX54SQ1O70@a-mtaout22.012.net.il>; Sat, 07 Feb 2015 22:26:50 +0200 (IST) Date: Sat, 07 Feb 2015 22:26:38 +0200 From: Eli Zaretskii Subject: Re: bug#19481: new tar-header-extractable-p, to use in tar-untar-buffer In-reply-to: <87r3u1eb3y.fsf_-_@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <837fvtbh8h.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> <83mw4zjitu.fsf@gnu.org> <87r3u1eb3y.fsf_-_@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 07 Feb 2015 20:10:41 +0000 > > >>>>> Eli Zaretskii writes: > >>>>> From: Ivan Shmakov Date: Sat, 31 Jan 2015 11:05:48 +0000 > > […] > > >>> Can we have a test suite for this file, > > >> Which of the two? (Or three, to count the .tar file produced by > >> $ git archive.) > > > I meant tar-mode.el, and specifically where the new function is used. > > ACK. How do I provide a sample .tar file to use in the test? Just add it to the repository, under test/automated/. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 06:31:03 2016 Received: (at 19481) by debbugs.gnu.org; 23 Feb 2016 11:31:03 +0000 Received: from localhost ([127.0.0.1]:39343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBBH-0004Ou-7B for submit@debbugs.gnu.org; Tue, 23 Feb 2016 06:31:03 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57240) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBBF-0004MD-59 for 19481@debbugs.gnu.org; Tue, 23 Feb 2016 06:31:01 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYBAj-0004wT-Dt; Tue, 23 Feb 2016 12:30:30 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#19481: new tar-header-extractable-p, to use in tar-untar-buffer References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> <83mw4zjitu.fsf@gnu.org> <87r3u1eb3y.fsf_-_@violet.siamics.net> <837fvtbh8h.fsf@gnu.org> Date: Tue, 23 Feb 2016 22:30:20 +1100 In-Reply-To: <837fvtbh8h.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Feb 2015 22:26:38 +0200") Message-ID: <878u2br7eb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MailScanner-ID: 1aYBAj-0004wT-Dt X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456831830.21567@uORRfr5SLPXXoxnXclBUuA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org, Ivan Shmakov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> From: Ivan Shmakov >> Date: Sat, 07 Feb 2015 20:10:41 +0000 >>=20 >> >>>>> Eli Zaretskii writes: >> >>>>> From: Ivan Shmakov Date: Sat, 31 Jan 2015 11:05:48 +0000 >>=20 >> [=85] >>=20 >> >>> Can we have a test suite for this file, >>=20 >> >> Which of the two? (Or three, to count the .tar file produced by >> >> $ git archive.) >>=20 >> > I meant tar-mode.el, and specifically where the new function is used. >>=20 >> ACK. How do I provide a sample .tar file to use in the test? > > Just add it to the repository, under test/automated/. >From what I can see, this patch was not applied?=20=20 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 16:54:00 2019 Received: (at 19481) by debbugs.gnu.org; 25 Jun 2019 20:54:00 +0000 Received: from localhost ([127.0.0.1]:33631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfsRu-0004wP-Rh for submit@debbugs.gnu.org; Tue, 25 Jun 2019 16:53:59 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfsRo-0004wA-JE for 19481@debbugs.gnu.org; Tue, 25 Jun 2019 16:53:53 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfsRj-0004HA-Ix for 19481@debbugs.gnu.org; Tue, 25 Jun 2019 22:53:46 +0200 From: Lars Ingebrigtsen To: 19481@debbugs.gnu.org Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> Date: Tue, 25 Jun 2019 22:53:43 +0200 In-Reply-To: <87386ri50z.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Sat, 31 Jan 2015 11:05:48 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ivan Shmakov writes: > >> * lisp/emacs-lisp/package.el (package-untar-buffer): Use > >> tar-header-extractable-p. > >> (package-tar-file-info): Consider the second file name in the > >> archive if the first one has no dir [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19481 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ivan Shmakov writes: > >> * lisp/emacs-lisp/package.el (package-untar-buffer): Use > >> tar-header-extractable-p. > >> (package-tar-file-info): Consider the second file name in the > >> archive if the first one has no directory component. > > > Thanks. > > > Can we have a test suite for this file, > > Which of the two? (Or three, to count the .tar file produced by > $ git archive.) > > > and in particular for these changes? > > I hope to come with a suitable addition for > test/automated/package-test.el shortly. Or do you suggest > adding a test suite for tar-mode as well? > > FTR, the two changes I suggest are not /inter/dependent, so I > intend to push them as two separate commits. (And I wonder if > eit makes sense to now file a separate Severity: wishlist bug > report for tar-header-extractable-p, so to provide a somewhat > extended background for the feature.) It doesn't look like these changes were applied -- are they still of interest, or is the pax_global_header entry not supported any more? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 13:36:01 2020 Received: (at 19481) by debbugs.gnu.org; 20 Jan 2020 18:36:01 +0000 Received: from localhost ([127.0.0.1]:46027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itbu0-00069D-GX for submit@debbugs.gnu.org; Mon, 20 Jan 2020 13:36:01 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itbtu-00068w-Ku for 19481@debbugs.gnu.org; Mon, 20 Jan 2020 13:35:55 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 065F7810E8; Mon, 20 Jan 2020 13:35:45 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 90C26803A8; Mon, 20 Jan 2020 13:35:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579545342; bh=p63drA/nbs7/5WmWPjYZ0EuMEPcPRgTcJwgyUg7ZTQk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z7jeXiytgvTLwlV+3KoaMrR+3I2ERtySFZjj36YVtt+JekbjrM5Wpv0a4Fp0u7E1r d40geUWpNpFIElKvLVJqzIIBYd5Scoulv9x8a0jPabrSmC6TGM9tW4a3foxrMkMPgh GEf1rwo/uIVk6cdrVgE5PrPPEyKkmnqvM+7PLhL0vszSfTGloX+WW817hZIQ4qSk1R tGhdXvOjmDog3NzWuEFhckvjBSVmegNQueRknS+kEyaIk5iIEXvKnA9UZPJs7CNODp zgOdLf0365UvJpp4EUDRboZAjwfvtUzUxlbrBnUXgmicYX5ODPztNHayIgC2kUKJK0 tT4MQfnxCAhpw== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C85B6120874; Mon, 20 Jan 2020 13:35:41 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 25 Jun 2019 22:53:43 +0200") Message-ID: References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 20 Jan 2020 13:35:29 -0500 MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > It doesn't look like these changes were applied -- are they still of > interest, or is the pax_global_header entry not supported any more? Yes, they are definitely still relevant and should be applied. I think they've not been applied simply because we were waiting for the tests. BTW, I do have some minor comment about the suggested patch: while I think the `filter` argument makes sense as a new feature for `tar-untar-buffer`, I'm not completely sure that exposing pax's internal details to this filter is a good idea. Part of the reason I'm not sure is because I'm not sufficiently familiar with the content of these "type 55" entries. But if it's used for extra metadata (or something like that), then it should be ignored by default rather than only if you pass an appropriate filter function. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 05:01:22 2020 Received: (at 19481) by debbugs.gnu.org; 13 Aug 2020 09:01:22 +0000 Received: from localhost ([127.0.0.1]:46839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k696q-0001IQ-SN for submit@debbugs.gnu.org; Thu, 13 Aug 2020 05:01:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k696p-0001Bp-9K for 19481@debbugs.gnu.org; Thu, 13 Aug 2020 05:01:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1LljVk9ss26v4534P0PIyjppkw34IwuzFcsFKEbz5A4=; b=N83YYWlFjpN63t/4xygyAgZ5mU 36mmoQtSrkfN8qagSkx0fWagj00x8ROtuyDtwGUJOdJkcRzNg3kxW4N0SMngNOrqctRff/DiFMHwG 2tj9DV38atli/Oz52/VP+GmEeB+cbd970A+SVIbXduJosCq3m3cVMsoLT/M5Wus2mZoc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k696f-0004Ga-57; Thu, 13 Aug 2020 11:01:08 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> Date: Thu, 13 Aug 2020 11:01:03 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 20 Jan 2020 13:35:29 -0500") Message-ID: <87lfiihqcw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> It doesn't look like these changes were applied -- are they still of >> interest, or is the pax_global_header entry not supported any more? > > Yes, they are definitely still relevant and should be [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> It doesn't look like these changes were applied -- are they still of >> interest, or is the pax_global_header entry not supported any more? > > Yes, they are definitely still relevant and should be applied. I think > they've not been applied simply because we were waiting for the tests. I think this was fixed in a different way in 2016 by Noam: (defun tar--describe-as-link (descriptor) (let ((link-p (tar-header-link-type descriptor))) (if link-p (cond ((eq link-p 5) "a directory") ((eq link-p 20) "a tar directory header") ((eq link-p 28) "a next has longname") ((eq link-p 29) "a multivolume-continuation") ((eq link-p 35) "a sparse entry") ((eq link-p 38) "a volume header") ((eq link-p 55) "a pax global extended header") ((eq link-p 72) "a pax extended header") (t "a link"))))) (defun tar--check-descriptor (descriptor) (let ((link-desc (tar--describe-as-link descriptor))) (when link-desc (error "This is %s, not a real file" link-desc)))) So tar-mode displays these headers like this: Hrw-rw-rw- root/root 52 pax_global_header drwxrwxr-x root/root 0 pax-test/ -rw-rw-r-- root/root 5 pax-test/foo Which isn't unreasonable... For reference, I've included a tar file that has one of these headers here. So is this still something that should be applied? If I read Ivan's patch correctly, it will make tar-mode just ignore those pax headers, which seems a bit heavy-handed... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no --=-=-= Content-Type: application/x-tar Content-Disposition: attachment; filename=pax-test.tar Content-Transfer-Encoding: base64 cGF4X2dsb2JhbF9oZWFkZXIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAwMDA2NjYAMDAwMDAw MAAwMDAwMDAwADAwMDAwMDAwMDY0ADEzNzE1MjAwMDIwADAwMTQ1MDAAZwAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB1c3RhcgAwMHJvb3QAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAcm9vdAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwMDAwMDAwADAwMDAw MDAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA1 MiBjb21tZW50PTYwYmU4YWExZTU0NTRkMGEwMGEzMWI0OTY0OTA3MGUwMDc3NDM3MWYKAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHBh eC10ZXN0LwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwMDAwNzc1ADAwMDAwMDAA MDAwMDAwMAAwMDAwMDAwMDAwMAAxMzcxNTIwMDAyMAAwMDEyNjExADUAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAdXN0YXIAMDByb290AAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAHJvb3QAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMDAwMDAwMAAwMDAwMDAw AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAcGF4 LXRlc3QvZm9vAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAwMDA2NjQAMDAwMDAwMAAw MDAwMDAwADAwMDAwMDAwMDA1ADEzNzE1MjAwMDIwADAwMTMzMTIAMAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB1c3RhcgAwMHJvb3QAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAcm9vdAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwMDAwMDAwADAwMDAwMDAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABCYXIu CgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA== --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 09:42:18 2020 Received: (at 19481) by debbugs.gnu.org; 19 Aug 2020 13:42:18 +0000 Received: from localhost ([127.0.0.1]:38625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8OM5-0003nN-3s for submit@debbugs.gnu.org; Wed, 19 Aug 2020 09:42:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8OM3-0003n4-EA for 19481@debbugs.gnu.org; Wed, 19 Aug 2020 09:42:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ni83HRboOgn8F8Smss0LDOodkt9au8P9jGqpBBgljSU=; b=vSUROgq6IH1M3cQ3bw5p5w84o1 zwR6B1uEPquxdgWJNs5RrXg+o7Ik4UMCcp3Xi1C3fy5xdsr/ioW2L3KMuiBI/nCzCDXROlQtY3oxf 3spueTvT6GEB6FRlCw+RD6aTZY8HZxj9a+f5t+Okx5hmbrZ31eVH7H1YlJ4HHL1thDbQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8OLt-0005Hk-Jc; Wed, 19 Aug 2020 15:42:08 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19481: package.el: support .tar archives featuring a pax_global_header entry References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> <87386ri50z.fsf_-_@violet.siamics.net> <87lfiihqcw.fsf@gnus.org> X-Now-Playing: Pixies's _Come On Pilgrim_: "Levitate Me" Date: Wed, 19 Aug 2020 15:42:04 +0200 In-Reply-To: <87lfiihqcw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 13 Aug 2020 11:01:03 +0200") Message-ID: <87364i4us3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I think this was fixed in a different way in 2016 by Noam: [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19481 Cc: 19481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I think this was fixed in a different way in 2016 by Noam: [...] > So tar-mode displays these headers like this: > > Hrw-rw-rw- root/root 52 pax_global_header > drwxrwxr-x root/root 0 pax-test/ > -rw-rw-r-- root/root 5 pax-test/foo > > Which isn't unreasonable... > > For reference, I've included a tar file that has one of these headers > here. > > So is this still something that should be applied? If I read Ivan's > patch correctly, it will make tar-mode just ignore those pax headers, > which seems a bit heavy-handed... There was no response to this, so I'm closing this bug report. If there is more to be fixed in this area, please respond and we'll reopen the bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 09:42:22 2020 Received: (at control) by debbugs.gnu.org; 19 Aug 2020 13:42:22 +0000 Received: from localhost ([127.0.0.1]:38628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8OMA-0003ne-1u for submit@debbugs.gnu.org; Wed, 19 Aug 2020 09:42:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8OM8-0003nC-PH for control@debbugs.gnu.org; Wed, 19 Aug 2020 09:42:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5kZwRSRVn75+3errucuYRGmXzJ4/fc+1zUZnaKNGEZA=; b=auY/MP+r61Gq3GEqmHZFvvcrPP CR2j0H7Wzm4p5EAJ9dYpabuQfEbsU2CyuMKQlbM96K9vrXWyl2pfhQoLlrk3Cp01SHEilN2Y5RHW/ XCohqH7Wxjfmt5wEFKx5avN6aAWAoHEy587TH2HZsq/q6m3mcvy0s8UFAc4Lmtg42Cd4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8OM1-0005Hz-1s for control@debbugs.gnu.org; Wed, 19 Aug 2020 15:42:15 +0200 Date: Wed, 19 Aug 2020 15:42:12 +0200 Message-Id: <871rk24urv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19481 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 19481 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 19481 quit From unknown Tue Aug 19 07:27:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Sep 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator