From unknown Sat Aug 16 21:20:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19469: minor nit: (sxml xpath) node-typeof? Resent-From: Matt Wette Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 30 Dec 2014 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19469 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 19469@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141990828414088 (code B ref -1); Tue, 30 Dec 2014 02:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Dec 2014 02:58:04 +0000 Received: from localhost ([127.0.0.1]:60622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5n0W-0003fA-GQ for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56304) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5n0T-0003eq-OI for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y5n0S-0007lD-NC for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5n0S-0007l9-Ko for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5n0R-0003dN-PR for bug-guile@gnu.org; Mon, 29 Dec 2014 21:58:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y5n0M-0007kf-PG for bug-guile@gnu.org; Mon, 29 Dec 2014 21:57:59 -0500 Received: from vms173025pub.verizon.net ([206.46.173.25]:12195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5n0M-0007kZ-KL for bug-guile@gnu.org; Mon, 29 Dec 2014 21:57:54 -0500 Received: from [192.168.2.127] ([71.108.232.238]) by vms173025.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPA id <0NHD00031HG0VC00@vms173025.mailsrvcs.net> for bug-guile@gnu.org; Mon, 29 Dec 2014 19:57:37 -0600 (CST) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=Ko/6AtSI c=1 sm=1 tr=0 a=XxAusKNOGYjrkNisIOG4pA==:117 a=kj9zAlcOel0A:10 a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10 a=A92cGCtB03wA:10 a=qoD9rm9Sq2bUhR-GdckA:9 a=CjuIK1q_8ugA:10 a=qsHlLoQpQ_YA:10 a=O5U5ifefRt0A:10 a=hUPKEAp_opYA:10 From: Matt Wette Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable Message-id: <1855DC0E-2E68-43F5-BD3E-B0835FB015DE@alumni.caltech.edu> Date: Mon, 29 Dec 2014 17:57:35 -0800 MIME-version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In guile-2.0.11 the following appears in sxml/xpath.scm: (define (node-typeof? crit) (lambda (node) (case crit ((*) (and (pair? node) (not (memq (car node) '(@ *PI*))))) ((*any*) #t) ((*text*) (string? node)) (else (and (pair? node) (eq? crit (car node)))) ))) Would it be more efficient to swap the "(lambda (node)" and "(case crit" = forms? Matt From unknown Sat Aug 16 21:20:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19469: minor nit: (sxml xpath) node-typeof? References: <1855DC0E-2E68-43F5-BD3E-B0835FB015DE@alumni.caltech.edu> In-Reply-To: <1855DC0E-2E68-43F5-BD3E-B0835FB015DE@alumni.caltech.edu> Resent-From: Matt Wette Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 09 Feb 2016 03:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19469 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 19469@debbugs.gnu.org Received: via spool by 19469-submit@debbugs.gnu.org id=B19469.145499032214942 (code B ref 19469); Tue, 09 Feb 2016 03:59:01 +0000 Received: (at 19469) by debbugs.gnu.org; 9 Feb 2016 03:58:42 +0000 Received: from localhost ([127.0.0.1]:60869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSzRq-0003sw-MU for submit@debbugs.gnu.org; Mon, 08 Feb 2016 22:58:42 -0500 Received: from mail.alumni.caltech.edu ([131.215.242.114]:23646) by debbugs.gnu.org with smtp (Exim 4.84) (envelope-from ) id 1aSzRp-0003sk-Ab for 19469@debbugs.gnu.org; Mon, 08 Feb 2016 22:58:41 -0500 Received: from [192.168.2.127] (pool-72-87-204-128.lsanca.dsl-w.verizon.net [72.87.204.128]) (Authenticated sender: mwette) by mail.alumni.caltech.edu (Postfix) with ESMTPSA id C1A1012004F for <19469@debbugs.gnu.org>; Mon, 8 Feb 2016 19:58:34 -0800 (PST) X-DKIM: Sendmail DKIM Filter v2.8.3 mail.alumni.caltech.edu C1A1012004F DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alumni.caltech.edu; s=enforce; t=1454990314; bh=/SC65YzOGs7uWAmhh0qCxZ40cUVE8GcEqt5zEd7PRKs=; h=From:Content-Type:Content-Transfer-Encoding:Subject:Message-Id: Date:To:Mime-Version; b=hNfiT5jTkQWcN859HB42VVZdtMi53HWTYeC4rk0Nbecxw64rSZOolTKnN6OBJgjsW /sreIAuOC57s82ko6/uoGqEnehI4UDdRu6TnXcKe0ADyMwnnBioQD27ZOu0NqJhPIG xM43PChj+wt60oEp0+YTAItr2Y4IzHDdfDljunYA= From: Matt Wette Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-Id: <4CF6A526-AD14-47C7-B8B0-1F72693DDDE6@alumni.caltech.edu> Date: Mon, 8 Feb 2016 19:58:34 -0800 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-MailScanner-Information-Alumni: X-Alumni-MailScanner-ID: C1A1012004F.A74B7 X-MailScanner-Alumni: No Virii found X-Spam-Status-Alumni: not spam, SpamAssassin (not cached, score=-1.1, required 5, ALL_TRUSTED -1.00, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10) X-MailScanner-From: mwette@alumni.caltech.edu X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) I recommend that this bug be closed. The current code is fine and = consistent with the rest of the module. =E2=80=94 Matt= From unknown Sat Aug 16 21:20:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Matt Wette Subject: bug#19469: closed (Re: bug#19469: minor nit: (sxml xpath) node-typeof?) Message-ID: References: <87r3bpq7mr.fsf@pobox.com> <1855DC0E-2E68-43F5-BD3E-B0835FB015DE@alumni.caltech.edu> X-Gnu-PR-Message: they-closed 19469 X-Gnu-PR-Package: guile Reply-To: 19469@debbugs.gnu.org Date: Wed, 22 Jun 2016 20:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1466628122-24538-1" This is a multi-part message in MIME format... ------------=_1466628122-24538-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19469: minor nit: (sxml xpath) node-typeof? which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19469@debbugs.gnu.org. --=20 19469: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19469 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1466628122-24538-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19469-done) by debbugs.gnu.org; 22 Jun 2016 20:41:12 +0000 Received: from localhost ([127.0.0.1]:51535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFoxU-0006Mh-4i for submit@debbugs.gnu.org; Wed, 22 Jun 2016 16:41:12 -0400 Received: from pb-sasl2.pobox.com ([64.147.108.67]:52843 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFoxT-0006MZ-25 for 19469-done@debbugs.gnu.org; Wed, 22 Jun 2016 16:41:11 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 8A92622137; Wed, 22 Jun 2016 16:41:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=1dNTDxcQfpv9 FcY8TiIPkKe6djM=; b=r1UKPRQIzUQVwB0AJVsneJO3WP9OkY8kxEQu076YtPvc mzfvgJ7PmeszD1bzonw4LN55Ozu5AF/DS6afaMOU2Ln1w5e/tc5VCmlZ9zCRYFzI EEt50ZqsAmKmPCVJTbuE+tx4FTtiZ5InyNNfj2WiZGusNkzeEBQtVNFBi7i2LKI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=S92Z0r kc1UkQXY2guMNtrrNdXn0674iGxee4LSqqswr5lnUWH0xW0eWrCyJBT2DzxWMH2A 1pdDAO4LRnbUXiNk1kMC+XukTbiyPQuOJzhQkqZIZCLHQgvh1R6wTiJ8axJ5ByB2 g7J2UD6Gruz5ZV3GUuaV+LdJTgYmbdFaxCp4o= Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 8367122136; Wed, 22 Jun 2016 16:41:09 -0400 (EDT) Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 93AA222135; Wed, 22 Jun 2016 16:41:08 -0400 (EDT) From: Andy Wingo To: Matt Wette Subject: Re: bug#19469: minor nit: (sxml xpath) node-typeof? References: <1855DC0E-2E68-43F5-BD3E-B0835FB015DE@alumni.caltech.edu> <4CF6A526-AD14-47C7-B8B0-1F72693DDDE6@alumni.caltech.edu> Date: Wed, 22 Jun 2016 22:41:00 +0200 In-Reply-To: <4CF6A526-AD14-47C7-B8B0-1F72693DDDE6@alumni.caltech.edu> (Matt Wette's message of "Mon, 8 Feb 2016 19:58:34 -0800") Message-ID: <87r3bpq7mr.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: A62B3C36-38B9-11E6-B080-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 19469-done Cc: 19469-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Tue 09 Feb 2016 04:58, Matt Wette writes: > I recommend that this bug be closed. The current code is fine and consis= tent with the rest of the module. =E2=80=94 Matt OK :) Patches accepted if there are improvements to make :) A ------------=_1466628122-24538-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Dec 2014 02:58:04 +0000 Received: from localhost ([127.0.0.1]:60622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5n0W-0003fA-GQ for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56304) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5n0T-0003eq-OI for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y5n0S-0007lD-NC for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5n0S-0007l9-Ko for submit@debbugs.gnu.org; Mon, 29 Dec 2014 21:58:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5n0R-0003dN-PR for bug-guile@gnu.org; Mon, 29 Dec 2014 21:58:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y5n0M-0007kf-PG for bug-guile@gnu.org; Mon, 29 Dec 2014 21:57:59 -0500 Received: from vms173025pub.verizon.net ([206.46.173.25]:12195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5n0M-0007kZ-KL for bug-guile@gnu.org; Mon, 29 Dec 2014 21:57:54 -0500 Received: from [192.168.2.127] ([71.108.232.238]) by vms173025.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPA id <0NHD00031HG0VC00@vms173025.mailsrvcs.net> for bug-guile@gnu.org; Mon, 29 Dec 2014 19:57:37 -0600 (CST) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=Ko/6AtSI c=1 sm=1 tr=0 a=XxAusKNOGYjrkNisIOG4pA==:117 a=kj9zAlcOel0A:10 a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10 a=A92cGCtB03wA:10 a=qoD9rm9Sq2bUhR-GdckA:9 a=CjuIK1q_8ugA:10 a=qsHlLoQpQ_YA:10 a=O5U5ifefRt0A:10 a=hUPKEAp_opYA:10 From: Matt Wette Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable Subject: minor nit: (sxml xpath) node-typeof? Message-id: <1855DC0E-2E68-43F5-BD3E-B0835FB015DE@alumni.caltech.edu> Date: Mon, 29 Dec 2014 17:57:35 -0800 To: bug-guile@gnu.org MIME-version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In guile-2.0.11 the following appears in sxml/xpath.scm: (define (node-typeof? crit) (lambda (node) (case crit ((*) (and (pair? node) (not (memq (car node) '(@ *PI*))))) ((*any*) #t) ((*text*) (string? node)) (else (and (pair? node) (eq? crit (car node)))) ))) Would it be more efficient to swap the "(lambda (node)" and "(case crit" = forms? Matt ------------=_1466628122-24538-1--