GNU bug report logs - #19460
25.0.50; help-function-arglist returns (&rest rest) for adviced functions

Previous Next

Package: emacs;

Reported by: Oleh Krehel <o.krehel <at> tue.nl>

Date: Sun, 28 Dec 2014 20:29:02 UTC

Severity: normal

Tags: fixed

Found in version 25.0.50

Fixed in version 26.1

Done: Noam Postavsky <npostavs <at> users.sourceforge.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19460 in the body.
You can then email your comments to 19460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#19460; Package emacs. (Sun, 28 Dec 2014 20:29:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Oleh Krehel <o.krehel <at> tue.nl>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 28 Dec 2014 20:29:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleh Krehel <o.krehel <at> tue.nl>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 help-function-arglist returns (&rest rest) for adviced functions
Date: Sun, 28 Dec 2014 21:28:48 +0100

Hello,

After a minimal config:

    (ido-mode)
    (require 'flx-ido)
    (setq ido-enable-flex-matching t)

`ido-read-internal' becomes advised by `flx'.
So now I get this:

    (help-function-arglist 'ido-read-internal t)
    ;; => (&rest rest)

instead of this:

    (help-function-arglist 'ido-read-internal t)
    ;; => (item prompt hist &optional default require-match initial)

I posted this question on StackOverflow and the answer was to use:

    (help-function-arglist
     (ad-get-orig-definition 'ido-read-internal))

However Stefan suggested in the comments that this could be a bug,
so I'm reporting it here.

regards,
Oleh
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19460; Package emacs. (Sat, 14 Oct 2017 23:26:01 GMT) Full text and rfc822 format available.

Message #8 received at 19460 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Oleh Krehel <o.krehel <at> tue.nl>
Cc: 19460 <at> debbugs.gnu.org
Subject: Re: bug#19460: 25.0.50;
 help-function-arglist returns (&rest rest) for adviced functions
Date: Sat, 14 Oct 2017 19:25:23 -0400

tags 19460 fixed
close 19460 26.1
quit

Oleh Krehel <o.krehel <at> tue.nl> writes:

> After a minimal config:
>
>     (ido-mode)
>     (require 'flx-ido)
>     (setq ido-enable-flex-matching t)
>
> `ido-read-internal' becomes advised by `flx'.
> So now I get this:
>
>     (help-function-arglist 'ido-read-internal t)
>     ;; => (&rest rest)
>
> instead of this:
>
>     (help-function-arglist 'ido-read-internal t)
>     ;; => (item prompt hist &optional default require-match initial)

This is fixed in emacs-26, by [1: 6e2d6d54e1], I believe.

[1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400
  * lisp/emacs-lisp/bytecomp.el: Fix bug#14860.
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6e2d6d54e1236216462c13655ea1fe573d9672e7
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> users.sourceforge.net> to control <at> debbugs.gnu.org. (Sat, 14 Oct 2017 23:26:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 26.1, send any further explanations to 19460 <at> debbugs.gnu.org and Oleh Krehel <o.krehel <at> tue.nl> Request was from Noam Postavsky <npostavs <at> users.sourceforge.net> to control <at> debbugs.gnu.org. (Sat, 14 Oct 2017 23:26:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 12 Nov 2017 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 263 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.