From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 26 20:11:23 2014 Received: (at submit) by debbugs.gnu.org; 27 Dec 2014 01:11:23 +0000 Received: from localhost ([127.0.0.1]:58492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4fuc-000565-JI for submit@debbugs.gnu.org; Fri, 26 Dec 2014 20:11:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53490) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4fua-00055w-56 for submit@debbugs.gnu.org; Fri, 26 Dec 2014 20:11:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4fuY-0004Fp-R4 for submit@debbugs.gnu.org; Fri, 26 Dec 2014 20:11:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4fuY-0004Fl-Ow for submit@debbugs.gnu.org; Fri, 26 Dec 2014 20:11:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4fuX-00075W-N7 for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 20:11:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4fuT-0004EQ-Kf for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 20:11:17 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:60999 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4fuT-0004Dq-Eo for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 20:11:13 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F3CDE30A2110F1 for ; Fri, 26 Dec 2014 17:11:09 -0800 (PST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 25.0.50; In vc-dir display file in other window Organization: LINKOV.NET Date: Sat, 27 Dec 2014 03:10:47 +0200 Message-ID: <87ppb5j3s8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This patch adds the standard keybinding `C-o' to vc-dir: diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index 54496b9..c90bf1c 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -169,6 +169,9 @@ (defvar vc-dir-menu-map (define-key map [ise] '(menu-item "Isearch Files..." vc-dir-isearch :help "Incremental search a string in the marked files")) + (define-key map [display] + '(menu-item "Display in Other Window" vc-dir-display-file + :help "Display the file on the current line, in another window")) (define-key map [open-other] '(menu-item "Open in Other Window" vc-dir-find-file-other-window :help "Find the file on the current line, in another window")) @@ -273,6 +276,7 @@ (defvar vc-dir-mode-map (define-key map "e" 'vc-dir-find-file) ; dired-mode compatibility (define-key map "\C-m" 'vc-dir-find-file) (define-key map "o" 'vc-dir-find-file-other-window) + (define-key map "\C-o" 'vc-dir-display-file) (define-key map "\C-c\C-c" 'vc-dir-kill-dir-status-process) (define-key map [down-mouse-3] 'vc-dir-menu) (define-key map [mouse-2] 'vc-dir-toggle-mark) @@ -755,6 +759,13 @@ (defun vc-dir-find-file-other-window (&optional event) (if event (posn-set-point (event-end event))) (find-file-other-window (vc-dir-current-file))) +(defun vc-dir-display-file (&optional event) + "Display the file on the current line, in another window." + (interactive (list last-nonmenu-event)) + (if event (posn-set-point (event-end event))) + (display-buffer (find-file-noselect (vc-dir-current-file)) + t)) + (defun vc-dir-isearch () "Search for a string through all marked buffers using Isearch." (interactive) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 27 03:46:38 2014 Received: (at 19450) by debbugs.gnu.org; 27 Dec 2014 08:46:38 +0000 Received: from localhost ([127.0.0.1]:58577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4n1C-0001Mm-Br for submit@debbugs.gnu.org; Sat, 27 Dec 2014 03:46:38 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:39904) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4n1A-0001Me-Jo for 19450@debbugs.gnu.org; Sat, 27 Dec 2014 03:46:37 -0500 Received: by mail-wi0-f174.google.com with SMTP id h11so18261072wiw.7 for <19450@debbugs.gnu.org>; Sat, 27 Dec 2014 00:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IDccPqio8ZsaCWqAicjkSzm6wDFFBGjeNURc3ZoAr4s=; b=q8LC/mrtvnBc5DJag2F3/SnJsZK4cUt4x1ftazJFq0jdT/jauF5sOwGMgLcHOhmwgj DpKfyYSTupAG37nqWgsvp8MM1+EzqhN8lqs489nsGHh7Dw9VgxSPFobScwEnc/dkWz5J 4FqfSGmk4u32gFN7qoqbvyJl60DfgqItE63buivPxBHhxY0L7VDv4EeMTQACd93gVu14 LxMDApfL29RDCGQxeXIT3gen943zRAcSbHKFJR2WCzJr/OHOI4N0okvNRnut721M8XhV 3PMuQ5GuMRogargEsmUpiDyBdgAiONTlV4WGoXRhZE9XczzDjFecI6uxotvLWRXRDxHu yymA== X-Received: by 10.194.77.38 with SMTP id p6mr78056479wjw.62.1419669995620; Sat, 27 Dec 2014 00:46:35 -0800 (PST) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id la10sm11628028wjc.36.2014.12.27.00.46.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Dec 2014 00:46:35 -0800 (PST) Message-ID: <549E71E6.5050702@yandex.ru> Date: Sat, 27 Dec 2014 10:46:30 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 MIME-Version: 1.0 To: Juri Linkov , 19450@debbugs.gnu.org Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window References: <87ppb5j3s8.fsf@mail.linkov.net> In-Reply-To: <87ppb5j3s8.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19450 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 12/27/2014 03:10 AM, Juri Linkov wrote: > +(defun vc-dir-display-file (&optional event) > + "Display the file on the current line, in another window." > + (interactive (list last-nonmenu-event)) > + (if event (posn-set-point (event-end event))) > + (display-buffer (find-file-noselect (vc-dir-current-file)) > + t)) Why not use `vc-dir-find-file-other-window'? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 27 19:56:27 2014 Received: (at 19450) by debbugs.gnu.org; 28 Dec 2014 00:56:27 +0000 Received: from localhost ([127.0.0.1]:59296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y529j-0004C9-3X for submit@debbugs.gnu.org; Sat, 27 Dec 2014 19:56:27 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:45973 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y529h-0004C1-JZ for 19450@debbugs.gnu.org; Sat, 27 Dec 2014 19:56:25 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7A629301991717; Sat, 27 Dec 2014 16:56:20 -0800 (PST) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window Organization: LINKOV.NET References: <87ppb5j3s8.fsf@mail.linkov.net> <549E71E6.5050702@yandex.ru> Date: Sun, 28 Dec 2014 02:55:59 +0200 In-Reply-To: <549E71E6.5050702@yandex.ru> (Dmitry Gutov's message of "Sat, 27 Dec 2014 10:46:30 +0200") Message-ID: <87iogwsicg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19450 Cc: 19450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> +(defun vc-dir-display-file (&optional event) >> + "Display the file on the current line, in another window." >> + (interactive (list last-nonmenu-event)) >> + (if event (posn-set-point (event-end event))) >> + (display-buffer (find-file-noselect (vc-dir-current-file)) >> + t)) > > Why not use `vc-dir-find-file-other-window'? `vc-dir-display-file' is intended to provide consistency with all other similar commands: dired-display-file occur-mode-display-occurrence Buffer-menu-switch-other-window ... From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 27 20:26:55 2014 Received: (at 19450) by debbugs.gnu.org; 28 Dec 2014 01:26:56 +0000 Received: from localhost ([127.0.0.1]:59316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y52dD-0006IS-Jy for submit@debbugs.gnu.org; Sat, 27 Dec 2014 20:26:55 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:38440) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y52dB-0006II-DO for 19450@debbugs.gnu.org; Sat, 27 Dec 2014 20:26:54 -0500 Received: by mail-wg0-f42.google.com with SMTP id k14so16738807wgh.29 for <19450@debbugs.gnu.org>; Sat, 27 Dec 2014 17:26:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lMlC+f/nzdeVyD4be53pc81tEaou8HK7583GY4/njws=; b=v3VMxwKcchcPWFjyTxjdeZaIdSIKUVrbW72ODNXsatJ7rqQrUkcoAhvRgcg5I0bfXO t/6J1v4Bp9CgPneiBko4Gsz7KDIOPTBgVs9se//VYTKq/+mb3SAHySMRLDXT7VQ6s0YS LSnnSI+vuQ9YlQpzMC8heZ/zADBbGc1R+DHdGiC2rJDLfZC8czfbEb5DvLUwTBeKwLUZ QRYNYuCthAaVkUBy9fwZO/2AyH4xE8XKuvDO1BbFLmAvo+70cmBgkPjl5r7Y+ttrasmC iIMYVP9DYSZfNoZHJ2QCUQxTpPSJyHholoWI03ekDVgRpFTONxlynLflML0lyhxDv0Dc 9/cg== X-Received: by 10.180.12.75 with SMTP id w11mr83535506wib.9.1419730012572; Sat, 27 Dec 2014 17:26:52 -0800 (PST) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id u3sm33451949wiw.24.2014.12.27.17.26.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Dec 2014 17:26:52 -0800 (PST) Message-ID: <549F5C54.7020501@yandex.ru> Date: Sun, 28 Dec 2014 03:26:44 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 MIME-Version: 1.0 To: Juri Linkov Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window References: <87ppb5j3s8.fsf@mail.linkov.net> <549E71E6.5050702@yandex.ru> <87iogwsicg.fsf@mail.linkov.net> In-Reply-To: <87iogwsicg.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19450 Cc: 19450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 12/28/2014 02:55 AM, Juri Linkov wrote: > `vc-dir-display-file' is intended to provide consistency with > all other similar commands: Ok, that makes sense. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 28 19:47:34 2014 Received: (at 19450-done) by debbugs.gnu.org; 29 Dec 2014 00:47:34 +0000 Received: from localhost ([127.0.0.1]:60003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5OUg-0006ZY-4k for submit@debbugs.gnu.org; Sun, 28 Dec 2014 19:47:34 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:38056 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5OUe-0006ZR-CU for 19450-done@debbugs.gnu.org; Sun, 28 Dec 2014 19:47:33 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 763FD3014E821F; Sun, 28 Dec 2014 16:47:30 -0800 (PST) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window Organization: LINKOV.NET References: <87ppb5j3s8.fsf@mail.linkov.net> <549E71E6.5050702@yandex.ru> <87iogwsicg.fsf@mail.linkov.net> <549F5C54.7020501@yandex.ru> Date: Mon, 29 Dec 2014 02:47:15 +0200 In-Reply-To: <549F5C54.7020501@yandex.ru> (Dmitry Gutov's message of "Sun, 28 Dec 2014 03:26:44 +0200") Message-ID: <87bnmni8oc.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19450-done Cc: 19450-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> `vc-dir-display-file' is intended to provide consistency with >> all other similar commands: > > Ok, that makes sense. So let it be. From unknown Mon Jun 23 04:15:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Jan 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator