GNU bug report logs - #19450
25.0.50; In vc-dir display file in other window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19450 in the body.
You can then email your comments to 19450 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; In vc-dir display file in other window
Date: Sat, 27 Dec 2014 03:10:47 +0200

This patch adds the standard keybinding `C-o' to vc-dir:

diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 54496b9..c90bf1c 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -169,6 +169,9 @@ (defvar vc-dir-menu-map
     (define-key map [ise]
       '(menu-item "Isearch Files..." vc-dir-isearch
 		  :help "Incremental search a string in the marked files"))
+    (define-key map [display]
+      '(menu-item "Display in Other Window" vc-dir-display-file
+		  :help "Display the file on the current line, in another window"))
     (define-key map [open-other]
       '(menu-item "Open in Other Window" vc-dir-find-file-other-window
 		  :help "Find the file on the current line, in another window"))
@@ -273,6 +276,7 @@ (defvar vc-dir-mode-map
     (define-key map "e" 'vc-dir-find-file) ; dired-mode compatibility
     (define-key map "\C-m" 'vc-dir-find-file)
     (define-key map "o" 'vc-dir-find-file-other-window)
+    (define-key map "\C-o" 'vc-dir-display-file)
     (define-key map "\C-c\C-c" 'vc-dir-kill-dir-status-process)
     (define-key map [down-mouse-3] 'vc-dir-menu)
     (define-key map [mouse-2] 'vc-dir-toggle-mark)
@@ -755,6 +759,13 @@ (defun vc-dir-find-file-other-window (&optional event)
   (if event (posn-set-point (event-end event)))
   (find-file-other-window (vc-dir-current-file)))
 
+(defun vc-dir-display-file (&optional event)
+  "Display the file on the current line, in another window."
+  (interactive (list last-nonmenu-event))
+  (if event (posn-set-point (event-end event)))
+  (display-buffer (find-file-noselect (vc-dir-current-file))
+		  t))
+
 (defun vc-dir-isearch ()
   "Search for a string through all marked buffers using Isearch."
   (interactive)

Message #8 received at 19450 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>, 19450 <at> debbugs.gnu.org
Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window
Date: Sat, 27 Dec 2014 10:46:30 +0200

On 12/27/2014 03:10 AM, Juri Linkov wrote:

> +(defun vc-dir-display-file (&optional event)
> +  "Display the file on the current line, in another window."
> +  (interactive (list last-nonmenu-event))
> +  (if event (posn-set-point (event-end event)))
> +  (display-buffer (find-file-noselect (vc-dir-current-file))
> +		  t))

Why not use `vc-dir-find-file-other-window'?

Message #11 received at 19450 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 19450 <at> debbugs.gnu.org
Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window
Date: Sun, 28 Dec 2014 02:55:59 +0200

>> +(defun vc-dir-display-file (&optional event)
>> +  "Display the file on the current line, in another window."
>> +  (interactive (list last-nonmenu-event))
>> +  (if event (posn-set-point (event-end event)))
>> +  (display-buffer (find-file-noselect (vc-dir-current-file))
>> +		  t))
>
> Why not use `vc-dir-find-file-other-window'?

`vc-dir-display-file' is intended to provide consistency with
all other similar commands:

dired-display-file
occur-mode-display-occurrence
Buffer-menu-switch-other-window
...

Message #14 received at 19450 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: 19450 <at> debbugs.gnu.org
Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window
Date: Sun, 28 Dec 2014 03:26:44 +0200

On 12/28/2014 02:55 AM, Juri Linkov wrote:

> `vc-dir-display-file' is intended to provide consistency with
> all other similar commands:

Ok, that makes sense.

Message #19 received at 19450-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 19450-done <at> debbugs.gnu.org
Subject: Re: bug#19450: 25.0.50; In vc-dir display file in other window
Date: Mon, 29 Dec 2014 02:47:15 +0200

>> `vc-dir-display-file' is intended to provide consistency with
>> all other similar commands:
>
> Ok, that makes sense.

So let it be.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.