From unknown Mon Jun 23 07:47:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19449 <19449@debbugs.gnu.org> To: bug#19449 <19449@debbugs.gnu.org> Subject: Status: 25.0.50; `auto-revert-tail-mode' tries to revert remote files even if `auto-revert-remote-files' is nil Reply-To: bug#19449 <19449@debbugs.gnu.org> Date: Mon, 23 Jun 2025 14:47:19 +0000 retitle 19449 25.0.50; `auto-revert-tail-mode' tries to revert remote files= even if `auto-revert-remote-files' is nil reassign 19449 emacs submitter 19449 Filipp Gunbin severity 19449 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 26 15:24:57 2014 Received: (at submit) by debbugs.gnu.org; 26 Dec 2014 20:24:58 +0000 Received: from localhost ([127.0.0.1]:58424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4bRR-0004ub-IE for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y4bRP-0004uT-WF for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4bRO-0004jv-ML for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRO-0004jq-JP for submit@debbugs.gnu.org; Fri, 26 Dec 2014 15:24:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRN-00062h-JE for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:24:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4bRK-0004jE-Bn for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:24:53 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4bRK-0004in-8P for bug-gnu-emacs@gnu.org; Fri, 26 Dec 2014 15:24:50 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3048020579 for ; Fri, 26 Dec 2014 15:24:48 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 26 Dec 2014 15:24:48 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type; s=mesmtp; bh=692cvaRKH/PrhL488myLeTSgJxA=; b=XlOz T1qRlleiFp43uC6q0BcaWkmxTR+kzEAc2bbm2L/w7lc/fElYjMoFiN/r8Z7GayJp 39bU1iDM7GC4rh6zEnbMOjRNXBd9WXIU72xijilB2zS0E25FKGEbPzzvJpY6d/Ur 9T5YCH6SC3f6Yg3J0Fi+X8wrlQsGb34r7w4o7p8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type; s=smtpout; bh=692cvaRKH/P rhL488myLeTSgJxA=; b=KmaMBKOxVL6yfR62TL40TXuXMaErNwND0Y7i+ydX/QH HvsykpcNYAXe4wVOa70g/X8TYD+WbJ9HOYKkCWn7eN0TT7PhgKteO7gnSkFB5qpN nSths0N+yptHJdwKyWGkSjqBgmA58CuEHLNWiIzSCn0By5TwkpcJyjkV7AwY0QOo = X-Sasl-enc: NiHo0h6NvYPO8qcN9yVgbRSgCp+hg4gvJhm/8jhuONf/ 1419625487 Received: from fgunbin.local (unknown [94.25.218.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 6A63AC00283 for ; Fri, 26 Dec 2014 15:24:47 -0500 (EST) From: Filipp Gunbin To: bug-gnu-emacs@gnu.org Subject: 25.0.50; `auto-revert-tail-mode' tries to revert remote files even if `auto-revert-remote-files' is nil Date: Fri, 26 Dec 2014 23:24:43 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Below is the suggested patch. Analysis: When the `auto-revert-tail-mode' is called it temporarily enables auto-revert-mode: (or auto-revert-mode (let ((auto-revert-tail-mode t)) (auto-revert-mode 1))) `auto-revert-mode' then calls `auto-revert-buffers' which in turn calls `auto-revert-handler' (fixed by the patch). Then, this code yielded t: + (and (or auto-revert-mode + global-auto-revert-non-file-buffers) which resulted as `revert' set to t. In the end, `(auto-revert-tail-handler size)' was evaluted with nil size. This produces error: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) auto-revert-tail-handler(nil) Fix: In `revert' value calculation, `or' is changed to `if'. The "then" clause applies to file-visiting buffers, this is where the result of `file-remote-p' is analyzed. The "else" clause case applies to non-file buffers. Ok to apply? Filipp diff --git a/lisp/autorevert.el b/lisp/autorevert.el index f1074e2..514dc2b 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -589,8 +589,8 @@ This is an internal function used by Auto-Revert Mode." ;; the values. (remote-file-name-inhibit-cache t) (revert - (or (and buffer-file-name - (or auto-revert-remote-files + (if buffer-file-name + (and (or auto-revert-remote-files (not (file-remote-p buffer-file-name))) (or (not auto-revert-use-notify) auto-revert-notify-modified-p) @@ -603,11 +603,11 @@ This is an internal function used by Auto-Revert Mode." (funcall (or buffer-stale-function #'buffer-stale--default-function) t))) - (and (or auto-revert-mode - global-auto-revert-non-file-buffers) - (funcall (or buffer-stale-function - #'buffer-stale--default-function) - t)))) + (and (or auto-revert-mode + global-auto-revert-non-file-buffers) + (funcall (or buffer-stale-function + #'buffer-stale--default-function) + t)))) eob eoblist) (setq auto-revert-notify-modified-p nil) (when revert From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 28 07:34:58 2014 Received: (at 19449) by debbugs.gnu.org; 28 Dec 2014 12:34:58 +0000 Received: from localhost ([127.0.0.1]:59454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5D3i-0000Uy-At for submit@debbugs.gnu.org; Sun, 28 Dec 2014 07:34:58 -0500 Received: from mout.gmx.net ([212.227.17.22]:52521) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5D3f-0000Uq-Kd for 19449@debbugs.gnu.org; Sun, 28 Dec 2014 07:34:56 -0500 Received: from detlef.gmx.de ([93.209.80.25]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Mcyxq-1YMBwW2EwE-00IFzU; Sun, 28 Dec 2014 13:34:51 +0100 From: Michael Albinus To: Filipp Gunbin Subject: Re: bug#19449: 25.0.50; `auto-revert-tail-mode' tries to revert remote files even if `auto-revert-remote-files' is nil References: Date: Sun, 28 Dec 2014 13:34:49 +0100 In-Reply-To: (Filipp Gunbin's message of "Fri, 26 Dec 2014 23:24:43 +0300") Message-ID: <87iogw3qc6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:86xucUuxzhTM1KzI7FatgBoek2/QpC9DL1ROV8GxaXA9R5xZvQR 0eRNDCaX3bh942x1+YGS2U5PSo3ycUuBPQfYX+K0eb80lMzApuAfGj7fEIHZ88hpLezWcL3 9tnRejTTTGm6bFIp7lRlV9NChyepuKZsCfVoyYPcxPU/iDzesmnDhw8k3M1VGYZNlAH6+65 w75iuI97a6CoLTqse+CLg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19449 Cc: 19449@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Filipp Gunbin writes: > Fix: > > In `revert' value calculation, `or' is changed to `if'. The "then" > clause applies to file-visiting buffers, this is where the result of > `file-remote-p' is analyzed. The "else" clause case applies to non-file > buffers. > > Ok to apply? Looks good to me. Please apply, preferred to the emacs-24 branch. > Filipp Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 29 10:36:19 2014 Received: (at 19449-done) by debbugs.gnu.org; 29 Dec 2014 15:36:20 +0000 Received: from localhost ([127.0.0.1]:60406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5cMl-00014A-Lb for submit@debbugs.gnu.org; Mon, 29 Dec 2014 10:36:19 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37879) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5cMi-000141-OD for 19449-done@debbugs.gnu.org; Mon, 29 Dec 2014 10:36:17 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D11AC20765 for <19449-done@debbugs.gnu.org>; Mon, 29 Dec 2014 10:36:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Mon, 29 Dec 2014 10:36:15 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.fm; h= x-sasl-enc:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=PyMI3dI+06YN xh0FIFAEqTYxqPw=; b=mn7ukDO3cLGtSmmV8z5j6Szgw1Gi54wIqEKal2AKwU4R r0sW6e0h4z3bokYmCNovaEUUcaRIzMeM45Re8J0lVVLXNgRG0Jga1jVp1dlPHe78 YqHWm8FGHsLDa5c54kMWaJfl7SPMbl9SiBcf6OpZo7vu1u5RZT93V/yTJwS4O3o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=PyMI3dI+06YNxh0FIFAEqTYxqPw=; b=VkIKKwNOpezth7HaGaWp F7kQ00DsyX9qZLTvSjy9hQ3wl8lI9Cdlub2rMcv8/xxAL5NyCIbWxftek1V4W0vU 66JDM/i6JkOumpUVp2JZLDQSLCS3jt0pPUDk/4saCQ+U02KiRCYUlMWG6/yykWRu 9ZAU2d6vilV+s9BkqCc1l9o= X-Sasl-enc: yqYou734Mv3SxvCg8Oc6HRX3kByiN+cqTuywRNcex/Dy 1419867375 Received: from fgunbin.local (unknown [94.25.218.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FD6BC0027F; Mon, 29 Dec 2014 10:36:15 -0500 (EST) From: Filipp Gunbin To: Michael Albinus Subject: Re: bug#19449: 25.0.50; `auto-revert-tail-mode' tries to revert remote files even if `auto-revert-remote-files' is nil References: <87iogw3qc6.fsf@gmx.de> Date: Mon, 29 Dec 2014 18:36:12 +0300 In-Reply-To: <87iogw3qc6.fsf@gmx.de> (Michael Albinus's message of "Sun, 28 Dec 2014 13:34:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19449-done Cc: 19449-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 28/12/2014 13:34 +0100, Michael Albinus wrote: > Filipp Gunbin writes: > >> Fix: >> >> In `revert' value calculation, `or' is changed to `if'. The "then" >> clause applies to file-visiting buffers, this is where the result of >> `file-remote-p' is analyzed. The "else" clause case applies to non-file >> buffers. >> >> Ok to apply? > > Looks good to me. Please apply, preferred to the emacs-24 branch. Applied to emacs-24, thanks. Sorry for excessive duplication in the commit message. Filipp From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 29 10:58:23 2014 Received: (at 19449) by debbugs.gnu.org; 29 Dec 2014 15:58:23 +0000 Received: from localhost ([127.0.0.1]:60428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5ci6-0001hG-P8 for submit@debbugs.gnu.org; Mon, 29 Dec 2014 10:58:22 -0500 Received: from mout.gmx.net ([212.227.15.19]:58773) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5ci3-0001h7-Mh for 19449@debbugs.gnu.org; Mon, 29 Dec 2014 10:58:20 -0500 Received: from detlef.gmx.de ([87.146.54.37]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Mb7pT-1YPcQr1FwB-00KgYq; Mon, 29 Dec 2014 16:58:18 +0100 From: Michael Albinus To: Filipp Gunbin Subject: Re: bug#19449: 25.0.50; `auto-revert-tail-mode' tries to revert remote files even if `auto-revert-remote-files' is nil References: <87iogw3qc6.fsf@gmx.de> Date: Mon, 29 Dec 2014 16:58:17 +0100 In-Reply-To: (Filipp Gunbin's message of "Mon, 29 Dec 2014 18:36:12 +0300") Message-ID: <87iogua1nq.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:n3cDuK6+PVashm+raRuNfDSGN3TVKKsi/L9njljwxcJgg2O7wQg pj8zMSps95OoUnwkoLeeUDPKhm1xR5cSwJovLBUXQh9kCIicJAFeC3Ffi1sISwAlJIUL3Ch 23YtwpM7xj1qcZUq4o68rmOZCPqIJCr4lwlQ8ZHP+SmE3OBH0UtAd7+ae51gVMRSIoJ31M1 ns8yqI3dp5SMxup3+foCg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19449 Cc: 19449@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Filipp Gunbin writes: > Applied to emacs-24, thanks. Thanks! > Filipp Best regards, Michael. From unknown Mon Jun 23 07:47:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Jan 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator