GNU bug report logs - #19423
25.0.50; incompatible change to `make-obsolete' - added 3rd arg should be optional

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19423: closed (25.0.50; incompatible change to
 `make-obsolete' - added 3rd arg should be optional)
Date: Sun, 21 Dec 2014 18:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 21 Dec 2014 20:53:02 +0200
with message-id <867fxkdecx.fsf <at> yandex.ru>
and subject line Re: bug#19423: 25.0.50; incompatible change to `make-obsolete' - added 3rd arg should be optional
has caused the debbugs.gnu.org bug report #19423,
regarding 25.0.50; incompatible change to `make-obsolete' - added 3rd arg should be optional
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19423: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19423
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; incompatible change to `make-obsolete' - added 3rd arg
 should be optional
Date: Sun, 21 Dec 2014 09:14:28 -0800 (PST)

This change, made long ago unfortunately, is incompatible.  Previous to
the change, `make-obsolete' accepted only 2 args.  It should still be
possible to use the function with only 2 args, as well as with 3.

This was presumably a careless oversight, and not intended as part of
the change to adding parameter WHEN.  The doc string in fact indicates
that this was not intended:

  If provided, WHEN should be a string indicating when the function
  ^^^^^^^^^^^
  was first made obsolete, for example a date or a release number.


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm <at> gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 19423-done <at> debbugs.gnu.org
Subject: Re: bug#19423: 25.0.50;
 incompatible change to `make-obsolete' - added 3rd arg should be
 optional
Date: Sun, 21 Dec 2014 20:53:02 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> In Emacs 23 someone unwisely changed it to mandatory, an
> incompatible change that gratuitously breaks code that could
> be used with older Emacs releases.  Pain for no real gain.

You should look at the code sometimes.

The change is very much compatible: `make-obsolete' can still be called
with only two arguments without error.  The third one is only mandatory
in the advertised calling convention.

Even if it wasn't, it would be too late to fix the "problem": it
wouldn't work in 23 and 24 anyway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.