From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 19 06:32:13 2014 Received: (at submit) by debbugs.gnu.org; 19 Dec 2014 11:32:13 +0000 Received: from localhost ([127.0.0.1]:50859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y1vn2-0002ZT-FC for submit@debbugs.gnu.org; Fri, 19 Dec 2014 06:32:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58249) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y1vn0-0002ZK-K3 for submit@debbugs.gnu.org; Fri, 19 Dec 2014 06:32:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1vmw-0007WI-4D for submit@debbugs.gnu.org; Fri, 19 Dec 2014 06:32:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1vmw-0007WE-1e for submit@debbugs.gnu.org; Fri, 19 Dec 2014 06:32:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1vmr-0005Gg-PJ for bug-gnu-emacs@gnu.org; Fri, 19 Dec 2014 06:32:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1vml-0007RP-PG for bug-gnu-emacs@gnu.org; Fri, 19 Dec 2014 06:32:01 -0500 Received: from samertm.com ([162.243.37.26]:36045 helo=mail.samertm.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1vml-0007Nv-Mj for bug-gnu-emacs@gnu.org; Fri, 19 Dec 2014 06:31:55 -0500 Received: from samertm.com (localhost [127.0.0.1]) by mail.samertm.com (Postfix) with ESMTP id 693E580904; Fri, 19 Dec 2014 11:31:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Dec 2014 03:31:12 -0800 From: samer To: bug-gnu-emacs@gnu.org, dylan@hardison.net Subject: Re: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion Message-ID: <02ec0b96564b9f98529b94bcc922a724@samertm.com> X-Sender: samer@samertm.com User-Agent: Roundcube Webmail/0.9.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The issue is that the subcommand requests a target for the symbol 'eshell-temp', but eshell-get-target returns the point marker for a buffer named 'eshell-temp' instead of setting 'eshell-temp's value to nil and returning the symbol. That's because eshell-get-target can't tell the difference between a symbol and a buffer when eshell-buffer-shorthand is set, so it assumes that every symbol is a buffer. We could treat 'eshell-temp' similarly to 't and 'nil by ignoring this branch if the name of the symbol is 'eshell-temp', but I'm 90% sure that eshell-buffer-shorthand doesn't work anyways and it's probably better to remove it (notice that the examples in the docstring for eshell-buffer-shorthand don't work). Also, I've submitted a patch for the issue regarding external subcommands having no output on bug #12680. Best, Samer Patch below: 2 files changed, 17 insertions(+), 28 deletions(-) lisp/ChangeLog | 10 ++++++++++ lisp/eshell/esh-io.el | 35 +++++++---------------------------- Modified lisp/ChangeLog diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 45ba279..9aec808 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,13 @@ +2014-12-19 Samer Masterson + + * eshell/esh-io.el (eshell-get-target, eshell-buffer-shorthand): + Remove eshell-buffer-shorthand (bug#19391). + 2014-11-28 Martin Rudalics Fix two issues around help-window-select. (Bug#11039) (Bug#19012) Modified lisp/eshell/esh-io.el diff --git a/lisp/eshell/esh-io.el b/lisp/eshell/esh-io.el index ebbca58..3f70f48 100644 --- a/lisp/eshell/esh-io.el +++ b/lisp/eshell/esh-io.el @@ -98,19 +98,6 @@ other buffers) ." :type 'integer :group 'eshell-io) -(defcustom eshell-buffer-shorthand nil - "If non-nil, a symbol name can be used for a buffer in redirection. -If nil, redirecting to a buffer requires buffer name syntax. If this -variable is set, redirection directly to Lisp symbols will be -impossible. - -Example: - - echo hello > '*scratch* ; works if `eshell-buffer-shorthand' is t - echo hello > # ; always works" - :type 'boolean - :group 'eshell-io) - (defcustom eshell-print-queue-size 5 "The size of the print queue, for doing buffered printing. This is basically a speed enhancement, to avoid blocking the Lisp code @@ -355,21 +342,13 @@ it defaults to `insert'." (goto-char (point-max)))) (point-marker)))))) - ((or (bufferp target) - (and (boundp 'eshell-buffer-shorthand) - (symbol-value 'eshell-buffer-shorthand) - (symbolp target) - (not (memq target '(t nil))))) - (let ((buf (if (bufferp target) - target - (get-buffer-create - (symbol-name target))))) - (with-current-buffer buf - (cond ((eq mode 'overwrite) - (erase-buffer)) - ((eq mode 'append) - (goto-char (point-max)))) - (point-marker)))) + ((bufferp target) + (with-current-buffer target + (cond ((eq mode 'overwrite) + (erase-buffer)) + ((eq mode 'append) + (goto-char (point-max)))) + (point-marker))) ((functionp target) nil) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 19 06:48:33 2014 Received: (at 19410) by debbugs.gnu.org; 19 Dec 2014 11:48:33 +0000 Received: from localhost ([127.0.0.1]:50865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y1w2r-0004L9-59 for submit@debbugs.gnu.org; Fri, 19 Dec 2014 06:48:33 -0500 Received: from samertm.com ([162.243.37.26]:49032 helo=mail.samertm.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y1w2n-0004Kz-DA for 19410@debbugs.gnu.org; Fri, 19 Dec 2014 06:48:29 -0500 Received: from samertm.com (localhost [127.0.0.1]) by mail.samertm.com (Postfix) with ESMTP id AABC680904 for <19410@debbugs.gnu.org>; Fri, 19 Dec 2014 11:48:08 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Dec 2014 03:48:08 -0800 From: samer To: 19410@debbugs.gnu.org Subject: Re: bug#19410: Acknowledgement ([PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion) In-Reply-To: References: <02ec0b96564b9f98529b94bcc922a724@samertm.com> Message-ID: <5aaa1396289235773d4af11dbe4de0cf@samertm.com> X-Sender: samer@samertm.com User-Agent: Roundcube Webmail/0.9.5 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19410 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Heh, this is a patch for bug#19391, not a new bug. That was a dumb mistake :) -samer From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 19 11:58:38 2014 Received: (at control) by debbugs.gnu.org; 19 Dec 2014 16:58:38 +0000 Received: from localhost ([127.0.0.1]:51710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y20sw-0006UG-FI for submit@debbugs.gnu.org; Fri, 19 Dec 2014 11:58:38 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:35928) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y20su-0006U9-F4 for control@debbugs.gnu.org; Fri, 19 Dec 2014 11:58:36 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Y20st-0002Xl-TX for control@debbugs.gnu.org; Fri, 19 Dec 2014 11:58:36 -0500 Date: Fri, 19 Dec 2014 11:58:35 -0500 Message-Id: Subject: control message for bug 19410 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 19391 19410 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 21:42:54 2017 Received: (at control) by debbugs.gnu.org; 27 Nov 2017 02:42:54 +0000 Received: from localhost ([127.0.0.1]:59841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Nm-0007P5-7K for submit@debbugs.gnu.org; Sun, 26 Nov 2017 21:42:54 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:45565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Nl-0007Oo-54; Sun, 26 Nov 2017 21:42:53 -0500 Received: by mail-io0-f169.google.com with SMTP id z74so34717957iof.12; Sun, 26 Nov 2017 18:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SLg+QzeOfFtW30YPJARrjr1qaDtMKjKNIIn8RsGOsnw=; b=a6EVda13/C1VLelzPU4YsAgFwBUnhuqr21V64eSqGwiUshSEst7ooLDc8jPmEMHJ6i gPMCf7msAzD4TqW8bAbPoOdx8nZJIt/s/b6LV0moX3DrTOPiDUUBsmqww4wnELz/7qUe kQAmnZC4Axk1ulKeaRHZ3oxSlkwjUJBpEpyV+AVSPpcs8hA/ZvPSDc2v40uwjk4TJIv9 SQ7XEk+VN7wvfYIqwGX1Hc5TjfrueYD+0n15f5EpN8fR0ELemLPkjfBTOiSa0yaAkibg xZ6XFd+KV5qDm6SeWXpPXFgAiO8R4ph6fFdnSNL8YOqD+WpGdCre5eWLCPorJch0AG3E 1aZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=SLg+QzeOfFtW30YPJARrjr1qaDtMKjKNIIn8RsGOsnw=; b=q6DGZsUq5TXOMO+vu95Vgjgy9WlJlxw2ZEfkS5hNb2cZEmSlcZb0LkQhkOHjlGfYxs fTBVZBj40wdErsMib0DVvWGDz2QPCNjPXsuD0XpjnGhnE2H+Gv/zuBPXak4Ik5Qg2I1b GZNQCdL3C9LAZ+dzLkS2xII8/gMWpj8MrBN+Fp+9G7I7OcT3kJWac6XyiFHl4O5ehcPT uAWMZbycm+0RrqCwGaG7pe06bHtMawOyC7Ut7Yff9H2iOtGO9AYn0lSI7fN8HWHJoMSg IcJ0W3DOLnWnx7DLrtRNP+3BlwI7tWqiG8//u14++n/hvIQF+vxqWyj0W7lmsEIqhF0O LRgQ== X-Gm-Message-State: AJaThX55Lwp73YKWotToM3yaqySqieTSUAPiAaBQQmOIV9HyPYQ1IFPv 6M40hjW/X3iSefqEPHCWOQMQ9w== X-Google-Smtp-Source: AGs4zMYeJjBWy6+3PtnewGb4kgh9lt4X35Qu1oR3GZoTOKzxKMmoaIBsc1T6WuYI40dghW2b6T1JKw== X-Received: by 10.107.183.77 with SMTP id h74mr42775807iof.0.1511750567257; Sun, 26 Nov 2017 18:42:47 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i133sm9375009itf.1.2017.11.26.18.42.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Nov 2017 18:42:46 -0800 (PST) From: Noam Postavsky To: Samer Masterson Subject: Re: bug#19391: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion References: <1424775586.11596.7@mail.samertm.com> <83a8zuqdle.fsf@gnu.org> <1425455434.1450.1@mail.samertm.com> Date: Sun, 26 Nov 2017 21:42:45 -0500 In-Reply-To: <1425455434.1450.1@mail.samertm.com> (Samer Masterson's message of "Tue, 03 Mar 2015 23:50:34 -0800") Message-ID: <87a7z8o316.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , 19391@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) tags 19391 fixed close 19391 25.1 quit Samer Masterson writes: > - The syntax for the shorthand should be distinct from any other > lisp objects, so that we don't have to put out fires when people try > to do things that are valid but overlap with the shorthand (e.g. this > bug was caused by eshell's external shell feature redirecting to a > symbol.) Something like # would work. > - The shorthand should be processed as a buffer (similar to how # > is processed). That means the shorthand won't > require extra code anywhere except for the reader. > - The shorthand should be on by default, and probably shouldn't have > an option to disable it. The reason for this is that the shorthand > would be universally beneficial and backwards compatible, and making > it controlled by an option is inviting bugs when we shouldn't be. Something along these lines was pushed for Emacs 25. [1: e37da5a4a8]: 2015-05-17 14:28:51 -0700 eshell: Introduce new buffer syntax https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e37da5a4a8055826f0fc1051083495a828509672> From unknown Mon Aug 18 07:45:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator