From unknown Sat Sep 06 06:36:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19391 <19391@debbugs.gnu.org> To: bug#19391 <19391@debbugs.gnu.org> Subject: Status: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion Reply-To: bug#19391 <19391@debbugs.gnu.org> Date: Sat, 06 Sep 2025 13:36:02 +0000 retitle 19391 25.0.50; eshell-buffer-shorthand breaks command dollar expans= ion reassign 19391 emacs submitter 19391 dylan@hardison.net severity 19391 normal tag 19391 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 15 23:40:30 2014 Received: (at submit) by debbugs.gnu.org; 16 Dec 2014 04:40:30 +0000 Received: from localhost ([127.0.0.1]:47351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0jvx-0001pF-BC for submit@debbugs.gnu.org; Mon, 15 Dec 2014 23:40:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50887) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0jrG-0001hl-F5 for submit@debbugs.gnu.org; Mon, 15 Dec 2014 23:35:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0jrA-0008Gt-3w for submit@debbugs.gnu.org; Mon, 15 Dec 2014 23:35:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0jr9-0008Gp-Sy for submit@debbugs.gnu.org; Mon, 15 Dec 2014 23:35:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0jr4-0002AD-8h for bug-gnu-emacs@gnu.org; Mon, 15 Dec 2014 23:35:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0jqy-0008DH-Be for bug-gnu-emacs@gnu.org; Mon, 15 Dec 2014 23:35:26 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0jqy-0008CV-45 for bug-gnu-emacs@gnu.org; Mon, 15 Dec 2014 23:35:20 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8694220706 for ; Mon, 15 Dec 2014 23:35:18 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Mon, 15 Dec 2014 23:35:18 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=hardison.net; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type; s=mesmtp; bh=MoPK3jYbNjKgalzj/1Y1JG5ABsE=; b=L5wo NcBenin6AJauKmCRJuH2pMvTC/gM2ixtqP8+/n/uGsVGBjrVusW9/CYnQJfO5aia h+c1DIASdbcSoCkS59VpBQz8XTBY2MeMO00pa4sTP/hgubV7kCKoRJsslRFM3hDT 3TDuhe7YuLWYtbOOsS8LwL7PZkJpoPqs28gB+rY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type; s=smtpout; bh=MoPK3jYbNjK galzj/1Y1JG5ABsE=; b=V/7WiIsD+VAMezcLSK98Q9DIGpgOrrfvEQjw8AjDl85 V6BrGHTODKq0DZRAxJMRUiQt+nNV5eJAHDkFii7kfqXjoOYjqg2Bb23xaLbQmL9N mI0dLzTDvLip1V9Ll7VmMUnWv3IIJDrC9qA8RljZdAXwE2Ra5xMRbuv0JZgpbrzY = X-Sasl-enc: r+NAQeGCIo/7NoIgScR57Lzt28NxB9kFDvejVqeUdS1A 1418704518 Received: from thor.god (unknown [96.58.191.108]) by mail.messagingengine.com (Postfix) with ESMTPA id 29BBF680105 for ; Mon, 15 Dec 2014 23:35:18 -0500 (EST) From: dylan@hardison.net To: bug-gnu-emacs@gnu.org Subject: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion Date: Mon, 15 Dec 2014 23:35:43 -0500 Message-ID: <87iohcw6sg.fsf@thor.god> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 15 Dec 2014 23:40:27 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Soemthing is wrong with dollar expansion on commands (${foo}). It seems to break if eshell-buffer-shorthand on, and also ${command} when command is a shell command seems to get lost... M-x eshell RET ~ $ (setq eshell-buffer-shorthand t) t ~ $ echo ${uptime} Symbol's value as variable is void: eshell-temp ~ $ echo ${emacs-uptime} Symbol's value as variable is void: eshell-temp ~ $ (setq eshell-buffer-shorthand nil) nil ~ $ echo ${uptime} # no output! ~ $ echo ${emacs-uptime} 4 minutes, 39 seconds In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5) of 2014-12-15 on thor Repository revision: 872617ad730906f9437b90c3b90af2e2458f00f6 Windowing system distributor `The X.Org Foundation', version 11.0.11602000 Configured using: `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --pdfdir=/usr/share/doc/emacs/pdf --with-sound=alsa --without-gconf --with-x-toolkit=gtk3 --with-xft 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB Important settings: value of $LC_COLLATE: POSIX value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: EShell Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent messages: Loading em-unix...done History item: 17 History item: 16 History item: 15 History item: 14 History item: 13 History item: 12 delete-backward-char: Text is read-only Sole completion Partially completed Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message idna dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils em-unix em-term term disp-table easymenu ehelp em-script em-prompt em-ls cl-loaddefs cl-lib em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias pcomplete comint ansi-color ring esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 95819 8904) (symbols 48 20003 0) (miscs 40 99 168) (strings 32 17152 4610) (string-bytes 1 527657) (vectors 16 12478) (vector-slots 8 417838 5964) (floats 8 77 97) (intervals 56 322 11) (buffers 976 14) (heap 1024 43589 956)) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 19 11:58:38 2014 Received: (at control) by debbugs.gnu.org; 19 Dec 2014 16:58:38 +0000 Received: from localhost ([127.0.0.1]:51710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y20sw-0006UG-FI for submit@debbugs.gnu.org; Fri, 19 Dec 2014 11:58:38 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:35928) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y20su-0006U9-F4 for control@debbugs.gnu.org; Fri, 19 Dec 2014 11:58:36 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Y20st-0002Xl-TX for control@debbugs.gnu.org; Fri, 19 Dec 2014 11:58:36 -0500 Date: Fri, 19 Dec 2014 11:58:35 -0500 Message-Id: Subject: control message for bug 19410 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 19391 19410 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 06:00:07 2015 Received: (at 19391) by debbugs.gnu.org; 24 Feb 2015 11:00:07 +0000 Received: from localhost ([127.0.0.1]:56318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQDDe-0003Nu-Jf for submit@debbugs.gnu.org; Tue, 24 Feb 2015 06:00:07 -0500 Received: from ec2-52-0-7-12.compute-1.amazonaws.com ([52.0.7.12]:60152 helo=samertm.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQDDb-0003NI-H8 for 19391@debbugs.gnu.org; Tue, 24 Feb 2015 06:00:00 -0500 Received: from [10.1.10.35] (c-98-210-154-226.hsd1.ca.comcast.net [98.210.154.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by samertm.com (Postfix) with ESMTPSA id 3366F42D27 for <19391@debbugs.gnu.org>; Tue, 24 Feb 2015 10:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samertm.com; s=mail; t=1424775586; bh=TpSCVTT6XlFL0//qMeoeqNmkGrwjdeT7nk2mpE7vdYM=; h=Date:From:Subject:To:From; b=i2KUKzDHAlJjjzNfReeQ1UCP4jVwfu4s2lvPyCzvXRL43IAc4Ows/I5VjM8GNlUk+ A3GKecW+tJK4fBwAR9r45k14VZCM6oKM4ognBKikE2SctJNuE00jOZHGftfqledU7J 9qOa01aYiedbI/a2fJ3hCI0KFbGHY4P8uqXfSLhE= Date: Tue, 24 Feb 2015 02:59:46 -0800 From: Samer Masterson Subject: Re: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion To: 19391@debbugs.gnu.org Message-Id: <1424775586.11596.7@mail.samertm.com> X-Mailer: geary/0.8.3 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-JfiPypyZP1JRlndJ5veR" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 19391 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --=-JfiPypyZP1JRlndJ5veR Content-Type: text/plain; charset=utf-8; format=flowed Hi, My copyright papers have been processed. Can we apply this to master? Best, Samer 2 files changed, 17 insertions(+), 28 deletions(-) lisp/ChangeLog | 10 ++++++++++ lisp/eshell/esh-io.el | 35 +++++++---------------------------- Modified lisp/ChangeLog diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 45ba279..9aec808 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,13 @@ +2014-12-19 Samer Masterson samertm.com> + + * eshell/esh-io.el (eshell-get-target, eshell-buffer-shorthand): + Remove eshell-buffer-shorthand (bug#19391). + 2014-11-28 Martin Rudalics gmx.at> Fix two issues around help-window-select. (Bug#11039) (Bug#19012) Modified lisp/eshell/esh-io.el diff --git a/lisp/eshell/esh-io.el b/lisp/eshell/esh-io.el index ebbca58..3f70f48 100644 --- a/lisp/eshell/esh-io.el +++ b/lisp/eshell/esh-io.el @@ -98,19 +98,6 @@ other buffers) ." :type 'integer :group 'eshell-io) -(defcustom eshell-buffer-shorthand nil - "If non-nil, a symbol name can be used for a buffer in redirection. -If nil, redirecting to a buffer requires buffer name syntax. If this -variable is set, redirection directly to Lisp symbols will be -impossible. - -Example: - - echo hello > '*scratch* ; works if `eshell-buffer-shorthand' is t - echo hello > # ; always works" - :type 'boolean - :group 'eshell-io) - (defcustom eshell-print-queue-size 5 "The size of the print queue, for doing buffered printing. This is basically a speed enhancement, to avoid blocking the Lisp code @@ -355,21 +342,13 @@ it defaults to `insert'." (goto-char (point-max)))) (point-marker)))))) - ((or (bufferp target) - (and (boundp 'eshell-buffer-shorthand) - (symbol-value 'eshell-buffer-shorthand) - (symbolp target) - (not (memq target '(t nil))))) - (let ((buf (if (bufferp target) - target - (get-buffer-create - (symbol-name target))))) - (with-current-buffer buf - (cond ((eq mode 'overwrite) - (erase-buffer)) - ((eq mode 'append) - (goto-char (point-max)))) - (point-marker)))) + ((bufferp target) + (with-current-buffer target + (cond ((eq mode 'overwrite) + (erase-buffer)) + ((eq mode 'append) + (goto-char (point-max)))) + (point-marker))) ((functionp target) nil) --=-JfiPypyZP1JRlndJ5veR Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi,

My copyright papers have been processed. = Can we apply this to master?

Best,
Samer=

2 files changed, 17 insertions(+), 28 deletions(-= )
 lisp/ChangeLog        |   10 +++= +++++++
 lisp/eshell/esh-io.el |   35 +++++++----------= ------------------

Modified   lisp/ChangeLog
= diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 45ba279..9aec8= 08 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,13 @@
+2014-12-19  Samer Masterson  &= lt;samer <at> samertm.com>
+
+ * eshell/esh-io.el (eshell= -get-target, eshell-buffer-shorthand):
+ Remove eshell-buffer-shorthand (bug= #19391).
+
 2014-11-28  Martin Rudalics  = ;<rudalics <at> gmx.at>

  Fix two issues aro= und help-window-select.  (Bug#11039) (Bug#19012)
Modified   lisp/= eshell/esh-io.el
diff --git a/lisp/eshell/esh-io.el b/lisp/eshell= /esh-io.el
index ebbca58..3f70f48 100644
--- a/lisp/esh= ell/esh-io.el
+++ b/lisp/eshell/esh-io.el
@@ -98,19 +98= ,6 @@ other buffers) ."
   :type 'integer
&nb= sp;  :group 'eshell-io)

-(defcustom eshell-bu= ffer-shorthand nil
-  "If non-nil, a symbol name can be used= for a buffer in redirection.
-If nil, redirecting to a buffer re= quires buffer name syntax.  If this
-variable is set, redire= ction directly to Lisp symbols will be
-impossible.
-
-Example:
-
-  echo hello > '*scratch*=  ; works if `eshell-buffer-shorthand' is t
-  echo hel= lo > #<buffer *scratch*>  ; always works"
-  := type 'boolean
-  :group 'eshell-io)
-
&n= bsp;(defcustom eshell-print-queue-size 5
   "The size o= f the print queue, for doing buffered printing.
 This is bas= ically a speed enhancement, to avoid blocking the Lisp code
@@ -3= 55,21 +342,13 @@ it defaults to `insert'."
    (goto-char (point= -max))))
     (point-marker))))))

-=   ((or (bufferp target)
- (and (boundp 'eshell-buffer-shorthand)
=
- &nb= sp;   (symbol-value 'eshell-buffer-shorthand)
-     (symbo= lp target)
-     (not (memq target '(t nil)))))
-  = ;  (let ((buf (if (bufferp target)
-   target
- (get-buffer-cre= ate
- <= /span>  (symbol-name target)))))
-      (with= -current-buffer buf
- (cond ((eq mode 'overwrite)
-       (er= ase-buffer))
-      ((eq mode 'append)
-      = ; (goto-char (point-max))))
- (point-marker))))
+   ((bufferp= target)
+    (with-current-buffer target
+ &= nbsp;    (cond ((eq mode 'overwrite)
+     &n= bsp;       (erase-buffer))
+       =      ((eq mode 'append)
+       &nb= sp;     (goto-char (point-max))))
+      = ;(point-marker)))

    ((functionp target= ) nil)
= --=-JfiPypyZP1JRlndJ5veR-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 03 10:56:45 2015 Received: (at 19391) by debbugs.gnu.org; 3 Mar 2015 15:56:45 +0000 Received: from localhost ([127.0.0.1]:34078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSpBc-0002oY-Th for submit@debbugs.gnu.org; Tue, 03 Mar 2015 10:56:45 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:55850) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSpBa-0002oL-K5 for 19391@debbugs.gnu.org; Tue, 03 Mar 2015 10:56:43 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NKN0050084ZE800@a-mtaout21.012.net.il> for 19391@debbugs.gnu.org; Tue, 03 Mar 2015 17:56:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKN005108ACAW90@a-mtaout21.012.net.il>; Tue, 03 Mar 2015 17:56:36 +0200 (IST) Date: Tue, 03 Mar 2015 17:56:29 +0200 From: Eli Zaretskii Subject: Re: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion In-reply-to: <1424775586.11596.7@mail.samertm.com> X-012-Sender: halo1@inter.net.il To: Samer Masterson Message-id: <83a8zuqdle.fsf@gnu.org> References: <1424775586.11596.7@mail.samertm.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19391 Cc: 19391@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 24 Feb 2015 02:59:46 -0800 > From: Samer Masterson > > Modified lisp/ChangeLog > diff --git a/lisp/ChangeLog b/lisp/ChangeLog > index 45ba279..9aec808 100644 > --- a/lisp/ChangeLog > +++ b/lisp/ChangeLog > @@ -1,3 +1,13 @@ > +2014-12-19 Samer Masterson samertm.com> > + > + * eshell/esh-io.el (eshell-get-target, eshell-buffer-shorthand): > + Remove eshell-buffer-shorthand (bug#19391). Can you explain why we should lose this user option? I understand that it causes trouble in this scenario, but can we solve the bug without losing the option? If not, why having the limitation documented in the doc string is not good enough? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 02:50:53 2015 Received: (at 19391) by debbugs.gnu.org; 4 Mar 2015 07:50:53 +0000 Received: from localhost ([127.0.0.1]:34494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YT44y-0000S4-5J for submit@debbugs.gnu.org; Wed, 04 Mar 2015 02:50:52 -0500 Received: from ec2-52-0-7-12.compute-1.amazonaws.com ([52.0.7.12]:34999 helo=samertm.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YT44w-0000Rt-5K for 19391@debbugs.gnu.org; Wed, 04 Mar 2015 02:50:50 -0500 Received: from [10.20.1.233] (75-101-62-71.dsl.static.fusionbroadband.com [75.101.62.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by samertm.com (Postfix) with ESMTPSA id 7A40E42D22; Wed, 4 Mar 2015 07:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samertm.com; s=mail; t=1425455430; bh=JRIMTki9s7wSaRzT8UDwLILYGHlQDTCnAM0nRsVE4QA=; h=Date:From:Subject:To:Cc:In-Reply-To:References:From; b=MzWtd5fFTduMIsVSMdTFcinrWy/iRwWJ7YBoAlo12D3j7Ei15LtSgvXlfyxmLd+Xz EAG7riKnWPlnsMaWBTFjPDfU5Tkf3y+yjsY8P2215j0L6W5vQ/EjHntIQLJdMf/VzE XepHQDpG2ug1P0CNqXG2QYfEl4aeGgdO+O685UOs= Date: Tue, 03 Mar 2015 23:50:34 -0800 From: Samer Masterson Subject: Re: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion To: Eli Zaretskii Message-Id: <1425455434.1450.1@mail.samertm.com> In-Reply-To: <83a8zuqdle.fsf@gnu.org> References: <1424775586.11596.7@mail.samertm.com> <83a8zuqdle.fsf@gnu.org> X-Mailer: geary/0.9.1 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-51C2NyWSVKj8eQNJyfH9" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 19391 Cc: 19391@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --=-51C2NyWSVKj8eQNJyfH9 Content-Type: text/plain; charset=utf-8; format=flowed On Tue, Mar 3, 2015 at 7:56 AM, Eli Zaretskii wrote: > Can you explain why we should lose this user option? I understand > that it causes trouble in this scenario, but can we solve the bug > without losing the option? If not, why having the limitation > documented in the doc string is not good enough? > > Thanks. I think the strongest reason for losing the option is that it currently doesn't work: If you type "echo hello > '*scratch" into eshell and press enter, eshell adds a newline without evaluating the command because it thinks it's in a string because of the unmatched single quote. Its implementation also makes eshell more complex, because eshell-get-target *only* checks for symbols if the option is selected, and then gets-or-creates a buffer with the symbol name. I think having a shorthand for buffers in eshell is a good thing, but it should be different in three ways: - The syntax for the shorthand should be distinct from any other lisp objects, so that we don't have to put out fires when people try to do things that are valid but overlap with the shorthand (e.g. this bug was caused by eshell's external shell feature redirecting to a symbol.) Something like # would work. - The shorthand should be processed as a buffer (similar to how # is processed). That means the shorthand won't require extra code anywhere except for the reader. - The shorthand should be on by default, and probably shouldn't have an option to disable it. The reason for this is that the shorthand would be universally beneficial and backwards compatible, and making it controlled by an option is inviting bugs when we shouldn't be. Let me know what you think of the above, and I can add more detail to the proposal and submit it to emacs-devel. Best, Samer --=-51C2NyWSVKj8eQNJyfH9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Mar 3, 2015 at 7:56 AM, Eli Zaretskii <eliz@gnu.org> wrote:
Can you explain why we should lose this user option? I understa= nd that it causes trouble in this scenario, but can we solve the bug without losing the option? If not, why having the limitation documented in the doc string is not good enough? Thanks.

I think the strongest reason for losing = the option is that it currently doesn't work: If you type "echo hello > = '*scratch" into eshell and press enter, eshell adds a newline without evalu= ating the command because it thinks it's in a string because of the unmatch= ed single quote. Its implementation also makes eshell more complex, because= eshell-get-target *only* checks for symbols if the option is selected, and= then gets-or-creates a buffer with the symbol name.

I think having a shorthand for buffers in eshell is a good thing, but it= should be different in three ways:
 - The syntax for the sh= orthand should be distinct from any other lisp objects, so that we don't ha= ve to put out fires when people try to do things that are valid but overlap= with the shorthand (e.g. this bug was caused by eshell's external shell fe= ature redirecting to a symbol.) Something like #<name-of-buffer> woul= d work.
 - The shorthand should be processed as a buffer (si= milar to how #<buffer name-of-buffer> is processed). That means the s= horthand won't require extra code anywhere except for the reader.
 - The shorthand should be on by default, and probably shouldn't have= an option to disable it. The reason for this is that the shorthand would b= e universally beneficial and backwards compatible, and making it controlled= by an option is inviting bugs when we shouldn't be.

Let me know what you think of the above, and I can add more detail to th= e proposal and submit it to emacs-devel.

Best,
Samer
= --=-51C2NyWSVKj8eQNJyfH9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 04 12:28:44 2015 Received: (at 19391) by debbugs.gnu.org; 4 Mar 2015 17:28:44 +0000 Received: from localhost ([127.0.0.1]:35194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTD6B-0001aZ-GZ for submit@debbugs.gnu.org; Wed, 04 Mar 2015 12:28:43 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:61656) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YTD69-0001aL-Ma for 19391@debbugs.gnu.org; Wed, 04 Mar 2015 12:28:42 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKP00B0071DA900@a-mtaout20.012.net.il> for 19391@debbugs.gnu.org; Wed, 04 Mar 2015 19:28:35 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKP00B6S77M5W60@a-mtaout20.012.net.il>; Wed, 04 Mar 2015 19:28:35 +0200 (IST) Date: Wed, 04 Mar 2015 19:28:31 +0200 From: Eli Zaretskii Subject: Re: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion In-reply-to: <1425455434.1450.1@mail.samertm.com> X-012-Sender: halo1@inter.net.il To: Samer Masterson Message-id: <83lhjcpt8g.fsf@gnu.org> References: <1424775586.11596.7@mail.samertm.com> <83a8zuqdle.fsf@gnu.org> <1425455434.1450.1@mail.samertm.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19391 Cc: 19391@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 03 Mar 2015 23:50:34 -0800 > From: Samer Masterson > Cc: 19391@debbugs.gnu.org > > On Tue, Mar 3, 2015 at 7:56 AM, Eli Zaretskii wrote: > > Can you explain why we should lose this user option? I understand that it > causes trouble in this scenario, but can we solve the bug without losing > the option? If not, why having the limitation documented in the doc string > is not good enough? Thanks. > > I think the strongest reason for losing the option is that it currently doesn't > work: If you type "echo hello > '*scratch" into eshell and press enter, eshell > adds a newline without evaluating the command because it thinks it's in a > string because of the unmatched single quote. Its implementation also makes > eshell more complex, because eshell-get-target *only* checks for symbols if the > option is selected, and then gets-or-creates a buffer with the symbol name. > > I think having a shorthand for buffers in eshell is a good thing, but it should > be different in three ways: If you are saying that redesigning eshell-buffer-shorthand would resolve this bug without losing the option, then I agree it's a better way. I don't know about Eshell enough to judge whether your suggestion won't run into problems, though, so I indeed think it's best to post it to emacs-devel. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 21:42:54 2017 Received: (at 19391) by debbugs.gnu.org; 27 Nov 2017 02:42:54 +0000 Received: from localhost ([127.0.0.1]:59843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Nm-0007P8-EA for submit@debbugs.gnu.org; Sun, 26 Nov 2017 21:42:54 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:45565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ9Nl-0007Oo-54; Sun, 26 Nov 2017 21:42:53 -0500 Received: by mail-io0-f169.google.com with SMTP id z74so34717957iof.12; Sun, 26 Nov 2017 18:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SLg+QzeOfFtW30YPJARrjr1qaDtMKjKNIIn8RsGOsnw=; b=a6EVda13/C1VLelzPU4YsAgFwBUnhuqr21V64eSqGwiUshSEst7ooLDc8jPmEMHJ6i gPMCf7msAzD4TqW8bAbPoOdx8nZJIt/s/b6LV0moX3DrTOPiDUUBsmqww4wnELz/7qUe kQAmnZC4Axk1ulKeaRHZ3oxSlkwjUJBpEpyV+AVSPpcs8hA/ZvPSDc2v40uwjk4TJIv9 SQ7XEk+VN7wvfYIqwGX1Hc5TjfrueYD+0n15f5EpN8fR0ELemLPkjfBTOiSa0yaAkibg xZ6XFd+KV5qDm6SeWXpPXFgAiO8R4ph6fFdnSNL8YOqD+WpGdCre5eWLCPorJch0AG3E 1aZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=SLg+QzeOfFtW30YPJARrjr1qaDtMKjKNIIn8RsGOsnw=; b=q6DGZsUq5TXOMO+vu95Vgjgy9WlJlxw2ZEfkS5hNb2cZEmSlcZb0LkQhkOHjlGfYxs fTBVZBj40wdErsMib0DVvWGDz2QPCNjPXsuD0XpjnGhnE2H+Gv/zuBPXak4Ik5Qg2I1b GZNQCdL3C9LAZ+dzLkS2xII8/gMWpj8MrBN+Fp+9G7I7OcT3kJWac6XyiFHl4O5ehcPT uAWMZbycm+0RrqCwGaG7pe06bHtMawOyC7Ut7Yff9H2iOtGO9AYn0lSI7fN8HWHJoMSg IcJ0W3DOLnWnx7DLrtRNP+3BlwI7tWqiG8//u14++n/hvIQF+vxqWyj0W7lmsEIqhF0O LRgQ== X-Gm-Message-State: AJaThX55Lwp73YKWotToM3yaqySqieTSUAPiAaBQQmOIV9HyPYQ1IFPv 6M40hjW/X3iSefqEPHCWOQMQ9w== X-Google-Smtp-Source: AGs4zMYeJjBWy6+3PtnewGb4kgh9lt4X35Qu1oR3GZoTOKzxKMmoaIBsc1T6WuYI40dghW2b6T1JKw== X-Received: by 10.107.183.77 with SMTP id h74mr42775807iof.0.1511750567257; Sun, 26 Nov 2017 18:42:47 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i133sm9375009itf.1.2017.11.26.18.42.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Nov 2017 18:42:46 -0800 (PST) From: Noam Postavsky To: Samer Masterson Subject: Re: bug#19391: [PATCH] bug#19391: 25.0.50; eshell-buffer-shorthand breaks command dollar expansion References: <1424775586.11596.7@mail.samertm.com> <83a8zuqdle.fsf@gnu.org> <1425455434.1450.1@mail.samertm.com> Date: Sun, 26 Nov 2017 21:42:45 -0500 In-Reply-To: <1425455434.1450.1@mail.samertm.com> (Samer Masterson's message of "Tue, 03 Mar 2015 23:50:34 -0800") Message-ID: <87a7z8o316.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 19391 Cc: Eli Zaretskii , 19391@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) tags 19391 fixed close 19391 25.1 quit Samer Masterson writes: > - The syntax for the shorthand should be distinct from any other > lisp objects, so that we don't have to put out fires when people try > to do things that are valid but overlap with the shorthand (e.g. this > bug was caused by eshell's external shell feature redirecting to a > symbol.) Something like # would work. > - The shorthand should be processed as a buffer (similar to how # > is processed). That means the shorthand won't > require extra code anywhere except for the reader. > - The shorthand should be on by default, and probably shouldn't have > an option to disable it. The reason for this is that the shorthand > would be universally beneficial and backwards compatible, and making > it controlled by an option is inviting bugs when we shouldn't be. Something along these lines was pushed for Emacs 25. [1: e37da5a4a8]: 2015-05-17 14:28:51 -0700 eshell: Introduce new buffer syntax https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e37da5a4a8055826f0fc1051083495a828509672> From unknown Sat Sep 06 06:36:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator