GNU bug report logs - #19387
SVN VC backend is unbearably slow on larger repositories

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19387 in the body.
You can then email your comments to 19387 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: SVN VC backend is unbearably slow on larger repositories
Date: Mon, 15 Dec 2014 16:14:18 +0100

[Message part 1 (text/plain, inline)]

When I 'C-x v d' my working directory in a recent Emacs, it prints
"Traversing directory: ..." and goes through the whole repository. I have
no idea what it looks for. After about 1 minute of waiting I C-g'd it.

It used to work instantly (well, in under 2 seconds anyway) a couple of
weeks ago; don't remember more precisely.

Version: GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version
3.10.9) of 2014-12-15

Paul

[Message part 2 (text/html, inline)]

Message #8 received at 19387 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 19387 <at> debbugs.gnu.org
Subject: Re: bug#19387: SVN VC backend is unbearably slow on larger
 repositories
Date: Mon, 15 Dec 2014 17:45:09 +0200

Paul Pogonyshev <pogonyshev <at> gmail.com> writes:

> When I 'C-x v d' my working directory in a recent Emacs, it prints
> "Traversing directory: ..." and goes through the whole repository. I have
> no idea what it looks for. After about 1 minute of waiting I C-g'd it.
>
> It used to work instantly (well, in under 2 seconds anyway) a couple of
> weeks ago; don't remember more precisely.

I can confirm this. The culprit is b1a765b3. We should probably revert
the essence of the change, as well as reinstate the FIXME (the meaning
of which is not exactly clear to me).


diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
index eedccd8..3f977e0 100644
--- a/lisp/vc/vc-svn.el
+++ b/lisp/vc/vc-svn.el
@@ -202,11 +202,11 @@ If you want to force an empty list of arguments, use t."
 
 (autoload 'vc-expand-dirs "vc")
 
-(defun vc-svn-dir-status-files (dir files callback)
+(defun vc-svn-dir-status-files (_dir files callback)
   "Run 'svn status' for DIR and update BUFFER via CALLBACK.
 CALLBACK is called as (CALLBACK RESULT BUFFER), where
 RESULT is a list of conses (FILE . STATE) for directory DIR."
-  (if (not files) (setq files (vc-expand-dirs (list dir) 'SVN)))
+  ;; FIXME shouldn't this rather default to all the files in dir?
   (vc-svn-command (current-buffer) 'async nil "status" "-u" files)
   (vc-run-delayed (vc-svn-after-dir-status callback)))
 

Message #13 received at 19387-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <raaahh <at> gmail.com>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 19387-done <at> debbugs.gnu.org
Subject: Re: bug#19387: SVN VC backend is unbearably slow on larger
 repositories
Date: Thu, 18 Dec 2014 15:50:21 +0200

Paul Pogonyshev <pogonyshev <at> gmail.com> writes:

> When I 'C-x v d' my working directory in a recent Emacs, it prints
> "Traversing directory: ..." and goes through the whole repository. I have
> no idea what it looks for. After about 1 minute of waiting I C-g'd it.

The patch has been applied. The feature seems to work now, but please 
double-check.

Message #16 received at 19387-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Dmitry Gutov <raaahh <at> gmail.com>
Cc: 19387-done <at> debbugs.gnu.org
Subject: Re: bug#19387: SVN VC backend is unbearably slow on larger
 repositories
Date: Mon, 22 Dec 2014 11:48:24 +0100

[Message part 1 (text/plain, inline)]

Yes, works fine now. Thanks.

Paul

On 18 December 2014 at 14:50, Dmitry Gutov <raaahh <at> gmail.com> wrote:
>
> Paul Pogonyshev <pogonyshev <at> gmail.com> writes:
>
>  When I 'C-x v d' my working directory in a recent Emacs, it prints
>> "Traversing directory: ..." and goes through the whole repository. I have
>> no idea what it looks for. After about 1 minute of waiting I C-g'd it.
>>
>
> The patch has been applied. The feature seems to work now, but please
> double-check.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.