Subject: bug#19374: [PATCH 2/4] build: configure.ac: support a response file on OS/2

From: KO Myung-Hun <[email-masked]>
Date: Mon, 15 Dec 2014 10:10:21 +0900

Pádraig Brady wrote:
> forcemerge 19374 19377
> stop
> 
> On 14/12/14 03:47, KO Myung-Hun wrote:
>> * configure.ac (LDFLAGS): Add -Zargs-resp on os2*.
> 
> This imparts no information.  Please comment as to the "why"
> rather than the "what".
> 

Fixed.

>> ---
>>  configure.ac | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 0744964..7cb1085 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -589,6 +589,9 @@ AM_GNU_GETTEXT_VERSION([0.18.1])
>>  # For a test of uniq: it uses the $LOCALE_FR envvar.
>>  gt_LOCALE_FR
>>  
>> +# In order to support a response file on OS/2
>> +AS_CASE([$host_os], [os2*], [LDFLAGS="$LDFLAGS -Zargs-resp"])
> 
> This relies on an implicit AC_CANONICAL_HOST which seems brittle.
> 

Fixed.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

>From 8165ae870666afb45a4e4c6af659c99d324e917a Mon Sep 17 00:00:00 2001
From: KO Myung-Hun <[email-masked]>
Date: Mon, 24 Nov 2014 14:02:00 +0900
Subject: [PATCH] build: configure.ac: support a response file on OS/2

By default, a response file(@file) is not supported on OS/2. This
enables that support.

* configure.ac (AC_CANONICAL_HOST): Added for host_os.
(LDFLAGS): Add -Zargs-resp on os2*.
---
 configure.ac | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configure.ac b/configure.ac
index f078034..92e3ee1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -595,6 +595,12 @@ AM_GNU_GETTEXT_VERSION([0.18.1])
 # For a test of uniq: it uses the $LOCALE_FR envvar.
 gt_LOCALE_FR
 
+# For host_os
+AC_CANONICAL_HOST
+
+# In order to support a response file on OS/2
+AS_CASE([$host_os], [os2*], [LDFLAGS="$LDFLAGS -Zargs-resp"])
+
 AC_CONFIG_FILES(
   Makefile
   po/Makefile.in
-- 
1.8.5.2