From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 13 01:33:12 2014 Received: (at submit) by debbugs.gnu.org; 13 Dec 2014 06:33:12 +0000 Received: from localhost ([127.0.0.1]:44362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzgGO-0003WA-4D for submit@debbugs.gnu.org; Sat, 13 Dec 2014 01:33:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37329) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzgGM-0003W0-4B for submit@debbugs.gnu.org; Sat, 13 Dec 2014 01:33:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzgGA-0003IB-0w for submit@debbugs.gnu.org; Sat, 13 Dec 2014 01:33:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzgG9-0003I5-UE for submit@debbugs.gnu.org; Sat, 13 Dec 2014 01:32:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzgG4-0006xy-3E for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 01:32:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzgFy-0003FB-Gy for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 01:32:52 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzgFy-0003F7-9G for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 01:32:46 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A722020227 for ; Sat, 13 Dec 2014 01:32:44 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Sat, 13 Dec 2014 01:32:44 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type; s=mesmtp; bh=S3jfKbyE/KQUi3trJ/wfhg9kxOE=; b=cE9W amWlgvZSxdqNC+a2sbqhd4653upDP/dDz64wCvI2px7yj7/lKNVUvC908pPGXR49 OvqyLxtwl3DI0nYrjXPvQlZm/l+iT5QIt5mGQj7XVZTUpr+rDqpWneO3BQUZGN4D N2qlR2dv0E6uHqMooSQU7Iql+hxP9Hc/vQ6ob5M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type; s=smtpout; bh=S3jfKbyE/KQ Ui3trJ/wfhg9kxOE=; b=c6N2HZYTf6dDtqnTr32OzzMSbNh7deFzRPquxs51C+Y JmP+PFaxoH9ZeFPEmrw1ZPPvv6w3aIa86pklec1CpGWgQDXseJwIleVvfKL/6DHP NAIPradYx5CfAmKvA0u79MF42aPgQTi2IGRg1Ol7XVkQWCsYd9AlnQAe4BeWKYgg = X-Sasl-enc: rtyOsnCtLNOwAO7Nr9EUNoeV/56VomMcwjAroLNr6XAL 1418452364 Received: from shorty.local (unknown [76.91.145.213]) by mail.messagingengine.com (Postfix) with ESMTPA id 5B4806800EA for ; Sat, 13 Dec 2014 01:32:44 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1XzgFv-0001lk-0V for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 22:32:43 -0800 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: 24.4.1; Notifications can make ERC unusable Date: Fri, 12 Dec 2014 22:32:42 -0800 Message-ID: <87r3w4njp1.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi. I just updated my Debian install from emacs24 24.3+1-5 -> 24.4+1-4, and my ERC is no longer usable as a result. The failure mode is that anything I type into a channel IS sent correctly, but nothing anybody else types shows up in the buffer. So even in an active channel it looks like I'm the only one there, since I see nothing anybody else types. The messages do arrive to ERC, since the notification callback sees them; they just aren't relayed to the buffer. This is 100% reproducible if you start emacs with just the following in your .emacs: (eval-after-load 'erc '(progn (require 'erc-desktop-notifications) (erc-notifications-enable) )) Then M-x erc and connect to any server and any channel. This is sensitive to order and/or to timing. For instance, running emacs -Q and then evaluating (require 'erc-desktop-notifications) (erc-notifications-enable) does not trigger the issue. I tried debugging this, but all the indirection in the sources makes it difficult. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 31 03:35:58 2014 Received: (at 19363) by debbugs.gnu.org; 31 Dec 2014 08:35:58 +0000 Received: from localhost ([127.0.0.1]:33298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6El3-0005e9-Im for submit@debbugs.gnu.org; Wed, 31 Dec 2014 03:35:58 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:32806) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6El1-0005do-BA for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 03:35:56 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DC72A20D4C for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 03:35:49 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 31 Dec 2014 03:35:49 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=dIM3A/Ig5F59 ucl1typqbxsGUF8=; b=S5k0SWM8gOgOTdHL2a/H32MMwrh9DFKoDtMLxLNADEO9 +E9dAfJCa1iVToCA70qQxQGDXFKNKkDCXMLd3cxuvU+p3YqAAhABS0IK4hQEhFdK Oeo6Hy+T8IMTNEiK5nu8icVpIxiQuBOA1dnyrH9gY5ptfacJ1tVSpIGAnliPTHA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=dIM3A/Ig5F59ucl1typqbxsGUF8=; b=UUEci/qczymCeOzIEhSg blviIRt+1fluMgip+dqCQWpotEhCjcxDtWtryiXpQ1PS8dyd+u8wqC5Sps/9wxf3 cSxujkwqG4OKOohB8l0nuIC5heU/Hen6Q9Vj+rxt+zcyTiWO8UXg7Fv3s4JVC2F1 Je27KwYttUgLaYYyGLRmLvo= X-Sasl-enc: pKxn362hmZnEKux2BVAMuC89eZw8wCTCvHOXc8ky1pb/ 1420014949 Received: from shorty.local (unknown [172.56.1.108]) by mail.messagingengine.com (Postfix) with ESMTPA id 3AC52C0027D for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 03:35:49 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6Ekp-0002GG-HO for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 00:35:43 -0800 References: <87r3w4njp1.fsf@secretsauce.net> From: Dima Kogan To: 19363@debbugs.gnu.org Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Wed, 31 Dec 2014 00:34:28 -0800 In-reply-to: Message-ID: <87egrgmd29.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19363 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Here's a patch. It works, but I don't like how un-future-proof it is. An uncareful coder can simply use (forward-word) somewhere and get things to break again. Is there a better way? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-subword-mode.patch >From 655e7b9b5735bd62aac104645b5a224636ab97ff Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Tue, 30 Dec 2014 23:29:21 -0800 Subject: [PATCH] ERC no longer gets confused by subword-mode In commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b subword-mode was integrated into the syntax table instead of simply remapping the interactive motion bindings as was done previously. This had the unintended effect of changing the behavior of lisp programs that touch words. In the case of ERC, it completely broke it: emacs now throws an error when ERC is launched, making it unusable when subword-mode is active. This commit temporarily disables subword-mode so that ERC functions that touch words do so the "normal" way. Closes: #17558 --- lisp/erc/erc-backend.el | 9 ++++++++- lisp/erc/erc-button.el | 23 +++++++++++++++-------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index bedb20f..fa95d7e 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -480,7 +480,14 @@ Currently this is called by `erc-send-input'." (with-temp-buffer (insert str) (goto-char (point-min)) - (upcase-word 1) + + ;; If we're in subword-mode then functions operating on words act + ;; differently. Here I temporarily disable subword-mode before + ;; touching the words + (let ((find-word-boundary-function-table + (if (boundp 'subword-empty-char-table) + subword-empty-char-table find-word-boundary-function-table))) + (upcase-word 1)) (buffer-string))) (defun erc-server-setup-periodical-ping (buffer) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index 10e7318..8343425 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -300,14 +300,21 @@ specified by `erc-button-alist'." (when (or (eq t form) (eval form)) (goto-char (point-min)) - (while (forward-word 1) - (setq bounds (bounds-of-thing-at-point 'word)) - (setq word (buffer-substring-no-properties - (car bounds) (cdr bounds))) - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) - (and erc-channel-users (erc-get-channel-user word))) - (erc-button-add-button (car bounds) (cdr bounds) - fun t (list word))))))) + + ;; If we're in subword-mode then functions operating on words + ;; act differently. Here I temporarily disable subword-mode + ;; before touching the words + (let ((find-word-boundary-function-table + (if (boundp 'subword-empty-char-table) + subword-empty-char-table find-word-boundary-function-table))) + (while (forward-word 1) + (setq bounds (bounds-of-thing-at-point 'word)) + (setq word (buffer-substring-no-properties + (car bounds) (cdr bounds))) + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) + (and erc-channel-users (erc-get-channel-user word))) + (erc-button-add-button (car bounds) (cdr bounds) + fun t (list word)))))))) (defun erc-button-add-buttons-1 (regexp entry) "Search through the buffer for matches to ENTRY and add buttons." -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 31 04:00:37 2014 Received: (at 19363) by debbugs.gnu.org; 31 Dec 2014 09:00:37 +0000 Received: from localhost ([127.0.0.1]:33303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6F8v-0006Jy-0B for submit@debbugs.gnu.org; Wed, 31 Dec 2014 04:00:37 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6F8s-0006Jo-QL for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 04:00:35 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 83F8B20B47 for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 04:00:34 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Wed, 31 Dec 2014 04:00:34 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=XPBpwX2XoS3c +JJbK6UloCRaGNo=; b=Fr1XKv4qpeNAxvYEFiAMVUsNO8BPQ5OaRylmorzlxvtO OvCuFBkZ5iIjENKJH7hdiR8/HvLuddi1Sz5pQw+svoFHKOVW8FesaObcRyM3Bh3k udwFNzwf47CVRNTysnV+ujYg5NN6Y+LoNr+jTCIyuzBVWSTh+ltZNznI3CQc3Ec= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=XPBpwX2XoS3c+JJbK6UloCRaGNo=; b=Hu3z6u0xbrCcC5etBc30 BbZHr8yc9r4VQCLlB48gU6ChwfLYlkkXGJJLgWQ2+3bquwTCvVWIe8T5AeayBQgj BCwmGOMcGC1pvzYIx3EbtTt6OvagenpYFfBCuZm1i+zZUWGLMXws7cSnTOstZf1y pI61b6p9UoNdYlZAuUipCgo= X-Sasl-enc: 8l3//IFngpwag2ZPLHMo8tN9EwN9YhWEBd1ekFQ/Ppn1 1420016433 Received: from shorty.local (unknown [208.54.64.204]) by mail.messagingengine.com (Postfix) with ESMTPA id 0D815C00280 for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 04:00:33 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6F8d-0002T9-TB for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 01:00:19 -0800 References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> From: Dima Kogan To: 19363@debbugs.gnu.org Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Wed, 31 Dec 2014 00:59:57 -0800 In-reply-to: <87egrgmd29.fsf@secretsauce.net> Message-ID: <87bnmkmbx8.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19363 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dima Kogan writes: > Here's a patch. It works, but I don't like how un-future-proof it is. An > uncareful coder can simply use (forward-word) somewhere and get things > to break again. Is there a better way? Oops; this was meant as a response to a different bug. Please disregard. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 31 12:46:49 2014 Received: (at 19363) by debbugs.gnu.org; 31 Dec 2014 17:46:49 +0000 Received: from localhost ([127.0.0.1]:33889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6NM8-0001km-59 for submit@debbugs.gnu.org; Wed, 31 Dec 2014 12:46:48 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48200) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6NM4-0001kb-Ab for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 12:46:45 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C093C206A7 for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 12:46:43 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Wed, 31 Dec 2014 12:46:43 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=MymVv2141Zhm PFu1XXpvibFhMRM=; b=G6DZsjMJLDFPoaDP89HQAj+QfCrumm9EI8y2ovDEWkji /vMsMJxr8vrd23URqInKIA8kO4bfONwSUjDkoNJxCC9GMxilSNjnVnSP1uFLMUaE +UNvJSAwmmMyNg7CmBOb3EAzITi11CfndN2iwd9OFWfQ5gx10Btsfekm0IXRphU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=MymVv2141ZhmPFu1XXpvibFhMRM=; b=TRQAC4kGBQzTe+JtHUt6 KT2tYsuTTSSMThu6vtPJUFeE0UxrvhQiMXujmc/gKyk/5cmJWkzODaXGrBH099rm I15XlgooJ1dC3/VmrLA8CBLQ4w1e0lXr68A1XZTO4dVadT1Wp5JwTfRqYbn/iSNv 8PZphdO9uA4ms3nbx7+yY3o= X-Sasl-enc: EpkscZKKX95MQcUxNdXmPk3rLzNOa0dLQLKOqlter0CL 1420048001 Received: from shorty.local (unknown [172.56.0.110]) by mail.messagingengine.com (Postfix) with ESMTPA id E9A29680135 for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 12:46:41 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6NLy-0006go-DW for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 09:46:38 -0800 References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> From: Dima Kogan To: 19363@debbugs.gnu.org Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Wed, 31 Dec 2014 09:46:20 -0800 In-reply-to: <87bnmkmbx8.fsf@secretsauce.net> Message-ID: <877fx7n24i.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19363 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Here's a solution to THIS bug, for real this time. I'm attaching a tested-working patch. I'm no longer sure this is a regression since it's very sensitive to load order. In emacs 24.3 if ERC is byte-compiled then the bug manifests, but if it isn't then it works ok. In any case, the patch solves the issue regardless. To reiterate, ERC works if you start emacs with no init file, and then evaluate (require 'erc) (require 'erc-desktop-notifications) (erc-notifications-enable) However ERC does NOT work if you start with just this in the init file: (eval-after-load 'erc '(progn (require 'erc-desktop-notifications) (erc-notifications-enable) )) The issue is that in the working case, the value of erc-server-PRIVMSG-functions ends up as (erc-notifications-PRIVMSG erc-auto-query erc-server-PRIVMSG) and in the broken case as (erc-auto-query erc-notifications-PRIVMSG) erc-server-PRIVMSG is important, so ERC does not work correctly if it is missing. This missing element is normally added in erc-backend.el by (define-erc-response-handler (PRIVMSG NOTICE) ... which is a macro. In the macro, the significant line is (defvar ,hook-name ',fn-name ,(format hook-doc name)) If we have some (eval-after-load 'erc ...) stuff then by the time this (defvar) is evaluated, the list may already have a value, so the defvar then does NOT add its value to the list. The patch explicitly changes the (defvar list default) idiom to (defvar list nil) (add-to-list 'list default) and thus the default value always appears in the list. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-eval-after-load-erc.patch >From 28bc9430ce6342d210e986586af7b6f12e103043 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Wed, 31 Dec 2014 08:13:57 -0800 Subject: [PATCH] ERC no longer gets confused by (eval-after-load 'erc ...) ERC was initializing one of its lists with (defvar list default). If the list already had a value due to (eval-after-load 'erc ...) for instance, then (defvar) would see an initialized variable, and would NOT add the default value to the list. This was breaking things. This patch changes the above defvar idiom to (defvar list nil) (add-to-list 'list default) This way the default value is added to the list unconditionally Closes: #19363 --- lisp/erc/erc-backend.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index fa95d7e..43e56c0 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -1179,8 +1179,11 @@ add things to `%s' instead." (cl-loop for alias in aliases collect (intern (format "erc-server-%s-functions" alias))))) `(prog2 - ;; Normal hook variable. - (defvar ,hook-name ',fn-name ,(format hook-doc name)) + ;; Normal hook variable. The variable may already have a + ;; value at this point, so I default to nil, and (add-hook) + ;; unconditionally + (defvar ,hook-name nil ,(format hook-doc name)) + (add-to-list ',hook-name ',fn-name) ;; Handler function (defun ,fn-name (proc parsed) ,fn-doc -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 31 15:58:08 2014 Received: (at 19363) by debbugs.gnu.org; 31 Dec 2014 20:58:08 +0000 Received: from localhost ([127.0.0.1]:33998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6QLH-0006VB-SN for submit@debbugs.gnu.org; Wed, 31 Dec 2014 15:58:08 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44719) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6QLE-0006Ut-93 for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 15:58:04 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 129432063D for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 15:58:04 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Wed, 31 Dec 2014 15:58:04 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=MymVv2141Zhm PFu1XXpvibFhMRM=; b=q1LpD1RFcIQSPoaOy8KteNtLiP7Z6FYGLR9BAa1oguom OdiSQBmkCpsb2EVQv2E6O9wEq7jS5OaRViJ1zUastTAc9OmXAAeI6QrXla5lAzAw 34FBlZ8AHG+ljdroZkWQYMY7Y0F2vwPZW5GrAupoPk8KDVnXshgmIQyoGqZydRQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=MymVv2141ZhmPFu1XXpvibFhMRM=; b=rRCCaSluvtt0mclrwXj8 F6CFiWtfUQfIoNJTxTfjiMxl4VXlXySbI9jl5EfD/Hya8EMk/9C6rH3+3RTvW8H8 OEkaWMEwdhVTNFbaqJtxZs4xB8hr39d9T2+rWV30eJ8luGDbZTAOVGz6zRCRofJb PRrAx9KQYa+4AHq9Ct8bFP4= X-Sasl-enc: v057sRh2if4cCbXm3xPYfziiY9VIBgmPX53GoL1j4Bqx 1420059483 Received: from shorty.local (unknown [174.28.80.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 65CEA68014C for <19363@debbugs.gnu.org>; Wed, 31 Dec 2014 15:58:03 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6MmC-0006Vp-AO for 19363@debbugs.gnu.org; Wed, 31 Dec 2014 09:09:40 -0800 References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> From: Dima Kogan To: 19363@debbugs.gnu.org Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Wed, 31 Dec 2014 07:47:24 -0800 In-reply-to: <87bnmkmbx8.fsf@secretsauce.net> Message-ID: <878uhnn3ub.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19363 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Here's a solution to THIS bug, for real this time. I'm attaching a tested-working patch. I'm no longer sure this is a regression since it's very sensitive to load order. In emacs 24.3 if ERC is byte-compiled then the bug manifests, but if it isn't then it works ok. In any case, the patch solves the issue regardless. To reiterate, ERC works if you start emacs with no init file, and then evaluate (require 'erc) (require 'erc-desktop-notifications) (erc-notifications-enable) However ERC does NOT work if you start with just this in the init file: (eval-after-load 'erc '(progn (require 'erc-desktop-notifications) (erc-notifications-enable) )) The issue is that in the working case, the value of erc-server-PRIVMSG-functions ends up as (erc-notifications-PRIVMSG erc-auto-query erc-server-PRIVMSG) and in the broken case as (erc-auto-query erc-notifications-PRIVMSG) erc-server-PRIVMSG is important, so ERC does not work correctly if it is missing. This missing element is normally added in erc-backend.el by (define-erc-response-handler (PRIVMSG NOTICE) ... which is a macro. In the macro, the significant line is (defvar ,hook-name ',fn-name ,(format hook-doc name)) If we have some (eval-after-load 'erc ...) stuff then by the time this (defvar) is evaluated, the list may already have a value, so the defvar then does NOT add its value to the list. The patch explicitly changes the (defvar list default) idiom to (defvar list nil) (add-to-list 'list default) and thus the default value always appears in the list. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-eval-after-load-erc.patch >From 28bc9430ce6342d210e986586af7b6f12e103043 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Wed, 31 Dec 2014 08:13:57 -0800 Subject: [PATCH] ERC no longer gets confused by (eval-after-load 'erc ...) ERC was initializing one of its lists with (defvar list default). If the list already had a value due to (eval-after-load 'erc ...) for instance, then (defvar) would see an initialized variable, and would NOT add the default value to the list. This was breaking things. This patch changes the above defvar idiom to (defvar list nil) (add-to-list 'list default) This way the default value is added to the list unconditionally Closes: #19363 --- lisp/erc/erc-backend.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index fa95d7e..43e56c0 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -1179,8 +1179,11 @@ add things to `%s' instead." (cl-loop for alias in aliases collect (intern (format "erc-server-%s-functions" alias))))) `(prog2 - ;; Normal hook variable. - (defvar ,hook-name ',fn-name ,(format hook-doc name)) + ;; Normal hook variable. The variable may already have a + ;; value at this point, so I default to nil, and (add-hook) + ;; unconditionally + (defvar ,hook-name nil ,(format hook-doc name)) + (add-to-list ',hook-name ',fn-name) ;; Handler function (defun ,fn-name (proc parsed) ,fn-doc -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 04 14:52:12 2015 Received: (at 19363) by debbugs.gnu.org; 4 Jan 2015 19:52:13 +0000 Received: from localhost ([127.0.0.1]:36605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7rDg-0006eq-G3 for submit@debbugs.gnu.org; Sun, 04 Jan 2015 14:52:12 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20809) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7rDc-0006eh-RB for 19363@debbugs.gnu.org; Sun, 04 Jan 2015 14:52:10 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEPAOwQflRFpY0B/2dsb2JhbABbgweBK4I1hVrFHQQCAoEkFwEBAQEBAXyEAgEBAQECAVYhAgULCxEDAQIdEhQYDRYOE4g3CdZZAQEBAQEBBAEBAQEBARyQbweESAWLAaQugXiEGSEwgkcBAQE X-IPAS-Result: AnEPAOwQflRFpY0B/2dsb2JhbABbgweBK4I1hVrFHQQCAoEkFwEBAQEBAXyEAgEBAQECAVYhAgULCxEDAQIdEhQYDRYOE4g3CdZZAQEBAQEBBAEBAQEBARyQbweESAWLAaQugXiEGSEwgkcBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="106531964" Received: from 69-165-141-1.dsl.teksavvy.com (HELO ceviche.home) ([69.165.141.1]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Jan 2015 14:52:07 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 7CFF266100; Sun, 4 Jan 2015 14:52:07 -0500 (EST) From: Stefan Monnier To: Dima Kogan Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Message-ID: References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> <878uhnn3ub.fsf@secretsauce.net> Date: Sun, 04 Jan 2015 14:52:07 -0500 In-Reply-To: <878uhnn3ub.fsf@secretsauce.net> (Dima Kogan's message of "Wed, 31 Dec 2014 07:47:24 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19363 Cc: 19363@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > If we have some (eval-after-load 'erc ...) stuff then by the time this > (defvar) is evaluated, the list may already have a value, so the defvar > then does NOT add its value to the list. The patch explicitly changes > the (defvar list default) idiom to > (defvar list nil) (add-to-list 'list default) and thus the default value > always appears in the list. Thanks. That's a good change. The general rule is that a hook's initial/default value should be nil (that's fairly strong "should", with relatively few exceptions. This bug-report is a good example of why it should be that way). It's also generally better if the hook's "normal" value is nil, tho I think in this case it'd be probably inconvenient. But I do wonder: if the function *has* to be on that hook for ERC to work correctly, then maybe that function's place is not in the hook but right at those places where the hook is run (i.e. hard-coded). Could you (or someone who understands the code better than I do) take a look to see if such a change would be even better? Stefan >> From 28bc9430ce6342d210e986586af7b6f12e103043 Mon Sep 17 00:00:00 2001 > From: Dima Kogan > Date: Wed, 31 Dec 2014 08:13:57 -0800 > Subject: [PATCH] ERC no longer gets confused by (eval-after-load 'erc ...) > ERC was initializing one of its lists with (defvar list default). If > the list already had a value due to (eval-after-load 'erc ...) for > instance, then (defvar) would see an initialized variable, and would NOT > add the default value to the list. This was breaking things. This > patch changes the above defvar idiom to > (defvar list nil) > (add-to-list 'list default) > This way the default value is added to the list unconditionally > Closes: #19363 > --- > lisp/erc/erc-backend.el | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el > index fa95d7e..43e56c0 100644 > --- a/lisp/erc/erc-backend.el > +++ b/lisp/erc/erc-backend.el > @@ -1179,8 +1179,11 @@ add things to `%s' instead." > (cl-loop for alias in aliases > collect (intern (format "erc-server-%s-functions" alias))))) > `(prog2 > - ;; Normal hook variable. > - (defvar ,hook-name ',fn-name ,(format hook-doc name)) > + ;; Normal hook variable. The variable may already have a > + ;; value at this point, so I default to nil, and (add-hook) > + ;; unconditionally > + (defvar ,hook-name nil ,(format hook-doc name)) > + (add-to-list ',hook-name ',fn-name) > ;; Handler function > (defun ,fn-name (proc parsed) > ,fn-doc > -- > 2.1.3 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 04 16:47:21 2015 Received: (at 19363) by debbugs.gnu.org; 4 Jan 2015 21:47:21 +0000 Received: from localhost ([127.0.0.1]:36684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7t17-00017e-5U for submit@debbugs.gnu.org; Sun, 04 Jan 2015 16:47:21 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7t13-00017R-Jo for 19363@debbugs.gnu.org; Sun, 04 Jan 2015 16:47:18 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2ED5821C31 for <19363@debbugs.gnu.org>; Sun, 4 Jan 2015 16:47:17 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sun, 04 Jan 2015 16:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=k1lwaq4+hzVj nSl3jeMwr8tjoPc=; b=slw50aiLEH5/Q8JDkmYmSnUWheGLnAGFSVKDAKV9trZr hdkwexq9wPSM1tNR5oU7bCDpeqwjFBPA98TWVJfLdsEKgv9ug543pD+0cCVpUi3F ThCXDal6oGOsu4ZSXMbu8RgUOZk/FXaNHMY52eKNBitZbtarhI/eGBbKDk+ZmFA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=k1lwaq4+hzVjnSl3jeMwr8tjoPc=; b=utgdVZw5xsWrxB9W6u3T DdwJeC1XYez8eujesHGj684OIW4xv5DrweKoirlyudWKUWwn91WzFLIHWrqqyT8I sFZZx9p+queB4ouEKGlW02P1gXyeL5L8rZmE1ucPhVlwi17+GZlXTSalCw5VnLCj 3L4KntNAJBDQiph5+ASURlk= X-Sasl-enc: 2u1O4U6ovTUB4aXC46QPfp3gXVg0fRqTuMotlSdrgIk+ 1420408036 Received: from shorty.local (unknown [75.173.95.188]) by mail.messagingengine.com (Postfix) with ESMTPA id C8763C0027E; Sun, 4 Jan 2015 16:47:16 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y7t11-0006oJ-F0; Sun, 04 Jan 2015 13:47:15 -0800 References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> <878uhnn3ub.fsf@secretsauce.net> From: Dima Kogan To: Stefan Monnier Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Sun, 04 Jan 2015 13:26:15 -0800 In-reply-to: Message-ID: <87mw5ykyl8.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19363 Cc: 19363@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: >> If we have some (eval-after-load 'erc ...) stuff then by the time this >> (defvar) is evaluated, the list may already have a value, so the defvar >> then does NOT add its value to the list. The patch explicitly changes >> the (defvar list default) idiom to >> (defvar list nil) (add-to-list 'list default) and thus the default value >> always appears in the list. > > But I do wonder: if the function *has* to be on that hook for ERC to > work correctly, then maybe that function's place is not in the hook but > right at those places where the hook is run (i.e. hard-coded). > Could you (or someone who understands the code better than I do) take > a look to see if such a change would be even better? Hi. I suspect that hard-coding this would be a very big and unwelcome change in this case because there's some indirection here. Each ERC "response handler" has a hook such as this. The (defvar ...) (add-to-list ...) happens in the macro that defines a response handler: define-erc-response-handler, and the hooks are invoked in a general way for all server responses in erc-handle-parsed-server-response. So the bug I was seeing was due specifically to missing PRIVMSG response handlers, but the patch fixes all response handlers generically. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 04 20:55:01 2015 Received: (at 19363) by debbugs.gnu.org; 5 Jan 2015 01:55:01 +0000 Received: from localhost ([127.0.0.1]:36813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7wsm-0008DT-MZ for submit@debbugs.gnu.org; Sun, 04 Jan 2015 20:55:00 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42551) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7wsi-0008D0-8y for 19363@debbugs.gnu.org; Sun, 04 Jan 2015 20:54:57 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwPAOwQflRFpY0B/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViECBQsLNBIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGSMY9zggqBeIQZIYJ3AQEB X-IPAS-Result: AjwPAOwQflRFpY0B/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViECBQsLNBIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGSMY9zggqBeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="106578887" Received: from 69-165-141-1.dsl.teksavvy.com (HELO pastel.home) ([69.165.141.1]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Jan 2015 20:54:54 -0500 Received: by pastel.home (Postfix, from userid 20848) id 63DD52527; Sun, 4 Jan 2015 20:54:54 -0500 (EST) From: Stefan Monnier To: Dima Kogan Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Message-ID: References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> <878uhnn3ub.fsf@secretsauce.net> <87mw5ykyl8.fsf@secretsauce.net> Date: Sun, 04 Jan 2015 20:54:54 -0500 In-Reply-To: <87mw5ykyl8.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 04 Jan 2015 13:26:15 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19363 Cc: 19363@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Hi. I suspect that hard-coding this would be a very big and unwelcome > change in this case because there's some indirection here. Each ERC > "response handler" has a hook such as this. The (defvar ...) > (add-to-list ...) happens in the macro that defines a response handler: > define-erc-response-handler, and the hooks are invoked in a general way > for all server responses in erc-handle-parsed-server-response. > So the bug I was seeing was due specifically to missing PRIVMSG response > handlers, but the patch fixes all response handlers generically. Right. So maybe it can be fixed "better" via a more significant restructuring, but that's still to be shown. Feel free to install your patch, thank you, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 07 00:18:30 2015 Received: (at 19363) by debbugs.gnu.org; 7 Jan 2015 05:18:30 +0000 Received: from localhost ([127.0.0.1]:39099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y8j0o-00058r-Ap for submit@debbugs.gnu.org; Wed, 07 Jan 2015 00:18:30 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56207) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y8j0l-00058f-27 for 19363@debbugs.gnu.org; Wed, 07 Jan 2015 00:18:28 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5D6A320738 for <19363@debbugs.gnu.org>; Wed, 7 Jan 2015 00:18:26 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Wed, 07 Jan 2015 00:18:26 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=erS9M6i4jfwM YnRxwZWdDoZqvow=; b=vnGJBqgTVjlMLRxAPbOAubIGuTyIj9Ci/p6X85av4GRq GS/yxN51EztLEkykps8R5u6n9fYHcegTYD6DWgw4bZTzWOoJ2w+V964geZXkiIXW ulOzyjmr48YQhj5Jg1enX8V9Ma+rIFm9euPD73NfIW9Q1+srNpYjSRE+65pUopQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=erS9M6i4jfwMYnRxwZWdDoZqvow=; b=oASLYKdzgjOU7J8xNZCX GVxtd71j4wH0P/HUKMAAOpgAaq0KEN+hTTu9pa4puJBbMXmX8ttz/89ym0P5if3V L+CjbcHRoc4b7aYJlOYYRLISIwdupZfId80ruaoyLMgdwy060ML+H8Nq2huQm9YS 8dyNEyK+DC1kHDHRRIEYAvg= X-Sasl-enc: etnN4EegM2wcAkt5fNvcP+9tHuUmmn12FOm8KDffNgav 1420607906 Received: from shorty.local (unknown [172.56.0.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 051BB6800DE for <19363@debbugs.gnu.org>; Wed, 7 Jan 2015 00:18:26 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y8j0i-0004Lr-2Z for 19363@debbugs.gnu.org; Tue, 06 Jan 2015 21:18:24 -0800 References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> <878uhnn3ub.fsf@secretsauce.net> <87mw5ykyl8.fsf@secretsauce.net> From: Dima Kogan To: 19363@debbugs.gnu.org Subject: Re: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Tue, 06 Jan 2015 16:38:27 -0800 In-reply-to: Message-ID: <87fvbnkw2n.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 19363 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) Stefan Monnier writes: > Feel free to install your patch, thank you Thanks, Stefan. I don't have commit access. Can somebody push up that change, please? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 14 17:07:54 2015 Received: (at 19363) by debbugs.gnu.org; 14 Jan 2015 22:07:54 +0000 Received: from localhost ([127.0.0.1]:57159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBW6T-00015C-KU for submit@debbugs.gnu.org; Wed, 14 Jan 2015 17:07:53 -0500 Received: from mail-qa0-f52.google.com ([209.85.216.52]:60386) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBW6Q-00014u-Kg for 19363@debbugs.gnu.org; Wed, 14 Jan 2015 17:07:51 -0500 Received: by mail-qa0-f52.google.com with SMTP id x12so8688913qac.11 for <19363@debbugs.gnu.org>; Wed, 14 Jan 2015 14:07:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=GTkcftXaHjExy0dQfOgMF2+GGqYTq1VjvBD1mpCYMdE=; b=AVcDss90c5TlRHZYCuIgUs59sqoKkGo1d085TTz2jjy1oOKaVNTTaeRf9s5WEMci2k tQVzaWD7JWSwUaF42iXBc1HV6jOvchlNfRqRFLjMh2hoqhxhzmx+5IW/XkyMOZh/3OfV YOClkTUrDEVTPfX6t/PFJ8PaLrpLZwQZZcNFRd3iorIlx8P6Ui6VRtFUEZnzdfPzs8Xc jXnexPH0cWazhwv9yp8EmlP+I9TX40fXvcLIx1jCilF/ipPwKwijcHVLg5Qj7ml3D50m V2XanBXN6ti4qbAGjiweWwaK80iZ7OQ3Z1koIBX7NwrhhhWRtiJ/q6158k+f0tEp8BCa 7F6Q== X-Received: by 10.224.104.10 with SMTP id m10mr10922414qao.3.1421273265285; Wed, 14 Jan 2015 14:07:45 -0800 (PST) MIME-Version: 1.0 From: Kelvin White Date: Wed, 14 Jan 2015 22:07:44 +0000 Message-ID: Subject: Close debbugs #19363 To: 19363@debbugs.gnu.org Content-Type: multipart/alternative; boundary=001a11c1ca161b305b050ca3f86b X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19363 Cc: Dima Kogan , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a11c1ca161b305b050ca3f86b Content-Type: text/plain; charset=UTF-8 Hello Dima, Your patch has been installed in the emacs-24 branch. Thanks --001a11c1ca161b305b050ca3f86b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 
Hello Dima,=C2=A0
Your =
patch has been installed in the emacs-24 branch.
Thanks
--001a11c1ca161b305b050ca3f86b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 14 18:17:33 2015 Received: (at 19363) by debbugs.gnu.org; 14 Jan 2015 23:17:33 +0000 Received: from localhost ([127.0.0.1]:57174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBXBs-0002p4-SA for submit@debbugs.gnu.org; Wed, 14 Jan 2015 18:17:33 -0500 Received: from mail-qc0-f182.google.com ([209.85.216.182]:62224) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBXBq-0002oq-Vi for 19363@debbugs.gnu.org; Wed, 14 Jan 2015 18:17:31 -0500 Received: by mail-qc0-f182.google.com with SMTP id l6so5792952qcy.13 for <19363@debbugs.gnu.org>; Wed, 14 Jan 2015 15:17:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:references:from:date:message-id:subject:to :content-type; bh=3WaF7LEazUEfUvzXeNO/LQBvcSwjzspM0aFnvz3mY84=; b=gtSzvL3ECWA1Z2yzyXD+FZSwslpbGgBxaMM4aH90HCLwQ3dd5ISEWoRe5xnIIk5yyb X7Knl6wvmtiaATGcafgjRurkasCgxXdnc/pdMfBccPXE9rLUQHNXZTIIoZbLSVJWFgqO TC1wCXeMDoxNS8sUUuLZrL49i1KsxN6aq2Pyk3MMhI8EymD946lnQflFqp/rUOF1LoHI uOwOl0EN5/GGfgi+ZPv93mzahFPAlDxn1GmeNTdNwIx9nWPKTDoUplpue6ltMnlbkRJ8 qaN9UxcsWByMipCJKALZYeb7kZ0oq6PchHb4/FSJtDI6E9dOHZ4Ba2Og8RDUX5MHp3mG +v/A== X-Received: by 10.229.197.129 with SMTP id ek1mr11574460qcb.8.1421277445420; Wed, 14 Jan 2015 15:17:25 -0800 (PST) MIME-Version: 1.0 References: From: Kelvin White Date: Wed, 14 Jan 2015 23:17:24 +0000 Message-ID: Subject: Re: bug#19363: Close debbugs #19363 To: 19363@debbugs.gnu.org Content-Type: multipart/alternative; boundary=001a11c2bf7642ffbf050ca4f138 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19363 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a11c2bf7642ffbf050ca4f138 Content-Type: text/plain; charset=UTF-8 patch installed. This bug report is closed. --001a11c2bf7642ffbf050ca4f138 Content-Type: text/html; charset=UTF-8



patch installed. This bug report is closed.

--001a11c2bf7642ffbf050ca4f138-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 15 13:15:15 2015 Received: (at 19363) by debbugs.gnu.org; 15 Jan 2015 18:15:15 +0000 Received: from localhost ([127.0.0.1]:57973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBows-0007zN-TX for submit@debbugs.gnu.org; Thu, 15 Jan 2015 13:15:15 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:42608 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBowr-0007zG-Ee for 19363@debbugs.gnu.org; Thu, 15 Jan 2015 13:15:13 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YBowp-0000DJ-7N; Thu, 15 Jan 2015 13:15:11 -0500 From: Glenn Morris To: Kelvin White Subject: Re: bug#19363: Close debbugs #19363 References: X-Spook: Area 51 Croatian $400 million in gold bullion clones X-Ran: swfaf~av1yhH\2#7UcB_F@+7q4c$)iW"0I+[iZ21$`"(x5q\{S1X+n%AEneQg/}[r#?}ne X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 15 Jan 2015 13:15:11 -0500 In-Reply-To: (Kelvin White's message of "Wed, 14 Jan 2015 23:17:24 +0000") Message-ID: <6ah9vrc3m8.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 19363 Cc: 19363@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) FYI, you haven't closed the bug report. You do that by sending a mail to 19363-done. (It may help to read the quick-start guide in admin/notes/bugtracker.) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 15 18:41:43 2015 Received: (at 19363) by debbugs.gnu.org; 15 Jan 2015 23:41:43 +0000 Received: from localhost ([127.0.0.1]:58199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBu2p-0007OL-GT for submit@debbugs.gnu.org; Thu, 15 Jan 2015 18:41:43 -0500 Received: from mail-qc0-f172.google.com ([209.85.216.172]:39724) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBu2l-0007O4-9G for 19363@debbugs.gnu.org; Thu, 15 Jan 2015 18:41:39 -0500 Received: by mail-qc0-f172.google.com with SMTP id i8so6111708qcq.3 for <19363@debbugs.gnu.org>; Thu, 15 Jan 2015 15:41:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:references:from:date:message-id:subject:to:cc :content-type; bh=Njqb4sfQtaSPR0Go/8/uJd8Xx3sINFIsALEjSf88Y8M=; b=aHBl5aKruBkUu1ccxWQRdXfQlnlPB+GW3uhR24Dzt14Mykk1gFwS/TOP9NZLCm5/QH gSZ5PtIGawsKxDq5wE/X96CyOWYmNwKJmkY95mc2qLsz7LCwvSmUvHILQxYSFsH5Zcc6 Ht/Ht6VpyHFo1OtzLTpZXSZU3MMHAyZdLJwCaQaNRoB1wZtrH7bZ/So1+Zm9DmNsy8ul bASIimOyeXkpMci3kIDwqDElnvExzWJ706op3GZIeAwUsfX2WrePG+u9UbUn9Jva9p6K Qg0IWZQoXt701COjso0rZzrKfFSFvzV8VKK4JWeIpsjHr8fGSBJtWuN8zk8LuoZ6XzqR 6g0g== X-Received: by 10.140.22.233 with SMTP id 96mr19321947qgn.86.1421365293603; Thu, 15 Jan 2015 15:41:33 -0800 (PST) MIME-Version: 1.0 References: <6ah9vrc3m8.fsf@fencepost.gnu.org> From: Kelvin White Date: Thu, 15 Jan 2015 23:41:33 +0000 Message-ID: Subject: Re: bug#19363: Close debbugs #19363 To: Glenn Morris Content-Type: multipart/alternative; boundary=001a11c152046be4f8050cb96533 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19363 Cc: 19363@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a11c152046be4f8050cb96533 Content-Type: text/plain; charset=UTF-8 I couldn't remember where I read that before, I was looking in admin and got sidetracked with work. Thanks Glenn On Thu, Jan 15, 2015, 1:15 PM Glenn Morris wrote: > > FYI, you haven't closed the bug report. > You do that by sending a mail to 19363-done. > (It may help to read the quick-start guide in admin/notes/bugtracker.) > > --001a11c152046be4f8050cb96533 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I couldn't remember where I read that before, I was look= ing in admin and got sidetracked with work.

Thanks Glenn


On Thu, Jan 15, 2015, 1:15 PM=C2=A0Glenn Mor= ris <rgm@gnu.org> wrote:

FYI, you haven't closed the bug report.
You do that by sending a mail to 19363-done.
(It may help to read the quick-start guide in admin/notes/bugtracker.)

--001a11c152046be4f8050cb96533-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 08:27:39 2015 Received: (at 19363-done) by debbugs.gnu.org; 16 Jan 2015 13:27:39 +0000 Received: from localhost ([127.0.0.1]:58559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC6w6-0003Nz-PG for submit@debbugs.gnu.org; Fri, 16 Jan 2015 08:27:39 -0500 Received: from mail-qc0-f182.google.com ([209.85.216.182]:39415) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC6w2-0003Nh-8r for 19363-done@debbugs.gnu.org; Fri, 16 Jan 2015 08:27:34 -0500 Received: by mail-qc0-f182.google.com with SMTP id l6so12870981qcy.13 for <19363-done@debbugs.gnu.org>; Fri, 16 Jan 2015 05:27:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:from:date:message-id:subject:to:content-type; bh=rQIdsGtvjezMXpqZUUj0Zet6eKM0jticeYG4aeuYqJU=; b=TVAftNslW45S/rHsq3ZMpuAh2BJ0xXb2EaaBT/MJH1wkHj47aMbLeIhQs5iCo8XJhd dC2dy3B8a+skrOCFQb0BZNmCMOdgTYfB2ZnvfOzDaFyZQsvpURove5ZlbedU+ElRgjyc mQxMgpG4TjEV0uN+mTUTlgu2VXUg8OhCbm4su4b3y75tqSd/c0XwZCnSK8/XIsj0GkZQ c81XthJuejI9dLFGLUjdja2V7q5arWvEHppslsg9AFmfmIY+zcZs0gmeNe0MXI+3Rd9r bj+jz6Y04Gtnxesx44C7QzYBJKuZ6zfpROxcye17LcR0RvmWSd1QuNgp10uW1fF19Rk3 SyrQ== X-Received: by 10.224.46.200 with SMTP id k8mr24801839qaf.89.1421414848663; Fri, 16 Jan 2015 05:27:28 -0800 (PST) MIME-Version: 1.0 From: Kelvin White Date: Fri, 16 Jan 2015 13:27:28 +0000 Message-ID: Subject: bug#19363 To: 19363-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary=001a11c2ec2822166b050cc4efd4 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19363-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a11c2ec2822166b050cc4efd4 Content-Type: text/plain; charset=UTF-8 patch installed --001a11c2ec2822166b050cc4efd4 Content-Type: text/html; charset=UTF-8 patch installed --001a11c2ec2822166b050cc4efd4-- From unknown Sun Jun 22 00:18:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Feb 2015 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator