From unknown Wed Jun 18 22:58:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19362 <19362@debbugs.gnu.org> To: bug#19362 <19362@debbugs.gnu.org> Subject: Status: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' Reply-To: bug#19362 <19362@debbugs.gnu.org> Date: Thu, 19 Jun 2025 05:58:52 +0000 retitle 19362 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' reassign 19362 emacs submitter 19362 Drew Adams severity 19362 minor tag 19362 moreinfo notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 21:47:22 2014 Received: (at submit) by debbugs.gnu.org; 13 Dec 2014 02:47:22 +0000 Received: from localhost ([127.0.0.1]:44304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xzcjq-00068c-6B for submit@debbugs.gnu.org; Fri, 12 Dec 2014 21:47:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45127) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xzcjm-00068L-JO for submit@debbugs.gnu.org; Fri, 12 Dec 2014 21:47:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzcjW-000590-Ry for submit@debbugs.gnu.org; Fri, 12 Dec 2014 21:47:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzcjW-00058w-Oz for submit@debbugs.gnu.org; Fri, 12 Dec 2014 21:47:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzcjO-0004zR-1L for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 21:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzcjF-00056h-8M for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 21:46:53 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzcjF-00056S-1M for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2014 21:46:45 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sBD2kfUt004104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 13 Dec 2014 02:46:42 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sBD2keeF016144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 13 Dec 2014 02:46:41 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id sBD2kdMw006763 for ; Sat, 13 Dec 2014 02:46:40 GMT MIME-Version: 1.0 Message-ID: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> Date: Fri, 12 Dec 2014 18:46:39 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Library `elisp-mode.el' was added after Emacs 24.4. Prior to that, functions such as `pp-eval-last-sexp' were aligned with the non-pp sister functions from `lisp-mode.el', such as `eval-last-sexp'. This is no longer the case. Please bring `pp.el' up to be parallel with the behavior of `elisp-mode.el', just as it was parallel with the same and similar code that was previously in `lisp-mode.el'. In particular, `pp-eval-last-sexp' had the same evaluation behavior as `eval-lisp-mode'. The addition of pretty-printing was pretty much the only difference. The two no longer correspond. Please fix this disparity. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 12:26:10 2016 Received: (at 19362) by debbugs.gnu.org; 30 Apr 2016 16:26:10 +0000 Received: from localhost ([127.0.0.1]:58102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awXib-0003eA-Sl for submit@debbugs.gnu.org; Sat, 30 Apr 2016 12:26:10 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:58258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awXiZ-0003e1-Vw for 19362@debbugs.gnu.org; Sat, 30 Apr 2016 12:26:08 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awXiV-0004HJ-Fu; Sat, 30 Apr 2016 18:26:05 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> Date: Sat, 30 Apr 2016 18:26:03 +0200 In-Reply-To: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> (Drew Adams's message of "Fri, 12 Dec 2014 18:46:39 -0800 (PST)") Message-ID: <87h9ejkqqs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19362 Cc: 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > Library `elisp-mode.el' was added after Emacs 24.4. Prior to that, > functions such as `pp-eval-last-sexp' were aligned with the non-pp > sister functions from `lisp-mode.el', such as `eval-last-sexp'. > > This is no longer the case. Please bring `pp.el' up to be parallel with > the behavior of `elisp-mode.el', just as it was parallel with the same > and similar code that was previously in `lisp-mode.el'. > > In particular, `pp-eval-last-sexp' had the same evaluation behavior as > `eval-lisp-mode'. The addition of pretty-printing was pretty much the > only difference. The two no longer correspond. Please fix this > disparity. What are the differences you think should be fixed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 13:37:02 2016 Received: (at 19362) by debbugs.gnu.org; 30 Apr 2016 17:37:03 +0000 Received: from localhost ([127.0.0.1]:58249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYpC-0005KP-LI for submit@debbugs.gnu.org; Sat, 30 Apr 2016 13:37:02 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYpB-0005Jt-0q for 19362@debbugs.gnu.org; Sat, 30 Apr 2016 13:37:01 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3UHasiS010520 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Apr 2016 17:36:55 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u3UHasJR018441 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Apr 2016 17:36:54 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u3UHarYb012789; Sat, 30 Apr 2016 17:36:54 GMT MIME-Version: 1.0 Message-ID: <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> Date: Sat, 30 Apr 2016 09:36:52 -0800 (GMT-08:00) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> In-Reply-To: <87h9ejkqqs.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 19362 Cc: 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > Library `elisp-mode.el' was added after Emacs 24.4. Prior to that, > > functions such as `pp-eval-last-sexp' were aligned with the non-pp > > sister functions from `lisp-mode.el', such as `eval-last-sexp'. > > > > This is no longer the case. Please bring `pp.el' up to be parallel wit= h > > the behavior of `elisp-mode.el', just as it was parallel with the same > > and similar code that was previously in `lisp-mode.el'. > > > > In particular, `pp-eval-last-sexp' had the same evaluation behavior as > > `eval-lisp-mode'. The addition of pretty-printing was pretty much the > > only difference. The two no longer correspond. Please fix this > > disparity. >=20 > What are the differences you think should be fixed? Should be aligned as it was before. Someone evolved the one without evolving the other in tandem. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 13:43:39 2016 Received: (at 19362) by debbugs.gnu.org; 30 Apr 2016 17:43:39 +0000 Received: from localhost ([127.0.0.1]:58257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYvb-0005UG-MH for submit@debbugs.gnu.org; Sat, 30 Apr 2016 13:43:39 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:59028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYvZ-0005U6-Ck for 19362@debbugs.gnu.org; Sat, 30 Apr 2016 13:43:38 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awYvV-00050H-VZ; Sat, 30 Apr 2016 19:43:35 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> Date: Sat, 30 Apr 2016 19:43:33 +0200 In-Reply-To: <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> (Drew Adams's message of "Sat, 30 Apr 2016 09:36:52 -0800 (GMT-08:00)") Message-ID: <87eg9nf0vu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19362 Cc: 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: >> > Library `elisp-mode.el' was added after Emacs 24.4. Prior to that, >> > functions such as `pp-eval-last-sexp' were aligned with the non-pp >> > sister functions from `lisp-mode.el', such as `eval-last-sexp'. >> > >> > This is no longer the case. Please bring `pp.el' up to be parallel with >> > the behavior of `elisp-mode.el', just as it was parallel with the same >> > and similar code that was previously in `lisp-mode.el'. >> > >> > In particular, `pp-eval-last-sexp' had the same evaluation behavior as >> > `eval-lisp-mode'. The addition of pretty-printing was pretty much the >> > only difference. The two no longer correspond. Please fix this >> > disparity. >> >> What are the differences you think should be fixed? > > Should be aligned as it was before. Someone evolved the one > without evolving the other in tandem. Do you have a list of things that you think should be aligned? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:16:33 2016 Received: (at 19362) by debbugs.gnu.org; 30 Apr 2016 18:16:33 +0000 Received: from localhost ([127.0.0.1]:58298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZRR-0007Vc-1h for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:16:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZRO-0007Pm-Jf for 19362@debbugs.gnu.org; Sat, 30 Apr 2016 14:16:30 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3UIGOSZ003814 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 18:16:24 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u3UIGO9q024512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 18:16:24 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3UIGNgY018934; Sat, 30 Apr 2016 18:16:23 GMT MIME-Version: 1.0 Message-ID: <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> Date: Sat, 30 Apr 2016 10:16:22 -0800 (GMT-08:00) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> In-Reply-To: <87eg9nf0vu.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 19362 Cc: 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Do you have a list of things that you think should be aligned? No, but diff of the source code should show it. ;-) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:33:56 2016 Received: (at 19362) by debbugs.gnu.org; 30 Apr 2016 18:33:56 +0000 Received: from localhost ([127.0.0.1]:58369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZiG-0001d3-B6 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:33:56 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:59459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZiE-0001cu-Ho for 19362@debbugs.gnu.org; Sat, 30 Apr 2016 14:33:54 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awZiC-0005ST-1Y; Sat, 30 Apr 2016 20:33:53 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> Date: Sat, 30 Apr 2016 20:33:51 +0200 In-Reply-To: <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> (Drew Adams's message of "Sat, 30 Apr 2016 10:16:22 -0800 (GMT-08:00)") Message-ID: <8760uzdjzk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19362 Cc: 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: >> Do you have a list of things that you think should be aligned? > > No, but diff of the source code should show it. ;-) I'm afraid that if you don't have anything specific you want to have fixed, there won't be any more progress happening in this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 22:04:43 2016 Received: (at 19362) by debbugs.gnu.org; 1 Jul 2016 02:04:43 +0000 Received: from localhost ([127.0.0.1]:32933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bInox-0006pX-Mc for submit@debbugs.gnu.org; Thu, 30 Jun 2016 22:04:43 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:36343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bInov-0006pE-Sc; Thu, 30 Jun 2016 22:04:42 -0400 Received: by mail-it0-f51.google.com with SMTP id a5so7098155ita.1; Thu, 30 Jun 2016 19:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bAN+uOsvbaE6RUwSdFUW0hy8vMkUpmsQQxrTLrSw9kM=; b=JHcB9XUIGM/4qJOlb17uewEX7PvsyhM9P1xmYS8PWUy1mfiUzD7N961u0fv6XK6tZv HBjXdZlCKxB1I+tio7xy6cI99pgS3PIlX2+VKRzegE5IQnW6lDOAbL41gUykz/jSSts/ lU7YteE4uA1K5wcBaVb5XXvP8ZeY3+dIxRdmq6O6TOKXludrlxGEE+inA/tGk8+J3Un4 vbc9UTUMYVLUoXGDsyAFue8BlGvCTYw09DB8iP626hkyk7msQMNM7BtZgSMnHgxmnjeg lc85BdsGtTHuXkFZ+Rv0MO4AUO7KAA07qnbCrZqxTOf01IE9QHd5+VKNQIE1e0oMk50P xQPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bAN+uOsvbaE6RUwSdFUW0hy8vMkUpmsQQxrTLrSw9kM=; b=JSlG6rWuQP+WYu2jP2zQVIRb0/AS5Sc9Bcd2WNPFbCHvcONhNsJctgl2gnsubrEqAo 7iRimn4KeKutPUpKmlVYaL3YyfHZzktBH5lfI8WrZmibYr0c5FWTV8VB1tavLmUkJnWV m/8ThGsFCiEoINdxLmm5JjNqnYr2DzRek+uni7iCzQTibf8JiwmS7SodTbe5PoVzb3TY PR6iDhFwdLSA5ElaYyDAr+vls9Q5PoNg2p8s4nxSNfvOJJgL60PbPnUNLvvq/9YO3DYK u4i6GyzkR9pynniI/3UgZTundMVNNmJ7ZbIuhixQ54Ue0UNwKWA2GBLtGT0NAiUrezbQ ZTtg== X-Gm-Message-State: ALyK8tK6t68PBoNzqRQk0roUNn2cW/xZ4Dm4iuoedENJJQ9QaPJcHipiU6j2XbwPZm0HLw== X-Received: by 10.36.81.15 with SMTP id s15mr18634060ita.57.1467338676502; Thu, 30 Jun 2016 19:04:36 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id x41sm5151677ioi.25.2016.06.30.19.04.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 19:04:35 -0700 (PDT) From: npostavs@users.sourceforge.net To: Drew Adams Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> Date: Thu, 30 Jun 2016 22:04:44 -0400 In-Reply-To: <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> (Drew Adams's message of "Sat, 30 Apr 2016 10:16:22 -0800 (GMT-08:00)") Message-ID: <87poqyi05f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 19362 moreinfo quit Drew Adams writes: >> Do you have a list of things that you think should be aligned? > > No, but diff of the source code should show it. ;-) I tried diffing pp.el and elisp-mode.el, but it was unenlightening. Like this bug report. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 30 23:08:05 2016 Received: (at 19362) by debbugs.gnu.org; 1 Jul 2016 03:08:05 +0000 Received: from localhost ([127.0.0.1]:32968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIooH-0004gS-2j for submit@debbugs.gnu.org; Thu, 30 Jun 2016 23:08:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIooF-0004fx-G9 for 19362@debbugs.gnu.org; Thu, 30 Jun 2016 23:08:03 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6137upW023989 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Jul 2016 03:07:57 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u6137tWS022320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jul 2016 03:07:55 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u6137q3u014989; Fri, 1 Jul 2016 03:07:54 GMT MIME-Version: 1.0 Message-ID: Date: Thu, 30 Jun 2016 20:07:51 -0700 (PDT) From: Drew Adams To: npostavs@users.sourceforge.net Subject: RE: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> In-Reply-To: <87poqyi05f.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > >> Do you have a list of things that you think should be aligned? > > > > No, but diff of the source code should show it. ;-) >=20 > I tried diffing pp.el and elisp-mode.el, but it was unenlightening. > Like this bug report. Yes, well, it's quite difficult. Some of the code from lisp-mode.el was moved to elisp-mode.el. And then it was modified, in some cases radically. Dunno why, except that some of the changes seem to have involved integrating eldoc. But most of the changes presumably do not concern this bug, which is only about the part of lisp-mode.el that had functions that correspond to pp.el functions.) =3D=3D=3D> The starting point is `eval-last-sexp', which used to correspond directly with `pp-eval-last-sexp'. The former was (presumably) improved, but the latter was not modified similarly. Some functions were renamed to add the prefix `elisp-' or `elisp--' (e.g. `elisp--preceding-sexp', `elisp--eval-last-sexp', `elisp--eval-last-sexp-print-value', `elisp--eval-last-sexp-fake-value', `elisp--eval-defun-1', `elisp--eval-defun'), so knowing that can help. In some cases they were just renamed. In other cases the code was changed quite a bit. But again, this bug is only about the pp-like code. This is not something you will understand in 5 minutes. It likely requires understanding the changes that were made to `eval-last-sexp' and its supporting functions, and then doing the right thing (not necessarily exactly the same thing) for `pp-eval-last-sexp'. The pp.el code was slightly different from the Emacs 24.4 (and prior) lisp-mode.el code (different helper functions, and one does not involve pretty-printing), but they generally mirror one another. Using their former correspondence as a guide should help. I cannot help more than this. It is unfortunate that the person who changed the non-pp version did not think to act similarly for the pp version. I discovered it late, myself. Once things are properly understood, perhaps the code fix will be minor. Dunno. With luck, you will find and understand the changes made to `eval-last-sexp' as a straightforward improvement that do not involve all of the other changes from lisp-mode.el code to elisp-mode.el code. With luck, perhaps the person(s) who made the changes to the non-pp code can look at this bug. No doubt that would be easiest. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 16:39:24 2016 Received: (at 19362) by debbugs.gnu.org; 6 Jul 2016 20:39:24 +0000 Received: from localhost ([127.0.0.1]:39915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKtbP-0004Q9-Lu for submit@debbugs.gnu.org; Wed, 06 Jul 2016 16:39:23 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:35852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKtbN-0004Pv-MF for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 16:39:22 -0400 Received: by mail-oi0-f41.google.com with SMTP id f189so287249150oig.3 for <19362@debbugs.gnu.org>; Wed, 06 Jul 2016 13:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=silCjUTkNwNx+3UwQI81OMyeGWjZwBo8XeLo7Lu/1cY=; b=dMTiljywU2ZKiJBQnWY5yDEjK3wDW362rIU98Hvw2jP/EfO80HSrV7F3HKpUGJlb0Z rzuaagSaMz3NGVG8X98uh+JW0gY4/+6/WVSPakVIMZeSkXFF5Ywj9RmCK6y3kjNEDfSy zu9j/1HMlYjEnfF4M+gJ/ogQUxmCk4vowZ/mvUePyh9sF2L0CgpujV8y+SV8N/TgqY/q JyXWUpG7TMUII0kaMOaBFgwB1rQH2v3Ipy81QZOf/jUHMzErAWl01DD+754yJQ2MiX/w xcQVl7p9bJINJms8JqzapFqEAhsN8Oa3LHoHsKH7CcND+vjoUkhqYseWTlZm1SqtyiA2 hZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=silCjUTkNwNx+3UwQI81OMyeGWjZwBo8XeLo7Lu/1cY=; b=fcuXmay7pYLV5o4XEJMVu5yIUkfWgn+JuDOg5xQZOGgDO98sFPREO9ggUBgbdqQ87D qRI+y70wB6EwQoAhix1gXN20FYkl4J2+klnlkgIst+99CwbhP4byZQhYkW2mhNJBIdwI +EVIS7CZvmtQCNkOAvTnCF+Oq5oo5xmuyg3YOwww5gwG7jcss9SawcJ1nGrw9Kz49AqF 2fDCQG35lqmt4spWsIfCvsdbL5OthTHzNnsFcePBA0SlaNWvuPH6ux4ptq9tYRZqdRus aVro8FCUcpZAqSuUnPPz9qV2Yf/SoSj03i8goz8Chfpj4bJaERET3rWldtVgSucy2NlK S6sQ== X-Gm-Message-State: ALyK8tKK5ilU1NNSyR2IkV06bSEe5MQCINwY3QTFfvjCdS+UgMsXpvjFiYZ+wBFVgMTy/+Colm8GNeLLB6Cd3Q== X-Received: by 10.202.207.16 with SMTP id f16mr13203554oig.178.1467837556039; Wed, 06 Jul 2016 13:39:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.4.197 with HTTP; Wed, 6 Jul 2016 13:39:15 -0700 (PDT) In-Reply-To: References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> From: Noam Postavsky Date: Wed, 6 Jul 2016 16:39:15 -0400 X-Google-Sender-Auth: utIA_jCk0SdH7DlrK3PLBXLZ9f8 Message-ID: Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' To: Drew Adams Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Jun 30, 2016 at 11:07 PM, Drew Adams wrote: >> >> Do you have a list of things that you think should be aligned? >> > >> > No, but diff of the source code should show it. ;-) >> >> I tried diffing pp.el and elisp-mode.el, but it was unenlightening. >> Like this bug report. > > Yes, well, it's quite difficult. Some of the code from lisp-mode.el > was moved to elisp-mode.el. And then it was modified, in some cases > radically. Dunno why, except that some of the changes seem to have > involved integrating eldoc. But most of the changes presumably do not > concern this bug, which is only about the part of lisp-mode.el that > had functions that correspond to pp.el functions.) > > ===> The starting point is `eval-last-sexp', which used to correspond > directly with `pp-eval-last-sexp'. The former was (presumably) > improved, but the latter was not modified similarly. > > Some functions were renamed to add the prefix `elisp-' or `elisp--' > (e.g. `elisp--preceding-sexp', `elisp--eval-last-sexp', > `elisp--eval-last-sexp-print-value', `elisp--eval-last-sexp-fake-value', > `elisp--eval-defun-1', `elisp--eval-defun'), so knowing that can help. > In some cases they were just renamed. In other cases the code was > changed quite a bit. But again, this bug is only about the pp-like > code. > > This is not something you will understand in 5 minutes. It likely > requires understanding the changes that were made to `eval-last-sexp' > and its supporting functions, and then doing the right thing (not > necessarily exactly the same thing) for `pp-eval-last-sexp'. The > pp.el code was slightly different from the Emacs 24.4 (and prior) > lisp-mode.el code (different helper functions, and one does not > involve pretty-printing), but they generally mirror one another. > Using their former correspondence as a guide should help. > > I cannot help more than this. It is unfortunate that the person > who changed the non-pp version did not think to act similarly for > the pp version. I discovered it late, myself. Once things are > properly understood, perhaps the code fix will be minor. Dunno. But do you know of any concrete cases where there is a difference in behaviour? Or is this report just about code duplication (or lack thereof)? I found #10495 "pp-eval-last-sexp doesn't work on a `symbol' in quotes", but that was reported against 24.0.92, so perhaps these functions were in fact never "aligned"? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 18:36:02 2016 Received: (at 19362) by debbugs.gnu.org; 6 Jul 2016 22:36:02 +0000 Received: from localhost ([127.0.0.1]:39967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKvQI-0007M8-0f for submit@debbugs.gnu.org; Wed, 06 Jul 2016 18:36:02 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKvQG-0007Ln-Bh for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 18:36:00 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u66MZqXO005752 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2016 22:35:52 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u66MZp3d004563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2016 22:35:52 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u66MZoqV003867; Wed, 6 Jul 2016 22:35:51 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 6 Jul 2016 22:35:49 +0000 (UTC) From: Drew Adams To: Noam Postavsky Subject: RE: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > But do you know of any concrete cases where there is a difference in > behaviour? Or is this report just about code duplication (or lack > thereof)? 1. I don't know about concrete cases; sorry. 2. This report is an enhancement request; it doesn't report a bug. In the past, `eval-last-sexp' and `pp-eval-last-sexp' did about the same thing, apart from the pretty-printing part (which the latter farms out to another function). My guess is that _improvements_ were made to the former case (only). Just what those improvements were and why they were made I don't know. > I found #10495 "pp-eval-last-sexp doesn't work on a `symbol' in > quotes", but that was reported against 24.0.92, so perhaps these > functions were in fact never "aligned"? The functions used to be mostly "aligned", but it's possible that the difference Michael points out in #10495 was present. I don't know. In any case, I was not really referring to the interactive behavior but to the code/behavior after the sexp has been determined. In the case of `eval-last-sexp' I guess that means the code other than `elisp--preceding-sexp'. I'm interested in both, but I don't think I was paying attention to differences that are covered by the `elisp--preceding-sexp' code. Michael's bug is all about extending what `elisp--preceding-sexp' does to pp.el. It could perhaps be a good start, in terms of realignment. On the other hand, that behavior seems to be overly DWIM, making heuristic assumptions about what sexp you _really_ wanted to evaluate. I'm not sure that's always such a good thing. I'd probably rather have that DWIM be a user choice (option). `pp-eval-last-sexp' is much simpler. In any case, what `elisp--preceding-sexp' is/does is not really what I had in mind about the code divergence, as you rightfully observed. So I guess this bug report is somewhat complementary to Michael's report. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 19:37:03 2016 Received: (at 19362) by debbugs.gnu.org; 6 Jul 2016 23:37:03 +0000 Received: from localhost ([127.0.0.1]:39992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKwNL-0001yZ-Lq for submit@debbugs.gnu.org; Wed, 06 Jul 2016 19:37:03 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKwNJ-0001y4-9R for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 19:37:03 -0400 Received: by mail-oi0-f42.google.com with SMTP id u201so2524186oie.0 for <19362@debbugs.gnu.org>; Wed, 06 Jul 2016 16:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eVhBL2ybiaWCz/5OX9XrdfUQtH5YETQFHBovtaVLkdI=; b=uRJ6HBPqZf3NonmECN61AaAq7uHHRXk5e+hZfdO/0b6Qjk4buc3sVLX5dwGtZETu3i 7mL28qJy5A6niLJJto5oGqkDcbAp9Vs25jlLBv7wOeBeuOj6DJkry3rLlSxN+AcsgmJC 5El9Ie0weS/n0+RNK3NdWoqUkrFxguPBeDEhp4wOxJxF5pXNJWszw/LzIhMjbKW1dJii wSafBij/kfjJwp/I9Q0s72WXv3di/2qdc9J1kIO+O06lVKZSgdorBvbW39VIly1WlpCP IKXNnU0uE2AVXmilIyUTLBs924lL35DvXgqdDcHpp25EW7dfd9Yo7NlF5Tl4GZ/L1qey sJUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=eVhBL2ybiaWCz/5OX9XrdfUQtH5YETQFHBovtaVLkdI=; b=QdqtkVEa2evtRcULIHSxr2YdnRVLtAlwNn4XPpfbcX0mZC/dGREHmuuMs5R48ZK50a mFX6QUV0XEd4h1He9cdmi9FLrqu3y3nFW1D5Qbke5AxRp0Uu1pCS/XaISZ/up2imlW3S i1SXBAraCVC0C/6mU2MqWHNeaRDUkmk9oW0KIjCyoKmdbDBoem0hZ5WbCH8yONWa7yle tUAQRAUfXHnDKPTffjTa9WKQzuOtfFMkGKDZ8WdGOwLkVIeIkKln4Wh/SZ/eOaifTUT9 jAnfTM9phhhl8d/hR35mt2/T5t8QJqSzxH0i8YJqXzhScMAV8zG2k28HcmjTjMqP+86Y GfFg== X-Gm-Message-State: ALyK8tL3JibDvS37GEH384kaON41KLTEvuZzLmdKECaR7LFC3T9xyxyj1WgU4qnKz5KChxAiWSVAtmD3M+SP+w== X-Received: by 10.202.207.16 with SMTP id f16mr13522733oig.178.1467848215777; Wed, 06 Jul 2016 16:36:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.4.197 with HTTP; Wed, 6 Jul 2016 16:36:55 -0700 (PDT) In-Reply-To: References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> From: Noam Postavsky Date: Wed, 6 Jul 2016 19:36:55 -0400 X-Google-Sender-Auth: vmnwG9jhwgInRPMUVYMD3FwyjgA Message-ID: Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' To: Drew Adams Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Jul 6, 2016 at 6:35 PM, Drew Adams wrote: >> But do you know of any concrete cases where there is a difference in >> behaviour? Or is this report just about code duplication (or lack >> thereof)? > > 1. I don't know about concrete cases; sorry. > > 2. This report is an enhancement request; it doesn't report a bug. > > In the past, `eval-last-sexp' and `pp-eval-last-sexp' did about the > same thing, apart from the pretty-printing part (which the latter > farms out to another function). So you're not talking about the difference between pp-to-string vs elisp--eval-last-sexp-print-value. > My guess is that _improvements_ > were made to the former case (only). Just what those improvements > were and why they were made I don't know. [...] > In any case, I was not really referring to the interactive behavior > but to the code/behavior after the sexp has been determined. In > the case of `eval-last-sexp' I guess that means the code other > than `elisp--preceding-sexp'. And you're not talking about the difference between (pp-last-sexp) vs (eval-sexp-add-defvars (elisp--preceding-sexp)). What's left? They both call eval in the middle. eval-last-sexp honours eval-expression-debug-on-error while pp-eval-last-sexp does not (this was the case for the old lisp-mode.el code in 24.3 as well). Other than that I don't see anything of significance. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 19:51:57 2016 Received: (at 19362) by debbugs.gnu.org; 6 Jul 2016 23:51:58 +0000 Received: from localhost ([127.0.0.1]:40013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKwbl-0002Kz-MY for submit@debbugs.gnu.org; Wed, 06 Jul 2016 19:51:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKwbj-0002Kj-NK for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 19:51:56 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u66Npnxp012649 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2016 23:51:49 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u66NpnCe012951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2016 23:51:49 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u66NpmXr030950; Wed, 6 Jul 2016 23:51:48 GMT MIME-Version: 1.0 Message-ID: <126bba1e-3f86-4ae3-b7b5-59532f62e4f6@default> Date: Wed, 6 Jul 2016 23:51:47 +0000 (UTC) From: Drew Adams To: Noam Postavsky Subject: RE: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > > In the past, `eval-last-sexp' and `pp-eval-last-sexp' did about the > > same thing, apart from the pretty-printing part (which the latter > > farms out to another function). >=20 > So you're not talking about the difference between pp-to-string vs > elisp--eval-last-sexp-print-value. >=20 > > My guess is that _improvements_ > > were made to the former case (only). Just what those improvements > > were and why they were made I don't know. > [...] > > In any case, I was not really referring to the interactive behavior > > but to the code/behavior after the sexp has been determined. In > > the case of `eval-last-sexp' I guess that means the code other > > than `elisp--preceding-sexp'. >=20 > And you're not talking about the difference between (pp-last-sexp) vs > (eval-sexp-add-defvars (elisp--preceding-sexp)). >=20 > What's left? They both call eval in the middle. eval-last-sexp honours > eval-expression-debug-on-error while pp-eval-last-sexp does not (this > was the case for the old lisp-mode.el code in 24.3 as well). Other > than that I don't see anything of significance. Sorry, but I have no more time to devote to this. I pointed to a time where the code was more or less the same between the two, and to a time where it had been changed to be really quite different. It seemed (and still seems) clear to me that the non-pp version was altered considerably - probably improving something, or adapting to some other change (lexical binding, perhaps?), and the pp version was not altered similarly. My guess is that the pp version was considered less important or was simply overlooked/ignored. I think it deserves a similar look. If no one wants to do that, so be it. If you feel you've taken a careful look and understand what changed and why, and that none of the changes can be usefully extended to pp, fine. I'm not looking at this anymore, so you'll get no argument from me. I think I've said all I want to say about this. Thanks for having taken a look. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 20:26:50 2016 Received: (at 19362) by debbugs.gnu.org; 7 Jul 2016 00:26:50 +0000 Received: from localhost ([127.0.0.1]:40040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKx9V-0006U1-VV for submit@debbugs.gnu.org; Wed, 06 Jul 2016 20:26:50 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:37960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKx9S-0006Ti-Vy; Wed, 06 Jul 2016 20:26:47 -0400 Received: by mail-it0-f41.google.com with SMTP id h190so9041353ith.1; Wed, 06 Jul 2016 17:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/mIR2JOO2U93ajQZF3evH6vRCWhi4oo2Iz03A/5RbLA=; b=LGrLfbXabp3z07D8bXx7hX5Lc9bRjDxoozI0Dfeypz6ZybyRLBK7aUpiyv0bUPE08H Lc5DCZqmdUpXBsqo6zvGwQu+wQmNJAZGhRX7x1pZMqa/G2x07h2JT7iQ6lSzleTGAq1g J7HERS04o55JJUqCUJooD/MtDjx/2bdiYDzgPm2CooATJXJ0i50nSxp2ebxDZ5INBxpj VY4vGOLFHBZbP9cjXkHigOQ3/3bswzbtxuxRMT0Aft1ikZA9AJl+Odeb+qCU4oJyKHJn oT/1gcixxiQfbbfB9XBnUyqhfd6gPGOHuEIZIQFWA7iJ9b0jkhChxGJFSv20JmS+fFp2 wpqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/mIR2JOO2U93ajQZF3evH6vRCWhi4oo2Iz03A/5RbLA=; b=FuATsNqCHaIT4Ih+u0cL2LBYn3D8VHJwl4naiDlF4cZTNxUxtK+AaMdAeyNvBEelRR wmqHl6nwcchQWLoV4cD9YmRDGGToJuaRhzLghjOfz/vaTIyjAT7EsVJXjrk8Q2cT8Rl7 RxhMRykhCEXrRU5fAVN1EV5+YWM2M60ij88ZCnGdDdU1f3Wj97nh6aetB6t8DJrYn3gZ ipEE++7M4Ce7L591T9Mry9I1Sh+VW0Epnq6FWbo2j+oP2EYCCCrfyUmo7TMtHHoWVK7Y T0pXBg19nkq8aLSFyHG22U95SN1XGHUkw4KcwVX9InAP/KeekZhA4edP9sMjAhUNts/X kn4w== X-Gm-Message-State: ALyK8tLTjBdPwl21u8vdBKH/I3Q27jqgNR0ippLyz3aUyJv/7RohYhvQDwIPh4pwEU8lbw== X-Received: by 10.36.227.68 with SMTP id d65mr21886380ith.75.1467851201525; Wed, 06 Jul 2016 17:26:41 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id d71sm79240ith.2.2016.07.06.17.26.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 17:26:40 -0700 (PDT) From: npostavs@users.sourceforge.net To: Drew Adams Subject: Re: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> <126bba1e-3f86-4ae3-b7b5-59532f62e4f6@default> Date: Wed, 06 Jul 2016 20:26:49 -0400 In-Reply-To: <126bba1e-3f86-4ae3-b7b5-59532f62e4f6@default> (Drew Adams's message of "Wed, 6 Jul 2016 23:51:47 +0000 (UTC)") Message-ID: <87bn2acmye.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable tags 19362 notabug close 19362 quit Drew Adams writes: > > Sorry, but I have no more time to devote to this. I pointed to a > time where the code was more or less the same between the two, and > to a time where it had been changed to be really quite different. Well, we could have all saved some time if you had taken your own advice to diff the code; not pp.el vs elisp-mode.el, but emacs-24.5's lisp-mode.el vs the new elisp-mode.el. You can see in the attached diff (exerpted to leave only the relevant functions) that the only changes are renaming of functions, and some minor refactoring in elisp--preceding-sexp (it now handles =E2=80=98foo=E2=80=99 as well as `foo= '). --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=elisp-lisp-mode.diff Content-Transfer-Encoding: quoted-printable Content-Description: diff excerpts --- /home/npostavs/src/emacs/emacs-24.5/lisp/emacs-lisp/lisp-mode.el 2016-0= 5-21 14:56:43.119505998 -0400 +++ /home/npostavs/src/emacs/emacs-25/lisp/progmodes/elisp-mode.el 2016-06-= 27 00:32:51.740892449 -0400 @@ -879,14 +970,14 @@ =20 =20 (defun last-sexp-setup-props (beg end value alt1 alt2) - "Set up text properties for the output of `eval-last-sexp-1'. + "Set up text properties for the output of `elisp--eval-last-sexp'. BEG and END are the start and end of the output in current-buffer. VALUE is the Lisp value printed, ALT1 and ALT2 are strings for the alternative printed representations that can be displayed." (let ((map (make-sparse-keymap))) - (define-key map "\C-m" 'last-sexp-toggle-display) + (define-key map "\C-m" 'elisp-last-sexp-toggle-display) (define-key map [down-mouse-2] 'mouse-set-point) - (define-key map [mouse-2] 'last-sexp-toggle-display) + (define-key map [mouse-2] 'elisp-last-sexp-toggle-display) (add-text-properties beg end `(printed-value (,value ,alt1 ,alt2) @@ -897,7 +988,7 @@ printed-value))))) =20 =20 -(defun last-sexp-toggle-display (&optional _arg) +(defun elisp-last-sexp-toggle-display (&optional _arg) "Toggle between abbreviated and unabbreviated printed representations." (interactive "P") (save-restriction @@ -920,7 +1011,7 @@ (nth 1 value)) (goto-char (min (point-max) point))))))) =20 -(defun prin1-char (char) +(defun prin1-char (char) ;FIXME: Move it, e.g. to simple.el. "Return a string representing CHAR as a character rather than as an inte= ger. If CHAR is not a character, return nil." (and (integerp char) @@ -956,19 +1047,20 @@ (=3D (car (read-from-string string)) char) string)))) =20 - -(defun preceding-sexp () +(defun elisp--preceding-sexp () "Return sexp before the point." (let ((opoint (point)) - ignore-quotes + (left-quote ?=E2=80=98) expr) (save-excursion (with-syntax-table emacs-lisp-mode-syntax-table - ;; If this sexp appears to be enclosed in `...' + ;; If this sexp appears to be enclosed in `...' or =E2=80=98...=E2=80=99 ;; then ignore the surrounding quotes. - (setq ignore-quotes - (or (eq (following-char) ?\') - (eq (preceding-char) ?\'))) + (cond ((eq (preceding-char) ?=E2=80=99) + (progn (forward-char -1) (setq opoint (point)))) + ((or (eq (following-char) ?\') + (eq (preceding-char) ?\')) + (setq left-quote ?\`))) (forward-sexp -1) ;; If we were after `?\e' (or similar case), ;; use the whole thing, not just the `e'. @@ -992,43 +1084,37 @@ (forward-sexp -1)))) =20 (save-restriction - ;; vladimir@cs.ualberta.ca 30-Jul-1997: skip ` in - ;; `variable' so that the value is returned, not the - ;; name - (if (and ignore-quotes - (eq (following-char) ?`)) + (if (eq (following-char) left-quote) + ;; vladimir@cs.ualberta.ca 30-Jul-1997: Skip ` in `variable'= so + ;; that the value is returned, not the name. (forward-char)) + (when (looking-at ",@?") (goto-char (match-end 0))) (narrow-to-region (point-min) opoint) (setq expr (read (current-buffer))) - ;; If it's an (interactive ...) form, it's more - ;; useful to show how an interactive call would - ;; use it. - (and (consp expr) - (eq (car expr) 'interactive) + ;; If it's an (interactive ...) form, it's more useful to show h= ow an + ;; interactive call would use it. + ;; FIXME: Is it really the right place for this? + (when (eq (car-safe expr) 'interactive) (setq expr - (list 'call-interactively - (list 'quote - (list 'lambda - '(&rest args) - expr - 'args))))) + `(call-interactively + (lambda (&rest args) ,expr args)))) expr))))) +(define-obsolete-function-alias 'preceding-sexp 'elisp--preceding-sexp "25= .1") =20 - -(defun eval-last-sexp-1 (eval-last-sexp-arg-internal) +(defun elisp--eval-last-sexp (eval-last-sexp-arg-internal) "Evaluate sexp before point; print value in the echo area. -With argument, print output into current buffer. -With a zero prefix arg, print output with no limit on the length -and level of lists, and include additional formats for integers -\(octal, hexadecimal, and character)." +If EVAL-LAST-SEXP-ARG-INTERNAL is non-nil, print output into +current buffer. If EVAL-LAST-SEXP-ARG-INTERNAL is `0', print +output with no limit on the length and level of lists, and +include additional formats for integers \(octal, hexadecimal, and +character)." (let ((standard-output (if eval-last-sexp-arg-internal (current-buffer) = t))) ;; Setup the lexical environment if lexical-binding is enabled. - (eval-last-sexp-print-value - (eval (eval-sexp-add-defvars (preceding-sexp)) lexical-binding) + (elisp--eval-last-sexp-print-value + (eval (eval-sexp-add-defvars (elisp--preceding-sexp)) lexical-binding) eval-last-sexp-arg-internal))) =20 - -(defun eval-last-sexp-print-value (value &optional eval-last-sexp-arg-inte= rnal) +(defun elisp--eval-last-sexp-print-value (value &optional eval-last-sexp-a= rg-internal) (let ((unabbreviated (let ((print-length nil) (print-level nil)) (prin1-to-string value))) (print-length (and (not (zerop (prefix-numeric-value @@ -1055,7 +1141,7 @@ )))) =20 =20 -(defvar eval-last-sexp-fake-value (make-symbol "t")) +(defvar elisp--eval-last-sexp-fake-value (make-symbol "t")) =20 (defun eval-sexp-add-defvars (exp &optional pos) "Prepend EXP with all the `defvar's that precede it in the buffer. @@ -1092,16 +1178,16 @@ this command arranges for all errors to enter the debugger." (interactive "P") (if (null eval-expression-debug-on-error) - (eval-last-sexp-1 eval-last-sexp-arg-internal) + (elisp--eval-last-sexp eval-last-sexp-arg-internal) (let ((value - (let ((debug-on-error eval-last-sexp-fake-value)) - (cons (eval-last-sexp-1 eval-last-sexp-arg-internal) + (let ((debug-on-error elisp--eval-last-sexp-fake-value)) + (cons (elisp--eval-last-sexp eval-last-sexp-arg-internal) debug-on-error)))) - (unless (eq (cdr value) eval-last-sexp-fake-value) + (unless (eq (cdr value) elisp--eval-last-sexp-fake-value) (setq debug-on-error (cdr value))) (car value)))) =20 -(defun eval-defun-1 (form) +(defun elisp--eval-defun-1 (form) "Treat some expressions specially. Reset the `defvar' and `defcustom' variables to the initial value. \(For `defcustom', use the :set function if there is one.) @@ -1144,17 +1230,17 @@ (put face-symbol 'face-override-spec nil)) form) ((eq (car form) 'progn) - (cons 'progn (mapcar 'eval-defun-1 (cdr form)))) + (cons 'progn (mapcar #'elisp--eval-defun-1 (cdr form)))) (t form))) =20 -(defun eval-defun-2 () +(defun elisp--eval-defun () "Evaluate defun that point is in or before. The value is displayed in the echo area. If the current defun is actually a call to `defvar', then reset the variable using the initial value expression even if the variable already has some other value. \(Normally `defvar' does not change the variable's value -if it already has a value.\) +if it already has a value.) =20 Return the result of evaluation." ;; FIXME: the print-length/level bindings should only be applied while @@ -1177,7 +1263,7 @@ (setq end (point))) ;; Alter the form if necessary. (let ((form (eval-sexp-add-defvars - (eval-defun-1 (macroexpand form))))) + (elisp--eval-defun-1 (macroexpand form))))) (eval-region beg end standard-output (lambda (_ignore) ;; Skipping to the end of the specified region @@ -1220,563 +1306,269 @@ (eval-defun (not edebug-all-defs))) (t (if (null eval-expression-debug-on-error) - (eval-defun-2) - (let ((old-value (make-symbol "t")) new-value value) - (let ((debug-on-error old-value)) - (setq value (eval-defun-2)) + (elisp--eval-defun) + (let (new-value value) + (let ((debug-on-error elisp--eval-last-sexp-fake-value)) + (setq value (elisp--eval-defun)) (setq new-value debug-on-error)) - (unless (eq old-value new-value) + (unless (eq elisp--eval-last-sexp-fake-value new-value) (setq debug-on-error new-value)) value))))) =20 -;; May still be used by some external Lisp-mode variant. -(define-obsolete-function-alias 'lisp-comment-indent - 'comment-indent-default "22.1") -(define-obsolete-function-alias 'lisp-mode-auto-fill 'do-auto-fill "23.1") +;;; ElDoc Support --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 22:35:00 2016 Received: (at 19362) by debbugs.gnu.org; 7 Jul 2016 02:35:00 +0000 Received: from localhost ([127.0.0.1]:40081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKz9Y-0002hN-9r for submit@debbugs.gnu.org; Wed, 06 Jul 2016 22:35:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKz9W-0002hA-Sh for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 22:34:59 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u672YoWi018747 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2016 02:34:51 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u672YoxJ015650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2016 02:34:50 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u672Ym3h017193; Thu, 7 Jul 2016 02:34:49 GMT MIME-Version: 1.0 Message-ID: <62e491fa-9863-47d6-8954-26b6368185f9@default> Date: Thu, 7 Jul 2016 02:34:48 +0000 (UTC) From: Drew Adams To: npostavs@users.sourceforge.net Subject: RE: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> <126bba1e-3f86-4ae3-b7b5-59532f62e4f6@default> <87bn2acmye.fsf@users.sourceforge.net> In-Reply-To: <87bn2acmye.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 19362 Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > Well, we could have all saved some time if you had taken your own advice > to diff the code; not pp.el vs elisp-mode.el, but emacs-24.5's > lisp-mode.el vs the new elisp-mode.el. You can see in the attached diff > (exerpted to leave only the relevant functions) that the only changes > are renaming of functions, and some minor refactoring in > elisp--preceding-sexp (it now handles =E2=80=98foo=E2=80=99 as well as `f= oo'). I never suggested diffing pp.el against either lisp-mode.el or elisp-mode.el. And actually I did compare lisp-mode.el with elisp-mode.el and different versions of lisp-mode.el. I said this, which I maintain: > Yes, well, it's quite difficult. Some of the code from lisp-mode.el > was moved to elisp-mode.el. And then it was modified, in some cases > radically. Dunno why, except that some of the changes seem to have > involved integrating eldoc. But most of the changes presumably do not > concern this bug, which is only about the part of lisp-mode.el that > had functions that correspond to pp.el functions.) It should be clear that wrt what I was following (and comparing) of the evolution, what I saw was not just renaming of functions and minor refactoring. But of course I was also trying to see how the changes compared to the pp.el code - what corresponding changes might be in order for pp.el. That was, uh, the point of the report. Whatever. Thanks for taking a look anyway. Sorry that you apparently wasted your time. From unknown Wed Jun 18 22:58:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Aug 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator