GNU bug report logs - #19355
25.0.50; limit the popup window height

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Fri, 12 Dec 2014 01:51:01 UTC

Severity: minor

Found in version 25.0.50

Done: martin rudalics <rudalics <at> gmx.at>

Bug is archived. No further changes may be made.

Full log


Message #52 received at 19355 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>, 19355 <at> debbugs.gnu.org
Cc: sdl.web <at> gmail.com
Subject: Re: bug#19355: 25.0.50; limit the popup window height
Date: Fri, 26 Dec 2014 10:13:20 +0100
> I tried your fixes now, and I see all improvements, but there is one thing
> that doesn't look good.  The *Completions* buffer doesn't shrink anymore
> if the window is larger than the buffer, e.g. after `M-x z TAB' now
> it leaves too much empty unused screen space instead of shrinking.

Add (require 'zotelo) and (require 'zeal-at-point) to your .emacs to
make this look more behaved ;-)

In fact, the present behavior is that of Emacs 24.4 and that's what Leo
Liu asked for in this thread.  Unfortunately, nobody stepped forward to
say that the pure `fit-window-to-buffer' behavior you implemented was
better.  I think it was - but I hardly count since I practically always
use in-line completion.

So now people have to activate `temp-buffer-resize-mode' again in order
to make this work in your sense.  Unless you find a better solution.

martin

BTW: IIUC `with-displayed-buffer-window' may call `fit-window-to-buffer'
up to three times now.  Couldn't we cut that down a bit?




This bug report was last modified 10 years and 146 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.