From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 10 16:51:24 2014 Received: (at submit) by debbugs.gnu.org; 10 Dec 2014 21:51:24 +0000 Received: from localhost ([127.0.0.1]:42077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XypAK-000150-67 for submit@debbugs.gnu.org; Wed, 10 Dec 2014 16:51:24 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:58132 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XypAI-00014t-Qo for submit@debbugs.gnu.org; Wed, 10 Dec 2014 16:51:23 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XypAI-00082y-A0; Wed, 10 Dec 2014 16:51:22 -0500 From: Glenn Morris To: submit@debbugs.gnu.org Subject: auto-fill scan-error in sh-mode X-Spook: bullion Semtex Mossad investigation infowar illuminati X-Ran: >EOML>.k?zk?lwbS0n]FfJkt/gH"yWS]%CilNFNF+W7hRmKjy3w67`uB5UR\^-vZ&UlCGi X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 10 Dec 2014 16:51:22 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 24.4 emacs -Q /tmp/foo.sh M-x auto-fill-mode Type a long string with spaces, past fill-column; eg: foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa Auto-fill results in: Error: (scan-error "Containing expression ends prematurely" 75 75) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 05:31:45 2018 Received: (at 19342) by debbugs.gnu.org; 9 Dec 2018 10:31:45 +0000 Received: from localhost ([127.0.0.1]:39230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVwNF-0000CT-Ho for submit@debbugs.gnu.org; Sun, 09 Dec 2018 05:31:45 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:52251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVwNE-0000CH-5V for 19342@debbugs.gnu.org; Sun, 09 Dec 2018 05:31:44 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id A2EDF229CF for <19342@debbugs.gnu.org>; Sun, 9 Dec 2018 10:36:42 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1544351801; x=1545215802; bh=XU OwF0Vr7eNwqVsXKNqjs2lhSWLlXz20yIISBpmVloc=; b=qtZ7ZqVNwbNgi/Oiss A3P/x8gp9ZO0AqioVXRDh0VzpjqJxorpwP5o+83l5UI7BuqtC39bND6kL/uYjf83 hBe/UHm7K6BBi2+599KzMzuPIBaP/unvI8XKX6Xre0qICwbDI6TKiqamDuVB6yMt SFE7Zq1sj8oTUJ/YmMmgurwhM= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MAVcTpGXEk8X for <19342@debbugs.gnu.org>; Sun, 9 Dec 2018 10:36:41 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:34ff:bc50:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 98652229AE; Sun, 9 Dec 2018 10:36:41 +0000 (UTC) Date: Sun, 09 Dec 2018 11:35:32 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Glenn Morris In-reply-to: (message from Glenn Morris on Wed, 10 Dec 2014 16:51:22 -0500) Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Glenn Morris > Date: Wed, 10 Dec 2014 16:51:22 -0500 > > Package: emacs > Version: 24.4 > > emacs -Q /tmp/foo.sh > M-x auto-fill-mode > > Type a long string with spaces, past fill-column; eg: > > foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa > > Auto-fill results in: > > Error: (scan-error "Containing expression ends prematurely" 75 75) Can't produce this in the latest master, it seems to work fine now. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 10:39:59 2018 Received: (at 19342) by debbugs.gnu.org; 9 Dec 2018 15:39:59 +0000 Received: from localhost ([127.0.0.1]:40128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW1BW-0002WX-R6 for submit@debbugs.gnu.org; Sun, 09 Dec 2018 10:39:59 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:52488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW1BU-0002W9-RP for 19342@debbugs.gnu.org; Sun, 09 Dec 2018 10:39:57 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 869C1229CF for <19342@debbugs.gnu.org>; Sun, 9 Dec 2018 15:44:54 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1544370293; x=1545234294; bh=4P qtc/vMe+dJwtvRVGxzhD4vmZbIjB7AHVD9G2i5PYA=; b=KRUIy8BpU9vETKRItB OgOD+8g55ZPYFRUfdmLS+Xr1Wbe7Ox7OyLFgXl8LQX32hLwjY0t3mgv2ha8dmt42 IOGUd18zQzLV9p4xYzrN+4s4Hjaz/pHa/5VBLDRjW+FnPjFIf8SWmWkHaT50YwlR iRAReMAQUm1lapBZ1ME4W0q7U= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qr2lERcucSKg for <19342@debbugs.gnu.org>; Sun, 9 Dec 2018 15:44:53 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:34ff:bc50:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 20C0C229AE; Sun, 9 Dec 2018 15:44:53 +0000 (UTC) Date: Sun, 09 Dec 2018 16:43:33 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: charles@aurox.ch In-reply-to: (charles@aurox.ch) Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: rgm@gnu.org, 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 09 Dec 2018 11:35:32 +0100 > Date: Sun, 09 Dec 2018 11:35:32 +0100 > From: charles@aurox.ch (Charles A. Roelli) > CC: 19342@debbugs.gnu.org > Reply-to: charles@aurox.ch > > > From: Glenn Morris > > Date: Wed, 10 Dec 2014 16:51:22 -0500 > > > > Package: emacs > > Version: 24.4 > > > > emacs -Q /tmp/foo.sh > > M-x auto-fill-mode > > > > Type a long string with spaces, past fill-column; eg: > > > > foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa > > > > Auto-fill results in: > > > > Error: (scan-error "Containing expression ends prematurely" 75 75) > > Can't produce this in the latest master, it seems to work fine now. Nevermind that, it still does. I missed a step. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 12:44:40 2020 Received: (at 19342) by debbugs.gnu.org; 12 Aug 2020 16:44:40 +0000 Received: from localhost ([127.0.0.1]:45337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5trV-0006Ob-0C for submit@debbugs.gnu.org; Wed, 12 Aug 2020 12:44:40 -0400 Received: from mail-yb1-f180.google.com ([209.85.219.180]:46087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5trU-0006OO-4z for 19342@debbugs.gnu.org; Wed, 12 Aug 2020 12:44:24 -0400 Received: by mail-yb1-f180.google.com with SMTP id x10so1681512ybj.13 for <19342@debbugs.gnu.org>; Wed, 12 Aug 2020 09:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=wvS3lNdr2hJVHDwBcfaYHa2FL+vDi3mYp7BuOZarQBs=; b=n85A6CrRVj9q98DGnHf9gQSam23RdkM/wb9LHOMSYJW0QdXGRMx0hVyYcjv9w2qr42 n1HQMNlhQ7mirFvHTE1BVttbP2i58NutuHWEYWkBXvGr2mHPclmgQ65Rb0/1YEK9WYYj /3P14WkEHROahXxFLsXIJz3Dfyn9UAfhjxWDjO6q/8hl7S3gZEHGzU8RRXjNmRh2orFS lEcXr9N/6ows2pMkbt2frFHqpf7mooG+76/yEAlJWNzqIoe85kZ5G2cZFgRqqqVbWvJG 4mF67cRzi4XbAYyTFC6nWABJsSyosUaZdFie6u6nRdEY6vLJNVnd0/3sFzDzvXtyA+pM gUtg== X-Gm-Message-State: AOAM531Qhe8pKTU2EYKeFQaFzKo+3sS96lG2kx3pfcnnj2x0iJjyYr1W 2nWbMFlc5MMBE7Cm14tXQ8B3LPvyoYr9n8fqs0OoZojAXwk= X-Google-Smtp-Source: ABdhPJxDxHwz4M5mhart0HMjeec61u+HBUbOHSvsK3701bEwjiqGQwBDJKpYenjw7DpPL3T0YcYKHnKNUkKAnpRYmWs= X-Received: by 2002:a25:b88b:: with SMTP id w11mr332643ybj.129.1597250658720; Wed, 12 Aug 2020 09:44:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Aug 2020 09:44:18 -0700 From: Stefan Kangas In-Reply-To: (Glenn Morris's message of "Wed, 10 Dec 2014 16:51:22 -0500") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 12 Aug 2020 09:44:18 -0700 Message-ID: Subject: Re: bug#19342: auto-fill scan-error in sh-mode To: Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19342 Cc: 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 19342 28.0.50 tags 19342 + confirmed thanks Glenn Morris writes: > Package: emacs > Version: 24.4 > > emacs -Q /tmp/foo.sh > M-x auto-fill-mode > > Type a long string with spaces, past fill-column; eg: > > foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa > > Auto-fill results in: > > Error: (scan-error "Containing expression ends prematurely" 75 75) I can reproduce this on current master. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 19 09:29:28 2021 Received: (at 19342) by debbugs.gnu.org; 19 Aug 2021 13:29:28 +0000 Received: from localhost ([127.0.0.1]:58852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGi6p-0000Au-Ki for submit@debbugs.gnu.org; Thu, 19 Aug 2021 09:29:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGi6n-0000Ae-JI for 19342@debbugs.gnu.org; Thu, 19 Aug 2021 09:29:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eHC6LW/zkMivOcabi+5buQbq6Hj7lc5Zg8pFIh+zYvw=; b=JzyoMFqkz1q0ldSDj4p0D/UJFg qdL+EZUaZayF/YDMLuGIIAwvWyqxeWenaFo/4GjhWviuEH9MJt6MzqLgu5N/4kYnDIrqdt/QjzVnO 6R1wkg6TGXRtkqQZt+aC7TV4thRCtUb2K3DJAcZe5di0FQaI54nYn1G1ZPgPEpAWdpWA=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGi6b-0006MK-PV; Thu, 19 Aug 2021 15:29:18 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: Date: Thu, 19 Aug 2021 15:29:10 +0200 In-Reply-To: (Glenn Morris's message of "Wed, 10 Dec 2014 16:51:22 -0500") Message-ID: <87tujl7ec9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > Type a long string with spaces, past fill-column; eg: > > foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa > > Auto-fill results in: > > Error: (scan-error "Containing express [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: 19342@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Glenn Morris writes: > Type a long string with spaces, past fill-column; eg: > > foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa > > Auto-fill results in: > > Error: (scan-error "Containing expression ends prematurely" 75 75) This problem is still present in Emacs 28. This is the backtrace: Debugger entered--Lisp error: (scan-error "Containing expression ends prematurely" 95 95) signal(scan-error ("Containing expression ends prematurely" 95 95)) (if (and (car res) (= pos (point)) (not (if forw (eobp) (bobp)))) ( (let ((pos (point)) (res (if forw (smie-forward-sexp 'halfsexp) (sm (while (/= n 0) (setq n (- n (if forw 1 -1))) (let ((pos (point)) ( (let ((forw (> n 0)) (forward-sexp-function nil)) (while (/= n 0) ( smie-forward-sexp-command(1) forward-sexp(1) (cond ((< 0 (length tok)) (assoc tok smie-grammar)) ((looking-at "\ (let ((tok (funcall smie-forward-token-function))) (cond ((< 0 (len smie-indent-forward-token() smie-indent-keyword() smie--funcall(smie-indent-keyword) run-hook-wrapped(smie--funcall smie-indent-keyword) smie-indent-calculate() smie-auto-fill(#f(compiled-function (&rest args) #)) The code that errors out is: (defun smie-indent-forward-token () [...] ((looking-at "\\s\"\\|\\s|") (forward-sexp 1) That is, if we're auto-filling an unterminated string, it'll always bug out, apparently? I've added Stefan to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 29 08:56:25 2021 Received: (at 19342) by debbugs.gnu.org; 29 Aug 2021 12:56:25 +0000 Received: from localhost ([127.0.0.1]:55739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKKML-0001XI-ES for submit@debbugs.gnu.org; Sun, 29 Aug 2021 08:56:25 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKKMJ-0001Wu-Lb for 19342@debbugs.gnu.org; Sun, 29 Aug 2021 08:56:24 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 603F6809E7; Sun, 29 Aug 2021 08:56:17 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 15D57807F5; Sun, 29 Aug 2021 08:56:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630241776; bh=0Vh8iyQYOYBIuVMW+zxX+Lxm0s4YRxbJseDHKjr5jmA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KKpn5fcUNG/K0sXPHmaAbG0pL1r7clfWaTsPcEIAcso+YwsrumnV0iVicN1k/V+De KFzNvT3OBh6qRtmOOAvaHcLGZaK4+OvP1DT2KhY2Jyjz5wzpO9PECuvy4eLVpBlCiL o3dW7f5GZbkzZCmNqY7F0dMD+heLooz08l4d/6V3NuPy6Qpj0GxDmY1A/tOrIRgAzn 7hI4Nj3827Gg4HaDx7zYJg/YQtIcZGIRoEVW7uwZE0PmAKhhY4B5B7TpfkPRwN3BPP adQJrjo/AvkYYogveF2+43rhy/BU0qNIs12Co8Y/jSqbI2kaEVcPrN4XUSoMScUBu0 xdhjsSp57QQMA== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C960A120208; Sun, 29 Aug 2021 08:56:15 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> Date: Sun, 29 Aug 2021 08:56:14 -0400 In-Reply-To: <87tujl7ec9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 19 Aug 2021 15:29:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-08-19 15:29:10] wrote: > Glenn Morris writes: > >> Type a long string with spaces, past fill-column; eg: >> >> foo="aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaa aaaaaaaaaa >> >> Auto-fill results in: >> >> Error: (scan-error "Containing expression ends prematurely" 75 75) > > This problem is still present in Emacs 28. This is the backtrace: > > Debugger entered--Lisp error: (scan-error "Containing expression ends prematurely" 95 95) > signal(scan-error ("Containing expression ends prematurely" 95 95)) > (if (and (car res) (= pos (point)) (not (if forw (eobp) (bobp)))) ( > (let ((pos (point)) (res (if forw (smie-forward-sexp 'halfsexp) (sm > (while (/= n 0) (setq n (- n (if forw 1 -1))) (let ((pos (point)) ( > (let ((forw (> n 0)) (forward-sexp-function nil)) (while (/= n 0) ( > smie-forward-sexp-command(1) > forward-sexp(1) > (cond ((< 0 (length tok)) (assoc tok smie-grammar)) ((looking-at "\ > (let ((tok (funcall smie-forward-token-function))) (cond ((< 0 (len > smie-indent-forward-token() > smie-indent-keyword() > smie--funcall(smie-indent-keyword) > run-hook-wrapped(smie--funcall smie-indent-keyword) > smie-indent-calculate() > smie-auto-fill(#f(compiled-function (&rest args) #)) > > The code that errors out is: > > (defun smie-indent-forward-token () > [...] > ((looking-at "\\s\"\\|\\s|") > (forward-sexp 1) > > That is, if we're auto-filling an unterminated string, it'll always bug > out, apparently? The behavior I see in the example above is that a newline is inserted right before the last "aaaaaaaaaa", and an error message is displayed in the echo area. I'm not completely sure what behavior we'd like to see here instead. Just a less scary error message? We could also emit no error message at all, but since this is using smie-auto-fill (i.e. syntax-aware auto-fill), it seems important to point out that we couldn't use syntax-aware auto-filling because of a problem in the syntax, which is what the error message is trying to say. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 29 14:43:13 2021 Received: (at 19342) by debbugs.gnu.org; 29 Aug 2021 18:43:13 +0000 Received: from localhost ([127.0.0.1]:57368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKPlx-00067z-5i for submit@debbugs.gnu.org; Sun, 29 Aug 2021 14:43:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKPlv-00067m-A8 for 19342@debbugs.gnu.org; Sun, 29 Aug 2021 14:43:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W7FnQE7Tc2JScIic2yo2bSyyVshR5VGE+uZYjanaeIE=; b=eWaSr0YR5jsydzhwU6kHkVHVEk dwnwYvqqACvPvZTMpFaIfLTfKuuV7RQ1HHAjaV25ynEGAxrTftAeDBk4aFhbTxUkAkmyWhPLy1PWQ 0XqpI5xz87bghCalOdnhHX5qpcZc/DuShJDql/uEFdxKa7GrHCpwvYFcg0dVWAQFnlSE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKPlj-0002VE-08; Sun, 29 Aug 2021 20:43:03 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> Date: Sun, 29 Aug 2021 20:42:58 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 Aug 2021 08:56:14 -0400") Message-ID: <8735qsgki5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > The behavior I see in the example above is that a newline > is inserted right before the last "aaaaaaaaaa", and an error message is > displayed in the echo area. > > I'm not completely sure what beh [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > The behavior I see in the example above is that a newline > is inserted right before the last "aaaaaaaaaa", and an error message is > displayed in the echo area. > > I'm not completely sure what behavior we'd like to see here instead. > Just a less scary error message? Perhaps no filling at all? Certainly not any sort of error message. > We could also emit no error message at all, but since this is using > smie-auto-fill (i.e. syntax-aware auto-fill), it seems important to > point out that we couldn't use syntax-aware auto-filling because of > a problem in the syntax, which is what the error message is trying > to say. Well, there's no problem in the syntax, is there? The user is just typing a long string, which is pretty normal behaviour... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 29 20:38:20 2021 Received: (at 19342) by debbugs.gnu.org; 30 Aug 2021 00:38:20 +0000 Received: from localhost ([127.0.0.1]:57779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKVJY-0000Yb-IG for submit@debbugs.gnu.org; Sun, 29 Aug 2021 20:38:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKVJT-0000YL-CX for 19342@debbugs.gnu.org; Sun, 29 Aug 2021 20:38:15 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A1ED1807F5; Sun, 29 Aug 2021 20:38:05 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E9D8B8084B; Sun, 29 Aug 2021 20:38:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630283883; bh=x6xOxhmbc1ZujvOhhsPLUqnhSCtrQiX9QwNKOPR74/A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Uqd/9dlBH1CIRflvhxQ8Rio1wCttZizZr90LRXToncRq78K5YKUk6XVW8BfRY81XO 7HfA1GHSjod5RkIemaDbUxVCQbVdHwXKc1i+0QqDKLZJ0+kava8Z9aLDJZ5FqNavdy zxlBC6EXpnNoPRi3n5NJSn45nw/tTIWHxKdOvifIUdx/bTBWBNEUsSQ3hk8assjLfL ytgsahP2UHYm+DCRuqMj3Htz1qls7w49d2TbafDECUmTMqMd4l4HikeXfHHimt8aw0 PE6ThjhQzygEF3QOsX0k5hSFUmsjggwL45BDgFe7tH+/Lc+tzvuEgo4KMTQ9Q+adHv kMzMSKw/5hD4A== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AF618120313; Sun, 29 Aug 2021 20:38:03 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> Date: Sun, 29 Aug 2021 20:38:02 -0400 In-Reply-To: <8735qsgki5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Aug 2021 20:42:58 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Well, there's no problem in the syntax, is there? The user is just > typing a long string, which is pretty normal behaviour... There's an error in the syntax because the string is not closed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 29 20:45:15 2021 Received: (at 19342) by debbugs.gnu.org; 30 Aug 2021 00:45:15 +0000 Received: from localhost ([127.0.0.1]:57788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKVQJ-0000j1-4k for submit@debbugs.gnu.org; Sun, 29 Aug 2021 20:45:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKVQH-0000ij-5O for 19342@debbugs.gnu.org; Sun, 29 Aug 2021 20:45:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VTVM02zIj/vJ5jZZhEjNSol05ynpmfpFgkPonbg/+JY=; b=p+dmlbCLGlGX8IorAuv9OUiLa7 z14ndj9daJBm5dFb/kjQoPHdQvJ47dL2ALZT3pukT17WYxiwLceFuC7iFH+FbTBEvaJSYox+V8A7m wntxlrJ7NDaN32SKupUrgJqBeIk3hQf49A1Rz0avqml7aEj6IXmsaZdRQcbMT/MDuefA=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKVQ5-0006Dx-AA; Mon, 30 Aug 2021 02:45:05 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> Date: Mon, 30 Aug 2021 02:44:59 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 Aug 2021 20:38:02 -0400") Message-ID: <87sfyrahh0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Well, there's no problem in the syntax, is there? The user is just >> typing a long string, which is pretty normal behaviour... > > There's an error in the syntax because the string is not closed. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> Well, there's no problem in the syntax, is there? The user is just >> typing a long string, which is pretty normal behaviour... > > There's an error in the syntax because the string is not closed. It rather sounds like you're saying it would be fine if Emacs started signalling errors immediately after a user has typed a " character -- which I don't think you are. So I'm not sure why you're fine with Emacs issuing an error after the user has typed a " character and then some more characters. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 08:36:32 2021 Received: (at 19342) by debbugs.gnu.org; 30 Aug 2021 12:36:32 +0000 Received: from localhost ([127.0.0.1]:58379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgWe-0002Dr-8o for submit@debbugs.gnu.org; Mon, 30 Aug 2021 08:36:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgWc-0002De-0e for 19342@debbugs.gnu.org; Mon, 30 Aug 2021 08:36:31 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6FB954408C8; Mon, 30 Aug 2021 08:36:24 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2D79544076C; Mon, 30 Aug 2021 08:36:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630326983; bh=kGrI0tbKo3JsYKIVLZL7V2OkauY2zZwaAUERhj/XUEc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MjOSJ3IGWvfKPG/yQSqCQ2/AqU+lQvAGd4vpjBjifG9Nv1cGBTSSUzRLCT+0Rjkpy KnpJ6ysFr1vPtutf+X7eJZnBv/Gc+CiozsjpVUiAkUw5EOdNY8Yn1JsRm4jY4q6MJC mO7rOe6qYFuWmnJTB5O2yKfyuvC9P2gPSMuxEm8AhdHTwHsdHO7hsnmDijeWamp+6Z fPaJtD091H/uVz2xbGEjAoH6dOIsSk/73REa2t9m+YQf9va61cVdauy8XsjbquZOl1 CJuJKxLLfZiKPdvmehdTQkz6eev9MqRXpcxRzoQ5oKdl8CSXdhI8yz0SSRitjU82Cy nbjbmYraHU/DQ== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EC498120223; Mon, 30 Aug 2021 08:36:22 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> Date: Mon, 30 Aug 2021 08:36:22 -0400 In-Reply-To: <87sfyrahh0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 30 Aug 2021 02:44:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.107 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-08-30 02:44:59] wrote: > Stefan Monnier writes: >>> Well, there's no problem in the syntax, is there? The user is just >>> typing a long string, which is pretty normal behaviour... >> >> There's an error in the syntax because the string is not closed. > > It rather sounds like you're saying it would be fine if Emacs started > signalling errors immediately after a user has typed a " character -- > which I don't think you are. So I'm not sure why you're fine with Emacs > issuing an error after the user has typed a " character and then some > more characters. It's not issuing an error. It's emitting a message, the purpose of which is to warn the user that the behavior was affected by that problem. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 11:03:17 2021 Received: (at 19342) by debbugs.gnu.org; 30 Aug 2021 15:03:17 +0000 Received: from localhost ([127.0.0.1]:59987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKioe-0007MT-Vh for submit@debbugs.gnu.org; Mon, 30 Aug 2021 11:03:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKiod-0007MA-1f for 19342@debbugs.gnu.org; Mon, 30 Aug 2021 11:03:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49640) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKioW-0003us-RA; Mon, 30 Aug 2021 11:03:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mKioV-0003XL-95; Mon, 30 Aug 2021 11:03:07 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> X-Spook: Typhoon RAID CRA Red Cross John Kerry Ruby Ridge Iraq X-Ran: BL.Ibfjn;ZqlB?Nf1i!(y{R=CMG+#r1y{}Bv%H^=k+*K]|LO4/,1SMmzjtmH!6a&%`L?{r X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 30 Aug 2021 11:03:07 -0400 In-Reply-To: (Stefan Monnier's message of "Mon, 30 Aug 2021 08:36:22 -0400") Message-ID: <8cwno37z6c.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Lars Ingebrigtsen , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) It works correctly in Emacs 24.3; ie before the use of smie. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 11:26:27 2021 Received: (at 19342) by debbugs.gnu.org; 30 Aug 2021 15:26:27 +0000 Received: from localhost ([127.0.0.1]:60004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKjB5-00083K-9T for submit@debbugs.gnu.org; Mon, 30 Aug 2021 11:26:27 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKjB0-00082y-DT for 19342@debbugs.gnu.org; Mon, 30 Aug 2021 11:26:26 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 97D3180904; Mon, 30 Aug 2021 11:26:16 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4A7F980272; Mon, 30 Aug 2021 11:26:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630337175; bh=MVOtzX/sPqMztlQltWtOuVqItj0XBdaxgirlwnYkPS0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jMOMLlUy9odowtTL0w1a3NoPfa+dBvziKpHItYUUV8Ao22U1QHM7mds004jBZD+Jx DjgbWOJ5AkwqgS0OkqWfeVLerMEXx8YIEuvYoj0QoVWalLyDAQF8WixPArKMHQJ3s+ 4F5wQ0jdto7KghdUYa6HR5BtjdsQAnVM2GkgFHaioHCFyIiiB/L6XUYpxd5NJYAw// SH6PJldEvDGxbDPgA8HW/yW9dH1XulX6G7DGENUkY8/bruoqpCffB2gcImJehplJZg 0kJ/znPqIyX39Bgyx8qJuKuKqdYXPvzQ72QzzNAmFwrxE2R/EFwpyiocMmfn4cxo+E aLyYPC9p5WGiw== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C67F8120445; Mon, 30 Aug 2021 11:26:14 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <8cwno37z6c.fsf@fencepost.gnu.org> Date: Mon, 30 Aug 2021 11:26:14 -0400 In-Reply-To: <8cwno37z6c.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 30 Aug 2021 11:03:07 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Lars Ingebrigtsen , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Glenn Morris [2021-08-30 11:03:07] wrote: > It works correctly in Emacs 24.3; ie before the use of smie. AFAICT in this specific case it works just the same as in 24.3. It just emits an additional message. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 21:24:51 2021 Received: (at 19342) by debbugs.gnu.org; 31 Aug 2021 01:24:51 +0000 Received: from localhost ([127.0.0.1]:60692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKsWB-00028s-BN for submit@debbugs.gnu.org; Mon, 30 Aug 2021 21:24:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKsW7-00028c-NR for 19342@debbugs.gnu.org; Mon, 30 Aug 2021 21:24:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oV/w9+q1X5mWOAY0tN99kYgkV7Z07UmaODlRRnPANBY=; b=Hr+TvCUQdUQcYmNdT7ZScJrZlS maJpT50+jdvzcUkqbPoxNXH7u65Wri23RYJLV8IFUnFqo09SPi1TSnPc4OvOGHWcRDWUeYuoizz1I 6/B8C8IOtD4fEo6BVnhUQbFruQ4l5mhmwEgAYK+M0brukF8SrIuEpsJfRAc4FE8KAik4=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKsVv-0005EP-JA; Tue, 31 Aug 2021 03:24:39 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> Date: Tue, 31 Aug 2021 03:24:35 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 30 Aug 2021 08:36:22 -0400") Message-ID: <878s0i76ek.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > It's not issuing an error. It's emitting a message, the purpose > of which is to warn the user that the behavior was affected by > that problem. I get your point, and as you say, it works fine -- it auto-fills as it's supposed to. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > It's not issuing an error. It's emitting a message, the purpose > of which is to warn the user that the behavior was affected by > that problem. I get your point, and as you say, it works fine -- it auto-fills as it's supposed to. But it's literally signalling an error. (And this is one of those rare instances where "literally" isn't a general intensifier.) Changing it to a message would solve the issue, I think? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 23:30:07 2021 Received: (at 19342) by debbugs.gnu.org; 31 Aug 2021 03:30:07 +0000 Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKuTP-0005Up-CQ for submit@debbugs.gnu.org; Mon, 30 Aug 2021 23:30:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKuTN-0005Sv-Vn for 19342@debbugs.gnu.org; Mon, 30 Aug 2021 23:30:06 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 93A7F1002B8; Mon, 30 Aug 2021 23:30:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D490F1001FC; Mon, 30 Aug 2021 23:29:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630380598; bh=QPeun9Qc65Xf3qirq052zHBlpxgEiTxyU7VJGF7mhrM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nJjwlTAqjoc0tai2chj5js2vwdfQxoZQC3VTW6cye2oW8yIObmnjbwSOtHfOWiJpW E+Xv3cje14XQVqHHQiRzZqU3iq5DY40oM3tgdG44pxncwVhbD2L+XOnRboNgFIOgQn JcjC8GZVlu44xxOiPZyY194hQkB+x2whrylxcp98y+PtsmjuCn0NvCM0EX+d8YLVQN KIX/erMs4I/qK7qVVUJ2wQOe/D6BChftziXU2yPRKZddy5KyVovmGnb0H4uNPsylDL n3u28sEJYBhMvEAr/REcFnzZysTjpUkuSoHIwWEGe/WdeYFeYJdKaceiGl6sbKrJ2E GRAjlPFpasgTg== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 96AE21202E4; Mon, 30 Aug 2021 23:29:58 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> Date: Mon, 30 Aug 2021 23:29:57 -0400 In-Reply-To: <878s0i76ek.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 31 Aug 2021 03:24:35 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-08-31 03:24:35] wrote: > Stefan Monnier writes: >> It's not issuing an error. It's emitting a message, the purpose >> of which is to warn the user that the behavior was affected by >> that problem. > I get your point, and as you say, it works fine -- it auto-fills as it's > supposed to. > But it's literally signalling an error. (And this is one of those rare > instances where "literally" isn't a general intensifier.) Changing it > to a message would solve the issue, I think? Should I just silence the message altogether? After all, I don't really what message to give if not the error itself, because it can be potentially any kind of error. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 31 04:31:25 2021 Received: (at 19342) by debbugs.gnu.org; 31 Aug 2021 08:31:25 +0000 Received: from localhost ([127.0.0.1]:32853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKzAy-0006li-Lb for submit@debbugs.gnu.org; Tue, 31 Aug 2021 04:31:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKzAs-0006lM-Bt for 19342@debbugs.gnu.org; Tue, 31 Aug 2021 04:31:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YsuVjbOUSGmSEsFNKCOwLVs8GzdFlL9KVgM6G7q4AM0=; b=gbCX60dwkpiobM0LniUhkVHaZt TPbiqaYupqH8xNNcTbtNzHXPqsVabM3V3upx6TFWig69TYn0I/ayRRzUBuR94TtB4fgZZ80QDKkX0 Ja5GjKhc6RhyuUDVgEXKBFoeTgrsi6WDCzcUl5F922V0mQJhsnuB0DWzfcqTNKKm5kDY=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKzAg-0000Zx-Ne; Tue, 31 Aug 2021 10:31:10 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> Date: Tue, 31 Aug 2021 10:31:05 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 30 Aug 2021 23:29:57 -0400") Message-ID: <87eeaaj9rq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Should I just silence the message altogether? > After all, I don't really what message to give if not the error itself, > because it can be potentially any kind of error. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > Should I just silence the message altogether? > After all, I don't really what message to give if not the error itself, > because it can be potentially any kind of error. I think silencing the message might be the right solution here (unless that leads to bad behaviour in other cases). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 09:39:40 2022 Received: (at 19342) by debbugs.gnu.org; 5 May 2022 13:39:40 +0000 Received: from localhost ([127.0.0.1]:44840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmbhk-0002j1-C7 for submit@debbugs.gnu.org; Thu, 05 May 2022 09:39:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmbhj-0002iq-Dy for 19342@debbugs.gnu.org; Thu, 05 May 2022 09:39:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SvBhKNqjcp3M+GzYKtW89oIuI8RsnYljhokwV0+fdY8=; b=o/4+YVMJ6fdMpe9Cmgz+Hrw5n3 0ugNdj3Q3tEoBGniFsP32gHkkPaxgYgabgX5wlfZsIP5hoXZ8f3GnFnTXRvt3E/vJ101FZmZd+Wl0 smwesD+2WNqXsq65Ux/7kg9TKzP8TuGpPIYPauiox8am24BcDk7C0bMIkWdIhcgD4Nq0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmbhY-0002TH-DF; Thu, 05 May 2022 15:39:31 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> X-Now-Playing: Rachel Unthank & The Winterset's _Cruel Sister_: "Twenty Long Weeks" Date: Thu, 05 May 2022 15:39:26 +0200 In-Reply-To: <87eeaaj9rq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 31 Aug 2021 10:31:05 +0200") Message-ID: <874k24p08h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: I took a stab at fixing this with the following patch. All tests pass after applying it, but I'm unsure how much test coverage there is in this area... Any comments? diff --git a/lisp/emacs-lisp/smie.el b/lisp/emacs-lisp/smie.el index 2bab131913..3b9f983cdb 100644 --- a/lisp/emacs-lisp/smie.el +++ b/lisp/emacs-lisp/smie.el @@ -1850,20 +1850,26 @@ smie-auto-fill (s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I took a stab at fixing this with the following patch. All tests pass after applying it, but I'm unsure how much test coverage there is in this area... Any comments? diff --git a/lisp/emacs-lisp/smie.el b/lisp/emacs-lisp/smie.el index 2bab131913..3b9f983cdb 100644 --- a/lisp/emacs-lisp/smie.el +++ b/lisp/emacs-lisp/smie.el @@ -1850,20 +1850,26 @@ smie-auto-fill (save-excursion (let ((end (point)) (bsf nil) ;Best-so-far. - (gain 0)) + (gain 0) + newcol) (beginning-of-line) (while (progn (smie-indent-forward-token) - (and (<= (point) end) - (<= (current-column) fc))) - ;; FIXME? `smie-indent-calculate' can (and often - ;; does) return a result that actually depends on the - ;; presence/absence of a newline, so the gain computed - ;; here may not be accurate, but in practice it seems - ;; to work well enough. - (skip-chars-forward " \t") - (let* ((newcol (smie-indent-calculate)) - (newgain (- (current-column) newcol))) + (and + (<= (point) end) + (<= (current-column) fc) + ;; FIXME? `smie-indent-calculate' can + ;; (and often does) return a result that + ;; actually depends on the presence/absence + ;; of a newline, so the gain computed here + ;; may not be accurate, but in practice it + ;; seems to work well enough. + (progn + (skip-chars-forward " \t") + (setq newcol + (ignore-error 'scan-error + (smie-indent-calculate)))))) + (let ((newgain (- (current-column) newcol))) (when (> newgain gain) (setq gain newgain) (setq bsf (point))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 16:03:30 2022 Received: (at 19342) by debbugs.gnu.org; 5 May 2022 20:03:30 +0000 Received: from localhost ([127.0.0.1]:46537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmhhC-0006gy-9i for submit@debbugs.gnu.org; Thu, 05 May 2022 16:03:30 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmhhA-0006gm-Qx for 19342@debbugs.gnu.org; Thu, 05 May 2022 16:03:29 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 883A4100E05; Thu, 5 May 2022 16:03:23 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1F113100C2D; Thu, 5 May 2022 16:03:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651781002; bh=Hn2n9nfyuofW/D0+9noY6LTCj2BEyge0wolKhBBL50U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LaAw1/M8nigwa4ORzzHevyszxmfP3Ss0Lj808dfhs0PkMDnX/tksZUHwASkshP/W9 8g2E7bk3/8z/Dwj/52UnAqcA2+EHwh1mDAaxzkfYSXlw375f2F3s812eXsvnGUur26 cLVRnqrVVcuqaLAbMhnu6hAHuYdHES1NVFl/Z3oP3P+ovycQyvsdUBimDT9WzZSQv3 5hty5L5vErz9IdWPjhVO7pRNxiRTIA83HWRrBxdqkAgyn8a0zdoJ6LHfxU5sTwtc7R 00oxiC5FN7+vXbhbKWYrMMUB8zP66VElhP+MusqrdKTVNShNsw5P45pnQEf+sKJZFb fEg+AMt52dflA== Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0EFE6120263; Thu, 5 May 2022 16:03:22 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> <874k24p08h.fsf@gnus.org> Date: Thu, 05 May 2022 16:03:21 -0400 In-Reply-To: <874k24p08h.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 05 May 2022 15:39:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.185 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Any comments? Looks OK to me. Tho maybe in the interest of minimizing the indentation depth (and the amount of text changes in the patch), maybe we could just use something like: (let ((newcol (condition-case nil (smie-indent-calculate) (scan-error (point-max)))) [...] where `point-max` is just a large enough value that the subsequent computation of `newgain` leads to skipping this choice. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 07:49:23 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 11:49:23 +0000 Received: from localhost ([127.0.0.1]:47310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmwSZ-0004Dy-Ff for submit@debbugs.gnu.org; Fri, 06 May 2022 07:49:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmwSX-0004Dh-Db for 19342@debbugs.gnu.org; Fri, 06 May 2022 07:49:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1NNI5hJlCVLa13naUr4tGcD1ZlcwZxwbYSe4Dmd8rrE=; b=PhDnJ4eInmKBr+FGkXa9RkmxWz V5N9s59ylxNfY8WqrewWvSJGgPJ8wXda/2E+WyXRTItPRDvuqVA9Icqv2CyIbatzX+rMTI6hKDEkd DGSIobQGSGKsHcfCxwr9SmhlkJeULHdOxo0JB91CEnhjAyJTqJQ7A6uxgYwdJ2vIj0/E=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmwSO-00065a-Bv; Fri, 06 May 2022 13:49:14 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> <874k24p08h.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUUDxFUT0qgk2/S yqj///8BJ5pvAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YFBgstDbOMSyAAAAFsSURBVDjLfZMBksMg CEUhvQDQC0S8QIL3v9uCUaNJZ2mnM/UFPnwJwBKSCH5G1t8Aiy0AuT34KYWWcyknswKUFYDkEnFs /rP2Us+LObdFooFiT6A3cA2eQC5TaBpEdQH3kNucYlMG6p2jmm4RSFxBtKu691OO2VmUNedISHPH FMxd0azM9f/smKdZ1rgRfJovZmLcz9E//Z7MxTnqVkDUEEZjDlBSU27xrQMKsS6dVcv8m7z1PktV k2qMZZ92WQnmZljyJ5i6RMze3Eqati1qEVJMLcNhL3QBhjjX+aZyLYW+PzxdSYA2Bk6FvC/CvhPY Eyw6MMBzLJDG3XlFd6Wc8O0DeoIxNbvKjmMfRceWB/iMSpcH1ZjYubw/3oJayrK0lZ/PHZzeYFee Fmkrh2RrCbPHn3KgWl+rKb5lBznhFZhdGPUN4B8QY3XVST3eNczU1AmIxhiPjAGOAPtLYvNuHaQX uGySH8AuMwD+AAaBR8irJ80RAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTA2VDExOjQ1OjEz KzAwOjAwpPzRGgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wNlQxMTo0NToxMyswMDowMNWh aaYAAAAASUVORK5CYII= X-Now-Playing: The Cure's _The Head On The Door_: "Kyoto Song" Date: Fri, 06 May 2022 13:49:10 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 05 May 2022 16:03:21 -0400") Message-ID: <87ilqinao9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Looks OK to me. Tho maybe in the interest of minimizing the indentation > depth (and the amount of text changes in the patch), maybe we could > just use something like: > > (let ((newcol (condition- [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > Looks OK to me. Tho maybe in the interest of minimizing the indentation > depth (and the amount of text changes in the patch), maybe we could > just use something like: > > (let ((newcol (condition-case nil > (smie-indent-calculate) > (scan-error (point-max)))) > [...] > > where `point-max` is just a large enough value that the subsequent > computation of `newgain` leads to skipping this choice. Sure, sounds simpler... uhm... but what would a good point-max be here? Just the `fc' point? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 08:09:58 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 12:09:58 +0000 Received: from localhost ([127.0.0.1]:47345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmwmU-0006xW-DB for submit@debbugs.gnu.org; Fri, 06 May 2022 08:09:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmwmS-0006xK-Pe for 19342@debbugs.gnu.org; Fri, 06 May 2022 08:09:57 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6DC818062B; Fri, 6 May 2022 08:09:51 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EF1568001C; Fri, 6 May 2022 08:09:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651838989; bh=fw//GbavkJWZWMNNuNSa6hmYx0TuMUGs0MGKb3m/o3I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HSc5gPTfwhFzjvvlJoU31mYE7PwQ802EA+7ej/yA9kV1wg2jZOGD6Ip9L+i0Y5PTb dPZwGokR4N6gRPStUNDPeKzz1thsaTdYTICgDMRYAXbySV7npE42pqP5b087bxv1VA BIS/l635fVyfn6VvkyzFXbHdEGpPqJyUdGTFJSFDfsrrPeqenjgzVG45QVgFbI8EdJ vpDrigRbPXFDTJ5Og24UdGka1hzcVkJ/o1MQB9DKWme6KCSWpq7eXv+5cN13wnS5gs qFaGzTnTWQLIYH8n/KNn3ddGKdPdgvr9mLTNhWR/BJfa6hAH/oCMumWyOa0EF2tejc vLHtzRUyeoSfQ== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B997A1204CC; Fri, 6 May 2022 08:09:49 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> <874k24p08h.fsf@gnus.org> <87ilqinao9.fsf@gnus.org> Date: Fri, 06 May 2022 08:09:48 -0400 In-Reply-To: <87ilqinao9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 06 May 2022 13:49:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Sure, sounds simpler... uhm... but what would a good point-max be > here? Just the `fc' point? I'd think `point-max` does the trick. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 08:26:50 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 12:26:50 +0000 Received: from localhost ([127.0.0.1]:47401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmx2o-0007R1-A8 for submit@debbugs.gnu.org; Fri, 06 May 2022 08:26:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmx2m-0007Qm-IR for 19342@debbugs.gnu.org; Fri, 06 May 2022 08:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+ezSmE35waW/kzbRKClXO2K1FMfkfWFUNO7wPDENbnU=; b=Ix02MCl6DzbilmgGCGuUZp8Jsj lfg8yPGyYs6uxZG0KL4Gfz/qJHF/IKUoiIq7OD+BBU7JFa+xYs0LPJr2k2928GAL32XXH1kAGc+2m lH8Zl/C+X8Vw3Uvzfto5y5DeCKxlHm05dgQdpN3hYmNTmZJZxnsKajbKT95Av0R5gqcM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmx2d-0006Vf-9n; Fri, 06 May 2022 14:26:41 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> <874k24p08h.fsf@gnus.org> <87ilqinao9.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXsqFLSVzHGMCmr HyiqGSh5FyTRYlLvxbL////g/tltAAAAAWJLR0QIht6VegAAAAd0SU1FB+YFBgwZJE9bNj4AAAGi SURBVDjLxZRNT+QwDIbDHuBKA5p7nFHPkETcibPzO9IKmSvalYa/z5uvQjVwW2ktTafjx37tNvYo pdRU7Vapek/kfUq/y4+rr0CThT+lHgYbCdZ/gpqSq19D6BOopUpJKdATGrieQA7LpH3R57SroQ3a CWkzlRFfpEkPkQ4mgXCzL/EApEtB6523aQfQHaQD+108AD4+fWMq/WD/DgQARj/hMiOMl4MvHuEN MF/GJ/5PzxF+An4A3vt795cgNY/6zok6vIHx+FzuqL7E3gtALJcj2jK8geArcBws4k/HrUaZiMTH R++fwszxfgMcQohhfZ7p6e5E9s4NYH1wj8fptM5GR6LFqf4UmDpyL/n09wEjqWlCRqhCZPRKv27p z7wUQISMiEMkEb3QOuszrUSmAOJo2eos67U+zzpTn3EMtYvG5KzyWclhnWt4AQ6XLCJKzlLWZyyF Eslvr/lKBKtm2grBsMTvsFc5CBSMhhvA1O0u4H21Na5Fm7byxb+QT96OjWt/EQCLCfVoXOzq6qYS NwaUY/XnlqA2t+9VB9iOlvbgAwUB8wkyqXolAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTA2 VDEyOjI1OjM2KzAwOjAw4Z5fTQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wNlQxMjoyNToz NiswMDowMJDD5/EAAAAASUVORK5CYII= X-Now-Playing: The Cure's _Kiss Me, Kiss Me, Kiss Me_: "The Kiss" Date: Fri, 06 May 2022 14:26:38 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 06 May 2022 08:09:48 -0400") Message-ID: <87ilqiludd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Sure, sounds simpler... uhm... but what would a good point-max be >> here? Just the `fc' point? > > I'd think `point-max` does the trick. Tried that, and it leads to breakages in other parts of the loop: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> Sure, sounds simpler... uhm... but what would a good point-max be >> here? Just the `fc' point? > > I'd think `point-max` does the trick. Tried that, and it leads to breakages in other parts of the loop: Debugger entered--Lisp error: (scan-error "Containing expression ends prematurely" 74 74) signal(scan-error ("Containing expression ends prematurely" 74 74)) smie-forward-sexp-command(1) forward-sexp(1) smie-indent-forward-token() smie-auto-fill(#f(compiled-function (&rest args) #)) apply(smie-auto-fill #f(compiled-function (&rest args) #) nil) #f(advice smie-auto-fill :around #f(compiled-function (&rest args) #))() internal-auto-fill() -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 08:35:13 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 12:35:13 +0000 Received: from localhost ([127.0.0.1]:47407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmxAu-0001NP-4P for submit@debbugs.gnu.org; Fri, 06 May 2022 08:35:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmxAr-0001NA-Jm for 19342@debbugs.gnu.org; Fri, 06 May 2022 08:35:10 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 29F79440F60; Fri, 6 May 2022 08:35:04 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8932D440F8E; Fri, 6 May 2022 08:34:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651840498; bh=W8k/NUMgcZ5gLzH6pnXrmx0IeDki5Ma04zCsopuHWSo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LmNOvLoLKTjvkxDfca9/G+eyM8ZGw89kv/cwOtGXV8yN0gTD/asHR+BhlJSkfxzCc UQOimvFwCaRGV8Ztrrh5AksEaB8MsX4SM/iqpjEwfpHzB5Et7q/cHpv6RZcA50DpQt sVVm4XxUYYf8EH0g84WiObsA+IXI31il2OWiLS7A6GvVVo43R7RWwg7Sltmmr5MwO/ IOjDwd56LnGr2mV8r5ITYa8tNj0hNHzYehWsP/NpQcbs+Ag8sGiSRtWBG+30197z27 lmzWiH3boqTdyOljeckd86CyH7t2otxHymkmLfkEuWGCCiGn4KGlqBapw+UOjJ+av/ nfGx/k1upYt0w== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3C2971201A4; Fri, 6 May 2022 08:34:58 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> <874k24p08h.fsf@gnus.org> <87ilqinao9.fsf@gnus.org> <87ilqiludd.fsf@gnus.org> Date: Fri, 06 May 2022 08:34:57 -0400 In-Reply-To: <87ilqiludd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 06 May 2022 14:26:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-05-06 14:26:38] wrote: > Stefan Monnier writes: > >>> Sure, sounds simpler... uhm... but what would a good point-max be >>> here? Just the `fc' point? >> >> I'd think `point-max` does the trick. > > Tried that, and it leads to breakages in other parts of the loop: > > Debugger entered--Lisp error: (scan-error "Containing expression ends prematurely" 74 74) > signal(scan-error ("Containing expression ends prematurely" 74 74)) > smie-forward-sexp-command(1) > forward-sexp(1) > smie-indent-forward-token() > smie-auto-fill(#f(compiled-function (&rest args) #)) > apply(smie-auto-fill #f(compiled-function (&rest args) #) nil) > #f(advice smie-auto-fill :around #f(compiled-function (&rest args) > #))() > internal-auto-fill() I can't begin to imagine why we'd get that. But how 'bout the patch below? Stefan diff --git a/lisp/emacs-lisp/smie.el b/lisp/emacs-lisp/smie.el index 2bab1319132..0da403c7053 100644 --- a/lisp/emacs-lisp/smie.el +++ b/lisp/emacs-lisp/smie.el @@ -1862,8 +1862,10 @@ smie-auto-fill ;; here may not be accurate, but in practice it seems ;; to work well enough. (skip-chars-forward " \t") - (let* ((newcol (smie-indent-calculate)) - (newgain (- (current-column) newcol))) + (let* ((newgain (condition-case nil + (- (current-column) + (smie-indent-calculate)) + (scan-error -1))) (when (> newgain gain) (setq gain newgain) (setq bsf (point))))) From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 08:37:39 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 12:37:39 +0000 Received: from localhost ([127.0.0.1]:47411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmxD5-0001Qa-6Z for submit@debbugs.gnu.org; Fri, 06 May 2022 08:37:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmxD3-0001QO-8f for 19342@debbugs.gnu.org; Fri, 06 May 2022 08:37:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c22UgaS5RSXfySA6g2IK8WkIQnE3VarDQjK0Ip7RoYQ=; b=meXP/D5rwmq76zNvgsQ5If+44g ULZQkfoWEex6cWIrNa13/nP79b1Qgo2r3s7gub4TtNtRGc2Xt1YYvS3ksYYvkUWGAd3PsCS9mSPJQ CSZvO75vIUNI27jS+dCRfGmdfezr7LbAMLBTQTn4Gjq3Y3MVi4IdAeCDEgxOgECr4/0Y=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmxCt-0006bF-1D; Fri, 06 May 2022 14:37:17 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <87eeaaj9rq.fsf@gnus.org> <874k24p08h.fsf@gnus.org> <87ilqinao9.fsf@gnus.org> <87ilqiludd.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXsqFLSVzHGMCmr HyiqGSh5FyTRYlLvxbL////g/tltAAAAAWJLR0QIht6VegAAAAd0SU1FB+YFBgwZJE9bNj4AAAGi SURBVDjLxZRNT+QwDIbDHuBKA5p7nFHPkETcibPzO9IKmSvalYa/z5uvQjVwW2ktTafjx37tNvYo pdRU7Vapek/kfUq/y4+rr0CThT+lHgYbCdZ/gpqSq19D6BOopUpJKdATGrieQA7LpH3R57SroQ3a CWkzlRFfpEkPkQ4mgXCzL/EApEtB6523aQfQHaQD+108AD4+fWMq/WD/DgQARj/hMiOMl4MvHuEN MF/GJ/5PzxF+An4A3vt795cgNY/6zok6vIHx+FzuqL7E3gtALJcj2jK8geArcBws4k/HrUaZiMTH R++fwszxfgMcQohhfZ7p6e5E9s4NYH1wj8fptM5GR6LFqf4UmDpyL/n09wEjqWlCRqhCZPRKv27p z7wUQISMiEMkEb3QOuszrUSmAOJo2eos67U+zzpTn3EMtYvG5KzyWclhnWt4AQ6XLCJKzlLWZyyF Eslvr/lKBKtm2grBsMTvsFc5CBSMhhvA1O0u4H21Na5Fm7byxb+QT96OjWt/EQCLCfVoXOzq6qYS NwaUY/XnlqA2t+9VB9iOlvbgAwUB8wkyqXolAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTA2 VDEyOjI1OjM2KzAwOjAw4Z5fTQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wNlQxMjoyNToz NiswMDowMJDD5/EAAAAASUVORK5CYII= X-Now-Playing: The Cure's _Kiss Me, Kiss Me, Kiss Me_: "If Only Tonight We Could Sleep" Date: Fri, 06 May 2022 14:37:14 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 06 May 2022 08:34:57 -0400") Message-ID: <87ee16ltvp.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > I can't begin to imagine why we'd get that. > But how 'bout the patch below? Nope, same problem. We don't seem to be breaking out of the while loop, so it's erroring out in the next iteration at: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > I can't begin to imagine why we'd get that. > But how 'bout the patch below? Nope, same problem. We don't seem to be breaking out of the while loop, so it's erroring out in the next iteration at: (while (progn (smie-indent-forward-token) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 10:12:32 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 14:12:32 +0000 Received: from localhost ([127.0.0.1]:49347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmyh6-0000Rc-2s for submit@debbugs.gnu.org; Fri, 06 May 2022 10:12:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmyh4-0000RQ-HT for 19342@debbugs.gnu.org; Fri, 06 May 2022 10:12:31 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C59C710029F; Fri, 6 May 2022 10:12:24 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 91BC710012C; Fri, 6 May 2022 10:12:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651846342; bh=Ow1eJ8IPlJtYJs4+m5taSU0Smr7zU8oQCs66vMxfdYk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gPoWUREjsh5EfLGLJLLqzIcCRF+odchZifnTGmhkEJS3euNUFyNjb+oO2RuQbnAyS KA0gnKZIn45CeGbDBjokqtNqt1C+i0xl6oXDhfRvb1zbTIRQzP6zlzKewvrrGVtGlG IaRkEcqOwQ7pHZe/haaMMK2PIztB8pyeiP3x3MqbuIg4SrN+wVX38mdKEWS5BBtZp9 Pewed4llOPfvCQqLrGmTzOQmhpjRRCWfo/Obeyx4TrHkbbXz2l+BlwmlaDWlVMFVfD sIAjnNKnJnZS+eFyGiJzETxD/K8v9l5I+q3IUjeuWJzsUkgyBKYaJJbkpdHDffu/1d wVuqraE7s9Z1A== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 59A1312080E; Fri, 6 May 2022 10:12:22 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> Date: Fri, 06 May 2022 10:12:21 -0400 In-Reply-To: <878s0i76ek.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 31 Aug 2021 03:24:35 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-08-31 03:24:35] wrote: > Stefan Monnier writes: >> It's not issuing an error. It's emitting a message, the purpose >> of which is to warn the user that the behavior was affected by >> that problem. > > I get your point, and as you say, it works fine -- it auto-fills as it's > supposed to. > > But it's literally signalling an error. (And this is one of those rare > instances where "literally" isn't a general intensifier.) Changing it > to a message would solve the issue, I think? BTW, AFAICT it does not *literally* signal an error: the error is caught inside `smie-auto-fill` and turned into a message (by `with-demoted-errors`). So if we want to silence the message, all it takes is to use `ignore-error` instead as in the patch below, no? Stefan diff --git a/lisp/emacs-lisp/smie.el b/lisp/emacs-lisp/smie.el index 2bab1319132..2be1ca3218b 100644 --- a/lisp/emacs-lisp/smie.el +++ b/lisp/emacs-lisp/smie.el @@ -1846,7 +1846,7 @@ smie-auto-fill (move-to-column fc) (syntax-ppss)))) (while - (and (with-demoted-errors "SMIE Error: %S" + (and (ignore-error scan-error (save-excursion (let ((end (point)) (bsf nil) ;Best-so-far. From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 11:03:38 2022 Received: (at 19342) by debbugs.gnu.org; 6 May 2022 15:03:38 +0000 Received: from localhost ([127.0.0.1]:49440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmzUY-0003wg-1J for submit@debbugs.gnu.org; Fri, 06 May 2022 11:03:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmzUW-0003wO-GX for 19342@debbugs.gnu.org; Fri, 06 May 2022 11:03:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PHmPuB/+U+4dGygEknRg/NknwLInikgpFUDJ+3AXC6M=; b=kAD0DiCZTEJy7aNTVobu8CFTBx QfZuVCJfTewmYFj0Dr8wSVfedPMyYd/nrPaFO5Y7oMTW2KLeYoIVIh0O9RyhVwdtcYaGrOYkLi4Li qS/4HPa9terqRIhYJD0Y9aR65EHUH7jmxrFAsIZnL2TgzjuNFJh8uOAbq19Gkzzmxdys=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmzUL-0007md-0Y; Fri, 06 May 2022 17:03:28 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19342: auto-fill scan-error in sh-mode References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEU5a9ZFd+RkjODs 596vs8EgHSdXa5yIf3n///82b3pcAAAAAWJLR0QIht6VegAAAAd0SU1FB+YFBg8DCbjvLskAAAGm SURBVDjLhZRRcqMwDIZt2gMYutPn2O4BNsiZvDaRMhyg8eZ9Z0MPgLNcv7JNkwBh+s+AQR/6JeEB IZLKKFneiYOKD1mKUmo5AhbqfcqysIrnamczqECTLnZCodHGrN6ea7uv9tEKBToLMUM7V1sG+OIy qMmSEuZlva5rW/y2ll0SIHoiXnFXR1Bb+wsjMIo75YvCSK11VeqqKk0pfGHM2Z//tO3Zty0vWVxD vf5VYqLYbrGSQudbNbyBPCA7mRVfKKlyWA1AMjD/2zbQP2Lvz4aby5NzvPLenw7HrY/qYADcWpEi MAGiVBkEoNBf7gCP5odn4dAvAZqD4wYAtt2lwwnoHDIJh0DTjMZxxnEzrxGS1WZmFWuz3IOuAJqO Ac3AR+MR3dzK9/4UreaAO1sCH4+LR6eY8T4FIfUb6P3BgCyEMTjBIJoU75YA/giAFsG4eFjK6HEJ 0De4Ky6j1RW4XIOi+v6WwCSGBK+AodkiQYdAjrcKugZAYAScgP2tL2bwXfxE11HGkwe4pNfFz473 A2ET9y9pfQX88RDt2zfK0jcwVvoJfQGNDcM14Ty3OgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0w NS0wNlQxNTowMzowOSswMDowMLFY55kAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDUtMDZUMTU6 MDM6MDkrMDA6MDDABV8lAAAAAElFTkSuQmCC X-Now-Playing: The Smiths's _Complete (2): Hatful of Hollow_: "Accept Yourself" Date: Fri, 06 May 2022 17:03:24 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 06 May 2022 10:12:21 -0400") Message-ID: <874k22ln43.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > So if we want to silence the message, all it takes is to use > `ignore-error` instead as in the patch below, no? [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342 Cc: Glenn Morris , 19342@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > So if we want to silence the message, all it takes is to use > `ignore-error` instead as in the patch below, no? [...] > (while > - (and (with-demoted-errors "SMIE Error: %S" > + (and (ignore-error scan-error Yup; that fixes the problem. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 11:11:18 2022 Received: (at 19342-done) by debbugs.gnu.org; 6 May 2022 15:11:18 +0000 Received: from localhost ([127.0.0.1]:49470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmzby-00049z-Dp for submit@debbugs.gnu.org; Fri, 06 May 2022 11:11:18 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmzbw-00049R-IR for 19342-done@debbugs.gnu.org; Fri, 06 May 2022 11:11:16 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 001C880521; Fri, 6 May 2022 11:11:10 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8810F80065; Fri, 6 May 2022 11:11:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651849869; bh=3mqr6UfrcV3tPc/1nnQNxZHONuxHM27OTggory8LvDQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ezvxiCwDtkMwdOXJcxCM3FWWtl3/xrX9clLlkGkYtJDtJ67GaSns0igM+Yi6kWGZ+ OgTsIzUnyEBKU/ypBMGPjkQqsU67kZLlVsmMpMqXaWWCG7RpKZXtl8ORgRawSj26RU nk7YmDr2Pc1F6oNJpUY2sWx6wQQrhq5s7GSqD492VfY2kiIlnKJKB53S81kjK9o309 SnDY04YfGb6tFqswe9GkJDZ/oZNOVHzSStWBrOuR1u8/SAgiWBVmA0MFPoTFMulOOf gaM7Kqpm8+vjPDt/14kHKru/8tHC2iUl04tKhJzyVzLDmkmWtJsQAQaX6C1K76bfXN YRSsNZCZ/qVJg== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 52769120919; Fri, 6 May 2022 11:11:09 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19342: auto-fill scan-error in sh-mode Message-ID: References: <87tujl7ec9.fsf@gnus.org> <8735qsgki5.fsf@gnus.org> <87sfyrahh0.fsf@gnus.org> <878s0i76ek.fsf@gnus.org> <874k22ln43.fsf@gnus.org> Date: Fri, 06 May 2022 11:11:08 -0400 In-Reply-To: <874k22ln43.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 06 May 2022 17:03:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19342-done Cc: Glenn Morris , 19342-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-05-06 17:03:24] wrote: > Stefan Monnier writes: >> So if we want to silence the message, all it takes is to use >> `ignore-error` instead as in the patch below, no? > > [...] > >> (while >> - (and (with-demoted-errors "SMIE Error: %S" >> + (and (ignore-error scan-error > > Yup; that fixes the problem. Pushed, thanks, Stefan From unknown Fri Aug 15 15:32:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Jun 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator