From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 10:46:32 2014 Received: (at submit) by debbugs.gnu.org; 9 Dec 2014 15:46:32 +0000 Received: from localhost ([127.0.0.1]:59826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyMzf-0005gX-Pd for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:46:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41642) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyMzd-0005gM-18 for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:46:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyMzc-0007Dm-64 for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:46:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyMzc-0007Dg-3V for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:46:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyMzb-000807-3i for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 10:46:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyMzX-0007Bd-FV for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 10:46:27 -0500 Received: from mail-ie0-x236.google.com ([2607:f8b0:4001:c03::236]:45324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyMzX-0007BN-9X for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 10:46:23 -0500 Received: by mail-ie0-f182.google.com with SMTP id x19so754785ier.13 for ; Tue, 09 Dec 2014 07:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=R1FuNptU6+7QP1ErRVzEOg8mj/g9IINKO7xBVaxtTtg=; b=qf0yB8A6CK10cQtpiodNhFFflngx4DgGtGjUP90NccZxlD00+tuN4DYnRUuCnFuVh1 V8c5/yavmJAh/C1m8XvBSXhKRMceYET+898Afq2lTgwn6F2Z8jG+bOQB+L3zxD7m/BFL JPXBpl5dqXHRSwADKX5Tt/+ndl84XINuRAGsL4eGp8A0HDUl0VaNEiGjx7cbSlM9tvdP VEsLPh+UoPsCHOTE4nywUzbldzuu85Qpz3nr85dghzGc5ZjQEIOqvLq34o9znqW9NGqj cIh0vkmX9ld67X4LzMXUeNU9m7UmcbqI6o52p3epPNXx486hPTm3tDybexWewqe2Lz8v FCEQ== MIME-Version: 1.0 X-Received: by 10.42.4.201 with SMTP id 9mr2438129ict.23.1418139982248; Tue, 09 Dec 2014 07:46:22 -0800 (PST) Received: by 10.107.43.8 with HTTP; Tue, 9 Dec 2014 07:46:22 -0800 (PST) Date: Tue, 9 Dec 2014 09:46:22 -0600 Message-ID: Subject: [PATCH] Add mechanism to prompt about unsaved customizations From: Cameron Desautels To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=001a11346bd2e2ba580509ca71dd X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11346bd2e2ba580509ca71dd Content-Type: multipart/alternative; boundary=001a11346bd2e2ba530509ca71db --001a11346bd2e2ba530509ca71db Content-Type: text/plain; charset=UTF-8 Implements the following, as requested in `etc/TODO`: ** A function to check for customizable options that have been set but not saved, and ask the user whether to save them. This could go in kill-emacs-query-functions, to remind people to save their changes. If the user says yes, show them in a Custom buffer using customize-customized. My copyright assignment info should be on file. Cheers. -- Cameron Desautels --001a11346bd2e2ba530509ca71db Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Implements the following, as requested in `etc/TODO`:=

** A function to check for customizable options t= hat have been
=C2=A0 =C2=A0set but not saved, and ask the user whether t= o save them.
=C2=A0 =C2=A0This could go in kill-emacs-query-functions, t= o remind people
=C2=A0 =C2=A0to save their changes. If the user says yes= , show them
=C2=A0 =C2=A0in a Custom buffer using customize-customized.<= /div>

My copyright assignment info should be on file.

Cheers.

--=C2=A0
Cameron Desautels <camdez@gmail.com>
--001a11346bd2e2ba530509ca71db-- --001a11346bd2e2ba580509ca71dd Content-Type: application/octet-stream; name="0001-Add-mechanism-to-prompt-about-unsaved-customizations.patch" Content-Disposition: attachment; filename="0001-Add-mechanism-to-prompt-about-unsaved-customizations.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i3hfswz50 RnJvbSBkZDE5MmNkN2M0NWYzZTgxNWI1YTczMTQyMGM1MjkzZDc0YzYwNzVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYW1lcm9uIERlc2F1dGVscyA8Y2FtZGV6QGdtYWlsLmNvbT4K RGF0ZTogVHVlLCA5IERlYyAyMDE0IDAwOjI4OjQ0IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IG1lY2hhbmlzbSB0byBwcm9tcHQgYWJvdXQgdW5zYXZlZCBjdXN0b21pemF0aW9ucwoKLSBSZXF1 ZXN0ZWQgaW4gYGV0Yy9UT0RPJwotIFN1aXRhYmxlIGZvciB1c2UgaW4gYGtpbGwtZW1hY3MtcXVl cnktZnVuY3Rpb25zJy4KLS0tCiBldGMvVE9ETyAgICAgICAgIHwgIDYgLS0tLS0tCiBsaXNwL0No YW5nZUxvZyAgIHwgIDUgKysrKysKIGxpc3AvY3VzLWVkaXQuZWwgfCAyOSArKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAxMiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvVE9ETyBiL2V0Yy9UT0RPCmluZGV4IGNjZDAw ZTUuLmNiYjIzOTQgMTAwNjQ0Ci0tLSBhL2V0Yy9UT0RPCisrKyBiL2V0Yy9UT0RPCkBAIC00MTks MTIgKzQxOSw2IEBAIHJhdGhlciB0aGFuIGludGVyYWN0aXZlbHkuICBUaGlzIGEgdHJpdmlhbCBv bmUtbGluZXIgaW4gZWFzeS1tb2RlLmVsLgogCiAqKiBNYWtlIGJ5dGUtb3B0aW1pemF0aW9uIHdh cm5pbmdzIGlzc3VlIGFjY3VyYXRlIGxpbmUgbnVtYmVycy4KIAotKiogQSBmdW5jdGlvbiB0byBj aGVjayBmb3IgY3VzdG9taXphYmxlIG9wdGlvbnMgdGhhdCBoYXZlIGJlZW4KLSAgc2V0IGJ1dCBu b3Qgc2F2ZWQsIGFuZCBhc2sgdGhlIHVzZXIgd2hldGhlciB0byBzYXZlIHRoZW0uCi0gIFRoaXMg Y291bGQgZ28gaW4ga2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMsIHRvIHJlbWluZCBwZW9wbGUK LSAgdG8gc2F2ZSB0aGVpciBjaGFuZ2VzLiBJZiB0aGUgdXNlciBzYXlzIHllcywgc2hvdyB0aGVt Ci0gIGluIGEgQ3VzdG9tIGJ1ZmZlciB1c2luZyBjdXN0b21pemUtY3VzdG9taXplZC4KLQogKiog UmVjb3JkIHRoZSBzeGhhc2ggb2YgdGhlIGRlZmF1bHQgdmFsdWUgZm9yIGN1c3RvbWl6ZWQgdmFy aWFibGVzCiAgIGFuZCBub3RpZnkgdGhlIHVzZXIgKG1heWJlIGJ5IGFkZGluZyBhIG1lbnUgaXRl bSBvciB0b29sYmFyIGJ1dHRvbiwKICAgYXMgdGhlIGRldGVjdGlvbiBjYW4gb2NjdXIgZHVyaW5n IGF1dG9sb2FkIHRpbWUpIHdoZW4gdGhlIGRlZmF1bHQKZGlmZiAtLWdpdCBhL2xpc3AvQ2hhbmdl TG9nIGIvbGlzcC9DaGFuZ2VMb2cKaW5kZXggYmYxMzlkNi4uOWU0YTdhNyAxMDA2NDQKLS0tIGEv bGlzcC9DaGFuZ2VMb2cKKysrIGIvbGlzcC9DaGFuZ2VMb2cKQEAgLTEsMyArMSw4IEBACisyMDE0 LTEyLTA5ICBDYW1lcm9uIERlc2F1dGVscyAgPGNhbWRlekBnbWFpbC5jb20+CisKKwkqIGN1cy1l ZGl0LmVsIChjdXN0b20tcHJvbXB0LWN1c3RvbWl6ZS11bnNhdmVkLW9wdGlvbnMpOiBBZGQgYQor CW1lY2hhbmlzbSBmb3IgcHJvbXB0aW5nIHVzZXIgYWJvdXQgdW5zYXZlZCBjdXN0b21pemF0aW9u cy4KKwogMjAxNC0xMi0wOSAgRXJpYyBTLiBSYXltb25kICA8ZXNyQHNuYXJrLnRoeXJzdXMuY29t PgogCiAJKiB2Yy92Yy1zcmMuZWwgKHZjLXNyYy1kby1jb21hbmQpOiBQcmVwZW5kIC0tIHRvIGZp bGUgYXJndW1lbnQKZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0 LmVsCmluZGV4IGM4ZTliOTAuLmE2ZGE1MGUgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLWVkaXQuZWwK KysrIGIvbGlzcC9jdXMtZWRpdC5lbApAQCAtMTM1NiwxMiArMTM1NiwxMCBAQCBzdWdnZXN0IHRv IGN1c3RvbWl6ZSB0aGF0IGZhY2UsIGlmIGl0J3MgY3VzdG9taXphYmxlLiIKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAob3IgKGZhY2UtYXQtcG9pbnQgdCB0KSAiYWxsIGZh Y2VzIikgdCkpKQogICAoY3VzdG9taXplLWZhY2UgZmFjZSB0KSkKIAotKGRlZmFsaWFzICdjdXN0 b21pemUtY3VzdG9taXplZCAnY3VzdG9taXplLXVuc2F2ZWQpCi0KLTs7OyMjI2F1dG9sb2FkCi0o ZGVmdW4gY3VzdG9taXplLXVuc2F2ZWQgKCkKLSAgIkN1c3RvbWl6ZSBhbGwgb3B0aW9ucyBhbmQg ZmFjZXMgc2V0IGluIHRoaXMgc2Vzc2lvbiBidXQgbm90IHNhdmVkLiIKLSAgKGludGVyYWN0aXZl KQorKGRlZnVuIGN1c3RvbS11bnNhdmVkLW9wdGlvbnMgKCkKKyAgIkxpc3Qgb2Ygb3B0aW9ucyBh bmQgZmFjZXMgc2V0IGluIHRoaXMgc2Vzc2lvbiBidXQgbm90IHNhdmVkLgorRWFjaCBlbnRyeSBp cyBvZiB0aGUgZm9ybSAoU1lNQk9MIFRZUEUpLCB3aGVyZSBUWVBFIGlzIG9uZSBvZiB0aGUKK3N5 bWJvbHMgYGN1c3RvbS1mYWNlJyBvciBgY3VzdG9tLXZhcmlhYmxlJy4iCiAgIChsZXQgKChmb3Vu ZCBuaWwpKQogICAgIChtYXBhdG9tcyAobGFtYmRhIChzeW1ib2wpCiAJCShhbmQgKG9yIChnZXQg c3ltYm9sICdjdXN0b21pemVkLWZhY2UpCkBAIC0xMzcyLDYgKzEzNzAsMTUgQEAgc3VnZ2VzdCB0 byBjdXN0b21pemUgdGhhdCBmYWNlLCBpZiBpdCdzIGN1c3RvbWl6YWJsZS4iCiAJCQkgKGdldCBz eW1ib2wgJ2N1c3RvbWl6ZWQtdmFyaWFibGUtY29tbWVudCkpCiAJCSAgICAgKGJvdW5kcCBzeW1i b2wpCiAJCSAgICAgKHB1c2ggKGxpc3Qgc3ltYm9sICdjdXN0b20tdmFyaWFibGUpIGZvdW5kKSkp KQorICAgIGZvdW5kKSkKKworKGRlZmFsaWFzICdjdXN0b21pemUtY3VzdG9taXplZCAnY3VzdG9t aXplLXVuc2F2ZWQpCisKKzs7OyMjI2F1dG9sb2FkCisoZGVmdW4gY3VzdG9taXplLXVuc2F2ZWQg KCkKKyAgIkN1c3RvbWl6ZSBhbGwgb3B0aW9ucyBhbmQgZmFjZXMgc2V0IGluIHRoaXMgc2Vzc2lv biBidXQgbm90IHNhdmVkLiIKKyAgKGludGVyYWN0aXZlKQorICAobGV0ICgoZm91bmQgKGN1c3Rv bS11bnNhdmVkLW9wdGlvbnMpKSkKICAgICAoaWYgKG5vdCBmb3VuZCkKIAkoZXJyb3IgIk5vIHVz ZXIgb3B0aW9ucyBhcmUgc2V0IGJ1dCB1bnNhdmVkIikKICAgICAgIChjdXN0b20tYnVmZmVyLWNy ZWF0ZSAoY3VzdG9tLXNvcnQtaXRlbXMgZm91bmQgdCBuaWwpCkBAIC0xNDc3LDYgKzE0ODQsMTYg QEAgSWYgVFlQRSBpcyBgZ3JvdXBzJywgaW5jbHVkZSBvbmx5IGdyb3Vwcy4iCiAgIChpbnRlcmFj dGl2ZSAobGlzdCAoYXByb3Bvcy1yZWFkLXBhdHRlcm4gImdyb3VwcyIpKSkKICAgKGN1c3RvbWl6 ZS1hcHJvcG9zIHJlZ2V4cCAnZ3JvdXBzKSkKIAorOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBjdXN0 b20tcHJvbXB0LWN1c3RvbWl6ZS11bnNhdmVkLW9wdGlvbnMgKCkKKyAgIlByb21wdCB1c2VyIHRv IGN1c3RvbWl6ZSBhbnkgdW5zYXZlZCBjdXN0b21pemF0aW9uIG9wdGlvbnMuCitSZXR1cm4gbm9u LW5pbCBpZiB1c2VyIGNob29zZXMgdG8gY3VzdG9taXplLCBmb3IgdXNlIGluCitga2lsbC1lbWFj cy1xdWVyeS1mdW5jdGlvbnMnLiIKKyAgKG5vdCAoYW5kIChjdXN0b20tdW5zYXZlZC1vcHRpb25z KQorCSAgICAoeWVzLW9yLW5vLXAgIlNvbWUgY3VzdG9taXplZCBvcHRpb25zIGhhdmUgbm90IGJl ZW4gc2F2ZWQ7IEV4YW1pbmU/ICIpCisJICAgIChjdXN0b21pemUtdW5zYXZlZCkKKwkgICAgdCkp KQorCiA7OzsgQnVmZmVyLgogCiAoZGVmY3VzdG9tIGN1c3RvbS1idWZmZXItc3R5bGUgJ2xpbmtz Ci0tIAoyLjIuMAoK --001a11346bd2e2ba580509ca71dd-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 10:54:25 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 15:54:25 +0000 Received: from localhost ([127.0.0.1]:59832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyN7I-0005sV-Pw for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:54:25 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:47563) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyN7H-0005sO-81 for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 10:54:23 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sB9FsLkp026819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Dec 2014 15:54:22 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sB9FsKuZ024112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 9 Dec 2014 15:54:21 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sB9FsKRN024099; Tue, 9 Dec 2014 15:54:20 GMT MIME-Version: 1.0 Message-ID: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> Date: Tue, 9 Dec 2014 07:54:19 -0800 (PST) From: Drew Adams To: Cameron Desautels , 19328@debbugs.gnu.org Subject: RE: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19328 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Why is this in etc/TODO? This already exists, no? I've been using this for years: (add-hook 'kill-emacs-query-functions (lambda () (condition-case nil (customize-unsaved) (error t)))) > Implements the following, as requested in `etc/TODO`: > > ** A function to check for customizable options that have been > =C2=A0 =C2=A0set but not saved, and ask the user whether to save them. > =C2=A0 =C2=A0This could go in kill-emacs-query-functions, to remind peopl= e > =C2=A0 =C2=A0to save their changes. If the user says yes, show them > =C2=A0 =C2=A0in a Custom buffer using customize-customized. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 11:16:49 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 16:16:49 +0000 Received: from localhost ([127.0.0.1]:59849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyNSy-0006R2-NV for submit@debbugs.gnu.org; Tue, 09 Dec 2014 11:16:49 -0500 Received: from mail-oi0-f53.google.com ([209.85.218.53]:61680) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyNSw-0006Qs-OD for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 11:16:47 -0500 Received: by mail-oi0-f53.google.com with SMTP id x69so607915oia.40 for <19328@debbugs.gnu.org>; Tue, 09 Dec 2014 08:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=O9FAf9HJqqG5nXZjC5MMX5v4lS7ACrvfAHGGzgAhlzY=; b=vkdHv4bCV/QQOfFRvCXsjFlkuI78iQqZa2+EJBRSkJyIkcf368Do+e5DeuRxojZDI7 XWNIKGjfMa2hThm5KIl4gtZ1UFnT7pzrvAu42GnJlNkq1m4JBbbQfw3ovpsERZBF51Bb UKY7LajtQKgIGFm1JtBdppNoON/bzEOlC4JyxFRiFTonnNmQjWKt5Q1mnPXVlVsOKrZz ukOPFtUZGOIsRAiZO/qw1nv0NKfpxJmUFOeMs9M50SUG+09TV5o7DEOZLTSHeL6acrzy 11LOCg084Tvo0Kj6c67b3PbPliUGkswgiUiPvUz+ThgWfDMao/f38AnsNKvVviktjKpL 20zQ== X-Received: by 10.202.17.142 with SMTP id 136mr9576978oir.51.1418141806297; Tue, 09 Dec 2014 08:16:46 -0800 (PST) Received: from [192.168.168.59] (rrcs-24-227-130-234.sw.biz.rr.com. [24.227.130.234]) by mx.google.com with ESMTPSA id e8sm645272oev.4.2014.12.09.08.16.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Dec 2014 08:16:45 -0800 (PST) Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: text/plain; charset=us-ascii From: Cameron Desautels X-Priority: 3 In-Reply-To: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> Date: Tue, 9 Dec 2014 10:16:44 -0600 Content-Transfer-Encoding: 7bit Message-Id: <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> To: Drew Adams X-Mailer: Apple Mail (2.1993) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > On 2014-12-09, at 9:54 AM, Drew Adams wrote: > > Why is this in etc/TODO? If you're asking me in particular, I don't know. I just found it there and thought I'd help out. > This already exists, no? I've been using this for years: > > (add-hook 'kill-emacs-query-functions > (lambda () > (condition-case nil > (customize-unsaved) > (error t)))) A named function is probably more suitable for an end user than an arbitrary lambda, no? Plus using error handling for control flow is generally not considered a best practice, especially when it's as broad in scope as `(condition-case nil ...)`. -- Cameron Desautels From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 11:24:35 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 16:24:35 +0000 Received: from localhost ([127.0.0.1]:59857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyNaV-0006dV-II for submit@debbugs.gnu.org; Tue, 09 Dec 2014 11:24:35 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:43805) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyNaU-0006dM-C0 for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 11:24:35 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sB9GOWOW013315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Dec 2014 16:24:33 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id sB9GOVZY009790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 9 Dec 2014 16:24:32 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sB9GOV4h022436; Tue, 9 Dec 2014 16:24:31 GMT MIME-Version: 1.0 Message-ID: <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> Date: Tue, 9 Dec 2014 08:24:31 -0800 (PST) From: Drew Adams To: Cameron Desautels Subject: RE: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> In-Reply-To: <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > Why is this in etc/TODO? >=20 > If you're asking me in particular, I don't know. I just found it > there and thought I'd help out. Thanks for helping out! The question is for Emacs Dev in general, i.e., for this bug thread. > > This already exists, no? I've been using this for years: > > > > (add-hook 'kill-emacs-query-functions > > (lambda () > > (condition-case nil > > (customize-unsaved) > > (error t)))) >=20 > A named function is probably more suitable for an end user than an > arbitrary lambda, no? Plus using error handling for control flow is > generally not considered a best practice, especially when it's as > broad in scope as `(condition-case nil ...)`. That's what *I* use. I'm not saying that everyone should use it. My .emacs is used for multiple Emacs versions. You might prefer `ignore-errors', which does not exist in older versions. Or you might prefer not to ignore errors... If you want a named function and no error handling, then, well, try `customize-unsaved'. My point was that `customized-unsaved' already exists. It is precisely a "mechanism to prompt about unsaved customizations". Unless I'm missing something. AFAICT, it is exactly what is described in that TODO item: A function to check for customizable options that have been set but not saved, and ask the user whether to save them. This could go in kill-emacs-query-functions, to remind people to save their changes. If the user says yes, show them in a Custom buffer using customize-customized. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 12:05:13 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 17:05:13 +0000 Received: from localhost ([127.0.0.1]:59868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyODo-0007dN-7h for submit@debbugs.gnu.org; Tue, 09 Dec 2014 12:05:13 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:34930) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyODl-0007dE-Af for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 12:05:10 -0500 Received: by mail-ob0-f175.google.com with SMTP id wp4so770221obc.20 for <19328@debbugs.gnu.org>; Tue, 09 Dec 2014 09:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mFIXi4A/pv1w3BPQZYux5TsMTG4jRex/rCEiwvxBi8w=; b=09arxu69qKSsqDMa4M5f9v9a+JW1oMzMO+RDuZesqjX6XwsT+7/C3W6cEJHNzKL769 xrKb3w19pkuB23nN5sIdsBvLxP14e/0YAqYF5VqZ+fWX5oRZjcmvgWgJsXm823esPncy Cb6VmDRYzs+WMKZrbT+VBk9WYnB/uTsG6Gd1P4vjW2VFMNDClxOcdGJuq2gyYjAOz5ro G+/qFosJ+9GEEn6pSgHO/99Rd2LH4AAtjOikTxjK+UEFW50uZm8SNKHlZIvEGKiOMs6C IgHPqr3gUO+yqShhha4dHeICXz9RnaArfDirB3vmCaxDsyuDeGiIzrAX+dG4Fpt5eFgF AC7Q== X-Received: by 10.60.37.97 with SMTP id x1mr11724374oej.57.1418144708516; Tue, 09 Dec 2014 09:05:08 -0800 (PST) Received: from [192.168.168.59] (rrcs-24-227-130-234.sw.biz.rr.com. [24.227.130.234]) by mx.google.com with ESMTPSA id u6sm693050oej.11.2014.12.09.09.05.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Dec 2014 09:05:08 -0800 (PST) Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: text/plain; charset=us-ascii From: Cameron Desautels X-Priority: 3 In-Reply-To: <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> Date: Tue, 9 Dec 2014 11:05:06 -0600 Content-Transfer-Encoding: 7bit Message-Id: <2C7E5AC2-9C0A-43EB-8FC7-A2C9FB091EA3@gmail.com> References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> To: Drew Adams X-Mailer: Apple Mail (2.1993) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Got it. Thank you for the clarification, I think I see where our thinking has diverged: `customize-unsaved' is the existing mechanism to pop up a customize buffer displaying unsaved customization options. I've put a thin layer around this which provides a yes / no prompt to the user before (conditionally) invoking `customized-unsaved'. This is in the general spirit of hooks that run when killing Emacs ("Modified buffers exist", "Active processes exist", etc.). > If you want a named function and no error handling, then, well, try > `customize-unsaved'. `customize-unsaved' is not suitable for use in `kill-emacs-query-functions` because it signals an error if nothing has been customized, meaning that it will block the user from quitting Emacs if there are no unsaved customizations, and it will invoke the customization mechanism there are any. Ergo, they can never quit. (Drew: I'm sure you're aware of this given the way you've wrapped the call to `customize-unsaved', but I'm spelling it out for the benefit of others.) That said, the lambda you've added to `kill-emacs-query-functions' doesn't function properly either (at least not on my machine). It returns `t' in the no-unsaved-customizations case (after catching the error thrown my `customize-unsaved'), and it returns a (truthy) string, courtesy of `customize-unsaved', in the have-unsaved-custoizations case. Truthy values returned by the functions in `kill-emacs-query-functions' mean "continue with quitting Emacs", ergo the user is never prompted about unsaved customizations. Of course you can fix this easily by making sure to return nil in the happy path, but you're working up to exactly what my patch does... The one behavioral difference between the two is how we prompt: in the patched version the user is prompted in the minibuffer: "Some customized options have not been saved; Examine?", and shown a customization buffer only if they say yes. In yours, the customization buffer is automatically shown, without explanation, and attempts to quit the editor will continue to fail until the user finds either the `Revert...` or the `Apply and Save` button. I believe the patched version is a superior user experience. Have I managed to convince you? :) -- Cameron Desautels > On 2014-12-09, at 10:24 AM, Drew Adams wrote: > >>> Why is this in etc/TODO? >> >> If you're asking me in particular, I don't know. I just found it >> there and thought I'd help out. > > Thanks for helping out! The question is for Emacs Dev in general, > i.e., for this bug thread. > >>> This already exists, no? I've been using this for years: >>> >>> (add-hook 'kill-emacs-query-functions >>> (lambda () >>> (condition-case nil >>> (customize-unsaved) >>> (error t)))) >> >> A named function is probably more suitable for an end user than an >> arbitrary lambda, no? Plus using error handling for control flow is >> generally not considered a best practice, especially when it's as >> broad in scope as `(condition-case nil ...)`. > > That's what *I* use. I'm not saying that everyone should use it. > My .emacs is used for multiple Emacs versions. You might prefer > `ignore-errors', which does not exist in older versions. Or you > might prefer not to ignore errors... > > If you want a named function and no error handling, then, well, > try `customize-unsaved'. > > My point was that `customized-unsaved' already exists. It is > precisely a "mechanism to prompt about unsaved customizations". > Unless I'm missing something. AFAICT, it is exactly what is > described in that TODO item: > > A function to check for customizable options that have been > set but not saved, and ask the user whether to save them. > This could go in kill-emacs-query-functions, to remind people > to save their changes. If the user says yes, show them > in a Custom buffer using customize-customized. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 12:46:37 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 17:46:37 +0000 Received: from localhost ([127.0.0.1]:59887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyOrs-0000G3-8A for submit@debbugs.gnu.org; Tue, 09 Dec 2014 12:46:36 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:32361) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyOrq-0000Fv-2M for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 12:46:34 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sB9HkW7v003535 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Dec 2014 17:46:33 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id sB9HkVwN022002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 9 Dec 2014 17:46:32 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sB9HkV6j019555; Tue, 9 Dec 2014 17:46:31 GMT MIME-Version: 1.0 Message-ID: <09009907-c8b9-4279-baa8-5c4be0cdf66b@default> Date: Tue, 9 Dec 2014 09:46:30 -0800 (PST) From: Drew Adams To: Cameron Desautels Subject: RE: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> <2C7E5AC2-9C0A-43EB-8FC7-A2C9FB091EA3@gmail.com> In-Reply-To: <2C7E5AC2-9C0A-43EB-8FC7-A2C9FB091EA3@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Got it. Thank you for the clarification, I think I see where our > thinking has diverged: `customize-unsaved' is the existing mechanism > to pop up a customize buffer displaying unsaved customization > options. I've put a thin layer around this which provides a yes / no > prompt to the user before (conditionally) invoking `customized-unsaved'. > This is in the general spirit of hooks that run when killing Emacs > ("Modified buffers exist", "Active processes exist", etc.). >=20 > > If you want a named function and no error handling, then, well, > > try `customize-unsaved'. >=20 > `customize-unsaved' is not suitable for use in > `kill-emacs-query-functions` because it signals an error if nothing > has been customized, meaning that it will block the user from > quitting Emacs if there are no unsaved customizations, and it will > invoke the customization mechanism there are any. Ergo, they can > never quit. (Drew: I'm sure you're aware of this given the way you've > wrapped the call to `customize-unsaved', but I'm spelling it out > for the benefit of others.) >=20 > That said, the lambda you've added to `kill-emacs-query-functions' > doesn't function properly either (at least not on my machine). It > returns `t' in the no-unsaved-customizations case (after catching > the error thrown my `customize-unsaved'), and it returns a (truthy) > string, courtesy of `customize-unsaved', in the > have-unsaved-custoizations case. Truthy values returned by the > functions in `kill-emacs-query-functions' mean "continue with > quitting Emacs", ergo the user is never prompted about unsaved > customizations. >=20 > Of course you can fix this easily by making sure to return nil in > the happy path, but you're working up to exactly what my patch does... >=20 > The one behavioral difference between the two is how we prompt: in > the patched version the user is prompted in the minibuffer: "Some > customized options have not been saved; Examine?", and shown a > customization buffer only if they say yes. >=20 > In yours, the customization buffer is automatically shown, without > explanation, and attempts to quit the editor will continue to fail > until the user finds either the `Revert...` or the `Apply and Save` > button. >=20 > I believe the patched version is a superior user experience. Have I > managed to convince you? :) OK. In fact, I use `cus-edit+.el', which redefines `customize-unsaved' so that it DTRT. I offered this to Emacs Dev long ago, but no interest. Perhaps you will have better luck. ;-) FWIW, These are the changes I made to `customize-unsaved': ;; 1. By default, ignores preferences in `customize-customized-ignore'. ;; 2. Added prefix arg to override `customize-customized-ignore'. ;; 3. When not interactive and there are changes, ask for confirmation. ;; 4. Always returns `t', so it can be used as a ;; `kill-emacs-query-functions' hook. ;; 5. Wrap in `condition-case' and reissue error. The code is here, in case you are interested: http://www.emacswiki.org/emacs-en/download/cus-edit%2b.el And here is some info about it: http://www.emacswiki.org/CustomizingAndSaving#CustomizePlus HTH. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 14:48:00 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 19:48:00 +0000 Received: from localhost ([127.0.0.1]:59975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyQlM-0004le-6p for submit@debbugs.gnu.org; Tue, 09 Dec 2014 14:48:00 -0500 Received: from mail-oi0-f49.google.com ([209.85.218.49]:63461) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyQlK-0004lW-0I for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 14:47:58 -0500 Received: by mail-oi0-f49.google.com with SMTP id i138so912412oig.36 for <19328@debbugs.gnu.org>; Tue, 09 Dec 2014 11:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=b9j/ffEacM6ximJ+ddJAsIpTQaMj+WG0/tAkTF8RdAg=; b=Thuh7zQe5VDSQkEJfYpf+KyxgM9Amv5xeh+keKwKF0pv8W9n2JFhnK0WF9w/4WAp/I bIRRXPRVEb3MQPigaPD7sMQmSfO7HWO0pfvai2qv/gWNYiCkjEfRXkNJbfQWI21oXpeI jqwksE8uAk5jiK1gf9g4J3paPpECW4U4IA1K1Jbh2KkxXO+qI12R2btGecRipRlGlDaW 9pkrs8u9H8k9xGQUdQqE26ZGI1hzOKmRrUsO1viVXV+QbUIBJSiF/CZ0dJRk2d972nQa x8jHBliSuvNK10vbV/fdiUeidbb3XaQvqFw85nqsd3WMhATThnaES3XSUHoYf406GJwE TrAQ== X-Received: by 10.202.89.138 with SMTP id n132mr11238352oib.109.1418154477140; Tue, 09 Dec 2014 11:47:57 -0800 (PST) Received: from [192.168.168.123] (rrcs-24-227-130-234.sw.biz.rr.com. [24.227.130.234]) by mx.google.com with ESMTPSA id ph6sm901129oeb.5.2014.12.09.11.47.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Dec 2014 11:47:56 -0800 (PST) Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: text/plain; charset=us-ascii From: Cameron Desautels X-Priority: 3 In-Reply-To: <09009907-c8b9-4279-baa8-5c4be0cdf66b@default> Date: Tue, 9 Dec 2014 13:47:56 -0600 Content-Transfer-Encoding: 7bit Message-Id: <74EB846F-F46E-427B-90BB-E79EC1934F93@gmail.com> References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> <2C7E5AC2-9C0A-43EB-8FC7-A2C9FB091EA3@gmail.com> <09009907-c8b9-4279-baa8-5c4be0cdf66b@default> To: Drew Adams X-Mailer: Apple Mail (2.1993) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > FWIW, These are the changes I made to `customize-unsaved': > ;; 1. By default, ignores preferences in `customize-customized-ignore'. > ;; 2. Added prefix arg to override `customize-customized-ignore'. > ;; 3. When not interactive and there are changes, ask for confirmation. > ;; 4. Always returns `t', so it can be used as a > ;; `kill-emacs-query-functions' hook. > ;; 5. Wrap in `condition-case' and reissue error. Thank you for sharing that! I looked through it to see if I'm missing anything important. Your code is much more ambitious than the humble patch I'm offering. I definitely see the rationale behind your work on `cus-edit+.el' but I think the important parts of it are orthogonal to what I've done here. WRT the five items above, 1 & 2 can be disregarded here because `customize-customized-ignore' only exists in your library (and is only necessary because of the elimination of the "changed outside of Customize" state). 3-5 I cover differently--a new function rather than changing the behavior of `customize-unsaved'--and this way has the benefit of being minimally invasive (i.e. shouldn't break anyone else's code). TLDR I still think it makes sense to merge the patch. -- Cameron Desautels From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 15:10:28 2014 Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 20:10:28 +0000 Received: from localhost ([127.0.0.1]:59983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyR74-0005LN-Tt for submit@debbugs.gnu.org; Tue, 09 Dec 2014 15:10:27 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyR73-0005LF-7y for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 15:10:25 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sB9KANlD028060 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Dec 2014 20:10:24 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sB9KANLp014612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 9 Dec 2014 20:10:23 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sB9KAMMa015876; Tue, 9 Dec 2014 20:10:22 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 9 Dec 2014 12:10:23 -0800 (PST) From: Drew Adams To: Cameron Desautels Subject: RE: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> <2C7E5AC2-9C0A-43EB-8FC7-A2C9FB091EA3@gmail.com> <09009907-c8b9-4279-baa8-5c4be0cdf66b@default> <74EB846F-F46E-427B-90BB-E79EC1934F93@gmail.com> In-Reply-To: <74EB846F-F46E-427B-90BB-E79EC1934F93@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > 3-5 I cover differently--a new function rather than changing the > behavior of `customize-unsaved'--and this way has the benefit of > being minimally invasive (i.e. shouldn't break anyone else's code). OK by me. (I didn't look at the patch, but the idea sounds OK.) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 10 10:32:02 2014 Received: (at 19328) by debbugs.gnu.org; 10 Dec 2014 15:32:02 +0000 Received: from localhost ([127.0.0.1]:60777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyjFB-0003u8-68 for submit@debbugs.gnu.org; Wed, 10 Dec 2014 10:32:01 -0500 Received: from mail-qa0-f47.google.com ([209.85.216.47]:57197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyjF9-0003tt-1i for 19328@debbugs.gnu.org; Wed, 10 Dec 2014 10:31:59 -0500 Received: by mail-qa0-f47.google.com with SMTP id s7so2120612qap.6 for <19328@debbugs.gnu.org>; Wed, 10 Dec 2014 07:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=XlHjuvp9rpykfMQEs51p3UVAHwra8XpRMPBKTWsTvFw=; b=Ue1lsbVhqbaXAKMV2NX3lfhcFma/jjlexLxdJGWaPNqkL2pQ5mPEwmePZmpV1cl6dJ MpCfotoeJf7Zo2SVKSN5dK4dnUwuIlaDHKMOHtJNW0LRS/3ZKv3LCud755GVx3no7wWm Y3F0S+N7hkHckg+GvkwI82i7mUBECiaejQAMo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=XlHjuvp9rpykfMQEs51p3UVAHwra8XpRMPBKTWsTvFw=; b=FYLbUu9UNp9GxfvKKZZTmQP+AqjVa2f7woT+KrQ29u8Qu/khg8tGDwdpDjfiEFJTb5 Irj3s0Et+v7VOX2nn1MEraF/1q4RGPyTLDhVNt9ELqKwVSiMn4Gn3mjIjOajuBqTxa3I Qag5PQoqrfnDvEn7/OqCrIYblcQgvl71XewrmtMMc0YS7AM6D6r3gv/XzyPCT9r/IOg5 l5QRorUOzBTzYx8GHW99WsY2ULarKRCbGcNNatccmn3QFWYCCxUdDkAQmVB9M9kXgKnH 6lgmZaw9P5+pfdwq45EM1jL+1Si0ALB6hSLVMElT9PqD0+6WmF+xZrDRlhFh0IMT6Zxb IQnw== X-Gm-Message-State: ALoCoQmmpf3vnJKm+f+nGd089jrmHg32PmvHOlfZgooG+JWiP9jK6e4cRaf8d3byoxB5pPitKy88 X-Received: by 10.140.30.69 with SMTP id c63mr8954716qgc.13.1418225518371; Wed, 10 Dec 2014 07:31:58 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id p67sm4465080qga.26.2014.12.10.07.31.57 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 10 Dec 2014 07:31:57 -0800 (PST) From: Ted Zlatanov To: Cameron Desautels Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 10 Dec 2014 10:32:51 -0500 In-Reply-To: (Cameron Desautels's message of "Tue, 9 Dec 2014 09:46:22 -0600") Message-ID: <87egs7a5b0.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 9 Dec 2014 09:46:22 -0600 Cameron Desautels wrote: CD> Implements the following, as requested in `etc/TODO`: CD> ** A function to check for customizable options that have been CD> set but not saved, and ask the user whether to save them. CD> This could go in kill-emacs-query-functions, to remind people CD> to save their changes. If the user says yes, show them CD> in a Custom buffer using customize-customized. CD> My copyright assignment info should be on file. I like it! Could you add a NEWS entry and maybe some docs in the manual? I think it's very helpful for beginners. The code looks OK to me. Ted From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 20:04:28 2014 Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 01:04:28 +0000 Received: from localhost ([127.0.0.1]:43353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzEeh-0004L5-TB for submit@debbugs.gnu.org; Thu, 11 Dec 2014 20:04:28 -0500 Received: from mail-ie0-f178.google.com ([209.85.223.178]:49664) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzEef-0004Kt-KN for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 20:04:26 -0500 Received: by mail-ie0-f178.google.com with SMTP id tp5so6033044ieb.9 for <19328@debbugs.gnu.org>; Thu, 11 Dec 2014 17:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2BKJgQAX1FIjgmVbUn6phwCh8hogrxejnJvvRYzN7WA=; b=YYNkIQKiRhrh5cLV8xR9ODD28Pm9BCe9bDq6vFrbKBA+FTM19DgqLZV3euHZ9KDuB0 /VBAjwmOPxG1AMA0R1NwMMzAXCqZhIvQOud3ns6ZcxKLGMbPBAEDDYu2lDeSG/OZufJh g2WdVwwHF0Ihzh+8p0cy11pVGvfS+Yek8WeQSi8ZiWj68/LU5D56Y86AkDn79WQk1ym4 5Hnk4XXDQCEdaKcitYFGRhT162VkAL1wJQbQ3+AAm5Yps73L8dQNLe22bfZeD0Hy7juI akkMeHVMONqRBAFEWKlxmdSHMCwGcG7o95w7WO38oL3LToaq5Qv4Gg5RVGGQ8extfEbO BiRw== MIME-Version: 1.0 X-Received: by 10.107.11.10 with SMTP id v10mr3649652ioi.12.1418346259868; Thu, 11 Dec 2014 17:04:19 -0800 (PST) Received: by 10.107.43.8 with HTTP; Thu, 11 Dec 2014 17:04:19 -0800 (PST) In-Reply-To: <87egs7a5b0.fsf@lifelogs.com> References: <87egs7a5b0.fsf@lifelogs.com> Date: Thu, 11 Dec 2014 19:04:19 -0600 Message-ID: Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations From: Cameron Desautels To: Ted Zlatanov Content-Type: multipart/mixed; boundary=001a113f9232fd1fc20509fa783e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113f9232fd1fc20509fa783e Content-Type: text/plain; charset=UTF-8 > Could you add a NEWS entry and maybe some docs in the manual? I think > it's very helpful for beginners. The code looks OK to me. Absolutely! I've attached an updated version of the patch with the requested additions. What about turning something like this on by default? Any strong opinions? Having it available to add to the hook is a step in the right direction, but the users most likely to be helped by it are (I assume) less likely to be editing their initialization file by hand. If it does make sense to turn it on by default then I suspect the implementation would be rather different from a call to `add-hook' (it seems a bit odd to have a user call `remove-hook' to turn off the behavior), so perhaps an addition to `save-buffers-kill-emacs' and a variable to toggle the feature would be in order? -- Cameron Desautels --001a113f9232fd1fc20509fa783e Content-Type: application/octet-stream; name="0001-Add-mechanism-to-prompt-about-unsaved-customizations.patch" Content-Disposition: attachment; filename="0001-Add-mechanism-to-prompt-about-unsaved-customizations.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i3kuq3pz0 RnJvbSAyNGYyNWZhODA2ZDY2M2Q4Mzc3ODdjYzMwMTM4NmI4ODdkMmUwYjE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYW1lcm9uIERlc2F1dGVscyA8Y2FtZGV6QGdtYWlsLmNvbT4K RGF0ZTogVHVlLCA5IERlYyAyMDE0IDAwOjI4OjQ0IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IG1lY2hhbmlzbSB0byBwcm9tcHQgYWJvdXQgdW5zYXZlZCBjdXN0b21pemF0aW9ucwoKLSBSZXF1 ZXN0ZWQgaW4gYGV0Yy9UT0RPJwotIFN1aXRhYmxlIGZvciB1c2UgaW4gYGtpbGwtZW1hY3MtcXVl cnktZnVuY3Rpb25zJy4KLS0tCiBkb2MvZW1hY3MvY3VzdG9tLnRleGkgfCAxMCArKysrKysrKysr CiBldGMvTkVXUyAgICAgICAgICAgICAgfCAgMyArKysKIGV0Yy9UT0RPICAgICAgICAgICAgICB8 ICA2IC0tLS0tLQogbGlzcC9DaGFuZ2VMb2cgICAgICAgIHwgIDUgKysrKysKIGxpc3AvY3VzLWVk aXQuZWwgICAgICB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCiA1IGZpbGVzIGNo YW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Rv Yy9lbWFjcy9jdXN0b20udGV4aSBiL2RvYy9lbWFjcy9jdXN0b20udGV4aQppbmRleCAwZDAwMTNm Li42YzM5MmNiIDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvY3VzdG9tLnRleGkKKysrIGIvZG9jL2Vt YWNzL2N1c3RvbS50ZXhpCkBAIC00MDUsNiArNDA1LDE2IEBAIGN1c3RvbWl6YXRpb25zIGluIHlv dXIgaW5pdGlhbGl6YXRpb24gZmlsZS4gIFRoaXMgaXMgYmVjYXVzZSBzYXZpbmcKIGN1c3RvbWl6 YXRpb25zIGZyb20gc3VjaCBhIHNlc3Npb24gd291bGQgd2lwZSBvdXQgYWxsIHRoZSBvdGhlcgog Y3VzdG9taXphdGlvbnMgeW91IG1pZ2h0IGhhdmUgb24geW91ciBpbml0aWFsaXphdGlvbiBmaWxl LgogCisgIFBsZWFzZSBub3RlIHRoYXQgYW55IGN1c3RvbWl6YXRpb25zIHlvdSBoYXZlIG5vdCBj aG9zZW4gdG8gc2F2ZSBmb3IKK2Z1dHVyZSBzZXNzaW9ucyB3aWxsIGJlIGxvc3Qgd2hlbiB5b3Ug dGVybWluYXRlIEVtYWNzLiAgSWYgeW91J2QgbGlrZQordG8gYmUgcHJvbXB0ZWQgYWJvdXQgdW5z YXZlZCBjdXN0b21pemF0aW9ucyBhdCB0ZXJtaW5hdGlvbiB0aW1lLCBhZGQKK3RoZSBmb2xsb3dp bmcgdG8geW91ciBpbml0aWFsaXphdGlvbiBmaWxlOgorCitAZXhhbXBsZQorKGFkZC1ob29rICdr aWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucworICAgICAgICAgICdjdXN0b20tcHJvbXB0LWN1c3Rv bWl6ZS11bnNhdmVkLW9wdGlvbnMpCitAZW5kIGV4YW1wbGUKKwogQG5vZGUgRmFjZSBDdXN0b21p emF0aW9uCiBAc3Vic2VjdGlvbiBDdXN0b21pemluZyBGYWNlcwogQGNpbmRleCBjdXN0b21pemlu ZyBmYWNlcwpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA1OGE1ODM2Li5h NTgzYWYyIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNDksNiArNDks OSBAQCBVc2UgJy4vY29uZmlndXJlIFBLR19DT05GSUc9L2Z1bGwvbmFtZS9vZi9wa2ctY29uZmln JyBpZiB5b3UgbmVlZCB0by4KIAwKICogQ2hhbmdlcyBpbiBFbWFjcyAyNS4xCiAKKyoqIE5ldyBm dW5jdGlvbiBgY3VzdG9tLXByb21wdC1jdXN0b21pemUtdW5zYXZlZC1vcHRpb25zJyBjaGVja3Mg Zm9yCit1bnNhdmVkIGN1c3RvbWl6YXRpb25zIGFuZCBwcm9tcHRzIHVzZXIgdG8gY3VzdG9taXpl IChpZiBmb3VuZCkuCisKICsrKwogKiogTmV0d29yayBzZWN1cml0eSAoVExTL1NTTCBjZXJ0aWZp Y2F0ZSB2YWxpZGl0eSBhbmQgdGhlIGxpa2UpIGlzCiBhZGRlZCB2aWEgdGhlIG5ldyBOZXR3b3Jr IFNlY3VyaXR5IE1hbmFnZXIgKE5TTSkgYW5kIGNvbnRyb2xsZWQgdmlhCmRpZmYgLS1naXQgYS9l dGMvVE9ETyBiL2V0Yy9UT0RPCmluZGV4IGNjZDAwZTUuLmNiYjIzOTQgMTAwNjQ0Ci0tLSBhL2V0 Yy9UT0RPCisrKyBiL2V0Yy9UT0RPCkBAIC00MTksMTIgKzQxOSw2IEBAIHJhdGhlciB0aGFuIGlu dGVyYWN0aXZlbHkuICBUaGlzIGEgdHJpdmlhbCBvbmUtbGluZXIgaW4gZWFzeS1tb2RlLmVsLgog CiAqKiBNYWtlIGJ5dGUtb3B0aW1pemF0aW9uIHdhcm5pbmdzIGlzc3VlIGFjY3VyYXRlIGxpbmUg bnVtYmVycy4KIAotKiogQSBmdW5jdGlvbiB0byBjaGVjayBmb3IgY3VzdG9taXphYmxlIG9wdGlv bnMgdGhhdCBoYXZlIGJlZW4KLSAgc2V0IGJ1dCBub3Qgc2F2ZWQsIGFuZCBhc2sgdGhlIHVzZXIg d2hldGhlciB0byBzYXZlIHRoZW0uCi0gIFRoaXMgY291bGQgZ28gaW4ga2lsbC1lbWFjcy1xdWVy eS1mdW5jdGlvbnMsIHRvIHJlbWluZCBwZW9wbGUKLSAgdG8gc2F2ZSB0aGVpciBjaGFuZ2VzLiBJ ZiB0aGUgdXNlciBzYXlzIHllcywgc2hvdyB0aGVtCi0gIGluIGEgQ3VzdG9tIGJ1ZmZlciB1c2lu ZyBjdXN0b21pemUtY3VzdG9taXplZC4KLQogKiogUmVjb3JkIHRoZSBzeGhhc2ggb2YgdGhlIGRl ZmF1bHQgdmFsdWUgZm9yIGN1c3RvbWl6ZWQgdmFyaWFibGVzCiAgIGFuZCBub3RpZnkgdGhlIHVz ZXIgKG1heWJlIGJ5IGFkZGluZyBhIG1lbnUgaXRlbSBvciB0b29sYmFyIGJ1dHRvbiwKICAgYXMg dGhlIGRldGVjdGlvbiBjYW4gb2NjdXIgZHVyaW5nIGF1dG9sb2FkIHRpbWUpIHdoZW4gdGhlIGRl ZmF1bHQKZGlmZiAtLWdpdCBhL2xpc3AvQ2hhbmdlTG9nIGIvbGlzcC9DaGFuZ2VMb2cKaW5kZXgg NDUyZjRjMy4uMGJkNWEwMyAxMDA2NDQKLS0tIGEvbGlzcC9DaGFuZ2VMb2cKKysrIGIvbGlzcC9D aGFuZ2VMb2cKQEAgLTEsMyArMSw4IEBACisyMDE0LTEyLTExICBDYW1lcm9uIERlc2F1dGVscyAg PGNhbWRlekBnbWFpbC5jb20+CisKKwkqIGN1cy1lZGl0LmVsIChjdXN0b20tcHJvbXB0LWN1c3Rv bWl6ZS11bnNhdmVkLW9wdGlvbnMpOiBBZGQgYQorCW1lY2hhbmlzbSBmb3IgcHJvbXB0aW5nIHVz ZXIgYWJvdXQgdW5zYXZlZCBjdXN0b21pemF0aW9ucy4KKwogMjAxNC0xMi0xMSAgTWljaGFlbCBB bGJpbnVzICA8bWljaGFlbC5hbGJpbnVzQGdteC5kZT4KIAogCSogdmMvdmMtaGcuZWwgKHZjLWhn LXN0YXRlKTogTWFrZSBGSUxFIGFic29sdXRlLiAgSGFuZGxlIHRoZSBjYXNlCmRpZmYgLS1naXQg YS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5lbAppbmRleCBjOGU5YjkwLi5hNmRh NTBlIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVsCisrKyBiL2xpc3AvY3VzLWVkaXQuZWwK QEAgLTEzNTYsMTIgKzEzNTYsMTAgQEAgc3VnZ2VzdCB0byBjdXN0b21pemUgdGhhdCBmYWNlLCBp ZiBpdCdzIGN1c3RvbWl6YWJsZS4iCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKG9yIChmYWNlLWF0LXBvaW50IHQgdCkgImFsbCBmYWNlcyIpIHQpKSkKICAgKGN1c3RvbWl6 ZS1mYWNlIGZhY2UgdCkpCiAKLShkZWZhbGlhcyAnY3VzdG9taXplLWN1c3RvbWl6ZWQgJ2N1c3Rv bWl6ZS11bnNhdmVkKQotCi07OzsjIyNhdXRvbG9hZAotKGRlZnVuIGN1c3RvbWl6ZS11bnNhdmVk ICgpCi0gICJDdXN0b21pemUgYWxsIG9wdGlvbnMgYW5kIGZhY2VzIHNldCBpbiB0aGlzIHNlc3Np b24gYnV0IG5vdCBzYXZlZC4iCi0gIChpbnRlcmFjdGl2ZSkKKyhkZWZ1biBjdXN0b20tdW5zYXZl ZC1vcHRpb25zICgpCisgICJMaXN0IG9mIG9wdGlvbnMgYW5kIGZhY2VzIHNldCBpbiB0aGlzIHNl c3Npb24gYnV0IG5vdCBzYXZlZC4KK0VhY2ggZW50cnkgaXMgb2YgdGhlIGZvcm0gKFNZTUJPTCBU WVBFKSwgd2hlcmUgVFlQRSBpcyBvbmUgb2YgdGhlCitzeW1ib2xzIGBjdXN0b20tZmFjZScgb3Ig YGN1c3RvbS12YXJpYWJsZScuIgogICAobGV0ICgoZm91bmQgbmlsKSkKICAgICAobWFwYXRvbXMg KGxhbWJkYSAoc3ltYm9sKQogCQkoYW5kIChvciAoZ2V0IHN5bWJvbCAnY3VzdG9taXplZC1mYWNl KQpAQCAtMTM3Miw2ICsxMzcwLDE1IEBAIHN1Z2dlc3QgdG8gY3VzdG9taXplIHRoYXQgZmFjZSwg aWYgaXQncyBjdXN0b21pemFibGUuIgogCQkJIChnZXQgc3ltYm9sICdjdXN0b21pemVkLXZhcmlh YmxlLWNvbW1lbnQpKQogCQkgICAgIChib3VuZHAgc3ltYm9sKQogCQkgICAgIChwdXNoIChsaXN0 IHN5bWJvbCAnY3VzdG9tLXZhcmlhYmxlKSBmb3VuZCkpKSkKKyAgICBmb3VuZCkpCisKKyhkZWZh bGlhcyAnY3VzdG9taXplLWN1c3RvbWl6ZWQgJ2N1c3RvbWl6ZS11bnNhdmVkKQorCis7OzsjIyNh dXRvbG9hZAorKGRlZnVuIGN1c3RvbWl6ZS11bnNhdmVkICgpCisgICJDdXN0b21pemUgYWxsIG9w dGlvbnMgYW5kIGZhY2VzIHNldCBpbiB0aGlzIHNlc3Npb24gYnV0IG5vdCBzYXZlZC4iCisgIChp bnRlcmFjdGl2ZSkKKyAgKGxldCAoKGZvdW5kIChjdXN0b20tdW5zYXZlZC1vcHRpb25zKSkpCiAg ICAgKGlmIChub3QgZm91bmQpCiAJKGVycm9yICJObyB1c2VyIG9wdGlvbnMgYXJlIHNldCBidXQg dW5zYXZlZCIpCiAgICAgICAoY3VzdG9tLWJ1ZmZlci1jcmVhdGUgKGN1c3RvbS1zb3J0LWl0ZW1z IGZvdW5kIHQgbmlsKQpAQCAtMTQ3Nyw2ICsxNDg0LDE2IEBAIElmIFRZUEUgaXMgYGdyb3Vwcycs IGluY2x1ZGUgb25seSBncm91cHMuIgogICAoaW50ZXJhY3RpdmUgKGxpc3QgKGFwcm9wb3MtcmVh ZC1wYXR0ZXJuICJncm91cHMiKSkpCiAgIChjdXN0b21pemUtYXByb3BvcyByZWdleHAgJ2dyb3Vw cykpCiAKKzs7OyMjI2F1dG9sb2FkCisoZGVmdW4gY3VzdG9tLXByb21wdC1jdXN0b21pemUtdW5z YXZlZC1vcHRpb25zICgpCisgICJQcm9tcHQgdXNlciB0byBjdXN0b21pemUgYW55IHVuc2F2ZWQg Y3VzdG9taXphdGlvbiBvcHRpb25zLgorUmV0dXJuIG5vbi1uaWwgaWYgdXNlciBjaG9vc2VzIHRv IGN1c3RvbWl6ZSwgZm9yIHVzZSBpbgorYGtpbGwtZW1hY3MtcXVlcnktZnVuY3Rpb25zJy4iCisg IChub3QgKGFuZCAoY3VzdG9tLXVuc2F2ZWQtb3B0aW9ucykKKwkgICAgKHllcy1vci1uby1wICJT b21lIGN1c3RvbWl6ZWQgb3B0aW9ucyBoYXZlIG5vdCBiZWVuIHNhdmVkOyBFeGFtaW5lPyAiKQor CSAgICAoY3VzdG9taXplLXVuc2F2ZWQpCisJICAgIHQpKSkKKwogOzs7IEJ1ZmZlci4KIAogKGRl ZmN1c3RvbSBjdXN0b20tYnVmZmVyLXN0eWxlICdsaW5rcwotLSAKMi4yLjAKCg== --001a113f9232fd1fc20509fa783e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 20:40:48 2014 Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 01:40:48 +0000 Received: from localhost ([127.0.0.1]:43370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzFDr-0005Hl-Ab for submit@debbugs.gnu.org; Thu, 11 Dec 2014 20:40:47 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:32702) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzFDn-0005HV-Pi for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 20:40:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCwsOJhIUGA0kLogcCdZZAQEBAQYBAQEBHpBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IPAS-Result: AjwPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCwsOJhIUGA0kLogcCdZZAQEBAQYBAQEBHpBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="100242871" Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Dec 2014 20:40:38 -0500 Received: by pastel.home (Postfix, from userid 20848) id D7136262D; Thu, 11 Dec 2014 20:40:36 -0500 (EST) From: Stefan Monnier To: Cameron Desautels Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Message-ID: References: <87egs7a5b0.fsf@lifelogs.com> Date: Thu, 11 Dec 2014 20:40:36 -0500 In-Reply-To: (Cameron Desautels's message of "Thu, 11 Dec 2014 19:04:19 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > What about turning something like this on by default? I'm not necessarily opposed to it, but I wonder if it's sufficiently unintrusive. E.g. if you just want to try out a minor mode like global-auto-revert-mode, IIUC this will set the var and mark it as "set but unsaved", so when you exit, Emacs will prompt you to save this setting. Maybe it's actually the right thing to do, but I wonder if it will turn out to be more annoying than useful. And I don't see a good solution for it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 20:57:08 2014 Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 01:57:08 +0000 Received: from localhost ([127.0.0.1]:43384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzFTf-0005gp-Kp for submit@debbugs.gnu.org; Thu, 11 Dec 2014 20:57:07 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:65197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzFTd-0005gJ-Pw for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 20:57:06 -0500 Received: by mail-lb0-f179.google.com with SMTP id z11so5095713lbi.24 for <19328@debbugs.gnu.org>; Thu, 11 Dec 2014 17:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mRskNC4h5TOMlLm1O4UUGs1/W0fzNLCvz/Iuqm27NkA=; b=S+YOrKAhxPe873VQyl71Odocfv3a6Zh8vKkmIHwTrLNjU6gTd2xoqUKUqYOS1LAkSb Mwn4QsD3JuaYGk4fBWem4ndsqR5xh9REAkO4/krAqIWxH9s0uPCwvc/pWhrQAeAQ1zkb V3/OjAI1eToZnf1j2+JzmZh/O73bF9T4cpbgiK4jjT5TuQs3CgtBGOqX1sz1M5tWRNyI sazw3Mo7NezMnkRBfxQwqoBc/gLKOSVCAhKOfxHzERsXsD0yXfr/yI5mnzrck04bViyE bUdsw1wmteoo/Y0mEv1dPboeWK2Ec2g0Kdm6kKp4XOg3wKL//fywQGCMxlEDNTC/zhHh VroA== MIME-Version: 1.0 X-Received: by 10.112.235.164 with SMTP id un4mr3318677lbc.56.1418349419677; Thu, 11 Dec 2014 17:56:59 -0800 (PST) Received: by 10.25.205.66 with HTTP; Thu, 11 Dec 2014 17:56:59 -0800 (PST) In-Reply-To: References: <87egs7a5b0.fsf@lifelogs.com> Date: Thu, 11 Dec 2014 19:56:59 -0600 Message-ID: Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations From: Cameron Desautels To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > I'm not necessarily opposed to it, but I wonder if it's > sufficiently unintrusive. Well, on quick sessions in-and-out of Emacs (say, on git commits), users will never be prompted because there won't be any customizations. But I suspect that if someone took the time to edit their preferences, odds are good they want them saved. Experiments to try something like `global-auto-revert-mode' seem like the minority of cases (plus "no" isn't *that* long of a word in the event that you are prompted), and more serious Emacs users (1) don't even close Emacs that often, (2) probably have most of their configuration done through handwritten Elisp, and (3) can easily disable the prompt. Hell, we could even make the "prompt for unsaved customizations" option customizable. I don't have an exceedingly strong opinion but FWIW I sat down to hack this out after seeing a friend and Emacs newbie spend quite a while customizing faces for visibility and then lose it all at quit time. Then I found the same request in the TODO file and it seemed worth doing. Obviously that's highly anecdotal, but I can imagine it being a common problem. -- Cameron Desautels On Thu, Dec 11, 2014 at 7:40 PM, Stefan Monnier wrote: >> What about turning something like this on by default? > > I'm not necessarily opposed to it, but I wonder if it's > sufficiently unintrusive. > > E.g. if you just want to try out a minor mode like global-auto-revert-mode, > IIUC this will set the var and mark it as "set but unsaved", so when you > exit, Emacs will prompt you to save this setting. > > Maybe it's actually the right thing to do, but I wonder if it will turn > out to be more annoying than useful. And I don't see a good solution for it. > > > Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 21:36:28 2014 Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 02:36:28 +0000 Received: from localhost ([127.0.0.1]:43394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzG5j-0006dV-LB for submit@debbugs.gnu.org; Thu, 11 Dec 2014 21:36:27 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:43721) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzG5g-0006dF-DB for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 21:36:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCwsOJhIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGkLoF4hBkhgncBAQE X-IPAS-Result: AjwPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCwsOJhIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGkLoF4hBkhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="100244998" Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Dec 2014 21:36:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id 73B1B2ED1; Thu, 11 Dec 2014 21:36:15 -0500 (EST) From: Stefan Monnier To: Cameron Desautels Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Message-ID: References: <87egs7a5b0.fsf@lifelogs.com> Date: Thu, 11 Dec 2014 21:36:15 -0500 In-Reply-To: (Cameron Desautels's message of "Thu, 11 Dec 2014 19:56:59 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I don't have an exceedingly strong opinion but FWIW I sat down to hack > this out after seeing a friend and Emacs newbie spend quite a while > customizing faces for visibility and then lose it all at quit time. > Then I found the same request in the TODO file and it seemed worth > doing. Obviously that's highly anecdotal, but I can imagine it being a > common problem. Oh yes, I'm quite aware of this problem, which is why I think this feature is very nice and that's also why I'm saying that I'm not necessarily opposed to enabling it by default. But I'd like to some opinion from people who've actually tried it. Many Emacs users can have very strong reactions to very small changes in the default behavior. The potential benefit justifies a bit of potential annoyance, and I think I can evaluate the potential benefit, but I don't think I can evaluate the potential annoyance yet. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 21:39:47 2014 Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 02:39:47 +0000 Received: from localhost ([127.0.0.1]:43399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzG8x-0006iR-7x for submit@debbugs.gnu.org; Thu, 11 Dec 2014 21:39:47 -0500 Received: from mail-ie0-f169.google.com ([209.85.223.169]:36442) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzG8v-0006iD-Mr for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 21:39:46 -0500 Received: by mail-ie0-f169.google.com with SMTP id y20so6202233ier.28 for <19328@debbugs.gnu.org>; Thu, 11 Dec 2014 18:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EtJun8+LqMKcrkS+uV1nCJCdbOynkI38GjXVQC7gPg8=; b=f19f892ySb5wOsms3v+lOndDSxbnGgCN9WIqSS2A2JHKdf/nsCvZMRzJColB/sDLCf BNgFN2w8Wkt+3mDaYkJj+Yya/dPW7A5B5BzpZkp/hcLN52zngHuY9wmplTe6GMZxLqQz 2G57Oc++hr8kO2rONRvfZCz8H8qTxyVlLDIHzqZVgjZlypskKiluOFWbFJG71Oi4Rhgz KZjiXAZc5ggWQ0VSQVzqCklGPivYStbrNsdEwuscQyGiKN4WWFZ9XbdLk1z+oI9szjAM AK4W62h5g7ydLkdWtuqgjaoM4Zu3+d+kRJmlx0MNhvjthR54Cv0t4Exabs6hW4ANQEoo eRyg== MIME-Version: 1.0 X-Received: by 10.42.30.13 with SMTP id t13mr14441568icc.40.1418351979931; Thu, 11 Dec 2014 18:39:39 -0800 (PST) Received: by 10.107.43.8 with HTTP; Thu, 11 Dec 2014 18:39:39 -0800 (PST) In-Reply-To: References: <87egs7a5b0.fsf@lifelogs.com> Date: Thu, 11 Dec 2014 20:39:39 -0600 Message-ID: Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations From: Cameron Desautels To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Dec 11, 2014 at 8:36 PM, Stefan Monnier wrote: > Oh yes, I'm quite aware of this problem, which is why I think this > feature is very nice and that's also why I'm saying that I'm not > necessarily opposed to enabling it by default. > > But I'd like to some opinion from people who've actually tried it. > > Many Emacs users can have very strong reactions to very small changes in > the default behavior. The potential benefit justifies a bit of > potential annoyance, and I think I can evaluate the potential benefit, > but I don't think I can evaluate the potential annoyance yet. Got it. Seems like a wise approach. Let me know how I can help. -- Cameron Desautels From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 21:49:01 2014 Received: (at 19328) by debbugs.gnu.org; 12 Dec 2014 02:49:01 +0000 Received: from localhost ([127.0.0.1]:43403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzGHs-0006wT-72 for submit@debbugs.gnu.org; Thu, 11 Dec 2014 21:49:00 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:20583) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzGHp-0006wE-Oc for 19328@debbugs.gnu.org; Thu, 11 Dec 2014 21:48:58 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sBC2mogA013156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Dec 2014 02:48:51 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sBC2mm9c002106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 12 Dec 2014 02:48:49 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sBC2mmQs007105; Fri, 12 Dec 2014 02:48:48 GMT MIME-Version: 1.0 Message-ID: Date: Thu, 11 Dec 2014 18:48:48 -0800 (PST) From: Drew Adams To: Stefan Monnier , Cameron Desautels Subject: RE: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations References: <87egs7a5b0.fsf@lifelogs.com> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > What about turning something like this on by default? >=20 > I'm not necessarily opposed to it, but I wonder if it's > sufficiently unintrusive. >=20 > E.g. if you just want to try out a minor mode like global-auto- > revert-mode, IIUC this will set the var and mark it as > "set but unsaved", so when you exit, Emacs will prompt you to > save this setting. >=20 > Maybe it's actually the right thing to do, but I wonder if it will > turn out to be more annoying than useful. And I don't see a good > solution for it. FWIW, in the version of this feature that I use: 1. You are not asked to save the changes. You are asked whether you want to see the changed options (in Customize). If/when you see them, you can quit or save any or all of them first. 2. There are some ways to deal with changes that you don't care about. From the `cus-edit+.el' file header: ;; Dealing with Spurious Changes, 1: Save ;; -------------------------------------- ;; ;; Even if you don't change any preferences yourself, when ;; you quit Emacs the first time you are informed that ;; there are lots of changed preferences, and you are given ;; a chance to save those changes. What are those changes? ;; They represent all of the user preferences that Emacs ;; and various Emacs libraries have changed behind ;; Customize's back - even before you did anything. ;; ;; You'll see user options like `baud-rate' that are set in ;; Emacs C code without informing Customize to mark their ;; settings as `standard' (=3D installed). There shouldn't ;; be any such apparent "changes", since this is part of ;; standard Emacs, but that's the way it is, for now. ;; Customize is still fairly new, and lots of Emacs ;; libraries still define and change user preferences ;; without going through Customize and, in effect, telling ;; it not to consider such preference changes as changes. ;; ;; If you choose to save these preference changes, you will ;; never again be bothered by being informed that they have ;; changed (unless you change them). So, that's one ;; solution to this bother, which makes it a one-time only ;; nuisance: just say "save all". ;; ;; Dealing with Spurious Changes, 2: Ignore ;; ---------------------------------------- ;; ;; Another solution is also possible. Some user ;; preferences, like `case-fold-search' and ;; `debug-on-error' are really the kind of thing that you ;; change often and temporarily - you don't really care ;; about saving their changes, and you certainly don't want ;; to be asked whether or not you want to save them each ;; time you quit Emacs. ;; ;; To deal with that, a list of ignored preferences, ;; `customize-customized-ignore', is defined here. Its ;; preferences (symbols) are not used by ;; `customize-unsaved' at all (you can override that ;; interactively with a prefix arg). So, the other way to ;; deal with the legacy Emacs preferences, besides just ;; saving them in your custom file, is to add them to ;; `customize-customized-ignore' so `customize-unsaved' ;; will ignore them. ;; ;; To make it easy for you to add preferences to this ;; ignore list, `Ignore Unsaved Changes' menu items and ;; buttons have been added. You can choose to ignore ;; specific preferences or all preferences in a Customize ;; buffer - in particular, all preferences in the Customize ;; buffer from `customize-unsaved' (all changed ;; preferences). ;; ;; Dealing with Spurious Changes, 3: Consider Unchanged ;; ---------------------------------------------------- ;; ;; There is also a third way to treat preference changes ;; that you are not responsible for, as an alternative to ;; saving them to your custom file or having Customize ;; always ignore them: tell Customize to consider the ;; current changes as unchanged. This essentially treats ;; them as having been saved, but without saving them. You ;; can do this using the `Consider Unchanged' menu items ;; and buttons added here. ;; ;; For instance, after starting Emacs, you can examine the ;; current preference changes (using `customize-unsaved') ;; from Emacs itself and loaded libraries, and choose ;; `Consider Unchanged' to let Customize know that the ;; current values are to be treated as if they were saved, ;; but without actually saving them to your custom file. ;; That way, your custom file is not polluted with things ;; that you are not really concerned with, yet you are not ;; bothered by seeing such fictitious changes show up each ;; time you check for changes. ;; ;; However, unlike ignoring changes to certain preferences, ;; and really saving current preference values, `Consider ;; Unchanged' is not a persistent change. You can use it ;; at any time to "reset" the change counter for given ;; preferences, so that the current change is considered ;; the new base value (as if it were saved), and any ;; further changes you make to them will show up as ;; changes, using `customize-unsaved'. And note that in my version it is `customize-unsaved' itself that is modified, so the advantageous behavior is available also when that command is used interactively. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 20:16:39 2014 Received: (at 19328) by debbugs.gnu.org; 13 Dec 2014 01:16:39 +0000 Received: from localhost ([127.0.0.1]:44291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzbK3-0003tY-8s for submit@debbugs.gnu.org; Fri, 12 Dec 2014 20:16:39 -0500 Received: from mail-qg0-f51.google.com ([209.85.192.51]:46277) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzbK1-0003tM-4I for 19328@debbugs.gnu.org; Fri, 12 Dec 2014 20:16:37 -0500 Received: by mail-qg0-f51.google.com with SMTP id e89so6360788qgf.10 for <19328@debbugs.gnu.org>; Fri, 12 Dec 2014 17:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=45NBeDF1J0hZy3i96Utmf1lMcBlXNUmm+Eyo1X9z1AM=; b=pCijbDu7zf1l7PY0ePurpVlN9SSDIHyRuEDpXnR5Ju3askmetjr+oPUvy8I+3cEV/c Bk0wuVD8FjE7wnU0fkkvPgYmUPExS/Ri6NFy764/z8WXH3LSnT0+5pighvFaVYY3Cmt5 fvnRTKLQpm5TkphapBhC41KxKG4epewy5W64Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=45NBeDF1J0hZy3i96Utmf1lMcBlXNUmm+Eyo1X9z1AM=; b=WuuFji+1X9zpYG1nk827feBdv4k82yHh5j+8s3QJCMlzxdKhjPdx9/JenrM4GkADdZ 1cK2g0d8zo5smiOUYP1poAaXPf8WBXaj4ciSBOWyDkHR375YtAPkAVWvFc//yhGD0Ykl Nw5RTwbntOBQnJIVrKvCCP6rvLd9XcZ+KcDiH0uRMpUVMYQJUBeZHMCIMwEguZKmk4H8 QPWARHStKemAesbHdVRz9C5D2F+GKBeaT+VvgBlzXmnpJElo2llvZYD+mDfOhZcxTEUW YbXx85cCU3NSdc3TCFOP8C9UtF+k/p2ZKOB2SLAyY5jCLmVhnIyahVf4MCfG0yFLzouT 26KA== X-Gm-Message-State: ALoCoQnkzMKuyOyUegOPjx5jlFk4o/09R7x28JFEDYxY3+ZGY2Z5c+m3j973o32nlfMT4+OSXx5A X-Received: by 10.224.37.67 with SMTP id w3mr36790076qad.88.1418433391745; Fri, 12 Dec 2014 17:16:31 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id e7sm3045460qag.49.2014.12.12.17.16.30 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Dec 2014 17:16:30 -0800 (PST) From: Ted Zlatanov To: Cameron Desautels Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87egs7a5b0.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 12 Dec 2014 20:17:26 -0500 In-Reply-To: (Cameron Desautels's message of "Thu, 11 Dec 2014 20:39:39 -0600") Message-ID: <87d27o1h7d.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, 11 Dec 2014 20:39:39 -0600 Cameron Desautels wrote: CD> On Thu, Dec 11, 2014 at 8:36 PM, Stefan Monnier CD> wrote: >> Oh yes, I'm quite aware of this problem, which is why I think this >> feature is very nice and that's also why I'm saying that I'm not >> necessarily opposed to enabling it by default. >> >> But I'd like to some opinion from people who've actually tried it. >> >> Many Emacs users can have very strong reactions to very small changes in >> the default behavior. The potential benefit justifies a bit of >> potential annoyance, and I think I can evaluate the potential benefit, >> but I don't think I can evaluate the potential annoyance yet. CD> Got it. Seems like a wise approach. Let me know how I can help. To make it easier for people to try it, and to format the patch a little better, I've pushed it on top of the current master branch in the branch scratch/bug19328/custom-prompt-customize-unsaved-options from where it can be tried or cherry-picked. Ted From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 13 00:55:20 2014 Received: (at 19328) by debbugs.gnu.org; 13 Dec 2014 05:55:20 +0000 Received: from localhost ([127.0.0.1]:44355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xzffj-0002T7-3d for submit@debbugs.gnu.org; Sat, 13 Dec 2014 00:55:19 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39750) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xzffe-0002Sq-Hv for 19328@debbugs.gnu.org; Sat, 13 Dec 2014 00:55:15 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCwsOJhIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGSMYM4jkWBeIQZIYJ3AQEB X-IPAS-Result: AjwPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViMFCwsOJhIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGSMYM4jkWBeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="100450788" Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Dec 2014 00:55:08 -0500 Received: by pastel.home (Postfix, from userid 20848) id 7D90A1237; Sat, 13 Dec 2014 00:55:08 -0500 (EST) From: Stefan Monnier To: Cameron Desautels Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Message-ID: References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> Date: Sat, 13 Dec 2014 00:55:08 -0500 In-Reply-To: <87d27o1h7d.fsf@lifelogs.com> (Ted Zlatanov's message of "Fri, 12 Dec 2014 20:17:26 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > To make it easier for people to try it, and to format the patch a little > better, I've pushed it on top of the current master branch in the branch > scratch/bug19328/custom-prompt-customize-unsaved-options from where it > can be tried or cherry-picked. No! Please install it into master. This part is not under debate. The only debate is whether to enable it by default. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 13 08:05:45 2014 Received: (at 19328) by debbugs.gnu.org; 13 Dec 2014 13:05:45 +0000 Received: from localhost ([127.0.0.1]:44425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzmOH-0005xF-3L for submit@debbugs.gnu.org; Sat, 13 Dec 2014 08:05:45 -0500 Received: from mail-qa0-f47.google.com ([209.85.216.47]:44161) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzmOE-0005x1-6d for 19328@debbugs.gnu.org; Sat, 13 Dec 2014 08:05:42 -0500 Received: by mail-qa0-f47.google.com with SMTP id s7so6325331qap.34 for <19328@debbugs.gnu.org>; Sat, 13 Dec 2014 05:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=lLNwEJXGF5mkcfatoz/k+fVlMhDUQQEoE8byGe1fpCY=; b=GFYDtP5YUUgW+3jcoh+zIjTfMxDQCZakDY1DpqkIhZ6WuLor3/lvZ3OHmX+IULpn7s NezlkpZbfq74pUREnhu/AxqmT/goikyWJLlyguZNbociEHYzmvqeUlScjV6D0gfrQVvW DrsxqgY9PmMNuvO3RaO9DpqNBCqIxcvqlC7Sg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=lLNwEJXGF5mkcfatoz/k+fVlMhDUQQEoE8byGe1fpCY=; b=eqtLiOA7Hb2aQWK+ZJPU0L0lWh4N6ognaT6cQhr4I6b+8UtdfAKha6wU+y376Y624b YsNQpdVN3tBfOW115GcLiN+xfECWKVODkUuQd1UDUtlIWg3A1zjSIubwtFotjk8P34qb uz5tpBBPElPl2u4jmIef94+vhrUNpO3uCvDmO+fLHXFUzz9lPGIo/CKXrOi46ouNcUIy YCaZqtUBDQOJYdDZgXxg9Y0yoKU47vA+F7hMqPz3JfIhU423tj60+Bp5upBczL37dbjw iPdfcWpoVCZKi4Fk+qvN5PqBkrroBeni3wRy0tNYeVySFu3QCXhhyTB1r4CHclzFtV9z Cnug== X-Gm-Message-State: ALoCoQlIBTS3CWasHf6CG8mWS+OLRCpuWqBszjyrb3uoUs10AtOTVFCAa+blrLkte87z4A6zYD2t X-Received: by 10.140.84.70 with SMTP id k64mr11173378qgd.76.1418475936510; Sat, 13 Dec 2014 05:05:36 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id e45sm4395071qgd.35.2014.12.13.05.05.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Dec 2014 05:05:35 -0800 (PST) From: Ted Zlatanov To: Stefan Monnier Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Sat, 13 Dec 2014 08:06:32 -0500 In-Reply-To: (Stefan Monnier's message of "Sat, 13 Dec 2014 00:55:08 -0500") Message-ID: <874msz1yxz.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Cameron Desautels X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, 13 Dec 2014 00:55:08 -0500 Stefan Monnier wrote: >> To make it easier for people to try it, and to format the patch a little >> better, I've pushed it on top of the current master branch in the branch >> scratch/bug19328/custom-prompt-customize-unsaved-options from where it >> can be tried or cherry-picked. SM> No! Please install it into master. SM> This part is not under debate. The only debate is whether to enable it SM> by default. Could you review the commit first? I wasn't sure about the commit message, since it's one commit for several scattered ChangeLogs (and those ChangeLog deltas are not in the commit message details). I think it's reasonable but didn't want to presume. Ted From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 13 18:23:50 2014 Received: (at 19328) by debbugs.gnu.org; 13 Dec 2014 23:23:50 +0000 Received: from localhost ([127.0.0.1]:45090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xzw2Q-0008DH-A0 for submit@debbugs.gnu.org; Sat, 13 Dec 2014 18:23:50 -0500 Received: from mail-ie0-f170.google.com ([209.85.223.170]:43102) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xzw2P-0008D6-2P for 19328@debbugs.gnu.org; Sat, 13 Dec 2014 18:23:49 -0500 Received: by mail-ie0-f170.google.com with SMTP id rd18so9019670iec.1 for <19328@debbugs.gnu.org>; Sat, 13 Dec 2014 15:23:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MMpuQXZiXf4m6XSoWDNG4IaT/7Em5mUYSnbMVnZzHwE=; b=qAHt8aEDEP8FPJ3elQoxBmrZkDFXjUjC+yWO8i1m5aJBF2GOYmT3Jxh8zAKVHIrqv7 zrNABla0BgeQxiyqVZ1XKBfrrvJR2cA39ySf2MOMIPbWGoFHaYleHS5moTGZxiVUAuuL +zHOcMAqTlOmc9SdffBb5OYg2JY389/YQTLozq2wjhndyadS7T9Mx0YdQ9YOKmNuNebu NfZMD5detSpQ8e+4i2pHcqRx1/S0OD5iwKPg+ckXTbyMgwiLP4Qty5UCgcFEG9juQ/hw Np9UBm9tL0rLv2lvJEGlz+rvCsB6TGpUGvDjeXpTD5yXq9b6UsplT2t8ejI1yR97EA77 MTnQ== MIME-Version: 1.0 X-Received: by 10.107.15.73 with SMTP id x70mr22003064ioi.8.1418513023279; Sat, 13 Dec 2014 15:23:43 -0800 (PST) Received: by 10.107.43.8 with HTTP; Sat, 13 Dec 2014 15:23:43 -0800 (PST) In-Reply-To: <874msz1yxz.fsf@lifelogs.com> References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> <874msz1yxz.fsf@lifelogs.com> Date: Sat, 13 Dec 2014 17:23:43 -0600 Message-ID: Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations From: Cameron Desautels To: Ted Zlatanov Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ted: thanks for adding the additional ChangeLog entries--I didn't realize just how many ChangeLog files there are. FWIW the patch looks good to me. -- Cameron Desautels On Sat, Dec 13, 2014 at 7:06 AM, Ted Zlatanov wrote: > On Sat, 13 Dec 2014 00:55:08 -0500 Stefan Monnier wrote: > >>> To make it easier for people to try it, and to format the patch a little >>> better, I've pushed it on top of the current master branch in the branch >>> scratch/bug19328/custom-prompt-customize-unsaved-options from where it >>> can be tried or cherry-picked. > > SM> No! Please install it into master. > SM> This part is not under debate. The only debate is whether to enable it > SM> by default. > > Could you review the commit first? I wasn't sure about the commit > message, since it's one commit for several scattered ChangeLogs (and > those ChangeLog deltas are not in the commit message details). I think > it's reasonable but didn't want to presume. > > Ted From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 14 06:53:31 2014 Received: (at 19328) by debbugs.gnu.org; 14 Dec 2014 11:53:31 +0000 Received: from localhost ([127.0.0.1]:45279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y07jv-0001FL-46 for submit@debbugs.gnu.org; Sun, 14 Dec 2014 06:53:31 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:65482) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y07jt-0001F6-7w for 19328@debbugs.gnu.org; Sun, 14 Dec 2014 06:53:29 -0500 Received: by mail-qa0-f54.google.com with SMTP id i13so7138774qae.27 for <19328@debbugs.gnu.org>; Sun, 14 Dec 2014 03:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=3hgHSYN8p3Ld8NhIAe3Kdloxz4nUfG/w1g1QHEOXErE=; b=ZPf50402/bHG4io0B9FfUbfs3539xh3n0ANb9+t1NzYBb2UX6qshvVnL2Yevp3scgI yVpNJKf2cUdXo74aNhsxcBv0BMpbKnQ1Qmp+JVyIQGYt/asDP8QIcYrIjJ5Mwz25xWsH QqXjnazNXbpSuZtUVgDhlcBCYxnreuEDcQxDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=3hgHSYN8p3Ld8NhIAe3Kdloxz4nUfG/w1g1QHEOXErE=; b=Ao5HFiwC1jcT/zI4aSpch8AQu430kg0TW+Qoj5bUz4Q2bHCReh1sFKMPBGCoweiMOs hu/r2U2XDGXxS+PVLIsHQqfMsaIENvrJXyh6rd2XEP8Q9Yf266RXYrGqfnAZBvFLIhUD pcqFDlszJUjqQHJhpVlaaXShosMvnv5ue46sUZ6r/yrJva2Hu1BzEbjE/uATuB3NFthD 4u+8V9EcUlrBYG4wm6paFufxAb9ekEL7fRXbbbXuq0NWszu0jBB/tJ+G4fDIcVt3+XfF xIz4giumfNG7wKnysk7jAmkFTZ8K4Lz1lyDEvBzg6re6YhIYCIK6nt30xyq+e28kvyMw Jeww== X-Gm-Message-State: ALoCoQkFY8zuCghlj/eXmbAghpXZwMqQ9vgJU+QlbKmQtAyAN/46rsCDxoCAgPtPK0BKfU86vWyk X-Received: by 10.224.25.146 with SMTP id z18mr47474102qab.17.1418558003705; Sun, 14 Dec 2014 03:53:23 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id v16sm7230607qaw.30.2014.12.14.03.53.22 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 14 Dec 2014 03:53:23 -0800 (PST) From: Ted Zlatanov To: Stefan Monnier , Glenn Morris Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> <874msz1yxz.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Sun, 14 Dec 2014 06:54:20 -0500 In-Reply-To: <874msz1yxz.fsf@lifelogs.com> (Ted Zlatanov's message of "Sat, 13 Dec 2014 08:06:32 -0500") Message-ID: <8761dezbtf.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Cameron Desautels X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, 13 Dec 2014 08:06:32 -0500 Ted Zlatanov wrote: TZ> On Sat, 13 Dec 2014 00:55:08 -0500 Stefan Monnier wrote: >>> To make it easier for people to try it, and to format the patch a little >>> better, I've pushed it on top of the current master branch in the branch >>> scratch/bug19328/custom-prompt-customize-unsaved-options from where it >>> can be tried or cherry-picked. SM> No! Please install it into master. SM> This part is not under debate. The only debate is whether to enable it SM> by default. TZ> Could you review the commit first? I wasn't sure about the commit TZ> message, since it's one commit for several scattered ChangeLogs (and TZ> those ChangeLog deltas are not in the commit message details). I think TZ> it's reasonable but didn't want to presume. ...I see for example the commit 49daed60510a073062b41fa39fd7c010cb0a315e from Glenn has a nice summary of all the changes in subdirectories gathered from various ChangeLogs, but `C-c C-a' in the commit window doesn't bring in anything near that summary. Is there a way to auto-generate it or do I have to assemble it by hand? I created the top-level commit message by hand for now, in scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 and then merged it, so the discussion about enabling this feature by default can continue (I'm not marking the bug "done")... Ted From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 14 09:04:30 2014 Received: (at 19328) by debbugs.gnu.org; 14 Dec 2014 14:04:30 +0000 Received: from localhost ([127.0.0.1]:45374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y09mg-00004q-Go for submit@debbugs.gnu.org; Sun, 14 Dec 2014 09:04:30 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:22255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y09md-0008WJ-Qs for 19328@debbugs.gnu.org; Sun, 14 Dec 2014 09:04:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjsPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQRWIxALDiYSFBgNJIhT1lkBAQEBBgEBAQEekG8HhEgFiwGkLoF4hBkhgncBAQE X-IPAS-Result: AjsPAOwQflTO+ILA/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQRWIxALDiYSFBgNJIhT1lkBAQEBBgEBAQEekG8HhEgFiwGkLoF4hBkhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="101334050" Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Dec 2014 09:04:21 -0500 Received: by pastel.home (Postfix, from userid 20848) id 54DA61F6D; Sun, 14 Dec 2014 09:02:48 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Message-ID: References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> <874msz1yxz.fsf@lifelogs.com> <8761dezbtf.fsf@lifelogs.com> Date: Sun, 14 Dec 2014 09:02:48 -0500 In-Reply-To: <8761dezbtf.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 14 Dec 2014 06:54:20 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Cameron Desautels X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > ...I see for example the commit 49daed60510a073062b41fa39fd7c010cb0a315e > from Glenn has a nice summary of all the changes in subdirectories > gathered from various ChangeLogs, but `C-c C-a' in the commit window > doesn't bring in anything near that summary. Is there a way to > auto-generate it or do I have to assemble it by hand? Yes: from the *vc-dir* buffer, you need to explicitly select every file you'll commit (instead of just saying "commit everything in this directory"). Then C-c C-a will work. It's stupid but it's the way to code works. Patches welcome. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 14 11:30:19 2014 Received: (at 19328) by debbugs.gnu.org; 14 Dec 2014 16:30:19 +0000 Received: from localhost ([127.0.0.1]:46223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0C3m-0005fK-UY for submit@debbugs.gnu.org; Sun, 14 Dec 2014 11:30:19 -0500 Received: from mail-qc0-f171.google.com ([209.85.216.171]:46403) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0C3k-0005f4-R1 for 19328@debbugs.gnu.org; Sun, 14 Dec 2014 11:30:17 -0500 Received: by mail-qc0-f171.google.com with SMTP id r5so7785935qcx.30 for <19328@debbugs.gnu.org>; Sun, 14 Dec 2014 08:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=YHt0I2AerXgzhSrIJPtHqG7Ja4US3IoIABRQF5t2dhY=; b=vu0GSQnCFbvXAgCU4XvvXTcK0kqZnDX+51jY0nHzGaTciOCzRTQB8P+vzMQgTrEbVW gPnTWkYNOZulz4wrHU/710/TUAuLv7Fixj2V/7sG4mTWYFiS1svmrAW5vBAmsGjX/RXF hB3Lu9sqp3CH/cHJk7JcPLuWRsUxo1DCYfLpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=YHt0I2AerXgzhSrIJPtHqG7Ja4US3IoIABRQF5t2dhY=; b=ZSu3FrOzTtBAs7iw5EcaesdZbA4o6fHjBbcSQ8/R8Dj9AyTgN8gakXdmOqafXi7AdX dIPtRLyiXNKB0ZKq1somZTLAG/KijKUlHxskmRSf+OAgh9C8VLYqwN7Od3a6R2I+3ymv XN3vUTnjaNur3AqgPfcCnCah3fPkOE4lIqcO01Mrn1KeHBN/WMxV4BykzVnFBB+N2JFs XDFZ/HrsMDPx9mXNDfQAP7bM2DoCJXMAPg+pWVHw72YkrwuH5zX1tvf1S6UfhiE25goz j6HRBYmOO8zvMBSKkpa9OL4UBxAjc7afre2KtN18774DhdRfBbXXgc4SLoXc3zJNN/oQ kWEA== X-Gm-Message-State: ALoCoQkxQih+eZprwOFCcgCEJ65bj9sWba4I15J+gDlhbM3mrH+G/YX3lF+dcgmE0VmYb7crTq9+ X-Received: by 10.229.97.73 with SMTP id k9mr48980297qcn.15.1418574611243; Sun, 14 Dec 2014 08:30:11 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id u64sm7765409qgd.46.2014.12.14.08.30.10 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 14 Dec 2014 08:30:10 -0800 (PST) From: Ted Zlatanov To: Stefan Monnier Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> <874msz1yxz.fsf@lifelogs.com> <8761dezbtf.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Sun, 14 Dec 2014 11:31:08 -0500 In-Reply-To: (Stefan Monnier's message of "Sun, 14 Dec 2014 09:02:48 -0500") Message-ID: <87y4qaxkfn.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Glenn Morris , Cameron Desautels X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 14 Dec 2014 09:02:48 -0500 Stefan Monnier wrote: >> ...I see for example the commit 49daed60510a073062b41fa39fd7c010cb0a315e >> from Glenn has a nice summary of all the changes in subdirectories >> gathered from various ChangeLogs, but `C-c C-a' in the commit window >> doesn't bring in anything near that summary. Is there a way to >> auto-generate it or do I have to assemble it by hand? SM> Yes: from the *vc-dir* buffer, you need to explicitly select every file SM> you'll commit (instead of just saying "commit everything in this SM> directory"). Then C-c C-a will work. It's stupid but it's the way to SM> code works. Patches welcome. Oh, huh, yeah that's kind of strange. I'd expect it to work when nothing is selected. I'll try to hack it, some time this century :) Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 06:37:22 2016 Received: (at 19328) by debbugs.gnu.org; 23 Feb 2016 11:37:22 +0000 Received: from localhost ([127.0.0.1]:39347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBHN-0005NL-Tx for submit@debbugs.gnu.org; Tue, 23 Feb 2016 06:37:22 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:42974) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBHM-0005ND-Dj for 19328@debbugs.gnu.org; Tue, 23 Feb 2016 06:37:20 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYBGx-000575-Ln; Tue, 23 Feb 2016 12:36:56 +0100 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations References: <87egs7a5b0.fsf@lifelogs.com> <87d27o1h7d.fsf@lifelogs.com> Date: Tue, 23 Feb 2016 22:36:46 +1100 In-Reply-To: (Stefan Monnier's message of "Sat, 13 Dec 2014 00:55:08 -0500") Message-ID: <8737sjr73l.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYBGx-000575-Ln X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456832216.46607@1eSYX+v72snlFvqu+4rb+w X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19328 Cc: 19328@debbugs.gnu.org, Cameron Desautels X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> To make it easier for people to try it, and to format the patch a little >> better, I've pushed it on top of the current master branch in the branch >> scratch/bug19328/custom-prompt-customize-unsaved-options from where it >> can be tried or cherry-picked. > > No! Please install it into master. > This part is not under debate. The only debate is whether to enable it > by default. It looks like the patch was committed, and presumably any debate that was going to happen has happened, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 06:37:33 2016 Received: (at control) by debbugs.gnu.org; 23 Feb 2016 11:37:33 +0000 Received: from localhost ([127.0.0.1]:39350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBHZ-0005Nl-4z for submit@debbugs.gnu.org; Tue, 23 Feb 2016 06:37:33 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:42985) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBHX-0005Nb-DA for control@debbugs.gnu.org; Tue, 23 Feb 2016 06:37:31 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYBH7-00057M-Tm for control@debbugs.gnu.org; Tue, 23 Feb 2016 12:37:06 +0100 Date: Tue, 23 Feb 2016 22:37:01 +1100 Message-Id: <871t83r736.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19328 X-MailScanner-ID: 1aYBH7-00057M-Tm X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456832226.92712@PiXQ2+4PyGMHVf8stakMbA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 19328 fixed close 19328 From unknown Tue Jun 24 17:28:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Mar 2016 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator