GNU bug report logs - #19327
24.4.51; Wrong advice class reported

Previous Next

Package: emacs;

Reported by: Ivan Andrus <darthandrus <at> gmail.com>

Date: Tue, 9 Dec 2014 15:46:02 UTC

Severity: normal

Tags: notabug

Found in version 24.4.51

Fixed in version 25.1

Done: Ivan Andrus <darthandrus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19327 in the body.
You can then email your comments to 19327 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#19327; Package emacs. (Tue, 09 Dec 2014 15:46:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ivan Andrus <darthandrus <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 09 Dec 2014 15:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Andrus <darthandrus <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.51; Wrong advice class reported
Date: Tue, 9 Dec 2014 08:44:51 -0700
[Message part 1 (text/plain, inline)]
Starting from emacs -Q, evaluate the following:

(defadvice save-buffers-kill-emacs
    (before allow-elnode-to-die-when-quitting activate)
  (set-process-query-on-exit-flag
   (cdr-safe (assoc 8314 elnode-server-socket)) nil))

Then C-h f save-buffers-kill-emacs RET.  The results I get have the
following line:

    :around advice: `ad-Advice-save-buffers-kill-emacs'

Notice that the advice was defined as before advice (and errors if
`ad-do-it' is used), but is reported as :around advice.

-Ivan


Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Undo!
Quit
save-buffers-kill-emacs
<C-tab> is undefined [2 times]

s-\ is undefined
toggle-input-method: Recursive use of `toggle-input-method'
Quit
Undo!
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils help-mode easymenu advice help-fns time-date
tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list
newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp
files text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
cocoa ns multi-tty emacs)

Memory information:
((conses 16 74709 7163)
(symbols 48 18001 0)
(miscs 40 57 299)
(strings 32 10711 4417)
(string-bytes 1 288430)
(vectors 16 9505)
(vector-slots 8 387032 7040)
(floats 8 57 405)
(intervals 56 278 24)
(buffers 960 13))
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19327; Package emacs. (Wed, 10 Dec 2014 00:31:01 GMT) Full text and rfc822 format available.

Message #8 received at 19327 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ivan Andrus <darthandrus <at> gmail.com>
Cc: 19327 <at> debbugs.gnu.org
Subject: Re: bug#19327: 24.4.51; Wrong advice class reported
Date: Tue, 09 Dec 2014 19:30:00 -0500
tags 19327 notabug
thanks

> (defadvice save-buffers-kill-emacs
>     (before allow-elnode-to-die-when-quitting activate)
[...]
> Then C-h f save-buffers-kill-emacs RET.  The results I get have the
> following line:

>     :around advice: `ad-Advice-save-buffers-kill-emacs'

It doesn't talk about your `allow-elnode-to-die-when-quitting' advice.
Instead it talks about a general advice used to implement the interface
between old-style advice and new-style advice.  If you click on that
link it should give you the information about your particular advice.


        Stefan




Added tag(s) notabug. Request was from Stefan Monnier <monnier <at> iro.umontreal.ca> to control <at> debbugs.gnu.org. (Wed, 10 Dec 2014 00:31:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19327; Package emacs. (Tue, 27 Oct 2015 21:41:01 GMT) Full text and rfc822 format available.

Message #13 received at 19327 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Andrus <darthandrus <at> gmail.com>
To: "bug#19327" <19327 <at> debbugs.gnu.org>, control <at> debbugs.gnu.org
Subject: Mark at #19327 as done since it's not a bug
Date: Tue, 27 Oct 2015 15:40:15 -0600
tag 19327 done
thanks




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19327; Package emacs. (Tue, 27 Oct 2015 21:47:02 GMT) Full text and rfc822 format available.

Message #16 received at 19327 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Andrus <darthandrus <at> gmail.com>
To: "bug#19327" <19327 <at> debbugs.gnu.org>, control <at> debbugs.gnu.org
Subject: Re: Mark at #19327 as done since it's not a bug
Date: Tue, 27 Oct 2015 15:45:51 -0600
close 19327 25.1
thanks




bug marked as fixed in version 25.1, send any further explanations to 19327 <at> debbugs.gnu.org and Ivan Andrus <darthandrus <at> gmail.com> Request was from Ivan Andrus <darthandrus <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 27 Oct 2015 21:47:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 25 Nov 2015 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 213 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.