GNU bug report logs - #19325
file-tree-walk needs to be replaced/removed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19325 in the body.
You can then email your comments to 19325 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 00:24:02 -0500

Package: emacs
Severity: important
Version: 25.0.50

Filing a bug so that this does not get overlooked.
file-tree-walk needs to be removed/replaced.
Ref: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00306.html

Message #6 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 13:40:37 +0800

On 2014-12-09 00:24 -0500, Glenn Morris wrote:
> Filing a bug so that this does not get overlooked.
> file-tree-walk needs to be removed/replaced.
> Ref: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00306.html

Personally I think a better option is to allow directory-files to take a
function as its MATCH argument. Then the tree walk is only a step away.

Leo

Message #9 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 06:47:40 +0100

Leo Liu <sdl.web <at> gmail.com> writes:

> Personally I think a better option is to allow directory-files to take a
> function as its MATCH argument. Then the tree walk is only a step away.

directory-files doesn't work recursively.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #12 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 07:23:11 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> Filing a bug so that this does not get overlooked.
> file-tree-walk needs to be removed/replaced.
> Ref: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00306.html

I've now committed the more generally useful
`directory-files-recursively', which has a saner interface.
`file-tree-walk' can be implemented as

(mapcar 'function (directory-files-recursively ...)) if you want, but it
seems kinda superfluous.

`directory-files-recursively' also returns full names instead of the
directory/leaf name nonsense.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 01:38:10 -0500

Lars Magne Ingebrigtsen wrote:

> `file-tree-walk' can be implemented as
>
> (mapcar 'function (directory-files-recursively ...)) if you want, but it
> seems kinda superfluous.

Oh, nothing actually uses f-t-w?

Then if no-one objects feel free to nuke it, I think. (And the NEWS and doc.)
Thanks!

Message #18 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 07:44:57 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> Lars Magne Ingebrigtsen wrote:
>
>> `file-tree-walk' can be implemented as
>>
>> (mapcar 'function (directory-files-recursively ...)) if you want, but it
>> seems kinda superfluous.
>
> Oh, nothing actually uses f-t-w?

I haven't actually looked, but I mean that what it does is so trivial
that it's not worth having as a separate function.

People should just mapc over `directory-files-recursively'.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Tue, 09 Dec 2014 07:52:31 +0100

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> I haven't actually looked, but I mean that what it does is so trivial
> that it's not worth having as a separate function.

It's not used, and there's already a `vc-file-tree-walk' that does a
similar thing, but with a less moronic interface.  Only over vc-covered
files, though.

I say nuke `file-tree-walk'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Wed, 10 Dec 2014 14:55:53 -0500

> `directory-files-recursively' also returns full names instead of the
> directory/leaf name nonsense.

I'm not so sure it's non-sense.  I think both options have their
respective advantages/disadvantages.


        Stefan

Message #27 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Fri, 02 Jan 2015 14:32:06 -0500

Several weeks have passed.
Since the code is unassigned and unused, the solution seems obvious to me.

Message #30 received at 19325 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 19325 <at> debbugs.gnu.org
Subject: Re: bug#19325: file-tree-walk needs to be replaced/removed
Date: Fri, 02 Jan 2015 22:22:13 -0500

> Several weeks have passed.
> Since the code is unassigned and unused, the solution seems obvious to me.

Yup,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.