From unknown Fri Jun 20 20:00:50 2025 X-Loop: don@donarmstrong.com Subject: bug#193: Fill for // (C++) style comments in C (C99) Reply-To: Richard Hansen , 193@debbugs.gnu.org Resent-From: Richard Hansen Original-Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 06 May 2008 23:30:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 193 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.121011621913392 (code B ref -1); Tue, 06 May 2008 23:30:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 6 May 2008 23:23:39 +0000 Received: from mercure.iro.umontreal.ca (mercure.iro.umontreal.ca [132.204.24.67]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m46NNZnj013386 for ; Tue, 6 May 2008 16:23:37 -0700 Received: by mercure.iro.umontreal.ca (Postfix, from userid 20848) id 4F2882CFCA8; Tue, 6 May 2008 19:23:35 -0400 (EDT) X-Original-To: monnier@iro.umontreal.ca Received: from pinpin.iro.umontreal.ca (pinpin.iro.umontreal.ca [132.204.24.52]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 301032CFA64 for ; Tue, 6 May 2008 19:23:35 -0400 (EDT) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by pinpin.iro.umontreal.ca (Postfix) with ESMTP id 1371F3B8B43 for ; Tue, 6 May 2008 19:23:28 -0400 (EDT) Received: from localhost ([127.0.0.1]:36953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtWVL-0003Ak-J8 for monnier@iro.umontreal.ca; Tue, 06 May 2008 19:23:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtV2E-0001Q0-L2 for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtV2D-0001Pd-20 for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:18 -0400 Received: from [199.232.76.173] (port=39345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtV2C-0001Pa-Ul for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:16 -0400 Received: from mx11.bbn.com ([128.33.0.80]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtV2C-0003GL-Of for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:16 -0400 Received: from deer.bbn.com ([128.89.80.92]) by mx11.bbn.com with esmtp (Exim 4.60) (envelope-from ) id 1JtV29-0000xn-4e for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:13 -0400 Message-ID: <4820D259.2060805@bbn.com> Date: Tue, 06 May 2008 17:49:13 -0400 From: Richard Hansen User-Agent: Thunderbird 2.0.0.12 (X11/20080227) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Tue, 06 May 2008 19:23:18 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.94, requis 5, BAYES_00 -2.60, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org It appears that filling C++-style comments inside C99 code via c-fill-paragraph is still broken. This bug was previously reported[1] in November 2006 and was extensively discussed, but it looks like no fix was ever committed. [1] http://lists.gnu.org/archive/html/emacs-devel/2006-11/msg00868.html -Richard From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 29 14:06:48 2010 Received: (at control) by debbugs.gnu.org; 29 Jan 2010 19:06:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NawB6-0006Th-CT for submit@debbugs.gnu.org; Fri, 29 Jan 2010 14:06:48 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NawB3-0006TR-9S for control@debbugs.gnu.org; Fri, 29 Jan 2010 14:06:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NawAz-0008CX-1L; Fri, 29 Jan 2010 14:06:41 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19299.12736.832508.282592@fencepost.gnu.org> Date: Fri, 29 Jan 2010 14:06:40 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: blue X-Ran: VO&ud[`?6f;MPwH!mdZU0Da5EQb;q|^:M@[G'\N`mS1c#>^/W4D}F4Lh'i,;0o1zMzi=T& X-Debbugs-No-Ack: yes X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) noowner 644 noowner 193 noowner 341 noowner 523 noowner 299 noowner 50 unarchive 113 noowner 113 reassign 113 emacs,cc-mode unarchive 512 noowner 512 unarchive 13 noowner 13 reassign 13 emacs,cc-mode unarchive 17 unmerge 17 noowner 16 unarchive 343 noowner 343 reassign 343 emacs,cc-mode unarchive 145 noowner 145 unarchive 45 noowner 45 unarchive 53 noowner 53 From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: References: <4820D259.2060805@bbn.com> In-Reply-To: <4820D259.2060805@bbn.com> Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 27 Jun 2010 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: 193@debbugs.gnu.org Received: via spool by 193-submit@debbugs.gnu.org id=B193.127764291115113 (code B ref 193); Sun, 27 Jun 2010 12:49:02 +0000 Received: (at 193) by debbugs.gnu.org; 27 Jun 2010 12:48:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSrHi-0003vi-C8 for submit@debbugs.gnu.org; Sun, 27 Jun 2010 08:48:30 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSrHg-0003vb-67 for 193@debbugs.gnu.org; Sun, 27 Jun 2010 08:48:28 -0400 Received: by fxm1 with SMTP id 1so98355fxm.3 for <193@debbugs.gnu.org>; Sun, 27 Jun 2010 05:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=6+jNN+pnNKgOdtCPhzS/xNLFb1wSLy41BMK/PpI5mFw=; b=sGK03gWpO9K3191etH1O5J9GBIi46JAIYsNbtB1N43DiUn2x6Apg1oWqS6OeFpooCX nX7Emseg3tnJ4adYb2gTM5OhcLWYEWnxzbf8aG8UhwYDBbaXmw9OJMMzUkFwOgRQR26M YkEwcGKj1Dyau5suR7tepBF65iLlHshqOOIDE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=VM/U146JJSGS8fvP8mlntXtIgSLcgRvCPUEtVsIzARmMsEDQy1UHI/yddZAq+FsEEm WmzwUmZ+MKLhjzjs78BjzLJ3DM6jbBCDATKdG2Ky+1TE9TatgRX9wpUSZIkGMoRcWvrC +YCEuO65+Vq8Rk9uAR+6zb0P9A3zUUzD9lbgk= Received: by 10.239.186.195 with SMTP id i3mr237167hbh.33.1277642902312; Sun, 27 Jun 2010 05:48:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.239.135.207 with HTTP; Sun, 27 Jun 2010 05:47:52 -0700 (PDT) From: Deniz Dogan Date: Sun, 27 Jun 2010 14:47:52 +0200 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.8 (/) Did anyone ever agree on what needs to be done to fix the problem? -- Deniz Dogan From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Mon, 05 Jul 2010 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Deniz Dogan Cc: bug-cc-mode@gnu.org, 193@debbugs.gnu.org Received: via spool by 193-submit@debbugs.gnu.org id=B193.127835976225486 (code B ref 193); Mon, 05 Jul 2010 19:57:02 +0000 Received: (at 193) by debbugs.gnu.org; 5 Jul 2010 19:56:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVrlq-0006d1-AK for submit@debbugs.gnu.org; Mon, 05 Jul 2010 15:56:02 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVrlm-0006cq-Qc for 193@debbugs.gnu.org; Mon, 05 Jul 2010 15:56:00 -0400 Received: (qmail 51604 invoked by uid 3782); 5 Jul 2010 19:55:53 -0000 Received: from acm.muc.de (pD9E23A7D.dip.t-dialin.net [217.226.58.125]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Mon, 05 Jul 2010 21:55:52 +0200 Received: (qmail 1733 invoked by uid 1000); 5 Jul 2010 20:06:30 -0000 Date: Mon, 5 Jul 2010 20:06:30 +0000 Message-ID: <20100705200629.GA1650@muc.de> References: <4820D259.2060805@bbn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Hi, Deniz, On Sun, Jun 27, 2010 at 02:47:52PM +0200, Deniz Dogan wrote: > Did anyone ever agree on what needs to be done to fix the problem? Er, it basically needs me to get out of bed and fix it. It seems to be one of these strange bugs where lots of people talked vaguely around a problem and it took 3 or 4 rounds of chat before anybody formulated a reproducible recipe. For some reason I missed it, and you're the first person to repost the bug (even if a little vagely ;-) onto bug-cc-mode. So, yes, I'll get around to fixing it with some celerity. Promise! > -- > Deniz Dogan -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Tue, 06 Jul 2010 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Deniz Dogan Cc: 193@debbugs.gnu.org, Stefan Monnier , emacs-devel@gnu.org Received: via spool by 193-submit@debbugs.gnu.org id=B193.127844394412082 (code B ref 193); Tue, 06 Jul 2010 19:20:02 +0000 Received: (at 193) by debbugs.gnu.org; 6 Jul 2010 19:19:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWDfc-00038p-HP for submit@debbugs.gnu.org; Tue, 06 Jul 2010 15:19:04 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWDfa-00038T-Ch for 193@debbugs.gnu.org; Tue, 06 Jul 2010 15:19:03 -0400 Received: (qmail 38923 invoked by uid 3782); 6 Jul 2010 19:18:57 -0000 Received: from acm.muc.de (pD9E518D3.dip.t-dialin.net [217.229.24.211]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Tue, 06 Jul 2010 21:18:55 +0200 Received: (qmail 4336 invoked by uid 1000); 6 Jul 2010 19:29:34 -0000 Date: Tue, 6 Jul 2010 19:29:34 +0000 Message-ID: <20100706192934.GA3741@muc.de> References: <4820D259.2060805@bbn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) On Sun, Jun 27, 2010 at 02:47:52PM +0200, Deniz Dogan wrote: > Did anyone ever agree on what needs to be done to fix the problem? A quick reminder of what the problem is. In C mode (NOT C++ mode): (i) Type M-q in a pair of short line comments like this // Two short // lines. The command ought to join them into a single line comment. Instead, it does nothing; (ii) Type M-q in a line comment which is longer than fill-column: // A long line comment, which is far far far longer than a moderately or very small fill-column. This miss-fills by splitting the line, but putting no comment marker on the new second line:. // A long line comment, which is far far far longer than a moderately or very small fill-column. These bugs are regressions between Emacs 21.4 and 22.1. ######################################################################### Both these bugs seem to be caused by a strange clause in `fill-paragraph', where what should be the fill-prefix ("// ") is made a component of `paragraph-start'. Thus (ii) every line in the comment sequence is automatically made into its own paragraph; and (i) when splitting lines, fill-paragraph doesn't insert the fill-prefix when this is also a paragraph starter. Here is the strange code: ;; Try to prevent code sections and comment sections from being ;; filled together. (when (and fill-paragraph-handle-comment comment-start-skip) (setq paragraph-start (concat paragraph-start "\\|[ \t]*\\(?:" comment-start-skip "\\)"))) In C Mode, `comment-start-skip' is "\\(//+\\|/\\*+\\)\\s *". The two bugs vanish when the above code is removed. Stefan, can you remember why you put this code in (revision 86672 of 2008-04-11)? Is there perhaps a way of achieving the same effect without making the fill-prefix match `paragraph-start'? > -- > Deniz Dogan -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Fix for bug#193. Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 09 Jul 2010 18:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Deniz Dogan Cc: 193@debbugs.gnu.org Received: via spool by 193-submit@debbugs.gnu.org id=B193.127870084424555 (code B ref 193); Fri, 09 Jul 2010 18:41:01 +0000 Received: (at 193) by debbugs.gnu.org; 9 Jul 2010 18:40:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXIVA-0006O0-8I for submit@debbugs.gnu.org; Fri, 09 Jul 2010 14:40:44 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXIV6-0006Nt-LR for 193@debbugs.gnu.org; Fri, 09 Jul 2010 14:40:41 -0400 Received: (qmail 51962 invoked by uid 3782); 9 Jul 2010 18:40:34 -0000 Received: from acm.muc.de (pD9E50735.dip.t-dialin.net [217.229.7.53]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Fri, 09 Jul 2010 20:40:33 +0200 Received: (qmail 3229 invoked by uid 1000); 9 Jul 2010 18:51:16 -0000 Date: Fri, 9 Jul 2010 18:51:16 +0000 Message-ID: <20100709185115.GA3036@muc.de> References: <4820D259.2060805@bbn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) Hi, Deniz, On Sun, Jun 27, 2010 at 02:47:52PM +0200, Deniz Dogan wrote: > Did anyone ever agree on what needs to be done to fix the problem? Would you try this patch, please, and then tell me whether or not it works fully. Thanks! *** orig/cc-cmds.el 2010-07-05 20:17:46.000000000 +0000 --- cc-cmds.el 2010-07-09 18:31:52.143059496 +0000 *************** *** 4229,4236 **** (let ((fill-paragraph-function ;; Avoid infinite recursion. (if (not (eq fill-paragraph-function 'c-fill-paragraph)) ! fill-paragraph-function))) ! (c-mask-paragraph t nil 'fill-paragraph arg)) ;; Always return t. This has the effect that if filling isn't done ;; above, it isn't done at all, and it's therefore effectively ;; disabled in normal code. --- 4229,4239 ---- (let ((fill-paragraph-function ;; Avoid infinite recursion. (if (not (eq fill-paragraph-function 'c-fill-paragraph)) ! fill-paragraph-function)) ! (start-point (point-marker))) ! (c-mask-paragraph ! t nil (lambda () (fill-region-as-paragraph (point-min) (point-max) arg))) ! (goto-char start-point)) ;; Always return t. This has the effect that if filling isn't done ;; above, it isn't done at all, and it's therefore effectively ;; disabled in normal code. > Deniz Dogan -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Fix for bug#193. Resent-From: Christoph Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 10 Jul 2010 01:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12787260933597 (code B ref -1); Sat, 10 Jul 2010 01:42:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jul 2010 01:41:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXP4P-0000vy-4Z for submit@debbugs.gnu.org; Fri, 09 Jul 2010 21:41:33 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXP4N-0000vt-Fs for submit@debbugs.gnu.org; Fri, 09 Jul 2010 21:41:32 -0400 Received: from lists.gnu.org ([199.232.76.165]:56549) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OXP4J-00048D-Vs for submit@debbugs.gnu.org; Fri, 09 Jul 2010 21:41:28 -0400 Received: from [140.186.70.92] (port=49909 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OXP4I-0005jC-Df for bug-gnu-emacs@gnu.org; Fri, 09 Jul 2010 21:41:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OXP4H-00071M-EJ for bug-gnu-emacs@gnu.org; Fri, 09 Jul 2010 21:41:26 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:36326) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXP4H-00071G-AB for bug-gnu-emacs@gnu.org; Fri, 09 Jul 2010 21:41:25 -0400 Received: by gyf1 with SMTP id 1so2125133gyf.0 for ; Fri, 09 Jul 2010 18:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=AHwcAIHTUz1fx+vNfiKLm0OFXVxt4MLhP/3XkcuzYvM=; b=rILqEKAlN8Mq4ASUogglGjya8OC8gAHA5A7e1Ce1/+IzGN8E2cP62iLaI1GhnrASR/ R6jbltVp/M3tvXvygEqaEXGi8c8ng88AXQeG8yfdBE4rjCVA1zrXVh3hn9n2COm5g6JD w877PwC5WyT6kEYPucUjkCmUcD1WMBieZMSbU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=qq/ZQl7p59pkWEH+NSjfILqDndPUadQ3zyp1RUXRJikXaPJ/WtbeuXfYV5VMyTirbT 3tNmtEC0R4NUVE1xKbkZAMgGYHHdqXdQ6lR27ShCFMaRWsz6KCw3RZTRNAPFCH09ZvpZ ezVgT80T30ntpdOv1DOdNjzoSzFX9eYfAS5F0= Received: by 10.101.170.1 with SMTP id x1mr3832726ano.82.1278726084164; Fri, 09 Jul 2010 18:41:24 -0700 (PDT) Received: from [192.168.1.2] (97-122-111-58.hlrn.qwest.net [97.122.111.58]) by mx.google.com with ESMTPS id r7sm17533890anb.35.2010.07.09.18.41.19 (version=SSLv3 cipher=RC4-MD5); Fri, 09 Jul 2010 18:41:23 -0700 (PDT) Message-ID: <4C37CFB8.2020707@gmail.com> Date: Fri, 09 Jul 2010 19:41:12 -0600 From: Christoph User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 MIME-Version: 1.0 References: <4820D259.2060805@bbn.com> <20100709185115.GA3036@muc.de> In-Reply-To: <20100709185115.GA3036@muc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Hi Alan, On 7/9/2010 12:51 PM, Alan Mackenzie wrote: > Hi, Deniz, > > On Sun, Jun 27, 2010 at 02:47:52PM +0200, Deniz Dogan wrote: >> Did anyone ever agree on what needs to be done to fix the problem? > > Would you try this patch, please, and then tell me whether or not it > works fully. Thanks! M-q works fine for me with C as well as C++ style comments, both ways, i.e. shorting long comments and extending short comments to fill the line. The only "quirk" I found: Using C-style comments, if the original comment looks like this: /* This is a short comment which is extended */ the resulting comment is: /* This is a short comment which is extended */ Notice the two spaces after the last word 'extended', before the close comment marker. I would have expected either: /* This is a short comment which is extended */ i.e. the whitespace of the original comment is preserved, or /* This is a short comment which is extended */ i.e. the whitespace is zapped except one space before the close comment marker. This might be nitpicking but I thought I bring it up. Christoph From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Fix for bug#193. Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 11 Jul 2010 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Christoph Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.127887394123254 (code B ref -1); Sun, 11 Jul 2010 18:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jul 2010 18:45:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OY1X3-000631-11 for submit@debbugs.gnu.org; Sun, 11 Jul 2010 14:45:41 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OY1Wy-00062t-3z for submit@debbugs.gnu.org; Sun, 11 Jul 2010 14:45:39 -0400 Received: from lists.gnu.org ([199.232.76.165]:56798) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OY1Wh-0000RE-LB for submit@debbugs.gnu.org; Sun, 11 Jul 2010 14:45:19 -0400 Received: from [140.186.70.92] (port=37182 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OY1We-0007vy-U8 for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2010 14:45:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OY1Wb-0001la-W4 for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2010 14:45:15 -0400 Received: from colin.muc.de ([193.149.48.1]:2260 helo=mail.muc.de) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OY1Wb-0001lH-KX for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2010 14:45:13 -0400 Received: (qmail 62677 invoked by uid 3782); 11 Jul 2010 18:45:11 -0000 Received: from acm.muc.de (pD9E5395F.dip.t-dialin.net [217.229.57.95]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sun, 11 Jul 2010 20:45:10 +0200 Received: (qmail 10688 invoked by uid 1000); 11 Jul 2010 18:55:59 -0000 Date: Sun, 11 Jul 2010 18:55:59 +0000 Message-ID: <20100711185559.GE3134@muc.de> References: <4820D259.2060805@bbn.com> <20100709185115.GA3036@muc.de> <4C37CFB8.2020707@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C37CFB8.2020707@gmail.com> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 4.6-4.9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) Hi, Christoph, On Fri, Jul 09, 2010 at 07:41:12PM -0600, Christoph wrote: > Hi Alan, > On 7/9/2010 12:51 PM, Alan Mackenzie wrote: > >Hi, Deniz, > >On Sun, Jun 27, 2010 at 02:47:52PM +0200, Deniz Dogan wrote: > >>Did anyone ever agree on what needs to be done to fix the problem? > >Would you try this patch, please, and then tell me whether or not it > >works fully. Thanks! > M-q works fine for me with C as well as C++ style comments, both ways, > i.e. shorting long comments and extending short comments to fill the line. > The only "quirk" I found: > Using C-style comments, if the original comment looks like this: > /* This is a short comment > which is extended */ > the resulting comment is: > /* This is a short comment which is extended */ > Notice the two spaces after the last word 'extended', before the close > comment marker. The reason being that the filling function assumed that a comment ends with a sentence, and should therefore leave two spaces after it. However, if there's no full stop (etc.), the two spaces is silly. > This might be nitpicking but I thought I bring it up. We need nitpickers. ;-) Thanks for drawing it to my attention. Would you please try this amended patch: It should leave just one space after "is extended", but two spaces after "is extended.". *** orig/cc-cmds.el 2010-07-05 20:17:46.000000000 +0000 --- cc-cmds.el 2010-07-11 18:46:13.066679040 +0000 *************** *** 3975,3980 **** --- 3975,3988 ---- (goto-char ender-start) (current-column))) (point-rel (- ender-start here)) + (sentence-ends-comment + (save-excursion + (goto-char ender-start) + (and (search-backward-regexp + (c-sentence-end) (c-point 'bol) t) + (goto-char (match-end 0)) + (looking-at "[ \t]*") + (= (match-end 0) ender-start)))) spaces) (save-excursion *************** *** 4017,4023 **** (setq spaces (max (min spaces ! (if sentence-end-double-space 2 1)) 1))) ;; Insert the filler first to keep marks right. (insert-char ?x spaces t) --- 4025,4033 ---- (setq spaces (max (min spaces ! (if (and sentence-ends-comment ! sentence-end-double-space) ! 2 1)) 1))) ;; Insert the filler first to keep marks right. (insert-char ?x spaces t) *************** *** 4229,4236 **** (let ((fill-paragraph-function ;; Avoid infinite recursion. (if (not (eq fill-paragraph-function 'c-fill-paragraph)) ! fill-paragraph-function))) ! (c-mask-paragraph t nil 'fill-paragraph arg)) ;; Always return t. This has the effect that if filling isn't done ;; above, it isn't done at all, and it's therefore effectively ;; disabled in normal code. --- 4239,4249 ---- (let ((fill-paragraph-function ;; Avoid infinite recursion. (if (not (eq fill-paragraph-function 'c-fill-paragraph)) ! fill-paragraph-function)) ! (start-point (point-marker))) ! (c-mask-paragraph ! t nil (lambda () (fill-region-as-paragraph (point-min) (point-max) arg))) ! (goto-char start-point)) ;; Always return t. This has the effect that if filling isn't done ;; above, it isn't done at all, and it's therefore effectively ;; disabled in normal code. > Christoph Looking forward to hearing back from you, -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Fix for bug#193. Resent-From: Christoph Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 14 Jul 2010 01:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Alan Mackenzie Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.127906971324071 (code B ref -1); Wed, 14 Jul 2010 01:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jul 2010 01:08:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYqSf-0006GB-1k for submit@debbugs.gnu.org; Tue, 13 Jul 2010 21:08:33 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYqSc-0006Fq-Si for submit@debbugs.gnu.org; Tue, 13 Jul 2010 21:08:31 -0400 Received: from lists.gnu.org ([199.232.76.165]:50046) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OYqSj-0000TQ-Cw for submit@debbugs.gnu.org; Tue, 13 Jul 2010 21:08:37 -0400 Received: from [140.186.70.92] (port=33500 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYqSh-0004or-Nz for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2010 21:08:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYqSg-0005Lw-F6 for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2010 21:08:35 -0400 Received: from mail-gx0-f169.google.com ([209.85.161.169]:61236) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYqSg-0005Lr-D0 for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2010 21:08:34 -0400 Received: by gxk4 with SMTP id 4so4532620gxk.0 for ; Tue, 13 Jul 2010 18:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=eTByK2rNQVTGAA8DFb2pBWAqU4t9V6Xv2W/mVq1Qrz8=; b=jpY472/tM4FEH/8xOa6e5p0pif24VewXTeh+dsWKR195sp7VUhhCJFaYI21FH1AFUW oGbAMdril+cM6o/Wu/P1yvLV8rHaXxxa39gFIvS8yit+WplSBr7/SFHdah46gSSC1mGM 1sJIy6Xd7NTFl8DzpoyV9wAaThAM6nRdI8cZ4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=bzrB0ZsZk6kd3hI8cA2fwhsdXLzNfHfKIpm+UT8PqHaAmFw/74tMAfaJjgs95elnIs fPNq//PBw2Rbzsb6Cbd5KEK5Xivn2Dxb4aXvbDOJsrVDCKUumqgQpgY+i4WoAwQjwSul w/xcaxSI2i0k9XU/gtnZ498kj/89VdrrDefB4= Received: by 10.100.109.20 with SMTP id h20mr1557525anc.93.1279069713860; Tue, 13 Jul 2010 18:08:33 -0700 (PDT) Received: from [192.168.1.4] (174-16-113-224.hlrn.qwest.net [174.16.113.224]) by mx.google.com with ESMTPS id c19sm72318095ana.2.2010.07.13.18.08.32 (version=SSLv3 cipher=RC4-MD5); Tue, 13 Jul 2010 18:08:33 -0700 (PDT) Message-ID: <4C3D0E0E.4020604@gmail.com> Date: Tue, 13 Jul 2010 19:08:30 -0600 From: Christoph User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 MIME-Version: 1.0 References: <4820D259.2060805@bbn.com> <20100709185115.GA3036@muc.de> <4C37CFB8.2020707@gmail.com> <20100711185559.GE3134@muc.de> In-Reply-To: <20100711185559.GE3134@muc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) Alan, On 7/11/2010 12:55 PM, Alan Mackenzie wrote: > We need nitpickers. ;-) Thanks for drawing it to my attention. Would > you please try this amended patch: It should leave just one space after > "is extended", but two spaces after "is extended.". Germans are the best nitpickers. ;) Anyway, it works fine now. Just like you described with an additional space after the period, none otherwise. However, here is one more quirky case: /* this is a test . */ expands to /* this is a test */ I would have expected /* this is a test */ However, this /* this is a test */ (note the extra space at the beginning of the line) expands to /* this is a test */ which I can understand, but I am not sure if this is intended or if it is supposed to also be /* this is a test */ Thanks, Christoph From unknown Fri Jun 20 20:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#193: Fix for bug#193. Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 06 Aug 2010 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 193 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Christoph Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128112087929457 (code B ref -1); Fri, 06 Aug 2010 18:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Aug 2010 18:54:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhS3z-0007f4-31 for submit@debbugs.gnu.org; Fri, 06 Aug 2010 14:54:39 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhS3x-0007ez-Ak for submit@debbugs.gnu.org; Fri, 06 Aug 2010 14:54:37 -0400 Received: from lists.gnu.org ([199.232.76.165]:59967) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OhS4V-0007b6-M2 for submit@debbugs.gnu.org; Fri, 06 Aug 2010 14:55:11 -0400 Received: from [140.186.70.92] (port=51083 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhS4T-00086t-WB for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 14:55:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OhS4S-0002q2-Uf for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 14:55:09 -0400 Received: from colin.muc.de ([193.149.48.1]:3105 helo=mail.muc.de) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhS4S-0002po-KP for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 14:55:08 -0400 Received: (qmail 91942 invoked by uid 3782); 6 Aug 2010 18:47:44 -0000 Received: from acm.muc.de (pD9E23D4E.dip.t-dialin.net [217.226.61.78]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Fri, 06 Aug 2010 20:47:43 +0200 Received: (qmail 2732 invoked by uid 1000); 6 Aug 2010 18:59:06 -0000 Date: Fri, 6 Aug 2010 18:59:06 +0000 Message-ID: <20100806185906.GA2471@muc.de> References: <4820D259.2060805@bbn.com> <20100709185115.GA3036@muc.de> <4C37CFB8.2020707@gmail.com> <20100711185559.GE3134@muc.de> <4C3D0E0E.4020604@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C3D0E0E.4020604@gmail.com> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 4.6-4.9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) Hi, Christoph! On Tue, Jul 13, 2010 at 07:08:30PM -0600, Christoph wrote: > Alan, > Anyway, it works fine now. Just like you described with an additional > space after the period, none otherwise. > However, here is one more quirky case: > /* > this > is > a > test > . > */ > expands to > /* > this is a test */ It fills properly for me when I type C-q. That is, it works right after applying the patch I sent ~ 3 weeks ago. > I would have expected > /* this is a test */ > However, this > /* > this > is > a > test > */ (note the extra space at the beginning of the line) > expands to > /* > this is a test > */ > which I can understand, but I am not sure if this is intended or if it > is supposed to also be > /* this is a test */ A comment marker alone on a line stays that way, on the assumption that this is a matter of style. A comment marker on a line together with text always keeps at least one word with it after filling. > Thanks, > Christoph -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 20:00:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Richard Hansen Subject: bug#193: closed (Re: bug#193:) Message-ID: References: <4820D259.2060805@bbn.com> X-Gnu-PR-Message: they-closed 193 X-Gnu-PR-Package: emacs,cc-mode Reply-To: 193@debbugs.gnu.org Date: Sat, 05 Mar 2011 20:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1299357842-21275-1" This is a multi-part message in MIME format... ------------=_1299357842-21275-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #193: Fill for // (C++) style comments in C (C99) which was filed against the emacs,cc-mode package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 193@debbugs.gnu.org. --=20 193: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D193 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1299357842-21275-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 193-done) by debbugs.gnu.org; 5 Mar 2011 20:43:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvyKE-0005WV-Ti for submit@debbugs.gnu.org; Sat, 05 Mar 2011 15:43:43 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvyKD-0005WH-Hq for 193-done@debbugs.gnu.org; Sat, 05 Mar 2011 15:43:41 -0500 Received: from localhost ([127.0.0.1]:36119) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvyK7-0002bi-8o; Sat, 05 Mar 2011 15:43:35 -0500 From: Glenn Morris To: 193-done@debbugs.gnu.org Subject: Re: bug#193: References: <4820D259.2060805@bbn.com> <20100705200629.GA1650@muc.de> X-Spook: cracking Ft. Knox encryption ICE ANC White House Defcon X-Ran: )_!wOZSbe0C0Fdtq?btb$frrU1Nf'%IyG*8a*rrViA(-S*'faj\6ubo1!qZ50,Ddb~|'?[ X-Hue: green X-Attribution: GM Date: Sat, 05 Mar 2011 15:43:34 -0500 In-Reply-To: <20100705200629.GA1650@muc.de> (Alan Mackenzie's message of "Mon, 5 Jul 2010 20:06:30 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 193-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.1 Looks like a patch for this was applied 2010-08-06. ------------=_1299357842-21275-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From monnier@iro.umontreal.ca Tue May 6 16:23:39 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 6 May 2008 23:23:39 +0000 Received: from mercure.iro.umontreal.ca (mercure.iro.umontreal.ca [132.204.24.67]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m46NNZnj013386 for ; Tue, 6 May 2008 16:23:37 -0700 Received: by mercure.iro.umontreal.ca (Postfix, from userid 20848) id 4F2882CFCA8; Tue, 6 May 2008 19:23:35 -0400 (EDT) X-Original-To: monnier@iro.umontreal.ca Received: from pinpin.iro.umontreal.ca (pinpin.iro.umontreal.ca [132.204.24.52]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 301032CFA64 for ; Tue, 6 May 2008 19:23:35 -0400 (EDT) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by pinpin.iro.umontreal.ca (Postfix) with ESMTP id 1371F3B8B43 for ; Tue, 6 May 2008 19:23:28 -0400 (EDT) Received: from localhost ([127.0.0.1]:36953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtWVL-0003Ak-J8 for monnier@iro.umontreal.ca; Tue, 06 May 2008 19:23:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtV2E-0001Q0-L2 for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtV2D-0001Pd-20 for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:18 -0400 Received: from [199.232.76.173] (port=39345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtV2C-0001Pa-Ul for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:16 -0400 Received: from mx11.bbn.com ([128.33.0.80]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtV2C-0003GL-Of for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:16 -0400 Received: from deer.bbn.com ([128.89.80.92]) by mx11.bbn.com with esmtp (Exim 4.60) (envelope-from ) id 1JtV29-0000xn-4e for bug-gnu-emacs@gnu.org; Tue, 06 May 2008 17:49:13 -0400 Message-ID: <4820D259.2060805@bbn.com> Date: Tue, 06 May 2008 17:49:13 -0400 From: Richard Hansen User-Agent: Thunderbird 2.0.0.12 (X11/20080227) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Tue, 06 May 2008 19:23:18 -0400 Subject: Fill for // (C++) style comments in C (C99) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.94, requis 5, BAYES_00 -2.60, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org It appears that filling C++-style comments inside C99 code via c-fill-paragraph is still broken. This bug was previously reported[1] in November 2006 and was extensively discussed, but it looks like no fix was ever committed. [1] http://lists.gnu.org/archive/html/emacs-devel/2006-11/msg00868.html -Richard ------------=_1299357842-21275-1--