GNU bug report logs - #19292
24.3; [PATCH] erc-server-ping-timer-alist now has at most one timer per buffer

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 19292 <at> debbugs.gnu.org
Subject: bug#19292: 24.3; [PATCH] erc-server-ping-timer-alist now has at most one timer per buffer
Date: Sun, 27 Dec 2015 21:19:49 +0100

Dima Kogan <dima <at> secretsauce.net> writes:

> This alist was meant to map buffers to timers, but the "push" function
> was not checking for already-existing timers.  This was causing a
> flood of PINGs being queued (because more than one timer was inserting
> those), and the flood-control logic would block those from going
> through quickly.
>
> This patch checks for existing timers in the alist before adding new
> ones.  If a timer already exists, it is cancelled and overwritten.

Thanks; applied to Emacs 25.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.