GNU bug report logs - #19231
25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64

Previous Next

Full log

View this message in rfc822 format

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Chris Zheng <chriszheng99 <at> gmail.com>
Cc: 19231 <at> debbugs.gnu.org
Subject: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64
Date: Mon, 01 Dec 2014 18:46:48 +0100

Chris Zheng <chriszheng99 <at> gmail.com> writes:

> * src/gnutls.c: In MinGW-w64, `gnutls_sign_algorithm_get_name' is
>   defined as a macro to `gnutls_sign_get_name', so use
>   `gnutls_sign_get_name' directly.
>   (init_gnutls_functions): Load missing `gnutls_server_name_set'.
>   (init_gnutls_functions): Use `gnutls_sign_get_name'.
>   (gnutls_certificate_details): Use `fn_gnutls_sign_get_name'.

[...]

> +/* Use `gnutls_sign_get_name' instead of
> +   `gnutls_sign_algorithm_get_name' for MinGW-w64.  */
> +#if defined(MINGW_W64) && defined(gnutls_sign_algorithm_get_name)
> +	const char *name = fn_gnutls_sign_get_name (err);
> +#else
>  	const char *name = fn_gnutls_sign_algorithm_get_name (err);
> +#endif

Instead of adding these ifdefs, perhaps we could just call
fn_gnutls_sign_get_name on all platforms?  Or does that function not
exist on non-MingGW platforms?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.