From unknown Sat Aug 16 23:36:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19231 <19231@debbugs.gnu.org> To: bug#19231 <19231@debbugs.gnu.org> Subject: Status: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 Reply-To: bug#19231 <19231@debbugs.gnu.org> Date: Sun, 17 Aug 2025 06:36:32 +0000 retitle 19231 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 reassign 19231 emacs submitter 19231 Chris Zheng severity 19231 normal tag 19231 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 14:18:27 2014 Received: (at submit) by debbugs.gnu.org; 30 Nov 2014 19:18:28 +0000 Received: from localhost ([127.0.0.1]:50134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvA0p-0002O2-Be for submit@debbugs.gnu.org; Sun, 30 Nov 2014 14:18:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35120) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvA0n-0002Nu-L6 for submit@debbugs.gnu.org; Sun, 30 Nov 2014 14:18:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvA0e-0006Mx-BH for submit@debbugs.gnu.org; Sun, 30 Nov 2014 14:18:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_40, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvA0e-0006Mt-8V for submit@debbugs.gnu.org; Sun, 30 Nov 2014 14:18:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvA0V-0005Lj-4E for bug-gnu-emacs@gnu.org; Sun, 30 Nov 2014 14:18:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvA0M-0006JR-2o for bug-gnu-emacs@gnu.org; Sun, 30 Nov 2014 14:18:07 -0500 Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:48336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvA0L-0006J4-Rw for bug-gnu-emacs@gnu.org; Sun, 30 Nov 2014 14:17:58 -0500 Received: by mail-pa0-f53.google.com with SMTP id kq14so9635507pab.12 for ; Sun, 30 Nov 2014 11:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:to:subject:from:mime-version:content-type :content-transfer-encoding; bh=Q8ZOuJlRLkugs9Lp3d1RIXjOAAAmlKwJhnPR9vFEjeY=; b=s4/ONVgSv+dwSSndCbl5SS1cz1kc7x2Dn28HOovp70Xxl9xxX5BHkgCP/sdSf7ES5i zqmyfao/26T6tPcHtHwrIryISGfXdyKAawc/a1dB8xLrQpEigZOWU2qzR30/sSnc6i5B ul9KDBU3U/7IJdGz+mIJbB8DixZQwRgUpyEpBAkt0LCGuegjuvA0xVAf5aYqrO0N408S A2+1xs5pKw9Jthr/uTRGGEGQknSJ5RbAYSuSIxPd9PzTPKCEe0Bh/uSBRWySbr1L81Q1 UcuXY3QQvuiOMguRYN/Ys+tkOrib8C3vd7vgBe30b0yGXT20nF9JBH8Py1b7q3U3iu3B dQoQ== X-Received: by 10.68.189.136 with SMTP id gi8mr93796994pbc.54.1417375076107; Sun, 30 Nov 2014 11:17:56 -0800 (PST) Received: from localhost ([180.201.223.129]) by mx.google.com with ESMTPSA id vy1sm15588243pac.20.2014.11.30.11.17.53 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sun, 30 Nov 2014 11:17:55 -0800 (PST) Date: Mon, 01 Dec 2014 03:17:48 +0800 Message-Id: <20141201.031748.1767411492928916984.chriszheng99@gmail.com> To: bug-gnu-emacs@gnu.org Subject: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 From: Chris Zheng X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Dear maintainers, Two recent changes to gnutls.c breaks GnuTLS support in a MSYS2/MinGW-w64 build. The first is: a859504 Add functions to gnutls.c for exporting certificate details. In GnuTLS v3.3.10 from MinGW-w64, the `gnutls_sign_algorithm_get_name' is defined as a macro, so it can't be loaded by the macro `LOAD_GNUTLS_FN'. This leads to `nil' from `(gnutls-available-p)'. The second is: ccae04f | * gnutls.c (Fgnutls_boot): Send the server name over where `gnutls_server_name_set' is not loaded in Windows. This cause Emacs to crash. I think the following patch fixes these bugs. I have tested it with MSYS2/MinGW-w64 combination, where GnuTLS version is 3.3.10. Can it be applied? Thanks. >From 3b747a7bc4d05a41f53ecc1fdbd4a45838bc9d5a Mon Sep 17 00:00:00 2001 From: Chris Zheng Date: Mon, 1 Dec 2014 02:13:04 +0800 Subject: [PATCH] Fix recent GnuTLS change for MinGW-w64. * src/gnutls.c: In MinGW-w64, `gnutls_sign_algorithm_get_name' is defined as a macro to `gnutls_sign_get_name', so use `gnutls_sign_get_name' directly. (init_gnutls_functions): Load missing `gnutls_server_name_set'. (init_gnutls_functions): Use `gnutls_sign_get_name'. (gnutls_certificate_details): Use `fn_gnutls_sign_get_name'. --- src/gnutls.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/gnutls.c b/src/gnutls.c index 752df3c..92333c5 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -185,8 +185,15 @@ DEF_GNUTLS_FN (int, gnutls_x509_crt_get_key_id, (gnutls_x509_crt_t, unsigned int, unsigned char *, size_t *_size)); DEF_GNUTLS_FN (const char*, gnutls_sec_param_get_name, (gnutls_sec_param_t)); +/* Use `gnutls_sign_get_name' instead of + `gnutls_sign_algorithm_get_name' for MinGW-w64. */ +#if defined(MINGW_W64) && defined(gnutls_sign_algorithm_get_name) +DEF_GNUTLS_FN (const char*, gnutls_sign_get_name, + (gnutls_sign_algorithm_t)); +#else DEF_GNUTLS_FN (const char*, gnutls_sign_algorithm_get_name, (gnutls_sign_algorithm_t)); +#endif DEF_GNUTLS_FN (int, gnutls_server_name_set, (gnutls_session_t, gnutls_server_name_type_t, const void *, size_t)); @@ -265,7 +272,14 @@ init_gnutls_functions (void) LOAD_GNUTLS_FN (library, gnutls_x509_crt_get_signature); LOAD_GNUTLS_FN (library, gnutls_x509_crt_get_key_id); LOAD_GNUTLS_FN (library, gnutls_sec_param_get_name); + /* Use `gnutls_sign_get_name' instead of + `gnutls_sign_algorithm_get_name' for MinGW-w64. */ +#if defined(MINGW_W64) && defined(gnutls_sign_algorithm_get_name) + LOAD_GNUTLS_FN (library, gnutls_sign_get_name); +#else LOAD_GNUTLS_FN (library, gnutls_sign_algorithm_get_name); +#endif + LOAD_GNUTLS_FN (library, gnutls_server_name_set); max_log_level = global_gnutls_log_level; @@ -928,7 +942,13 @@ gnutls_certificate_details (gnutls_x509_crt_t cert) err = fn_gnutls_x509_crt_get_signature_algorithm (cert); if (err >= GNUTLS_E_SUCCESS) { +/* Use `gnutls_sign_get_name' instead of + `gnutls_sign_algorithm_get_name' for MinGW-w64. */ +#if defined(MINGW_W64) && defined(gnutls_sign_algorithm_get_name) + const char *name = fn_gnutls_sign_get_name (err); +#else const char *name = fn_gnutls_sign_algorithm_get_name (err); +#endif if (name) res = nconc2 (res, list2 (intern (":signature-algorithm"), build_string (name))); -- 2.2.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 01 12:47:10 2014 Received: (at 19231) by debbugs.gnu.org; 1 Dec 2014 17:47:10 +0000 Received: from localhost ([127.0.0.1]:51010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvV42-0004i0-3Y for submit@debbugs.gnu.org; Mon, 01 Dec 2014 12:47:10 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57555) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvV3z-0004hp-HA for 19231@debbugs.gnu.org; Mon, 01 Dec 2014 12:47:07 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XvV3h-0000oL-5n; Mon, 01 Dec 2014 18:46:49 +0100 From: Lars Magne Ingebrigtsen To: Chris Zheng Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 References: <20141201.031748.1767411492928916984.chriszheng99@gmail.com> X-Now-Playing: Steely Dan's _Aja_: "Aja" X-Hashcash: 1:23:141201:chriszheng99@gmail.com::6B55XhSXjM9nfnVt:0000000000000000000000000000000000000009eZt X-Hashcash: 1:23:141201:19231@debbugs.gnu.org::3IDLx0OLohKrs+DS:0000000000000000000000000000000000000001DIT2 Date: Mon, 01 Dec 2014 18:46:48 +0100 In-Reply-To: <20141201.031748.1767411492928916984.chriszheng99@gmail.com> (Chris Zheng's message of "Mon, 01 Dec 2014 03:17:48 +0800") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XvV3h-0000oL-5n X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418060809.41799@A077kzf75UR9wclICr6Ocw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19231 Cc: 19231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Chris Zheng writes: > * src/gnutls.c: In MinGW-w64, `gnutls_sign_algorithm_get_name' is > defined as a macro to `gnutls_sign_get_name', so use > `gnutls_sign_get_name' directly. > (init_gnutls_functions): Load missing `gnutls_server_name_set'. > (init_gnutls_functions): Use `gnutls_sign_get_name'. > (gnutls_certificate_details): Use `fn_gnutls_sign_get_name'. [...] > +/* Use `gnutls_sign_get_name' instead of > + `gnutls_sign_algorithm_get_name' for MinGW-w64. */ > +#if defined(MINGW_W64) && defined(gnutls_sign_algorithm_get_name) > + const char *name = fn_gnutls_sign_get_name (err); > +#else > const char *name = fn_gnutls_sign_algorithm_get_name (err); > +#endif Instead of adding these ifdefs, perhaps we could just call fn_gnutls_sign_get_name on all platforms? Or does that function not exist on non-MingGW platforms? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 02 08:03:58 2014 Received: (at 19231) by debbugs.gnu.org; 2 Dec 2014 13:03:58 +0000 Received: from localhost ([127.0.0.1]:51487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xvn7S-0000Ye-0f for submit@debbugs.gnu.org; Tue, 02 Dec 2014 08:03:58 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:45780) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xvn7L-0000YJ-UX for 19231@debbugs.gnu.org; Tue, 02 Dec 2014 08:03:52 -0500 Received: by mail-pa0-f44.google.com with SMTP id et14so13517498pad.3 for <19231@debbugs.gnu.org>; Tue, 02 Dec 2014 05:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:to:cc:subject:from:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=uC/sTyn1Rm5i0ghkbdlZotTIzuOuMqUUow24hrlGoBw=; b=PnxT8K8NhTwMO/2tACCe6GOjU/59Pk13ETa6TLDzdcL53Eiu/vHxOChFCHez0os/Q0 NnsN1RkNtKKKtR8QNWcU7Q0ZX5dRBwcVpjUv5c1VtV1BpbJJINnWApO1jHv2aMux5L7q 7arD55Vb9/o6imf85E1YbvVjzthw389iRLclntVTR3K6crOE5Dc0K+rq2u+cCpPkSmCq kYxztic2hzypoJxy9CZtiX/cpNmcQ+iKOdTxdxlxONF++KyD4QJyldKik4Q44GjYpwdK fQKvEXYT/g890olf/IkX4QVjjufagbiTMDZpG+MM2I3E8DZbAEQr7EHMkZQ8KrRE82Ld EPnw== X-Received: by 10.70.53.35 with SMTP id y3mr19425594pdo.27.1417525425148; Tue, 02 Dec 2014 05:03:45 -0800 (PST) Received: from localhost ([123.235.3.96]) by mx.google.com with ESMTPSA id co1sm20274169pbc.22.2014.12.02.05.03.41 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 02 Dec 2014 05:03:44 -0800 (PST) Date: Tue, 02 Dec 2014 21:03:37 +0800 Message-Id: <20141202.210337.671564019439610331.chriszheng99@gmail.com> To: larsi@gnus.org Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 From: Chris Zheng In-Reply-To: References: <20141201.031748.1767411492928916984.chriszheng99@gmail.com> X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19231 Cc: 19231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) From: Lars Magne Ingebrigtsen Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 Date: Mon, 01 Dec 2014 18:46:48 +0100 Hi, > Instead of adding these ifdefs, perhaps we could just call > fn_gnutls_sign_get_name on all platforms? Or does that function not > exist on non-MingGW platforms? I have tested using fn_gnutls_sign_get_name in GNU/Linux (distro Arch Linux with same version of GnuTLS as in Windows), and it works as expected. This is all what I known. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 02 11:37:42 2014 Received: (at 19231) by debbugs.gnu.org; 2 Dec 2014 16:37:42 +0000 Received: from localhost ([127.0.0.1]:51927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvqSL-0007gc-RQ for submit@debbugs.gnu.org; Tue, 02 Dec 2014 11:37:42 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:44595) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvqSJ-0007gU-W0 for 19231@debbugs.gnu.org; Tue, 02 Dec 2014 11:37:40 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XvqRt-0008F6-32; Tue, 02 Dec 2014 17:37:13 +0100 From: Lars Magne Ingebrigtsen To: Chris Zheng Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 References: <20141201.031748.1767411492928916984.chriszheng99@gmail.com> <20141202.210337.671564019439610331.chriszheng99@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWpDh6OCBelEh6RCxqH UE61FR8yAgcj1NjkAAACTElEQVQ4jVWUzXbaMBCF5eSYNRNH2tODWYcm9r6t8FrGjNcoiHn/R+gd yXZPvQAzn3Tv/AgZKY8fkniR+HmYzi3zjU2JpzQMiAuNlizjuRSQvPcJ302saa9x9maN+wFC52gp x/mWwbDESXqqEZ0azh7LetlRbNQgiNwVZCE1cO4zG8zifwGkReg7xns2cKoBoAmpQf10VV6ffNId CGeDTlzT5Q1ZWkE2sHd55Mo4e14Aksaf4ixy5HHJBSALxbqfzsUYLfNDAdiwfxyqD3AuRf2+1Mhq 78S6GOyMxK0KQaN9MQar4qk/vOXFF0S9eNeFFyPxLrsIgwKys7QcjCPr3IjW5Sy/vrw/snQAuzvP USvI4Jiwng+o1IzCIbfufQMtGwB29pArHt9VSh30VzCV5NlgOn/QoaNHFgVQGT4ApK4HnBBIMV/N WIaPV/Th2mOVaJNHQ2EF+tHzAipjNqBBzWNW7T3i9ULiuqKAul62XGUBbFXXdPsFTBvQrNhUFNr8 Pm5A8wgmUIWtH/+BkfnLhD1h2Kh+jqvQ1PGUDFURUdduoOO55V2CBzmbwWMDOjV4OGom9Gf+3pLV U2SYKNKr2HZ+loz0q1cAD4BHeypgjFqrgkD0QRLbHuDaMgHcMmBqGidN5wCm0ttUwGtFTt5aeeaS fxYlBdA6yQ+W51r4cQFMZxKcROQ55v4NK0CNuBJ0TqiZ7U1WMJLD/27AgUYfXddvgGFe7gGk9Jjk H6jKPYODzpM9rQC9HV25N4bIU4u3AkzN4VyAfPM0qxuev4xLTg4JwBHuAAAAAElFTkSuQmCC X-Now-Playing: Kraftwerk's _The Man Machine_: "Metropolis" X-Hashcash: 1:23:141202:chriszheng99@gmail.com::aWoQoex0E/rPBAa/:0000000000000000000000000000000000000007b4f X-Hashcash: 1:23:141202:19231@debbugs.gnu.org::9qKcTYiCGbHJmsxe:0000000000000000000000000000000000000001W7lu Date: Tue, 02 Dec 2014 17:37:12 +0100 In-Reply-To: <20141202.210337.671564019439610331.chriszheng99@gmail.com> (Chris Zheng's message of "Tue, 02 Dec 2014 21:03:37 +0800") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XvqRt-0008F6-32 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418143033.92224@SpG9OCJhWp/7qy1f4fTQmA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19231 Cc: 19231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Chris Zheng writes: > I have tested using fn_gnutls_sign_get_name in GNU/Linux (distro Arch > Linux with same version of GnuTLS as in Windows), and it works as > expected. This is all what I known. Great. Could you redo the patch without the #ifdefs, and just call fn_gnutls_sign_get_name on all architectures? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 02 23:38:11 2014 Received: (at 19231) by debbugs.gnu.org; 3 Dec 2014 04:38:11 +0000 Received: from localhost ([127.0.0.1]:52264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xw1hX-0002xi-IA for submit@debbugs.gnu.org; Tue, 02 Dec 2014 23:38:11 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:54054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xw1hR-0002xC-G1 for 19231@debbugs.gnu.org; Tue, 02 Dec 2014 23:38:05 -0500 Received: by mail-pa0-f45.google.com with SMTP id lj1so14998542pab.32 for <19231@debbugs.gnu.org>; Tue, 02 Dec 2014 20:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:to:cc:subject:from:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=GfO1uO4Tevt7JcKqhNaQhecZiqPqqj5hbLnLhSmVPio=; b=dXSTpMA4RVqdhUEmKTAxJ2WgpzR+lgIYgu4gKwcPdj/53QM3MPu4RDNl+Zpn2ILTcL S5cJFJSwr3oDF+5KAMfuq0HPH61xLEwIJcfQmsOLWn0i8rNRkklBos4DED7r9G5QjxWl 3MWtEQ9rkg2QZbHJFtdWMMu77EuySQXM0a3NDFKlkYFrSET519FXTTeME7Uk1Zi1WpCR jMO7a8FAeJ1MylrZWNIHlNeZUM/YFX3spigwqWg7YlM8vLLzxWDIwD95X+B/vn02Rrd9 1A7jJtuAdfLjX6VRqUIAOdv8qJjhZkyo4wqMTNVj0s5WJ8bRV4LAj4MozWkLjrkBTxl0 XQUw== X-Received: by 10.66.66.135 with SMTP id f7mr4706151pat.81.1417581480449; Tue, 02 Dec 2014 20:38:00 -0800 (PST) Received: from localhost ([211.64.141.155]) by mx.google.com with ESMTPSA id pl3sm21636532pbb.50.2014.12.02.20.37.57 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 02 Dec 2014 20:37:59 -0800 (PST) Date: Wed, 03 Dec 2014 12:37:47 +0800 Message-Id: <20141203.123747.2258800522354877276.chriszheng99@gmail.com> To: larsi@gnus.org Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 From: Chris Zheng In-Reply-To: References: <20141202.210337.671564019439610331.chriszheng99@gmail.com> X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19231 Cc: 19231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) From: Lars Magne Ingebrigtsen Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 Date: Tue, 02 Dec 2014 17:37:12 +0100 Hi, > Great. Could you redo the patch without the #ifdefs, and just call > fn_gnutls_sign_get_name on all architectures? I don't have older version, maybe we should ask for compatibility check. The revised patch is as follows. >From 7c9c759c33e34c3cc5d031ae15ac9bb3d05a37e3 Mon Sep 17 00:00:00 2001 From: Chris Zheng Date: Wed, 3 Dec 2014 12:05:13 +0800 Subject: [PATCH] Use gnutls_sign_get_name and load missing function. * src/gnutls.c (init_gnutls_functions, gnutls_certificate_details): use `gnutls_sign_get_name' directly. (init_gnutls_functions): Load missing `gnutls_server_name_set'. --- src/gnutls.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gnutls.c b/src/gnutls.c index 752df3c..7c61445 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -185,7 +185,7 @@ DEF_GNUTLS_FN (int, gnutls_x509_crt_get_key_id, (gnutls_x509_crt_t, unsigned int, unsigned char *, size_t *_size)); DEF_GNUTLS_FN (const char*, gnutls_sec_param_get_name, (gnutls_sec_param_t)); -DEF_GNUTLS_FN (const char*, gnutls_sign_algorithm_get_name, +DEF_GNUTLS_FN (const char*, gnutls_sign_get_name, (gnutls_sign_algorithm_t)); DEF_GNUTLS_FN (int, gnutls_server_name_set, (gnutls_session_t, gnutls_server_name_type_t, @@ -265,7 +265,8 @@ init_gnutls_functions (void) LOAD_GNUTLS_FN (library, gnutls_x509_crt_get_signature); LOAD_GNUTLS_FN (library, gnutls_x509_crt_get_key_id); LOAD_GNUTLS_FN (library, gnutls_sec_param_get_name); - LOAD_GNUTLS_FN (library, gnutls_sign_algorithm_get_name); + LOAD_GNUTLS_FN (library, gnutls_sign_get_name); + LOAD_GNUTLS_FN (library, gnutls_server_name_set); max_log_level = global_gnutls_log_level; @@ -337,7 +338,7 @@ init_gnutls_functions (void) #define fn_gnutls_x509_crt_get_signature gnutls_x509_crt_get_signature #define fn_gnutls_x509_crt_get_key_id gnutls_x509_crt_get_key_id #define fn_gnutls_sec_param_get_name gnutls_sec_param_get_name -#define fn_gnutls_sign_algorithm_get_name gnutls_sign_algorithm_get_name +#define fn_gnutls_sign_get_name gnutls_sign_get_name #define fn_gnutls_server_name_set gnutls_server_name_set #endif /* !WINDOWSNT */ @@ -928,7 +929,7 @@ gnutls_certificate_details (gnutls_x509_crt_t cert) err = fn_gnutls_x509_crt_get_signature_algorithm (cert); if (err >= GNUTLS_E_SUCCESS) { - const char *name = fn_gnutls_sign_algorithm_get_name (err); + const char *name = fn_gnutls_sign_get_name (err); if (name) res = nconc2 (res, list2 (intern (":signature-algorithm"), build_string (name))); -- 2.2.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 03 09:41:18 2014 Received: (at 19231) by debbugs.gnu.org; 3 Dec 2014 14:41:19 +0000 Received: from localhost ([127.0.0.1]:52443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwB7G-0003Zp-AA for submit@debbugs.gnu.org; Wed, 03 Dec 2014 09:41:18 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwB77-0003ZP-Lq for 19231@debbugs.gnu.org; Wed, 03 Dec 2014 09:41:10 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XwB6o-0004KH-4j; Wed, 03 Dec 2014 15:40:50 +0100 From: Lars Magne Ingebrigtsen To: Chris Zheng Subject: Re: bug#19231: 25.0.50; [PATCH] Fix recent GnuTLS change for MinGW-w64 References: <20141202.210337.671564019439610331.chriszheng99@gmail.com> <20141203.123747.2258800522354877276.chriszheng99@gmail.com> X-Now-Playing: Talking Heads's _More Songs About Buildings and Food_: "With Our Love" X-Hashcash: 1:23:141203:chriszheng99@gmail.com::3KjUGXPpZdzdUB2o:000000000000000000000000000000000000000Kckk X-Hashcash: 1:23:141203:19231@debbugs.gnu.org::3yWh+3SWqUa2/LwM:0000000000000000000000000000000000000000QPAG Date: Wed, 03 Dec 2014 15:40:49 +0100 In-Reply-To: <20141203.123747.2258800522354877276.chriszheng99@gmail.com> (Chris Zheng's message of "Wed, 03 Dec 2014 12:37:47 +0800") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XwB6o-0004KH-4j X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418222450.74914@GhcFeRdbT2qzp1ZTj0Ywzw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19231 Cc: 19231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Chris Zheng writes: > I don't have older version, maybe we should ask for compatibility > check. The revised patch is as follows. Thanks; applied. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 03 09:41:18 2014 Received: (at control) by debbugs.gnu.org; 3 Dec 2014 14:41:18 +0000 Received: from localhost ([127.0.0.1]:52441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwB7F-0003Zm-JW for submit@debbugs.gnu.org; Wed, 03 Dec 2014 09:41:17 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56514) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XwB79-0003ZT-LU for control@debbugs.gnu.org; Wed, 03 Dec 2014 09:41:12 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XwB6r-0004KP-2F for control@debbugs.gnu.org; Wed, 03 Dec 2014 15:40:53 +0100 Date: Wed, 03 Dec 2014 15:40:52 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #19231 X-MailScanner-ID: 1XwB6r-0004KP-2F X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418222453.45336@LygA1CxWWxpeL8q9TICE6A X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 19231 fixed close 19231 25.1 From unknown Sat Aug 16 23:36:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 01 Jan 2015 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator