From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 06:04:18 2014 Received: (at submit) by debbugs.gnu.org; 30 Nov 2014 11:04:18 +0000 Received: from localhost ([127.0.0.1]:49576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xv2Ic-0005Ja-AI for submit@debbugs.gnu.org; Sun, 30 Nov 2014 06:04:18 -0500 Received: from fely.am-1.org ([78.47.74.50]:42922) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xv2IX-0005JQ-Ok for submit@debbugs.gnu.org; Sun, 30 Nov 2014 06:04:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=j2m3eZ9519zs08suL5Ccz1kOapKx/7OmFxbDfdEJl58=; b=ED9NbUM/aFbEak56I1hFuR56x3meI6KY77jzkXmdUgDQXN5gSHws1EG5YaAkakC3Y/ZwXyX2ausqaju6WN33K6Qp1CKCIWUfjKT6SaUZkZC20ufnaY7jyVwOvlnCsFlR18eWK9Ooa0W5LUfiVoClvvr678ivUgkq/vwLxUuEMOQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xv2IW-0007QG-L4 for submit@debbugs.gnu.org; Sun, 30 Nov 2014 11:04:13 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xv2IP-0004S8-B3 for submit@debbugs.gnu.org; Sun, 30 Nov 2014 18:04:05 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> Date: Sun, 30 Nov 2014 11:04:04 +0000 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 19 Nov 2014 18:23:48 +0100") Message-ID: <87bnnpne57.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Tags: patch Please consider the patch MIMEd. * eww.el (eww-mode): Autoload, as expected by desktop.el. (eww-restore-desktop): Use inhibit-read-only when inserting eww-restore-reload-prompt. --=20 FSF associate member #7257 np. Your Leaving =E2=80=94 Jami Sieber =E2=80= =A6 B6A0 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -662,6 +662,8 @@ map) "Tool bar for `eww-mode'.") +;; autoload cookie needed by desktop.el +;;;###autoload (define-derived-mode eww-mode nil "eww" "Mode for browsing the web. @@ -1710,8 +1712,9 @@ defun eww-restore-desktop (file-name buffer-name misc-data) (case eww-restore-desktop ((t auto) (eww (plist-get eww-data :url))) ((zerop (buffer-size)) - (insert (substitute-command-keys - eww-restore-reload-prompt)))))) + (let ((inhibit-read-only t)) + (insert (substitute-command-keys + eww-restore-reload-prompt))))))) ;; . (current-buffer))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 14:57:19 2014 Received: (at 19226) by debbugs.gnu.org; 30 Nov 2014 19:57:19 +0000 Received: from localhost ([127.0.0.1]:50152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvAcR-0003OZ-3i for submit@debbugs.gnu.org; Sun, 30 Nov 2014 14:57:19 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:38369) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvAcP-0003OS-Nt for 19226@debbugs.gnu.org; Sun, 30 Nov 2014 14:57:18 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XvAcK-0007Qo-Qy; Sun, 30 Nov 2014 14:57:13 -0500 From: Glenn Morris To: Ivan Shmakov Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> X-Spook: embassy Clinton Saudi Arabia MD4 Craig Livingstone Elvis X-Ran: JI[bA0fZ]o~Owc/(Idh8wuSlv'|]=_B%9n1,NhR43Ap&AXLNGfF`sv~pFB2E-7[>$Zv>e3 X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sun, 30 Nov 2014 14:57:11 -0500 In-Reply-To: <87bnnpne57.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Sun, 30 Nov 2014 11:04:04 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19226 Cc: 19226@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ivan Shmakov wrote: > * eww.el (eww-mode): Autoload, as expected by desktop.el. Then IMO desktop.el should autoload it, rather than adding a general autoload cookie. (Yes, this may be inconsistent with some existing cases.) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 15:16:06 2014 Received: (at 19226) by debbugs.gnu.org; 30 Nov 2014 20:16:06 +0000 Received: from localhost ([127.0.0.1]:50165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvAub-0005DJ-Rw for submit@debbugs.gnu.org; Sun, 30 Nov 2014 15:16:06 -0500 Received: from fely.am-1.org ([78.47.74.50]:42962) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvAuY-0005Ck-Ic for 19226@debbugs.gnu.org; Sun, 30 Nov 2014 15:16:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=+yQkEMAd8DwNX0XInhjEoWx+sHf4fVwZILP2Va7pc8Q=; b=kO6uYi1IcGwdS4XMPh+wlFI2SuwX5n+uzxjHbu2U0rJ327aqE5DNiZrACQ8YVZqKoMXvCWKj10xL/SGuNwVgtmrGB3LB+olgly2PMtMn3n65Z11eUhfWfCGP9jHuNY+d883DE/1baDU37IVMq1bKtnVmHD6h3rVwh4/928BuvU4=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvAuU-0003MU-0k for 19226@debbugs.gnu.org; Sun, 30 Nov 2014 20:15:58 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvAuM-0005uZ-IA for 19226@debbugs.gnu.org; Mon, 01 Dec 2014 03:15:50 +0700 From: Ivan Shmakov To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> Mail-Followup-To: 19226@debbugs.gnu.org Date: Sun, 30 Nov 2014 20:15:49 +0000 In-Reply-To: (Glenn Morris's message of "Sun, 30 Nov 2014 14:57:11 -0500") Message-ID: <87mw78molm.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Glenn Morris writes: >>>>> Ivan Shmakov wrote: >> * eww.el (eww-mode): Autoload, as expected by desktop.el. > Then IMO desktop.el should autoload it, rather than adding a general > autoload cookie. That=E2=80=99s the point: as currently implemented, desktop.el uses a general autoload cookie to map major modes (as preserved in the desktop file) to Emacs features to load before handling any given buffer. Consider, for instance: 514 Modules that define a major mode that needs a special handler should= contain 515 code like 516=09 517 (defun foo-restore-desktop-buffer 518 ... 519 (add-to-list 'desktop-buffer-mode-handlers 520 '(foo-mode . foo-restore-desktop-buffer)) 521=09 522 Furthermore the major mode function must be autoloaded.") =E2=80=A6 1319 (defun desktop-load-file (function) 1320 "Load the file where auto loaded FUNCTION is defined." 1321 (when (fboundp function) 1322 (autoload-do-load (symbol-function function) function))) =E2=80=A6 (See also the uses of desktop-load-file in desktop.el.) > (Yes, this may be inconsistent with some existing cases.) As for the existing cases, the change suggested exactly matches info.el: 4222 ;; Autoload cookie needed by desktop.el 4223 ;;;###autoload 4224 (define-derived-mode Info-mode nil "Info" ;FIXME: Derive from specia= l-mode? =E2=80=A6 4312 (setq-local bookmark-make-record-function #'Info-bookmark-make-rec= ord)) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 21:22:18 2014 Received: (at 19226) by debbugs.gnu.org; 1 Dec 2014 02:22:18 +0000 Received: from localhost ([127.0.0.1]:50243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvGcz-0002SI-Ou for submit@debbugs.gnu.org; Sun, 30 Nov 2014 21:22:17 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:43624) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvGcw-0002S3-Rt for 19226@debbugs.gnu.org; Sun, 30 Nov 2014 21:22:15 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XvGcv-0006U8-Ug; Sun, 30 Nov 2014 21:22:14 -0500 From: Glenn Morris To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> X-Spook: e-cash Putin SAFE Rule Psix BATF Lon Horiuchi terrorism X-Ran: j)Ep215[+(s\Yc%0r{/i=ony~/Ii{jbq4m[aRJ~ (Ivan Shmakov's message of "Sun, 30 Nov 2014 20:15:49 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Come to think of it, desktop mode could solve this itself: When restoring foo-mode, if foo-mode is not bound, try requiring foo. That would solve this case and many others. For a complete solution, when desktop saves a major/minor mode to restore, it could also save the name of the library that defines the mode. When restoring, first of all require that library. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 01 00:59:52 2014 Received: (at 19226) by debbugs.gnu.org; 1 Dec 2014 05:59:52 +0000 Received: from localhost ([127.0.0.1]:50305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvK1Y-0001I3-D4 for submit@debbugs.gnu.org; Mon, 01 Dec 2014 00:59:52 -0500 Received: from fely.am-1.org ([78.47.74.50]:43010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvK1W-0001Ht-22 for 19226@debbugs.gnu.org; Mon, 01 Dec 2014 00:59:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=DbFBCrmPqPEZvoFx5OUDkufL1FvvLy6xAArpEifYjcs=; b=CygVU9zPQEsEquwFmSrkLsQkpLGIoC49dERJzq9aJSeqJPcf+c+hkMVjhspk1puzgpLq1G3TRwH8k7K1q9PWEDVTP0SqDXCtk3i242dRrwyMYAonHRZKQ2wMYUJop/NibVv19BZtwqoncnq9sG53JrAhS7fQEVTEKzmefFgn98A=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvK1T-0007rP-3i for 19226@debbugs.gnu.org; Mon, 01 Dec 2014 05:59:47 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XvK1L-0002NT-H4 for 19226@debbugs.gnu.org; Mon, 01 Dec 2014 12:59:39 +0700 From: Ivan Shmakov To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> Mail-Followup-To: 19226@debbugs.gnu.org Date: Mon, 01 Dec 2014 05:59:38 +0000 In-Reply-To: (Glenn Morris's message of "Sun, 30 Nov 2014 21:22:13 -0500") Message-ID: <87iohvnc51.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Glenn Morris writes: > Come to think of it, desktop mode could solve this itself: > When restoring foo-mode, if foo-mode is not bound, try requiring foo. > That would solve this case and many others. Yet will leave some unsolved. Such as, for instance, my own zealous-save-mode, defined in 'zealsave. > For a complete solution, when desktop saves a major/minor mode to > restore, it could also save the name of the library that defines the > mode. How would it obtain such information? Especially if the user has modified the -mode function code and used eval-defun to redefine it. (That=E2=80=99s also what I do at times.) > When restoring, first of all require that library. And fail miserably should the library be renamed. Moreover, =E2=80=9Cgeneral purpose=E2=80=9D modes are ought to be autoload= ed anyway. I see no reason to second-guess this case at the least. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 01 08:52:04 2014 Received: (at 19226) by debbugs.gnu.org; 1 Dec 2014 13:52:05 +0000 Received: from localhost ([127.0.0.1]:50513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvROW-0005zU-JR for submit@debbugs.gnu.org; Mon, 01 Dec 2014 08:52:04 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:33092) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvROU-0005zK-Gi for 19226@debbugs.gnu.org; Mon, 01 Dec 2014 08:52:02 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sB1Dq1sZ010348; Mon, 1 Dec 2014 08:52:01 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6FAE38675; Mon, 1 Dec 2014 08:52:01 -0500 (EST) From: Stefan Monnier To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only Message-ID: References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> <87iohvnc51.fsf@violet.siamics.net> Date: Mon, 01 Dec 2014 08:52:01 -0500 In-Reply-To: <87iohvnc51.fsf@violet.siamics.net> (Ivan Shmakov's message of "Mon, 01 Dec 2014 05:59:38 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5142=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5142> : inlines <1571> : streams <1350042> : uri <1836869> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> Come to think of it, desktop mode could solve this itself: It could, but I think this would be trying to be too clever. > Moreover, =E2=80=9Cgeneral purpose=E2=80=9D modes are ought to be autolo= aded > anyway. I see no reason to second-guess this case at the least. I tend to agree. If the major-mode is not autoloaded (as in the eww case), it's quite likely to be a special major mode that is better entered via some other function (e.g. store the URL and recreate the buffer via `eww' which will take care calling eww-mode (and loading any file that this may require)). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 07 13:57:05 2014 Received: (at 19226) by debbugs.gnu.org; 7 Dec 2014 18:57:05 +0000 Received: from localhost ([127.0.0.1]:56499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxh0y-0006vO-QA for submit@debbugs.gnu.org; Sun, 07 Dec 2014 13:57:05 -0500 Received: from fely.am-1.org ([78.47.74.50]:43817) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxh0w-0006vG-TK for 19226@debbugs.gnu.org; Sun, 07 Dec 2014 13:57:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=VJtBWl+WJZ7vrkFwKZbUUsO/gGLeAk0ZLe3Qz6LlUYk=; b=L9gWG/7usmqZ8/P6Oaaz281sdAysH4mr+JY3uV+EjGD358DImX3OLFQr9A5oeDnYL5hit+I8FgNcMH7MQsz3LiYAAaWHbKfFU8XnibG3VDPan12XM+gdbddIoJySaJqwyNjkrfYksuDOi5ByD2cwomKxDDFSMDQKiUngIs6ILfM=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xxh0u-0000AW-OZ for 19226@debbugs.gnu.org; Sun, 07 Dec 2014 18:57:01 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xxh0m-0005hw-Mq for 19226@debbugs.gnu.org; Mon, 08 Dec 2014 01:56:52 +0700 From: Ivan Shmakov To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> <87iohvnc51.fsf@violet.siamics.net> Mail-Followup-To: 19226@debbugs.gnu.org Date: Sun, 07 Dec 2014 18:56:52 +0000 In-Reply-To: (Stefan Monnier's message of "Mon, 01 Dec 2014 08:52:01 -0500") Message-ID: <87sigrjnkb.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Stefan Monnier writes: [=E2=80=A6] >> Moreover, =E2=80=9Cgeneral purpose=E2=80=9D modes are ought to be autol= oaded anyway. >> I see no reason to second-guess this case at the least. > I tend to agree. If the major-mode is not autoloaded (as in the eww > case), it's quite likely to be a special major mode that is better > entered via some other function The problem here is that desktop.el should explicitly be pointed to the function to do all the special handling for the mode, which is (conventionally) done like: (add-to-list 'desktop-buffer-mode-handlers '(eww-mode . eww-restore-desktop)) The problem is: to get /that/ evaluated, desktop.el needs to first load eww.el, leading to a chicken and egg problem. The current implementation suggests it to be solved as follows: =E2=80=A2 the major mode is marked as autoloaded; =E2=80=A2 when desktop-read encounters a major mode which is not currently loaded, it loads the respective library (using desktop-load-file, which in turn calls autoload-do-load); =E2=80=A2 that library modifies desktop-buffer-mode-handlers as appropriate (see above.) The following =E2=80=9Cspecial=E2=80=9D modes explicitly document the use = of autoloads to satisfy this desktop.el requirement: $ grep -rF --include=3D\*.el -- needed\ by\ desktop.el lisp/=20 lisp/dired.el:;; Autoload cookie needed by desktop.el lisp/info.el:;; Autoload cookie needed by desktop.el lisp/mh-e/mh-folder.el:;; Autoload cookie needed by desktop.el $=20 The others (doc-view-mode?) do that quietly. And I guess there may be a few (vc-dir-mode?) that fail there. > (e. g. store the URL and recreate the buffer via `eww' which will > take care calling eww-mode (and loading any file that this may > require)). =E2=80=A6 Yet that=E2=80=99s by no means necessary, =E2=80=93 it=E2=80=99s= perfectly possible to invoke M-x eww-mode from just any (empty) buffer, and then use =E2=80=98G=E2=80=99 to point EWW to the Web page of interest. Hence, the trick mentioned in etc/NEWS isn=E2=80=99t necessary, either. *** You can now use several eww buffers in parallel by renaming eww buffers you want to keep separate. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 07 21:54:40 2014 Received: (at 19226) by debbugs.gnu.org; 8 Dec 2014 02:54:40 +0000 Received: from localhost ([127.0.0.1]:56751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxoT9-0003W4-SJ for submit@debbugs.gnu.org; Sun, 07 Dec 2014 21:54:40 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7381) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxoT7-0003Vs-Cp for 19226@debbugs.gnu.org; Sun, 07 Dec 2014 21:54:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjsPAOwQflRFxLi7/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBVigLCzQSFBgNiG4J1lkBAQgCIJB2FoQyBYsBkjGGUYssgXiCN4FiIYJ3AQEB X-IPAS-Result: AjsPAOwQflRFxLi7/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBVigLCzQSFBgNiG4J1lkBAQgCIJB2FoQyBYsBkjGGUYssgXiCN4FiIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="99822463" Received: from 69-196-184-187.dsl.teksavvy.com (HELO pastel.home) ([69.196.184.187]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Dec 2014 21:54:36 -0500 Received: by pastel.home (Postfix, from userid 20848) id 89F529896; Sun, 7 Dec 2014 21:54:36 -0500 (EST) From: Stefan Monnier To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only Message-ID: References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> <87iohvnc51.fsf@violet.siamics.net> <87sigrjnkb.fsf@violet.siamics.net> Date: Sun, 07 Dec 2014 21:54:36 -0500 In-Reply-To: <87sigrjnkb.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 07 Dec 2014 18:56:52 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The problem here is that desktop.el should explicitly be pointed > to the function to do all the special handling for the mode, > which is (conventionally) done like: > (add-to-list 'desktop-buffer-mode-handlers > '(eww-mode . eww-restore-desktop)) > The problem is: to get /that/ evaluated, desktop.el needs to > first load eww.el, leading to a chicken and egg problem. I see. Maybe the problem then is that desktop.el should be changed so that it records `eww-restore-desktop' as the handler function for this buffer in the desktop file. I.e. those desktop-buffer-mode-handlers should be looked up while *saving* the desktop file rather than while reading them. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 14:46:02 2014 Received: (at 19226) by debbugs.gnu.org; 9 Dec 2014 19:46:02 +0000 Received: from localhost ([127.0.0.1]:59971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyQjR-0004iD-BV for submit@debbugs.gnu.org; Tue, 09 Dec 2014 14:46:01 -0500 Received: from fely.am-1.org ([78.47.74.50]:44089) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyQjN-0004i2-JG for 19226@debbugs.gnu.org; Tue, 09 Dec 2014 14:45:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=FWxmmRHfvtOInvaJnqtSeIdLS2rVsdGkts4om6POGP8=; b=OtqaRkgToHHBGMYvUy5V+yNqTjZkgmHNwEG77NVtDRJFTemsfBWisnOX6ZMiYL8ANW4CMPtr8rl3bg8cfHIJFj3a3aHYcxpsogMD3HYOehnh2WPbMBAyGoy3SuKRrr9ruZo++jIf/8B5gX+umrTTCoS0hkKFmGDHgTUxYgB78/8=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XyQjL-0003aN-AU for 19226@debbugs.gnu.org; Tue, 09 Dec 2014 19:45:56 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XyQjE-0007c5-04 for 19226@debbugs.gnu.org; Wed, 10 Dec 2014 02:45:48 +0700 From: Ivan Shmakov To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> <87iohvnc51.fsf@violet.siamics.net> <87sigrjnkb.fsf@violet.siamics.net> Mail-Followup-To: 19226@debbugs.gnu.org Date: Tue, 09 Dec 2014 19:45:47 +0000 In-Reply-To: (Stefan Monnier's message of "Sun, 07 Dec 2014 21:54:36 -0500") Message-ID: <87r3w8ip3o.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Stefan Monnier writes: >> The problem here is that desktop.el should explicitly be pointed to >> the function to do all the special handling for the mode, which is >> (conventionally) done like: >> (add-to-list 'desktop-buffer-mode-handlers >> '(eww-mode . eww-restore-desktop)) >> The problem is: to get /that/ evaluated, desktop.el needs to first >> load eww.el, leading to a chicken and egg problem. > I see. Maybe the problem then is that desktop.el should be changed > so that it records `eww-restore-desktop' as the handler function for > this buffer in the desktop file. I. e. those > desktop-buffer-mode-handlers should be looked up while *saving* the > desktop file rather than while reading them. Yes. Yet I fail to see how that would be an improvement? First of all, we already can trigger .emacs.desktop incompatibility when the format of the value stored in there changes. Now, we also make that fail when it=E2=80=99s the /name/ of the handler function that changes. (I presume that the change in the mode name is much less likely on one side, and much more likely to get a defalias on the other.) Moreover, instead of (or, well, in addition to) an autoload for the mode function, we now need an autoload for the handler. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 19:35:54 2014 Received: (at 19226) by debbugs.gnu.org; 10 Dec 2014 00:35:54 +0000 Received: from localhost ([127.0.0.1]:60093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyVFy-0003d6-7q for submit@debbugs.gnu.org; Tue, 09 Dec 2014 19:35:54 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:59132) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyVFw-0003cz-KL for 19226@debbugs.gnu.org; Tue, 09 Dec 2014 19:35:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmkPAOwQflQXW5Ml/2dsb2JhbABbgweDYFCFCsUdBAICgSQXAQEBAQEBfIQDAQEDASMzKAsLGgIYDgICFBgNiG4JwAaWUwELIIErj0sWgl+BUwWLAZIxhlGNJII3gWIhgncBAQE X-IPAS-Result: AmkPAOwQflQXW5Ml/2dsb2JhbABbgweDYFCFCsUdBAICgSQXAQEBAQEBfIQDAQEDASMzKAsLGgIYDgICFBgNiG4JwAaWUwELIIErj0sWgl+BUwWLAZIxhlGNJII3gWIhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="100023525" Received: from 23-91-147-37.cpe.pppoe.ca (HELO pastel.home) ([23.91.147.37]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Dec 2014 19:35:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id B15DB72BD; Tue, 9 Dec 2014 19:35:50 -0500 (EST) From: Stefan Monnier To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only Message-ID: References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87mw78molm.fsf@violet.siamics.net> <87iohvnc51.fsf@violet.siamics.net> <87sigrjnkb.fsf@violet.siamics.net> <87r3w8ip3o.fsf@violet.siamics.net> Date: Tue, 09 Dec 2014 19:35:50 -0500 In-Reply-To: <87r3w8ip3o.fsf@violet.siamics.net> (Ivan Shmakov's message of "Tue, 09 Dec 2014 19:45:47 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Yes. Yet I fail to see how that would be an improvement? Maybe it's not worth the trouble, indeed. > changes. Now, we also make that fail when it=E2=80=99s the /name/ of > the handler function that changes. (I presume that the change > in the mode name is much less likely on one side, and much more > likely to get a defalias on the other.) The issue at hand was presumably that the buffer's mode (i.e. eww-mode) is not meant as a "normal entry point". So it's more normal to have to keep the name of the handler stable, since that is an explicit entry point. > Moreover, instead of (or, well, in addition to) an autoload for > the mode function, we now need an autoload for the handler. But this handler *is* a normal entry point. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 15:50:54 2015 Received: (at 19226) by debbugs.gnu.org; 14 Feb 2015 20:50:54 +0000 Received: from localhost ([127.0.0.1]:44202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMjfx-0000mI-I6 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 15:50:54 -0500 Received: from fely.am-1.org ([78.47.74.50]:43861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMjfu-0000m6-Cg for 19226@debbugs.gnu.org; Sat, 14 Feb 2015 15:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=PexBFnzeEQyXEacjgxVAk4GyDxXBBCovvmUv4u+BnbU=; b=HUn2aLM+4/YPTF4G9K+9dCIBZAFL8gUWPuWbzpSJdixSv3SHy1f+FJS02WvQuf7K6+dYW7zxnSe5gU8qxAhyK5IunaxzBZh46iOFZw6N5d6s2M/P2UJTG4+MORgAwOcDmQxRECvxzJjOLfLC9r+1G/9LR9Hi3SJhCt8bks+ZVBQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMjft-0005kq-51 for 19226@debbugs.gnu.org; Sat, 14 Feb 2015 20:50:49 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMjfm-0003FG-Fn for 19226@debbugs.gnu.org; Sun, 15 Feb 2015 03:50:42 +0700 From: Ivan Shmakov To: 19226@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> Mail-Followup-To: 19226@debbugs.gnu.org Date: Sat, 14 Feb 2015 20:50:41 +0000 In-Reply-To: <87bnnpne57.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Sun, 30 Nov 2014 11:04:04 +0000") Message-ID: <87pp9c9pzy.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19226 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The discussion, as it seems, have lead us nowhere. Would there be any objections against me pushing the (updated) fix sometime within the next two days, /as well as/ a couple of unrelated minor changes (both MIMEd)? (Somehow, I believe that the discussion over the possible desktop.el vs. special modes changes can safely be postponed until something specific is suggested.) TIA. Fix eww.el desktop support. * lisp/net/eww.el (eww-mode): Add autoload cookie. (eww-restore-desktop): Use inhibit-read-only. Fixes: debbugs:19226 Minor eww.el fixes. * lisp/net/eww.el (eww-suggest-uris): Add autoload cookie, so that add-hook works correctly even if the file is not yet loaded. (eww-list-histories): Do not pad the rightmost (URIs) column. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -686,6 +687,8 @@ map) "Tool bar for `eww-mode'.") +;; Autoload cookie needed by desktop.el. +;;;###autoload (define-derived-mode eww-mode special-mode "eww" "Mode for browsing the web." (setq-local eww-data (list :title "")) @@ -1877,8 +1880,9 @@ defun eww-restore-desktop (file-name buffer-name misc-data) (case eww-restore-desktop ((t auto) (eww (plist-get eww-data :url))) ((zerop (buffer-size)) - (insert (substitute-command-keys - eww-restore-reload-prompt)))))) + (let ((inhibit-read-only t)) + (insert (substitute-command-keys + eww-restore-reload-prompt))))))) ;; . (current-buffer))) --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -60,6 +60,7 @@ :group 'eww :type 'string) +;;;###autoload (defcustom eww-suggest-uris '(eww-links-at-point url-get-url-at-point @@ -1634,7 +1637,7 @@ defun eww-list-histories () (setq start (point)) (setq domain-length (max domain-length (length (plist-get history :url)))) (setq title-length (max title-length (length (plist-get history :title))))) - (setq format (format "%%-%ds %%-%ds" title-length domain-length) + (setq format (format "%%-%ds %%s" title-length) header-line-format (concat " " (format format "Title" "URL"))) (dolist (history eww-history-trans) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 14:12:21 2015 Received: (at 19226-done) by debbugs.gnu.org; 16 Feb 2015 19:12:21 +0000 Received: from localhost ([127.0.0.1]:45599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNR5g-0008IG-St for submit@debbugs.gnu.org; Mon, 16 Feb 2015 14:12:21 -0500 Received: from fely.am-1.org ([78.47.74.50]:44108) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNR5e-0008I7-VC for 19226-done@debbugs.gnu.org; Mon, 16 Feb 2015 14:12:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=riMsY0CmMDODlm9235umJZsShJTio7PcFDNd2eTfv0s=; b=HWXxOhj+TtlxiHOPLqrPYR3OnTosIxi2mlvCfBGrLQqBw5e8tCgnN7A7WfnB5VE/XWFwQpwwc1uERjMfWIeodebmohVPY/AvNmlrluosaExXMMucWlwC0klK2aYhZ1nOGMwzm2XAGXXi4qnEyGJQs/umWb4O6wItXrfYPiOCStM=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNR5d-0006ia-Ta for 19226-done@debbugs.gnu.org; Mon, 16 Feb 2015 19:12:18 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNR5W-0000Ig-18 for 19226-done@debbugs.gnu.org; Tue, 17 Feb 2015 02:12:10 +0700 From: Ivan Shmakov To: 19226-done@debbugs.gnu.org Subject: Re: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only References: <87bnst4fmc.fsf@violet.siamics.net> <87d28j7ajp.fsf@violet.siamics.net> <87bnnpne57.fsf_-_@violet.siamics.net> <87pp9c9pzy.fsf@violet.siamics.net> Mail-Followup-To: 19226@debbugs.gnu.org Date: Mon, 16 Feb 2015 19:12:09 +0000 In-Reply-To: <87pp9c9pzy.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 14 Feb 2015 20:50:41 +0000") Message-ID: <87wq3h8yd2.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19226-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Ivan Shmakov writes: [=E2=80=A6] > Would there be any objections against me pushing the (updated) fix > sometime within the next two days, /as well as/ a couple of unrelated > minor changes (both MIMEd)? Pushed, as there were no objections; closing. [=E2=80=A6] > (eww-list-histories): Do not pad the rightmost (URIs) column. =E2=80=A6 Except for this padding change, as the same change should probably be applied to eww-list-buffers at the same time. [=E2=80=A6] commit 8b36bfafeecf5f0578c64129be1d2017483b00f7 CommitDate: 2015-02-16 19:01:50 +0000 Add autoload cookie for the eww-suggest-uris variable. =20=20=20=20 * lisp/net/eww.el (eww-suggest-uris): Add autoload cookie, so that add-hook works correctly even if the file is not yet loaded. commit 2ea5364ca8d1a8dc3f8ac4c9a5ba5c7f03666258 CommitDate: 2015-02-16 18:55:02 +0000 Fix eww.el desktop support. =20=20=20=20 * lisp/net/eww.el (eww-mode): Add autoload cookie. (eww-restore-desktop): Use inhibit-read-only. =20=20=20=20 Fixes: debbugs:19226 --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Fri Aug 15 15:55:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Mar 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator