From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 04:59:46 2014 Received: (at submit) by debbugs.gnu.org; 30 Nov 2014 09:59:46 +0000 Received: from localhost ([127.0.0.1]:49563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xv1I6-0002MO-EX for submit@debbugs.gnu.org; Sun, 30 Nov 2014 04:59:46 -0500 Received: from fely.am-1.org ([78.47.74.50]:42913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xv1Hz-0002M9-99 for submit@debbugs.gnu.org; Sun, 30 Nov 2014 04:59:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=yH5htW/v8Bo3S8XXwuVSxGWMhF2Z37vtrrPxfEZnReI=; b=lfY5ZDymrlrFlpHhDEpX4SIiCoLj7dvRwDY8IDdoC6OTm2cNYg511eRChSmmtJzXu+JjYpGidQzYlNTjWN4MklqfQ6uigOO7qzNHnpZ8YamOoP18eqR3K2uHh5MEkrIrSOpAyfwtmlzP0iSpgibkq/MnN7w3RpjwD8kGXIg5KfU=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xv1Hi-0006xL-8V for submit@debbugs.gnu.org; Sun, 30 Nov 2014 09:59:18 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xv1Ha-0004EY-RY for submit@debbugs.gnu.org; Sun, 30 Nov 2014 16:59:10 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: eww-render: runs eww-after-render-hook in the (temporary) data buffer References: <87fvpmwint.fsf@violet.siamics.net> <87eh56dkdo.fsf@flea.lifelogs.com> <87d2knaf08.fsf@flea.lifelogs.com> <87a9fqy8q9.fsf@building.gnus.org> <871u12tyz8.fsf@violet.siamics.net> <87d28j8z67.fsf@violet.siamics.net> <87k32r7fje.fsf@violet.siamics.net> Date: Sun, 30 Nov 2014 09:59:10 +0000 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 19 Nov 2014 18:41:37 +0100") Message-ID: <87tx1hnh5d.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs >>>>> Lars Magne Ingebrigtsen writes: >>>>> Ivan Shmakov writes: [=E2=80=A6] >> The plist-put calls down that progn are evaluated after >> eww-display-*, and thus after either eww-setup-buffer or some other >> set-buffer. The eww-use-external-browser-for-content-type case I=E2=80= =99m >> unsure about, though. > I've now removed the statement. Following the change for eww-display-* /not/ to change the current buffer ($ git log entry MIMEd), those forms are now also evaluated in the data buffer. 283 (defun eww-render (status url &optional point buffer encode) =E2=80=A6 287 (let* ((headers (eww-parse-headers)) =E2=80=A6 298 (data-buffer (current-buffer))) 299 (unwind-protect 300 (progn =E2=80=A6 316 (plist-put eww-data :url url) 317 (setq eww-history-position 0) 318 (run-hooks 'eww-after-render-hook)) 319 (kill-buffer data-buffer)))) What=E2=80=99s even worse is that the call to eww-after-render-hook is among them, and thus the code there has no (easy) way of finding the EWW buffer proper; consider, e. g.: (add-hook 'eww-after-render-hook (lambda () (message "Called in: %S" (current-buffer)))) Called in: # There=E2=80=99re two obvious ways to deal with the issues with eww-data and eww-history-position: =E2=80=A2 they could be wrapped into a (with-current-buffer buffer =E2=80= =A6) form in eww-render; =E2=80=A2 or they could be moved from there to eww-display-raw, -image, and -pdf; (eww-display-html already has them.) The eww-after-render-hook case is a bit trickier, as I=E2=80=99d rather prefer having some easy way to access /either/ of the buffers from the functions referenced. For instance, I=E2=80=99d like to have a way to capture the HTTP header and provide a command to present it to the user when asked. (I doubt this feature really belongs to the EWW =E2=80=9Ccore,=E2=80=9D so doing it from the hook looks sensibl= e.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/plain Content-Disposition: inline commit 6fd82d61a2b82e772e8cde0e04516f5c3ca98ed3 Author: Lars Magne Ingebrigtsen Date: Sun Nov 23 17:22:41 2014 +0100 Switch to the *eww* buffer immediately to avoid doing it asynchronously (eww): Pop to the *eww* buffer immediately after executing the `M-x eww' command to avoid having buffers pop up later. (eww-display-html): Don't pop the *eww* buffer. (eww-display-raw): Ditto. (eww-display-image): Ditto. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 30 05:46:12 2014 Received: (at 19225) by debbugs.gnu.org; 30 Nov 2014 10:46:12 +0000 Received: from localhost ([127.0.0.1]:49570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xv212-0003WX-B7 for submit@debbugs.gnu.org; Sun, 30 Nov 2014 05:46:12 -0500 Received: from fely.am-1.org ([78.47.74.50]:42919) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xv20r-0003Vg-0a; Sun, 30 Nov 2014 05:46:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=FufxlWpSYod9klhLLVKiZgVU1/uVWb4QK1eKthysaE8=; b=eR2hNyxV7UFev+5MiTqSUccbm/0nDuiWjTUvtacqcq/guigOX7O1p/eNNvb78xxwoDVrPhZDJbdYDJr/mYuvzGkam1pS8Xp316WQEtDAY9BuO+Brh0Hk+4QCjwRCC2tq6316JMSjDdlwkDyY5DZy2c4UNPIWgSkoVQPIZ1aGX5k=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xv20o-0007IQ-V6; Sun, 30 Nov 2014 10:45:55 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xv20h-0004O6-Kq; Sun, 30 Nov 2014 17:45:47 +0700 From: Ivan Shmakov To: 19225@debbugs.gnu.org, control@debbugs.gnu.org Subject: Re: bug#19225: eww-render: runs eww-after-render-hook in the (temporary) data buffer References: <87fvpmwint.fsf@violet.siamics.net> <87eh56dkdo.fsf@flea.lifelogs.com> <87d2knaf08.fsf@flea.lifelogs.com> <87a9fqy8q9.fsf@building.gnus.org> <871u12tyz8.fsf@violet.siamics.net> <87d28j8z67.fsf@violet.siamics.net> <87k32r7fje.fsf@violet.siamics.net> <87tx1hnh5d.fsf_-_@violet.siamics.net> Mail-Followup-To: 19225@debbugs.gnu.org Date: Sun, 30 Nov 2014 10:45:46 +0000 In-Reply-To: <87tx1hnh5d.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Sun, 30 Nov 2014 09:59:10 +0000") Message-ID: <87lhmtnezp.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19225 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable tags 19225 + patch thanks >>>>> Ivan Shmakov writes: >>>>> Lars Magne Ingebrigtsen writes: >>>>> Ivan Shmakov writes: [=E2=80=A6] >>> The plist-put calls down that progn are evaluated after >>> eww-display-*, and thus after either eww-setup-buffer or some other >>> set-buffer. The eww-use-external-browser-for-content-type case I=E2= =80=99m >>> unsure about, though. >> I've now removed the statement. > Following the change for eww-display-* /not/ to change the > current buffer ($ git log entry MIMEd), those forms are now also > evaluated in the data buffer. =E2=80=A6 As well as a couple of eww-update-header-line-format calls. Please consider the patch MIMEd. This one doesn=E2=80=99t pass the data buffer to eww-after-render-hook, and I hope this still could be resolved a bit later. * eww.el (eww-render): Call eww-update-header-line-format unconditionally and in the browsing buffer (was: data buffer); change eww-data and eww-history-position for the browsing buffer, and run eww-after-render-hook there, too. (eww-display-html): Do not call eww-update-header-line-format or change eww-data, eww-history-position (now done in eww-render.) 283 (defun eww-render (status url &optional point buffer encode) =E2=80=A6 287 (let* ((headers (eww-parse-headers)) =E2=80=A6 298 (data-buffer (current-buffer))) 299 (unwind-protect 300 (progn 301 (cond =E2=80=A6 310 ((string-match-p "\\`image/" (car content-type)) 311 (eww-display-image buffer) 312 (eww-update-header-line-format)) 313 (t 314 (eww-display-raw buffer encode) 315 (eww-update-header-line-format))) 316 (plist-put eww-data :url url) 317 (setq eww-history-position 0) 318 (run-hooks 'eww-after-render-hook)) 319 (kill-buffer data-buffer)))) [=E2=80=A6] --=20 FSF associate member #7257 np. Surrender =E2=80=94 Jami Sieber =E2=80=A6 3= 013 B6A0 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -308,14 +315,14 @@ defun eww-render (status url &optional point buffer encode) ((equal (car content-type) "application/pdf") (eww-display-pdf)) ((string-match-p "\\`image/" (car content-type)) - (eww-display-image buffer) - (eww-update-header-line-format)) + (eww-display-image buffer)) (t - (eww-display-raw buffer encode) - (eww-update-header-line-format))) - (plist-put eww-data :url url) - (setq eww-history-position 0) - (run-hooks 'eww-after-render-hook)) + (eww-display-raw buffer encode))) + (with-current-buffer buffer + (plist-put eww-data :url url) + (eww-update-header-line-format) + (setq eww-history-position 0) + (run-hooks 'eww-after-render-hook))) (kill-buffer data-buffer)))) (defun eww-parse-headers () @@ -403,10 +411,7 @@ defun eww-display-html (charset url &optional document point buffer encode) (while (and (not (eobp)) (get-text-property (point) 'eww-form)) (forward-line 1))))) - (plist-put eww-data :url url) - (setq eww-history-position 0) - (eww-size-text-inputs) - (eww-update-header-line-format)))) + (eww-size-text-inputs)))) (defun eww-handle-link (dom) (let* ((rel (dom-attr dom 'rel)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 01 12:46:00 2014 Received: (at control) by debbugs.gnu.org; 1 Dec 2014 17:46:00 +0000 Received: from localhost ([127.0.0.1]:51005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvV2t-0004fd-MU for submit@debbugs.gnu.org; Mon, 01 Dec 2014 12:45:59 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40155) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvV2q-0004fT-E9 for control@debbugs.gnu.org; Mon, 01 Dec 2014 12:45:57 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XvV2V-0000mt-TN for control@debbugs.gnu.org; Mon, 01 Dec 2014 18:45:35 +0100 Date: Mon, 01 Dec 2014 18:45:35 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #19227 X-MailScanner-ID: 1XvV2V-0000mt-TN X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418060736.09602@EKb4OQ+bpMDbMKSWrllF7w X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) forcemerge 19227 19225 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 01 12:56:50 2014 Received: (at 19225) by debbugs.gnu.org; 1 Dec 2014 17:56:50 +0000 Received: from localhost ([127.0.0.1]:51033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvVDO-0004xG-0z for submit@debbugs.gnu.org; Mon, 01 Dec 2014 12:56:50 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:34321) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvVDM-0004x6-8L for 19225@debbugs.gnu.org; Mon, 01 Dec 2014 12:56:48 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XvVD4-0000vs-Fm for 19225@debbugs.gnu.org; Mon, 01 Dec 2014 18:56:30 +0100 From: Lars Magne Ingebrigtsen To: 19225@debbugs.gnu.org Subject: Re: bug#19225: eww-render: runs eww-after-render-hook in the (temporary) data buffer References: <87fvpmwint.fsf@violet.siamics.net> <87eh56dkdo.fsf@flea.lifelogs.com> <87d2knaf08.fsf@flea.lifelogs.com> <87a9fqy8q9.fsf@building.gnus.org> <871u12tyz8.fsf@violet.siamics.net> <87d28j8z67.fsf@violet.siamics.net> <87k32r7fje.fsf@violet.siamics.net> <87tx1hnh5d.fsf_-_@violet.siamics.net> <87lhmtnezp.fsf@violet.siamics.net> X-Now-Playing: Steely Dan's _Aja_: "Deacon Blues" X-Hashcash: 1:23:141201:19225@debbugs.gnu.org::me/hWKrZ4FaBX6NY:0000000000000000000000000000000000000000GgZ9 Date: Mon, 01 Dec 2014 18:56:30 +0100 In-Reply-To: <87lhmtnezp.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 30 Nov 2014 10:45:46 +0000") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MailScanner-ID: 1XvVD4-0000vs-Fm X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418061390.76123@J5wM/XGX7ToAhY5Opr52bg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19225 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ivan Shmakov writes: > Please consider the patch MIMEd. This one doesn=92t pass the data > buffer to eww-after-render-hook, and I hope this still could be > resolved a bit later. Thanks; applied. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 01 12:56:52 2014 Received: (at control) by debbugs.gnu.org; 1 Dec 2014 17:56:52 +0000 Received: from localhost ([127.0.0.1]:51036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvVDQ-0004xV-Hf for submit@debbugs.gnu.org; Mon, 01 Dec 2014 12:56:52 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:34326) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XvVDP-0004xO-65 for control@debbugs.gnu.org; Mon, 01 Dec 2014 12:56:51 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XvVD7-0000w2-DG for control@debbugs.gnu.org; Mon, 01 Dec 2014 18:56:33 +0100 Date: Mon, 01 Dec 2014 18:56:33 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #19225 X-MailScanner-ID: 1XvVD7-0000w2-DG X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418061393.85765@cc/bLCmiJxkTSdJI4l3GKg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 19225 fixed close 19225 25.1 From unknown Fri Jun 20 07:16:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Dec 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator