From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 26 12:56:11 2014 Received: (at submit) by debbugs.gnu.org; 26 Nov 2014 17:56:11 +0000 Received: from localhost ([127.0.0.1]:46485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtgp0-0004RX-Ov for submit@debbugs.gnu.org; Wed, 26 Nov 2014 12:56:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50927) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtgoy-0004RP-Rp for submit@debbugs.gnu.org; Wed, 26 Nov 2014 12:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xtgos-0001T2-OH for submit@debbugs.gnu.org; Wed, 26 Nov 2014 12:56:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtgos-0001Sk-L6 for submit@debbugs.gnu.org; Wed, 26 Nov 2014 12:56:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtgoo-0003Ke-G5 for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 12:56:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xtgon-0001RG-Gx for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 12:55:58 -0500 Received: from teruel.switch.ch ([2001:620:0:1b::28]:47693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtgon-0001Qp-7y for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 12:55:57 -0500 Received: from surlej.switch.ch (surlej.switch.ch [IPv6:2001:620:0:e::69]) by teruel.switch.ch (8.14.4/8.14.4/Debian-4) with ESMTP id sAQHoHoA027522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 26 Nov 2014 18:50:18 +0100 Received: from [2001:620:0:68::106] (helo=macsl.switch.ch) by surlej.switch.ch with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1XtgjI-0000dN-VX; Wed, 26 Nov 2014 18:50:17 +0100 From: Simon Leinen To: bug-gnu-emacs@gnu.org Subject: 25.0.50; vc.el with RCS: `vc-master-name' returns nil where it shouldn't Date: Wed, 26 Nov 2014 18:50:16 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-CanIt-Geo: ip=2001:620:0:e::69; country=CH X-CanItPRO-Stream: switch-ch:outbound (inherits from switch-ch:default, base:default) X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: "Eric S. Raymond" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When I start ./src/emacs -Q freshly compiled from the Git source (with the vc-filewise autoload patches included in my last report) and try to open a file under RCS, I get an error Wrong type argument: stringp, nil with a backtrace such as this: Debugger entered--Lisp error: (wrong-type-argument stringp nil) file-exists-p(nil) vc-insert-file(nil "^[0-9]") vc-rcs-fetch-master-state("/Users/leinen/public_html/private/log.html" nil) vc-rcs-state("/Users/leinen/public_html/private/log.html") vc-rcs-state-heuristic("/Users/leinen/public_html/private/log.html") apply(vc-rcs-state-heuristic "/Users/leinen/public_html/private/log.html") vc-call-backend(RCS state-heuristic "/Users/leinen/public_html/private/log.html") vc-state-refresh("/Users/leinen/public_html/private/log.html" RCS) vc-state("/Users/leinen/public_html/private/log.html" RCS) vc-default-mode-line-string(RCS "/Users/leinen/public_html/private/log.html") apply(vc-default-mode-line-string RCS "/Users/leinen/public_html/private/log.html") vc-call-backend(RCS mode-line-string "/Users/leinen/public_html/private/log.html") vc-mode-line("/Users/leinen/public_html/private/log.html" RCS) vc-find-file-hook() run-hooks(find-file-hook) after-find-file(nil t) find-file-noselect-1(# "~/public_html/private/log.html" nil nil "~/www/html/misc/leinen/private/log.html" (18988536 16777220)) find-file-noselect("~/public_html/private/log.html" nil nil t) find-file("~/public_html/private/log.html" t) `vc-rcs-fetch-master-state' uses `vc-master-name' (in vc-filewise.el) to find the master filename for the visited file. `vc-master-name' calls the 'registered method for the file's backend (the symbol `RCS' in this case), which is successful, and then returns the file's `vc-name' property. But that property isn't set anywhere. I found that the function `vc-filewise-registered' also claims to check whether a file is registered, and it sets the `vc-name' property on the file. So that looks more suitable to use. It also does other things that I don't quite understand. Anyway, the following patch prevents the error for me, and lets me edit and check in/out RCS-managed files again. -- Simon. diff --git a/lisp/vc/vc-filewise.el b/lisp/vc/vc-filewise.el index bc8a8de..4a05c98 100644 --- a/lisp/vc/vc-filewise.el +++ b/lisp/vc/vc-filewise.el @@ -41,7 +41,7 @@ If the file is not registered, or the master name is not known, return nil." ;; vc-BACKEND-registered explicitly (let ((backend (vc-backend file))) (if (and backend - (vc-call-backend backend 'registered file)) + (vc-filewise-registered backend file)) (vc-file-getprop file 'vc-name))))) (defun vc-rename-master (oldmaster newfile templates) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 03 10:06:09 2019 Received: (at 19197) by debbugs.gnu.org; 3 Aug 2019 14:06:09 +0000 Received: from localhost ([127.0.0.1]:59675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htufg-0005cR-QN for submit@debbugs.gnu.org; Sat, 03 Aug 2019 10:06:09 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htuff-0005cD-0J for 19197@debbugs.gnu.org; Sat, 03 Aug 2019 10:06:07 -0400 Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htufa-00050x-D7; Sat, 03 Aug 2019 16:06:04 +0200 From: Lars Ingebrigtsen To: Simon Leinen Subject: Re: bug#19197: 25.0.50; vc.el with RCS: `vc-master-name' returns nil where it shouldn't References: Date: Sat, 03 Aug 2019 16:06:01 +0200 In-Reply-To: (Simon Leinen's message of "Wed, 26 Nov 2014 18:50:16 +0100") Message-ID: <87d0hmibsm.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Simon Leinen writes: > When I start ./src/emacs -Q freshly compiled from the Git source (with > the vc-filewise autoload patches included in my last report) and try to > open a file under RCS, I get an error > > Wrong typ [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19197 Cc: "Eric S. Raymond" , 19197@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Simon Leinen writes: > When I start ./src/emacs -Q freshly compiled from the Git source (with > the vc-filewise autoload patches included in my last report) and try to > open a file under RCS, I get an error > > Wrong type argument: stringp, nil > > with a backtrace such as this: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > file-exists-p(nil) > vc-insert-file(nil "^[0-9]") Looks like the patch was applied at the time, but I guess closing the bug report was forgotten, so I'm doing that now. commit 4e0f8f7b2da47a59da317ebcc5c85ef9d3ee3b68 Author: Simon Leinen Date: Wed Nov 26 13:22:35 2014 -0500 Fix for vc-filewise.el unresolved-call glitch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 03 10:06:13 2019 Received: (at control) by debbugs.gnu.org; 3 Aug 2019 14:06:13 +0000 Received: from localhost ([127.0.0.1]:59678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htufl-0005ci-3c for submit@debbugs.gnu.org; Sat, 03 Aug 2019 10:06:13 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htufi-0005cZ-IJ for control@debbugs.gnu.org; Sat, 03 Aug 2019 10:06:12 -0400 Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htufg-000514-0X for control@debbugs.gnu.org; Sat, 03 Aug 2019 16:06:10 +0200 Date: Sat, 03 Aug 2019 16:06:07 +0200 Message-Id: <87blx6ibsg.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19197 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 19197 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 19197 quit From unknown Tue Jun 24 03:27:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Sep 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator