GNU bug report logs - #19186
[PATCH] OS/2 patches

Previous Next

Full log

Message #23 received at 19186 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: KO Myung-Hun <komh78 <at> gmail.com>
Cc: 19186 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches
Date: Fri, 12 Dec 2014 07:56:29 -0800

On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
> Jim Meyering wrote:
>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78 <at> gmail.com> wrote:
>>> Hi/2.
>>>
>>> These are OS/2 patches.
>>>
>>> Review, please...
>>>
>>> [PATCH 1/2] build: use quotation mark(") for PATH
>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
>>
>> I saw no patches here, but was able to dig them out of the
>> bug-tracking system at http://debbugs.gnu.org/19186.
>> I have applied and pushed the first one.  Thank you.
>>
>> However, for the second, my inclination is that if at all possible,
>> it should be fixed via an lseek replacement that does something
>> more sensible. Of course, that may not be possible, but from
>> what you've presented so far, I cannot tell. Please demonstrate
>> a use of diff that shows how OS/2+kLIBC's lseek fails.
>
> Do you want this ?
>
> -----
> $ cat file | diff - file
> diff.exe: -: Invalid seek
> -----

Yes.  Thanks. That shows how lseek-pipe fails on your system.
Please adjust your patch to make diff ignore failure only in that case,
i.e., when errno == EINVAL (assuming strerror(EINVAL)
produces that diagnostic).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.