From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 25 21:31:03 2014 Received: (at submit) by debbugs.gnu.org; 26 Nov 2014 02:31:03 +0000 Received: from localhost ([127.0.0.1]:45439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtSNi-0000oQ-Qw for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:31:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51123) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtSMs-0000li-4d for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtSMj-0000I2-53 for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_05, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMj-0000Hy-1s for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMa-0002za-0P for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:30:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtSMR-0000GH-0S for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:51 -0500 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:49993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMQ-0000GC-Pf for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:42 -0500 Received: by mail-pa0-f48.google.com with SMTP id rd3so1824926pab.35 for ; Tue, 25 Nov 2014 18:29:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=jMnQ5ISEp1OgNrFDdz7scxuFPyZHPdbnaYve+ujeqHM=; b=EhfqzKj60fT5YGp8M6JOClH7rBlsphD9vTkcUdpn6hfdf58Vd3/LpgYZZ3axQAevjv LLQw+Y6OAAZrNyn1VNLR7qgMn57xrSr3RqCntt2g3l3DuPNCgrr2FMJ2fxVKrCKgBe4Z H17wRo5/bikGI3Jvwlm/2OXqGCk4Dm2tPG/rQsQG+6T6W7q1yQrjAykPssIoQGOCPfsH xKtJBQRpyp6k7V1FIUq20z08Pxj5AXcIz5ec6ggmxruJBCwAFZojZ7kOrhmqwtKbKzGn E5E9EPMhHhUwiWxJ2vL4BDtqkkWJNnmZwHfLTH4EPnoXGgJzCRYpkz1fnu/rTrdFVIu0 beqw== X-Received: by 10.68.197.138 with SMTP id iu10mr48218856pbc.143.1416968981944; Tue, 25 Nov 2014 18:29:41 -0800 (PST) Received: from localhost.localdomain ([211.244.64.26]) by mx.google.com with ESMTPSA id ev8sm2717969pdb.28.2014.11.25.18.29.39 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 25 Nov 2014 18:29:40 -0800 (PST) From: KO Myung-Hun X-Google-Original-From: KO Myung-Hun To: bug-diffutils@gnu.org Subject: [PATCH] OS/2 patches Date: Wed, 26 Nov 2014 11:29:37 +0900 Message-Id: <1416968979-56894-1-git-send-email-komh@chollian.net> X-Mailer: git-send-email 1.8.5.2 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 25 Nov 2014 21:31:01 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Hi/2. These are OS/2 patches. Review, please... [PATCH 1/2] build: use quotation mark(") for PATH [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 25 22:27:48 2014 Received: (at submit) by debbugs.gnu.org; 26 Nov 2014 03:27:48 +0000 Received: from localhost ([127.0.0.1]:45475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtTGd-0003dX-JC for submit@debbugs.gnu.org; Tue, 25 Nov 2014 22:27:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51030) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtSMm-0000kH-20 for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtSMg-0000Hm-7m for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMg-0000Hi-4V for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:29:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMa-0002zb-CF for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtSMT-0000Gh-Ci for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:52 -0500 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:33571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMT-0000Gb-5K for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:45 -0500 Received: by mail-pa0-f46.google.com with SMTP id lj1so1833586pab.5 for ; Tue, 25 Nov 2014 18:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=5gwebFLb2hOXE5D8EyCtfm0hf7FHhpicY7k+2AmL0yk=; b=TsZcrx9qWwUNfyXOg1voql9rLz5vk3YJ5h+xb/xilSMUkq9oj48VJczKNPjnTehVTR ocueJFRmAewsxt/7xtkV1AJRUTvg1HoYZtvdGtdYriq1gBWB2HA4uxjTSn1BLq2QBa13 f162ruXVexpymXhMYHkvbSSwmX+z1JmwtRNodFmfMAm4urfJHXPxELmYen1jCRclfK8+ iB65gKqw7NlaKYUjVXG3xN0Mtg4k9BzlyMxbixtY2TsLB/pqOxbxTYheiwsvkAX1ilEH mobnk5iFSqda5LYCkyP86GyfiYvJPAm1cje6VHVwsrMNjEQFnEeAorMA7c/lBFKNwlY6 jQNg== X-Received: by 10.66.119.175 with SMTP id kv15mr49865849pab.30.1416968984277; Tue, 25 Nov 2014 18:29:44 -0800 (PST) Received: from localhost.localdomain ([211.244.64.26]) by mx.google.com with ESMTPSA id ev8sm2717969pdb.28.2014.11.25.18.29.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 25 Nov 2014 18:29:43 -0800 (PST) From: KO Myung-Hun X-Google-Original-From: KO Myung-Hun To: bug-diffutils@gnu.org Subject: [PATCH 1/2] build: use quotation mark(") for PATH Date: Wed, 26 Nov 2014 11:29:38 +0900 Message-Id: <1416968979-56894-2-git-send-email-komh@chollian.net> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1416968979-56894-1-git-send-email-komh@chollian.net> References: <1416968979-56894-1-git-send-email-komh@chollian.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 25 Nov 2014 22:27:46 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) * man/Makefile.am (dist_man1_MANS): On OS/2, PATH_SEPARATOR is ';', and sh recognizes it as a mark of EOL. To avoid this, quote it. --- man/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/Makefile.am b/man/Makefile.am index 02cd761..36eb35f 100644 --- a/man/Makefile.am +++ b/man/Makefile.am @@ -29,6 +29,6 @@ sdiff.1: $S/sdiff.c sdiff.x $(dist_man1_MANS): $(SRC_VERSION_C) help2man $(AM_V_GEN)base=`expr $@ : '\(.*\).1'` \ && (echo '[NAME]' && sed 's@/\* *@@; s/-/\\-/; q' $S/$$base.c) \ - | PATH=..$(PATH_SEPARATOR)$$PATH \ + | PATH="..$(PATH_SEPARATOR)$$PATH" \ $(srcdir)/help2man -i - -i $(srcdir)/$$base.x \ -S '$(PACKAGE) $(VERSION)' $$base > $@-t && mv $@-t $@ -- 1.8.5.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 25 22:27:48 2014 Received: (at submit) by debbugs.gnu.org; 26 Nov 2014 03:27:48 +0000 Received: from localhost ([127.0.0.1]:45477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtTGe-0003da-Bu for submit@debbugs.gnu.org; Tue, 25 Nov 2014 22:27:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51175) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtSMx-0000mL-7s for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtSMo-0000VD-67 for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMo-0000V2-3v for submit@debbugs.gnu.org; Tue, 25 Nov 2014 21:30:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMf-0002ze-1x for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:30:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtSMV-0000Gv-O7 for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:56 -0500 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:51304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtSMV-0000Gr-GU for bug-diffutils@gnu.org; Tue, 25 Nov 2014 21:29:47 -0500 Received: by mail-pa0-f41.google.com with SMTP id rd3so1831098pab.28 for ; Tue, 25 Nov 2014 18:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=jPznhLDQAKFIlfudy92KtgIVxmQIxzVrMziW0d79Wj0=; b=mixXaYk1pa2hkMWZ37+GPMz20eLD9drQ1YpQ3LZLVlIJp89J/7Zw3KpAcZan5n3cTz A2k687FTDEF3PUEpnc4jZ3ICM64voDmuPxqSsXiizwKkJse9VC4gkozVJQ80ik7jLtA+ +oeJnDBVtiUrJRdrdFgDHPPQfu3t30MBE+/zWhb4CoQiR5+BbhrQyzCf22QRClNaXcC4 /2Nog2plku37KDMYEtnDrLuJ8hCSnp/GxTNE5E0w6fQj+s6JZbTnMsKDK6ODDtYzSIM8 tcAHQy/lZvatjgO/qeCQavnVvAIW8k5DSmaW4p2KQrlCjls0CklBK9tadpDKrDgEYqTt Md7w== X-Received: by 10.67.14.36 with SMTP id fd4mr48540470pad.79.1416968986799; Tue, 25 Nov 2014 18:29:46 -0800 (PST) Received: from localhost.localdomain ([211.244.64.26]) by mx.google.com with ESMTPSA id ev8sm2717969pdb.28.2014.11.25.18.29.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 25 Nov 2014 18:29:45 -0800 (PST) From: KO Myung-Hun X-Google-Original-From: KO Myung-Hun To: bug-diffutils@gnu.org Subject: [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC Date: Wed, 26 Nov 2014 11:29:39 +0900 Message-Id: <1416968979-56894-3-git-send-email-komh@chollian.net> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1416968979-56894-1-git-send-email-komh@chollian.net> References: <1416968979-56894-1-git-send-email-komh@chollian.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 25 Nov 2014 22:27:46 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) This fixes the problem that 'diff - file' fails due to seek failure, because seek does not work on stdin on OS/2 kLIBC. * src/io.c (sip): Set skip_test to true if seek is not possible on OS/2 kLIBC. --- src/io.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/io.c b/src/io.c index 05a898c..75c39a9 100644 --- a/src/io.c +++ b/src/io.c @@ -108,6 +108,11 @@ sip (struct file_data *current, bool skip_test) PTRDIFF_MAX - 2 * sizeof (word)); current->buffer = xmalloc (current->bufsize); +#ifdef __KLIBC__ + /* Skip test if seek is not possible */ + skip_test = skip_test || lseek (current->desc, 0, SEEK_CUR) < 0; +#endif + if (! skip_test) { /* Check first part of file to see if it's a binary file. */ -- 1.8.5.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 01:08:28 2014 Received: (at 19186) by debbugs.gnu.org; 9 Dec 2014 06:08:28 +0000 Received: from localhost ([127.0.0.1]:58485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyDyG-0004vJ-CX for submit@debbugs.gnu.org; Tue, 09 Dec 2014 01:08:28 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:44690) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyDyE-0004vC-N5 for 19186@debbugs.gnu.org; Tue, 09 Dec 2014 01:08:27 -0500 Received: by mail-pa0-f42.google.com with SMTP id et14so6786876pad.1 for <19186@debbugs.gnu.org>; Mon, 08 Dec 2014 22:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:message-id:date:user-agent:mime-version:newsgroups:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Us8Oy3kgHZI5GQ+XOc883rmHanqunLGVdsJPmYvJYCA=; b=lVJS/WwEnFvwmC1v19v77I4BeWcQuI0zDk6VuKwEnyVt3s+bBfVY04fm2CtpcNeWdh Ngavbl2lEAzv0c3RapZmNYh3cMCw1D3qEPtZkrhdf4JFl9zEsXpwfDSXXQLyI0Fix9Jk lt6TXa3x8u815uqNFycPjCcswk80ejV+5PT2Wg38Kt16FPsqEkJEgyxkg8fabR1VotrF ArOgAIY2F2zm+erGCH0L4u7pwCRTk9wLVaK7hBzvHNTim9bCjEqChZVPHqXURcxvDosH b2rFYrTWeChWIgxElLMmkFQXDGt7OCcGMVvAkYSznizXhAHNF+/xD5egXYMFyEHrsnRs IaLA== X-Received: by 10.70.13.1 with SMTP id d1mr27888653pdc.132.1418105305815; Mon, 08 Dec 2014 22:08:25 -0800 (PST) Received: from [10.0.2.15] ([211.244.64.26]) by mx.google.com with ESMTPSA id f12sm336978pat.43.2014.12.08.22.08.23 for <19186@debbugs.gnu.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 08 Dec 2014 22:08:24 -0800 (PST) From: KO Myung-Hun X-Google-Original-From: KO Myung-Hun Message-ID: <548691D3.9060805@chollian.net> Date: Tue, 09 Dec 2014 15:08:19 +0900 User-Agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 MIME-Version: 1.0 Newsgroups: gmane.comp.gnu.diffutils.bugs To: 19186@debbugs.gnu.org Subject: Re: bug#19186: [PATCH] OS/2 patches References: <1416968979-56894-1-git-send-email-komh@chollian.net> In-Reply-To: <1416968979-56894-1-git-send-email-komh@chollian.net> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=EUC-KR Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19186 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Ping ? KO Myung-Hun wrote: > Hi/2. > > These are OS/2 patches. > > Review, please... > > [PATCH 1/2] build: use quotation mark(") for PATH > [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC > > > > -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 09 10:58:33 2014 Received: (at 19186) by debbugs.gnu.org; 9 Dec 2014 15:58:33 +0000 Received: from localhost ([127.0.0.1]:59836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyNBI-0005yg-Rh for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:58:33 -0500 Received: from mail-yk0-f182.google.com ([209.85.160.182]:55664) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyNBF-0005yW-V9 for 19186@debbugs.gnu.org; Tue, 09 Dec 2014 10:58:30 -0500 Received: by mail-yk0-f182.google.com with SMTP id 131so377709ykp.13 for <19186@debbugs.gnu.org>; Tue, 09 Dec 2014 07:58:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=/RQq4HwvXWCg3rIfd4dnNvQYoM5HaPzmCEBeDbDxdE4=; b=nSwO4Q1ruMPbb2Mo5+FynM0iaRsMnSYa3pF9Oe+i43nndxTgOqCY19kkBJvMv7lnRU gIyMf4DwMynZd/AqcGh385akh4q6DljnY3mjQ+XesTjS/LPnAWXTPl3H8nqPnRD7DYHl vL0EXg6gOY5a9h76qXrFAXVoYrMTuOzPr7DW1751I5ePn55wykU6SFnyp03FPDJkc0dv EoVf10b3TRARPbgzn50vrc4Hrl3e7hoO3POItcJlQlE5R5vwtpCff3XTWAbYWe8eHlmN PosXrez06P00P2MYhSVp/xWpH4+HdZvj3knSNBJ5UvdY+2f0cOiDCfaXIK5AVz5/RZfE 2QmA== X-Received: by 10.170.160.137 with SMTP id b131mr4174263ykd.92.1418140709268; Tue, 09 Dec 2014 07:58:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.139.67 with HTTP; Tue, 9 Dec 2014 07:58:09 -0800 (PST) In-Reply-To: <1416968979-56894-1-git-send-email-komh@chollian.net> References: <1416968979-56894-1-git-send-email-komh@chollian.net> From: Jim Meyering Date: Tue, 9 Dec 2014 07:58:09 -0800 X-Google-Sender-Auth: YFBlibrY_mEHKnn20YY6nA0j0os Message-ID: Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches To: KO Myung-Hun Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19186 Cc: 19186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: > Hi/2. > > These are OS/2 patches. > > Review, please... > > [PATCH 1/2] build: use quotation mark(") for PATH > [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC I saw no patches here, but was able to dig them out of the bug-tracking system at http://debbugs.gnu.org/19186. I have applied and pushed the first one. Thank you. However, for the second, my inclination is that if at all possible, it should be fixed via an lseek replacement that does something more sensible. Of course, that may not be possible, but from what you've presented so far, I cannot tell. Please demonstrate a use of diff that shows how OS/2+kLIBC's lseek fails. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 11 00:37:20 2014 Received: (at 19186) by debbugs.gnu.org; 11 Dec 2014 05:37:20 +0000 Received: from localhost ([127.0.0.1]:42239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XywRE-0005el-6H for submit@debbugs.gnu.org; Thu, 11 Dec 2014 00:37:20 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:51517) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XywRB-0005eS-H4 for 19186@debbugs.gnu.org; Thu, 11 Dec 2014 00:37:18 -0500 Received: by mail-pd0-f170.google.com with SMTP id v10so4307727pde.1 for <19186@debbugs.gnu.org>; Wed, 10 Dec 2014 21:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=7EZc1wQdPvtC1dLLnIXESkduIQCZZPDRiwFBjCZgBeA=; b=xIxiM4IvUzS8eK/GchesK+/nvANoLZVEo83QOnwaw3tfaZO8rGQ19Euofzt6PjlfFZ CKqjvG9hr/nKYftee07tOpnSqTdxDpXvQaiJEcHH6OZc+HDVkhgDbDkSoR8IPbK1XWQf wGKqDv9paO/yQhRLlzpsetEnvA3C1ukiVfZWFkngBjuCicpDZU0CrBgHisSDX1lRiTDG Ui/W3yvugrcEtqGn38lqBn4r0cNHRKMRxF1ueOGGKYsetoNJWIY7T/ltP5K/FhirI50o mybpNCp6rUhanlEcdbqE1r3sfwp8jn5msJbuJ/bJieSwV07w6rKDXkxGvEGNjPTI1lIa cKYA== X-Received: by 10.68.65.2 with SMTP id t2mr13817176pbs.39.1418276231423; Wed, 10 Dec 2014 21:37:11 -0800 (PST) Received: from [10.0.2.15] ([211.244.64.26]) by mx.google.com with ESMTPSA id zn2sm159057pbb.41.2014.12.10.21.37.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 21:37:10 -0800 (PST) Message-ID: <54892D87.9000206@gmail.com> Date: Thu, 11 Dec 2014 14:37:11 +0900 From: KO Myung-Hun User-Agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 MIME-Version: 1.0 To: Jim Meyering Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches References: <1416968979-56894-1-git-send-email-komh@chollian.net> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19186 Cc: 19186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Jim Meyering wrote: > On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: >> Hi/2. >> >> These are OS/2 patches. >> >> Review, please... >> >> [PATCH 1/2] build: use quotation mark(") for PATH >> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC > > I saw no patches here, but was able to dig them out of the > bug-tracking system at http://debbugs.gnu.org/19186. > I have applied and pushed the first one. Thank you. > > However, for the second, my inclination is that if at all possible, > it should be fixed via an lseek replacement that does something > more sensible. Of course, that may not be possible, but from > what you've presented so far, I cannot tell. Please demonstrate > a use of diff that shows how OS/2+kLIBC's lseek fails. Do you want this ? ----- $ cat file | diff - file diff.exe: -: Invalid seek ----- -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 10:56:59 2014 Received: (at 19186) by debbugs.gnu.org; 12 Dec 2014 15:56:59 +0000 Received: from localhost ([127.0.0.1]:44096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzSaQ-0005XM-O9 for submit@debbugs.gnu.org; Fri, 12 Dec 2014 10:56:58 -0500 Received: from mail-yk0-f177.google.com ([209.85.160.177]:45422) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzSaO-0005X6-Dt for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 10:56:56 -0500 Received: by mail-yk0-f177.google.com with SMTP id 9so3199287ykp.8 for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 07:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=HjpVchDveqhqeTTEYNxia/v1ElJ80AXMIlcUkU5TY5Y=; b=k+FAynqK/0kkbTLy7MeTb2wtQC0Rkaz2zeeTaRDtBeMBa1xETaiCPtEvurLbtNfrnE xgbl0RQGyfjytn00QcVgYuM8kS0RycOOqoiAtI31SO8bbG2U/6uvevJRoVF7KKLY1Omm 22YZShtrhpua6ij3lO9f8j1oIWPV0UW/pmnxcwCMktInYRzbjFruWp2AoAYtwd+20jmV XsFDL78uLoLzwXiGoYMj+mXbSMBai+h9Zu5LiSgH5O4inINQ7Xdvzh3382kGpTrBjxp3 TpKQRYr0L8rZy8f3DWVFrDz3pH0jkLUZrflyTNDjJIzAscxyzn5rmnKIrTm7UPQwDG7n pGKg== X-Received: by 10.170.174.213 with SMTP id q204mr13787469ykd.114.1418399810438; Fri, 12 Dec 2014 07:56:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.139.67 with HTTP; Fri, 12 Dec 2014 07:56:29 -0800 (PST) In-Reply-To: <54892D87.9000206@gmail.com> References: <1416968979-56894-1-git-send-email-komh@chollian.net> <54892D87.9000206@gmail.com> From: Jim Meyering Date: Fri, 12 Dec 2014 07:56:29 -0800 X-Google-Sender-Auth: PH33bpJ1CoTKy2XSSlDKpCyM_bY Message-ID: Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches To: KO Myung-Hun Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19186 Cc: 19186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun wrote: > Jim Meyering wrote: >> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: >>> Hi/2. >>> >>> These are OS/2 patches. >>> >>> Review, please... >>> >>> [PATCH 1/2] build: use quotation mark(") for PATH >>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC >> >> I saw no patches here, but was able to dig them out of the >> bug-tracking system at http://debbugs.gnu.org/19186. >> I have applied and pushed the first one. Thank you. >> >> However, for the second, my inclination is that if at all possible, >> it should be fixed via an lseek replacement that does something >> more sensible. Of course, that may not be possible, but from >> what you've presented so far, I cannot tell. Please demonstrate >> a use of diff that shows how OS/2+kLIBC's lseek fails. > > Do you want this ? > > ----- > $ cat file | diff - file > diff.exe: -: Invalid seek > ----- Yes. Thanks. That shows how lseek-pipe fails on your system. Please adjust your patch to make diff ignore failure only in that case, i.e., when errno == EINVAL (assuming strerror(EINVAL) produces that diagnostic). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 22:24:46 2014 Received: (at 19186) by debbugs.gnu.org; 13 Dec 2014 03:24:46 +0000 Received: from localhost ([127.0.0.1]:44317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzdK2-00079r-5l for submit@debbugs.gnu.org; Fri, 12 Dec 2014 22:24:46 -0500 Received: from mail-pd0-f181.google.com ([209.85.192.181]:44631) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzdJz-00079Y-9j for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 22:24:44 -0500 Received: by mail-pd0-f181.google.com with SMTP id v10so8164431pde.26 for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 19:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=I13+B18o1S/DhBZtdlCqo2pT1XD46Kn1Exvqel9at4w=; b=hj/elLqeLj0rVa4RIfteDvj8syGPTFFkAeqN47b2gneTkweFMSjFZi8aVXXSO+L0bx pYaB8/IzAy8q8XXUdTD9Hh16EZCdCf8uZNhkuFXdFvFLKnaeD3ZJF6VgvmmV7cpwkrzp Qzj8oNwu/1Cew5Tx2X/2UPuctIlNU9OWEOGTZggmjQgMpla1pRahYf7MYZPuruIi0CrP x1Ue2taHqH1P3EuMSEZTdnbSLRFQvF3apCmuDsjCXom1rquMAyTsEUWMybt/FRiVOBCe qUL0ItGIye8sG7ypZsVtlTZxEje+o57TogjZnrVqgCo4Juz4j0PaYyMeQruIYBqM608m 54/A== X-Received: by 10.70.88.47 with SMTP id bd15mr21962204pdb.54.1418441077286; Fri, 12 Dec 2014 19:24:37 -0800 (PST) Received: from [10.0.2.15] ([211.244.64.26]) by mx.google.com with ESMTPSA id vy1sm2807552pac.20.2014.12.12.19.24.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 12 Dec 2014 19:24:36 -0800 (PST) Message-ID: <548BB17A.20602@gmail.com> Date: Sat, 13 Dec 2014 12:24:42 +0900 From: KO Myung-Hun User-Agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 MIME-Version: 1.0 To: Jim Meyering Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches References: <1416968979-56894-1-git-send-email-komh@chollian.net> <54892D87.9000206@gmail.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19186 Cc: 19186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Jim Meyering wrote: > On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun wrote: >> Jim Meyering wrote: >>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: >>>> Hi/2. >>>> >>>> These are OS/2 patches. >>>> >>>> Review, please... >>>> >>>> [PATCH 1/2] build: use quotation mark(") for PATH >>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC >>> >>> I saw no patches here, but was able to dig them out of the >>> bug-tracking system at http://debbugs.gnu.org/19186. >>> I have applied and pushed the first one. Thank you. >>> >>> However, for the second, my inclination is that if at all possible, >>> it should be fixed via an lseek replacement that does something >>> more sensible. Of course, that may not be possible, but from >>> what you've presented so far, I cannot tell. Please demonstrate >>> a use of diff that shows how OS/2+kLIBC's lseek fails. >> >> Do you want this ? >> >> ----- >> $ cat file | diff - file >> diff.exe: -: Invalid seek >> ----- > > Yes. Thanks. That shows how lseek-pipe fails on your system. > Please adjust your patch to make diff ignore failure only in that case, > i.e., when errno == EINVAL (assuming strerror(EINVAL) > produces that diagnostic). Do you mean to add errno == EINVAL to if() for pfatal_with_name() ? Then contents read from pipe are consumed and cannot be recovered. So diff behaves in wrong way. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 22:51:51 2014 Received: (at 19186) by debbugs.gnu.org; 13 Dec 2014 03:51:51 +0000 Received: from localhost ([127.0.0.1]:44321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzdkE-0007rw-MB for submit@debbugs.gnu.org; Fri, 12 Dec 2014 22:51:51 -0500 Received: from mail-yk0-f181.google.com ([209.85.160.181]:53750) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzdkB-0007ri-IG for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 22:51:48 -0500 Received: by mail-yk0-f181.google.com with SMTP id 142so3644593ykq.12 for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 19:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=kOwKGxQF85aC+p68VGaQSrKj8Dzfhs5aos2B6bZ3sgg=; b=h1AJ35KTbFjyXFHO6rwdbQ543aot7dZT2NqiybuRuxOlENXHt5g5KV93JpbCsN72CB nzPyOeGi+oCgbRD6MC86ZWqyojB13M80/WCUBydJaarf94IUsnA5Gfi5uYgbxeLFcROb gTCQ1UcaFFRsduxAI76Ay/fzuaIfDQCvpPAVtJDjuHWQvkkjOCoeW26wqZcysoarmDp5 pq1e5jb8rfg+a3l6vvOEgjMkYMZX0JqoYYk9+P5ritEPh6VWh3dLX5Av0HfYOP1WflHy oBigSpc8df3jNYjt76b7GKWdzwWCW6EDtF3Kow5+CqfJR5zYjoapOuSmufb80la1cGtb TdCA== X-Received: by 10.236.220.194 with SMTP id o62mr14396493yhp.32.1418442702019; Fri, 12 Dec 2014 19:51:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.139.67 with HTTP; Fri, 12 Dec 2014 19:51:21 -0800 (PST) In-Reply-To: <548BB17A.20602@gmail.com> References: <1416968979-56894-1-git-send-email-komh@chollian.net> <54892D87.9000206@gmail.com> <548BB17A.20602@gmail.com> From: Jim Meyering Date: Fri, 12 Dec 2014 19:51:21 -0800 X-Google-Sender-Auth: e9erxKr7vFQZkMonWotfpJU9I0A Message-ID: Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches To: KO Myung-Hun Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19186 Cc: 19186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Dec 12, 2014 at 7:24 PM, KO Myung-Hun wrote: > > > Jim Meyering wrote: >> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun wrote: >>> Jim Meyering wrote: >>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: >>>>> Hi/2. >>>>> >>>>> These are OS/2 patches. >>>>> >>>>> Review, please... >>>>> >>>>> [PATCH 1/2] build: use quotation mark(") for PATH >>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC >>>> >>>> I saw no patches here, but was able to dig them out of the >>>> bug-tracking system at http://debbugs.gnu.org/19186. >>>> I have applied and pushed the first one. Thank you. >>>> >>>> However, for the second, my inclination is that if at all possible, >>>> it should be fixed via an lseek replacement that does something >>>> more sensible. Of course, that may not be possible, but from >>>> what you've presented so far, I cannot tell. Please demonstrate >>>> a use of diff that shows how OS/2+kLIBC's lseek fails. >>> >>> Do you want this ? >>> >>> ----- >>> $ cat file | diff - file >>> diff.exe: -: Invalid seek >>> ----- >> >> Yes. Thanks. That shows how lseek-pipe fails on your system. >> Please adjust your patch to make diff ignore failure only in that case, >> i.e., when errno == EINVAL (assuming strerror(EINVAL) >> produces that diagnostic). > > Do you mean to add errno == EINVAL to if() for pfatal_with_name() ? No. Skip the test only when this lseek fails with precisely that errno value: +#ifdef __KLIBC__ + /* Skip test if seek is not possible */ + skip_test = skip_test || lseek (current->desc, 0, SEEK_CUR) < 0; +#endif From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 23:18:53 2014 Received: (at 19186) by debbugs.gnu.org; 13 Dec 2014 04:18:53 +0000 Received: from localhost ([127.0.0.1]:44325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzeAO-0008WO-51 for submit@debbugs.gnu.org; Fri, 12 Dec 2014 23:18:52 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:55021) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzeAL-0008W7-4X for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 23:18:50 -0500 Received: by mail-pa0-f45.google.com with SMTP id lf10so7834476pab.4 for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 20:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=cwkwrDyl6p3WBt7Y2yqw8nf6sfIb9MLoaCTdlY17dzo=; b=BUnx312RW1PfxUdDFddbqd2kD8ivJfIM2uy49hpAFUxeze6BT3JpSG0KrSxweS3P+s hxMQzFO6z7s7Cl9RtsNRaL/HfDIJi8tUFlSQK66PWYxa2rb4j0C/X3ciiMPsBLWxs9CV +XWo7EY8b5S0v3T4lGKzGzOvzFsyHNKYWm6JEvJHokTMxRvgiVzvPljsOPZtm8wVzczk ofjaRtbZfcy7gdSLj5ZCS49P8I6ly21uSUpxvou/P83zi8FZWfZBiAhJPgL8sxVjHlFb AOU/b5j6I2ycEA8XV8iS4Y3oNusiJneYm2IdkhdqUUXYV46oWRkyWj6ZxDW9WOWKBhYW ebvw== X-Received: by 10.67.22.162 with SMTP id ht2mr32654682pad.49.1418444323260; Fri, 12 Dec 2014 20:18:43 -0800 (PST) Received: from [10.0.2.15] ([211.244.64.26]) by mx.google.com with ESMTPSA id fm4sm252753pdb.88.2014.12.12.20.18.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 12 Dec 2014 20:18:41 -0800 (PST) Message-ID: <548BBE27.6070305@gmail.com> Date: Sat, 13 Dec 2014 13:18:47 +0900 From: KO Myung-Hun User-Agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 MIME-Version: 1.0 To: Jim Meyering Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches References: <1416968979-56894-1-git-send-email-komh@chollian.net> <54892D87.9000206@gmail.com> <548BB17A.20602@gmail.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: multipart/mixed; boundary="------------040106000506020404010807" X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 19186 Cc: 19186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) This is a multi-part message in MIME format. --------------040106000506020404010807 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Jim Meyering wrote: > On Fri, Dec 12, 2014 at 7:24 PM, KO Myung-Hun wrote: >> >> >> Jim Meyering wrote: >>> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun wrote: >>>> Jim Meyering wrote: >>>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: >>>>>> Hi/2. >>>>>> >>>>>> These are OS/2 patches. >>>>>> >>>>>> Review, please... >>>>>> >>>>>> [PATCH 1/2] build: use quotation mark(") for PATH >>>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC >>>>> >>>>> I saw no patches here, but was able to dig them out of the >>>>> bug-tracking system at http://debbugs.gnu.org/19186. >>>>> I have applied and pushed the first one. Thank you. >>>>> >>>>> However, for the second, my inclination is that if at all possible, >>>>> it should be fixed via an lseek replacement that does something >>>>> more sensible. Of course, that may not be possible, but from >>>>> what you've presented so far, I cannot tell. Please demonstrate >>>>> a use of diff that shows how OS/2+kLIBC's lseek fails. >>>> >>>> Do you want this ? >>>> >>>> ----- >>>> $ cat file | diff - file >>>> diff.exe: -: Invalid seek >>>> ----- >>> >>> Yes. Thanks. That shows how lseek-pipe fails on your system. >>> Please adjust your patch to make diff ignore failure only in that case, >>> i.e., when errno == EINVAL (assuming strerror(EINVAL) >>> produces that diagnostic). >> >> Do you mean to add errno == EINVAL to if() for pfatal_with_name() ? > > No. > Skip the test only when this lseek fails with precisely that errno value: > Ok. Fixed. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr --------------040106000506020404010807 Content-Type: text/plain; name="0001-diff-skip-test-if-seek-is-not-possible-on-OS-2-kLIBC.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-diff-skip-test-if-seek-is-not-possible-on-OS-2-kLIBC.pa"; filename*1="tch" >From 7b7ebe9c5716a39cff4478e6e83720b9a9648c62 Mon Sep 17 00:00:00 2001 From: KO Myung-Hun Date: Tue, 15 Jul 2014 11:50:53 +0900 Subject: [PATCH] diff: skip test if seek is not possible on OS/2 kLIBC This fixes the problem that 'diff - file' and 'cat file | diff - file' fail due to a seek failure with a message 'diff.exe: -: Invalid seek', because seek does not work on stdin and a pipe on OS/2 kLIBC. * src/io.c (sip): Set skip_test to true if seek is not possible on OS/2 kLIBC. --- src/io.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/io.c b/src/io.c index 1a8b936..e564f40 100644 --- a/src/io.c +++ b/src/io.c @@ -108,6 +108,13 @@ sip (struct file_data *current, bool skip_test) PTRDIFF_MAX - 2 * sizeof (word)); current->buffer = xmalloc (current->bufsize); +#ifdef __KLIBC__ + /* Skip test if seek is not possible */ + skip_test = skip_test + || (lseek (current->desc, 0, SEEK_CUR) < 0 + && errno == ESPIPE); +#endif + if (! skip_test) { /* Check first part of file to see if it's a binary file. */ -- 1.8.5.2 --------------040106000506020404010807-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 12 23:54:51 2014 Received: (at 19186-done) by debbugs.gnu.org; 13 Dec 2014 04:54:51 +0000 Received: from localhost ([127.0.0.1]:44329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzejC-0000xc-Ko for submit@debbugs.gnu.org; Fri, 12 Dec 2014 23:54:50 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:46163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzejA-0000xP-4M for 19186-done@debbugs.gnu.org; Fri, 12 Dec 2014 23:54:48 -0500 Received: by mail-yk0-f170.google.com with SMTP id q200so3693276ykb.1 for <19186-done@debbugs.gnu.org>; Fri, 12 Dec 2014 20:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=wLJRrk72GZo41qhKLXtb9p6+rbp9Uya/T7LY4kpJXMI=; b=QvWN9w1SeOOdW+zS63DJaAnm3LKRj1aC3BiAdJh0mJoHc+sbooGFGtL2oiLUJcccHW 8+Cfp02iBaojip0QaZA9r3NTTvLJSuZOtZjf88w0Hgk51RFUfqKNNPYGk24gpk4IpBxm XEnn556JT+U8ncK2dVHLXzif+xAqDqQf7Mm2wys8J6h99I2aHZaPanLRLM2hTO0F/vI/ +Sq68lVAtHpMupF5c9AF4Yq4F5jLg1UNbSWsRQJjDO+cKBS9DC7GHV6QERQJLvcCSCOV b8ebWPJxH9M0CfyhYdge5lABsUPyek7aHMau85eGiYbLMgXyLXNRcmGJxVhU9a5ippxs b3mQ== X-Received: by 10.236.47.196 with SMTP id t44mr14442942yhb.59.1418446482542; Fri, 12 Dec 2014 20:54:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.139.67 with HTTP; Fri, 12 Dec 2014 20:54:22 -0800 (PST) In-Reply-To: <548BBE27.6070305@gmail.com> References: <1416968979-56894-1-git-send-email-komh@chollian.net> <54892D87.9000206@gmail.com> <548BB17A.20602@gmail.com> <548BBE27.6070305@gmail.com> From: Jim Meyering Date: Fri, 12 Dec 2014 20:54:22 -0800 X-Google-Sender-Auth: NKcXEUiU_TjHlV781isi37w0cRA Message-ID: Subject: Re: [bug-diffutils] bug#19186: [PATCH] OS/2 patches To: KO Myung-Hun Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19186-done Cc: 19186-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Dec 12, 2014 at 8:18 PM, KO Myung-Hun wrote: > Jim Meyering wrote: >> On Fri, Dec 12, 2014 at 7:24 PM, KO Myung-Hun wrote: >>> >>> Jim Meyering wrote: >>>> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun wrote: >>>>> Jim Meyering wrote: >>>>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun wrote: >>>>>>> Hi/2. >>>>>>> >>>>>>> These are OS/2 patches. >>>>>>> >>>>>>> Review, please... >>>>>>> >>>>>>> [PATCH 1/2] build: use quotation mark(") for PATH >>>>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC >>>>>> >>>>>> I saw no patches here, but was able to dig them out of the >>>>>> bug-tracking system at http://debbugs.gnu.org/19186. >>>>>> I have applied and pushed the first one. Thank you. >>>>>> >>>>>> However, for the second, my inclination is that if at all possible, >>>>>> it should be fixed via an lseek replacement that does something >>>>>> more sensible. Of course, that may not be possible, but from >>>>>> what you've presented so far, I cannot tell. Please demonstrate >>>>>> a use of diff that shows how OS/2+kLIBC's lseek fails. >>>>> >>>>> Do you want this ? >>>>> >>>>> ----- >>>>> $ cat file | diff - file >>>>> diff.exe: -: Invalid seek >>>>> ----- >>>> >>>> Yes. Thanks. That shows how lseek-pipe fails on your system. >>>> Please adjust your patch to make diff ignore failure only in that case, >>>> i.e., when errno == EINVAL (assuming strerror(EINVAL) >>>> produces that diagnostic). >>> >>> Do you mean to add errno == EINVAL to if() for pfatal_with_name() ? >> >> No. >> Skip the test only when this lseek fails with precisely that errno value: > > Ok. Fixed. Applied and pushed. Thanks. From unknown Tue Aug 19 03:05:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 10 Jan 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator