From unknown Tue Sep 09 11:59:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error Resent-From: Pedro Aguilar Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 25 Nov 2014 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19172 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 19172@debbugs.gnu.org Cc: thomas.petazzoni@free-electrons.com, Pedro Aguilar X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14168750365863 (code B ref -1); Tue, 25 Nov 2014 00:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Nov 2014 00:23:56 +0000 Received: from localhost ([127.0.0.1]:44401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xt3v9-0001WS-0i for submit@debbugs.gnu.org; Mon, 24 Nov 2014 19:23:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53006) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xt2qV-0006je-51 for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:15:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xt2qO-0001Nm-8y for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:15:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2qO-0001Ni-60 for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:14:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2qI-00024J-8b for bug-guile@gnu.org; Mon, 24 Nov 2014 18:14:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xt2qC-0001N9-Bb for bug-guile@gnu.org; Mon, 24 Nov 2014 18:14:50 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:55878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2qC-0001Mp-2q for bug-guile@gnu.org; Mon, 24 Nov 2014 18:14:44 -0500 Received: from localhost.localdomain (host89-115-dynamic.60-82-r.retail.telecomitalia.it [82.60.115.89]) by mrelayeu.kundenserver.de (node=mreue004) with ESMTP (Nemesis) id 0LgtFa-1YFPE63e90-00oHEe; Tue, 25 Nov 2014 00:14:41 +0100 From: Pedro Aguilar Date: Tue, 25 Nov 2014 00:14:32 +0100 Message-Id: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> X-Mailer: git-send-email 1.9.1 X-Provags-ID: V02:K0:+ZJPAx15YnYnyzOGyr08cV1hqxJjG0Mu4TXRKYrGafL cD/xSEECnHvcG6d9cg1qsUavwQAc7P86KH65CKoh1SdvEc1SyH nKzMp8Lmc8ylvf/qj+4CLhHdRiStTOCmDvAs3NUnH1vekwScdW wbgFMAfGsijzRE9a7tp1b1UXpFYq3Z/ClWpIToq2i8t0SnhKlw yxTpDg/IZxbaxgjK+7A5Fk+BmjQyI/OgOgwf8BVSQzlKpbSaTm xnzRAHGdiQ3gw9FSZ4/ltU/cyqecQokfZic9rh8RsM+cFgk2un 6qVEd5DIfNbD7tquli8kPSlUUyYAdeUHh0X48WP1CAX6AhPy0u 0bvBA4Tp8sL4n8xPrJqcUlMmH2Jsf1FwWfcpQyD8sk6LM2lyDV zqCWM2peHfJQNzjC7CPpuAiILgo7NHyy88= X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Mon, 24 Nov 2014 19:23:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Remove unused static inline functions str_upcase_l() and str_downcase_l() that cause the compilation error 'dereferencing pointer to incomplete type' when building for ARM using a buildroot-generated toolchain. Signed-off-by: Pedro Aguilar --- libguile/i18n.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/libguile/i18n.c b/libguile/i18n.c index c6b9b84..32278bd 100644 --- a/libguile/i18n.c +++ b/libguile/i18n.c @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src) *dst = '\0'; } -#ifdef USE_GNU_LOCALE_API -static inline void -str_upcase_l (register char *dst, register const char *src, - scm_t_locale locale) -{ - for (; *src != '\0'; src++, dst++) - *dst = toupper_l (*src, locale); - *dst = '\0'; -} - -static inline void -str_downcase_l (register char *dst, register const char *src, - scm_t_locale locale) -{ - for (; *src != '\0'; src++, dst++) - *dst = tolower_l (*src, locale); - *dst = '\0'; -} -#endif - SCM_DEFINE (scm_string_locale_lt, "string-locale Subject: bug#19172: closed (Re: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error) Message-ID: References: <87y45xs2hu.fsf@pobox.com> <1416870872-13385-1-git-send-email-paguilar@paguilar.org> X-Gnu-PR-Message: they-closed 19172 X-Gnu-PR-Package: guile X-Gnu-PR-Keywords: patch Reply-To: 19172@debbugs.gnu.org Date: Wed, 22 Jun 2016 14:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1466607002-17645-1" This is a multi-part message in MIME format... ------------=_1466607002-17645-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19172: [PATCH 1/1] Remove unused funcs that cause a building error which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19172@debbugs.gnu.org. --=20 19172: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19172 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1466607002-17645-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19172-done) by debbugs.gnu.org; 22 Jun 2016 14:49:12 +0000 Received: from localhost ([127.0.0.1]:51273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjSq-0004ZO-JN for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:49:12 -0400 Received: from pb-sasl2.pobox.com ([64.147.108.67]:61860 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjSo-0004ZF-8U for 19172-done@debbugs.gnu.org; Wed, 22 Jun 2016 10:49:10 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 7364C1F284; Wed, 22 Jun 2016 10:49:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=kPSeMKQKsWyW+CLV2TjqaAiFTDc=; b=PEBt8c /QG+SSRAsi7ExM1moNZMmMrVkswXiFGntnukLpBtX7m50gC7lm+oznO4Fe+GITtC +F1Xgertg9wwYpVQ55wwDEHaaDWdekyrrkUFjS0X4N5geEY/t/otUo2qHJM9wxce VLbxahRKWJ2QHLNyGJ0vB0T4diU7WnMBwCab4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=Z6oWxEjl4JAMOR08d4SvgjMFSf8uZn02 5M1MCH6lhGmmT9Ef6Mzp2IG5i12eiVVEqojDQhDYDe3EhMXEucoF2SThnowtknHc HgWNubuCvkocLCP1kH1wL8W7BaCGURR7RjDmSE9IT6BlN0WmHg25gIuSjc5kDklV n/9Yys723oU= Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 6BF751F281; Wed, 22 Jun 2016 10:49:09 -0400 (EDT) Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 9633D1F280; Wed, 22 Jun 2016 10:49:08 -0400 (EDT) From: Andy Wingo To: Pedro Aguilar Subject: Re: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error References: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> Date: Wed, 22 Jun 2016 16:49:01 +0200 In-Reply-To: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> (Pedro Aguilar's message of "Tue, 25 Nov 2014 00:14:32 +0100") Message-ID: <87y45xs2hu.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 79A51D3E-3888-11E6-B460-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 19172-done Cc: thomas.petazzoni@free-electrons.com, 19172-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Thanks for the patch! I applied a version that also deleted the previous two static inline helpers. Weird to have them around. Will be in 2.0.12 and 2.1.4. Cheers, Andy On Tue 25 Nov 2014 00:14, Pedro Aguilar writes: > Remove unused static inline functions str_upcase_l() and > str_downcase_l() that cause the compilation error > 'dereferencing pointer to incomplete type' when building > for ARM using a buildroot-generated toolchain. > > Signed-off-by: Pedro Aguilar > --- > libguile/i18n.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/libguile/i18n.c b/libguile/i18n.c > index c6b9b84..32278bd 100644 > --- a/libguile/i18n.c > +++ b/libguile/i18n.c > @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src) > *dst = '\0'; > } > > -#ifdef USE_GNU_LOCALE_API > -static inline void > -str_upcase_l (register char *dst, register const char *src, > - scm_t_locale locale) > -{ > - for (; *src != '\0'; src++, dst++) > - *dst = toupper_l (*src, locale); > - *dst = '\0'; > -} > - > -static inline void > -str_downcase_l (register char *dst, register const char *src, > - scm_t_locale locale) > -{ > - for (; *src != '\0'; src++, dst++) > - *dst = tolower_l (*src, locale); > - *dst = '\0'; > -} > -#endif > - > > SCM_DEFINE (scm_string_locale_lt, "string-locale (SCM s1, SCM s2, SCM locale), ------------=_1466607002-17645-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Nov 2014 00:23:56 +0000 Received: from localhost ([127.0.0.1]:44401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xt3v9-0001WS-0i for submit@debbugs.gnu.org; Mon, 24 Nov 2014 19:23:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53006) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xt2qV-0006je-51 for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:15:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xt2qO-0001Nm-8y for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:15:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2qO-0001Ni-60 for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:14:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2qI-00024J-8b for bug-guile@gnu.org; Mon, 24 Nov 2014 18:14:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xt2qC-0001N9-Bb for bug-guile@gnu.org; Mon, 24 Nov 2014 18:14:50 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:55878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2qC-0001Mp-2q for bug-guile@gnu.org; Mon, 24 Nov 2014 18:14:44 -0500 Received: from localhost.localdomain (host89-115-dynamic.60-82-r.retail.telecomitalia.it [82.60.115.89]) by mrelayeu.kundenserver.de (node=mreue004) with ESMTP (Nemesis) id 0LgtFa-1YFPE63e90-00oHEe; Tue, 25 Nov 2014 00:14:41 +0100 From: Pedro Aguilar To: bug-guile@gnu.org Subject: [PATCH 1/1] Remove unused funcs that cause a building error Date: Tue, 25 Nov 2014 00:14:32 +0100 Message-Id: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> X-Mailer: git-send-email 1.9.1 X-Provags-ID: V02:K0:+ZJPAx15YnYnyzOGyr08cV1hqxJjG0Mu4TXRKYrGafL cD/xSEECnHvcG6d9cg1qsUavwQAc7P86KH65CKoh1SdvEc1SyH nKzMp8Lmc8ylvf/qj+4CLhHdRiStTOCmDvAs3NUnH1vekwScdW wbgFMAfGsijzRE9a7tp1b1UXpFYq3Z/ClWpIToq2i8t0SnhKlw yxTpDg/IZxbaxgjK+7A5Fk+BmjQyI/OgOgwf8BVSQzlKpbSaTm xnzRAHGdiQ3gw9FSZ4/ltU/cyqecQokfZic9rh8RsM+cFgk2un 6qVEd5DIfNbD7tquli8kPSlUUyYAdeUHh0X48WP1CAX6AhPy0u 0bvBA4Tp8sL4n8xPrJqcUlMmH2Jsf1FwWfcpQyD8sk6LM2lyDV zqCWM2peHfJQNzjC7CPpuAiILgo7NHyy88= X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 24 Nov 2014 19:23:53 -0500 Cc: thomas.petazzoni@free-electrons.com, Pedro Aguilar X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Remove unused static inline functions str_upcase_l() and str_downcase_l() that cause the compilation error 'dereferencing pointer to incomplete type' when building for ARM using a buildroot-generated toolchain. Signed-off-by: Pedro Aguilar --- libguile/i18n.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/libguile/i18n.c b/libguile/i18n.c index c6b9b84..32278bd 100644 --- a/libguile/i18n.c +++ b/libguile/i18n.c @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src) *dst = '\0'; } -#ifdef USE_GNU_LOCALE_API -static inline void -str_upcase_l (register char *dst, register const char *src, - scm_t_locale locale) -{ - for (; *src != '\0'; src++, dst++) - *dst = toupper_l (*src, locale); - *dst = '\0'; -} - -static inline void -str_downcase_l (register char *dst, register const char *src, - scm_t_locale locale) -{ - for (; *src != '\0'; src++, dst++) - *dst = tolower_l (*src, locale); - *dst = '\0'; -} -#endif - SCM_DEFINE (scm_string_locale_lt, "string-locale