From unknown Sat Jun 21 10:30:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19140 <19140@debbugs.gnu.org> To: bug#19140 <19140@debbugs.gnu.org> Subject: Status: dir-locals-collect-variables discrepancy in handling non-file buffers Reply-To: bug#19140 <19140@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:30:18 +0000 retitle 19140 dir-locals-collect-variables discrepancy in handling non-file= buffers reassign 19140 emacs submitter 19140 Ivan Shmakov severity 19140 minor tag 19140 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 21 11:13:07 2014 Received: (at submit) by debbugs.gnu.org; 21 Nov 2014 16:13:07 +0000 Received: from localhost ([127.0.0.1]:41061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrqpW-00079Q-GF for submit@debbugs.gnu.org; Fri, 21 Nov 2014 11:13:06 -0500 Received: from fely.am-1.org ([78.47.74.50]:41736) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrqpT-00079H-H5 for submit@debbugs.gnu.org; Fri, 21 Nov 2014 11:13:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=8QV9ZoqEQd1QSnxqifYoY8XgHk+6z7dIYomhyiqhNtc=; b=rGCdoNw8MK980BTVwLQ7GCXu14ubH7fG8hz9HZH0+6YM14tgtGzSwNN9J1dFeZMVXCk8FLg6s5iTvBpoyulY2z06hKN3CUirdzS5HPefdlyQBQwqJ7HP0RJOjMujToG/UoumkmI+QTR0EkVnBWIxavpVUJhj17bf4nYKRXIjMGQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XrqpQ-0002EM-LI for submit@debbugs.gnu.org; Fri, 21 Nov 2014 16:13:00 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XrqpJ-0007Pe-AA for submit@debbugs.gnu.org; Fri, 21 Nov 2014 23:12:53 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: dir-locals-collect-variables discrepancy in handling non-file buffers Date: Fri, 21 Nov 2014 16:12:52 +0000 Message-ID: <87zjbky1kr.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Please consider the patch MIMEd. * lisp/files.el (dir-locals-collect-variables): Use default-directory in place of the file name while working on non-file buffers (as hack-dir-local-variables already does.) The issue I observe is as follows. First, I create ~/foo and ~/foo/ru directories, and a ~/foo/.dir-locals.el file like: ((nil (ispell-local-dictionary . "esperanto")) ("ru" (nil (ispell-local-dictionary . "russian")))) Then: (with-temp-buffer (cd "~/foo/ru/") (hack-dir-local-variables-non-file-buffer) ;; . dir-local-variables-alist) The result is '((ispell-local-dictionary . "esperanto")), contrary to the expected '((=E2=80=A6 . "russian")). This does not happen for buffers associated with files: (with-current-buffer (find-file-noselect "~/foo/ru/bar") (hack-dir-local-variables) ;; . dir-local-variables-alist) Reading the code suggests that dir-locals-collect-variables fails to handle the (stringp key) case properly when =E2=80=98file-name=E2= =80=99 is nil, which is what my patch is intended to fix. --=20 FSF associate member #7257 np. Conclusion =E2=80=94 Apocalyptica =E2=80= =A6 B6A0 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/files.el +++ b/lisp/files.el @@ -3567,8 +3569,10 @@ (defun dir-locals-collect-variables (class-variables root variables) "Collect entries from CLASS-VARIABLES into VARIABLES. ROOT is the root directory of the project. Return the new variables list." - (let* ((file-name (buffer-file-name)) + (let* ((file-name (or (buffer-file-name) + ;; handle non-file buffers, too + default-directory)) (sub-file-name (if file-name ;; FIXME: Why not use file-relative-name? (substring file-name (length root))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 29 04:01:04 2014 Received: (at control) by debbugs.gnu.org; 29 Dec 2014 09:01:04 +0000 Received: from localhost ([127.0.0.1]:60183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5WCG-00050s-FI for submit@debbugs.gnu.org; Mon, 29 Dec 2014 04:01:04 -0500 Received: from fely.am-1.org ([78.47.74.50]:46761) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y5WCD-00050J-N4 for control@debbugs.gnu.org; Mon, 29 Dec 2014 04:01:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=1siiA8qGfEwATDrcsznszeE9vWtzeRu014lFZeJpj0g=; b=GmLdqCa0w0aOvakXKbvs4MxSN0dDhn7hxIlqeS6ccdqmj+pOMa2DyVv52l8oD1hKIjF9iKJ9Y+yJIzRsjkushh3MZiTeOUs2y9XC9rWB1AwRX6jPo99KYsnAqq2lIuadXaTLItpr7F+muFU4INZUzlT8+kjb4nbgcXbsyFfjEIE=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y5WCC-0005wY-9p for control@debbugs.gnu.org; Mon, 29 Dec 2014 09:01:00 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y5WC4-0001Tq-8x for control@debbugs.gnu.org; Mon, 29 Dec 2014 16:00:52 +0700 From: Ivan Shmakov To: control@debbugs.gnu.org Subject: tweaking bugs Mail-Followup-To: emacs-devel@gnu.org Date: Mon, 29 Dec 2014 09:00:51 +0000 Message-ID: <87a926bzjw.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 19462 + patch tags 19274 + patch tags 19140 + patch tags 16002 + patch fixed 19435 24.5 thanks The code suggested in #16002 already works; it=E2=80=99s only the matter of where to put it in. (Or not.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 30 14:46:10 2014 Received: (at 19140) by debbugs.gnu.org; 30 Dec 2014 19:46:10 +0000 Received: from localhost ([127.0.0.1]:33154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y62k6-0000IV-58 for submit@debbugs.gnu.org; Tue, 30 Dec 2014 14:46:10 -0500 Received: from fely.am-1.org ([78.47.74.50]:47001) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y62k2-0000IL-TK for 19140@debbugs.gnu.org; Tue, 30 Dec 2014 14:46:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=BquyT22I0sAMnkNzhkyESyz+NfadyqnxRUF/P/8rypY=; b=JVZmIZcwYSO+sqFPbmQ/YWU4g8569Kx4taKS/VzcK1iNwHwzhXSTPpsIGpKhn23viJnE/r/9i3HkrMQA5bTyrw7WAqgofdQgFN5a7W7tLqDZFgOpYwYvxW/LnDQdmVzrogtE9iAv8XUdOISMVHiORg+YVdpGiVaj+H5Gx5h6plY=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y62k1-0001kg-5w for 19140@debbugs.gnu.org; Tue, 30 Dec 2014 19:46:05 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Y62jt-0004rj-ST for 19140@debbugs.gnu.org; Wed, 31 Dec 2014 02:45:57 +0700 From: Ivan Shmakov To: 19140@debbugs.gnu.org Subject: Re: bug#19140: dir-locals-collect-variables discrepancy in handling non-file buffers References: <87zjbky1kr.fsf@violet.siamics.net> Mail-Followup-To: 19140@debbugs.gnu.org Date: Tue, 30 Dec 2014 19:45:57 +0000 In-Reply-To: <87zjbky1kr.fsf@violet.siamics.net> (Ivan Shmakov's message of "Fri, 21 Nov 2014 16:12:52 +0000") Message-ID: <87egrg9b0q.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19140 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Please consider the revised patch MIMEd. * lisp/files.el (dir-locals-collect-variables): Use default-directory in place of the file name while working on non-file buffers (as hack-dir-local-variables already does.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --- a/lisp/files.el +++ b/lisp/files.el 2014-12-28 19:20:59+00:00 @@ -3628,7 +3628,9 @@ defun dir-locals-collect-variables (class-variables r= oot variables) "Collect entries from CLASS-VARIABLES into VARIABLES. ROOT is the root directory of the project. Return the new variables list." - (let* ((file-name (buffer-file-name)) + (let* ((file-name (or (buffer-file-name) + ;; handle non-file buffers, too + (expand-file-name default-directory))) (sub-file-name (if file-name ;; FIXME: Why not use file-relative-name? (substring file-name (length root))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 02:30:30 2015 Received: (at 19140) by debbugs.gnu.org; 19 Jan 2015 07:30:30 +0000 Received: from localhost ([127.0.0.1]:60934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD6n6-0001w2-Uj for submit@debbugs.gnu.org; Mon, 19 Jan 2015 02:30:30 -0500 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:57917 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD6n1-0001vj-NO for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 02:30:26 -0500 Received: from localhost.localdomain ([127.0.0.1]:46460 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1YD6ml-002Eek-Gg for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 01:30:16 -0600 Date: Mon, 19 Jan 2015 16:30:05 +0900 Message-ID: From: Katsumi Yamaoka To: 19140@debbugs.gnu.org Subject: Re: bug#19140: dir-locals-collect-variables discrepancy in handling non-file buffers References: <87zjbky1kr.fsf@violet.siamics.net> <87egrg9b0q.fsf@violet.siamics.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:GOs3ZlONsAaJnpkFLInRaeVeeXU= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-1.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19140 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hi Ivan, On Tue, 30 Dec 2014 19:45:57 +0000, Ivan Shmakov wrote: > Please consider the revised patch MIMEd. > * lisp/files.el (dir-locals-collect-variables): Use > default-directory in place of the file name while working on > non-file buffers (as hack-dir-local-variables already does.) After this change, I got to get unknown errors[1] when building Ma Gnus. To reproduce the same result, try the following in the Emacs source tree: % cd lisp/gnus % emacs -batch -Q --eval FORM where FORM is: '(with-temp-buffer (let ((default-directory (expand-file-name "."))) (insert-file-contents "./auth-source.el") (hack-local-variables)))' And you will see (args-out-of-range "/DIR/emacs/lisp/gnus" 21 nil) or something similar (where 21 is 1+ the number of letters of the dir name). The FORM above is what `custom-make-dependencies' does. When building Ma Gnus, `dir-locals-collect-variables' is called in this way: dgnushack.el (dgnushack-make-cus-load) -> cus-dep.el (custom-make-dependencies) -> files.el (hack-local-variables) -> files.el (hack-dir-local-variables) -> files.el (dir-locals-collect-variables) Before you changed `dir-locals-collect-variables', it returned nil and `custom-make-dependencies' issued no error. I guess `custom-make-dependencies' expects the function in question to return nil, otherwise it needs to be modified in some way. Thanks. [1] % cd /Work/gnus % ./configure % make lick cd lisp && make EMACS="emacs" lispdir="/usr/local/share/emacs/site-lisp/gnus" all make[1]: Entering directory '/Work/gnus/lisp' rm -f *.elc gnus-load.el auto-autoloads.* custom-load.* lispdir="/usr/local/share/emacs/site-lisp/gnus" srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load . Loading cus-dep... Directory . Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Directory-local variables error: (args-out-of-range "/Work/gnus/lisp" 16 nil) Generating cus-load.el... Generating cus-load.el...done lispdir="/usr/local/share/emacs/site-lisp/gnus" srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-auto-load . lispdir="/usr/local/share/emacs/site-lisp/gnus" srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-load Generating /Work/gnus/lisp/gnus-load.el... Compiling /Work/gnus/lisp/gnus-load.el... [...] From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 03:55:58 2015 Received: (at 19140) by debbugs.gnu.org; 19 Jan 2015 08:55:58 +0000 Received: from localhost ([127.0.0.1]:60973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD87p-00048p-Gx for submit@debbugs.gnu.org; Mon, 19 Jan 2015 03:55:57 -0500 Received: from fely.am-1.org ([78.47.74.50]:50017) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD87n-00048g-0b for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 03:55:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=OJI6aRPNT7JqtDkAedHuc0E2M+kFNbKD8lN/cyiCBB8=; b=A5y62wflDpCb+w/7Me3XYxC8KEf4JlS9enn0zKO5KShfMpXzMAg9uY7y6nUY8CKTaH6UJB0hodMfB7BBK4r3o1vzFX43Bgak89Ihuhb9gJoeNCsboibh1a7IaSqfGl8by6abolWepdE/VxMmHc8EYYd08Gw5H0aZpxueHdHvTY4=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YD87k-0004ky-DC for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 08:55:53 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YD87c-0005fG-OK for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 15:55:44 +0700 From: Ivan Shmakov To: 19140@debbugs.gnu.org Subject: Re: bug#19140: dir-locals-collect-variables discrepancy in handling non-file buffers References: <87zjbky1kr.fsf@violet.siamics.net> <87egrg9b0q.fsf@violet.siamics.net> Mail-Followup-To: 19140@debbugs.gnu.org Date: Mon, 19 Jan 2015 08:55:43 +0000 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 19 Jan 2015 16:30:05 +0900") Message-ID: <87y4ozrvxs.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19140 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Katsumi Yamaoka writes: >>>>> On Tue, 30 Dec 2014 19:45:57 +0000, Ivan Shmakov wrote: [=E2=80=A6] >> * lisp/files.el (dir-locals-collect-variables): Use >> default-directory in place of the file name while working on >> non-file buffers (as hack-dir-local-variables already does.) > After this change, I got to get unknown errors[1] when building > Ma Gnus. To reproduce the same result, try the following in the > Emacs source tree: > % cd lisp/gnus=20 > % emacs -batch -Q --eval FORM=20 > where FORM is: > '(with-temp-buffer (let ((default-directory (expand-file-name "."))) > (insert-file-contents "./auth-source.el") (hack-local-variables)))' > And you will see > (args-out-of-range "/DIR/emacs/lisp/gnus" 21 nil) > or something similar (where 21 is 1+ the number of letters of the dir > name). > The FORM above is what `custom-make-dependencies' does. ACK, thanks. Indeed, this change assumes that the result for (expand-file-name default-directory) ends with a =E2=80=98/=E2=80=99, yet = that=E2=80=99s only the case when default-directory itself ends with a =E2=80=98/=E2=80= =99, which I believe it should; consider, e. g.: (defun cd-absolute (dir) "Change current directory to given absolute file name DIR." ;; Put the name into directory syntax now, ;; because otherwise expand-file-name may give some bad results. (setq dir (file-name-as-directory dir)) =E2=80=A6) The issue at hand could be solved by using the first of the patches MIMEd. However, I believe that such a change may easily mask bugs in the other parts of the code, so the proper solution would probably be a fix to custom-make-dependencies, as per the second patch MIMEd. Could you please check if both indeed resolve the issue at hand? TIA. [=E2=80=A6] --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/files.el 2015-01-17 19:02:00 +0000 +++ b/lisp/files.el @@ -3604,7 +3604,8 @@ defun dir-locals-collect-variables (class-variables root variables) Return the new variables list." (let* ((file-name (or (buffer-file-name) ;; Handle non-file buffers, too. - (expand-file-name default-directory))) + (file-name-as-directory + (expand-file-name default-directory)))) (sub-file-name (if file-name ;; FIXME: Why not use file-relative-name? (substring file-name (length root))))) --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/cus-dep.el 2015-01-01 22:26:41 +0000 +++ b/lisp/cus-dep.el 2015-01-19 08:49:23 +0000 @@ -62,7 +62,8 @@ defun custom-make-dependencies () (while (setq subdir (pop command-line-args-left)) (message "Directory %s" subdir) (let ((files (directory-files subdir nil "\\`[^=.].*\\.el\\'")) - (default-directory (expand-file-name subdir)) + (default-directory + (file-name-as-directory (expand-file-name subdir))) (preloaded (concat "\\`\\(\\./+\\)?" (regexp-opt preloaded-file-list t) "\\.el\\'"))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 04:28:41 2015 Received: (at 19140) by debbugs.gnu.org; 19 Jan 2015 09:28:41 +0000 Received: from localhost ([127.0.0.1]:60983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD8dV-0004wK-0n for submit@debbugs.gnu.org; Mon, 19 Jan 2015 04:28:41 -0500 Received: from memphis.hostforweb.net ([205.234.200.236]:43959) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD8dS-0004w6-FM for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 04:28:39 -0500 Received: from localhost ([127.0.0.1]:40713) by memphis.hostforweb.net with smtp (Exim 4.84) (envelope-from ) id 1YD8dM-000SYD-Mo; Mon, 19 Jan 2015 03:28:32 -0600 Date: Mon, 19 Jan 2015 18:28:28 +0900 Message-ID: From: Katsumi Yamaoka To: 19140@debbugs.gnu.org Subject: Re: bug#19140: dir-locals-collect-variables discrepancy in handling non-file buffers References: <87zjbky1kr.fsf@violet.siamics.net> <87egrg9b0q.fsf@violet.siamics.net> <87y4ozrvxs.fsf@violet.siamics.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:Q67VGqMltPcW2d0JC3l5VTTuL50= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19140 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Mon, 19 Jan 2015 08:55:43 +0000, Ivan Shmakov wrote: > so the proper solution would probably be a fix to > custom-make-dependencies Hm, I wish there aren't many other modules to have to be fixed. > Could you please check if both indeed resolve the issue at hand? Both work. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 04:56:05 2015 Received: (at 19140) by debbugs.gnu.org; 19 Jan 2015 09:56:05 +0000 Received: from localhost ([127.0.0.1]:60994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD941-0005eV-4o for submit@debbugs.gnu.org; Mon, 19 Jan 2015 04:56:05 -0500 Received: from fely.am-1.org ([78.47.74.50]:50024) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YD93y-0005e1-LQ for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 04:56:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=cdlKtb7FWGfTTR2WP37GPVaMnUG5NGW6nx4rCeqx3do=; b=hmdbshLS0Ek/Ww7emQKxEjotirQ2TQjCz5tfmzS4t5HoBGhUpIOsOALP0J5IdkqEhK2VvGPvl/D5EV4sr/6R5gTbc5DT1lBjTqzeDSMIKntadaAetpB8MwKX7+Fi1f7+SPzEu498YN5fPT567Macz0pfK7wzOWDqgFILXa3Vl90=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YD93t-0005Cj-5H for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 09:55:58 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YD93j-0006Bu-4W for 19140@debbugs.gnu.org; Mon, 19 Jan 2015 16:55:47 +0700 From: Ivan Shmakov To: 19140@debbugs.gnu.org Subject: Re: bug#19140: dir-locals-collect-variables discrepancy in handling non-file buffers References: <87zjbky1kr.fsf@violet.siamics.net> <87egrg9b0q.fsf@violet.siamics.net> <87y4ozrvxs.fsf@violet.siamics.net> Mail-Followup-To: 19140@debbugs.gnu.org Date: Mon, 19 Jan 2015 09:55:46 +0000 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 19 Jan 2015 18:28:28 +0900") Message-ID: <87ppabrt5p.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19140 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Katsumi Yamaoka writes: >>>>> On Mon, 19 Jan 2015 08:55:43 +0000, Ivan Shmakov wrote: [=E2=80=A6] >> Could you please check if both indeed resolve the issue at hand? > Both work. Thanks. ACK; I=E2=80=99ve just pushed the change to custom-make-dependencies. commit 2e8d209f258c9bb6a6626d4a101995965b040024 Fix the value default-directory gets in custom-make-dependencies. * lisp/cus-dep.el (custom-make-dependencies): Ensure that default-directory is interpreted as a directory (see bug#19140.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 16:09:51 2015 Received: (at 19140-done) by debbugs.gnu.org; 14 Feb 2015 21:09:51 +0000 Received: from localhost ([127.0.0.1]:44206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMjyI-0001CV-K6 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 16:09:50 -0500 Received: from fely.am-1.org ([78.47.74.50]:43862) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMjyG-0001CM-Hz for 19140-done@debbugs.gnu.org; Sat, 14 Feb 2015 16:09:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=dAt/ZWu7XTpjitBW0HgmzaN3Sc/kExHlE2H7FUj3RyE=; b=Y+1xoGrRIhBdobr5EsUaU0Tsv20ZrAnn9qxQwNOVSFzDYNCPe3DzWb1OSjzEPQXEfKXenMYP08HFslZlZB+El+i8LX8g5uaNm2GOC+c39FrXZ85SLlN47QYqXI1nZfgY86L9ESlYNTd2Zcm4vwUU/AwLq085pHP0VqcAU+vqDOE=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMjyF-0005xy-V6 for 19140-done@debbugs.gnu.org; Sat, 14 Feb 2015 21:09:48 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMjy8-0003HA-FZ for 19140-done@debbugs.gnu.org; Sun, 15 Feb 2015 04:09:40 +0700 From: Ivan Shmakov To: 19140-done@debbugs.gnu.org Subject: Re: bug#19140: dir-locals-collect-variables discrepancy in handling non-file buffers References: <87zjbky1kr.fsf@violet.siamics.net> <87egrg9b0q.fsf@violet.siamics.net> <87y4ozrvxs.fsf@violet.siamics.net> <87ppabrt5p.fsf@violet.siamics.net> Mail-Followup-To: 19140@debbugs.gnu.org Date: Sat, 14 Feb 2015 21:09:39 +0000 In-Reply-To: <87ppabrt5p.fsf@violet.siamics.net> (Ivan Shmakov's message of "Mon, 19 Jan 2015 09:55:46 +0000") Message-ID: <87lhk09p4c.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19140-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 25.1 >>>>> Ivan Shmakov writes: >>>>> Katsumi Yamaoka writes: >>>>> On Mon, 19 Jan 2015 08:55:43 +0000, Ivan Shmakov wrote: >>> Could you please check if both indeed resolve the issue at hand? >> Both work. Thanks. > ACK; I=E2=80=99ve just pushed the change to custom-make-dependencies. > commit 2e8d209f258c9bb6a6626d4a101995965b040024 > Fix the value default-directory gets in custom-make-dependencies. > * lisp/cus-dep.el (custom-make-dependencies): Ensure that > default-directory is interpreted as a directory (see bug#19140.) No further issues reported; closing. commit e000ff30b4354064ca7f9ed07e58903d7c44033f CommitDate: 2015-01-17 19:33:50 +0000 Fix dir-locals handling for non-file buffers. =20=20=20=20 * lisp/files.el (dir-locals-collect-variables): Use default-directory in place of the file name while working on non-file buffers, just like hack-dir-local-variables already does. =20=20=20=20 Fixes: debbugs:19140 --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Sat Jun 21 10:30:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 Mar 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator