GNU bug report logs - #19102
24.4; outline-move-subtree-up/down error at last and second-last subtree

Previous Next

Full log

View this message in rfc822 format

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: paul <at> tilk.co, 19102 <at> debbugs.gnu.org
Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree
Date: Wed, 19 Nov 2014 21:14:42 +0100

On Wed, 19 Nov 2014 20:56:12 +0200 Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: Stephen Berman <stephen.berman <at> gmx.net>
>> Cc: paul <at> tilk.co,  19102 <at> debbugs.gnu.org
>> Date: Wed, 19 Nov 2014 18:09:52 +0100
>> 
>> On Wed, 19 Nov 2014 17:54:41 +0200 Eli Zaretskii <eliz <at> gnu.org> wrote:
>> > Thanks.  Can you explain why the problem happened in the first place?
>> 
>> The error occurs when the sexp `(= (char-after) ?\n)' in
>> outline-move-subtree-down is evaluated at eob.
>
> Wouldn't using eolp instead of the comparison solve that problem more
> easily?

Well, that eliminates the wrong-type-argument error in the current code,
but it instead signals "End of buffer" and still fails to move the
subtree in the cases I listed.  But using eolp in place of the
comparison in my patch is fine, and cleaner, so thanks.  Do you see any
other problems with the patch or more room for improvement?

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.