From unknown Fri Aug 15 21:24:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19101 <19101@debbugs.gnu.org> To: bug#19101 <19101@debbugs.gnu.org> Subject: Status: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' Reply-To: bug#19101 <19101@debbugs.gnu.org> Date: Sat, 16 Aug 2025 04:24:28 +0000 retitle 19101 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' reassign 19101 emacs submitter 19101 Richard Copley severity 19101 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 18 20:17:08 2014 Received: (at submit) by debbugs.gnu.org; 19 Nov 2014 01:17:09 +0000 Received: from localhost ([127.0.0.1]:37690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqttM-0006iq-BM for submit@debbugs.gnu.org; Tue, 18 Nov 2014 20:17:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54784) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqttJ-0006ih-LT for submit@debbugs.gnu.org; Tue, 18 Nov 2014 20:17:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqttI-0001dy-6A for submit@debbugs.gnu.org; Tue, 18 Nov 2014 20:17:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqttI-0001du-2f for submit@debbugs.gnu.org; Tue, 18 Nov 2014 20:17:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqttG-0006hh-Sq for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 20:17:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqttF-0001dZ-OA for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 20:17:02 -0500 Received: from mail-qc0-x22e.google.com ([2607:f8b0:400d:c01::22e]:46288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqttF-0001dO-JV for bug-gnu-emacs@gnu.org; Tue, 18 Nov 2014 20:17:01 -0500 Received: by mail-qc0-f174.google.com with SMTP id c9so8698764qcz.33 for ; Tue, 18 Nov 2014 17:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=RyYSXpqqAlMjgtRSp8DN1OT6pzCWcSRYhn1uVl0QxRs=; b=INx+miBNBA5QWYzSuU1dFSimTMHEp5IombFoCQB54+he/q6OC6PfOXGtJMzN3Pa35K i57qo/zUl31fsSFuu/1vvln6WwnbHSh7tuyzXDqfdI+lT6mOn5+0V0ytzjw2hq6m0T8x BNR9RlGuS6ikciwdnEzNezA7GdGPMJHOxHlKAU65Iab4oBzm6ahIVKdNXappfAoU60f0 oXwMbey31R2bCsCxTR/Kn0BX+xEGZXuBX/aJFv5HuyTLvg9TLj4w8tjLfQX/V94gJKIy pTsjKaBe3ln3XAnLwOnW8KAScuut5R0RZCu4xnfU80p+F+WKVKPEYnVHKkPaPCxLyWJC pong== MIME-Version: 1.0 X-Received: by 10.229.79.132 with SMTP id p4mr47689742qck.14.1416359820982; Tue, 18 Nov 2014 17:17:00 -0800 (PST) Received: by 10.229.214.67 with HTTP; Tue, 18 Nov 2014 17:17:00 -0800 (PST) Date: Wed, 19 Nov 2014 01:17:00 +0000 Message-ID: Subject: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' From: Richard Copley To: "bug-gnu-emacs@gnu.org" Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Visit a file under Subversion or RCS (not Git or Bazaar) and invoke `vc-print-log'. The log buffer should be put into log-view-mode, but it isn't. The buffer visiting the file is put into log-view-mode instead. In GNU Emacs 25.0.50.1 (x86_64-w64-mingw32) of 2014-11-18 on MACHINE Repository revision: 4a306d701b0dbe860c8ced70e0d93bd3129f0665 Windowing system distributor `Microsoft Corp.', version 6.3.9600 Configured using: `configure --prefix /c/emacs/emacs-20141217-222347 --disable-dependency-tracking --enable-locallisppath=%emacs_dir%/../site-lisp --with-wide-int --build=x86_64-w64-mingw32 'CPPFLAGS=-I G:/usr/include -I C:/GnuWin32/include 'LDFLAGS=-L G:/usr/lib -L C:/GnuWin32/lib'' Configured features: XPM JPEG TIFF GIF PNG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB Important settings: value of $LANG: ENG locale-coding-system: cp1252 Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils add-log log-view easymenu easy-mmode pcvs-util cl-extra vc cl-loaddefs cl-lib vc-dispatcher vc-svn make-mode time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) Memory information: ((conses 16 86122 7047) (symbols 56 18892 1) (miscs 48 52 94) (strings 32 15819 4424) (string-bytes 1 430435) (vectors 16 10614) (vector-slots 8 389547 5184) (floats 8 66 152) (intervals 56 327 1) (buffers 976 13)) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 18 20:57:23 2014 Received: (at control) by debbugs.gnu.org; 19 Nov 2014 01:57:23 +0000 Received: from localhost ([127.0.0.1]:37698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XquWI-0007iC-Tc for submit@debbugs.gnu.org; Tue, 18 Nov 2014 20:57:23 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:33926) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XquWG-0007i4-Q2 for control@debbugs.gnu.org; Tue, 18 Nov 2014 20:57:21 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XquWF-0007aK-Fs for control@debbugs.gnu.org; Tue, 18 Nov 2014 20:57:19 -0500 Date: Tue, 18 Nov 2014 20:57:19 -0500 Message-Id: Subject: control message for bug 19078 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 19101 19078 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 01:53:27 2014 Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 06:53:27 +0000 Received: from localhost ([127.0.0.1]:37751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xqz8o-0007sq-TW for submit@debbugs.gnu.org; Wed, 19 Nov 2014 01:53:27 -0500 Received: from fely.am-1.org ([78.47.74.50]:41341) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xqz8n-0007sh-2v for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 01:53:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=Z6eiNAoGENJ6E5HAPa7oftWbIs+HyemCx1m6w7U5acc=; b=KPAx6P+QB3CrniKLmgw1CqeE+r8nwOL5iUnRnk8TzFvm0vRQeeo2cgs27gWvpmGHQ/WDHcLHtlnKWicY4m6VmhDwNfhRNHaYm9qNaP9HpxcrRluRK6tB3m9McVMeGhis5HgO/h0r4gezDh0hul7SjOuUA6aolMvLDoz9OdABgDw=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xqz8l-0001P3-4F for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 06:53:23 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xqz8e-000552-0P for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 13:53:16 +0700 From: Ivan Shmakov To: 19101@debbugs.gnu.org Subject: Re: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode References: Date: Wed, 19 Nov 2014 06:53:15 +0000 In-Reply-To: (Richard Copley's message of "Wed, 19 Nov 2014 01:17:00 +0000") Message-ID: <8761eb8yw4.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19101 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Richard Copley writes: > Visit a file under Subversion or RCS (not Git or Bazaar) and invoke > `vc-print-log'. The log buffer should be put into log-view-mode, but > it isn't. The buffer visiting the file is put into log-view-mode > instead. This is likely to be caused by VC assuming that the =E2=80=98print-log=E2= =80=99 backend function leaves the log buffer as the current one. It doesn=E2=80=99t seem documented, and frankly, I=E2=80=99ve stumbled on = that myself while working on vc-mw.el. My suggestion would be for vc-print-log-internal to explicitly set-buffer after (successfully) invoking =E2=80=98print-log=E2=80=99. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 10:30:52 2014 Received: (at control) by debbugs.gnu.org; 19 Nov 2014 15:30:52 +0000 Received: from localhost ([127.0.0.1]:38435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr7DY-0006Zh-C5 for submit@debbugs.gnu.org; Wed, 19 Nov 2014 10:30:52 -0500 Received: from fely.am-1.org ([78.47.74.50]:41408) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr7DW-0006ZZ-8k for control@debbugs.gnu.org; Wed, 19 Nov 2014 10:30:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=+1CZnT+DuKCeydgfUexBfj5PRxoWGoZn1qZ7gf4zTQY=; b=TdYCXu3Yk8btsB9LINBIco4hpIUFE15jxIRbk/Sv6xXGtLYXF24WtqOwCzJc17BU+h5x4udGNPGculTr5PEH79OtGb5NKSxqsgMInuzus+sVAYCFCnXRXwuiGDln/OarCmv6YU/DNMlzxd9ZN3X2NHgIwyF0sAusbQ4nMzZqaEw=; Received: from host-46-241-38-202.bbcustomer.zsttk.net ([46.241.38.202] helo=waterlily.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Xr7DU-000559-T4 for control@debbugs.gnu.org; Wed, 19 Nov 2014 15:30:49 +0000 Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by waterlily.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xr7D2-0005zI-MH for control@debbugs.gnu.org; Wed, 19 Nov 2014 22:30:20 +0700 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xr7AD-0006Xs-Do for control@debbugs.gnu.org; Wed, 19 Nov 2014 22:27:25 +0700 From: Ivan Shmakov To: control@debbugs.gnu.org Subject: vc-print-log spills log-view-mode onto a wrong buffer Date: Wed, 19 Nov 2014 15:27:24 +0000 Message-ID: <874mtv5hyb.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) merge 19101 19078 thanks (Apparently the issue is the same.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 11:13:02 2014 Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 16:13:02 +0000 Received: from localhost ([127.0.0.1]:38454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr7sM-0000VG-0m for submit@debbugs.gnu.org; Wed, 19 Nov 2014 11:13:02 -0500 Received: from mtaout24.012.net.il ([80.179.55.180]:56855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr7sK-0000V0-3T for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 11:13:01 -0500 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NFA00300N97TH00@mtaout24.012.net.il> for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 18:05:22 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFA0032MNCX2B10@mtaout24.012.net.il>; Wed, 19 Nov 2014 18:05:22 +0200 (IST) Date: Wed, 19 Nov 2014 18:12:55 +0200 From: Eli Zaretskii Subject: Re: bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' In-reply-to: X-012-Sender: halo1@inter.net.il To: Richard Copley Message-id: <83egsz88zc.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19101 Cc: 19101@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 19 Nov 2014 01:17:00 +0000 > From: Richard Copley > > Visit a file under Subversion or RCS (not Git or Bazaar) and invoke > `vc-print-log'. The log buffer should be put into log-view-mode, but it > isn't. The buffer visiting the file is put into log-view-mode instead. Fixed on trunk (e9917c0). From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 11:14:38 2014 Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 16:14:38 +0000 Received: from localhost ([127.0.0.1]:38458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr7tt-0000Y7-FL for submit@debbugs.gnu.org; Wed, 19 Nov 2014 11:14:37 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:36605) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr7tn-0000Xs-Sj for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 11:14:36 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NFA00I00NOVZI00@a-mtaout22.012.net.il> for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 18:14:30 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFA00INWNS6HN80@a-mtaout22.012.net.il>; Wed, 19 Nov 2014 18:14:30 +0200 (IST) Date: Wed, 19 Nov 2014 18:14:27 +0200 From: Eli Zaretskii Subject: Re: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode In-reply-to: <8761eb8yw4.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83d28j88ws.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <8761eb8yw4.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19101 Cc: 19101@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Wed, 19 Nov 2014 06:53:15 +0000 > > >>>>> Richard Copley writes: > > > Visit a file under Subversion or RCS (not Git or Bazaar) and invoke > > `vc-print-log'. The log buffer should be put into log-view-mode, but > > it isn't. The buffer visiting the file is put into log-view-mode > > instead. > > This is likely to be caused by VC assuming that the ‘print-log’ > backend function leaves the log buffer as the current one. No, it's because Stefan moved the call to pop-to-buffer so that the part that turned on the mode was running in the wrong buffer. As for print-log backend function, those that I saw run inside with-temp-buffer, so they don't switch buffers. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 11:51:28 2014 Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 16:51:28 +0000 Received: from localhost ([127.0.0.1]:38467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr8TY-0001WG-Dy for submit@debbugs.gnu.org; Wed, 19 Nov 2014 11:51:28 -0500 Received: from fely.am-1.org ([78.47.74.50]:41418) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr8TS-0001W4-VP for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 11:51:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=JPBm2wGG24+fqIS8o9M/ABZFwgHAJz/LGPkSDN0PTpk=; b=Sp5te6MBS/957/lB25CQ219RciI6oCOG+aC5cGRO+E5uCVq1R9Up57x1fb5NKHvNZk2VM9inyw67HQnCqYP5vXxtf02nGmbcNJ8ZIgau53uQSQEk2OQoljO9HF3Umbw4WkDM5Z63NHfEGm+xIeJ54lJoct1D3wazabAZo31Ssh0=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xr8TR-0005eX-3Y for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 16:51:21 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xr8TK-0006jN-3s for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 23:51:14 +0700 From: Ivan Shmakov To: 19101@debbugs.gnu.org Subject: Re: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode References: <8761eb8yw4.fsf@violet.siamics.net> <83d28j88ws.fsf@gnu.org> Date: Wed, 19 Nov 2014 16:51:13 +0000 In-Reply-To: <83d28j88ws.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Nov 2014 18:14:27 +0200") Message-ID: <87ppcj3zi6.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19101 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov >>>>> Richard Copley writes: >>> Visit a file under Subversion or RCS (not Git or Bazaar) and invoke >>> `vc-print-log'. The log buffer should be put into log-view-mode, >>> but it isn't. The buffer visiting the file is put into >>> log-view-mode instead. >> This is likely to be caused by VC assuming that the =E2=80=98print-log= =E2=80=99 >> backend function leaves the log buffer as the current one. > No, it's because Stefan moved the call to pop-to-buffer so that the > part that turned on the mode was running in the wrong buffer. ACK, but that change seem to be dated 2014-11-05, while I=E2=80=99ve observed a similar issue (with non-Emacs code, though) before. Or so I think. > As for print-log backend function, those that I saw run inside > with-temp-buffer, so they don't switch buffers. There=E2=80=99re several which use vc-setup-buffer, which in turn calls set-buffer. Consider, e. g.: (defun vc-setup-buffer (buf) "Prepare BUF for executing a slave command and make it current." (let ((camefrom (current-buffer)) (olddir default-directory)) (set-buffer (get-buffer-create buf)) (defun vc-bzr-print-log (files buffer &optional shortlog start-revision lim= it) =E2=80=A6 ;; `vc-do-command' creates the buffer, but we need it before running ;; the command. (vc-setup-buffer buffer) (defun vc-git-print-log (files buffer &optional shortlog start-revision lim= it) =E2=80=A6 (let ((coding-system-for-read vc-git-commits-coding-system)) ;; `vc-do-command' creates the buffer, but we need it before running ;; the command. (vc-setup-buffer buffer) (defun vc-hg-print-log (files buffer &optional shortlog start-revision limi= t) =E2=80=A6 ;; `vc-do-command' creates the buffer, but we need it before running ;; the command. (vc-setup-buffer buffer) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 13:52:56 2014 Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 18:52:56 +0000 Received: from localhost ([127.0.0.1]:38594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAN5-0007Dd-RM for submit@debbugs.gnu.org; Wed, 19 Nov 2014 13:52:56 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:64596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAN2-0007DT-Uy for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 13:52:54 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NFA00A00UUTWZ00@a-mtaout23.012.net.il> for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 20:52:51 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFA00A1OV42XG00@a-mtaout23.012.net.il>; Wed, 19 Nov 2014 20:52:51 +0200 (IST) Date: Wed, 19 Nov 2014 20:52:47 +0200 From: Eli Zaretskii Subject: Re: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode In-reply-to: <87ppcj3zi6.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83vbmb6n0g.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <8761eb8yw4.fsf@violet.siamics.net> <83d28j88ws.fsf@gnu.org> <87ppcj3zi6.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19101 Cc: 19101@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Wed, 19 Nov 2014 16:51:13 +0000 > > >> This is likely to be caused by VC assuming that the ‘print-log’ > >> backend function leaves the log buffer as the current one. > > > No, it's because Stefan moved the call to pop-to-buffer so that the > > part that turned on the mode was running in the wrong buffer. > > ACK, but that change seem to be dated 2014-11-05, while I’ve > observed a similar issue (with non-Emacs code, though) before. > Or so I think. The problem reported in this bug started happening on 2014-11-05. > > As for print-log backend function, those that I saw run inside > > with-temp-buffer, so they don't switch buffers. > > There’re several which use vc-setup-buffer, which in turn calls > set-buffer. But no one relies on that. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 14:04:47 2014 Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 19:04:47 +0000 Received: from localhost ([127.0.0.1]:38616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAYZ-0007XO-1q for submit@debbugs.gnu.org; Wed, 19 Nov 2014 14:04:47 -0500 Received: from mail-qc0-f171.google.com ([209.85.216.171]:53623) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAYW-0007XG-Tl for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 14:04:45 -0500 Received: by mail-qc0-f171.google.com with SMTP id r5so962296qcx.30 for <19101@debbugs.gnu.org>; Wed, 19 Nov 2014 11:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=84eSOyRn7Ie1paJjisVY9+55ZSk8+LyxbIvx/1cWwV0=; b=bOBDH7K2TcLvIm1TM9aC8DncdFJeDnHpT/1O+bG4drIeWQkhaEbxfKzvIwCy5nSaT7 tk0nhguxy5nu4Xfo1/Z51DzyEZPomJws02i6llqYpHdk+6RBk/OcU9u1CXilPhnzFtfq TtyQFmzo4P6Hc0hQmuQR12ONR6Lqzc4QvGgBFBs5hkB1RsDlbhh7c8ZGDw8z0Q2TzryA fK9iSf42XYrRNAN9/jAQTBrMc1hCk6oLQC8oSHN9aUlqFn39Cc6GxIsOUmngPtIE3Cif od9PZc6atnCsAFUKlvf5bsLGYOw7nDJ6R8xv9Q1bcE85dOWjqXcllGDFOqcbD+3yndDP 42uA== MIME-Version: 1.0 X-Received: by 10.224.40.202 with SMTP id l10mr30037965qae.7.1416423884229; Wed, 19 Nov 2014 11:04:44 -0800 (PST) Received: by 10.229.214.67 with HTTP; Wed, 19 Nov 2014 11:04:44 -0800 (PST) In-Reply-To: <83egsz88zc.fsf@gnu.org> References: <83egsz88zc.fsf@gnu.org> Date: Wed, 19 Nov 2014 19:04:44 +0000 Message-ID: Subject: Re: bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' From: Richard Copley To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19101 Cc: 19101@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> Visit a file under Subversion or RCS (not Git or Bazaar) and invoke >> `vc-print-log'. The log buffer should be put into log-view-mode, but it >> isn't. The buffer visiting the file is put into log-view-mode instead. > > Fixed on trunk (e9917c0). Confirmed, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 14:17:58 2014 Received: (at 19101-done) by debbugs.gnu.org; 19 Nov 2014 19:17:58 +0000 Received: from localhost ([127.0.0.1]:38642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAlK-0000oM-8Y for submit@debbugs.gnu.org; Wed, 19 Nov 2014 14:17:58 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:65332) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAlH-0000oC-Bc for 19101-done@debbugs.gnu.org; Wed, 19 Nov 2014 14:17:56 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NFA00A00W99ZI00@a-mtaout23.012.net.il> for 19101-done@debbugs.gnu.org; Wed, 19 Nov 2014 21:17:54 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFA00AHUW9TXG30@a-mtaout23.012.net.il>; Wed, 19 Nov 2014 21:17:54 +0200 (IST) Date: Wed, 19 Nov 2014 21:17:51 +0200 From: Eli Zaretskii Subject: Re: bug#19101: 25.0.50; `vc-print-log' puts wrong buffer into `log-view-mode' In-reply-to: X-012-Sender: halo1@inter.net.il To: Richard Copley Message-id: <83oas36luo.fsf@gnu.org> References: <83egsz88zc.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19101-done Cc: 19101-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 19 Nov 2014 19:04:44 +0000 > From: Richard Copley > Cc: 19101@debbugs.gnu.org > > >> Visit a file under Subversion or RCS (not Git or Bazaar) and invoke > >> `vc-print-log'. The log buffer should be put into log-view-mode, but it > >> isn't. The buffer visiting the file is put into log-view-mode instead. > > > > Fixed on trunk (e9917c0). > > Confirmed, thanks. Thanks, closing. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 20 06:17:28 2014 Received: (at 19101) by debbugs.gnu.org; 20 Nov 2014 11:17:28 +0000 Received: from localhost ([127.0.0.1]:39087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrPjr-0001yO-Tj for submit@debbugs.gnu.org; Thu, 20 Nov 2014 06:17:28 -0500 Received: from fely.am-1.org ([78.47.74.50]:41560) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrPjp-0001yF-Ae for 19101@debbugs.gnu.org; Thu, 20 Nov 2014 06:17:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=wFq22558Flq0s8aWmxCPSZlpxJry5MTuseCEFZMs5KY=; b=GCYTlpHisinQVHWNkJll8yXyQSAsACshYCQE075zpvallwac/uLzA6QqXi31/sycQwookAhfrTUIsQZ5V+mJOowm0v6P+/12XONrtUdd5LNqJLkgkH/f32HghmhXZkhM9NgVav4dEv/Nix0y/+Nt2PYF9vrUGxQ2YnEav4Og1fs=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XrPjn-0005FR-EB for 19101@debbugs.gnu.org; Thu, 20 Nov 2014 11:17:23 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XrPjf-0000lu-AB for 19101@debbugs.gnu.org; Thu, 20 Nov 2014 18:17:15 +0700 From: Ivan Shmakov To: 19101@debbugs.gnu.org Subject: Re: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode References: <8761eb8yw4.fsf@violet.siamics.net> <83d28j88ws.fsf@gnu.org> <87ppcj3zi6.fsf@violet.siamics.net> <83vbmb6n0g.fsf@gnu.org> Date: Thu, 20 Nov 2014 11:17:14 +0000 In-Reply-To: <83vbmb6n0g.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Nov 2014 20:52:47 +0200") Message-ID: <87a93m15qd.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19101 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> Ivan Shmakov Date: Wed, 19 Nov 2014 16:51:13 +0000 >>>> This is likely to be caused by VC assuming that the =E2=80=98print-lo= g=E2=80=99 >>>> backend function leaves the log buffer as the current one. >>> No, it's because Stefan moved the call to pop-to-buffer so that the >>> part that turned on the mode was running in the wrong buffer. >> ACK, but that change seem to be dated 2014-11-05, while I=E2=80=99ve >> observed a similar issue (with non-Emacs code, though) before. Or >> so I think. > The problem reported in this bug started happening on 2014-11-05. I stand corrected; as it seems, I=E2=80=99ve first observed this issue with the then-recent development version of Emacs built 2014-11-08. >>> As for print-log backend function, those that I saw run inside >>> with-temp-buffer, so they don't switch buffers. >> There=E2=80=99re several which use vc-setup-buffer, which in turn calls >> set-buffer. > But no one relies on that. ACK, thanks for the clarification. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Fri Aug 15 21:24:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 18 Dec 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator