From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19074: 24.4; Bug in auth-source.el's search of OS X Keychain Resent-From: John Mastro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Nov 2014 04:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19074@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141620016918760 (code B ref -1); Mon, 17 Nov 2014 04:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2014 04:56:09 +0000 Received: from localhost ([127.0.0.1]:35691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqEMC-0004sR-Hq for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:56:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54139) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqDYu-0002Eg-RY for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:05:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqDYo-000655-H1 for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:05:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_50, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYo-00064t-Em for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:05:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYj-0004lk-0v for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 23:05:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqDYd-0005vM-6j for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 23:05:00 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYc-0005uo-Tu for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 23:04:55 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2A80D20979 for ; Sun, 16 Nov 2014 23:04:53 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Sun, 16 Nov 2014 23:04:53 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=jbm.io; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; s=mesmtp; bh=1QIDSAS4Yq TVaCvQp0xoGWgsL5E=; b=pQFn1wtOZNgu/qqvpiSkA95kIKXK9wBVdZEiaN8+X+ zOa2/OAsPfwc0ZBpzAzNYCgnGNRhvbj7B/EHO/g6aoHOoxY9bzyf3SG4bvp+/lzK Fhs+SBmMZ2wsyfn/LhjHBYGmZ5/Ihxl4XkqPkiQ4VTWQOcq7oMNtk7vSR1sLVp0Y E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type:content-transfer-encoding; s=smtpout; bh=1QIDSAS4YqTVaCvQp0xoGWgsL5E=; b=UgdDjCaW5cJkhphxX BRbSkKIdwxj55jyJJEyUzM525Lfe5+thrVNjazYOOQwpWQ0c2cXFA6L+WQQQOV26 FpgiA8xyUaYr3F+QsXmntjbmSKhoVdkFPec9ZDJWa2jYw3xzmGiVzkI/kruEGNkh 65TYviKufVXlvJhV0cvXE19Sas= X-Sasl-enc: 5xqETGdJ+U4pntUUWQr5wckB5Y7Dd6AvTt33sU1gGMgU 1416197092 Received: from nebula.local (unknown [23.240.150.50]) by mail.messagingengine.com (Postfix) with ESMTPA id 9A903C0000E for ; Sun, 16 Nov 2014 23:04:52 -0500 (EST) From: John Mastro Date: Sun, 16 Nov 2014 20:04:42 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Sun, 16 Nov 2014 23:56:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The library `auth-source.el' contains code to search OS X's Keychain (the backends `macos-keychain-generic' and `macos-keychain-internet'). Both backends are implemented by parsing the results of OS X's /usr/bin/security. This parsing is done by `auth-source-macos-keychain-search-items'. However, there's currently a problem with this code in both the master and emacs-24 branches. Specifically, the function `auth-source-macos-keychain-result-append' is called three times, but each time its result is ignored. A precise recipe from `emacs -Q' is a little difficult, because it depends on OS X and what you have in your keychain. However, the below is an example of what will work with the fix but not with the current code. A simple patch (against the emacs-24 batch) is attached. I don't yet have paperwork on file with FSF, but I believe this is short/trivial enough to be accepted anyway. ;; Example. With appropriate user/host, will be nil before patch but ;; return expected output after patch. (progn (require 'auth-source) (auth-source-macos-keychain-search :backend (auth-source-backend-parse 'macos-keychain-internet) :user "MY-USER" :host "MY-HOST")) Patch: diff --git a/lisp/gnus/auth-source.el b/lisp/gnus/auth-source.el index a50ad75..72ec5f4 100644 --- a/lisp/gnus/auth-source.el +++ b/lisp/gnus/auth-source.el @@ -1779,29 +1779,29 @@ entries for git.gnus.org: (while (not (eobp)) (cond ((looking-at "^password: \"\\(.+\\)\"$") - (auth-source-macos-keychain-result-append - ret - keychain-generic - "secret" - (lexical-let ((v (match-string 1))) - (lambda () v)))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "secret" + (lexical-let ((v (match-string 1))) + (lambda () v))))) ;; TODO: check if this is really the label ;; match 0x00000007 ="AppleID" ((looking-at "^[ ]+0x00000007 =\"\\(.+\\)\"") - (auth-source-macos-keychain-result-append - ret - keychain-generic - "label" - (match-string 1))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "label" + (match-string 1)))) ;; match "crtr"="aapl" ;; match "svce"="AppleID" ((looking-at "^[ ]+\"\\([a-z]+\\)\"[^=]+=\"\\(.+\\)\"") - (auth-source-macos-keychain-result-append - ret - keychain-generic - (match-string 1) - (match-string 2)))) - (forward-line))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + (match-string 1) + (match-string 2))))) + (forward-line))) ;; return `ret' iff it has the :secret key (and (plist-get ret :secret) (list ret)))) In GNU Emacs 24.4.1 (x86_64-apple-darwin14.0.0, NS apple-appkit-1343.14) of 2014-11-09 on nebula.local Windowing system distributor `Apple', version 10.3.1343 Configured using: `configure --prefix=/usr/local/Cellar/emacs/24.4 --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/24.4/share/info/emacs --without-dbus --with-gnutls --with-imagemagick --with-ns --disable-ns-self-contained' Important settings: locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: magit-auto-revert-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t flyspell-mode: t paredit-mode: t eldoc-mode: t elisp-slime-nav-mode: t whitespace-mode: t global-company-mode: t company-mode: t smartparens-global-strict-mode: t projectile-global-mode: t projectile-mode: t ido-vertical-mode: t ido-ubiquitous-mode: t flx-ido-mode: t ido-everywhere: t savehist-mode: t global-undo-tree-mode: t undo-tree-mode: t guide-key-mode: t global-discover-mode: t discover-mode: t recentf-mode: t winner-mode: t global-auto-revert-mode: t global-page-break-lines-mode: t page-break-lines-mode: t delete-selection-mode: t show-paren-mode: t global-hl-line-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: SPC f u n c t i o n SPC A-H-s-÷µ¹¶ M-o C-x b M-= M-= M-w C-x b C-g C-v C-v C-x b M-o C-q ` C-y ' M-q SPC l o o p s SPC t h r o u A-H-s-÷µ¹¶ g h SPC C-a C-e a n d SPC u s e s SPC M-o C-x b C-p C-p C-p M-f M-f M-f M-= M-= M-w C-x b M-o C-q ` C-y ' SPC t o SPC c o l l e A-H-s-÷µ¹¶ c t SPC i n f o r m a t i o n . SPC H o w e v e r , SPC t h e SPC r e s A-H-s-÷µ¹¶ u l C-h C-h C-g C-n C-k I n A-H-s-÷µ¹¶ C-c C-j C-c C-j M-^ M-e C-k , SPC t h e SPC r e t u r n SPC c v a l u e SPC o f A-H-s-÷µ¹¶ C-n w a s SPC b e i n g SPC i g n o r e d . SPC T h i A-H-s-÷µ¹¶ s SPC c a u s e d SPC t h e SPC i n t e n d e d SPC r e s u l t A-H-s-÷µ¹¶ SPC n o t SPC t o SPC b e SPC r e t u r n e d . C-n C-a C-k C-k C-p C-p C-p C-c C-c C-x C-f d r o e m p a t C-n C-h C-k q M-x r e p o r t - e m a c s - b u g Recent messages: Quit Indenting region...done Indenting region...done Indenting region...done Indenting region...done Indenting region...done Indenting region...done Saving file /Users/jbm/src/emacs/emacs/.git/COMMIT_EDITMSG... Wrote /Users/jbm/src/emacs/emacs/.git/COMMIT_EDITMSG Git finished Load-path shadows: None found. Features: (shadow emacsbug expand-region text-mode-expansions the-org-mode-expansions er-basic-expansions expand-region-core expand-region-custom magit-key-mode magit view tramp tramp-compat tramp-loaddefs trampver git-rebase-mode git-commit-mode log-edit pcvs-util add-log idomenu imenu eieio-opt ace-window ace-jump-mode diff-mode gnutls network-stream starttls tls mailalias mail-extr sort hippie-exp org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m ob-sh shell ob-python ob-clojure org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs mule-util mu4e mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-view epa derived epg browse-url mu4e-headers mu4e-compose mu4e-draft mu4e-actions rfc2368 smtpmail sendmail mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils doc-view image-mode find-dired dired+ image-dired image-file dired-x dired-aux dired mu4e-lists mu4e-about mu4e-vars message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader mu4e-meta smex misearch multi-isearch auth-source gnus-util mm-util mail-prsvr password-cache pp vc-git flyspell ispell jka-compr disp-table paredit eldoc elisp-slime-nav help-mode whitespace company-files company-keywords company-etags etags company-gtags company-dabbrev-code company-dabbrev company-capf company skewer-setup smartparens redshank-loader projectile ibuffer-vc ibuf-ext ibuffer pkg-info find-func lisp-mnt epl grep compile comint thingatpt ido-at-point ido-vertical-mode ido-ubiquitous warnings flx-ido flx ido ibuf-macs savehist saveplace undo-tree diff key-chord guide-key face-remap popwin discover makey man ansi-color recentf tree-widget wid-edit browse-kill-ring winner ring diminish solarized-dark-theme solarized-definitions cl autorevert filenotify page-break-lines delsel paren hl-line server exec-path-from-shell rx easy-mmode advice help-fns s ucs-normalize dash-functional dash subr-x pcase cl-macs gv finder-inf eieio byte-opt bytecomp byte-compile cconv eieio-core edmacro kmacro info easymenu slime-autoloads package epg-config cl-loaddefs cl-lib time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 759686 83978) (symbols 48 45387 18) (miscs 40 1637 1304) (strings 32 105380 22526) (string-bytes 1 3126833) (vectors 16 136035) (vector-slots 8 3699462 25228) (floats 8 25664 1278) (intervals 56 3552 721) (buffers 960 35)) -- jbm From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19074: Bug in auth-source.el's search of OS X Keychain References: In-Reply-To: Resent-From: John Mastro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Nov 2014 05:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19074@debbugs.gnu.org Received: via spool by 19074-submit@debbugs.gnu.org id=B19074.141620272327494 (code B ref 19074); Mon, 17 Nov 2014 05:39:02 +0000 Received: (at 19074) by debbugs.gnu.org; 17 Nov 2014 05:38:43 +0000 Received: from localhost ([127.0.0.1]:35697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqF1O-00079K-Dw for submit@debbugs.gnu.org; Mon, 17 Nov 2014 00:38:43 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47735) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqF1H-00078q-5y for 19074@debbugs.gnu.org; Mon, 17 Nov 2014 00:38:36 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 36C502078F for <19074@debbugs.gnu.org>; Mon, 17 Nov 2014 00:38:34 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Mon, 17 Nov 2014 00:38:34 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=jbm.io; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type; s=mesmtp; bh=0hqGY+Tu5rlpD3yAZoS3bGJ+6HI=; b=MQxP 8mE5CDXmlDgfNFfsoRtnUIk1xwd4STiJQJDnWhgdvFj0qC19n52SzfiuU8rQXtaN 7LzSkqZprrMDcJtku8VwbHH7M7LKjxl4zWTLg7eTVxjQxr2mTEMz0Gwyegbsujjp 7u/BIVCAIhMRykd/HGwqnawH2uRYf3GR4mO6mAw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type; s=smtpout; bh=0hqGY+Tu5rl pD3yAZoS3bGJ+6HI=; b=h4DVlSDC/OoQlNvio7s/Fp/sL/tQfSMiPuEnhYpVKs5 eA2iBHhzoIIZ0u4sr/c31AgXZQepeBRcMiU1344voPsfpgDW4YihA6Vd4L+gVf5U ZeQ5A5t2Dl3TdLFwHrp/X+nII9bvRrW2p07xaKb+EReZnVx3IFb1SPzEAt9ecCOs = X-Sasl-enc: ZxrnmJcFILB92tc5fGr9VWQ/hmlb3JIiySMoyfuWKsRn 1416202713 Received: from nebula.local (unknown [23.240.150.50]) by mail.messagingengine.com (Postfix) with ESMTPA id B7261680163 for <19074@debbugs.gnu.org>; Mon, 17 Nov 2014 00:38:33 -0500 (EST) From: John Mastro Date: Sun, 16 Nov 2014 21:38:32 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I accidentally copied only part of the patch in my original email. The full thing (via `git format-patch') follows. -- jbm >From 2b968a29ff2a01e316e09faa4d765aca08cf0121 Mon Sep 17 00:00:00 2001 From: John Mastro Date: Sun, 16 Nov 2014 19:41:10 -0800 Subject: [PATCH] Fix auth-source.el bug regarding the OS X Keychain In `auth-source-macos-keychain-search-items', the return value of `auth-source-macos-keychain-result-append' was being ignored. This caused the intended result not to be returned. --- lisp/gnus/auth-source.el | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/lisp/gnus/auth-source.el b/lisp/gnus/auth-source.el index a50ad75..72ec5f4 100644 --- a/lisp/gnus/auth-source.el +++ b/lisp/gnus/auth-source.el @@ -1779,29 +1779,29 @@ entries for git.gnus.org: (while (not (eobp)) (cond ((looking-at "^password: \"\\(.+\\)\"$") - (auth-source-macos-keychain-result-append - ret - keychain-generic - "secret" - (lexical-let ((v (match-string 1))) - (lambda () v)))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "secret" + (lexical-let ((v (match-string 1))) + (lambda () v))))) ;; TODO: check if this is really the label ;; match 0x00000007 ="AppleID" ((looking-at "^[ ]+0x00000007 =\"\\(.+\\)\"") - (auth-source-macos-keychain-result-append - ret - keychain-generic - "label" - (match-string 1))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "label" + (match-string 1)))) ;; match "crtr"="aapl" ;; match "svce"="AppleID" ((looking-at "^[ ]+\"\\([a-z]+\\)\"[^=]+=\"\\(.+\\)\"") - (auth-source-macos-keychain-result-append - ret - keychain-generic - (match-string 1) - (match-string 2)))) - (forward-line))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + (match-string 1) + (match-string 2))))) + (forward-line))) ;; return `ret' iff it has the :secret key (and (plist-get ret :secret) (list ret)))) -- 2.1.3 From unknown Tue Aug 19 01:58:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: John Mastro Subject: bug#19074: closed (Re: bug#19074: Bug in auth-source.el's search of OS X Keychain) Message-ID: References: <87a93eavwt.fsf@lifelogs.com> X-Gnu-PR-Message: they-closed 19074 X-Gnu-PR-Package: emacs Reply-To: 19074@debbugs.gnu.org Date: Wed, 26 Nov 2014 14:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1417011422-22700-1" This is a multi-part message in MIME format... ------------=_1417011422-22700-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19074: 24.4; Bug in auth-source.el's search of OS X Keychain which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19074@debbugs.gnu.org. --=20 19074: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19074 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1417011422-22700-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19074-done) by debbugs.gnu.org; 26 Nov 2014 14:16:48 +0000 Received: from localhost ([127.0.0.1]:45709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtdOh-0005tg-TR for submit@debbugs.gnu.org; Wed, 26 Nov 2014 09:16:48 -0500 Received: from mail-qc0-f169.google.com ([209.85.216.169]:42692) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtdOf-0005tX-Hm for 19074-done@debbugs.gnu.org; Wed, 26 Nov 2014 09:16:46 -0500 Received: by mail-qc0-f169.google.com with SMTP id w7so2116197qcr.28 for <19074-done@debbugs.gnu.org>; Wed, 26 Nov 2014 06:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=vwJaWtLmTIJzEAn7i76uG6jlklAKiZbFObzy3eZn59U=; b=HFhjhs031nO0zB7/PPXKzQjiGJmeuHk3OswpgYl4PGdZuWGdl0jjY+mxbcqIp+eaNM BAwOg/dZkClvsKJM1qqDggb7Z97lA6dRheFrTxtGN4YH5VNB40teCgL3KekSeO66ziRH ltipSSFuehxHT6tIqqMM2jEYOIrqIZugQM2Qo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=vwJaWtLmTIJzEAn7i76uG6jlklAKiZbFObzy3eZn59U=; b=D/EEUIK+ZZcS64vzJiuIDkRWqxiCnPDu40Hr4l74HwxSqAX3uhvw+bZ+wGfCyNmYSC 1JZov3Wc2uzreCW6MgHZGaBb0i4uREIj5R8e2ka0uxNDycWkmSPDOgNP1SKA11rDpeqi 7NO+5gvtQkkml4N9IVVJHfdkhVtU7VmfCAWKN2Hgo/PsMjlKdOcCeTmkgcc3+INNBdB6 n5bbj65WU8J0j16/NMmE+FVMjR0pHU5zduHtVShAitwEXm4HcRO6BAePFGAkK/whDcnP MF/CNmcg/hureLgV/JxroNfO/E2hUUDg3RRgOhg0M1bguCbMccjJgHObPHOCtZTOry+n a6yA== X-Gm-Message-State: ALoCoQnHAkdKwKgi223cuqcuLDhqVytnQ9lNT8L9mD46Kq8Q0Ep6u5iFkI+TyJM4Dp8fyqxqsuY/ X-Received: by 10.224.148.18 with SMTP id n18mr46237353qav.100.1417011404518; Wed, 26 Nov 2014 06:16:44 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id k6sm3967658qaz.41.2014.11.26.06.16.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 26 Nov 2014 06:16:43 -0800 (PST) From: Ted Zlatanov To: John Mastro , Glenn Morris , Stefan Monnier Subject: Re: bug#19074: Bug in auth-source.el's search of OS X Keychain Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 26 Nov 2014 09:17:22 -0500 In-Reply-To: (John Mastro's message of "Sun, 16 Nov 2014 21:38:32 -0800") Message-ID: <87a93eavwt.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19074-done Cc: Katsumi Yamaoka , 19074-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 16 Nov 2014 21:38:32 -0800 John Mastro wrote: JM> I accidentally copied only part of the patch in my original email. The JM> full thing (via `git format-patch') follows. Thanks, applied to emacs-24 branch as a bugfix: commit a10e36a5d7fe95830e3f93dc7ae6f65507738978 Author: John Mastro Date: Wed Nov 26 09:15:08 2014 -0500 auth-source: Fix Mac OS X keychain lookups. * auth-source.el (auth-source-macos-keychain-search-items): Return result of `auth-source-macos-keychain-result-append' (bug#19074). It will eventually get ported to Emacs master and to Gnus master as well. Glenn or Stefan, should I do that or wait for you? Thanks! Ted ------------=_1417011422-22700-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Nov 2014 04:56:09 +0000 Received: from localhost ([127.0.0.1]:35691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqEMC-0004sR-Hq for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:56:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54139) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqDYu-0002Eg-RY for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:05:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqDYo-000655-H1 for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:05:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_50, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYo-00064t-Em for submit@debbugs.gnu.org; Sun, 16 Nov 2014 23:05:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYj-0004lk-0v for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 23:05:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqDYd-0005vM-6j for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 23:05:00 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqDYc-0005uo-Tu for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 23:04:55 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2A80D20979 for ; Sun, 16 Nov 2014 23:04:53 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Sun, 16 Nov 2014 23:04:53 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=jbm.io; h= x-sasl-enc:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; s=mesmtp; bh=1QIDSAS4Yq TVaCvQp0xoGWgsL5E=; b=pQFn1wtOZNgu/qqvpiSkA95kIKXK9wBVdZEiaN8+X+ zOa2/OAsPfwc0ZBpzAzNYCgnGNRhvbj7B/EHO/g6aoHOoxY9bzyf3SG4bvp+/lzK Fhs+SBmMZ2wsyfn/LhjHBYGmZ5/Ihxl4XkqPkiQ4VTWQOcq7oMNtk7vSR1sLVp0Y E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:subject:date :message-id:mime-version:content-type:content-transfer-encoding; s=smtpout; bh=1QIDSAS4YqTVaCvQp0xoGWgsL5E=; b=UgdDjCaW5cJkhphxX BRbSkKIdwxj55jyJJEyUzM525Lfe5+thrVNjazYOOQwpWQ0c2cXFA6L+WQQQOV26 FpgiA8xyUaYr3F+QsXmntjbmSKhoVdkFPec9ZDJWa2jYw3xzmGiVzkI/kruEGNkh 65TYviKufVXlvJhV0cvXE19Sas= X-Sasl-enc: 5xqETGdJ+U4pntUUWQr5wckB5Y7Dd6AvTt33sU1gGMgU 1416197092 Received: from nebula.local (unknown [23.240.150.50]) by mail.messagingengine.com (Postfix) with ESMTPA id 9A903C0000E for ; Sun, 16 Nov 2014 23:04:52 -0500 (EST) From: John Mastro To: bug-gnu-emacs@gnu.org Subject: 24.4; Bug in auth-source.el's search of OS X Keychain Date: Sun, 16 Nov 2014 20:04:42 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 16 Nov 2014 23:56:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The library `auth-source.el' contains code to search OS X's Keychain (the backends `macos-keychain-generic' and `macos-keychain-internet'). Both backends are implemented by parsing the results of OS X's /usr/bin/security. This parsing is done by `auth-source-macos-keychain-search-items'. However, there's currently a problem with this code in both the master and emacs-24 branches. Specifically, the function `auth-source-macos-keychain-result-append' is called three times, but each time its result is ignored. A precise recipe from `emacs -Q' is a little difficult, because it depends on OS X and what you have in your keychain. However, the below is an example of what will work with the fix but not with the current code. A simple patch (against the emacs-24 batch) is attached. I don't yet have paperwork on file with FSF, but I believe this is short/trivial enough to be accepted anyway. ;; Example. With appropriate user/host, will be nil before patch but ;; return expected output after patch. (progn (require 'auth-source) (auth-source-macos-keychain-search :backend (auth-source-backend-parse 'macos-keychain-internet) :user "MY-USER" :host "MY-HOST")) Patch: diff --git a/lisp/gnus/auth-source.el b/lisp/gnus/auth-source.el index a50ad75..72ec5f4 100644 --- a/lisp/gnus/auth-source.el +++ b/lisp/gnus/auth-source.el @@ -1779,29 +1779,29 @@ entries for git.gnus.org: (while (not (eobp)) (cond ((looking-at "^password: \"\\(.+\\)\"$") - (auth-source-macos-keychain-result-append - ret - keychain-generic - "secret" - (lexical-let ((v (match-string 1))) - (lambda () v)))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "secret" + (lexical-let ((v (match-string 1))) + (lambda () v))))) ;; TODO: check if this is really the label ;; match 0x00000007 ="AppleID" ((looking-at "^[ ]+0x00000007 =\"\\(.+\\)\"") - (auth-source-macos-keychain-result-append - ret - keychain-generic - "label" - (match-string 1))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + "label" + (match-string 1)))) ;; match "crtr"="aapl" ;; match "svce"="AppleID" ((looking-at "^[ ]+\"\\([a-z]+\\)\"[^=]+=\"\\(.+\\)\"") - (auth-source-macos-keychain-result-append - ret - keychain-generic - (match-string 1) - (match-string 2)))) - (forward-line))) + (setq ret (auth-source-macos-keychain-result-append + ret + keychain-generic + (match-string 1) + (match-string 2))))) + (forward-line))) ;; return `ret' iff it has the :secret key (and (plist-get ret :secret) (list ret)))) In GNU Emacs 24.4.1 (x86_64-apple-darwin14.0.0, NS apple-appkit-1343.14) of 2014-11-09 on nebula.local Windowing system distributor `Apple', version 10.3.1343 Configured using: `configure --prefix=/usr/local/Cellar/emacs/24.4 --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/24.4/share/info/emacs --without-dbus --with-gnutls --with-imagemagick --with-ns --disable-ns-self-contained' Important settings: locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: magit-auto-revert-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t flyspell-mode: t paredit-mode: t eldoc-mode: t elisp-slime-nav-mode: t whitespace-mode: t global-company-mode: t company-mode: t smartparens-global-strict-mode: t projectile-global-mode: t projectile-mode: t ido-vertical-mode: t ido-ubiquitous-mode: t flx-ido-mode: t ido-everywhere: t savehist-mode: t global-undo-tree-mode: t undo-tree-mode: t guide-key-mode: t global-discover-mode: t discover-mode: t recentf-mode: t winner-mode: t global-auto-revert-mode: t global-page-break-lines-mode: t page-break-lines-mode: t delete-selection-mode: t show-paren-mode: t global-hl-line-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: SPC f u n c t i o n SPC A-H-s-÷µ¹¶ M-o C-x b M-= M-= M-w C-x b C-g C-v C-v C-x b M-o C-q ` C-y ' M-q SPC l o o p s SPC t h r o u A-H-s-÷µ¹¶ g h SPC C-a C-e a n d SPC u s e s SPC M-o C-x b C-p C-p C-p M-f M-f M-f M-= M-= M-w C-x b M-o C-q ` C-y ' SPC t o SPC c o l l e A-H-s-÷µ¹¶ c t SPC i n f o r m a t i o n . SPC H o w e v e r , SPC t h e SPC r e s A-H-s-÷µ¹¶ u l C-h C-h C-g C-n C-k I n A-H-s-÷µ¹¶ C-c C-j C-c C-j M-^ M-e C-k , SPC t h e SPC r e t u r n SPC c v a l u e SPC o f A-H-s-÷µ¹¶ C-n w a s SPC b e i n g SPC i g n o r e d . SPC T h i A-H-s-÷µ¹¶ s SPC c a u s e d SPC t h e SPC i n t e n d e d SPC r e s u l t A-H-s-÷µ¹¶ SPC n o t SPC t o SPC b e SPC r e t u r n e d . C-n C-a C-k C-k C-p C-p C-p C-c C-c C-x C-f d r o e m p a t C-n C-h C-k q M-x r e p o r t - e m a c s - b u g Recent messages: Quit Indenting region...done Indenting region...done Indenting region...done Indenting region...done Indenting region...done Indenting region...done Saving file /Users/jbm/src/emacs/emacs/.git/COMMIT_EDITMSG... Wrote /Users/jbm/src/emacs/emacs/.git/COMMIT_EDITMSG Git finished Load-path shadows: None found. Features: (shadow emacsbug expand-region text-mode-expansions the-org-mode-expansions er-basic-expansions expand-region-core expand-region-custom magit-key-mode magit view tramp tramp-compat tramp-loaddefs trampver git-rebase-mode git-commit-mode log-edit pcvs-util add-log idomenu imenu eieio-opt ace-window ace-jump-mode diff-mode gnutls network-stream starttls tls mailalias mail-extr sort hippie-exp org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m ob-sh shell ob-python ob-clojure org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs mule-util mu4e mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-view epa derived epg browse-url mu4e-headers mu4e-compose mu4e-draft mu4e-actions rfc2368 smtpmail sendmail mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils doc-view image-mode find-dired dired+ image-dired image-file dired-x dired-aux dired mu4e-lists mu4e-about mu4e-vars message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader mu4e-meta smex misearch multi-isearch auth-source gnus-util mm-util mail-prsvr password-cache pp vc-git flyspell ispell jka-compr disp-table paredit eldoc elisp-slime-nav help-mode whitespace company-files company-keywords company-etags etags company-gtags company-dabbrev-code company-dabbrev company-capf company skewer-setup smartparens redshank-loader projectile ibuffer-vc ibuf-ext ibuffer pkg-info find-func lisp-mnt epl grep compile comint thingatpt ido-at-point ido-vertical-mode ido-ubiquitous warnings flx-ido flx ido ibuf-macs savehist saveplace undo-tree diff key-chord guide-key face-remap popwin discover makey man ansi-color recentf tree-widget wid-edit browse-kill-ring winner ring diminish solarized-dark-theme solarized-definitions cl autorevert filenotify page-break-lines delsel paren hl-line server exec-path-from-shell rx easy-mmode advice help-fns s ucs-normalize dash-functional dash subr-x pcase cl-macs gv finder-inf eieio byte-opt bytecomp byte-compile cconv eieio-core edmacro kmacro info easymenu slime-autoloads package epg-config cl-loaddefs cl-lib time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 759686 83978) (symbols 48 45387 18) (miscs 40 1637 1304) (strings 32 105380 22526) (string-bytes 1 3126833) (vectors 16 136035) (vector-slots 8 3699462 25228) (floats 8 25664 1278) (intervals 56 3552 721) (buffers 960 35)) -- jbm ------------=_1417011422-22700-1-- From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19074: Bug in auth-source.el's search of OS X Keychain Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Nov 2014 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: John Mastro Cc: Glenn Morris , Katsumi Yamaoka , 19074-done@debbugs.gnu.org Received: via spool by 19074-done@debbugs.gnu.org id=D19074.14170174365318 (code D ref 19074); Wed, 26 Nov 2014 15:58:02 +0000 Received: (at 19074-done) by debbugs.gnu.org; 26 Nov 2014 15:57:16 +0000 Received: from localhost ([127.0.0.1]:46369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtexw-0001Nh-35 for submit@debbugs.gnu.org; Wed, 26 Nov 2014 10:57:16 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:36997) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtexu-0001NZ-EI for 19074-done@debbugs.gnu.org; Wed, 26 Nov 2014 10:57:14 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sAQFvDfc001349; Wed, 26 Nov 2014 10:57:13 -0500 Received: by pastel.home (Postfix, from userid 20848) id D94D44820; Wed, 26 Nov 2014 10:57:12 -0500 (EST) From: Stefan Monnier Message-ID: References: <87a93eavwt.fsf@lifelogs.com> Date: Wed, 26 Nov 2014 10:57:12 -0500 In-Reply-To: <87a93eavwt.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 26 Nov 2014 09:17:22 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5137=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5137> : inlines <1562> : streams <1349016> : uri <1836228> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > It will eventually get ported to Emacs master and to Gnus master as > well. Glenn or Stefan, should I do that or wait for you? Feel free to merge emacs-24 into master any time you feel like it. BUT: I really mean "merge the branch", not "cherrypick my change". Stefan From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19074: Bug in auth-source.el's search of OS X Keychain In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Nov 2014 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19074-done@debbugs.gnu.org Cc: John Mastro , Glenn Morris , Stefan Monnier Received: via spool by 19074-done@debbugs.gnu.org id=D19074.141704104727906 (code D ref 19074); Wed, 26 Nov 2014 22:31:02 +0000 Received: (at 19074-done) by debbugs.gnu.org; 26 Nov 2014 22:30:47 +0000 Received: from localhost ([127.0.0.1]:46696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtl6k-0007G2-OA for submit@debbugs.gnu.org; Wed, 26 Nov 2014 17:30:46 -0500 Received: from mail-halifax.hostforweb.net ([205.234.137.17]:36132 helo=halifax.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtl6e-0007Fm-Ls for 19074-done@debbugs.gnu.org; Wed, 26 Nov 2014 17:30:41 -0500 Received: from [127.0.0.1] (port=55627 helo=localhost) by halifax.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1Xtl6Z-0006Xh-Uo; Wed, 26 Nov 2014 16:30:37 -0600 Date: Thu, 27 Nov 2014 07:30:12 +0900 Message-ID: From: Katsumi Yamaoka References: <87a93eavwt.fsf@lifelogs.com> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?UTF-8?Q?=E7=9C=9F?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:O/29aqPYFCeVoDXeZpA9Bs33T6E= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - halifax.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: halifax.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed, 26 Nov 2014 09:17:22 -0500, Ted Zlatanov wrote: > Thanks, applied to emacs-24 branch as a bugfix: [...] > auth-source: Fix Mac OS X keychain lookups. > * auth-source.el (auth-source-macos-keychain-search-items): Return > result of `auth-source-macos-keychain-result-append' (bug#19074). > It will eventually get ported to Emacs master and to Gnus master as > well. Glenn or Stefan, should I do that or wait for you? I've installed the fix in the Gnus master in advance of merging it to the Emacs master. ;) Thanks. From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19074: Bug in auth-source.el's search of OS X Keychain Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Nov 2014 01:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Katsumi Yamaoka Cc: John Mastro , 19074-done@debbugs.gnu.org Received: via spool by 19074-done@debbugs.gnu.org id=D19074.141705143712776 (code D ref 19074); Thu, 27 Nov 2014 01:24:02 +0000 Received: (at 19074-done) by debbugs.gnu.org; 27 Nov 2014 01:23:57 +0000 Received: from localhost ([127.0.0.1]:46750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtnoL-0003K0-3A for submit@debbugs.gnu.org; Wed, 26 Nov 2014 20:23:57 -0500 Received: from mail-qg0-f47.google.com ([209.85.192.47]:46460) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtnoJ-0003Jt-H2 for 19074-done@debbugs.gnu.org; Wed, 26 Nov 2014 20:23:56 -0500 Received: by mail-qg0-f47.google.com with SMTP id z60so2858954qgd.20 for <19074-done@debbugs.gnu.org>; Wed, 26 Nov 2014 17:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=I4r+szJ1BV1L/Mzg2dQ4zEx90BMlTXZDurOUZko86oE=; b=eZVzJ528xuKLwR3+L+HmVwPd3eODnOmcm3A+U4b+LNiMo8Iq7oZNR4tZibiYX5SYRB avN4372tN244RsGIeYUVD8GX2Eh1drSqGm/0M+btFwbDPyF0lJiSAR5xDQBIe19aLqAT 28oXc5Jp8pf7kCzfXp94sHcFE+to4nnXaC+IU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=I4r+szJ1BV1L/Mzg2dQ4zEx90BMlTXZDurOUZko86oE=; b=NS04v/ygw/MpgBmoNGzNOqp6CTRMzO00tb4RmBYOghyLijitmUEdTXCO5tw52HvM9f iPys2+DEdSMQiWXzHrZQWX9YvJa63waLugrRnkowdlDmSToE+/ZGmYbW9Djquv80Vsl1 Nu+YjAbtuAuYuS0OOwy6vtyDEofZz6Myd3xFldx21exyDQQgRKAEU8t0W7sa5/sJoDEe 2GvrLRrZ33qpNhuqDZeUaHbyg0x1mUEsLcysgyHMPqxAtW1Fc6iBtFkMq+rWcJA3Z0Nb M3bo6Ji9QvH/U3U/z6iSRcm+OMRbOIXmSkKQ/qTJUEE8uwfGysZcLybbAjABQcWkksRc 9umg== X-Gm-Message-State: ALoCoQloCMMBG0aMoiDYLafQQVNnmXkQnmrrS64ajaEAaFYPgNmiRrOnZXpjwWDwfsjZu1dTipzf X-Received: by 10.140.101.68 with SMTP id t62mr49285806qge.92.1417051435052; Wed, 26 Nov 2014 17:23:55 -0800 (PST) Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id p10sm5384410qab.39.2014.11.26.17.23.54 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 26 Nov 2014 17:23:54 -0800 (PST) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <87a93eavwt.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 26 Nov 2014 20:24:33 -0500 In-Reply-To: (Katsumi Yamaoka's message of "Thu, 27 Nov 2014 07:30:12 +0900") Message-ID: <8738958mge.fsf@lifelogs.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, 27 Nov 2014 07:30:12 +0900 Katsumi Yamaoka wrote: KY> On Wed, 26 Nov 2014 09:17:22 -0500, Ted Zlatanov wrote: >> Thanks, applied to emacs-24 branch as a bugfix: ... >> It will eventually get ported to Emacs master and to Gnus master as >> well. Glenn or Stefan, should I do that or wait for you? KY> I've installed the fix in the Gnus master in advance of merging KY> it to the Emacs master. ;) Thanks. Excellent. I started with emacs-24 because I wanted to make sure it showed up in the next 24.x release and we're asked to make changes there before master/trunk, that's why this commit was a bit unusual. Thanks for your help! Ted