From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 16 05:01:05 2014 Received: (at submit) by debbugs.gnu.org; 16 Nov 2014 10:01:05 +0000 Received: from localhost ([127.0.0.1]:34314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpwdk-0001dk-Cs for submit@debbugs.gnu.org; Sun, 16 Nov 2014 05:01:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56922) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpwdh-0001cz-Gl for submit@debbugs.gnu.org; Sun, 16 Nov 2014 05:01:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpwdT-00010r-68 for submit@debbugs.gnu.org; Sun, 16 Nov 2014 05:00:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:32927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpwdT-00010m-3q for submit@debbugs.gnu.org; Sun, 16 Nov 2014 05:00:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpwdK-00048e-0d for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 05:00:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpwdA-000102-Vk for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 05:00:37 -0500 Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:46677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpwdA-0000zt-Nm for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 05:00:28 -0500 Received: by mail-pd0-f177.google.com with SMTP id v10so19089502pde.8 for ; Sun, 16 Nov 2014 02:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=M8ZKZzUEUHVLU2XzXglKY85WOMI5ugeCboFE3KdLscg=; b=rfLZ3pdfiiYMMl+usdFw8ESn3sbFSU4gPHfvM4SsdB+wTk1DXcOp6rty9fscDBbe0a AviNx/HmAUOzg2vq8wcJCvQNvXGbDLYUU6lip054ts7fxVT7NpxsOSQAd83Rk+VLJ/VY rQuEefEPePYnJkviVHULi8pWgLz6DDIOJXsA5kOZIlBnh6rQ9tbIK9TTkXlL0zf5inT4 LsQuRbRZqfdlTqJ4+5lHO131yaYXTnL7IcrJQ24/ncTXEFhid3h7OMRWTR8ipK+T9i+3 UH7SH31iab6hRicstOvcidVPuzMZCHxsphpMTD8dG/N2CGlBx6ngXbdiLQ/misNtCRR/ 2wcA== X-Received: by 10.66.244.105 with SMTP id xf9mr9287396pac.20.1416132027268; Sun, 16 Nov 2014 02:00:27 -0800 (PST) Received: from fortuna ([221.222.150.252]) by mx.google.com with ESMTPSA id w5sm32187056pds.25.2014.11.16.02.00.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2014 02:00:26 -0800 (PST) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 25.0.50; nadvice and interactive-form X-Debbugs-CC: Stefan Monnier Date: Sun, 16 Nov 2014 18:00:21 +0800 Message-ID: <87y4rbtqh6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Start emacs and load a file with these lines: --8<---------------cut here---------------start------------->8--- (advice-add 'just-one-space :before #'change-interactive-form) (defun change-interactive-form (&optional x y) (interactive (list 1 1)) (princ (list x y))) --8<---------------cut here---------------end--------------->8--- M-x just-one-space prints (1 nil) 2. Start emacs and load a file with these lines: --8<---------------cut here---------------start------------->8--- (defun change-interactive-form (&optional x y) (interactive (list 1 1)) (princ (list x y))) (advice-add 'just-one-space :before #'change-interactive-form) --8<---------------cut here---------------end--------------->8--- M-x just-one-space errs: apply: Wrong number of arguments: (0 . 1), 2 Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 00:09:13 2017 Received: (at control) by debbugs.gnu.org; 22 Feb 2017 05:09:13 +0000 Received: from localhost ([127.0.0.1]:49552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgPAv-0007rX-KG for submit@debbugs.gnu.org; Wed, 22 Feb 2017 00:09:13 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:34035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgPAt-0007rL-SL for control@debbugs.gnu.org; Wed, 22 Feb 2017 00:09:12 -0500 Received: by mail-io0-f174.google.com with SMTP id l66so1868761ioi.1 for ; Tue, 21 Feb 2017 21:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=Bp6qvmvb8/9GEhbHrrk4ajEMQccA/Af2OoGLnU0/Uzo=; b=GA7HtbwAggNM4X8jMj5SJjREAn3aGau2Jt6lA+M7KmE8bw4lAJ37qWCo3JccGPI2zm Ad00mLgIaJIu0O82ymza+dAnTv8F7rMGZhSlqEvs1dST8j3s+amwWi2+hpcXEwdFJC3C yB32aVtpoGJWycFfhB+ZkYdPqYEcJJDkHvrDZ7vqpFbFS1bKOCVxpvfU5Wa4X6lK1CdF P2lqgxu9jragZyOXQ14IFcHKxKJNADGKjH8KYOfcBdvqdJN3s6YTO1t1Tz0+wfDCQMqB bXmr/N4OeI80w6cAF6oA72GkmWiU1iD5G6VuZnapkeiwc6qVEXJ5KuMm45alxwLV14vO UO/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=Bp6qvmvb8/9GEhbHrrk4ajEMQccA/Af2OoGLnU0/Uzo=; b=AuejhTsF5PFxG8jcKhO3TKykwXlI1sPyzrF9VLAb/rmFsudyqcRz/yV5lPIb4EMmJZ 7Wl8ucR+gF6wwv0bj0MLgl0M6nBwHy0ofbhj01CROaUEdrsfbi7Q7n2VcTzm9Ib5GheN izwvgpJrYfhVXqeMoCjXUzV7JPP+vjk5q21Z2vH5njLyFPJsGbhgFIO2aiLShzVZwFID YiAfsigZXH7vh8brxDG2zHsyn/KzTHLBuzpejBxjmulbrxnsQkG/oqt/1sFhIebBqG3+ 1JVKpko7nfnvglQKn7SwL+yV3vbAx8nZuXVdgPgOvbusBbn2myrdv+00npDhlT4PQQ/B tq0w== X-Gm-Message-State: AMke39l73ad+wai4h4wn8ejj+7ARhprGhgWkUKd6XvHqcuwwIOSp4PdJobE4yisna2AUJA== X-Received: by 10.107.129.9 with SMTP id c9mr26290170iod.23.1487740146237; Tue, 21 Feb 2017 21:09:06 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j14sm477743itd.0.2017.02.21.21.09.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Feb 2017 21:09:05 -0800 (PST) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #19066 Date: Wed, 22 Feb 2017 00:10:18 -0500 Message-ID: <8760k2hkud.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) found 19066 25.2 tags 19066 confirmed quit From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 22:11:24 2021 Received: (at 19066) by debbugs.gnu.org; 28 May 2021 02:11:24 +0000 Received: from localhost ([127.0.0.1]:53322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmRy8-000349-Dz for submit@debbugs.gnu.org; Thu, 27 May 2021 22:11:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmRy7-00033w-1y for 19066@debbugs.gnu.org; Thu, 27 May 2021 22:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bO6YBW2pAANmvIrYH1nOTNKixj/0WWkZtq+IdZfSmT0=; b=akp1rDF5bm1tw1hC/2eLmXcs20 xpFJ2PKSpr69IyMihM0wcFgTUlX+aZaOpw8DJVwMvFLygB16k5lx6h9FBWBxlyrMjA+1m5+qbUCMk RBbErrEJcaSTtHr9gfOXIgUY+mhhkJMGtgSpLQ6Ie3X/OUs6P1qVFebekTmbn8HH+Pss=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmRxx-0003XC-RX; Fri, 28 May 2021 04:11:16 +0200 From: Lars Ingebrigtsen To: Leo Liu Subject: Re: bug#19066: 25.0.50; nadvice and interactive-form References: <87y4rbtqh6.fsf@gmail.com> X-Now-Playing: The Residents's _The King & Eye: RMX_: "A Fool such as I" Date: Fri, 28 May 2021 04:11:13 +0200 In-Reply-To: <87y4rbtqh6.fsf@gmail.com> (Leo Liu's message of "Sun, 16 Nov 2014 18:00:21 +0800") Message-ID: <87r1hry5dq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Leo Liu writes: > 1. Start emacs and load a file with these lines: > > (advice-add 'just-one-space :before #'change-interactive-form) > (defun change-interactive-form (&optional x y) > (interactive (list 1 1)) > (pri [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19066 Cc: 19066@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Leo Liu writes: > 1. Start emacs and load a file with these lines: > > (advice-add 'just-one-space :before #'change-interactive-form) > (defun change-interactive-form (&optional x y) > (interactive (list 1 1)) > (princ (list x y))) > > M-x just-one-space prints (1 nil) > > 2. Start emacs and load a file with these lines: > > (defun change-interactive-form (&optional x y) > (interactive (list 1 1)) > (princ (list x y))) > (advice-add 'just-one-space :before #'change-interactive-form) > > M-x just-one-space errs: apply: Wrong number of arguments: (0 . 1), 2 So whether this works depends on whether `change-interactive-form' is defined or not when `advice-add' is run? (The only difference here is the order.) Perhaps Stefan has some insights here; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 13:27:05 2021 Received: (at 19066) by debbugs.gnu.org; 30 May 2021 17:27:05 +0000 Received: from localhost ([127.0.0.1]:60286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnPDN-0000Kf-8o for submit@debbugs.gnu.org; Sun, 30 May 2021 13:27:05 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnPDI-0000K6-JC for 19066@debbugs.gnu.org; Sun, 30 May 2021 13:27:03 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E58E88009E; Sun, 30 May 2021 13:26:54 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 816568040B; Sun, 30 May 2021 13:26:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622395613; bh=tjyrVFC8kfKAeAt0NHel/X8JeOgmUZJz/sMrSAAegh8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UJ8dcQjX0OiaORj+Lv4XUfYzqLbAMxPLKoXg0YF/MSYkk/Hr/CDogIwqXb79JrF0k sQpas9pmUBtb0x3xbnT4YYmoxpCQCQlK5mtKL+oIjos7mqAxyH7RTmyWWu28cpjh5f 7Z93n1clxBK+N5tl24IvmwRJrv3bvOktNwfWNbRMF3JGtMSzQVQ6813/OCd+rOKkAF g8D8s8b4ezPJBcNRC48ULEphGfkIDOPu6qNHuR0lRoYufxFj61MlzgaOn9fUEJ0ZLF OQBf+O1oo8rw5XgL8mOUplIrrB/jkoQ3kAvMA8EdCFuoQ2Nv1ev/rU+0uRZyeija9k WLGnWwiQkMeoA== Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 41845120D90; Sun, 30 May 2021 13:26:53 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19066: 25.0.50; nadvice and interactive-form Message-ID: References: <87y4rbtqh6.fsf@gmail.com> <87r1hry5dq.fsf@gnus.org> Date: Sun, 30 May 2021 13:26:52 -0400 In-Reply-To: <87r1hry5dq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 28 May 2021 04:11:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19066 Cc: Leo Liu , 19066@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-05-28 04:11:13] wrote: > Leo Liu writes: >> 1. Start emacs and load a file with these lines: >> >> (advice-add 'just-one-space :before #'change-interactive-form) >> (defun change-interactive-form (&optional x y) >> (interactive (list 1 1)) >> (princ (list x y))) >> >> M-x just-one-space prints (1 nil) >> >> 2. Start emacs and load a file with these lines: >> >> (defun change-interactive-form (&optional x y) >> (interactive (list 1 1)) >> (princ (list x y))) >> (advice-add 'just-one-space :before #'change-interactive-form) >> >> M-x just-one-space errs: apply: Wrong number of arguments: (0 . 1), 2 > > So whether this works depends on whether `change-interactive-form' is > defined or not when `advice-add' is run? (The only difference here is > the order.) > Perhaps Stefan has some insights here; added to the CCs. [ Side note: the correct/desired behavior is the one described by (2), i.e. it should signal a "Wrong number of arguments" (tho after printing (1 1)). ] `advice-add` creates a new function object which is a "composition" of the old function and the advice that's added to it. In the case where `change-interactive-form` is defined later, one way to make this work right would be for `advice-add` to put some kind of "watcher" on (symbol-function 'change-interactive-form) to recompute the interactive form of the "composed function". Another way would be to make the interactive form of the "compose function" more dynamic: make it re-checks the interactive form of every advice function every time. That's probably the better option. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 01:43:46 2021 Received: (at 19066) by debbugs.gnu.org; 31 May 2021 05:43:46 +0000 Received: from localhost ([127.0.0.1]:60766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnaiI-0006JC-0q for submit@debbugs.gnu.org; Mon, 31 May 2021 01:43:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnaiG-0006Iy-6U for 19066@debbugs.gnu.org; Mon, 31 May 2021 01:43:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i1htptAEHSNEQ+pqX9D4N3fPunxSZBC4WsjiHK9v/KQ=; b=m6+sDpKHXR2VT/nXRoEq7H0eU5 Ay4L8CGthgOMrtxMBz3v1SHJdW4OqC/lyBq7JipfzoWybvVtBUwk+1XZV6u/TMClUZO3pKA4ubNRQ K3mHLhQ+8cI2inreU30d2kPvZ1K6jnPW0NSzKjvgIxhrXBCWOlqjHFgh1BqYNIlWaz3s=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnai7-0005zU-4n; Mon, 31 May 2021 07:43:37 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19066: 25.0.50; nadvice and interactive-form References: <87y4rbtqh6.fsf@gmail.com> <87r1hry5dq.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEUWEhJEOztlW1qG eneMgHzQw7+ompgsJib///9RCNRGAAAAAWJLR0QIht6VegAAAAd0SU1FB+UFHwUdOJti/kEAAAGB SURBVDjLlZLNUoMwEMeDOubKojNcJTjj1YGOD9AyvEE5Oy3Ea9bLvr7ZTUhbpH78Lwn7y36jVGYW atvWPCml7gbrNe0v9O7BjRX5r4gP9ji9JjAJkOPQW8uhbgUMU4woh4AY6lKXoOskGTuugGkFjLGK YT2HpP9j8iUY/g2uhfJjb/s1oJRGMPVbsPiRjb7PXCVpAihMUTe8q8axxWlSJMICvIoKDIMMkubl Ajipatx+NiFEUgD247zkbtN3uzxsMOcm4+7suOl2Au73+zwzddtJM/3o17INyTkiXxT6eoBTv6gf pQmdIkdYPR4qIOR+KFFCKOpW1ts82zgSlP4B0Gz4Bxv6NESf2vlo3qt6aIQec8lBbPUHcWG1qWvT MsgqKLXYS/+EV9A0RjxKQgSKcvwAIY4doZQiifjCjwSUyCHkvQwfZwDhoBmVyUMsM4mppEEh0ceF I4yDUtTZpNUpuO9kOV4X/egbUYlcYyH27zrz16GB9BUb0os0p1ZPtx/0BRDzCCYXISHNAAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTMxVDA1OjI5OjU2KzAwOjAwSqpf2wAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMS0wNS0zMVQwNToyOTo1NiswMDowMDv352cAAAAASUVORK5CYII= X-Now-Playing: Scorn's _Cafe Mor_: "Never Let It Be Said" Date: Mon, 31 May 2021 07:43:34 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 30 May 2021 13:26:52 -0400") Message-ID: <87czt7lapl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Another way would be to make the interactive form of the "compose > function" more dynamic: make it re-checks the interactive form of every > advice function every time. That's probably the better o [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19066 Cc: Leo Liu , 19066@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > Another way would be to make the interactive form of the "compose > function" more dynamic: make it re-checks the interactive form of every > advice function every time. That's probably the better option. That sounds like a good solution to me -- the interactive path isn't normally performance critical, so adding more work in that case should be fine. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 08:49:38 2021 Received: (at 19066) by debbugs.gnu.org; 31 May 2021 12:49:39 +0000 Received: from localhost ([127.0.0.1]:32954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnhMQ-0007X8-MV for submit@debbugs.gnu.org; Mon, 31 May 2021 08:49:38 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnhMO-0007Wv-MS for 19066@debbugs.gnu.org; Mon, 31 May 2021 08:49:37 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D4545440537; Mon, 31 May 2021 08:49:30 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0EF9E440071; Mon, 31 May 2021 08:49:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622465369; bh=8i8PJrcEihrdwTov6V1BZ8RXQ09sKuXVsx6sWgkav6Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VCF9fHvmhEM1mNfrE65MgARqhE/VSNk63XRQCG+8pI1DOmxGbs3wdhZq1h7/RxwrJ jNDqmR2OtQ4FnmKgkP5Lgf8oJ14tgKdRFE5r4bK3FIctEfQCWhaj/T5iBLFGUzfnUX Vr2u3iIE++fC1MKqVrHIvzojFe6kPWakx75STSU+zhqZdIhQ3hr595F9cHjNhBX/Hc OGDmRF11pJggJsiMt8NEA7kcjHSMbg2QgTZu9Et1HMhZvbJFNon01HKBqIzdb/Om7P gGAW7dun/0bHh/mRea3LCrWMBcIX2dKYQLpbIfpWuv3N+mFOjNjb+XwjFIGGOeuHCM R570/l0ixbxLA== Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BECF9121053; Mon, 31 May 2021 08:49:28 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19066: 25.0.50; nadvice and interactive-form Message-ID: References: <87y4rbtqh6.fsf@gmail.com> <87r1hry5dq.fsf@gnus.org> <87czt7lapl.fsf@gnus.org> Date: Mon, 31 May 2021 08:49:27 -0400 In-Reply-To: <87czt7lapl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 31 May 2021 07:43:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.108 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19066 Cc: Leo Liu , 19066@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-05-31 07:43:34] wrote: > Stefan Monnier writes: >> Another way would be to make the interactive form of the "compose >> function" more dynamic: make it re-checks the interactive form of every >> advice function every time. That's probably the better option. > That sounds like a good solution to me -- the interactive path isn't > normally performance critical, so adding more work in that case should > be fine. Yes, performance is not an issue. But preserving the semantics 100% is currently somewhere between hard and impossible. 99.9% is fairly easy, OTOH (IIRC the main problem has to do with how the args get represented in `command-history`). Stefan