GNU bug report logs - #19060
[FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based

Previous Next

Full log

Message #17 received at 19060 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: kelly <at> prtime.org, 19060 <at> debbugs.gnu.org
Subject: Re: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug
 in	window_scroll_pixel_based
Date: Sat, 15 Nov 2014 13:12:47 +0100

> Yes.  Why is it hard to understand?

When I try to correct an off-by-one error I usually never understand
what I'm doing.  I "fix" it by rounding in one direction first and if
this doesn't seem to work as intended I try the other direction.

>> Could you add comments which tell more or less how you corrected the
>> issue?
>
> Will do, once we agree that this is the right fix.

First of all I'd need to understand the bug itself.  Do we assume that
scrolling down is "correct" in some sense or does the bug manifest
itself there already?  Does scrolling up always move to the line before
the "previously established as correct" one or to the line after it?
(I'm asking because I cannot reproduce the problem with Kelly Dean's
pgup/pgdn recipe.)

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.