From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: Kelly Dean Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 08:05:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19060@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141603865221328 (code B ref -1); Sat, 15 Nov 2014 08:05:04 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2014 08:04:12 +0000 Received: from localhost ([127.0.0.1]:33181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpYL5-0005Xo-Hn for submit@debbugs.gnu.org; Sat, 15 Nov 2014 03:04:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpXXl-0003J5-Qb for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:13:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpXXb-0001ns-Lm for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:13:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_50,INVALID_MSGID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXXb-0001no-Jq for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:13:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXXR-0002BR-Fa for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:13:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpXXH-0001lq-BA for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:12:53 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:41268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXXH-0001lF-5F for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:12:43 -0500 Received: from mfilter33-d.gandi.net (mfilter33-d.gandi.net [217.70.178.164]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id BFE68FB882 for ; Sat, 15 Nov 2014 08:12:42 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter33-d.gandi.net Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by mfilter33-d.gandi.net (mfilter33-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id GplW46Ybw7kK for ; Sat, 15 Nov 2014 08:12:41 +0100 (CET) X-Originating-IP: 73.169.42.166 Received: from localhost (c-73-169-42-166.hsd1.co.comcast.net [73.169.42.166]) (Authenticated sender: kelly@prtime.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 7C3E4FB877 for ; Sat, 15 Nov 2014 08:12:39 +0100 (CET) From: Kelly Dean Date: Sat, 15 Nov 2014 06:57:45 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Mailman-Approved-At: Sat, 15 Nov 2014 03:04:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) With 24.4, emacs -Q, then M-x split-window-horizontally, then open any fi= le with a lot of long logical lines (each a few visual lines long), so th= at as you page down through the file, every screenful of text has some wr= apped lines on it. Adjust the vertical size of your Emacs frame so that t= he vertical size of your Emacs windows is not an integer multiple of the = visual line height, so that the bottom visual line of text is partially c= overed by the top of the mode line. Scroll forward a couple pages using pgdn (scroll-up-command), then notice= exactly which visual line is at the top, and which one is at the bottom.= Press pgdn, then pgup, and notice that the text doesn't return to the pr= evious position; instead, it's scrolled backward by one visual line. This= bug wasn't in 24.3. The bug is in window.c of the 24.4 release, line 5042. The fix is to chan= ge =E2=8C=9Cwindow_box_height (w)=E2=8C=9D on that line to =E2=8C=9Cwindo= w_box_height (w) / dy * dy=E2=8C=9D in order to align the result to an in= teger multiple of the visual line height, since as of 24.4, Emacs no long= er ensures that window_box_height is such a multiple. Patch excluded, per= request. There might be a related bug (with the same fix) on line 4959, but I have= n't tested that. BTW on line 471 (copied from line 466) of window.h, =E2=80=9Fwidth=E2=80=9D= should be =E2=80=9Fheight=E2=80=9D. From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kelly Dean , martin rudalics Cc: 19060@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.14160436467028 (code B ref 19060); Sat, 15 Nov 2014 09:28:01 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 09:27:26 +0000 Received: from localhost ([127.0.0.1]:33215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpZdd-0001pF-Az for submit@debbugs.gnu.org; Sat, 15 Nov 2014 04:27:25 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:64283) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpZda-0001oy-FU for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 04:27:23 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NF200I00PYJZ200@a-mtaout20.012.net.il> for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 11:27:21 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF200I4YQ9KNI90@a-mtaout20.012.net.il>; Sat, 15 Nov 2014 11:27:21 +0200 (IST) Date: Sat, 15 Nov 2014 11:27:05 +0200 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83wq6wg6fq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Kelly Dean > Date: Sat, 15 Nov 2014 06:57:45 +0000 > > With 24.4, emacs -Q, then M-x split-window-horizontally, then open any file with a lot of long logical lines (each a few visual lines long), so that as you page down through the file, every screenful of text has some wrapped lines on it. Adjust the vertical size of your Emacs frame so that the vertical size of your Emacs windows is not an integer multiple of the visual line height, so that the bottom visual line of text is partially covered by the top of the mode line. > Scroll forward a couple pages using pgdn (scroll-up-command), then notice exactly which visual line is at the top, and which one is at the bottom. Press pgdn, then pgup, and notice that the text doesn't return to the previous position; instead, it's scrolled backward by one visual line. This bug wasn't in 24.3. > > The bug is in window.c of the 24.4 release, line 5042. The fix is to change ⌜window_box_height (w)⌝ on that line to ⌜window_box_height (w) / dy * dy⌝ in order to align the result to an integer multiple of the visual line height, since as of 24.4, Emacs no longer ensures that window_box_height is such a multiple. Patch excluded, per request. > > There might be a related bug (with the same fix) on line 4959, but I haven't tested that. Martin, I propose the following patch: diff --git a/src/window.c b/src/window.c index b002423..7462fdc 100644 --- a/src/window.c +++ b/src/window.c @@ -4956,8 +4956,8 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, int noerror) int px; int dy = frame_line_height; if (whole) - dy = max ((window_box_height (w) - - next_screen_context_lines * dy), + dy = max ((window_box_height (w) / dy + - next_screen_context_lines) * dy, dy); dy *= n; @@ -5039,8 +5039,7 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, int noerror) { ptrdiff_t start_pos = IT_CHARPOS (it); int dy = frame_line_height; - dy = max ((window_box_height (w) - - next_screen_context_lines * dy), + dy = max ((window_box_height (w) / dy - next_screen_context_lines) * dy, dy) * n; /* Note that move_it_vertically always moves the iterator to the > BTW on line 471 (copied from line 466) of window.h, ‟width” should be ‟height”. Indeed, and "column" should be "line". Thanks, fixed. From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Kelly Dean Cc: 19060@debbugs.gnu.org Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.141605001728489 (code B ref 19060); Sat, 15 Nov 2014 11:14:02 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 11:13:37 +0000 Received: from localhost ([127.0.0.1]:33287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpbIO-0007PQ-Rw for submit@debbugs.gnu.org; Sat, 15 Nov 2014 06:13:37 -0500 Received: from mout.gmx.net ([212.227.15.18]:64583) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpbIM-0007PF-6O for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 06:13:35 -0500 Received: from [178.190.161.208] ([178.190.161.208]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Mb7lL-1XZSFp3kB1-00KkxX; Sat, 15 Nov 2014 12:13:27 +0100 Message-ID: <5467354D.3000600@gmx.at> Date: Sat, 15 Nov 2014 12:13:17 +0100 From: martin rudalics MIME-Version: 1.0 References: <83wq6wg6fq.fsf@gnu.org> In-Reply-To: <83wq6wg6fq.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:VX5xDUf1M2nMUc/9In1kO5mG997uQZzMBxc2ttNw1xiic0Q3IoP H4bGCobxvnRe5MVMvAkxyzGNgXsGqIPQTTrRp3fbN+zSnkiSgKB0iJ1tM6asb5WXaQkfKvd VPXAFJyQFV0M8zoHG0ZHEHxUtBPnze5hB4ca7uB0vYAJy57+i1T6QOSEp2DmgMpGumxMwiF u4vnwfqTdc9o6gUFjDkHQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) First of all many thanks to Kelly Dean for finding the problem and proposing a solution. > Martin, I propose the following patch: > > diff --git a/src/window.c b/src/window.c > index b002423..7462fdc 100644 > --- a/src/window.c > +++ b/src/window.c > @@ -4956,8 +4956,8 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, int noerror) > int px; > int dy = frame_line_height; > if (whole) > - dy = max ((window_box_height (w) > - - next_screen_context_lines * dy), > + dy = max ((window_box_height (w) / dy > + - next_screen_context_lines) * dy, > dy); > dy *= n; > > @@ -5039,8 +5039,7 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, int noerror) > { > ptrdiff_t start_pos = IT_CHARPOS (it); > int dy = frame_line_height; > - dy = max ((window_box_height (w) > - - next_screen_context_lines * dy), > + dy = max ((window_box_height (w) / dy - next_screen_context_lines) * dy, > dy) * n; > > /* Note that move_it_vertically always moves the iterator to the If it works for you, please apply it. I'm too silly to understand it, though. IIUC we have a rounding issue which makes us go by one line too far or too few when scrolling up and your patch compensates that rounding issue by putting it back into that window_box_height (w) / dy calculation. Could you add comments which tell more or less how you corrected the issue? Thanks, martin From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 11:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: kelly@prtime.org, 19060@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.141605028828963 (code B ref 19060); Sat, 15 Nov 2014 11:19:01 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 11:18:08 +0000 Received: from localhost ([127.0.0.1]:33291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpbMl-0007X5-Hz for submit@debbugs.gnu.org; Sat, 15 Nov 2014 06:18:07 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:37547) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpbMi-0007Wv-PT for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 06:18:05 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NF200500UQJGQ00@a-mtaout22.012.net.il> for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 13:18:02 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF2005FWVE29D70@a-mtaout22.012.net.il>; Sat, 15 Nov 2014 13:18:02 +0200 (IST) Date: Sat, 15 Nov 2014 13:17:47 +0200 From: Eli Zaretskii In-reply-to: <5467354D.3000600@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83lhncg1b8.fsf@gnu.org> References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 15 Nov 2014 12:13:17 +0100 > From: martin rudalics > CC: 19060@debbugs.gnu.org > > > diff --git a/src/window.c b/src/window.c > > index b002423..7462fdc 100644 > > --- a/src/window.c > > +++ b/src/window.c > > @@ -4956,8 +4956,8 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, int noerror) > > int px; > > int dy = frame_line_height; > > if (whole) > > - dy = max ((window_box_height (w) > > - - next_screen_context_lines * dy), > > + dy = max ((window_box_height (w) / dy > > + - next_screen_context_lines) * dy, > > dy); > > dy *= n; > > > > @@ -5039,8 +5039,7 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, int noerror) > > { > > ptrdiff_t start_pos = IT_CHARPOS (it); > > int dy = frame_line_height; > > - dy = max ((window_box_height (w) > > - - next_screen_context_lines * dy), > > + dy = max ((window_box_height (w) / dy - next_screen_context_lines) * dy, > > dy) * n; > > > > /* Note that move_it_vertically always moves the iterator to the > > If it works for you, please apply it. It evidently works for Kelly. > I'm too silly to understand it, though. IIUC we have a rounding > issue which makes us go by one line too far or too few when > scrolling up and your patch compensates that rounding issue by > putting it back into that window_box_height (w) / dy calculation. Yes. Why is it hard to understand? > Could you add comments which tell more or less how you corrected the > issue? Will do, once we agree that this is the right fix. From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kelly@prtime.org, 19060@debbugs.gnu.org Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.14160535832009 (code B ref 19060); Sat, 15 Nov 2014 12:14:02 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 12:13:03 +0000 Received: from localhost ([127.0.0.1]:33303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpcDu-0000WL-Lr for submit@debbugs.gnu.org; Sat, 15 Nov 2014 07:13:02 -0500 Received: from mout.gmx.net ([212.227.15.19]:53022) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpcDq-0000Vu-Rt for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 07:13:00 -0500 Received: from [178.190.161.208] ([178.190.161.208]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MPDeK-1Xu24d2MiW-004RQi; Sat, 15 Nov 2014 13:12:55 +0100 Message-ID: <5467433F.4020906@gmx.at> Date: Sat, 15 Nov 2014 13:12:47 +0100 From: martin rudalics MIME-Version: 1.0 References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> In-Reply-To: <83lhncg1b8.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:QCz8AFgtSqUBzVsIcog74mUZgJImwLwBUR2O7KXraVyKK69xNTK rEEb7//5A9ci4Eft8l4VE4Kzk3BM6bZEFtuzRlxFm6cY4yXPiQsTpUfIRgWHW9WfuEr6Isb z/VpV1ODhBqe3uJ4x8M4P/RGQVFyDaigBcbUsC9pGAXk32wYh979kkbJsKdSiNx/Q4ZCYs1 9EQhNcVntRVEgunGgvayQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Yes. Why is it hard to understand? When I try to correct an off-by-one error I usually never understand what I'm doing. I "fix" it by rounding in one direction first and if this doesn't seem to work as intended I try the other direction. >> Could you add comments which tell more or less how you corrected the >> issue? > > Will do, once we agree that this is the right fix. First of all I'd need to understand the bug itself. Do we assume that scrolling down is "correct" in some sense or does the bug manifest itself there already? Does scrolling up always move to the line before the "previously established as correct" one or to the line after it? (I'm asking because I cannot reproduce the problem with Kelly Dean's pgup/pgdn recipe.) martin From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 13:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: kelly@prtime.org, 19060@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.141605672212007 (code B ref 19060); Sat, 15 Nov 2014 13:06:01 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 13:05:22 +0000 Received: from localhost ([127.0.0.1]:33313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpd2X-00037a-8I for submit@debbugs.gnu.org; Sat, 15 Nov 2014 08:05:21 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:58525) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpd2V-00037R-6d for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 08:05:20 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NF200N00ZJK0K00@mtaout28.012.net.il> for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 15:02:38 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF300IY908ESB50@mtaout28.012.net.il>; Sat, 15 Nov 2014 15:02:38 +0200 (IST) Date: Sat, 15 Nov 2014 15:05:02 +0200 From: Eli Zaretskii In-reply-to: <5467433F.4020906@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83d28ofwch.fsf@gnu.org> References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> <5467433F.4020906@gmx.at> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 15 Nov 2014 13:12:47 +0100 > From: martin rudalics > CC: kelly@prtime.org, 19060@debbugs.gnu.org > > First of all I'd need to understand the bug itself. Do we assume that > scrolling down is "correct" in some sense or does the bug manifest > itself there already? Does scrolling up always move to the line before > the "previously established as correct" one or to the line after it? > (I'm asking because I cannot reproduce the problem with Kelly Dean's > pgup/pgdn recipe.) Kelly, please help Martin reproduce the problem. Perhaps you need to provide more details, like maybe the file you used and the geometry of the frame needed to see the issue. From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 13:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kelly@prtime.org, 19060@debbugs.gnu.org Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.141605816714169 (code B ref 19060); Sat, 15 Nov 2014 13:30:03 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 13:29:27 +0000 Received: from localhost ([127.0.0.1]:33317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpdPq-0003gT-JB for submit@debbugs.gnu.org; Sat, 15 Nov 2014 08:29:26 -0500 Received: from mout.gmx.net ([212.227.17.21]:61537) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpdPn-0003gJ-PV for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 08:29:24 -0500 Received: from [188.22.239.168] ([188.22.239.168]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M6730-1YDLX11Edu-00y6AX; Sat, 15 Nov 2014 14:29:21 +0100 Message-ID: <54675528.7070401@gmx.at> Date: Sat, 15 Nov 2014 14:29:12 +0100 From: martin rudalics MIME-Version: 1.0 References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> <5467433F.4020906@gmx.at> <83d28ofwch.fsf@gnu.org> In-Reply-To: <83d28ofwch.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+UX2h2B9e/FtbbrioQ2R0CeMzCvSjmclbpAtTAspaHRCERb8RpN oGIR46VsUQarfpocQrSUsLdwE/b04MvpMxnwDBvgkTQ6GZy/u/7EuisPAagp2Y8ZZs2lLsk 8314Us/QFaeeCygsyTnrJH2M581vB6fF7XYi8MRPRY7ekPc4oieSpk3fkbUDBFvk7eXnskL PTgAk7xvO6h+A2HZ8oufw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Kelly, please help Martin reproduce the problem. Perhaps you need to > provide more details, like maybe the file you used and the geometry of > the frame needed to see the issue. Just a few informations. I tried on Windows XP with the current trunk (the release doesn't allow to resize frames pixelwise easily). I did emacs -Q, displayed xdisp.c, did C-x 3 and resized the frame with the mouse to make sure that the last lines of the windows showing xdisp.c do get displayed only partially. Now pgup/pgdn in the right window always gets me to the same line it had before when scrolling in the other direction. Am I missing something? martin From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: kelly@prtime.org, 19060@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.141605929716246 (code B ref 19060); Sat, 15 Nov 2014 13:49:02 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 13:48:17 +0000 Received: from localhost ([127.0.0.1]:33387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpdi4-0004Dx-Iq for submit@debbugs.gnu.org; Sat, 15 Nov 2014 08:48:16 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:34357) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpdi2-0004Do-5p for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 08:48:15 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NF300L001YB1J00@a-mtaout20.012.net.il> for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 15:48:12 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF300KSY2CCPP90@a-mtaout20.012.net.il>; Sat, 15 Nov 2014 15:48:12 +0200 (IST) Date: Sat, 15 Nov 2014 15:47:57 +0200 From: Eli Zaretskii In-reply-to: <54675528.7070401@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83bno8fucy.fsf@gnu.org> References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> <5467433F.4020906@gmx.at> <83d28ofwch.fsf@gnu.org> <54675528.7070401@gmx.at> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 15 Nov 2014 14:29:12 +0100 > From: martin rudalics > CC: kelly@prtime.org, 19060@debbugs.gnu.org > > Just a few informations. I tried on Windows XP with the current trunk > (the release doesn't allow to resize frames pixelwise easily). I did > emacs -Q, displayed xdisp.c, did C-x 3 and resized the frame with the > mouse to make sure that the last lines of the windows showing xdisp.c do > get displayed only partially. Now pgup/pgdn in the right window always > gets me to the same line it had before when scrolling in the other > direction. Am I missing something? Since the issue is rounding vs truncating, perhaps try playing with the portion of the last displayed line, trying both less and greater than half the canonical line height. From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based In-Reply-To: Resent-From: Angelo Graziosi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rudalics@gmx.at, 19060@debbugs.gnu.org X-Debbugs-Original-To: rudalics@gmx.at, bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141606064218396 (code B ref -1); Sat, 15 Nov 2014 14:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2014 14:10:42 +0000 Received: from localhost ([127.0.0.1]:33407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpe3l-0004me-LV for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:10:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40980) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpe3j-0004mW-Lz for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:10:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpe3c-0004H6-Pi for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:10:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:40708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpe3c-0004H2-Jr for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:10:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpe3W-0004h8-Iu for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 09:10:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpe3Q-0004Dn-7g for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 09:10:26 -0500 Received: from smtp201.alice.it ([82.57.200.97]:26693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpe3Q-0004DS-1H for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 09:10:20 -0500 Received: from [192.168.1.102] (87.21.227.179) by smtp201.alice.it (8.6.060.43) (authenticated as angelo.graziosi@alice.it) id 54632F5300507346; Sat, 15 Nov 2014 15:10:17 +0100 Message-ID: <54675ED2.9030901@alice.it> Date: Sat, 15 Nov 2014 15:10:26 +0100 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 References: 5467354D.3000600@gmx.at Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Martin Rudalics wrote: > IIUC we have a rounding issue which makes us go by one line too > far or too few when scrolling up and your patch compensates that > rounding issue by putting it back into that window_box_height (w) / dy > calculation. Apparently, this seem related, in some way, to what I flagged here: http://lists.gnu.org/archive/html/bug-gnu-emacs/2014-11/msg00621.html ..or not? Ciao, Angelo. From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: angelo.graziosi@alice.it, 19060@debbugs.gnu.org X-Debbugs-Original-To: Angelo Graziosi , bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141606203420505 (code B ref -1); Sat, 15 Nov 2014 14:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2014 14:33:54 +0000 Received: from localhost ([127.0.0.1]:33415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpeQD-0005Kd-Sf for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:33:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44132) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpeQC-0005KW-2V for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:33:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpeQ5-0001kU-7y for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:33:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpeQ5-0001kP-5L for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:33:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpePz-0007wV-5R for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 09:33:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpePt-0001jU-3r for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 09:33:38 -0500 Received: from mout.gmx.net ([212.227.15.15]:64857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpePs-0001jP-QE for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 09:33:33 -0500 Received: from [188.22.239.168] ([188.22.239.168]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M2cYX-1Y5wPS2Ucf-00sQEX; Sat, 15 Nov 2014 15:33:19 +0100 Message-ID: <54676426.8030505@gmx.at> Date: Sat, 15 Nov 2014 15:33:10 +0100 From: martin rudalics MIME-Version: 1.0 References: 5467354D.3000600@gmx.at <54675ED2.9030901@alice.it> In-Reply-To: <54675ED2.9030901@alice.it> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dZbfxcZoRXUS7zmfZFgRs83R1YbZgfFmjKqHmqcJC3m+fOmaaS4 YAYPQKKo8mMdKJJL8c0+w+G3/p6BI/Iyk4RF1bkJsV/PrsVyuxvep9RbgR9idisEVHY+cA9 pv22PwNJbsin15vcS2hbMr3wM+7hC5i/cSRC3u1AACD5Lj/hnGjNVgbBlC5uh95W4myIydm 1c2F2zp7pGuteiysVB/ag== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) > Apparently, this seem related, in some way, to what I flagged here: > > http://lists.gnu.org/archive/html/bug-gnu-emacs/2014-11/msg00621.html > > ..or not? Maybe. But I have no idea what your report describes. IIUC you are using `desktop-save' to save the window configuration across sessions and when you restart Emacs its frame's height is one line less. Is that correct? Then please tell us how much the height decreases in pixels (you can use the function `window--dump-frame' for that) and what the height stored by `desktop-save' is. I suppose this is somewhere in a cons whose car is something like `height' or `frame-height' or the like. martin From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 14:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kelly@prtime.org, 19060@debbugs.gnu.org Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.141606198720434 (code B ref 19060); Sat, 15 Nov 2014 14:34:03 +0000 Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 14:33:07 +0000 Received: from localhost ([127.0.0.1]:33411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpePR-0005JV-J5 for submit@debbugs.gnu.org; Sat, 15 Nov 2014 09:33:06 -0500 Received: from mout.gmx.net ([212.227.15.18]:63669) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpePK-0005J8-RP for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 09:33:00 -0500 Received: from [188.22.239.168] ([188.22.239.168]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Mg42v-1Xb1Ql2pEr-00NU1O; Sat, 15 Nov 2014 15:32:50 +0100 Message-ID: <54676409.3030505@gmx.at> Date: Sat, 15 Nov 2014 15:32:41 +0100 From: martin rudalics MIME-Version: 1.0 References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> <5467433F.4020906@gmx.at> <83d28ofwch.fsf@gnu.org> <54675528.7070401@gmx.at> <83bno8fucy.fsf@gnu.org> In-Reply-To: <83bno8fucy.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Y+Bg4UPcYpD39HDOaJcfZrB6l0j9RCnwd0DkIWwS+oVGzQQxVhm wBIIYP0cYMkYvD0ZkXAeSlDtnSfeWBUh0pTcXLrzssMppnjHHe6Jo/3eUVEacUnWb1v6NQ/ PqeY2cR/ma0T6sEtkCczNyHkqma+lo/EgwpvlDjm2ZAuSDHGWy95/eUrGdCUErMbrh/8PPd 8txtagcUnOad8Sa4E832A== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Since the issue is rounding vs truncating, perhaps try playing with > the portion of the last displayed line, trying both less and greater > than half the canonical line height. Got it. The last line must show more than a half of the frame's character height. And the patch fixes it AFAICT. So please apply it with as much comment as you can provide. Thanks, martin From unknown Sun Jun 22 04:32:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kelly Dean Subject: bug#19060: closed (Re: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based) Message-ID: References: <831tp4fl5c.fsf@gnu.org> X-Gnu-PR-Message: they-closed 19060 X-Gnu-PR-Package: emacs Reply-To: 19060@debbugs.gnu.org Date: Sat, 15 Nov 2014 17:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1416071282-8468-1" This is a multi-part message in MIME format... ------------=_1416071282-8468-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel= _based which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19060@debbugs.gnu.org. --=20 19060: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19060 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1416071282-8468-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19060-done) by debbugs.gnu.org; 15 Nov 2014 17:07:24 +0000 Received: from localhost ([127.0.0.1]:34046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpgol-0002Bi-RY for submit@debbugs.gnu.org; Sat, 15 Nov 2014 12:07:24 -0500 Received: from mtaout24.012.net.il ([80.179.55.180]:38567) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpgoj-0002BY-6B for 19060-done@debbugs.gnu.org; Sat, 15 Nov 2014 12:07:22 -0500 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NF300000B3GLB00@mtaout24.012.net.il> for 19060-done@debbugs.gnu.org; Sat, 15 Nov 2014 18:59:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF300HPVB7M4Q80@mtaout24.012.net.il>; Sat, 15 Nov 2014 18:59:46 +0200 (IST) Date: Sat, 15 Nov 2014 19:06:55 +0200 From: Eli Zaretskii Subject: Re: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based In-reply-to: <54676409.3030505@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <831tp4fl5c.fsf@gnu.org> References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> <5467433F.4020906@gmx.at> <83d28ofwch.fsf@gnu.org> <54675528.7070401@gmx.at> <83bno8fucy.fsf@gnu.org> <54676409.3030505@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19060-done Cc: kelly@prtime.org, 19060-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 15 Nov 2014 15:32:41 +0100 > From: martin rudalics > CC: kelly@prtime.org, 19060@debbugs.gnu.org > > > Since the issue is rounding vs truncating, perhaps try playing with > > the portion of the last displayed line, trying both less and greater > > than half the canonical line height. > > Got it. The last line must show more than a half of the frame's > character height. And the patch fixes it AFAICT. So please apply it > with as much comment as you can provide. Done on the emacs-24 branch. ------------=_1416071282-8468-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Nov 2014 08:04:12 +0000 Received: from localhost ([127.0.0.1]:33181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpYL5-0005Xo-Hn for submit@debbugs.gnu.org; Sat, 15 Nov 2014 03:04:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpXXl-0003J5-Qb for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:13:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpXXb-0001ns-Lm for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:13:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_50,INVALID_MSGID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXXb-0001no-Jq for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:13:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXXR-0002BR-Fa for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:13:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpXXH-0001lq-BA for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:12:53 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:41268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXXH-0001lF-5F for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:12:43 -0500 Received: from mfilter33-d.gandi.net (mfilter33-d.gandi.net [217.70.178.164]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id BFE68FB882 for ; Sat, 15 Nov 2014 08:12:42 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter33-d.gandi.net Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by mfilter33-d.gandi.net (mfilter33-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id GplW46Ybw7kK for ; Sat, 15 Nov 2014 08:12:41 +0100 (CET) X-Originating-IP: 73.169.42.166 Received: from localhost (c-73-169-42-166.hsd1.co.comcast.net [73.169.42.166]) (Authenticated sender: kelly@prtime.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 7C3E4FB877 for ; Sat, 15 Nov 2014 08:12:39 +0100 (CET) From: Kelly Dean To: bug-gnu-emacs@gnu.org Subject: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Date: Sat, 15 Nov 2014 06:57:45 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 15 Nov 2014 03:04:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) With 24.4, emacs -Q, then M-x split-window-horizontally, then open any fi= le with a lot of long logical lines (each a few visual lines long), so th= at as you page down through the file, every screenful of text has some wr= apped lines on it. Adjust the vertical size of your Emacs frame so that t= he vertical size of your Emacs windows is not an integer multiple of the = visual line height, so that the bottom visual line of text is partially c= overed by the top of the mode line. Scroll forward a couple pages using pgdn (scroll-up-command), then notice= exactly which visual line is at the top, and which one is at the bottom.= Press pgdn, then pgup, and notice that the text doesn't return to the pr= evious position; instead, it's scrolled backward by one visual line. This= bug wasn't in 24.3. The bug is in window.c of the 24.4 release, line 5042. The fix is to chan= ge =E2=8C=9Cwindow_box_height (w)=E2=8C=9D on that line to =E2=8C=9Cwindo= w_box_height (w) / dy * dy=E2=8C=9D in order to align the result to an in= teger multiple of the visual line height, since as of 24.4, Emacs no long= er ensures that window_box_height is such a multiple. Patch excluded, per= request. There might be a related bug (with the same fix) on line 4959, but I have= n't tested that. BTW on line 471 (copied from line 466) of window.h, =E2=80=9Fwidth=E2=80=9D= should be =E2=80=9Fheight=E2=80=9D. ------------=_1416071282-8468-1-- From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: Angelo Graziosi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rudalics@gmx.at, 19060@debbugs.gnu.org X-Debbugs-Original-To: martin rudalics , bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14160719579529 (code B ref -1); Sat, 15 Nov 2014 17:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2014 17:19:17 +0000 Received: from localhost ([127.0.0.1]:34053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xph0G-0002Td-6l for submit@debbugs.gnu.org; Sat, 15 Nov 2014 12:19:16 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47140) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xph0A-0002TP-Oo for submit@debbugs.gnu.org; Sat, 15 Nov 2014 12:19:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xph03-0003YL-Po for submit@debbugs.gnu.org; Sat, 15 Nov 2014 12:19:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xph03-0003YD-Nm for submit@debbugs.gnu.org; Sat, 15 Nov 2014 12:19:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpgzx-0004m0-QO for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 12:19:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpgzr-0003W5-IA for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 12:18:57 -0500 Received: from smtp204.alice.it ([82.57.200.100]:9606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpgzr-0003Vz-7E for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 12:18:51 -0500 Received: from [192.168.1.102] (87.21.227.179) by smtp204.alice.it (8.6.060.43) (authenticated as angelo.graziosi@alice.it) id 542BEACC08953EB9; Sat, 15 Nov 2014 18:18:49 +0100 Message-ID: <54678AE4.6050304@alice.it> Date: Sat, 15 Nov 2014 18:18:28 +0100 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 References: 5467354D.3000600@gmx.at <54675ED2.9030901@alice.it> <54676426.8030505@gmx.at> In-Reply-To: <54676426.8030505@gmx.at> Content-Type: multipart/mixed; boundary="------------060702020806010208070305" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------060702020806010208070305 Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Il 15/11/2014 15:33, martin rudalics ha scritto: > > Apparently, this seem related, in some way, to what I flagged here: > > > > http://lists.gnu.org/archive/html/bug-gnu-emacs/2014-11/msg00621.html > > > > ..or not? > > Maybe. But I have no idea what your report describes. IIUC you are > using `desktop-save' to save the window configuration across sessions > and when you restart Emacs its frame's height is one line less. Is that > correct? Then please tell us how much the height decreases in pixels Yes, even if each time not always the same size: sometimes more, sometimes less. I have quantified this in about one line (or, if you prefer, about the height of the minibuffer). I would say 10-20 pixel. > (you can use the function `window--dump-frame' for that) and what the > height stored by `desktop-save' is. I suppose this is somewhere in a > cons whose car is something like `height' or `frame-height' or the like. I am afraid, I wasn't able to use that function.. How to evaluate it? I tried a few command but they didn't work. I have attached a tar-ball with a few examples of desktop file. They have been obtained in this way. First I removed the current desktop and history files. So I started Emacs and moved it so that it was centered in the Windows desktop (I tried this with the Cygwin build..). Then I closed Emacs and it asked to save the desktop. Yes - and this generated the "desktop-00" file. Then I restarted Emacs and closed it obtaining the "desktop-01" file. I repeated this 2 times obtaining "desktop-03". After repeating this a few times I obtained the "desktop" file: now Emacs frame is conspicuously short. Ciao, Angelo. --------------060702020806010208070305 Content-Type: application/x-gzip; name="desktop_files.tar.gz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="desktop_files.tar.gz" H4sIADqFZ1QAA+1YS28bNxD22b+C0MkOQIPcp6Rcijhub7kkQA9FD9QuJRHZJdUl5Ud/fWe4 q2fsNkFt17XnEwyZM8PhzPD1UbX2X4NbcSFOngwCUGTZiSiELHMZv4WQUQ7I0qI8kUmWylLI PMtPhJRFmp6wJwxph7UPqmPsRNmFbtzDdp+c1c8RzzPj/XvG33HWulpPmW5V5Xlj/Oo9q1xt 7GIja9eNjpan2OHRgN4+9iuQ/WwazeauY1c44uOPc9lpFXTNPqvAPrlrJnMmy2lWTJMJS4TM 9mOZD7G0YHutO2+cBZsCTWJ0O2F+IS5ycSFPUfdL42aqYV5XAZTT0zOvwx+sHraYV9e65vNO tRrk7Lftf5KdJbIQJUvTIi2ZTHLYFUycs7OhK7tgIxh+dM5G/TL96YsKzhmrR8yaJv6dAebO Bj5T1Vdta7a2xledmWm2qA34QiU64m4dGujKL531rlGeW0y0OfpqnXVcljDl+Kngz3g3HucT LiGOs5nrat3xG1OHJXhNQGRs0J2Frkc6TKQzi2Xgtbk2x5qZC8G196qgyMFU4BDycA34VZ0H VfQF6qXrzJ+Q1KFBzLTTi86tbc0r18CKgqw/3/mg21+Nrd3NF30bYg5Qqb+zQ5vWrb3eqWcN 9NnL/1sFhKK15QvVtgqasdJ+pSrYTNjU8wBLABoaeo23lTkQqWa1VGycsxyr0Gq7xsw4usL8 JQhh9psDIU5AMKHRmP+6afowcFYqZ3m4W6FCrYPjnTJ+22jcje6gUa0777poB85m7rbPZCjq dlZkeShfaox+mK4azo1G3W2cxNIcVhlPGdA0wwQOg35bQ22vTecsZB7neTNImmFyw67h3NTY 6UOZSC4ury75+Kq44h+vkmx0YNYaaxh2R1+bRMaxshAO1m/QoeFsPZ/rbhCsLSRkQlCzWFac O9Dkk0mcANyVcF1tSmxhPFyzxpuZgV53g5OhKhjqTZrE7G7Ba2XCpst2LlfOGzw4sKdbnYMK Y9oVOeuD3M2GGAS9BTcL2LuYTbpvuBMXh+ZezfWwnHbGgzAZhCtzq5tdBGNxIN8EMhH3mO+N e0+vnTbP7uu8ieO+rpvAx1CiRqs5OzsMp8yxAEehF+U41hqPi+0qSLei3SJD2XAGboXyQuyk 2/JH4bBiRu9gW6hQLd+NYIfoBq4AXQ9LYNnvmGGb9FvdszF84ODG/FS3MNYPrf3DDg/2BBYv fovo6/rAV61rOCBhJMwX7oMY6wQnD1lNbJ0Dfj8/uopa4z1EwfGe4zeqs9CIww92QS18r8Q1 +o0m7gjkCWFf5bXqqiXvjnzBWQwrnj+sBTdwkqpjd9vh+RI0rrvrlXjPfuhrPtyzwBNYPwue oROou7HMY+DxkGbKo2CYKLSYnv7XtOvFYLMigI4/Gf6R/5fZlv8Xpej5vyT+/xx48/y/nObJ y+H/ZSJYMi6lmLA0bg56BNAjgB4B/5b2/yDTfyJCv/+USY8fIw+8LugR8KiPgPw7HwHJC3wE CPj0WnoE0CPgkbDl/+nTjfED/D+RSf/7f1IS/38OvHX+n4sX9fv/uCzx7E7HCVyzxP+J/xP/ f538Xz7A/zcMNfL/JCf+/7j8X34n/99j+sT/if+/XgyL4UnH+BH+nxQl8v9MFsT/nwNvnv8n UyDeL4b/T8qcZTIVwPsmxP+J/xP/f538H5g98f/n5//Z5Pv4f5IR/yf+TyAQCAQCgUAgEAgE AoFAIBAIBAKBQCAQCAQCgfB/wF8eIxCiAFAAAA== --------------060702020806010208070305-- From unknown Sun Jun 22 04:32:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Nov 2014 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: angelo.graziosi@alice.it, 19060@debbugs.gnu.org X-Debbugs-Original-To: Angelo Graziosi , bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141613787121522 (code B ref -1); Sun, 16 Nov 2014 11:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Nov 2014 11:37:51 +0000 Received: from localhost ([127.0.0.1]:34354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpy9P-0005b4-Di for submit@debbugs.gnu.org; Sun, 16 Nov 2014 06:37:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37806) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpy9N-0005ak-Hz for submit@debbugs.gnu.org; Sun, 16 Nov 2014 06:37:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpy98-0001Aw-Bk for submit@debbugs.gnu.org; Sun, 16 Nov 2014 06:37:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpy98-0001As-9P for submit@debbugs.gnu.org; Sun, 16 Nov 2014 06:37:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpy90-00081N-A9 for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 06:37:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpy8p-00010K-LO for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 06:37:26 -0500 Received: from mout.gmx.net ([212.227.15.18]:56849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpy8p-000109-Bb for bug-gnu-emacs@gnu.org; Sun, 16 Nov 2014 06:37:15 -0500 Received: from [178.190.163.170] ([178.190.163.170]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MYfre-1XUdtj1niE-00VQID; Sun, 16 Nov 2014 12:37:13 +0100 Message-ID: <54688C5F.9090201@gmx.at> Date: Sun, 16 Nov 2014 12:37:03 +0100 From: martin rudalics MIME-Version: 1.0 References: 5467354D.3000600@gmx.at <54675ED2.9030901@alice.it> <54676426.8030505@gmx.at> <54678AE4.6050304@alice.it> In-Reply-To: <54678AE4.6050304@alice.it> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:1udgAGfcjhCKLp1Ib101u2PdLCOoM5XLpCxIgPkZxd+n/yi/Tw6 ogsOIV1zWqg0FZ06EaoeTN/Erxk8oPxWy11zUqMEw9boRO6oGQgiBe8RWTKjhe6exmt5dFG 4iFvbXazphqkT8eASDt6JIiGgeXF2aMbmYFNEvfvXN9WQB7lNcy4eNMpK0vBD4E1/kLemPi pmKiJ+FIGi/vTqFKvQJoA== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) >> (you can use the function `window--dump-frame' for that) and what the >> height stored by `desktop-save' is. I suppose this is somewhere in a >> cons whose car is something like `height' or `frame-height' or the like. > > I am afraid, I wasn't able to use that function.. How to evaluate it? I tried a few command but they didn't work. M-: (window--dump-frame) The results appear in a buffer called *window-frame-dump*. Do this please once before exiting one session and once after entering the subsequent session and post the respective buffer contents here. And please do that in the appropriate thread, namely for bug#19048. > First I removed the current desktop and history files. So I started > Emacs and moved it so that it was centered in the Windows desktop (I > tried this with the Cygwin build..). Then I closed Emacs and it asked > to save the desktop. Yes - and this generated the "desktop-00" > file. Then I restarted Emacs and closed it obtaining the "desktop-01" > file. I repeated this 2 times obtaining "desktop-03". After repeating > this a few times I obtained the "desktop" file: now Emacs frame is > conspicuously short. I suppose the frame height is stored in the (height . xx) conses. In desktop-00 you have (height . 34), in desktop-01 (height . 33) and in desktop-03 (height . 31). So your frame height seems to decrease by one line every time you restore it. Using `window--dump-frame' we should be able to see what the frame height was before exiting one session and after restoring it in another one and hopefully why the frame decreases by that line. Thanks, martin