From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 15 03:04:11 2014 Received: (at submit) by debbugs.gnu.org; 15 Nov 2014 08:04:11 +0000 Received: from localhost ([127.0.0.1]:33179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpYL4-0005Xh-Sm for submit@debbugs.gnu.org; Sat, 15 Nov 2014 03:04:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59844) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpXVj-0003Fp-I3 for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:11:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpXVZ-0001Es-EE for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:11:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_50,INVALID_MSGID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXVZ-0001En-Aq for submit@debbugs.gnu.org; Sat, 15 Nov 2014 02:10:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXVO-00024w-My for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpXVE-0001ER-I4 for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:10:46 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:41703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpXVE-0001EN-6X for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 02:10:36 -0500 Received: from mfilter16-d.gandi.net (mfilter16-d.gandi.net [217.70.178.144]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 75087FB877 for ; Sat, 15 Nov 2014 08:10:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter16-d.gandi.net Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by mfilter16-d.gandi.net (mfilter16-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id EuLy7EiilFvD for ; Sat, 15 Nov 2014 08:10:34 +0100 (CET) X-Originating-IP: 73.169.42.166 Received: from localhost (c-73-169-42-166.hsd1.co.comcast.net [73.169.42.166]) (Authenticated sender: kelly@prtime.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 08502FB8A7 for ; Sat, 15 Nov 2014 08:10:32 +0100 (CET) From: Kelly Dean To: bug-gnu-emacs@gnu.org Subject: [FIX INCLUDED] desktop-read re-enables desktop autosave when it shouldn't Date: Sat, 15 Nov 2014 06:57:15 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 15 Nov 2014 03:04:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) With emacs 24.4, run emacs -Q, then do (desktop-save-mode 1) Notice that window-configuration-change-hook now (correctly) contains desktop-auto-save-set-timer, since desktop-save-mode defaults to enabling desktop autosave. Now do (desktop-auto-save-disable) Notice that desktop-auto-save-set-timer is (correctly) removed from the hook. Now do (desktop-save "~/.emacs.d") (desktop-read) Notice that desktop-auto-save-set-timer is added back to the hook, which is a bug since you didn't ask for desktop autosave to be re-enabled. This bug wasn't in 24.3, because 24.3 didn't have the desktop autosave feature. The bug is in desktop.el of the 24.4 release, line 1191, which unconditionally calls desktop-auto-save-enable. The fix is to change that to conditionally call desktop-auto-save-enable, if desktop autosave was enabled (indicated by presence of desktop-auto-save-set-timer in the hook) prior to being disabled by the call to desktop-auto-save-disable on line 1138. Patch excluded, per request. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 22 22:46:41 2015 Received: (at 19059) by debbugs.gnu.org; 23 Jan 2015 03:46:41 +0000 Received: from localhost ([127.0.0.1]:53369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEVCj-0004PW-93 for submit@debbugs.gnu.org; Thu, 22 Jan 2015 22:46:41 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37865) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEVCh-0004PN-7y for 19059@debbugs.gnu.org; Thu, 22 Jan 2015 22:46:39 -0500 Received: from mfilter37-d.gandi.net (mfilter37-d.gandi.net [217.70.178.168]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 632BFFB88B for <19059@debbugs.gnu.org>; Fri, 23 Jan 2015 04:46:38 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter37-d.gandi.net Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by mfilter37-d.gandi.net (mfilter37-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id pflXCyCh4tFG for <19059@debbugs.gnu.org>; Fri, 23 Jan 2015 04:46:37 +0100 (CET) X-Originating-IP: 66.220.3.179 Received: from localhost (unknown [66.220.3.179]) (Authenticated sender: kelly@prtime.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 5EBC1FB887 for <19059@debbugs.gnu.org>; Fri, 23 Jan 2015 04:46:35 +0100 (CET) From: Kelly Dean To: 19059@debbugs.gnu.org Subject: [PATCH] desktop-read re-enables desktop autosave when it shouldn't Date: Fri, 23 Jan 2015 03:45:26 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19059 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Since patches are allowed now... --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=desktop-auto-save-bug.patch --- emacs-24.4/lisp/desktop.el +++ emacs-24.4/lisp/desktop.el @@ -1119,7 +1119,8 @@ (desktop-buffer-fail-count 0) (owner (desktop-owner)) ;; Avoid desktop saving during evaluation of desktop buffer. - (desktop-save nil)) + (desktop-save nil) + (desktop-autosave-was-enabled)) (if (and owner (memq desktop-load-locked-desktop '(nil ask)) (or (null desktop-load-locked-desktop) @@ -1135,6 +1136,8 @@ ;; Temporarily disable the autosave that will leave it ;; disabled when loading the desktop fails with errors, ;; thus not overwriting the desktop with broken contents. + (setq desktop-autosave-was-enabled + (memq 'desktop-auto-save-set-timer window-configuration-change-hook)) (desktop-auto-save-disable) ;; Evaluate desktop buffer and remember when it was modified. (load (desktop-full-file-name) t t t) @@ -1188,7 +1191,7 @@ (set-window-prev-buffers window nil) (set-window-next-buffers window nil)))) (setq desktop-saved-frameset nil) - (desktop-auto-save-enable) + (if desktop-autosave-was-enabled (desktop-auto-save-enable)) t)) ;; No desktop file found. (desktop-clear) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 19:42:53 2015 Received: (at 19059-done) by debbugs.gnu.org; 18 Feb 2015 00:42:53 +0000 Received: from localhost ([127.0.0.1]:46732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNsj6-0006cH-Jg for submit@debbugs.gnu.org; Tue, 17 Feb 2015 19:42:52 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41024) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNsj4-0006c9-UE for 19059-done@debbugs.gnu.org; Tue, 17 Feb 2015 19:42:51 -0500 Received: from mfilter35-d.gandi.net (mfilter35-d.gandi.net [217.70.178.166]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id E2B29A80AD for <19059-done@debbugs.gnu.org>; Wed, 18 Feb 2015 01:42:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter35-d.gandi.net Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by mfilter35-d.gandi.net (mfilter35-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 2GqtuXiJj7Q3 for <19059-done@debbugs.gnu.org>; Wed, 18 Feb 2015 01:42:47 +0100 (CET) X-Originating-IP: 66.220.3.179 Received: from localhost (gm179.geneticmail.com [66.220.3.179]) (Authenticated sender: kelly@prtime.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 45EAEA80B4 for <19059-done@debbugs.gnu.org>; Wed, 18 Feb 2015 01:42:46 +0100 (CET) From: Kelly Dean To: 19059-done@debbugs.gnu.org Subject: Re: desktop-read re-enables desktop autosave when it shouldn't In-Reply-To: References: Date: Wed, 18 Feb 2015 00:41:30 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19059-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in trunk. From unknown Fri Aug 15 04:03:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Mar 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator