From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 11:45:52 2014 Received: (at submit) by debbugs.gnu.org; 14 Nov 2014 16:45:52 +0000 Received: from localhost ([127.0.0.1]:32769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpK0N-0004v9-OS for submit@debbugs.gnu.org; Fri, 14 Nov 2014 11:45:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38919) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpDcL-0004Po-9Y for submit@debbugs.gnu.org; Fri, 14 Nov 2014 04:56:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpDcF-0006zl-Qk for submit@debbugs.gnu.org; Fri, 14 Nov 2014 04:56:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpDcF-0006zh-Np for submit@debbugs.gnu.org; Fri, 14 Nov 2014 04:56:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpDcA-0006No-Tc for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 04:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpDc3-0006sM-Ck for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 04:56:26 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:53811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpDc3-0006o6-33 for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 04:56:19 -0500 Received: from luna.netfonds.no ([80.91.225.79] helo=luna) by hermes.netfonds.no with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1XpDbj-0007Rf-Rq for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 10:55:59 +0100 Received: from pok by luna with local (Exim 4.71) (envelope-from ) id 1XpDbj-0006rK-PP for bug-gnu-emacs@gnu.org; Fri, 14 Nov 2014 10:55:59 +0100 From: pok@netfonds.no (Peder O. Klingenberg) To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Wrong envelope-from in report-emacs-bug Date: Fri, 14 Nov 2014 10:55:59 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-MailScanner-ID: 1XpDbj-0007Rf-Rq X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: pok@netfonds.no MailScanner-NULL-Check: 1416563760.05593@06Q3LGICS8+xwXdmrwYaqA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 14 Nov 2014 11:45:50 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain (Creating a bug report from a mail thread on emacs-devel to keep it alive. I probably should have done this as a bug report originally. Original thread on http://permalink.gmane.org/gmane.emacs.devel/175920) I wrote: > Earlier today I was bitten by something that has irritated be before as > well. When reporting bugs from an "emacs -Q", emacs doesn't know my > email address. No problem, I can edit the From: header. > > However, I like to use my local sendmail as transport, because I have > already told that how and where to forward my mail, and it seems like a > perfectly good option. But message.el then decides to make up its own > envelope-from, regardless of From: header. That makes the mail bounce. > > Attached is a patch to emacsbug.el that checks if what message.el would > do results in a bogus address, and if so, defaults to the From: header > instead. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=emacsbug.patch diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 821d4fd..75317c6 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-10-28 Peder O. Klingenberg + + * mail/emacsbug.el (report-emacs-bug): Make a better guess at + envelope-from when reporting through sendmail. + 2014-10-24 Martin Rudalics * mouse.el (mouse-drag-line): Don't use mouse-pixel-position. diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index 9145150..4ed212e 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -137,6 +137,12 @@ This requires either the OS X \"open\" command, or the freedesktop (concat "mailto:" to))) (error "Subject, To or body not found"))))) +;; It's the default mail mode, so it seems OK to use its features. +(autoload 'message-bogus-recipient-p "message") +(autoload 'message-make-address "message") +(defvar message-send-mail-function) +(defvar message-sendmail-envelope-from) + ;;;###autoload (defun report-emacs-bug (topic &optional recent-keys) "Report a bug in GNU Emacs. @@ -165,7 +171,12 @@ Prompts for bug subject. Leaves you in a mail buffer." ;; that report-emacs-bug-orig-text remains valid. (Bug#5178) (message-sort-headers) ;; Stop message-mode stealing the properties we will add. - (set (make-local-variable 'message-strip-special-text-properties) nil)) + (set (make-local-variable 'message-strip-special-text-properties) nil) + ;; Make sure we default to the From: address as envelope when sending + ;; through sendmail. + (when (and (not message-sendmail-envelope-from) + (message-bogus-recipient-p (message-make-address))) + (set (make-local-variable 'message-sendmail-envelope-from) 'header))) (rfc822-goto-eoh) (forward-line 1) ;; Move the mail signature to the proper place. @@ -364,10 +375,6 @@ usually do not have translators for other languages.\n\n"))) (define-obsolete-function-alias 'report-emacs-bug-info 'info-emacs-bug "24.3") -;; It's the default mail mode, so it seems OK to use its features. -(autoload 'message-bogus-recipient-p "message") -(defvar message-send-mail-function) - (defun report-emacs-bug-hook () "Do some checking before sending a bug report." (save-excursion --=-=-= Content-Type: text/plain Eli Zaretskii replied with a concern: >> +;; It's the default mail mode, so it seems OK to use its features. >> +(autoload 'message-bogus-recipient-p "message") >> +(autoload 'message-make-address "message") >> +(defvar message-send-mail-function) >> +(defvar message-sendmail-envelope-from) > > What if the user overrides that default, and uses a different mail > mode? To which I replied: > Then I guess that user will have some unused functions loaded, as well > as some variables defined that she has no use for? I was basically just > cargo-culting the existing code. > > Existing code in emacsbug.el has > > ;; It's the default mail mode, so it seems OK to use its features. > (autoload 'message-bogus-recipient-p "message") > (defvar message-send-mail-function) > > I just added one more function and one more variable, and moved the > whole bunch, including comment, earlier in the file, because I used > those functions earlier in the file and thought it logical to place the > definitions before the uses. > > Autoload of one function causes the entire file to be loaded, does it > not? So my additions are more for documentation purposes than any > actual functional change. Does anyone have any further thoughts? I consider existing behaviour a bug, and I believe my patch fixes it in a relatively unobtrusive manner. message.el is already autoloaded today, and my patch does not change behaviour if the user has already told message.el how to determine envelope-from, or if the guessed address would be sane. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 15 10:23:39 2014 Received: (at 19054) by debbugs.gnu.org; 15 Nov 2014 15:23:39 +0000 Received: from localhost ([127.0.0.1]:34015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpfCM-0006eu-OW for submit@debbugs.gnu.org; Sat, 15 Nov 2014 10:23:39 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:47460) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpfCJ-0006el-GF for 19054@debbugs.gnu.org; Sat, 15 Nov 2014 10:23:36 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XpfC1-0006gh-Ju; Sat, 15 Nov 2014 16:23:17 +0100 From: Lars Magne Ingebrigtsen To: pok@netfonds.no (Peder O. Klingenberg) Subject: Re: bug#19054: 25.0.50; Wrong envelope-from in report-emacs-bug References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUAAAAAAAMFBQ0BAwkA AAS6fXwICA8AAQY2Eh8AAQcETrc+AAACLElEQVQ4jW2TQaucMBDHtS286wrC0muWyuuxpuySWy2B 4AcQPG9pcG/dViq5FpTc80Dm23YmE2UfvCAK+fn/z0wyk2VxHQqtx6J0YSwO+VEGKbNDBLnW5t44 UOpeFK0iwKsw07ROgBtrOQEqTgmUZpwAVwBoDEi1W5VmcmFFKwDtULeBvCxNCy8QCIB8BSYHawTw CLK8+W5p3eB8sp/JK/sWy8ibT7PvfbeA1h9lCLJmgGXg79equsJLcwRMqo5WT7Xd1lWcRgJc4O8q bQ8LvkTMN4I6gcFHUUyYQRJ470liHCQgNgETtqLgu1PXdf1iHYRHIOzz3NFajKN0dythh7jf9SOG EAxIIgQLuu4GW3COkQQIMKvTG6C/QXiV7gNQtXgD+EvYgierFNyTk411kGKwlkFvEdR2L3D2SwRU uSTQICCjrvd+ToAVB1aQ+bxbYYyGwbCDbsE7r7fgHg8We6FnIOXZxnTPP8mCIH0IVDZ2yV/O3/P7 HysKBO9m3pq7GXU/GLxPnTgNlDS1NV1sCk4DovH32TuAF8fgnh94cmIr0By0j4q8OPoEFDBo0uSU LajJKYlTFR4VZenU2rT7eFQ7wJNbtYtjGCL48yWCo8O51DjIrKmr7Cun+zRNsDYmqJUEtRAbKPUR VoxzWUmBXZ7dN2CwN5TCdFsVwaZAF+XwJpSKV26zXww0HoQasQ4sPdTYs5wsPkZCi+nWynH07RA/ OLhcsAwJ1AqY1X/rL0NxGDWE/wAAAABJRU5ErkJggg== X-Now-Playing: Joni Mitchell's _Shadows And Light (1)_: "Amelia" X-Hashcash: 1:23:141115:19054@debbugs.gnu.org::0RrGBXzt1+HJL/de:00000000000000000000000000000000000000005q8o X-Hashcash: 1:23:141115:pok@netfonds.no::8dALjQQRWko18l+o:00v5on Date: Sat, 15 Nov 2014 16:23:17 +0100 In-Reply-To: (Peder O. Klingenberg's message of "Fri, 14 Nov 2014 10:55:59 +0100") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XpfC1-0006gh-Ju X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1416669798.31601@B+QC7rirhd980G1RhSZHHg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19054 Cc: 19054@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) pok@netfonds.no (Peder O. Klingenberg) writes: > (Creating a bug report from a mail thread on emacs-devel to keep it > alive. I probably should have done this as a bug report originally. > Original thread on http://permalink.gmane.org/gmane.emacs.devel/175920) Thanks; applied to emacs-24 (and to the trunk after a while). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 15 10:23:53 2014 Received: (at control) by debbugs.gnu.org; 15 Nov 2014 15:23:53 +0000 Received: from localhost ([127.0.0.1]:34018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpfCb-0006fN-4x for submit@debbugs.gnu.org; Sat, 15 Nov 2014 10:23:53 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:47465) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpfCZ-0006fF-Aq for control@debbugs.gnu.org; Sat, 15 Nov 2014 10:23:51 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XpfCH-0006gv-Lb for control@debbugs.gnu.org; Sat, 15 Nov 2014 16:23:33 +0100 Date: Sat, 15 Nov 2014 16:23:33 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #19054 X-MailScanner-ID: 1XpfCH-0006gv-Lb X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1416669814.77506@nmxF6YcpGXd+HwER9QkrWQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 19054 fixed close 19054 24.5 From unknown Sun Jun 22 22:45:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Dec 2014 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator