From unknown Sun Jun 22 07:53:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19044: 'guix-register -p' should perform deduplication Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 13 Nov 2014 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19044 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 19044@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14158978277791 (code B ref -1); Thu, 13 Nov 2014 16:58:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Nov 2014 16:57:07 +0000 Received: from localhost ([127.0.0.1]:59583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xoxhi-00021b-NM for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:57:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58495) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xoxhg-00021T-Re for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:57:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoxhX-00008z-JB for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:57:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoxhX-00008r-9d for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:56:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoxhO-0004Ka-5D for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoxhE-000076-Th for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:46 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:54916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoxhE-00006v-NT for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:36 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 146283FA5 for ; Thu, 13 Nov 2014 17:56:36 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lazaAHQt-j+U for ; Thu, 13 Nov 2014 17:56:35 +0100 (CET) Received: from pluto (pluto.bordeaux.inria.fr [193.50.110.57]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D29BC1B0A for ; Thu, 13 Nov 2014 17:56:35 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Brumaire an 223 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Thu, 13 Nov 2014 17:56:35 +0100 Message-ID: <87h9y3hwe4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) When used with -p (as is the case when building a disk/VM image), =E2=80=98guix-register=E2=80=99 doesn=E2=80=99t do any deduplication in the= target store, as noted in the source: /* XXX: When PREFIX is non-empty, store->linksDir points to the original store's '.links' directory, which means 'optimisePath' would try to li= nk to that instead of linking to the target store. Thus, disable deduplication in this case. */ if (optimize && prefix.empty ()) { /* Make sure deduplication is enabled. */ settings.autoOptimiseStore =3D true; foreach (ValidPathInfos::const_iterator, i, infos) store->optimisePath (i->path); } This should be fixed, but may need to diverge slightly from upstream libstore. Ludo=E2=80=99. From unknown Sun Jun 22 07:53:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#19044: closed (Re: bug#19044: 'guix-register -p' should perform deduplication) Message-ID: References: <877frbiww6.fsf@gnu.org> <87h9y3hwe4.fsf@gnu.org> X-Gnu-PR-Message: they-closed 19044 X-Gnu-PR-Package: guix Reply-To: 19044@debbugs.gnu.org Date: Wed, 10 Jun 2015 12:14:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1433938443-4683-1" This is a multi-part message in MIME format... ------------=_1433938443-4683-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19044: 'guix-register -p' should perform deduplication which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19044@debbugs.gnu.org. --=20 19044: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19044 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1433938443-4683-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19044-done) by debbugs.gnu.org; 10 Jun 2015 12:13:55 +0000 Received: from localhost ([127.0.0.1]:46749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2etG-0001D6-FS for submit@debbugs.gnu.org; Wed, 10 Jun 2015 08:13:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2etF-0001Cz-6b for 19044-done@debbugs.gnu.org; Wed, 10 Jun 2015 08:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2et9-00077Q-N6 for 19044-done@debbugs.gnu.org; Wed, 10 Jun 2015 08:13:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2et9-00077M-Ju for 19044-done@debbugs.gnu.org; Wed, 10 Jun 2015 08:13:47 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:38463 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1Z2et9-0006GA-2B for 19044-done@debbugs.gnu.org; Wed, 10 Jun 2015 08:13:47 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: 19044-done@debbugs.gnu.org Subject: Re: bug#19044: 'guix-register -p' should perform deduplication References: <87h9y3hwe4.fsf@gnu.org> Date: Wed, 10 Jun 2015 14:13:45 +0200 In-Reply-To: <87h9y3hwe4.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 13 Nov 2014 17:56:35 +0100") Message-ID: <877frbiww6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19044-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > When used with -p (as is the case when building a disk/VM image), > =E2=80=98guix-register=E2=80=99 doesn=E2=80=99t do any deduplication in t= he target store Fixed in 3697558. Ludo=E2=80=99. ------------=_1433938443-4683-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Nov 2014 16:57:07 +0000 Received: from localhost ([127.0.0.1]:59583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xoxhi-00021b-NM for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:57:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58495) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xoxhg-00021T-Re for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:57:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoxhX-00008z-JB for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:57:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoxhX-00008r-9d for submit@debbugs.gnu.org; Thu, 13 Nov 2014 11:56:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoxhO-0004Ka-5D for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoxhE-000076-Th for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:46 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:54916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoxhE-00006v-NT for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:36 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 146283FA5 for ; Thu, 13 Nov 2014 17:56:36 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lazaAHQt-j+U for ; Thu, 13 Nov 2014 17:56:35 +0100 (CET) Received: from pluto (pluto.bordeaux.inria.fr [193.50.110.57]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D29BC1B0A for ; Thu, 13 Nov 2014 17:56:35 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guix@gnu.org Subject: 'guix-register -p' should perform deduplication X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Brumaire an 223 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Thu, 13 Nov 2014 17:56:35 +0100 Message-ID: <87h9y3hwe4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) When used with -p (as is the case when building a disk/VM image), =E2=80=98guix-register=E2=80=99 doesn=E2=80=99t do any deduplication in the= target store, as noted in the source: /* XXX: When PREFIX is non-empty, store->linksDir points to the original store's '.links' directory, which means 'optimisePath' would try to li= nk to that instead of linking to the target store. Thus, disable deduplication in this case. */ if (optimize && prefix.empty ()) { /* Make sure deduplication is enabled. */ settings.autoOptimiseStore =3D true; foreach (ValidPathInfos::const_iterator, i, infos) store->optimisePath (i->path); } This should be fixed, but may need to diverge slightly from upstream libstore. Ludo=E2=80=99. ------------=_1433938443-4683-1--