From ian@digg.com Wed Jan 14 10:57:59 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jan 2009 18:57:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EIvtam028598 for ; Wed, 14 Jan 2009 10:57:56 -0800 Received: from mail.gnu.org ([199.232.76.166]:47116 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LNAun-0005WG-IV; Wed, 14 Jan 2009 13:56:33 -0500 Received: from mail.digg.com ([64.191.203.36]:33600) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNAw6-0005f1-4L; Wed, 14 Jan 2009 13:57:54 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 6002CA8507F; Wed, 14 Jan 2009 10:57:50 -0800 (PST) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qnInprv-PZO6; Wed, 14 Jan 2009 10:57:49 -0800 (PST) Received: from [10.2.16.90] (diggstage01.digg.com [64.191.203.34]) by mail.digg.com (Postfix) with ESMTP id C3178A84FE4; Wed, 14 Jan 2009 10:57:49 -0800 (PST) Message-Id: From: Ian Eure To: emacs-pretest-bug@gnu.org, alex@gnu.org, mmaug@yahoo.com Content-Type: text/plain; charset=WINDOWS-1252; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v930.3) Subject: 23.0.60; [PATCH] sql-sqlite doesn't work Date: Wed, 14 Jan 2009 10:57:49 -0800 X-Mailer: Apple Mail (2.930.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) The (sql-sqlite) function prompts for username, password, and server =20 even though these don=92t apply to SQLite. Further, it adds options for =20= them (--host, --user, --password) to the arguments of sql-sqlite-=20 program. The SQLite CLI doesn=92t understand or support these, and =20 returns this error if they=92re provided: sqlite3: unknown option: -user=3Dieure (The sqlite 2.8.x binary behaves in the same way.) For these reasons, I=92ve taken the following measures: 1. Removed 'user, 'password and 'server from :sqli-login for sqlite =20= in sql-product-alist; this prevents them from being read from the user =20= when (sql-sqlite) is invoked. 2. Removed the addition of the --host, --user, and --password =20 arguments to 'params in (sql-connect-sqlite). Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows. --- sql.el.~1.61.~ 2009-01-14 10:44:58.000000000 -0800 +++ sql.el 2009-01-14 10:50:09.000000000 -0800 @@ -356,7 +356,7 @@ :sqli-prompt-length 0) (sqlite :font-lock sql-mode-sqlite-font-lock-keywords - :sqli-login (user password server database) + :sqli-login (database) :sqli-connect sql-connect-sqlite :sqli-prompt-regexp "^sqlite> " :sqli-prompt-length 8) @@ -2611,12 +2611,6 @@ (let ((params)) (if (not (string=3D "" sql-database)) (setq params (append (list sql-database) params))) - (if (not (string=3D "" sql-server)) - (setq params (append (list (concat "--host=3D" sql-server)) = params))) - (if (not (string=3D "" sql-password)) - (setq params (append (list (concat "--password=3D" = sql-password)) =20 params))) - (if (not (string=3D "" sql-user)) - (setq params (append (list (concat "--user=3D" sql-user)) = params))) (if (not (null sql-sqlite-options)) (setq params (append sql-sqlite-options params))) (set-buffer (apply 'make-comint "SQL" sql-sqlite-program In GNU Emacs 23.0.60.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-01-14 on neutron.local Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Diff Minor modes in effect: diff-auto-refine-mode: t erc-track-mode: t erc-track-minor-mode: t erc-spelling-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-netsplit-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-autojoin-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t which-function-mode: t twit-mode: t yas/minor-mode: t ime-bindings: t shell-dirtrack-mode: t show-paren-mode: t recentf-mode: t iswitchb-mode: t auto-insert-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-x k RET C-x b s h e l M-> c d SPC ~ / P r e m c v s SPC u p SPC - A C-x 1 C-p C-p C-p C-p C-p C-p C-p C-p C-SPC M-b M-b M-b M-b M-b M-b M-w M-> r m SPC C-y c v s SPC u p SPC C-y s v n SPC x c s a SPC a r c v s SPC u p C-p C-x b s q l C-g C-x b s q l . e l C-x k RET C-x b s q l . e l C-x k RET M-> C-p C-p M-- M-z SPC M-> r m SPC C-y c v s SPC u p SPC C-y C-p C-p C-p C-e C-c C-x C-f RET C-x v =3D C-s s q l - c o n n e c t - s q l i t e C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-h v p r o g m C-g C-n C-p C-p C-p C-a C-n M-m C-SPC C-n C-n C-n C-n C-n C-n C-p C-e C-w C-d C-h v w r i e e v f b e f o - w s a M-: M-( s e q SPC t q SPC b e f M-/ - M-/ SPC n i l C-e C-x C-s C-x v =3D M-> M-< C-x C-w C-g C-SPC M-> M-w Recent messages: Making completion list... [2 times] Type C-x 1 to delete the help window, C-M-v to scroll help. Scanning for dabbrevs...100% [2 times] nil Saving file /Users/ieure/Projects/emacs/lisp/progmodes/sql.el... Wrote /Users/ieure/Projects/emacs/lisp/progmodes/sql.el Finding changes in /Users/ieure/Projects/emacs/lisp/progmodes/=20 sql.el...done Mark set [2 times] Quit Mark set= From cyd@stupidchicken.com Thu Jan 15 06:06:26 2009 Received: (at 1904) by emacsbugs.donarmstrong.com; 15 Jan 2009 14:06:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0FE6NZM011047 for <1904@emacsbugs.donarmstrong.com>; Thu, 15 Jan 2009 06:06:24 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id DE70657E21A; Thu, 15 Jan 2009 09:06:40 -0500 (EST) From: Chong Yidong To: Michael Mauger Cc: 1904@debbugs.gnu.org, Ian Eure Subject: Re: 23.0.60; [PATCH] sql-sqlite doesn't work Date: Thu, 15 Jan 2009 09:06:40 -0500 Message-ID: <8763kgoe8f.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Michael, could you evaluate this bug report and patch? Thanks. Ian Eure wrote: > The (sql-sqlite) function prompts for username, password, and server > even though these don=E2=80=99t apply to SQLite. Further, it adds options= for > them (--host, --user, --password) to the arguments of sql-sqlite- > program. The SQLite CLI doesn=E2=80=99t understand or support these, and > returns this error if they=E2=80=99re provided: > > sqlite3: unknown option: -user=3Dieure > > (The sqlite 2.8.x binary behaves in the same way.) > > For these reasons, I=E2=80=99ve taken the following measures: > > 1. Removed 'user, 'password and 'server from :sqli-login for sqlite=20=20 > in sql-product-alist; this prevents them from being read from the user=20= =20 > when (sql-sqlite) is invoked. > 2. Removed the addition of the --host, --user, and --password=20=20 > arguments to 'params in (sql-connect-sqlite). > > Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows. --- sql.el.~1.61.~ 2009-01-14 10:44:58.000000000 -0800 +++ sql.el 2009-01-14 10:50:09.000000000 -0800 @@ -356,7 +356,7 @@ :sqli-prompt-length 0) (sqlite :font-lock sql-mode-sqlite-font-lock-keywords - :sqli-login (user password server database) + :sqli-login (database) :sqli-connect sql-connect-sqlite :sqli-prompt-regexp "^sqlite> " :sqli-prompt-length 8) @@ -2611,12 +2611,6 @@ (let ((params)) (if (not (string=3D "" sql-database)) (setq params (append (list sql-database) params))) - (if (not (string=3D "" sql-server)) - (setq params (append (list (concat "--host=3D" sql-server)) params))) - (if (not (string=3D "" sql-password)) - (setq params (append (list (concat "--password=3D" sql-password)) para= ms))) - (if (not (string=3D "" sql-user)) - (setq params (append (list (concat "--user=3D" sql-user)) params))) (if (not (null sql-sqlite-options)) (setq params (append sql-sqlite-options params))) (set-buffer (apply 'make-comint "SQL" sql-sqlite-program From rgm@gnu.org Thu Feb 12 14:34:13 2009 Received: (at control) by emacsbugs.donarmstrong.com; 12 Feb 2009 22:34:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1CMYApq006768 for ; Thu, 12 Feb 2009 14:34:12 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LXk6M-0004W1-St; Thu, 12 Feb 2009 17:32:11 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18836.41834.798554.599838@fencepost.gnu.org> Date: Thu, 12 Feb 2009 17:32:10 -0500 From: Glenn Morris To: control Subject: control message tags 2271 moreinfo reassign 2309 emacs,w32 merge 1904 2313 reassign 2310 spam reassign 2311 spam reassign 2312 spam From rgm@gnu.org Fri Feb 13 19:40:25 2009 Received: (at 1904-done) by emacsbugs.donarmstrong.com; 14 Feb 2009 03:40:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1E3eMCM015900 for <1904-done@emacsbugs.donarmstrong.com>; Fri, 13 Feb 2009 19:40:23 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LYBMC-0000fA-M4; Fri, 13 Feb 2009 22:38:20 -0500 From: Glenn Morris To: 1904-done@debbugs.gnu.org Subject: Re: 23.0.60; [PATCH] sql-sqlite doesn't work References: <8763kgoe8f.fsf@cyd.mit.edu> X-Spook: quarter kilo class Blowfish nitrate War on Terrorism X-Ran: 5AH";65AdAwAR@5f!KBAxj?H+_O&BFw User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Installed, given that it looks fine and two people have come up with the same solution. (Bugs 1904, 2313). From unknown Sat Aug 16 22:46:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Mar 2009 14:24:09 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator