From unknown Thu Aug 14 12:25:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19033 <19033@debbugs.gnu.org> To: bug#19033 <19033@debbugs.gnu.org> Subject: Status: Manual: (elisp) `Advising Named Functions' does not describe FUNCTION Reply-To: bug#19033 <19033@debbugs.gnu.org> Date: Thu, 14 Aug 2025 19:25:59 +0000 retitle 19033 Manual: (elisp) `Advising Named Functions' does not describe = FUNCTION reassign 19033 emacs submitter 19033 Drew Adams severity 19033 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 12 12:12:26 2014 Received: (at submit) by debbugs.gnu.org; 12 Nov 2014 17:12:26 +0000 Received: from localhost ([127.0.0.1]:58895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XobT0-0002RD-0p for submit@debbugs.gnu.org; Wed, 12 Nov 2014 12:12:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XobSw-0002R4-JY for submit@debbugs.gnu.org; Wed, 12 Nov 2014 12:12:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XobSm-0006PH-BA for submit@debbugs.gnu.org; Wed, 12 Nov 2014 12:12:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XobSm-0006PD-8s for submit@debbugs.gnu.org; Wed, 12 Nov 2014 12:12:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XobSd-0003eP-HZ for bug-gnu-emacs@gnu.org; Wed, 12 Nov 2014 12:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XobST-0006L1-79 for bug-gnu-emacs@gnu.org; Wed, 12 Nov 2014 12:12:03 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:27552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XobST-0006KZ-1i for bug-gnu-emacs@gnu.org; Wed, 12 Nov 2014 12:11:53 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sACHBnKJ008045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Nov 2014 17:11:50 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id sACHBnrj029042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 12 Nov 2014 17:11:49 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id sACHBmKA029010 for ; Wed, 12 Nov 2014 17:11:48 GMT MIME-Version: 1.0 Message-ID: <97aa8252-de9e-4a3d-9a79-4d080bc17aaa@default> Date: Wed, 12 Nov 2014 09:11:47 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; (elisp) `Advising Named Functions' does not describe FUNCTION X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This node sends you off to node `Core Advising Primitives' for information about parameters WHERE and PROPS. That's bad enough, since `Advising Named Functions' is intended as the MAIN entry point for advising functions: "But you should use `advice-add' and `advice-remove' for that instead." But `Advising Named Functions' tells you nothing about FUNCTION. In particular, it does not tell you what its signature must be or must fit. Worse still, neither does node `Core Advising Primitives' tell you anything about the signature of FUNCTION! So it would not even be enough to send readers to that node for information about FUNCTION, as we do now for WHERE and PROPS. What must FUNCTION accept as argument(s)? What must it return? If there are no restrictions on its signature, then say so. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 10:07:16 2017 Received: (at control) by debbugs.gnu.org; 16 Jul 2017 14:07:17 +0000 Received: from localhost ([127.0.0.1]:42543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWkCa-0008Fc-Oe for submit@debbugs.gnu.org; Sun, 16 Jul 2017 10:07:16 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:38484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWkCZ-0008FS-8l for control@debbugs.gnu.org; Sun, 16 Jul 2017 10:07:15 -0400 Received: by mail-it0-f42.google.com with SMTP id h199so8104540ith.1 for ; Sun, 16 Jul 2017 07:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=p1ymauCRiXQeA+rE/ylCw+p9OXCX5/iIspWcKmi89GY=; b=Kt/qAzb0XLrjdQB/koYvb5SRwmo2xWLbISsYj8UZQ5Co51sIDjR+PZpltfaVjFzbJX a/THHQy2BgU2tQhhcsw58hWV2GQEKQXWLN+W73dMWUa72u4S0QI0Sex8iyeBVYr/ee4m OgCOpGb4lxSzr2bYkLvgDwIQdWN6mYSG8HFBFVRDyi4wVn0jr3AurBWwAuOopZS/uFd8 kg0LFqgyiLFRtpdJq9VxyG5lm3Snh6SjonGZM0GxP93mNuVaXDrhuLHvX8rMaMKM7abI sCaBskJ4no1bgbteYLizq6ug4+WVzJD0yqb4msrugbOps1JIdFaPMVJvCcWsk19j9UHj Nc7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=p1ymauCRiXQeA+rE/ylCw+p9OXCX5/iIspWcKmi89GY=; b=JuCJ/JCYahnbpNbUfJEEJcwtn+xgCG8RvWoetXsrbwCOfPLHH+selC5etBFOUS6uD6 hE+ebe5z+el655w3yLi4BwSh3+YK89ReRqKN7zuwrvyt8mrx/N/T1ubeo/i/jgeav7KB PxT/5LSiX1iRLW08723CkaK02RGKuRXAbnXHUhjET6D+ROzCJWaCXMdpT7iEU3BmFdjn jUDewy2USf/5lAZ7qmGgK1AabyUmYKWjN50usyUIXrBFmxf6GjSd52FTg0omVNWFaaq2 rdpA1a2PBfXNt8sc2N5rbAjTlDLzQSJfNrb8EhWmEWXo8SnZAyN9zYoWyVkedvzzpU2b h0sw== X-Gm-Message-State: AIVw110pmQuNCDqXwILSP9FXCuaRCvT61XyDC9WwUTgQ2dmRHUEusURQ CN2kMHxNnRZNmfzG X-Received: by 10.36.65.74 with SMTP id x71mr1856177ita.102.1500214029313; Sun, 16 Jul 2017 07:07:09 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id t7sm5560136ita.1.2017.07.16.07.07.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jul 2017 07:07:08 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #19033 Date: Sun, 16 Jul 2017 10:08:43 -0400 Message-ID: <87h8yccw44.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) retitle 19033 Manual: (elisp) `Advising Named Functions' does not describe FUNCTION quit From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 21:46:20 2019 Received: (at 19033) by debbugs.gnu.org; 9 Oct 2019 01:46:21 +0000 Received: from localhost ([127.0.0.1]:51714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI13U-0003ns-IU for submit@debbugs.gnu.org; Tue, 08 Oct 2019 21:46:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI13S-0003nk-P5 for 19033@debbugs.gnu.org; Tue, 08 Oct 2019 21:46:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI13O-0000xA-GW; Wed, 09 Oct 2019 03:46:16 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#19033: 25.0.50; (elisp) `Advising Named Functions' does not describe FUNCTION References: <97aa8252-de9e-4a3d-9a79-4d080bc17aaa@default> Date: Wed, 09 Oct 2019 03:46:14 +0200 In-Reply-To: <97aa8252-de9e-4a3d-9a79-4d080bc17aaa@default> (Drew Adams's message of "Wed, 12 Nov 2014 09:11:47 -0800 (PST)") Message-ID: <87y2xuwv15.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > This node sends you off to node `Core Advising Primitives' for > information about parameters WHERE and PROPS. > > That's bad enough, since `Advising Named Functions' is intended as the > MAIN entry [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19033 Cc: 19033@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > This node sends you off to node `Core Advising Primitives' for > information about parameters WHERE and PROPS. > > That's bad enough, since `Advising Named Functions' is intended as the > MAIN entry point for advising functions: > > "But you should use `advice-add' and `advice-remove' for that instead." > > But `Advising Named Functions' tells you nothing about FUNCTION. In > particular, it does not tell you what its signature must be or must fit. > > Worse still, neither does node `Core Advising Primitives' tell you > anything about the signature of FUNCTION! So it would not even be > enough to send readers to that node for information about FUNCTION, > as we do now for WHERE and PROPS. > > What must FUNCTION accept as argument(s)? What must it return? > If there are no restrictions on its signature, then say so. If I understand correctly, what you want is that the @defmac add-function where place function &optional props in @node Core Advising Primitives should describe what parameters @var{function} takes in that macro. That is indeed not described in that node, presumably because it's complicated. Instead, we're directed to @var{where} determines how @var{function} is composed with the existing function, e.g., whether @var{function} should be called before, or after the original function. @xref{Advice Combinators}, for the list of available ways to compose the two functions. where we find stuff like @table @code @item :before Call @var{function} before the old function. Both functions receive the same arguments I think that makes sense -- trying to say anything about the parameters before talking about @var{where} is pretty futile, because @var{where} decides what parameters the function will receive. So I don't see anything to fix here, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 21:46:29 2019 Received: (at control) by debbugs.gnu.org; 9 Oct 2019 01:46:29 +0000 Received: from localhost ([127.0.0.1]:51717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI13b-0003oD-Uw for submit@debbugs.gnu.org; Tue, 08 Oct 2019 21:46:28 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI13Z-0003o5-MC for control@debbugs.gnu.org; Tue, 08 Oct 2019 21:46:27 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI13W-0000xN-TY for control@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:24 +0200 Date: Wed, 09 Oct 2019 03:46:22 +0200 Message-Id: <87wodewv0x.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19033 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 19033 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 19033 quit From unknown Thu Aug 14 12:25:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 06 Nov 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator