From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 12 11:41:49 2014 Received: (at submit) by debbugs.gnu.org; 12 Nov 2014 16:41:49 +0000 Received: from localhost ([127.0.0.1]:58864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoazM-0001f9-MB for submit@debbugs.gnu.org; Wed, 12 Nov 2014 11:41:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37729) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoX5s-0003s5-4B for submit@debbugs.gnu.org; Wed, 12 Nov 2014 07:32:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoX5i-0002RY-Ta for submit@debbugs.gnu.org; Wed, 12 Nov 2014 07:32:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoX5i-0002RU-RE for submit@debbugs.gnu.org; Wed, 12 Nov 2014 07:32:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoX5c-00021v-Gj for bug-gnu-emacs@gnu.org; Wed, 12 Nov 2014 07:32:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoX5W-0002Pw-9M for bug-gnu-emacs@gnu.org; Wed, 12 Nov 2014 07:32:00 -0500 Received: from mail-vc0-f171.google.com ([209.85.220.171]:54676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoX5W-0002Ps-6F for bug-gnu-emacs@gnu.org; Wed, 12 Nov 2014 07:31:54 -0500 Received: by mail-vc0-f171.google.com with SMTP id id10so2055215vcb.16 for ; Wed, 12 Nov 2014 04:31:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=j7gXBj6Ta4RqelWeIFGgQR0ymQRlfNVkpGEhdpSogI4=; b=P09g3ut3nTG9COJq9+F6UoFFjydC5/AxAZDaAHFRzjr2kQfCq5Nw23ZF2L8JyP9yc1 i8rb3uipcrDLnIP3qAPmgLXpIPBx4q/yqh4rcK75y8ARXtx8C/p8XhQM+0Ol0tqHWIMX G4TcKKTtWYUskdggkQboyHy+0FMQTlNA4cho3Sv/+gp/UmRW6KwZohpPGVj+8XXOWWVn zoBNeQfZDVl8blQ8/XCqhRGL9WKVnoLp2pehJlF3x7kQii4rvUgk3GHlMFZfaAliBlkM 0+mMQMQmqUUKTQNu3WOuedCaZfg8O+b862zCN3KwhuLQHsN8PibLyEP5KXSgUvHK30Ep g1pA== X-Gm-Message-State: ALoCoQmwSmpbIo9g0br7K3obRTTxGbvfT++sZGYoQHSlqkeWJBNBQQV1UGQYS15C/TxcwzSnYgkW X-Received: by 10.220.127.5 with SMTP id e5mr13496707vcs.40.1415795513596; Wed, 12 Nov 2014 04:31:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.99.133 with HTTP; Wed, 12 Nov 2014 04:31:33 -0800 (PST) From: Ole Laursen Date: Wed, 12 Nov 2014 13:31:33 +0100 Message-ID: Subject: 24.4; icomplete cannot select matches with C-x b with no input To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 12 Nov 2014 11:41:44 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Run emacs -Q, evaluate (icomplete-mode 1) (setq icomplete-show-matches-on-no-input t) Make sure you have three buffers, e.g. by finding three files. Then hit C-x b which should immediately show all buffers and use C-. or C-, to select any other buffer than what the modeline declares to be the default, and hit C-j or RET. Emacs then switches to the default buffer instead of the selected buffer. Ole From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 15 18:08:18 2014 Received: (at 19032) by debbugs.gnu.org; 15 Nov 2014 23:08:18 +0000 Received: from localhost ([127.0.0.1]:34193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpmS1-0000Md-Do for submit@debbugs.gnu.org; Sat, 15 Nov 2014 18:08:17 -0500 Received: from mx0.mattleach.net ([176.58.118.143]:57918) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpmRz-0000MR-5J for 19032@debbugs.gnu.org; Sat, 15 Nov 2014 18:08:16 -0500 Received: by mx0.mattleach.net (Postfix, from userid 99) id 557D461AC6; Sat, 15 Nov 2014 23:08:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from matt-desktop.home.mattleach.net (host86-180-142-129.range86-180.btcentralplus.com [86.180.142.129]) by mx0.mattleach.net (Postfix) with ESMTPSA id 7178461AB6; Sat, 15 Nov 2014 23:08:13 +0000 (GMT) From: Matthew Leach To: Ole Laursen Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input In-Reply-To: (Ole Laursen's message of "Wed, 12 Nov 2014 13:31:33 +0100") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Sat, 15 Nov 2014 23:08:12 +0000 Message-ID: <8761egqcyr.fsf@matt-desktop.home> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: 19032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hello, Ole Laursen writes: > Run emacs -Q, evaluate > > (icomplete-mode 1) > (setq icomplete-show-matches-on-no-input t) > > Make sure you have three buffers, e.g. by finding three files. Then > hit C-x b which should immediately show all buffers and use C-. or C-, > to select any other buffer than what the modeline declares to be the > default, and hit C-j or RET. > > Emacs then switches to the default buffer instead of the selected buffer. I'm not sure if this is expected behaviour, since the "default" prompt in the minibuffer doesn't disappear when cycling through results. Nevertheless attached is a patch that fixes this. -- Matt lisp/ChangeLog: 2014-11-15 Matthew Leach * minibuffer.el (completion-use-stored-completions-when-no-input): New. (completion--complete-and-exit): Use the above to decide whether to use the car of `completion-all-sorted-completions' as the candidate. * icomplete.el (icomplete-minibuffer-setup): set `completion-use-stored-completions-when-no-input' when `icomplete-show-matches-on-no-input' is t. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=icomplete-cycle-fix.patch diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 95a6e1b..dc90f0e 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -262,6 +262,7 @@ Usually run by inclusion in `minibuffer-setup-hook'." (add-hook 'post-command-hook #'icomplete-post-command-hook nil t) (run-hooks 'icomplete-minibuffer-setup-hook) (when icomplete-show-matches-on-no-input + (setq completion-use-stored-completions-when-no-input t) (icomplete-exhibit)))) (defvar icomplete--in-region-buffer nil) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index c9ce381..4ea0530 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -969,6 +969,7 @@ completion candidates than this number." (defvar-local completion-all-sorted-completions nil) (defvar-local completion--all-sorted-completions-location nil) (defvar completion-cycling nil) +(defvar completion-use-stored-completions-when-no-input nil) (defvar completion-fail-discreetly nil "If non-nil, stay quiet when there is no match.") @@ -1332,8 +1333,15 @@ If `minibuffer-completion-confirm' is `confirm-after-completion', COMPLETION-FUNCTION is called if the current buffer's content does not appear to be a match." (cond - ;; Allow user to specify null string - ((= beg end) (funcall exit-function)) + ;; Allow user to specify null string. In the case that + ;; `completion-use-stored-completions-when-no-input' is t, use + ;; the car of `completion-all-sorted-completions' as the + ;; candidate. + ((= beg end) + (when completion-use-stored-completions-when-no-input + (completion--replace beg end (car completion-all-sorted-completions))) + (funcall exit-function)) + ((test-completion (buffer-substring beg end) minibuffer-completion-table minibuffer-completion-predicate) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 21:34:58 2019 Received: (at control) by debbugs.gnu.org; 30 Sep 2019 01:34:58 +0000 Received: from localhost ([127.0.0.1]:56338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEkaX-0000Q2-VR for submit@debbugs.gnu.org; Sun, 29 Sep 2019 21:34:58 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:43995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEkaV-0000Pi-TZ for control@debbugs.gnu.org; Sun, 29 Sep 2019 21:34:56 -0400 Received: by mail-pf1-f182.google.com with SMTP id a2so4623320pfo.10 for ; Sun, 29 Sep 2019 18:34:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=RtgHPcLqd/9/cW7C0vmFlTwIlhgV+r8bKaIoNk8x5bA=; b=aYUclsk5fr9S95w5ZCWSgjrqavr+ZZwPoKiP+Lj8LUkb1x6rCUIFBhOQo7RYCHGH07 jP5TdbON0rYoJdzu5KowclwqYpJx7A+xX+6LMGtAsjfxoNqRbBe2uEZJQWXXbtV9vPje 18hmBbQTNOTf2BRCuITp6tRtyKvoftYhjeVIjRHBNE3jdKhPA5GQpIHCclpsJ3PY/Sfl FVDTeZluuoYrbyhqt7qt2kZBUsQrPUy8aHzUYREiJvVMfFmOhwRbURBBF8jlqbT+pyaV dsSMNrsBjJn1b6H7pouhFdXp+la2O3V1XWfPihGkFYHOeKvuFKD/UTBj5jlRYaalAkt9 NScw== X-Gm-Message-State: APjAAAUiDHwHg0zovgIMflnLUBQaEhtlINb54Duz+gKQaZLZKk2K99s9 YDUWj6XyWFk/WTQ9I4U4C/ZBxYAe71QtD8Yl0Guh1c5IuwM= X-Google-Smtp-Source: APXvYqyZfg1FTeEkpu8il8N/bJzODppotbqOWeQYKNRTDu0B7eSpNje22oF9/dnPi53IPgsqFgKbd+iRrFdBOfGg9ps= X-Received: by 2002:a17:90a:1150:: with SMTP id d16mr24521305pje.2.1569807289989; Sun, 29 Sep 2019 18:34:49 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Mon, 30 Sep 2019 03:34:39 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 19032 + patch quit Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.182 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 19032 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 05:34:41 2020 Received: (at 19032) by debbugs.gnu.org; 13 Aug 2020 09:34:41 +0000 Received: from localhost ([127.0.0.1]:46918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k69dA-0007iN-SZ for submit@debbugs.gnu.org; Thu, 13 Aug 2020 05:34:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k69d6-0007i6-5m for 19032@debbugs.gnu.org; Thu, 13 Aug 2020 05:34:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fVm2BaWnqz2Hey7UxeLsJ27MS4OSQw9RWRgWY0VwF5c=; b=q3TcXnUSYaqdkTYdhMl5ISro3e gN2dLmDF72TW8Fds+R8X+hEhyTy4bx3+BlAbtw5F3o6TIXgKzAgiKSqGivRO8bX5FO6rCk9SnWho+ Dc2IUxDyCjwvTDrrWpAEpjvRrTuOC8hZ9HzbYmczm36yaW5z+4EDuMKjBENSFE4bLjR8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k69cv-0004Vg-4g; Thu, 13 Aug 2020 11:34:29 +0200 From: Lars Ingebrigtsen To: Matthew Leach Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input References: <8761egqcyr.fsf@matt-desktop.home> Date: Thu, 13 Aug 2020 11:34:22 +0200 In-Reply-To: <8761egqcyr.fsf@matt-desktop.home> (Matthew Leach's message of "Sat, 15 Nov 2014 23:08:12 +0000") Message-ID: <874kp6hotd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matthew Leach writes: >> Run emacs -Q, evaluate >> >> (icomplete-mode 1) >> (setq icomplete-show-matches-on-no-input t) >> >> Make sure you have three buffers, e.g. by finding three files. Then >> hit C-x b which should im [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Ole Laursen , Stefan Monnier , 19032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthew Leach writes: >> Run emacs -Q, evaluate >> >> (icomplete-mode 1) >> (setq icomplete-show-matches-on-no-input t) >> >> Make sure you have three buffers, e.g. by finding three files. Then >> hit C-x b which should immediately show all buffers and use C-. or C-, >> to select any other buffer than what the modeline declares to be the >> default, and hit C-j or RET. >> >> Emacs then switches to the default buffer instead of the selected buffer. > > I'm not sure if this is expected behaviour, since the "default" prompt > in the minibuffer doesn't disappear when cycling through results. > Nevertheless attached is a patch that fixes this. I've respun the patch for Emacs 28, and I think the new behaviour makes a lot more sense than the old behaviour, which I couldn't understand the point of at all. But I'm not an icomplete user, so perhaps the old behaviour is what people want? This also has possible ramifications for other completion styles (although only icomplete enables it with this patch), so I wonder whether Stefan has any comments here? diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 3747ae3d28..e3f7043e2c 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -432,6 +432,8 @@ icomplete-minibuffer-setup (current-local-map))) (add-hook 'pre-command-hook #'icomplete-pre-command-hook nil t) (add-hook 'post-command-hook #'icomplete-post-command-hook nil t) + (when icomplete-show-matches-on-no-input + (setq-local completion-use-stored-completions-when-no-input t)) (run-hooks 'icomplete-minibuffer-setup-hook))) (defvar icomplete--in-region-buffer nil) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index d2c3f9045e..c3e5440956 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1126,6 +1126,7 @@ completion--cycle-threshold (defvar-local completion-all-sorted-completions nil) (defvar-local completion--all-sorted-completions-location nil) (defvar completion-cycling nil) ;Function that takes down the cycling map. +(defvar completion-use-stored-completions-when-no-input nil) (defvar completion-fail-discreetly nil "If non-nil, stay quiet when there is no match.") @@ -1510,8 +1511,15 @@ completion--complete-and-exit COMPLETION-FUNCTION is called if the current buffer's content does not appear to be a match." (cond - ;; Allow user to specify null string - ((= beg end) (funcall exit-function)) + ;; Allow user to specify null string. In the case that + ;; `completion-use-stored-completions-when-no-input' is t, use + ;; the car of `completion-all-sorted-completions' as the + ;; candidate. + ((= beg end) + (when completion-use-stored-completions-when-no-input + (completion--replace beg end (car completion-all-sorted-completions))) + (funcall exit-function)) + ((test-completion (buffer-substring beg end) minibuffer-completion-table minibuffer-completion-predicate) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 06:00:29 2020 Received: (at 19032) by debbugs.gnu.org; 13 Aug 2020 10:00:29 +0000 Received: from localhost ([127.0.0.1]:46966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6A28-0002cA-Ir for submit@debbugs.gnu.org; Thu, 13 Aug 2020 06:00:29 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:46373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6A24-0002S3-NO for 19032@debbugs.gnu.org; Thu, 13 Aug 2020 06:00:27 -0400 Received: by mail-lj1-f196.google.com with SMTP id h19so5481943ljg.13 for <19032@debbugs.gnu.org>; Thu, 13 Aug 2020 03:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iola-dk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QMeYt1DDtQgo/aZ9sfVdb9LtlczaU8TwlKEzjVrwvWs=; b=ADOxa4mk8G295dnV+m6RPsqpoELdFwws33/qbNyyA+ZfvNTbY/yu7wbyjq/rg5d4U8 PnH8rCLMARJS85Q2X3e5P0+00ks1eCb28ZFd5uAcoAM7wR5A6zwKEznkqKGBRwc2WTkY 54fqsTxyFTkqJU1Q7pld5kR9EICt0brzMw53x1KEr8kYirWeJ2vxQFK//hkMT4YG+3+e PNRN0qubpNQ+UVx0Fqw7zqGCmsWL2kmysaEZAbqp0scE3jUxReInfQj4E5xK5yH0y4CB DpOk1ksXhJBOOo1Nt5I/fZwPAOopvmLtCDTxt5qTsS/D5I8O5ITaoF4qWIrHrO6UzQcT Ms/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QMeYt1DDtQgo/aZ9sfVdb9LtlczaU8TwlKEzjVrwvWs=; b=UDpKqpiNQUGeYhOn1VSTvnRcjRvpz0mLBeVHeqNUcLrva/CKASorY2e4C09XExC7+J TXBpHfxJPdWmEEi7T4kKvO5pS9mnT1CwM2CDOlPinypgtJdweYAtuSN3Q8+rIaBU97CN rtmKueYK1zw/boox5KBhiLCCw0hsuE7xM9i5fPoAlBqfs39L/4lXlS1F48qCEzNWMye9 Y7tEmSNPG3qcyfX+Ykgvg/orXRbWHrXBEEU+4D+ZJ00T6G6De21B8bXfgsNY53fLmioU MXl/Ziox1rrCNIzkpThY/6p3A382uQJKNLySKpBcrTFYxpRjXOw9vva8dW+rN9hp7JtR afTQ== X-Gm-Message-State: AOAM531iQZUOm5lqXNtkJ0Xv83nvKRTYqqVmVugtGHSlLTpCCFByxHe4 o8qEHSg9LairlcSmjmx0Sz+XzPqRprtk2MybJNBbGA== X-Google-Smtp-Source: ABdhPJwQZtouP410XzB28seCuGRPw0fiTGx3u2IcqfCXGco0W5OoNNcj2Lnq1CL6LseTT6UUU5eT3uumnnREmEl89Yc= X-Received: by 2002:a2e:9946:: with SMTP id r6mr1701962ljj.127.1597312818538; Thu, 13 Aug 2020 03:00:18 -0700 (PDT) MIME-Version: 1.0 References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> In-Reply-To: <874kp6hotd.fsf@gnus.org> From: Ole Laursen Date: Thu, 13 Aug 2020 12:00:07 +0200 Message-ID: Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Matthew Leach , Stefan Monnier , 19032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks! I'm a former iswitchb user, and this problem keeps me from switching to icomplete (I'm currently on ido-switch-buffer), even though I would like to have access to more advanced completion. Ole Den tor. 13. aug. 2020 kl. 11.34 skrev Lars Ingebrigtsen : > > Matthew Leach writes: > > >> Run emacs -Q, evaluate > >> > >> (icomplete-mode 1) > >> (setq icomplete-show-matches-on-no-input t) > >> > >> Make sure you have three buffers, e.g. by finding three files. Then > >> hit C-x b which should immediately show all buffers and use C-. or C-, > >> to select any other buffer than what the modeline declares to be the > >> default, and hit C-j or RET. > >> > >> Emacs then switches to the default buffer instead of the selected buffer. > > > > I'm not sure if this is expected behaviour, since the "default" prompt > > in the minibuffer doesn't disappear when cycling through results. > > Nevertheless attached is a patch that fixes this. > > I've respun the patch for Emacs 28, and I think the new behaviour makes > a lot more sense than the old behaviour, which I couldn't understand the > point of at all. > > But I'm not an icomplete user, so perhaps the old behaviour is what > people want? > > This also has possible ramifications for other completion styles > (although only icomplete enables it with this patch), so I wonder > whether Stefan has any comments here? > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > index 3747ae3d28..e3f7043e2c 100644 > --- a/lisp/icomplete.el > +++ b/lisp/icomplete.el > @@ -432,6 +432,8 @@ icomplete-minibuffer-setup > (current-local-map))) > (add-hook 'pre-command-hook #'icomplete-pre-command-hook nil t) > (add-hook 'post-command-hook #'icomplete-post-command-hook nil t) > + (when icomplete-show-matches-on-no-input > + (setq-local completion-use-stored-completions-when-no-input t)) > (run-hooks 'icomplete-minibuffer-setup-hook))) > > (defvar icomplete--in-region-buffer nil) > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index d2c3f9045e..c3e5440956 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1126,6 +1126,7 @@ completion--cycle-threshold > (defvar-local completion-all-sorted-completions nil) > (defvar-local completion--all-sorted-completions-location nil) > (defvar completion-cycling nil) ;Function that takes down the cycling map. > +(defvar completion-use-stored-completions-when-no-input nil) > > (defvar completion-fail-discreetly nil > "If non-nil, stay quiet when there is no match.") > @@ -1510,8 +1511,15 @@ completion--complete-and-exit > COMPLETION-FUNCTION is called if the current buffer's content does not > appear to be a match." > (cond > - ;; Allow user to specify null string > - ((= beg end) (funcall exit-function)) > + ;; Allow user to specify null string. In the case that > + ;; `completion-use-stored-completions-when-no-input' is t, use > + ;; the car of `completion-all-sorted-completions' as the > + ;; candidate. > + ((= beg end) > + (when completion-use-stored-completions-when-no-input > + (completion--replace beg end (car completion-all-sorted-completions))) > + (funcall exit-function)) > + > ((test-completion (buffer-substring beg end) > minibuffer-completion-table > minibuffer-completion-predicate) > > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 09:43:51 2020 Received: (at 19032) by debbugs.gnu.org; 13 Aug 2020 13:43:51 +0000 Received: from localhost ([127.0.0.1]:47456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6DWJ-0002hN-FA for submit@debbugs.gnu.org; Thu, 13 Aug 2020 09:43:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6DWG-0002h9-Tx for 19032@debbugs.gnu.org; Thu, 13 Aug 2020 09:43:50 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4AE6E44127F; Thu, 13 Aug 2020 09:43:43 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CE2D044127C; Thu, 13 Aug 2020 09:43:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1597326221; bh=WJKVKhrp7x26DStHUHt2lfOjVfF3arkbL2mqMlCuLz4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bKTZjiZOoE36rvvA7w0DoYycj3LZOoFTOWxZ3R2St98TiLtF8iudu7QXkrpQsb+fv gNyekR5fFsAV0H6fV5meKSFsSRcAzNk399PR5JKOsca2FA4OJzptUbj5SM5sbgFj2S oYmxsaGSczwDDpchoGz/UpvBXRcbzWxrr9AJrY8+yBnkTgrK95Lxt1zkFK/Hjf9wQk XRsf+hjjYr5ofKde8mHjzxCtXSmHYuwNDuB5OyQuGX7v3O0Iu5fWU/4kbLKTwviROa DqrjsI+1N94hYYURF3zIdsfXqEBI1SVBYwKXuzBhqhunZGkRS7VuKrtl0bLSUsalrm MhavqYgvURpcA== Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9DB8912036E; Thu, 13 Aug 2020 09:43:41 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input Message-ID: References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> Date: Thu, 13 Aug 2020 09:43:41 -0400 In-Reply-To: <874kp6hotd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 13 Aug 2020 11:34:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19032 Cc: Matthew Leach , 19032@debbugs.gnu.org, Ole Laursen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > +(defvar completion-use-stored-completions-when-no-input nil) > (defvar completion-fail-discreetly nil > "If non-nil, stay quiet when there is no match.") > @@ -1510,8 +1511,15 @@ completion--complete-and-exit > COMPLETION-FUNCTION is called if the current buffer's content does not > appear to be a match." > (cond > - ;; Allow user to specify null string > - ((= beg end) (funcall exit-function)) > + ;; Allow user to specify null string. In the case that > + ;; `completion-use-stored-completions-when-no-input' is t, use > + ;; the car of `completion-all-sorted-completions' as the > + ;; candidate. > + ((= beg end) > + (when completion-use-stored-completions-when-no-input > + (completion--replace beg end (car completion-all-sorted-completions))) > + (funcall exit-function)) Would it be cleaner to have the following instead? ;; Allow user to specify null string. Obey `completion-content-when-empty`. ((= beg end) (when completion-content-when-empty (completion--replace beg end completion-content-when-empty)) (funcall exit-function)) So icomplete would be in charge of setting that var to the `car` of `completion-all-sorted-completions`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 07:03:30 2020 Received: (at 19032) by debbugs.gnu.org; 14 Aug 2020 11:03:30 +0000 Received: from localhost ([127.0.0.1]:51955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XUf-0001LT-NK for submit@debbugs.gnu.org; Fri, 14 Aug 2020 07:03:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XUe-0001LG-1D for 19032@debbugs.gnu.org; Fri, 14 Aug 2020 07:03:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sV1XRnhJoDnFqPseMP0lRW17LlC6qs89dZVWdTq4oRk=; b=jiCtsNFQz/Kr2ZBajqIAKMpjHS SbXFonUM5zBNhzAU3Kto7f2MQJVqQhHwRTdI7RrnRqpAoW1rgNgtEUlpQbLSk/jJ9huab8cczKTY+ xd1yaOMyGH4bdFoYz8C1B2VRig1Zq1msQ6AJO8UdYzYahQIW1qaLw+umMLBwbCK/Igno=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6XUR-00012b-GO; Fri, 14 Aug 2020 13:03:20 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> Date: Fri, 14 Aug 2020 13:03:14 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Aug 2020 09:43:41 -0400") Message-ID: <87mu2xa3rh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Would it be cleaner to have the following instead? > > ;; Allow user to specify null string. Obey `completion-content-when-empty`. > ((= beg end) > (when completion-content-when-empty > (completion- [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Matthew Leach , 19032@debbugs.gnu.org, Ole Laursen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > Would it be cleaner to have the following instead? > > ;; Allow user to specify null string. Obey `completion-content-when-empty`. > ((= beg end) > (when completion-content-when-empty > (completion--replace beg end completion-content-when-empty)) > (funcall exit-function)) > > So icomplete would be in charge of setting that var to the `car` of > `completion-all-sorted-completions`. Yeah, that makes sense. I'll take a stab at implementing it that way. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 07:31:12 2020 Received: (at 19032) by debbugs.gnu.org; 14 Aug 2020 11:31:13 +0000 Received: from localhost ([127.0.0.1]:51989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XvU-0003BD-Mx for submit@debbugs.gnu.org; Fri, 14 Aug 2020 07:31:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XvS-00033q-KV for 19032@debbugs.gnu.org; Fri, 14 Aug 2020 07:31:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=djx8UOwyZJYS+EGKtfX+A+VC2m48Hp6daVboLJhhwjA=; b=rfdfMHqd56g5J+baYHXFxYcaal w5ejrPTbq9aNG7K7ZqCKb7WJ7nQjLyPve6r3DzEI9Et+K1mLVx6I8kP7QolRxtS5983XUscEpXpBC 8nZptZi1A75uoS5EYNlcFEacww1o2HIT074FwlFAUUP8s8NnbZGekLE677LpgCd+Czvo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6XvD-0001HE-Q4; Fri, 14 Aug 2020 13:31:03 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> <87mu2xa3rh.fsf@gnus.org> Date: Fri, 14 Aug 2020 13:30:54 +0200 In-Reply-To: <87mu2xa3rh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 14 Aug 2020 13:03:14 +0200") Message-ID: <87imdla2hd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Yeah, that makes sense. I'll take a stab at implementing it that way. I think I found where in the icomplete machinery to set this variable, so I've now pushed this change. It would be nice if others could test this, too, and see whether it works. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Matthew Leach , 19032@debbugs.gnu.org, Ole Laursen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Yeah, that makes sense. I'll take a stab at implementing it that way. I think I found where in the icomplete machinery to set this variable, so I've now pushed this change. It would be nice if others could test this, too, and see whether it works. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 07:31:18 2020 Received: (at control) by debbugs.gnu.org; 14 Aug 2020 11:31:18 +0000 Received: from localhost ([127.0.0.1]:51992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XvZ-0003GO-V7 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 07:31:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XvY-00039b-45 for control@debbugs.gnu.org; Fri, 14 Aug 2020 07:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n+kTWcypl40sCXZg4w5LsGIF+FRhPiQLw3gVaRCuak8=; b=eIEwJVVEImeeo73I6ZQ1piaStR tRfyckDiu74QEvmz0/3lYUx9bLSndT8TgHLujB3xRVbc9buGFw2EEBJ8AyZk7GOgVudAtUqGR+xpr e+qUEa7mzQJpxTOsZiDtVQdbpR65YCYn9PT/QcvRVVFLILHlrFR/4hDXclguU/iNtb9w=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6XvQ-0001HY-D4 for control@debbugs.gnu.org; Fri, 14 Aug 2020 13:31:10 +0200 Date: Fri, 14 Aug 2020 13:31:07 +0200 Message-Id: <87h7t5a2h0.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19032 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 19032 fixed close 19032 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 19032 fixed close 19032 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 08:34:21 2020 Received: (at 19032) by debbugs.gnu.org; 14 Aug 2020 12:34:21 +0000 Received: from localhost ([127.0.0.1]:52107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Yua-0001pf-Px for submit@debbugs.gnu.org; Fri, 14 Aug 2020 08:34:20 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6YuW-0001pN-Fr for 19032@debbugs.gnu.org; Fri, 14 Aug 2020 08:34:19 -0400 Received: by mail-lj1-f196.google.com with SMTP id t23so9767016ljc.3 for <19032@debbugs.gnu.org>; Fri, 14 Aug 2020 05:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iola-dk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oFp4BpwZju8saXDLtT42i3Qivm3f0IXqjboxCZUBi48=; b=qVOojnUCDeIbexE89vnzxXVrEMysqrcuyWbgx5mFfi3XFADgkdoYB28gC3ANAMZQqF Dp2Ef7nldxssvwRieX+962TQhgSOROyDSNOZBzVVDWog0aFlhvQ2xw+kUje+to2rTygE tDv/jw78ug5E/70Lts3oUnR8EMxVB4y68mtRNRlC/MOsbiANN/Gx0TKUljlA3qUDE7+9 b3CD9rgVjBFEgHHGe+DQyl8Z+6hZKf2xtiAdFOawHZiMasw/d9G2am5odJfl1OUMaKcx d+CmzN/yaGEt3H6LoUvYrcQTjYVlfCFXDeTLdb+qRR+2aV/q48qiFW6IeU7ZIuWLQCLF OJ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oFp4BpwZju8saXDLtT42i3Qivm3f0IXqjboxCZUBi48=; b=kgOwztzxpgrl1MoObZZXT1zcHx1UASs4jzDTHRjBmZZgqUC92FxtqBgURyJ8PjFhG7 wkCEclUZxh5nZNMC4ZFAsMcuKsSYY5PB8wjfZoeKkjAfobzVdNl4CC/A29J4KBCSovII a3qPmPO7sr4Zd5d9XKlVAQoxwfP1Ubi+t6xyadhKQHfuSiSb+kIrBH5UjRao0+rlu0Kp 4n9ww5NsRlI/ME/YPQX12zVpMfQGL2OlfVmanxBRpanTAyiOq6YmIFYbNPDskpQgwevB Y0l2XN3FuDczwa4us8IRjW2PAQWgMXClsjD+kOR/pR/R3oS1uw4gms0WP7pY/06T+rM9 iorw== X-Gm-Message-State: AOAM5320+yc9u0btXn9Chc3pBBgg3T8LQwKi776VoV6985Ld+M3cBFTh d+vUSDurigS0d5+s4LsTUSMzxWUMVdm2blEjqpTLOw== X-Google-Smtp-Source: ABdhPJzNONFyNbpoM874FiM2ubx5S3nz1+oDOj3YcrJOa+FuxNhwu9KqORppOtN8ZB0zXWAANSf1B40ao+fPY8im7L4= X-Received: by 2002:a2e:8157:: with SMTP id t23mr1246809ljg.417.1597408450390; Fri, 14 Aug 2020 05:34:10 -0700 (PDT) MIME-Version: 1.0 References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> <87mu2xa3rh.fsf@gnus.org> <87imdla2hd.fsf@gnus.org> In-Reply-To: <87imdla2hd.fsf@gnus.org> From: Ole Laursen Date: Fri, 14 Aug 2020 14:33:59 +0200 Message-ID: Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Matthew Leach , Stefan Monnier , 19032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I just built from trunk, and it now works! Flawless victory. :) Thanks again to all involved! Ole Den fre. 14. aug. 2020 kl. 13.31 skrev Lars Ingebrigtsen : > > Lars Ingebrigtsen writes: > > > Yeah, that makes sense. I'll take a stab at implementing it that way. > > I think I found where in the icomplete machinery to set this variable, > so I've now pushed this change. It would be nice if others could test > this, too, and see whether it works. :-) > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 08:35:40 2020 Received: (at 19032) by debbugs.gnu.org; 14 Aug 2020 12:35:40 +0000 Received: from localhost ([127.0.0.1]:52133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Yvr-0001tW-UO for submit@debbugs.gnu.org; Fri, 14 Aug 2020 08:35:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Yvp-0001tH-3T for 19032@debbugs.gnu.org; Fri, 14 Aug 2020 08:35:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0zJtr2yW9y2T7Mepq5aB6PNZtrxDTZkL/bdYoQ8RH7A=; b=WHOMytd0az41H3HPweEiZbhi57 5ELMRi4cQhinARZt+rp+kW+VImij2ujUYXP8UaHydJCYqPZSXfoFry4xEAmE6gAb+PSr6wKrZvqc1 RG6p9Z5JC0KDaxc0f00W2RU2ayc5ppjeNFHZjbtcgcpacYHdog7qSONgQ/eI7EbwCC7Y=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Yvf-0001qf-SN; Fri, 14 Aug 2020 14:35:30 +0200 From: Lars Ingebrigtsen To: Ole Laursen Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> <87mu2xa3rh.fsf@gnus.org> <87imdla2hd.fsf@gnus.org> Date: Fri, 14 Aug 2020 14:35:26 +0200 In-Reply-To: (Ole Laursen's message of "Fri, 14 Aug 2020 14:33:59 +0200") Message-ID: <87lfih8kxd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ole Laursen writes: > I just built from trunk, and it now works! Flawless victory. :) Thanks for testing. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Matthew Leach , Stefan Monnier , 19032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ole Laursen writes: > I just built from trunk, and it now works! Flawless victory. :) Thanks for testing. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 14:00:56 2020 Received: (at 19032) by debbugs.gnu.org; 18 Aug 2020 18:00:56 +0000 Received: from localhost ([127.0.0.1]:36896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k85up-0004wj-Tt for submit@debbugs.gnu.org; Tue, 18 Aug 2020 14:00:56 -0400 Received: from mx0.mattleach.net ([176.58.118.143]:38856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k85uo-0004uw-Cd for 19032@debbugs.gnu.org; Tue, 18 Aug 2020 14:00:55 -0400 Received: by mx0.mattleach.net (Postfix, from userid 99) id 87FF561AF9; Tue, 18 Aug 2020 19:00:53 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham autolearn_force=no version=3.4.4 Received: from prax.mattleach.net (unknown [109.249.184.197]) by mx0.mattleach.net (Postfix) with ESMTPSA id E825161AD4; Tue, 18 Aug 2020 19:00:52 +0100 (BST) References: <8761egqcyr.fsf@matt-desktop.home> <874kp6hotd.fsf@gnus.org> <87mu2xa3rh.fsf@gnus.org> <87imdla2hd.fsf@gnus.org> User-agent: mu4e 1.4.10; emacs 26.3 From: Matthew Leach To: Lars Ingebrigtsen Subject: Re: bug#19032: 24.4; icomplete cannot select matches with C-x b with no input In-reply-to: <87imdla2hd.fsf@gnus.org> Date: Tue, 18 Aug 2020 19:00:51 +0100 Message-ID: <87tuwzkf58.fsf@mattleach.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Ole Laursen , Stefan Monnier , 19032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> Yeah, that makes sense. I'll take a stab at implementing it >> that way. > > I think I found where in the icomplete machinery to set this > variable, > so I've now pushed this change. It would be nice if others > could test > this, too, and see whether it works. :-) Thanks for fixing this Lars. Much appreciated! -- Matt From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 14:27:02 2020 Received: (at 19032) by debbugs.gnu.org; 6 Sep 2020 18:27:02 +0000 Received: from localhost ([127.0.0.1]:47144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEzNV-0005Cr-Qj for submit@debbugs.gnu.org; Sun, 06 Sep 2020 14:27:02 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:38095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEzNU-0005CY-9k; Sun, 06 Sep 2020 14:27:00 -0400 Received: by mail-wr1-f41.google.com with SMTP id g4so12778903wrs.5; Sun, 06 Sep 2020 11:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=r+mR28t0SILD0wD+2BPqgIhAzAmRzpvV9cLqZalhMj8=; b=bA0z6avjrIjnPNI9rYGYf2cCdtkI5pvZGzqdAGapVzIlPfltH0DoqCPO/0uxreN6hK XNJqhOHmvVt5nISEBzqB7Jwy7dk54YBSBFRPkARJmTL5KpdDfHK+SeclYhGmhzW7XWl1 9KVViX7RwPQ032JGUfrd7xLw5ukjTf89ktml1SiKDiCoEhmJ6UgdGP4x2296eordIIJ6 LZRr6KPDsIJ3pwv0j+Vu5RtRHzqhoz7uzFQchFKdq9QLSv2V7Eo+S3kUk/BcDEBXqDsh sCJH6SGamgXrgkr0ZkZ+Lvee8WEIJNPa4MoCVOu7Oe8r2Yhoq+X44MiwDexCZ9lic7MS s/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=r+mR28t0SILD0wD+2BPqgIhAzAmRzpvV9cLqZalhMj8=; b=g49KcZLr4XnCQHUGx1puxWueUMvVbWMDruM6hPxbNaN+hYtMPI2tkDK+xa/FzVNOMb ZjRdxwV/znq1pM+/jZBnpJshx1otghjGW4ZucHuxwdNAYp/FzSnXJzS0dK7nXFulGaP0 /SSTErH92iaCMDFODiDie51dc3+6zM+v3amC9s4EWvycw2P3uLdw+eWpPFBCZ56y95u5 WXhaXlPpw2ItDw3c2fMLq7vWsCZoZUx4TO5009+LKvMFOgIp9VXKBoKg1Xw4l/fdcEzo ojI8YOXWfIkspgAXbxHEKKTwGt4LdL5YjTFesVmjk5xHSoFVAHm7gf2ulNLaZ5vFagaQ UySA== X-Gm-Message-State: AOAM533DioKRa3Lfc9Aao9mcBR8Dcm6UQtBHPdYjkPkw+gEoty4HZ9EG jkQRlFXzNDVILDnM9CMnHEe1/CLSoDM= X-Google-Smtp-Source: ABdhPJwCspVhfctmQVKNFAvZN5Cp/Ib6qYmVdBlVClTC31VOiECmGrfwj0yaVBFtOGnT0uq9EWJMZg== X-Received: by 2002:adf:f903:: with SMTP id b3mr18471983wrr.142.1599416814135; Sun, 06 Sep 2020 11:26:54 -0700 (PDT) Received: from krug (93.102.201.41.rev.optimus.pt. [93.102.201.41]) by smtp.gmail.com with ESMTPSA id w15sm24038800wro.46.2020.09.06.11.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2020 11:26:53 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> Date: Sun, 06 Sep 2020 19:26:47 +0100 In-Reply-To: <87363w2ajd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 05 Sep 2020 23:12:06 +0200") Message-ID: <87tuwaoj6g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Sean Whitton writes: > >> On Sat 05 Sep 2020 at 02:25PM +02, Lars Ingebrigtsen wrote: >> >>> In which case -- does the following fix this problem? >> >> It does indeed. Hope this patch can be applied. > > Thanks for testing; I've now applied the patch. I've had a look at the original problem that triggered this, and I wonder if this much simpler patch wouldn't be preferable. For one, it doesn't touch the minibuffer.el machinery (which is complicated as it is) or has any kind of complicated caching semantics. It just binds a different command to RET in icomplete-minibuffer-map, presumably solving 19032 (in my limited testing). It's also guaranteed not to affect fido-mode. I think something like this is the way to go for a behaviour change such as this. Jo=C3=A3o --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Change-icomplete-show-matches-on-no-input-behaviour-.patch >From f4dc81e0c7be75ace3766ca16e2be8bdcc8f0627 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Sun, 6 Sep 2020 19:03:52 +0100 Subject: [PATCH] Change icomplete-show-matches-on-no-input behaviour for Icomplete only Fixes: bug#19032, bug#43120 Previous fixes to bug#19032 introduced bugs in Fido mode. This fix relies on a new command bound to RET. * etc/NEWS (Miscellaneous): Mention icomplete-show-matches-on-no-input. * lisp/icomplete.el (icomplete-show-matches-on-no-input): Add comment. (icomplete-minibuffer-map): Bind icomplete-ret. (icomplete-ret): New command. --- etc/NEWS | 6 ++++++ lisp/icomplete.el | 16 +++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 749b28ac3f..d40a4807ec 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -938,6 +938,12 @@ window after starting). This variable defaults to nil. ** Miscellaneous +--- +*** 'icomplete-show-matches-on-no-input' behavior change +Previously, choosing a different completion with commands like 'C-.' +and then hitting enter would choose the default completion. Doing +this will now choose the completion under point. + +++ *** The user can now customize how "default" values are prompted for. The new utility function 'format-prompt' has been added which uses the diff --git a/lisp/icomplete.el b/lisp/icomplete.el index f76ab28fb8..c4d5012af9 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -75,7 +75,11 @@ icomplete-tidy-shadowed-file-names selection process starts again from the user's $HOME.") (defcustom icomplete-show-matches-on-no-input nil - "When non-nil, show completions when first prompting for input." + "When non-nil, show completions when first prompting for input. +This also means that if you traverse the list of completions with +commands like `C-.' and just hit RET without typing any +characters, the match under point will be chosen instead of the +default." :type 'boolean :version "24.4") @@ -153,12 +157,22 @@ icomplete-post-command-hook (defvar icomplete-minibuffer-map (let ((map (make-sparse-keymap))) (define-key map [?\M-\t] 'icomplete-force-complete) + (define-key map (kbd "RET") 'icomplete-ret) (define-key map [?\C-j] 'icomplete-force-complete-and-exit) (define-key map [?\C-.] 'icomplete-forward-completions) (define-key map [?\C-,] 'icomplete-backward-completions) map) "Keymap used by `icomplete-mode' in the minibuffer.") +(defun icomplete-ret () + "Exit minibuffer for icomplete." + (interactive) + (if (and icomplete-show-matches-on-no-input + (car completion-all-sorted-completions) + (eql (icomplete--field-end) (icomplete--field-beg))) + (icomplete-force-complete-and-exit) + (exit-minibuffer))) + (defun icomplete-force-complete-and-exit () "Complete the minibuffer with the longest possible match and exit. Use the first of the matches if there are any displayed, and use -- 2.25.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 06:30:25 2020 Received: (at 19032) by debbugs.gnu.org; 7 Sep 2020 10:30:25 +0000 Received: from localhost ([127.0.0.1]:48185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEPo-0008Rm-SL for submit@debbugs.gnu.org; Mon, 07 Sep 2020 06:30:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEPm-0008Jb-ED; Mon, 07 Sep 2020 06:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6FZFhH5n9tyPjo0DIjFSj+NNJQ0jNUR/5DgCeFsd14o=; b=VmCCs9gm+cAkRsKCE+HK44Kkcg XaHL4wKEjOVB/c1qKuZKcSsRRAkV7UasQUBHdxgr57oDjOaU6cbrdFeHXsCd4vY7IhrGsR2I2ilpR kXjHmlgMjryL8O8/cnN68Ze3yNly8HOjZtCSwpMGja31FQ7qZlm+u2EN0EtCNgcf2tt0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFEPd-00064j-Ax; Mon, 07 Sep 2020 12:30:15 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUrR6MsTq9ec7px h8ZcdsFLZ7qps9SZptCKmMpxgb21vto5X8L////C3AL4AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QJ BwoLHCukqa4AAAEuSURBVDjLrZPBSsNAEIZn32DGstBraFXwJpuaXotVvNa6UuhJqd3gsTQ29CYF iWfBV+jZQ9/PTdoEG2YKBYdAlv34d+b/swEFhLAtpD8FSuVAKVS0V5BvACIS1gEo8iLMn5qidsa2 8BCg/wHkLUgAkAc+EgHQ0QAFgJIi96F4wIdVAFbhx2LbeIMogaPHLb0j7TXz6QoKKZNCwPooNkFQ MIXFNy8ubx3sXopYwGdI3FwgKwSA8i0hCYixHziK/6cATxrtsG8D3Rk+9MJhu1c5vz1LM9d6akbP 7tssriZVj7d49vWZTZrnL/FFN47mFQg696dk7uxs1Ho316GtmqdBdJn1b5I0bKyM6RqzA3qRTMO1 c0m8fnTL1+X0o1RoGpDVm8HYamtXc7vhI/kpF7+VDmRfLEfkkgAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wN1QxMDoxMToyOCswMDowMO2vH8gAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDdUMTA6MTE6MjgrMDA6MDCc8qd0AAAAAElFTkSuQmCC X-Now-Playing: Artful Dodger's _It's All About the Stragglers_: "What You Gonna Do? feat. Craig David" Date: Mon, 07 Sep 2020 12:30:12 +0200 In-Reply-To: <87tuwaoj6g.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 06 Sep 2020 19:26:47 +0100") Message-ID: <87a6y1angr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > I've had a look at the original problem that triggered this, and I > wonder if this much simpler patch wouldn't be preferable. For one, it > doesn't touch the minibuffer.el machinery (which is compl [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I've had a look at the original problem that triggered this, and I > wonder if this much simpler patch wouldn't be preferable. For one, it > doesn't touch the minibuffer.el machinery (which is complicated as it > is) or has any kind of complicated caching semantics. It just binds a > different command to RET in icomplete-minibuffer-map, presumably solving > 19032 (in my limited testing). It's also guaranteed not to affect > fido-mode. That does look like a much simpler and less invasive way to implement this; yes. (And you'd presumably remove the stuff that was added for 19032 already?) But I was wondering whether there were any other use cases where the newly added stuff would be useful... but perhaps not? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 06:37:34 2020 Received: (at 19032) by debbugs.gnu.org; 7 Sep 2020 10:37:34 +0000 Received: from localhost ([127.0.0.1]:48211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEWV-0001yc-K1 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 06:37:34 -0400 Received: from mail-il1-f182.google.com ([209.85.166.182]:45411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEWU-0001yN-8c for 19032@debbugs.gnu.org; Mon, 07 Sep 2020 06:37:18 -0400 Received: by mail-il1-f182.google.com with SMTP id q6so12055742ild.12 for <19032@debbugs.gnu.org>; Mon, 07 Sep 2020 03:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=klMxwduq9uaEpaKRLbtsNdfCU0Os24IA/qQZiYf/ehQ=; b=mD8FdLd6BWNgzmTi7kFp2qYjzq36tkKkHsw5kH1oAtTul4+2ZRfJY6fZQJ19q0iLtO 2+Oqh10CoCpwGeWM4fhGS5LNOfZGfUarocvNnK48p/nq6XO919JQF0QIUpGYOlEEaYgJ FP27m2PITBbOYzgJ1N3YT9IgKg7p3shp9fZnkw4KbtGZ8nSSZrIQeZhdjeDkENzHo4Y/ 0cctoevmHpbcrMXL4xKUd2kPflHeDR6JT5bis4UG0UC/gWf9D2nfskN8cMTyjHtb3mRr 4tk0HUKW5Z4UR8QjVzaWs/XQQxTrKDzRpqlUqwFVs9brArq1x5fbtLr57hBcOZtBqT0M EYQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=klMxwduq9uaEpaKRLbtsNdfCU0Os24IA/qQZiYf/ehQ=; b=fHs//R7BMYXPCMIyuZBjODQADMZUxgDR7tLtBGuvJDtNMivMmbbGeWEGSLq7XR9p/k /YqM6zOBvSKbyIjmhmOacCpw2L0IR0adHVVuR041Y035Bn1JJV2/XoopUAvSac2U2bcW +2HbMg9DNPCsCMzDKWpzpZwp59W2QLDg7scoFUgdVzkU66pj10BnevCEHMj37r7VGkD8 c1x0CepknkJr/b9Z9D+X9DNXHBSPn9kdjXIa1fajnY0EfFP509RreJLZTQGFcXwc4XrT +WChCrlIFPloC0inuq0/as8i1FT/5GPMt8yi680DSHyD75C/LWz/RXS1paCtYBN6+qUL 1AjQ== X-Gm-Message-State: AOAM533nQV+n8TRzNigmF1Hanj718euETffVLCgaSj2DuUJ4WKCW2vZ3 TxJPubfwhSf9M5Lwxo6FSs1wehDw8A1/K1Ku2XA= X-Google-Smtp-Source: ABdhPJxbN1n8Tw1jzFU/nCOpi60j1sBh7Qutp5A1rSHkV0PpPEnuuszjWWU3mRY/aHjxLR4anvqyns9x010cGOG9wfM= X-Received: by 2002:a05:6e02:c61:: with SMTP id f1mr18844343ilj.137.1599475032714; Mon, 07 Sep 2020 03:37:12 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <87a6y1angr.fsf@gnus.org> In-Reply-To: <87a6y1angr.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 7 Sep 2020 11:37:01 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Lars Ingebrigtsen , Stefan Monnier Content-Type: multipart/alternative; boundary="00000000000026f34905aeb6cda3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000026f34905aeb6cda3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 7, 2020 at 11:30 AM Lars Ingebrigtsen wrote: > That does look like a much simpler and less invasive way to implement > this; yes. (And you'd presumably remove the stuff that was added for > 19032 already?) Yes, I'd revert both the original patch and the fixup. > But I was wondering whether there were any other use cases where the > newly added stuff would be useful... but perhaps not? This is for Stefan to say: he's the "owner" of minibuffer.el. Sorry Stefan if you're not, I just nominated you. Anyway, I kind of screech at any added complexity there, hence this simple suggestion. Anyway, I'd risk committing my patch to master while we evaluate this. Or maybe let's hear from Stefan first. Jo=C3=A3o [Also I'm moving this to 19032's thread exclusively, since 43120 is fixed] --00000000000026f34905aeb6cda3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Sep 7, 2020 at 11:30 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Tha= t does look like a much simpler and less invasive way to implement
> = this; yes. =C2=A0(And you'd presumably remove the stuff that was added = for
> 19032 already?)

Yes, I'd revert both the original pa= tch and the fixup.
=C2=A0
> But I was wondering whether there were= any other use cases where the
> newly added stuff would be useful...= =C2=A0but perhaps not?

This is for Stefan to say: he's the= "owner" of minibuffer.el.=C2=A0 Sorry Stefan if
you= 9;re not, I just nominated you.=C2=A0 Anyway, I kind of screech at any
=
added complexity there, hence this simple suggestion.
=
Anyway, I'd risk committing my patch to master while we = evaluate
this. Or maybe let's hear from Stefan first.

Jo=C3=A3o

[Also I'm movi= ng this to 19032's thread exclusively, since 43120 is fixed]
<= /div> --00000000000026f34905aeb6cda3-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 07:43:50 2020 Received: (at 19032) by debbugs.gnu.org; 7 Sep 2020 11:43:50 +0000 Received: from localhost ([127.0.0.1]:48281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFFYs-0005mJ-Ck for submit@debbugs.gnu.org; Mon, 07 Sep 2020 07:43:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFFYq-0005m4-T9 for 19032@debbugs.gnu.org; Mon, 07 Sep 2020 07:43:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1o8EUJ1+v1ztqzrfJQkHkr4ECbEx9qyT7SDayOsTC2Y=; b=RGeFVGhrzalBab21z0buI1K/Bf KDNCUs/2dhXv7ANek6Y4iwKh7fxRYfeJ0ku6lWK+ueWdPhLQgFLeMtD040VoW1uCxcEg8hAlK7vxg 5zBG7hBrvJV+XaF01Km8+8tS6G2EjfUYw4Pbr7JjijjVOzhwXyV323MZcILLId5E30gc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFFYe-0006sS-3p; Mon, 07 Sep 2020 13:43:41 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <87a6y1angr.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWjo53KysLJsqCq jnJ9gXyUaVRHPDz///8byIXzAAAAAWJLR0QHFmGI6wAAAAlwSFlzAAAuIwAALiMBeKU/dgAAAAd0 SU1FB+QJBwsrElhayjwAAAGUSURBVDjLddO9csMgDABgGZLOxpcHALnNnNi1Zw+5zGk5Mvd6Ne// CBUigJ0fDcnFnyVBBAApKtUIoTAFlFAKC+SnQi9Ag16DzlBCIIO5rw/0mlEQAe6hgVhqWYlK6SoB /TwATLm5qAv0MkEIAvwUXMlZOBWgpNH/BpBroILe/4VvOScQIi7S+9lqkCUDY+kNgTuA7N0Ap2kN 3l1oTYPLIBJ4gr6fbyAgZ/gfSSBuALF5LEUwnNbLDc1nSwmjzzsX/Nk66kHgPWVseNcR8Di6y9YO DJyj4wbR7Ofv88wwTaU5jaX2X9COAXhZ+jY37MwglHrLkAbaGaTDos4L4HluOsVxvYfdMYJ/gAob et5E4DUhj3ZnsDHK7BimBdSmQeq+zxAr1armA6eXEO4Bg0Yt3hhypYq6GvXRaTwnCK+F+xH2JjuB 1wxhflSJoLb4fvArUCHFtLZrewb+C4kioLR9NyyAWtRVAE2DdQzx0MZrSwAEQwYoIJ9A7OFeZLSv YOvsa+ifweDcc3COUp6AdiEeoXEZ/gF+xYR/kLX3KgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0w OS0wN1QxMTo0MzoxOCswMDowMMsUvdEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDktMDdUMTE6 NDM6MTgrMDA6MDC6SQVtAAAAAElFTkSuQmCC X-Now-Playing: Joanne Robertson & Dean Blunt's _Wahalla_: "X" Date: Mon, 07 Sep 2020 13:43:34 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 7 Sep 2020 11:37:01 +0100") Message-ID: <875z8pak2h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > Anyway, I'd risk committing my patch to master while we evaluate > this. Or maybe let's hear from Stefan first. Let's wait for Stefan to chime in. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Stefan Monnier , 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Anyway, I'd risk committing my patch to master while we evaluate > this. Or maybe let's hear from Stefan first. Let's wait for Stefan to chime in. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 07 13:30:56 2020 Received: (at 19032) by debbugs.gnu.org; 7 Sep 2020 17:30:56 +0000 Received: from localhost ([127.0.0.1]:50715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKyl-0000Wc-PW for submit@debbugs.gnu.org; Mon, 07 Sep 2020 13:30:55 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKyj-0000WJ-C5; Mon, 07 Sep 2020 13:30:53 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CDDD210022E; Mon, 7 Sep 2020 13:30:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5200710006F; Mon, 7 Sep 2020 13:30:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599499839; bh=FAF2x4vbsjloyiYKqnPHY+AfJzXXQzSWjMzpit/jx0E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SbY9crUsI9juTmPWJsAf3/hA4zZfAnNDVSVMglmccLz5UR0wQekTpjbR6PTFJvg// zKeInHzi2+E47zW54yUNHuIqEioFxFK3laJ3/lXDOhauPcsv/SJ1yQ5hbVnQpqzxci 9YKqWy2ni0c31FcC2z0SVsllHSudJZ0pcTjTVTcngjD6/ODs5W+0OK5jbRV+LFKV33 QlaloFIuFfBw6s/Lao/RFxDmc/+tcIicYwZmFs1eP7lHFOAY79IDcQ37RYiwZaTB5+ sA3GxVxeSVqEN9Fm+mxtcFxVpP1YrS1LiJqmcj7mrQ0gvxmDtXQUjsj9A4z9KAoXr1 q1vh4VBjZbT3w== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EB75512081D; Mon, 7 Sep 2020 13:30:38 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Date: Mon, 07 Sep 2020 13:30:38 -0400 In-Reply-To: <87tuwaoj6g.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sun, 06 Sep 2020 19:26:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think something like this is the way to go for a behaviour change such > as this. Looks fine to me. > + (define-key map (kbd "RET") 'icomplete-ret) Maybe use a `remap`ping instead? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 02:52:33 2020 Received: (at 19032) by debbugs.gnu.org; 8 Sep 2020 06:52:33 +0000 Received: from localhost ([127.0.0.1]:51716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFXUX-0008Bf-2g for submit@debbugs.gnu.org; Tue, 08 Sep 2020 02:52:33 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFXUV-0008BP-Bb; Tue, 08 Sep 2020 02:52:31 -0400 Received: by mail-wr1-f51.google.com with SMTP id a17so17828685wrn.6; Mon, 07 Sep 2020 23:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KxAydsf2519t8+wHlNZKK3SJymJpM8IohbSxLcbKs/4=; b=fSDMLD4AHYGikYwssxh908AWmoJpyIkTE9jNrLYB4bZkSEUd23Vvxxsb4UqYeDAELg Mb+FfSEfVp3RIpShaOgXkx7YmkIHqEw9m6dbNFxuuGLMNKUr8d9qwfmUFsQfiWQ3pHen /Y+r2I+8IMkuBZvuvSwScv9OLrki/XUFt0SHQVLNzOjqa5W/NqKRs4kKeFuagFGVx1vQ 9XOBo3ZKDQnPdHt/PTikH9KB8V5VCBWO8IaPaEqKjep5kt2l6iBpD82izoIM2bKLcS8h 8V1847/rShfZnQmVVhVguxbXTTkyYL+QfWZTmF9DjIqErZZ7wIOl9a1p04/qoE9Lix7n 7i5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KxAydsf2519t8+wHlNZKK3SJymJpM8IohbSxLcbKs/4=; b=a9lwi28niWC0KcyS7TvW73ILPtDmFlOkdR1FaJLtFtfilOu+uKvwXsUJV975/02vlA lxy4HLRBMnDinW2bkmk1cDjMODDjxYl3dNQhX5/HLuTy78VF/myYz/rHEhtRVQ+1EVrq KuNMXfyU/UtMpo12pcom5cf/ePlEPZUGod8Lyp2rwZ/9a53R8Dpp8MJyQoVXxStfrx6t rE8DUnm7Qjua0GZzWqs2EU5LTv8O2dA8S4A+JNf3XMjr+TaZwvOGFUtAoIDle+uZxYkU qTKBQ8jdlOazO9IvjICasBiaxuP5xFrkW8hSrL9wdt6/rziV4vYrvt3RUYUypRtrXVnJ SIVg== X-Gm-Message-State: AOAM530BdCaOh9gw69vJ01nZ+7K/EjaOvbym7Lcss3Z71SBvA8SQoeSX 1KRF/tI2qkN3CMZwVcLDYZc= X-Google-Smtp-Source: ABdhPJzcRuxyqUqEFe6oWrxZBS90Ol2fjkPjIyexbagQwqljJMzbVWQbOslpNgyyF+Wgq36CwEin2g== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr24872366wro.362.1599547945339; Mon, 07 Sep 2020 23:52:25 -0700 (PDT) Received: from krug ([89.180.149.6]) by smtp.gmail.com with ESMTPSA id u126sm38563481wmu.9.2020.09.07.23.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:52:24 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Date: Tue, 08 Sep 2020 07:52:21 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 07 Sep 2020 13:30:38 -0400") Message-ID: <87eencwyje.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> I think something like this is the way to go for a behaviour change such >> as this. > > Looks fine to me. > >> + (define-key map (kbd "RET") 'icomplete-ret) > > Maybe use a `remap`ping instead? Yes, maybe makes sense. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 08 05:00:05 2020 Received: (at 19032) by debbugs.gnu.org; 8 Sep 2020 09:00:05 +0000 Received: from localhost ([127.0.0.1]:51903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZTx-00053o-51 for submit@debbugs.gnu.org; Tue, 08 Sep 2020 05:00:05 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZTv-00052m-SB; Tue, 08 Sep 2020 05:00:04 -0400 Received: by mail-wr1-f51.google.com with SMTP id a17so18212634wrn.6; Tue, 08 Sep 2020 02:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5NF3WaY49CTzxW8VNecAxLBUKag9T40oxui0434TBic=; b=cKXWeDOqOUf7HLBueFCNHv4XzTrvMSu5S8KIIzZp77J8cVcbQW+eh/CWURaDiNL6kJ PFhPZKYUNJqgmSaOhGiH1l4Ww2Z6KJdcsEh9GrOTaf6EQ36wvdZeXJ4GkarOW4bbOTyL gdHHFLou2geJKETWzkIEw4L4QKcPNUgUOb51WVVHh+6EYiM0T1X3o1prsu0u107PiGI3 ZkYd8Ht+BM0BZVgvBUn1w8OyqXivEg71PkCmfx7qDOTPZuk+IBtePpvmEcS+RMByRfYS yWzEBElLnt8vOTmdOZ+ltzJeETDRhzvWAZuoQNjghlVyesPgjjoY7afTRhQEeh8N7e+i hOyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5NF3WaY49CTzxW8VNecAxLBUKag9T40oxui0434TBic=; b=ZKNCAtAIRB0Ojz3iOJeJxGDYPhQubt4cE1SHMsDwO8JmF/LF788qrvlII07qaWK4AB TLM1Pq4+ufuRc3qgzpts6SNHtYfYIXH7E1bBvTmHcM1P1j3EeGVoKBdSQ74ps87iU598 fT1PfekGKpw4pSSQS2vARKDw3yLhGxd75U4IzlAC5UwO57ozE1a5viC1MqyK48gOhsFF vGpJkCeUc1g+ZrfZtq9Hrn8ScPlZgDAAmMf834fHW1YxjGajrX9jK5/bN47tJ+tUehuI lzZJjYm6BzbumOS7LE2B5jMCeHLtKpMvmwzdvUjHapLqwVBKHX+eYFmnxCEgxQskqiJR tisw== X-Gm-Message-State: AOAM5301jHBuFOvCx2F39Mz/HXjf30V2QIhAf7+OoB9pz9OelcjVzFtO d0L7VH/MTazmnq4ES8oHGMY= X-Google-Smtp-Source: ABdhPJwsKcdYejkNW+ynUcso3gneGt+Ur9WFeVO5rzii1hfJwlCQQjlhwNO8YaaH0p0td3k4URmwEw== X-Received: by 2002:adf:edd2:: with SMTP id v18mr24932732wro.242.1599555597967; Tue, 08 Sep 2020 01:59:57 -0700 (PDT) Received: from krug ([89.180.149.6]) by smtp.gmail.com with ESMTPSA id u66sm31313271wmg.44.2020.09.08.01.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 01:59:57 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Date: Tue, 08 Sep 2020 09:59:56 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 07 Sep 2020 13:30:38 -0400") Message-ID: <871rjcwsmr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> I think something like this is the way to go for a behaviour change such >> as this. > > Looks fine to me. Thanks, pushed. >> + (define-key map (kbd "RET") 'icomplete-ret) > > Maybe use a `remap`ping instead? I did that, too. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 10:01:31 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 14:01:31 +0000 Received: from localhost ([127.0.0.1]:60924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG0fD-0006O2-7B for submit@debbugs.gnu.org; Wed, 09 Sep 2020 10:01:31 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:60160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG0fA-0006Ks-Jg; Wed, 09 Sep 2020 10:01:30 -0400 Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 40DC91B44DF; Wed, 9 Sep 2020 23:01:26 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.15.2/8.15.2/Debian-20) with ESMTPS id 089E1O9q581093 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Sep 2020 23:01:26 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.15.2/8.15.2/Debian-20) with ESMTPS id 089E1OAw1235885 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Sep 2020 23:01:24 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.15.2/8.15.2/Submit) id 089E1Mlo1235884; Wed, 9 Sep 2020 23:01:22 +0900 From: OGAWA Hirofumi To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> Date: Wed, 09 Sep 2020 23:01:22 +0900 In-Reply-To: <871rjcwsmr.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Tue, 08 Sep 2020 09:59:56 +0100") Message-ID: <87y2ljcaml.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , Sean Whitton , Stefan Monnier , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) João Távora writes: > Stefan Monnier writes: > >>> I think something like this is the way to go for a behaviour change such >>> as this. >> >> Looks fine to me. > > Thanks, pushed. > >>> + (define-key map (kbd "RET") 'icomplete-ret) >> >> Maybe use a `remap`ping instead? > > I did that, too. > +(defun icomplete-ret () > + "Exit minibuffer for icomplete." > + (interactive) > + (if (and icomplete-show-matches-on-no-input > + (car completion-all-sorted-completions) > + (eql (icomplete--field-end) (icomplete--field-beg))) > + (icomplete-force-complete-and-exit) > + (exit-minibuffer))) This changed the behavior of RET from `minibuffer-complete-and-exit' to `exit-minibuffer'. Was that intention? What I noticed is the following. [before] emacs -Q M-x icomplete-mode C-xd /usr C-xk u ;; shows "Kill buffer (default usr): u(sr)" RET killed "usr" buffer [after] emacs -Q M-x icomplete-mode C-xd /usr C-xk u ;; shows "Kill buffer (default usr): u(sr)" RET No buffer named u Thanks. -- OGAWA Hirofumi From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 12:12:07 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 16:12:07 +0000 Received: from localhost ([127.0.0.1]:33055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG2ha-0006eO-Uy for submit@debbugs.gnu.org; Wed, 09 Sep 2020 12:12:07 -0400 Received: from mail-il1-f174.google.com ([209.85.166.174]:33481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG2hV-0006dh-1M; Wed, 09 Sep 2020 12:12:05 -0400 Received: by mail-il1-f174.google.com with SMTP id x2so2888113ilm.0; Wed, 09 Sep 2020 09:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/pXdUAS6lFsadA6/dGWq9L2YOOuwcEYJwvrHSUrFD6k=; b=LDbx+akDnRjI/gPCvtqGc0/q6jzBVcOdVBGX4atspF+71ES+/DP5JJBYEp3yjcdXMw QCd4acCdcLl9D6FYoFqvYjU7x/4ox9yKlRiL8hC7dF4pOT0NsXByAgaAUF1Wwf952dwA ah2o0eH9TF4a3KqW9ZboCqM7TyXw0tuK5dc42WcdZq0hU1IlSql/+A73g7Rb21XNTjdr WNdK1BxsbY3BuT1wIAtEVXXg6mo1hw69c7pa95S1KGRf6B4ywfrpTnSw8P7ZS02JahUU /HpvBI1WQTJr08eCg5cz6KSktbZW9co/NLgJwzUDtLmlUV4WYqSuKRGQ/q0wYS66a/3H MKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/pXdUAS6lFsadA6/dGWq9L2YOOuwcEYJwvrHSUrFD6k=; b=ACMv1UygU1hGVopwsuMkc6fUM9aqhqB4Zs2lDDDParLVf9shAzz3QGFgokYcPDeLGS lO+uakyZ3kfIaW5+U7PIvmmiJZduHvkX1Klrb2oLIBa1pm04AB61yPJZkMTSoclK6Qzj PnujcqIDIIi8nr84XzcjUecfFnMVt324pU36qwm8F3KdWZVcb6Ql0/UiEV/jCc36yPiK aPhB9/S1L4CfNNB0EVC8NeQ1rhSV+6Jm5oo2TtR4wrf2g6ZmLOLemSmMBn4uxccrgcBU hj594s5Lc78v/cVe4QJlh9tJlOsJZz8bjDGXGWYJbISjKDtLUYLm3DxJlFIzN41sAoUz lclQ== X-Gm-Message-State: AOAM533nKUqMPlf5jAm4KuYyL6NwiPvPSNtWDCIY2Q3YAuJT/cQgRYnw GnozUgsBBg7ZHT2S/UNiQkZARN9yP4R0KhyU6Kg= X-Google-Smtp-Source: ABdhPJzcM9OCDFZ5RyPyHudgEnl3jSp1wu7wuW0j5WQXJcteAOQLkhRHix3mH0db2W3RxZifmlzVmz3oA4GrV03WIMw= X-Received: by 2002:a92:b309:: with SMTP id p9mr2661036ilh.125.1599667915490; Wed, 09 Sep 2020 09:11:55 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> In-Reply-To: <87y2ljcaml.fsf@mail.parknet.co.jp> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 9 Sep 2020 17:11:43 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: OGAWA Hirofumi Content-Type: multipart/alternative; boundary="000000000000dc8b2605aee3b567" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , Sean Whitton , Stefan Monnier , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000dc8b2605aee3b567 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 9, 2020 at 3:01 PM OGAWA Hirofumi wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Stefan Monnier writes: > > > >>> I think something like this is the way to go for a behaviour change > such > >>> as this. > >> > >> Looks fine to me. > > > > Thanks, pushed. > > > >>> + (define-key map (kbd "RET") 'icomplete-ret) > >> > >> Maybe use a `remap`ping instead? > > > > I did that, too. > > > +(defun icomplete-ret () > > + "Exit minibuffer for icomplete." > > + (interactive) > > + (if (and icomplete-show-matches-on-no-input > > + (car completion-all-sorted-completions) > > + (eql (icomplete--field-end) (icomplete--field-beg))) > > + (icomplete-force-complete-and-exit) > > + (exit-minibuffer))) > > This changed the behavior of RET from `minibuffer-complete-and-exit' to > `exit-minibuffer'. Was that intention? > Nope, sorry. You're right. It should read minibuffer-complete-and-exit ther= e of course. Jo=C3=A3o --000000000000dc8b2605aee3b567 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 9, 2020 at 3:01 PM OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
=
Jo=C3=A3o T=C3=A1vo= ra <joaotavora= @gmail.com> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> I think something like this is the way to go for a behaviour c= hange such
>>> as this.
>>
>> Looks fine to me.
>
> Thanks, pushed.
>
>>> +=C2=A0 =C2=A0 (define-key map (kbd "RET") 'icom= plete-ret)
>>
>> Maybe use a `remap`ping instead?
>
> I did that, too.

> +(defun icomplete-ret ()
> +=C2=A0 "Exit minibuffer for icomplete."
> +=C2=A0 (interactive)
> +=C2=A0 (if (and icomplete-show-matches-on-no-input
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(car completion-all-sorted-c= ompletions)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(eql (icomplete--field-end) = (icomplete--field-beg)))
> +=C2=A0 =C2=A0 =C2=A0 (icomplete-force-complete-and-exit)
> +=C2=A0 =C2=A0 (exit-minibuffer)))

This changed the behavior of RET from `minibuffer-complete-and-exit' to=
`exit-minibuffer'. Was that intention?

=
Nope, sorry. You're right. It should read minibuffer-complet= e-and-exit there
of course.

Jo=C3=A3o
--000000000000dc8b2605aee3b567-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 13:52:20 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 17:52:20 +0000 Received: from localhost ([127.0.0.1]:34394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG4GZ-0001KG-P6 for submit@debbugs.gnu.org; Wed, 09 Sep 2020 13:52:19 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG4GY-0001Jh-An; Wed, 09 Sep 2020 13:52:18 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C191B80D35; Wed, 9 Sep 2020 13:52:12 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 01ACC80723; Wed, 9 Sep 2020 13:52:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599673931; bh=w65XQ8gE4osdOQFIfsvq1ccPQWqoqXOa9TZh8ur4eK4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eFLBW9YC7mNeysOuRhpcWfWyIkk7lI8Dz6VPIu0SwCWc03p9MEFdcHec7hnIYXcmA USvo8kZ6f7mIEd7Y7MKWBS2mjqmsBg2UzEusz8tZhYFVC33nJtxRsDbflAFm1bIWj2 3c5M7ECD31X+4EIY81qby/j8oWsE/Rx50xrybGs/XWr5MRKfYsKOXFm2tpK8vZLug+ F6U7A9uO95sdFzAYq3H6PXAjpaffJRGgv0SV9C5V2PvNnwbGBc/62mbcSxPWRXfZF5 fcj/8yl5Yjv+j8mJj9ygHeOC+x//Wf5T5mThX1FvB1YwpygR3Z+JFoGMV61LLob/34 cAbfCnUdJUn3w== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8782112079C; Wed, 9 Sep 2020 13:52:10 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Date: Wed, 09 Sep 2020 13:52:10 -0400 In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Wed, 9 Sep 2020 17:11:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Nope, sorry. You're right. It should read minibuffer-complete-and-exit there > of course. IIRC this depends on whether the completion is `require-match` or not. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:04:12 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:04:12 +0000 Received: from localhost ([127.0.0.1]:34719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5O8-0005Pl-6u for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:04:12 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5O6-0005PI-0E; Wed, 09 Sep 2020 15:04:11 -0400 X-Originating-IP: 91.129.97.241 Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C83D7E0002; Wed, 9 Sep 2020 19:03:59 +0000 (UTC) From: Juri Linkov To: OGAWA Hirofumi Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Organization: LINKOV.NET References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Date: Wed, 09 Sep 2020 21:58:03 +0300 In-Reply-To: <87y2ljcaml.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Wed, 09 Sep 2020 23:01:22 +0900") Message-ID: <87eena6b30.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , Lars Ingebrigtsen , Stefan Monnier , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> +(defun icomplete-ret () >> + "Exit minibuffer for icomplete." >> + (interactive) >> + (if (and icomplete-show-matches-on-no-input >> + (car completion-all-sorted-completions) >> + (eql (icomplete--field-end) (icomplete--field-beg))) >> + (icomplete-force-complete-and-exit) >> + (exit-minibuffer))) > > This changed the behavior of RET from `minibuffer-complete-and-exit' to > `exit-minibuffer'. Was that intention? What I noticed is the following. I confirm that this change broke icomplete-mode. Here is a test case that shows regression: M-x icomplete-mode RET M-x rgr RET Lisp error: (error "‘rgr’ is not a valid command name") Until yesterday it used to run 'rgrep'. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:13:40 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:13:40 +0000 Received: from localhost ([127.0.0.1]:34736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5XH-0005dP-RO for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:13:40 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:51762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5XF-0005d8-I6; Wed, 09 Sep 2020 15:13:38 -0400 Received: by mail-wm1-f46.google.com with SMTP id w2so3362933wmi.1; Wed, 09 Sep 2020 12:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5YGRHx5oa+q8uO7teXhj3ocKPiZYBpAmE4A/ELHfs28=; b=Ep8OAWKrYhjGKMsZ8pWcOCLaipMH5JtUWI0akPLDByHbt9hNkk4aT/Xi+3tdY+pw+h MUJ0ly0CBIUfqTYRa4bgvFlH6hxLNTM3cACAbPB+SOix+tt1+PVoc6kvyQSUzPNz9FVT xNwimD58vViQZLG9aogvjyYDINOPX8nthXGtw/BNDZCc+XDvtJNoW0dI6696XnUKfVYW tjh+O48qxcmuf9KL79U5Z1OzXvwipeUdqYGHj9bN7Zq/Ebq1o5wPrgdJmjKI8AxRCosn c4A01xEntH13WtAuoIevqDHniyAOaOBL+N6tfbJicUGzrg8k0FjGAvZ2mM1oIMD02m2G Ph5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5YGRHx5oa+q8uO7teXhj3ocKPiZYBpAmE4A/ELHfs28=; b=fNfM3IpjQUqBO4TUegJi0soD+OyfIT2P641qP7FItHrClPuMf797QNZe6yFUQuvSGc FNauAR/t2A6k90vXdL2puOUPteLxeH4FIBObqx269gCdlY2ZhkUq+cvOXnNWHmPMt0jB 4UW8REIk76LVMsNe5k3wQdQcbvlWAPo0HSLRurH63MKshtoIvsmWHCKgILRNiepLnPHk UIE5BO3kTuZwBTCYQYo1CBar3zjNM6qL+77NeD7oDtVn71Hz1lmCN+61acNIrhKGW0MQ LFNaOKcLIzhWQRUZ5BVeq1rhFjzW6+cdepS2/Xr8H4sGovjkZSFnIJucr6Ff2FZYejEO qH9A== X-Gm-Message-State: AOAM530HkZYoKfXUEMZfX7EOKdly0nGi5qGrDlNi3N/mCL0eAaOsYo8o AzN4KMZRR/COi+sgAeQQN5c= X-Google-Smtp-Source: ABdhPJzV0OInTkMG04X3zmwXFuDkMDsAFkdM6+bi+YvKj20IJC+PKAAndvrtro5UiYuXoxPINQUwHA== X-Received: by 2002:a1c:5a56:: with SMTP id o83mr5106611wmb.77.1599678811664; Wed, 09 Sep 2020 12:13:31 -0700 (PDT) Received: from krug ([89.180.151.22]) by smtp.gmail.com with ESMTPSA id m3sm80384wme.31.2020.09.09.12.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 12:13:31 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Date: Wed, 09 Sep 2020 20:13:28 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Sep 2020 13:52:10 -0400") Message-ID: <87k0x2vk4n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Nope, sorry. You're right. It should read minibuffer-complete-and-exit t= here >> of course. > > IIRC this depends on whether the completion is `require-match` or not. If so, shouldn't minibuffer-complete-and-exit take care of that? I mean, I've remapped the binding to _that_ command, so unless it's making some "(interactive)" magic, which it is not, calling it from lisp in the normal case as it should be completely equivalent. I've gone ahead and commited the fix, as it fixes Hirofumi's problem, as he described it. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:52:51 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:52:51 +0000 Received: from localhost ([127.0.0.1]:34807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG69D-0006ar-5V for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:52:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG69A-0006aa-Kv; Wed, 09 Sep 2020 15:52:49 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B831D100234; Wed, 9 Sep 2020 15:52:42 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 12C6310006F; Wed, 9 Sep 2020 15:52:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599681161; bh=0PdfYnOFoeqAlXCnyCYrAanmqJYiJabtWUu415PX54g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eSrhKiRojd+6sMQ5h10bUC3NN1iPzqgabWl/ZimFIluWJd3h+i+dnzJ0X2BQc+25H ShCN8ZY8d3eimHftmNmwiAWv9DhJRuFBY+f49XUsj60/jPGOMXXszFV5XC3meUqfkE L3wupzKzfaYqTr9AjTV4+UnrZnsfhiEKiwEUVXsjat3E+OwXE+gI62+tCFghTRDscu VPfTknFqPe1mhgPXj2yGHYYRf5cod9lPehSpYh9f5cl5zsjH+i5fWVmhx3iEgmuliP lX/jINs0340dSJR/3TyAneoT4n6jsnugUpDiBiLoEdTGTNRpUpzpWoL8uBs0hG6+0A 3Rf0VeIofI1mA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 91678120319; Wed, 9 Sep 2020 15:52:40 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> Date: Wed, 09 Sep 2020 15:52:38 -0400 In-Reply-To: <87k0x2vk4n.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Wed, 09 Sep 2020 20:13:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> Nope, sorry. You're right. It should read minibuffer-complete-and-exit there >>> of course. >> IIRC this depends on whether the completion is `require-match` or not. > If so, shouldn't minibuffer-complete-and-exit take care of that? Yes and no: IIRC depending on `require-match`, RET is bound either to `minibuffer-complete-and-exit` or to `exit-minibuffer`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:55:00 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:55:00 +0000 Received: from localhost ([127.0.0.1]:34818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6BI-0006ed-0Y for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:55:00 -0400 Received: from mail-io1-f43.google.com ([209.85.166.43]:34075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6BF-0006eJ-Uy; Wed, 09 Sep 2020 15:54:58 -0400 Received: by mail-io1-f43.google.com with SMTP id m17so4563917ioo.1; Wed, 09 Sep 2020 12:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dn10GNF/GclEs36hao6BRVOgdWpZyL2Kio1Ixchhe6M=; b=es6SYQsN0KGen1MWUZcfxc2UCbU0MwGFR0iozEqn86nL+lgHDPWixgSj6lUpBtTCjA kaHkkHFH4DB14aLlz+dAyVXH71qVVpdltK2I/NgK3pNnhXiIlhBulMO05EBdKWtQugxu a29sPahWEUKpziJLcPOPvO+ByYp9T1OTylk+7JzKtyYfu01JU3/P1r7cUqIQ6P7Ztb9k Gg2uImJ5vXJ4CvhFr7G4YhSRpD3kbHL39riOevjrqJOsHJQncQfg/BM7nlA6V8MHK4eP Z+WI4aqMnLyPP8fXtyolgPJPXKEF5ZcIw2bEHMa3XxWCDYli135E91biSj5tIpYUtzN1 Ha/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dn10GNF/GclEs36hao6BRVOgdWpZyL2Kio1Ixchhe6M=; b=kvUv8CgX1/5dtE+63w0r6yXlD6OHX07Y6QV4z7sjaAN3KdOGfou64gTWhx/4dPVq2t mCck6jRjqrNGUIW/THQGGjYocBn9f6vfcxzzf5BYEIylMlaPfOKaZqgQYJJ37RfNPbds OaV/pTMOf5rC7eEbr51vblL0rea4syvj3obSyKH1kDASh244/y4e58SsE8S9QO5bb8qj SFVNgIJxHkxsrON6GpnJWkh4rCnWm9JV7Z+PbOOOjsTkEluFgLAYLI+QLRzGdpyeQ8qE mqP2uTgYNFPdzjaXan/R6rkBb76d/iko5ON89cXmRMqa0lMPi+u4kPAhsG2hiFwQ8vB4 qtQg== X-Gm-Message-State: AOAM53328mVY4hO4qKwIwr0KCymCkUGLJJWEyfRZ1qL9erJvuvg/yxok 1MChPT40BqX9tBvZg1hkmyx7NL8bZF+ImE3Apfw= X-Google-Smtp-Source: ABdhPJwJZNGjpv23wKFj4pvW9bm8HskwyiClNjjCYxkTTUbL+bualTc8Yc6zN4XkGpr+5pCammvsuxT21R+kUHRWajg= X-Received: by 2002:a6b:7c0d:: with SMTP id m13mr4679288iok.57.1599681292180; Wed, 09 Sep 2020 12:54:52 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 9 Sep 2020 20:54:39 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Stefan Monnier Content-Type: multipart/alternative; boundary="0000000000002ca0e605aee6d359" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002ca0e605aee6d359 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 9, 2020 at 8:52 PM Stefan Monnier wrote: > >>> Nope, sorry. You're right. It should read minibuffer-complete-and-exi= t > there > >>> of course. > >> IIRC this depends on whether the completion is `require-match` or not. > > If so, shouldn't minibuffer-complete-and-exit take care of that? > > Yes and no: IIRC depending on `require-match`, RET is bound either > to `minibuffer-complete-and-exit` or to `exit-minibuffer`. Bah, so the remap you suggested wouldn't work anyway. What to do? The good 'ol :filter trick? How does it go again? Jo=C3=A3o --0000000000002ca0e605aee6d359 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 9, 2020 at 8:52 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
=
>>> Nope, sorry.= You're right. It should read minibuffer-complete-and-exit there
>>> of course.
>> IIRC this depends on whether the completion is `require-match` or = not.
> If so, shouldn't minibuffer-complete-and-exit take care of that?
Yes and no: IIRC depending on `require-match`, RET is bound either
to `minibuffer-complete-and-exit` or to `exit-minibuffer`.

Bah, so the remap you suggested wouldn't work any= way.=C2=A0 What to do?
The good 'ol :filter trick? How d= oes it go again?

Jo=C3=A3o
--0000000000002ca0e605aee6d359-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 15:58:11 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:58:11 +0000 Received: from localhost ([127.0.0.1]:34825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6EM-0006jl-On for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:58:11 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:46233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6EH-0006j9-NN; Wed, 09 Sep 2020 15:58:08 -0400 Received: by mail-io1-f47.google.com with SMTP id d18so4507389iop.13; Wed, 09 Sep 2020 12:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wHTWWe4CNWTkkwFaorYH+WOGUvP1qy3yohbZGUgh51g=; b=AfdOLXEIo4vrxFT3pGUK4JWK/DzwdzpogP85QUGY5xhfK9yx1m4ErF5Rf17lYVkMiK yWdkoFaAb7rvKxvoEOqSLvaQW5G9zLUO6MD1EEBrRO9ofWaMcHojGt70EuqdDiqT1zfR DDxJXCBg086dpgfyuldW5wmS4Is/qYxR39xl8elye5xzQ2DqVLlRS6VATxHYITR7iFdn u0/sSK+qpxUvVxvXXVSLUhLJtR6CopupiGMI2ayvg7ekx4VYlGkuHb37kWrguK0L9KS1 lPEC2wi9J08Nc4/JP3dBW7KQHwNwA/ii9xP1+UM5NpYNXctkbZMPFSyCbbIZWWZs7mpi i4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wHTWWe4CNWTkkwFaorYH+WOGUvP1qy3yohbZGUgh51g=; b=WR/9GAN863+RvhvIcggI/WfxJAXolVVaIBThds6pykLLqM+r3cMdwc6IL/hZe97r4s 0dKG0uwIjgHIbz1Js/7ripT70O5kUm9fdHiNsWoseMyGyKcOmPSW6S/OpRNBZ/V/4XvP UzMRzv+rLMovvh/HC95wHIabpCwkA73Tlmot1Wzs9v8JgDQhTbeSECEclVBbuVTMfDR0 kehz1SPXoSUv1YmSUSKODFgHAjYAxaGiHgNj14/LmecF3jOi5LlSTkdyoUWHpDVj9z4k 8vakoGs3Hgs8ODPH39bTwY/+eF8xONPYQXH1iAw67h+2RSyaPKhW7/PjtUnFiuHrayw1 Zypg== X-Gm-Message-State: AOAM530NLs+mjtQ1bHceVwsyAd6HuCWffyNoNo5qFQcQh0bXKvFFtyMC YB2JafF3mYqmpXFKpJrVlObetMlXYTQzr+qdW2g= X-Google-Smtp-Source: ABdhPJyVx86YUXb+AtYCqIYVqyefYWPutlHHudpYBTnSHOt+TMchabFyXK9+k6SxKKzlugV8L5ius7nHrW4FgCH1jR4= X-Received: by 2002:a02:cbda:: with SMTP id u26mr5538834jaq.71.1599681480168; Wed, 09 Sep 2020 12:58:00 -0700 (PDT) MIME-Version: 1.0 References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 9 Sep 2020 20:57:47 +0100 Message-ID: Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice To: Stefan Monnier Content-Type: multipart/alternative; boundary="00000000000061163505aee6de38" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000061163505aee6de38 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 9, 2020 at 8:54 PM Jo=C3=A3o T=C3=A1vora = wrote: > On Wed, Sep 9, 2020 at 8:52 PM Stefan Monnier > wrote: > >> >>> Nope, sorry. You're right. It should read >> minibuffer-complete-and-exit there >> >>> of course. >> >> IIRC this depends on whether the completion is `require-match` or not= . >> > If so, shouldn't minibuffer-complete-and-exit take care of that? >> >> Yes and no: IIRC depending on `require-match`, RET is bound either >> to `minibuffer-complete-and-exit` or to `exit-minibuffer`. > > > Bah, so the remap you suggested wouldn't work anyway. What to do? > The good 'ol :filter trick? How does it go again? > Alternatively (and a bit sillily), two remaps for two different commands: one for exit-minibuffer and one for minibuffer-complete-and-exit. Or check minibuffer-require-match which was recently added. Pick your poison. Jo=C3=A3o --00000000000061163505aee6de38 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 9, 2020 at 8:54 PM Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
On Wed, Sep 9, 2020= at 8:52 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>> Nope, sorry. You'= ;re right. It should read minibuffer-complete-and-exit there
>>> of course.
>> IIRC this depends on whether the completion is `require-match` or = not.
> If so, shouldn't minibuffer-complete-and-exit take care of that?
Yes and no: IIRC depending on `require-match`, RET is bound either
to `minibuffer-complete-and-exit` or to `exit-minibuffer`.

Bah, so the remap you suggested wouldn't work any= way.=C2=A0 What to do?
The good 'ol :filter trick? How d= oes it go again?

Alternatively = (and a bit sillily), two remaps for two different commands:
= one for exit-minibuffer and one for minibuffer-complete-and-exit.=C2=A0 Or<= /div>
check minibuffer-require-match which was recently added. Pick you= r
poison.

Jo=C3=A3o
--00000000000061163505aee6de38-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 16:36:03 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 20:36:03 +0000 Received: from localhost ([127.0.0.1]:34867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6p1-0007dM-3t for submit@debbugs.gnu.org; Wed, 09 Sep 2020 16:36:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG6oy-0007ck-SU; Wed, 09 Sep 2020 16:36:02 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0FEDA440F7F; Wed, 9 Sep 2020 16:35:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 756F5440F72; Wed, 9 Sep 2020 16:35:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599683753; bh=YgLh4Wr2GgdvBg5+TGnNOMGCtCWarRNvc2zuQx3mHp0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VKmC3VA1QC7h0TS9JtbMJjLrSATncNrOic37ll3AYA3mCwmDntPKe2yDZjdw1X5H2 IwMCwP39n5wm+KOlb2R7vG4Mnmjp8y8OBZXoq7JUtOjPDTrVPUH0TwBmJHNdqgcB0W EH4fA7GSQVVmUcp3xMnhP5cdDwCz82BG/IbWe12izPHaHVICqFZ7v+sE3i2kl+JDRC qVPKxJb8BOqYDKDRqJC3Of8wZnyZp4Z4JUaQouku/2wSeancmJ/DomyDbJ7V05nCP9 4bMf2YnWyANI6aNLkOG5Y6Qw26iFTf1qPVHyld+ZhuLyieyhkW09jVhF2CAtByA5n1 m3afoa94T5PcQ== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE0E112025D; Wed, 9 Sep 2020 16:35:52 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> Date: Wed, 09 Sep 2020 16:35:52 -0400 In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Wed, 9 Sep 2020 20:57:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Alternatively (and a bit sillily), two remaps for two different commands: > one for exit-minibuffer and one for minibuffer-complete-and-exit. I'd go with that, yes, Also, because it will handle the case where the user has added a binding to `minibuffer-complete-and-exit` to the keymap where RET is bound to `exit-minibuffer`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 18:08:56 2020 Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 22:08:56 +0000 Received: from localhost ([127.0.0.1]:35014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG8Gu-0003c3-GW for submit@debbugs.gnu.org; Wed, 09 Sep 2020 18:08:56 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:46455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG8Gs-0003bm-BK; Wed, 09 Sep 2020 18:08:55 -0400 Received: by mail-wr1-f49.google.com with SMTP id o5so4503357wrn.13; Wed, 09 Sep 2020 15:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fpep/0va5i6An5TwJ1g+b8jJ39PgYMoTZhjtBKWWL3k=; b=J56miASGivF3W55RBxKZFoaKkLhkALBoUvNjmWcPwCW04uln/7xOrkhQY5jFmjDZXu aB4UtKf1ebhNftGxsP6z4qR8SkuwmtnKcx6UHeFObyFuA7Y69LMqodDpSc3jan31ZGPx QjmnwV9Qzx+Mvox0Fy8EWvbQyfZ9rX43KHWveGOJXlrF8MV3mQMQ4rnhH5DoBkM5e6Ga YDFFVWfZrieOd3sMKRx3HfqUlIWxpuCKptKM4TMdjbcI05CFsid5k+n+leXDMYV9t9D5 Q4t1HtbHpFTC73LUObyq+1JpqClE9QfaF10WDFfFMkpQsW+VezGDXC2dSomCQpzn/unS nDGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fpep/0va5i6An5TwJ1g+b8jJ39PgYMoTZhjtBKWWL3k=; b=EQ74rneNT4rc4gwWdHqKytQEIDBp1NUZfuq2J3/ycMGteYB/VQoAvRTevkI/5SfDSw nAxJ5iBrh67DrOJGfLHgRWfazNC1haQNwZManKR5+D3PHNWEtaJE8TNA30lkIKIR2RmL DPt1fwmeB4Bl+4OPUZLWj8y0aSr2LK/NLFESN03PkXRjlsVHBVQJQqPxKhtPGJ0cufu4 jQFDc1pMiXigI++I/MvFFKY198lzZW3aEkTPD7xDqzN4f3s0Ao+tW8BldpbK1H5cOY1U XXfw8RCZYVcJ3ShYfpupjSy8pmwGk6dpJerwUpk/zAbsMMheVKhHrwkpDmZhlk44m8WX +72A== X-Gm-Message-State: AOAM5302JwioUaQkdkguOzRVPKD24poeBhhfYOPR750vCRdb0bx0f188 0e/vowLTGxr141Gpvka0sxA= X-Google-Smtp-Source: ABdhPJw4SRbMW4PJACZ3Tj5b/CVXu3fy877v15qVpyJS4SqiroD52KA4fjX8Kfy0bTJ6PiZK1WqMxw== X-Received: by 2002:a5d:4d51:: with SMTP id a17mr5932815wru.248.1599689328384; Wed, 09 Sep 2020 15:08:48 -0700 (PDT) Received: from krug (89-180-151-22.net.novis.pt. [89.180.151.22]) by smtp.gmail.com with ESMTPSA id g12sm5827917wro.89.2020.09.09.15.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 15:08:47 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> Date: Wed, 09 Sep 2020 23:08:44 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Sep 2020 16:35:52 -0400") Message-ID: <87ft7qvc0j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Alternatively (and a bit sillily), two remaps for two different commands: >> one for exit-minibuffer and one for minibuffer-complete-and-exit. > > I'd go with that, yes, > > Also, because it will handle the case where the user has added a binding > to `minibuffer-complete-and-exit` to the keymap where RET is bound to > `exit-minibuffer`. OK, how's this look? Though I'm starting to think that when require-match is nil, an icomplete user wouldn't want the new icomplete-show-matches-on-no-input behaviour anyway. But I'm not one of those. Else, if she does, doesn't it mean she wants fido-mode instead? The question is thus: remap exit-minibuffer or not? It means usually: exit with whatever has been input, which may well be the empty string. Jo=C3=A3o diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 4e546807b7..6d48aa84d4 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -157,21 +157,31 @@ icomplete-post-command-hook (defvar icomplete-minibuffer-map (let ((map (make-sparse-keymap))) (define-key map [?\M-\t] 'icomplete-force-complete) - (define-key map [remap minibuffer-complete-and-exit] 'icomplete-ret) + (define-key map [remap minibuffer-complete-and-exit] 'icomplete-comple= te-and-exit) + (define-key map [remap exit-minibuffer] 'icomplete-exit) (define-key map [?\C-j] 'icomplete-force-complete-and-exit) (define-key map [?\C-.] 'icomplete-forward-completions) (define-key map [?\C-,] 'icomplete-backward-completions) map) "Keymap used by `icomplete-mode' in the minibuffer.") =20 -(defun icomplete-ret () - "Exit minibuffer for icomplete." - (interactive) +(defun icomplete--maybe-force (fallback) + "Helper for `icomplete-complete-and-exit' and `icomplete-exit'." (if (and icomplete-show-matches-on-no-input (car completion-all-sorted-completions) (eql (icomplete--field-end) (icomplete--field-beg))) (icomplete-force-complete-and-exit) - (minibuffer-complete-and-exit))) + (funcall fallback))) + +(defun icomplete-complete-and-exit () + "Complete, then exit minibuffer for icomplete." + (interactive) + (icomplete--maybe-force #'minibuffer-complete-and-exit)) + +(defun icomplete-exit () + "Exit minibuffer for icomplete." + (interactive) + (icomplete--maybe-force #'exit-minibuffer)) =20 (defun icomplete-force-complete-and-exit () "Complete the minibuffer with the longest possible match and exit. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 00:36:56 2020 Received: (at 19032) by debbugs.gnu.org; 10 Sep 2020 04:36:56 +0000 Received: from localhost ([127.0.0.1]:35633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGEKN-0007FN-Q3 for submit@debbugs.gnu.org; Thu, 10 Sep 2020 00:36:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGEKL-0007F6-8W; Thu, 10 Sep 2020 00:36:54 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 993FD100271; Thu, 10 Sep 2020 00:36:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 82818100059; Thu, 10 Sep 2020 00:36:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599712600; bh=oBgLE25CqShwefNNrOYfhzGMywuTgGvZ7RzNYCn0794=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fn6DW3nvqbo7Iyg8zbuq58boALX07VC63P8JXfPpUqVVWHXGuE/70+KKjuS3zSBjA eNqTlB6/oyiPnA21SEZbIvXCEkSyO8RMQ37c6n5lMOwyY3OKsF78mJ60R8k1E3+4HO /hhlwqWGCD3KWAw+tNXtlZsYpUU7ndyRcSn14vVWbNtpjwW813zGB6wtHoYQc3ju6C yKxUs3vO0ophxayKHjBRevFl8p/1vtT4zgNgOXJP9+dL+dsYccsVSfQ47bCt7PKUoa 1ndMksvD2z347TMxepzJUmn8YTfr1gjwo6Kt50A7nBS7dltsZFcR5t5qqG5F/0/hss Q4u2TkotNVobA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3AC82120237; Thu, 10 Sep 2020 00:36:40 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Message-ID: References: <8736433l4c.fsf@iris.silentflame.com> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> Date: Thu, 10 Sep 2020 00:36:39 -0400 In-Reply-To: <87ft7qvc0j.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Wed, 09 Sep 2020 23:08:44 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19032 Cc: Lars Ingebrigtsen , 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The question is thus: remap exit-minibuffer or not? Good question. I think if there is a default value (i.e. if exit-minibuffer would return that non-nil default when the minibuffer is empty), then I think it makes sense to use the new icomplete-show-matches-on-no-input, but if not, indeed we probably should return "" (otherwise we're making it impossible to return ""). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 14:53:21 2020 Received: (at 19032) by debbugs.gnu.org; 10 Sep 2020 18:53:21 +0000 Received: from localhost ([127.0.0.1]:41206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRhB-0005GY-22 for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:53:21 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:60387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRh9-0005GF-1X; Thu, 10 Sep 2020 14:53:20 -0400 Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D8CF2200002; Thu, 10 Sep 2020 18:53:07 +0000 (UTC) From: Juri Linkov To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Organization: LINKOV.NET References: <8736433l4c.fsf@iris.silentflame.com> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> Date: Thu, 10 Sep 2020 21:51:34 +0300 In-Reply-To: <87ft7qvc0j.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Wed, 09 Sep 2020 23:08:44 +0100") Message-ID: <87lfhh8nyh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19032 Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, Stefan Monnier , Lars Ingebrigtsen , OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Though I'm starting to think that when require-match is nil, an > icomplete user wouldn't want the new icomplete-show-matches-on-no-input > behaviour anyway. This is confusing, I don't understand why behaviour of icomplete-show-matches-on-no-input should depend on require-match. Here are two examples that produce a different result. The first example is from hi-lock-read-face-name: (defvar hi-history nil) (icomplete-mode) (let ((icomplete-show-matches-on-no-input t) (defaults '("hi-yellow" "hi-green")) (hi-history '("hi-blue"))) (completing-read (format-prompt "Highlight using face" (car defaults)) obarray 'facep t nil 'hi-history defaults)) displays this prompt: Highlight using face (default hi-yellow): {link | menu | bold ... Typing RET returns "link" (and sometimes returns "hi-blue" from the history), but never returns the expected default value "hi-yellow". Whereas the second example from tab-bar-switch-to-tab works correctly since its arg require-match is nil: (let ((icomplete-show-matches-on-no-input t) (defaults '("yellow" "green")) (hi-history '("blue"))) (completing-read (format-prompt "Switch to tab by name" (car defaults)) defaults nil nil nil 'hi-history defaults)) displays this prompt: Switch to tab by name (default yellow): {green | yellow} Typing RET returns the default value "yellow", not the first candidate "green". This makes the behaviour of icomplete-show-matches-on-no-input unpredictable, and thus in some cases dangerous. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 15:15:36 2020 Received: (at 19032) by debbugs.gnu.org; 10 Sep 2020 19:15:36 +0000 Received: from localhost ([127.0.0.1]:41236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGS2h-0005o7-Lm for submit@debbugs.gnu.org; Thu, 10 Sep 2020 15:15:35 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGS2g-0005nq-KX; Thu, 10 Sep 2020 15:15:35 -0400 Received: by mail-wm1-f42.google.com with SMTP id l9so1483328wme.3; Thu, 10 Sep 2020 12:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=YgUdFFn8tPd8XaApra/ASmehqu8CYfqEUHLzfwob9RU=; b=pqMO9xpDjm6easyrF21iAZBUUZFqxeIJZw8ssKhRAV24Idy2tAdwB/8vprA1nzji4a 9kSCg0cEZ+Z2JAqIGfIPQwO9C4HDrya5v0yRQL/GmZik4asC++EOg0t/8XJSQCWShMmi wEUcnBbxYOPHjkL43DuHtxqpT23vJAnv3NcCv/KmKUjOAUKHUHlXCaHi5eoo/9hB7Gzr vtEaShL/Lz2Ujq75X3d/hZtG8LE0LX5nNJPu4Q7Ub/EJ//GPA0kxwX7HN+7CS7q6Rsfk FPSOw+Ug2CI/csJft3UknWNdUaZ1cXV8xy9Hz0RrItExH4jTfwQ4B5fOdOiZ0PMsgZGM qUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YgUdFFn8tPd8XaApra/ASmehqu8CYfqEUHLzfwob9RU=; b=NAq4w/H/l+B0DbYVh5ZnXlJXWr5O1lx8fI18oWOhPmXcMqV+6nxmmGnjY7Ey8khkCZ wE29HoCReh3DW4sFdmpGdIieRZWbcv3C/1goeTdo2yMcUKAUUwwjy8a2mnh1WcT7ZHwK NnK9OtfmhE+ZSBgqJ4OwKuPSuDSnkXKR8B+eaSvKDNXEhv53acOKJtfYr1STTT/QXJW3 5Ig2S2m3DMpDj5YOxZRsEXmFXp7khPDoE+jV9ekd6/Zkw90dvHYGVYpSD44m1186Z2mh Ow6JCywVY3NdUvR5qBvvd3wx1shv4uvZaFnwgrFkszOyPXxx1pOPyvt3PNHsh1kLmWVY GREg== X-Gm-Message-State: AOAM531+kzliNQcs8MAotP9R26eW4zNgRnOjDtjlMSlT3VrvA3bk0Omc U+WE4RgoUqlTgpuvdJ+Ehws= X-Google-Smtp-Source: ABdhPJx8SfkZtNB7ADatTSK++Tf895nunkKosR+RnhOs5G7a5r5JmB5ygHW1B3Xda4ziBgY88aB6aw== X-Received: by 2002:a1c:105:: with SMTP id 5mr1586527wmb.83.1599765328631; Thu, 10 Sep 2020 12:15:28 -0700 (PDT) Received: from krug ([89.180.146.237]) by smtp.gmail.com with ESMTPSA id o124sm4849958wmb.2.2020.09.10.12.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 12:15:27 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Juri Linkov Subject: Re: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice References: <8736433l4c.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> <87k0x2vk4n.fsf@gmail.com> <87ft7qvc0j.fsf@gmail.com> <87lfhh8nyh.fsf@mail.linkov.net> Date: Thu, 10 Sep 2020 20:15:25 +0100 In-Reply-To: <87lfhh8nyh.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 10 Sep 2020 21:51:34 +0300") Message-ID: <87363pv3xu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19032 Cc: 19032@debbugs.gnu.org, 43120@debbugs.gnu.org, Stefan Monnier , Lars Ingebrigtsen , OGAWA Hirofumi , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> Though I'm starting to think that when require-match is nil, an >> icomplete user wouldn't want the new icomplete-show-matches-on-no-input >> behaviour anyway. > > This is confusing, I don't understand why behaviour of > icomplete-show-matches-on-no-input should depend on require-match. > > Here are two examples that produce a different result. > > The first example is from hi-lock-read-face-name: > > (defvar hi-history nil) > (icomplete-mode) > (let ((icomplete-show-matches-on-no-input t) > (defaults '("hi-yellow" "hi-green")) > (hi-history '("hi-blue"))) > (completing-read > (format-prompt "Highlight using face" (car defaults)) > obarray 'facep t nil 'hi-history defaults)) > > displays this prompt: > > Highlight using face (default hi-yellow): {link | menu | bold ... > > Typing RET returns "link" (and sometimes returns "hi-blue" from the histo= ry), > but never returns the expected default value "hi-yellow". > > Whereas the second example from tab-bar-switch-to-tab > works correctly since its arg require-match is nil: > > (let ((icomplete-show-matches-on-no-input t) > (defaults '("yellow" "green")) > (hi-history '("blue"))) > (completing-read > (format-prompt "Switch to tab by name" (car defaults)) > defaults nil nil nil 'hi-history defaults)) > > displays this prompt: > > Switch to tab by name (default yellow): {green | yellow} > > Typing RET returns the default value "yellow", not the first candidate "g= reen". > > This makes the behaviour of icomplete-show-matches-on-no-input > unpredictable, and thus in some cases dangerous. I think I agree, but I've just tested this with the version of icomplete.el before I started messing with this stuff (commit c8472cc69d4bce7f53c9a62966245a4de3d99fbd) and I get exactly the same results as you. So I'd leave my work here for someone else to pick up on: To be clear, I just wanted to simplify/refactor the code to be less intrusive on minibuffer.el. I'm not much of an icomplete-mode user, more of a fido-mode user where these discrepancies are "fixed" by copying ido-mode's behaviour. Jo=C3=A3o From unknown Sat Aug 16 21:19:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Oct 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator