GNU bug report logs - #19028
[PATCH] grep: fix grep -F -x -o outputs extra newlines

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 19028 <19028 <at> debbugs.gnu.org>
Subject: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines
Date: Fri, 14 Nov 2014 08:32:46 -0800

[Message part 1 (text/plain, inline)]

On Thu, Nov 13, 2014 at 4:50 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Wed, 12 Nov 2014 16:38:42 -0800
> Jim Meyering <jim <at> meyering.net> wrote:
>> Would you please amend it to include the test you added?
>
> Sorry, I amend it after `git add'.

Thanks. However, that new test would never run, because the new file's
name was not listed in tests/Makefile.am.  I added it, and changed the
test script to merge two loops (avoiding some duplication) and
improved comments (this also affects 2.19). I also tracked down the
commit that introduced the problem and listed it in the commit log,
and mentioned in NEWS that both 2.19 and 2.20 were affected. I changed
the commit log to provide more detail: this is important, especially
for a bug fix.  Simply saying "fixed the bug" does not help the reader
understand.  One must say how/why the code failed, and/or what changed
to make it work, especially when the change is nontrivial.

[0001-grep-F-x-o-PAT-would-print-an-extra-newline-for-each.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.