From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 12 08:55:08 2014 Received: (at submit) by debbugs.gnu.org; 12 Nov 2014 13:55:08 +0000 Received: from localhost ([127.0.0.1]:58286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoYO3-0005tL-RD for submit@debbugs.gnu.org; Wed, 12 Nov 2014 08:55:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58903) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoYO0-0005tC-TL for submit@debbugs.gnu.org; Wed, 12 Nov 2014 08:55:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoYNs-0002q7-17 for submit@debbugs.gnu.org; Wed, 12 Nov 2014 08:55:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoYNr-0002q3-Uv for submit@debbugs.gnu.org; Wed, 12 Nov 2014 08:54:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoYNk-0004nb-Ae for bug-grep@gnu.org; Wed, 12 Nov 2014 08:54:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoYNb-0002p2-Sd for bug-grep@gnu.org; Wed, 12 Nov 2014 08:54:48 -0500 Received: from mailgw05.kcn.ne.jp ([61.86.7.212]:53491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoYNb-0002oV-Cl for bug-grep@gnu.org; Wed, 12 Nov 2014 08:54:39 -0500 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw05.kcn.ne.jp (Postfix) with ESMTP id F11FB67B1E for ; Wed, 12 Nov 2014 22:54:35 +0900 (JST) Received: from mail08.kcn.ne.jp ([61.86.6.187]) by imp01 with bizsmtp id Edub1p00U426eXR01dubjn; Wed, 12 Nov 2014 22:54:35 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.73] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail08.kcn.ne.jp (Postfix) with ESMTPA id 8832A12B802E for ; Wed, 12 Nov 2014 22:54:35 +0900 (JST) Date: Wed, 12 Nov 2014 22:54:36 +0900 From: Norihiro Tanaka To: bug-grep@gnu.org Subject: [PATCH] grep: fix grep -F -x -o outputs extra newlines Message-Id: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_546365440000000059D2_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: Mac OS X 10.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_546365440000000059D2_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit grep -F -x -o outputs extra newlines as following. $ printf 'abc\nabc\n' | grep -F -x -o abc abc abc $ (expected) $ printf 'abc\nabc\n' | grep -F -x -o abc abc abc $ Jim, could you take this bug fix in next release? --------_546365440000000059D2_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-fix-grep-F-x-o-outputs-extra-newlines.patch" Content-Disposition: attachment; filename="0001-grep-fix-grep-F-x-o-outputs-extra-newlines.patch" Content-Transfer-Encoding: base64 RnJvbSBhNGRjOWMxNGRhZTZkODNhYjE0ODkxZWUxZDg1YTQxZjRkMjRkNjg0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBXZWQsIDEyIE5vdiAyMDE0IDIyOjI1OjE4ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogZml4IGdyZXAgLUYgLXggLW8gb3V0cHV0cyBleHRyYSBuZXdsaW5lcwoKKiBzcmMva3dzZWFy Y2guYzogRml4IGdyZXAgLUYgLXggLW8gb3V0cHV0cyBleHRyYSBuZXdsaW5lcy4KKiB0ZXN0cy9t YXRjaC1saW5lczogQWRkIGEgbmV3IHRlc3QuCi0tLQogTkVXUyAgICAgICAgICAgfCAzICsrKwog c3JjL2t3c2VhcmNoLmMgfCA3ICsrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL05FV1MgYi9ORVdTCmluZGV4IGM0NjUx NjIuLjY2M2I0MjIgMTAwNjQ0Ci0tLSBhL05FV1MKKysrIGIvTkVXUwpAQCAtNDEsNiArNDEsOSBA QCBHTlUgZ3JlcCBORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLSotIG91 dGxpbmUgLSotCiAgIGltcGx5aW5nIHRoYXQgdGhlIG1hdGNoLCAiMTAiIHdhcyBvbiBsaW5lIDEu CiAgIFtidWcgaW50cm9kdWNlZCBpbiBncmVwLTIuMTldCiAKKyAgZ3JlcCAtRiAteCAtbyBubyBs b25nZXIgb3V0cHV0IGV4dHJhIG5ld2xpbmVzLgorICBbYnVnIGludHJvZHVjZWQgaW4gZ3JlcC0y LjE5XQorCiAgIGdyZXAgaW4gYSBub24tVVRGOCBtdWx0aWJ5dGUgbG9jYWxlIGNvdWxkIG1pc3Rh a2VubHkgbWF0Y2ggaW4gdGhlIG1pZGRsZQogICBvZiBhIG11bHRpYnl0ZSBjaGFyYWN0ZXIgd2hl biB1c2luZyBhICdeJy1hbmNob3JlZCBhbHRlcm5hdGUgaW4gYSBwYXR0ZXJuLAogICBsZWFkaW5n IGl0IHRvIHByaW50IG5vbi1tYXRjaGluZyBsaW5lcy4gIFtidWcgcHJlc2VudCBzaW5jZSAidGhl IGJlZ2lubmluZyJdCmRpZmYgLS1naXQgYS9zcmMva3dzZWFyY2guYyBiL3NyYy9rd3NlYXJjaC5j CmluZGV4IDZiZDUxNmEuLmFhOTY1ZjYgMTAwNjQ0Ci0tLSBhL3NyYy9rd3NlYXJjaC5jCisrKyBi L3NyYy9rd3NlYXJjaC5jCkBAIC0xMjksNyArMTI5LDcgQEAgRmV4ZWN1dGUgKGNoYXIgY29uc3Qg KmJ1Ziwgc2l6ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6ZSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBidWYgKyBzaXplIC0gYmVnICsgbWF0Y2hfbGluZXMsICZrd3NtYXRjaCk7 CiAgICAgICBpZiAob2Zmc2V0ID09IChzaXplX3QpIC0xKQogICAgICAgICBnb3RvIGZhaWx1cmU7 Ci0gICAgICBsZW4gPSBrd3NtYXRjaC5zaXplWzBdIC0gbWF0Y2hfbGluZXM7CisgICAgICBsZW4g PSBrd3NtYXRjaC5zaXplWzBdIC0gMiAqIG1hdGNoX2xpbmVzOwogICAgICAgaWYgKCFtYXRjaF9s aW5lcyAmJiBNQl9DVVJfTUFYID4gMSAmJiAhdXNpbmdfdXRmOCAoKQogICAgICAgICAgICYmIG1i X2dvYmFjayAoJm1iX3N0YXJ0LCBiZWcgKyBvZmZzZXQsIGJ1ZiArIHNpemUpICE9IDApCiAgICAg ICAgIHsKQEAgLTE0Miw3ICsxNDIsMTAgQEAgRmV4ZWN1dGUgKGNoYXIgY29uc3QgKmJ1Ziwgc2l6 ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6ZSwKICAgICAgIGlmIChzdGFydF9wdHIgJiYgIW1h dGNoX3dvcmRzKQogICAgICAgICBnb3RvIHN1Y2Nlc3NfaW5fYmVnX2FuZF9sZW47CiAgICAgICBp ZiAobWF0Y2hfbGluZXMpCi0gICAgICAgIGdvdG8gc3VjY2Vzc19pbl9iZWdfYW5kX2xlbjsKKyAg ICAgICAgeworICAgICAgICAgIGxlbiArPSBzdGFydF9wdHIgPT0gTlVMTDsKKyAgICAgICAgICBn b3RvIHN1Y2Nlc3NfaW5fYmVnX2FuZF9sZW47CisgICAgICAgIH0KICAgICAgIGlmIChtYXRjaF93 b3JkcykKICAgICAgICAgZm9yICh0cnkgPSBiZWc7IDsgKQogICAgICAgICAgIHsKLS0gCjIuMS4z Cgo= --------_546365440000000059D2_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 12 19:39:05 2014 Received: (at 19028) by debbugs.gnu.org; 13 Nov 2014 00:39:06 +0000 Received: from localhost ([127.0.0.1]:58985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoiRF-00056R-Jr for submit@debbugs.gnu.org; Wed, 12 Nov 2014 19:39:05 -0500 Received: from mail-yk0-f177.google.com ([209.85.160.177]:46019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoiRE-00056J-0H for 19028@debbugs.gnu.org; Wed, 12 Nov 2014 19:39:04 -0500 Received: by mail-yk0-f177.google.com with SMTP id 9so621841ykp.22 for <19028@debbugs.gnu.org>; Wed, 12 Nov 2014 16:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=YWir/94u9PblD1kpHuTAXXXp3Rk2l6+z3Tp2dsRCQ3s=; b=zRpbDa9Jk3pA+FdbseuPBzg2S2shDoabiRzDUVizqszjLZoYITMU0321iZ6krjmd+x TsQ/4o7WCWHzgDObz1Z9vxU0VdZjHaTqn11qt/EkwfvVaAWn8x0lhQqc3jRqiUqnxm9S DDIR/e1Y7WNrrj03hHCasnsMFRtPAxlqXJZARduUvh4uMa8AfdxFzuZ43pTsrcJQPAkk Ri/W5MW7GrddnMWR/KEAFxyIqc5AMhwhd5TRJbuf+H41TFHqh8yz7Kytn0iA520KFI4X oQRGlzMhI5kC8eu9CMrp+OUy8gpO0K7hOBYTH3Zx0HMxfH/TTkBS4hBVeQ/f+ehIouUg iMjA== X-Received: by 10.170.117.73 with SMTP id j70mr53534739ykb.76.1415839143113; Wed, 12 Nov 2014 16:39:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.157.9 with HTTP; Wed, 12 Nov 2014 16:38:42 -0800 (PST) In-Reply-To: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> References: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Wed, 12 Nov 2014 16:38:42 -0800 X-Google-Sender-Auth: pPMVE-Gevtv82ocpXd82H3hfFxA Message-ID: Subject: Re: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines To: Norihiro Tanaka Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19028 Cc: 19028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Nice! Thank you for the report and patch. Would you please amend it to include the test you added? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 12 19:42:44 2014 Received: (at 19028) by debbugs.gnu.org; 13 Nov 2014 00:42:44 +0000 Received: from localhost ([127.0.0.1]:58989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoiUm-0005Bw-5Z for submit@debbugs.gnu.org; Wed, 12 Nov 2014 19:42:44 -0500 Received: from mail-yh0-f52.google.com ([209.85.213.52]:57360) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XoiUk-0005Bn-P1 for 19028@debbugs.gnu.org; Wed, 12 Nov 2014 19:42:43 -0500 Received: by mail-yh0-f52.google.com with SMTP id z6so436201yhz.11 for <19028@debbugs.gnu.org>; Wed, 12 Nov 2014 16:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=kBM/KU1BB+lwpS5zfxhymNqNkgJIWPf9AmioUU8Njiw=; b=IreiDPKYRJNSbJLNZY+BkOav0rlu/Sno054hdWA8otTmfOW2gyg2F1AxfxYHLgyUJJ VUQx+lXYZitedTGTv6iCGkS/zC94Ncznml0qv4YPzsBRDloy6PaidVAIrcf1P2DApqMy JMGE8sy69iucEmp4HsrQgUXsFyUNSsuhnH7R+WN0Bbm+yVkzlC5S7tcr1umHUxP8Iwl6 LB/twKPiTV96NCmWrV1f7nlrbdNMl4z8z1ymi8iemyctn/dJRYA2MlAtWeu/DoZ4I6M8 1cTr6A4vYuuVnM+dy/EVj9jPgIiLNGq7N0et+AiUM7NMZSuokjeYCejqnLjggfMerSL8 DELg== X-Received: by 10.236.30.33 with SMTP id j21mr5702060yha.157.1415839362324; Wed, 12 Nov 2014 16:42:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.157.9 with HTTP; Wed, 12 Nov 2014 16:42:22 -0800 (PST) In-Reply-To: References: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Wed, 12 Nov 2014 16:42:22 -0800 X-Google-Sender-Auth: 1uSXT4gAUfPI3bSXLlas2vm4as0 Message-ID: Subject: Re: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines To: Norihiro Tanaka Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19028 Cc: 19028 <19028@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) PS, this (omitting parts of a patch) used to happen to me, too, but then I wrote vc-dwim (https://gnu.org/software/vc-dwim/). If you use it to prepare/view/commit changes for which you have already written a ChangeLog entry, then it will automatically ensure that you do not omit changes to any file whose name appears in the corresponding ChangeLog entry. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 13 07:50:24 2014 Received: (at 19028) by debbugs.gnu.org; 13 Nov 2014 12:50:24 +0000 Received: from localhost ([127.0.0.1]:59238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xotqx-000051-Tz for submit@debbugs.gnu.org; Thu, 13 Nov 2014 07:50:24 -0500 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:50693) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xotqu-00004q-Bk for 19028@debbugs.gnu.org; Thu, 13 Nov 2014 07:50:22 -0500 Received: from imp03 (mailgw7.kcn.ne.jp [61.86.15.238]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id E862E6C1C23 for <19028@debbugs.gnu.org>; Thu, 13 Nov 2014 21:50:17 +0900 (JST) Received: from mail05.kcn.ne.jp ([61.86.6.184]) by imp03 with bizsmtp id F0qH1p00E3yDdWd010qHaq; Thu, 13 Nov 2014 21:50:17 +0900 X-OrgRCPT: 19028@debbugs.gnu.org Received: from [10.120.1.12] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail05.kcn.ne.jp (Postfix) with ESMTPA id 8CFFB7D009F; Thu, 13 Nov 2014 21:50:17 +0900 (JST) Date: Thu, 13 Nov 2014 21:50:18 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines In-Reply-To: References: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> Message-Id: <20141113215017.B746.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5464A8B100000000B73D_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 19028 Cc: 19028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --------_5464A8B100000000B73D_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Wed, 12 Nov 2014 16:38:42 -0800 Jim Meyering wrote: > Would you please amend it to include the test you added? Sorry, I amend it after `git add'. --------_5464A8B100000000B73D_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-fix-grep-F-x-o-outputs-extra-newlines.patch" Content-Disposition: attachment; filename="0001-grep-fix-grep-F-x-o-outputs-extra-newlines.patch" Content-Transfer-Encoding: base64 RnJvbSAwMzQ5NWM1YWZiODE5YmYyODk5ODdiZTE1YzA2YjUwYzIxOTYyZGE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBXZWQsIDEyIE5vdiAyMDE0IDIyOjI1OjE4ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogZml4IGdyZXAgLUYgLXggLW8gb3V0cHV0cyBleHRyYSBuZXdsaW5lcwoKKiBzcmMva3dzZWFy Y2guYzogZ3JlcDogRml4IGdyZXAgLUYgLXggLW8gb3V0cHV0cyBleHRyYSBuZXdsaW5lcy4KKiB0 ZXN0cy9tYXRjaC1saW5lczogQWRkIGEgbmV3IHRlc3QuCi0tLQogTkVXUyAgICAgICAgICAgICAg fCAgMyArKysKIHNyYy9rd3NlYXJjaC5jICAgIHwgIDcgKysrKystLQogdGVzdHMvbWF0Y2gtbGlu ZXMgfCAzOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBj aGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAw NzU1IHRlc3RzL21hdGNoLWxpbmVzCgpkaWZmIC0tZ2l0IGEvTkVXUyBiL05FV1MKaW5kZXggYzQ2 NTE2Mi4uNjYzYjQyMiAxMDA2NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC00MSw2ICs0MSw5 IEBAIEdOVSBncmVwIE5FV1MgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtKi0g b3V0bGluZSAtKi0KICAgaW1wbHlpbmcgdGhhdCB0aGUgbWF0Y2gsICIxMCIgd2FzIG9uIGxpbmUg MS4KICAgW2J1ZyBpbnRyb2R1Y2VkIGluIGdyZXAtMi4xOV0KIAorICBncmVwIC1GIC14IC1vIG5v IGxvbmdlciBvdXRwdXQgZXh0cmEgbmV3bGluZS4KKyAgW2J1ZyBpbnRyb2R1Y2VkIGluIGdyZXAt Mi4xOV0KKwogICBncmVwIGluIGEgbm9uLVVURjggbXVsdGlieXRlIGxvY2FsZSBjb3VsZCBtaXN0 YWtlbmx5IG1hdGNoIGluIHRoZSBtaWRkbGUKICAgb2YgYSBtdWx0aWJ5dGUgY2hhcmFjdGVyIHdo ZW4gdXNpbmcgYSAnXictYW5jaG9yZWQgYWx0ZXJuYXRlIGluIGEgcGF0dGVybiwKICAgbGVhZGlu ZyBpdCB0byBwcmludCBub24tbWF0Y2hpbmcgbGluZXMuICBbYnVnIHByZXNlbnQgc2luY2UgInRo ZSBiZWdpbm5pbmciXQpkaWZmIC0tZ2l0IGEvc3JjL2t3c2VhcmNoLmMgYi9zcmMva3dzZWFyY2gu YwppbmRleCA2YmQ1MTZhLi5hYTk2NWY2IDEwMDY0NAotLS0gYS9zcmMva3dzZWFyY2guYworKysg Yi9zcmMva3dzZWFyY2guYwpAQCAtMTI5LDcgKzEyOSw3IEBAIEZleGVjdXRlIChjaGFyIGNvbnN0 ICpidWYsIHNpemVfdCBzaXplLCBzaXplX3QgKm1hdGNoX3NpemUsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYnVmICsgc2l6ZSAtIGJlZyArIG1hdGNoX2xpbmVzLCAma3dzbWF0Y2gp OwogICAgICAgaWYgKG9mZnNldCA9PSAoc2l6ZV90KSAtMSkKICAgICAgICAgZ290byBmYWlsdXJl OwotICAgICAgbGVuID0ga3dzbWF0Y2guc2l6ZVswXSAtIG1hdGNoX2xpbmVzOworICAgICAgbGVu ID0ga3dzbWF0Y2guc2l6ZVswXSAtIDIgKiBtYXRjaF9saW5lczsKICAgICAgIGlmICghbWF0Y2hf bGluZXMgJiYgTUJfQ1VSX01BWCA+IDEgJiYgIXVzaW5nX3V0ZjggKCkKICAgICAgICAgICAmJiBt Yl9nb2JhY2sgKCZtYl9zdGFydCwgYmVnICsgb2Zmc2V0LCBidWYgKyBzaXplKSAhPSAwKQogICAg ICAgICB7CkBAIC0xNDIsNyArMTQyLDEwIEBAIEZleGVjdXRlIChjaGFyIGNvbnN0ICpidWYsIHNp emVfdCBzaXplLCBzaXplX3QgKm1hdGNoX3NpemUsCiAgICAgICBpZiAoc3RhcnRfcHRyICYmICFt YXRjaF93b3JkcykKICAgICAgICAgZ290byBzdWNjZXNzX2luX2JlZ19hbmRfbGVuOwogICAgICAg aWYgKG1hdGNoX2xpbmVzKQotICAgICAgICBnb3RvIHN1Y2Nlc3NfaW5fYmVnX2FuZF9sZW47Cisg ICAgICAgIHsKKyAgICAgICAgICBsZW4gKz0gc3RhcnRfcHRyID09IE5VTEw7CisgICAgICAgICAg Z290byBzdWNjZXNzX2luX2JlZ19hbmRfbGVuOworICAgICAgICB9CiAgICAgICBpZiAobWF0Y2hf d29yZHMpCiAgICAgICAgIGZvciAodHJ5ID0gYmVnOyA7ICkKICAgICAgICAgICB7CmRpZmYgLS1n aXQgYS90ZXN0cy9tYXRjaC1saW5lcyBiL3Rlc3RzL21hdGNoLWxpbmVzCm5ldyBmaWxlIG1vZGUg MTAwNzU1CmluZGV4IDAwMDAwMDAuLjNjOTA0NDMKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0cy9t YXRjaC1saW5lcwpAQCAtMCwwICsxLDM4IEBACisjIS9iaW4vc2gKKyMgVHJpZ2dlciBhIGJ1ZyBp biB0aGUgREZBIG1hdGNoZXIuCisjIFRoaXMgd291bGQgZmFpbCBmb3IgZ3JlcC0yLjIwLgorCisj IENvcHlyaWdodCAyMDE0IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRoaXMg cHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3Ig bW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVp dGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9wdGlvbikgYW55 IGxhdGVyIHZlcnNpb24uCisKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsg d2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBv ciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworIyBZb3Ugc2hvdWxkIGhhdmUg cmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9u ZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGlj ZW5zZXMvPi4KKworLiAiJHtzcmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi4vc3Jj CisKK3ByaW50ZiAnYVxuJyA+IGluIHx8IGZyYW1ld29ya19mYWlsdXJlXworCitmYWlsPTAKKwor Zm9yIGxvY2FsZSBpbiBDIGVuX1VTLlVURi04OyBkbworICBmb3Igb3B0aW9ucyBpbiAteCAnLUUg LXgnICctRiAteCc7IGRvCisgICAgTENfQUxMPSRsb2NhbGUgZ3JlcCAkb3B0aW9ucyBhIGluID4g b3V0IHx8IGZhaWw9MQorICAgIGNvbXBhcmUgb3V0IGluIHx8IGZhaWw9MQorICBkb25lCisKKyAg Zm9yIG9wdGlvbnMgaW4gJy14IC1vJyAnLUUgLXggLW8nICctRiAteCAtbyc7IGRvCisgICAgTENf QUxMPSRsb2NhbGUgZ3JlcCAkb3B0aW9ucyBhIGluID4gb3V0CisgICAgY29tcGFyZSBvdXQgaW4g fHwgZmFpbD0xCisgIGRvbmUKK2RvbmUKKworRXhpdCAkZmFpbAotLSAKMi4xLjMKCg== --------_5464A8B100000000B73D_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 11:33:12 2014 Received: (at 19028) by debbugs.gnu.org; 14 Nov 2014 16:33:12 +0000 Received: from localhost ([127.0.0.1]:60985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpJo8-0004ag-0L for submit@debbugs.gnu.org; Fri, 14 Nov 2014 11:33:12 -0500 Received: from mail-yk0-f182.google.com ([209.85.160.182]:41137) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpJo4-0004aW-WE for 19028@debbugs.gnu.org; Fri, 14 Nov 2014 11:33:10 -0500 Received: by mail-yk0-f182.google.com with SMTP id q9so3239444ykb.13 for <19028@debbugs.gnu.org>; Fri, 14 Nov 2014 08:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=tMgwt/3GHDVvJZAU3nbc/QxTWAdfQpfZ8uO94LTOUXI=; b=Xi4fRKjrmkHH6lDzSvx8EVYwz8T7Ji4rl8zEWNYTSYjDx4qOocR+JhMMr5LhZes0QF /+SsdZiTgZLHl0ZmVsw5PYnFYf/hpqTnXzjFEvKElBI4t1cwAtHmRcsAeT58i6aKHt35 3IoXcMH3NDdkXEpX6QM/ZwwnUboVSlsQKuXh+yeVBzKt8ahBfed6qYgYIuAXy8SOHjmQ FqcFDcH5lnTuIDtOqIczrxCzQb0BPaHGT5hsq/+dA6xEMB5adcDGZclZWXI6qJ1iOiYk 4rEOuWL1HpgYvI5shfWkHpkzMT7XsrDaWM7Q2AhpYTETrsoORra9Ojfc8YyKjBrRKUl+ d9hg== X-Received: by 10.170.117.73 with SMTP id j70mr6952079ykb.76.1415982788248; Fri, 14 Nov 2014 08:33:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.157.9 with HTTP; Fri, 14 Nov 2014 08:32:46 -0800 (PST) In-Reply-To: <20141113215017.B746.27F6AC2D@kcn.ne.jp> References: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> <20141113215017.B746.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Fri, 14 Nov 2014 08:32:46 -0800 X-Google-Sender-Auth: vcrPjvSu508SaOnzBfZU1d8TBvk Message-ID: Subject: Re: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=001a1137a2001a1e370507d42f8a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19028 Cc: 19028 <19028@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1137a2001a1e370507d42f8a Content-Type: text/plain; charset=ISO-8859-1 On Thu, Nov 13, 2014 at 4:50 AM, Norihiro Tanaka wrote: > On Wed, 12 Nov 2014 16:38:42 -0800 > Jim Meyering wrote: >> Would you please amend it to include the test you added? > > Sorry, I amend it after `git add'. Thanks. However, that new test would never run, because the new file's name was not listed in tests/Makefile.am. I added it, and changed the test script to merge two loops (avoiding some duplication) and improved comments (this also affects 2.19). I also tracked down the commit that introduced the problem and listed it in the commit log, and mentioned in NEWS that both 2.19 and 2.20 were affected. I changed the commit log to provide more detail: this is important, especially for a bug fix. Simply saying "fixed the bug" does not help the reader understand. One must say how/why the code failed, and/or what changed to make it work, especially when the change is nontrivial. --001a1137a2001a1e370507d42f8a Content-Type: application/octet-stream; name="0001-grep-F-x-o-PAT-would-print-an-extra-newline-for-each.patch" Content-Disposition: attachment; filename="0001-grep-F-x-o-PAT-would-print-an-extra-newline-for-each.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2hrih1g1 RnJvbSAwZDg2MDUxYWU4MmNmYzFiMjRiZDI4YWM0NzBhZTY3Y2E1NDVlYzlmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBXZWQsIDEyIE5vdiAyMDE0IDIyOjI1OjE4ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cCAtRiAteCAtbyBQQVQgd291bGQgcHJpbnQgYW4gZXh0cmEgbmV3bGluZSBmb3IgZWFjaCBtYXRj aAoKKiBzcmMva3dzZWFyY2guYyAoRmV4ZWN1dGUpOiBDb3JyZWN0bHkgY29tcHV0ZSB0aGUgbGVu Z3RoIG9mIGEgbWF0Y2gKYnkgc3VidHJhY3RpbmcgMiAobm90IDEpIHdoZW4gbWF0Y2hfbGluZXMg aXMgc2V0LiAgV2l0aCAteCwgd2UgYXVnbWVudAp0aGUgImxpbmUiIGJ5IGJvdGggcHJlcGVuZGlu ZyBhbmQgYXBwZW5kaW5nIGFuIEVPTEJZVEUgdG8gdGhlIHNlYXJjaApwYXR0ZXJuLiAgSGVyZSwg d2UgbXVzdCBjb3JyZWN0IGZvciB0aGF0LiAgSG93ZXZlciwgdG8gY29tcGVuc2F0ZSwKd2hlbiB3 ZSBhcmUgdXNpbmcgLXggKC0tbGluZS1yZWdleHApIGFuZCBzdGFydF9wdHIgaXMgTlVMTCwgd2Ug aGF2ZQp0byBhZGQgMSB0byB0aGUgbGVuZ3RoIHNvIHRoYXQgd2Ugc3RpbGwgcHJpbnQgdGhlIHRy YWlsaW5nIEVPTEJZVEUuCkludHJvZHVjZWQgYnkgY29tbWl0IHYyLjE4LTg1LWcyYzk0MzI2Lgoq IHRlc3RzL21hdGNoLWxpbmVzOiBBZGQgYSBuZXcgdGVzdC4KKiB0ZXN0cy9NYWtlZmlsZS5hbSAo VEVTVFMpOiBBZGQgaXQuCiogTkVXUyAoQnVnIGZpeGVzKTogTWVudGlvbiBpdC4KLS0tCiBORVdT ICAgICAgICAgICAgICB8ICAzICsrKwogc3JjL2t3c2VhcmNoLmMgICAgfCAgNyArKysrKy0tCiB0 ZXN0cy9NYWtlZmlsZS5hbSB8ICAxICsKIHRlc3RzL21hdGNoLWxpbmVzIHwgMzYgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDQ1IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA3NTUgdGVzdHMvbWF0Y2gtbGlu ZXMKCmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCBjNDY1MTYyLi4xNTk3NTI4IDEwMDY0 NAotLS0gYS9ORVdTCisrKyBiL05FV1MKQEAgLTQxLDYgKzQxLDkgQEAgR05VIGdyZXAgTkVXUyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0qLSBvdXRsaW5lIC0qLQogICBpbXBs eWluZyB0aGF0IHRoZSBtYXRjaCwgIjEwIiB3YXMgb24gbGluZSAxLgogICBbYnVnIGludHJvZHVj ZWQgaW4gZ3JlcC0yLjE5XQoKKyAgZ3JlcCAtRiAteCAtbyBubyBsb25nZXIgcHJpbnRzIGFuIGV4 dHJhIG5ld2xpbmUgZm9yIGVhY2ggbWF0Y2guCisgIFtidWcgaW50cm9kdWNlZCBpbiBncmVwLTIu MTldCisKICAgZ3JlcCBpbiBhIG5vbi1VVEY4IG11bHRpYnl0ZSBsb2NhbGUgY291bGQgbWlzdGFr ZW5seSBtYXRjaCBpbiB0aGUgbWlkZGxlCiAgIG9mIGEgbXVsdGlieXRlIGNoYXJhY3RlciB3aGVu IHVzaW5nIGEgJ14nLWFuY2hvcmVkIGFsdGVybmF0ZSBpbiBhIHBhdHRlcm4sCiAgIGxlYWRpbmcg aXQgdG8gcHJpbnQgbm9uLW1hdGNoaW5nIGxpbmVzLiAgW2J1ZyBwcmVzZW50IHNpbmNlICJ0aGUg YmVnaW5uaW5nIl0KZGlmZiAtLWdpdCBhL3NyYy9rd3NlYXJjaC5jIGIvc3JjL2t3c2VhcmNoLmMK aW5kZXggNmJkNTE2YS4uYWE5NjVmNiAxMDA2NDQKLS0tIGEvc3JjL2t3c2VhcmNoLmMKKysrIGIv c3JjL2t3c2VhcmNoLmMKQEAgLTEyOSw3ICsxMjksNyBAQCBGZXhlY3V0ZSAoY2hhciBjb25zdCAq YnVmLCBzaXplX3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJ1ZiArIHNpemUgLSBiZWcgKyBtYXRjaF9saW5lcywgJmt3c21hdGNoKTsK ICAgICAgIGlmIChvZmZzZXQgPT0gKHNpemVfdCkgLTEpCiAgICAgICAgIGdvdG8gZmFpbHVyZTsK LSAgICAgIGxlbiA9IGt3c21hdGNoLnNpemVbMF0gLSBtYXRjaF9saW5lczsKKyAgICAgIGxlbiA9 IGt3c21hdGNoLnNpemVbMF0gLSAyICogbWF0Y2hfbGluZXM7CiAgICAgICBpZiAoIW1hdGNoX2xp bmVzICYmIE1CX0NVUl9NQVggPiAxICYmICF1c2luZ191dGY4ICgpCiAgICAgICAgICAgJiYgbWJf Z29iYWNrICgmbWJfc3RhcnQsIGJlZyArIG9mZnNldCwgYnVmICsgc2l6ZSkgIT0gMCkKICAgICAg ICAgewpAQCAtMTQyLDcgKzE0MiwxMCBAQCBGZXhlY3V0ZSAoY2hhciBjb25zdCAqYnVmLCBzaXpl X3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAgICAgaWYgKHN0YXJ0X3B0ciAmJiAhbWF0 Y2hfd29yZHMpCiAgICAgICAgIGdvdG8gc3VjY2Vzc19pbl9iZWdfYW5kX2xlbjsKICAgICAgIGlm IChtYXRjaF9saW5lcykKLSAgICAgICAgZ290byBzdWNjZXNzX2luX2JlZ19hbmRfbGVuOworICAg ICAgICB7CisgICAgICAgICAgbGVuICs9IHN0YXJ0X3B0ciA9PSBOVUxMOworICAgICAgICAgIGdv dG8gc3VjY2Vzc19pbl9iZWdfYW5kX2xlbjsKKyAgICAgICAgfQogICAgICAgaWYgKG1hdGNoX3dv cmRzKQogICAgICAgICBmb3IgKHRyeSA9IGJlZzsgOyApCiAgICAgICAgICAgewpkaWZmIC0tZ2l0 IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtlZmlsZS5hbQppbmRleCBjMDA2ZTU4Li4y MTdhNzMxIDEwMDY0NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQorKysgYi90ZXN0cy9NYWtlZmls ZS5hbQpAQCAtNzMsNiArNzMsNyBAQCBURVNUUyA9CQkJCQkJXAogICBpbnZhbGlkLW11bHRpYnl0 ZS1pbmZsb29wCQkJXAogICBraGFkYWZ5CQkJCQlcCiAgIGxvbmctbGluZS12cy0yR2lCLXJlYWQJ CQlcCisgIG1hdGNoLWxpbmVzCQkJCQlcCiAgIG1heC1jb3VudC1vdmVycmVhZAkJCQlcCiAgIG1h eC1jb3VudC12cy1jb250ZXh0CQkJCVwKICAgbWItZG90LW5ld2xpbmUJCQkJXApkaWZmIC0tZ2l0 IGEvdGVzdHMvbWF0Y2gtbGluZXMgYi90ZXN0cy9tYXRjaC1saW5lcwpuZXcgZmlsZSBtb2RlIDEw MDc1NQppbmRleCAwMDAwMDAwLi41MWMwMzllCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdHMvbWF0 Y2gtbGluZXMKQEAgLTAsMCArMSwzNiBAQAorIyEvYmluL3NoCisjIFRyaWdnZXIgYSBidWcgaW4g dGhlIERGQSBtYXRjaGVyIHRoYXQgd291bGQgbWFrZQorIyBncmVwIC1GIC14IC1vIFBBVCBwcmlu dCBhbiBleHRyYSBuZXdsaW5lIGZvciBlYWNoIG1hdGNoLgorIyBUaGlzIHdvdWxkIGZhaWwgZm9y IGdyZXAtMi4xOSBhbmQgZ3JlcC0yLjIwLgorCisjIENvcHlyaWdodCAyMDE0IEZyZWUgU29mdHdh cmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5 b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRo ZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vu c2UsIG9yCisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyMgVGhpcyBw cm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWws CisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdh cnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIg UFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUg ZGV0YWlscy4KKworIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5v dCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworLiAiJHtzcmNkaXI9Ln0v aW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi4vc3JjCisKK3ByaW50ZiAnYVxuJyA+IGluIHx8IGZy YW1ld29ya19mYWlsdXJlXworCitmYWlsPTAKKworZm9yIGxvY2FsZSBpbiBDIGVuX1VTLlVURi04 OyBkbworICBmb3Igb3B0aW9ucyBpbiAteCAnLUUgLXgnICctRiAteCc7IGRvCisgICAgZm9yIG8g aW4gJycgLW87IGRvCisgICAgICBMQ19BTEw9JGxvY2FsZSBncmVwICRvICRvcHRpb25zIGEgaW4g PiBvdXQgfHwgZmFpbD0xCisgICAgICBjb21wYXJlIG91dCBpbiB8fCBmYWlsPTEKKyAgICBkb25l CisgIGRvbmUKK2RvbmUKKworRXhpdCAkZmFpbAotLSAKMi4xLjIKCg== --001a1137a2001a1e370507d42f8a-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 17:46:56 2014 Received: (at 19028) by debbugs.gnu.org; 14 Nov 2014 22:46:56 +0000 Received: from localhost ([127.0.0.1]:32921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpPdo-0005qU-3i for submit@debbugs.gnu.org; Fri, 14 Nov 2014 17:46:56 -0500 Received: from mailgw05.kcn.ne.jp ([61.86.7.212]:52944) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpPdl-0005qL-6w for 19028@debbugs.gnu.org; Fri, 14 Nov 2014 17:46:54 -0500 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw05.kcn.ne.jp (Postfix) with ESMTP id 2947C679D9 for <19028@debbugs.gnu.org>; Sat, 15 Nov 2014 07:46:51 +0900 (JST) Received: from mail01.kcn.ne.jp ([61.86.6.180]) by imp02 with bizsmtp id Famr1p0053t2w9Z01amr1R; Sat, 15 Nov 2014 07:46:51 +0900 X-OrgRCPT: 19028@debbugs.gnu.org Received: from [10.120.1.58] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail01.kcn.ne.jp (Postfix) with ESMTPA id 06AEC5A8268; Sat, 15 Nov 2014 07:46:51 +0900 (JST) Date: Sat, 15 Nov 2014 07:46:51 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines In-Reply-To: References: <20141113215017.B746.27F6AC2D@kcn.ne.jp> Message-Id: <20141115074651.71D1.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19028 Cc: 19028 <19028@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Fri, 14 Nov 2014 08:32:46 -0800 Jim Meyering wrote: > Thanks. However, that new test would never run, because the new file's > name was not listed in tests/Makefile.am. I added it, and changed the > test script to merge two loops (avoiding some duplication) and > improved comments (this also affects 2.19). I also tracked down the > commit that introduced the problem and listed it in the commit log, > and mentioned in NEWS that both 2.19 and 2.20 were affected. I changed > the commit log to provide more detail: this is important, especially > for a bug fix. Simply saying "fixed the bug" does not help the reader > understand. One must say how/why the code failed, and/or what changed > to make it work, especially when the change is nontrivial. Thanks a lot for the adjustment. I understood that you said, and I agree that you changed. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 14 21:17:33 2014 Received: (at 19028-done) by debbugs.gnu.org; 15 Nov 2014 02:17:33 +0000 Received: from localhost ([127.0.0.1]:32937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpSvd-0002gb-2L for submit@debbugs.gnu.org; Fri, 14 Nov 2014 21:17:33 -0500 Received: from mail-yk0-f169.google.com ([209.85.160.169]:65190) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpSvb-0002gS-A2 for 19028-done@debbugs.gnu.org; Fri, 14 Nov 2014 21:17:31 -0500 Received: by mail-yk0-f169.google.com with SMTP id 79so968808ykr.0 for <19028-done@debbugs.gnu.org>; Fri, 14 Nov 2014 18:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=y4MY3bALx5kSqe8L0v90/eRCAXX5IsXTz2homU8t45E=; b=rq9feMdvR0t7b8QFsABRLeLoQbk9+untXUXzORdEzi0ndVQKNyq9k0YVzeC884vIh7 0pqScw/eyu4DbE5IC06Qw663lUNzuwFOfb34WoJ5efoH98pCVt4/u3Xvmu6mS5xnflY1 fNHNUm8nQsqTpQxCVPof5bT5k0rohPG8gct1dB34x03JgyqtNnJ5TbHHD094aigorwnw RiT1AgsybLXf+jrQ37IZwVHN6PAWAQJKwkVpGZX9mdCNC+vSOf5B8yOu/fIiviWYjMHn dG7CuiN0YqD5W+pf/CxzxcgBwSyJxZMXR+VbHzl1O9IndI8BbpQgDcNzNG6ZPSNL3Iwb XSnw== X-Received: by 10.170.166.8 with SMTP id i8mr10298388ykd.92.1416017850949; Fri, 14 Nov 2014 18:17:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.157.9 with HTTP; Fri, 14 Nov 2014 18:17:10 -0800 (PST) In-Reply-To: References: <20141112225435.59DE.27F6AC2D@kcn.ne.jp> <20141113215017.B746.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Fri, 14 Nov 2014 18:17:10 -0800 X-Google-Sender-Auth: OMy5JWD1a733sefiu7aq-pjkYlk Message-ID: Subject: Re: bug#19028: [PATCH] grep: fix grep -F -x -o outputs extra newlines To: Norihiro Tanaka Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19028-done Cc: 19028-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) pushed and marked as done From unknown Mon Jun 23 04:14:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Dec 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator