GNU bug report logs - #18994
Daemon does not preserve supplementary groups of build users

Previous Next

Full log

Message #17 received at 18994 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Charles Strahan <notifications <at> github.com>
Cc: 18994 <at> debbugs.gnu.org, NixOS/nix
 <reply+0011d43327cde66fa384a8345ffe1205d196179a23d7e9d092cf0000000111abfb7c92a163ce00b68004 <at> reply.github.com>,
 NixOS/nix <nix <at> noreply.github.com>
Subject: Re: [nix] Preserve supplementary groups of build users (9aed117)
Date: Wed, 01 Jul 2015 23:10:52 +0200

Charles Strahan <notifications <at> github.com> skribis:

> Is there any reason we immediately throw here, instead of checking `ngroups`, resizing the buffer accordingly, and then rerunning `getgrouplist`? I would think that would be a bit more robust.

Sorry, could you quote the code you’re referring to?

If you talking about the ‘getgrouplist’ call, maybe we could do that,
but we would still need to put a hard limit on the maximum number of
groups anyway.

WDYT?

Thanks,
Ludo’.

PS: Please keep 18994 <at> debbugs.gnu.org Cc’d.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.