From unknown Mon Aug 11 21:13:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18994 <18994@debbugs.gnu.org> To: bug#18994 <18994@debbugs.gnu.org> Subject: Status: Daemon does not preserve supplementary groups of build users Reply-To: bug#18994 <18994@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:13:41 +0000 retitle 18994 Daemon does not preserve supplementary groups of build users reassign 18994 guix submitter 18994 ludo@gnu.org (Ludovic Court=C3=A8s) severity 18994 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 08 09:02:15 2014 Received: (at submit) by debbugs.gnu.org; 8 Nov 2014 14:02:15 +0000 Received: from localhost ([127.0.0.1]:53451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xn6al-00016r-1t for submit@debbugs.gnu.org; Sat, 08 Nov 2014 09:02:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37715) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xn6aj-00016h-Es for submit@debbugs.gnu.org; Sat, 08 Nov 2014 09:02:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xn6aa-0002Ka-96 for submit@debbugs.gnu.org; Sat, 08 Nov 2014 09:02:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xn6aa-0002KV-60 for submit@debbugs.gnu.org; Sat, 08 Nov 2014 09:02:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xn6aR-0001lg-3r for bug-guix@gnu.org; Sat, 08 Nov 2014 09:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xn6aI-0002J7-30 for bug-guix@gnu.org; Sat, 08 Nov 2014 09:01:55 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:50595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xn6aH-0002Iw-SI for bug-guix@gnu.org; Sat, 08 Nov 2014 09:01:46 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 8F9943E49 for ; Sat, 8 Nov 2014 15:01:44 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1W+y2DB22y+K for ; Sat, 8 Nov 2014 15:01:44 +0100 (CET) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 4C6AD14FA for ; Sat, 8 Nov 2014 15:01:44 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guix@gnu.org Subject: Daemon does not preserve supplementary groups of build users X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 Brumaire an 223 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Sat, 08 Nov 2014 15:01:43 +0100 Message-ID: <87ppcxsse0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Currently, the build environment made by the daemon does not preserve supplementary groups of the build users. Thus, even though the standalone Guix system sets /dev/kvm 660, owned by root:kvm, and adds the build users to the kvm group, build users are unable to access it. This can be see with: (gexp->derivation "foo" #~(begin (mkdir #$output)(pk (stat:gid (stat "/dev/kvm")) (getgroups)))) The workaround for now is to make /dev/kvm 666. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 01 05:13:21 2015 Received: (at 18994) by debbugs.gnu.org; 1 Jul 2015 09:13:21 +0000 Received: from localhost ([127.0.0.1]:35199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAE52-0007Lz-Ij for submit@debbugs.gnu.org; Wed, 01 Jul 2015 05:13:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41741) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAE50-0007Lk-9c for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 05:13:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAE4s-0001ma-AN for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 05:13:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([208.118.235.10]:40385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAE4f-0001iL-6G; Wed, 01 Jul 2015 05:12:57 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:35990 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZAE4e-0005nr-CX; Wed, 01 Jul 2015 05:12:56 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: 18994@debbugs.gnu.org, Eelco Dolstra Subject: [PATCH] Preserve supplementary groups of build users References: <87ppcxsse0.fsf@gnu.org> Date: Wed, 01 Jul 2015 11:12:51 +0200 In-Reply-To: <87ppcxsse0.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 08 Nov 2014 15:01:43 +0100") Message-ID: <87vbe4w8a4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.10 X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 18994 Cc: nix-dev@lists.science.uu.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Currently, the build environment made by the daemon does not preserve > supplementary groups of the build users. > > Thus, even though the standalone Guix system sets /dev/kvm 660, owned by > root:kvm, and adds the build users to the kvm group, build users are > unable to access it. The following patch is an attempt to address this bug (see ) by preserving the supplementary groups of build users in the build environment. In practice, I would expect that supplementary groups would contain only one or two groups: the build users group, and possibly the =E2=80=9Ckvm=E2= =80=9D group. WDYT? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc index 85a818b..4644810 100644 --- a/nix/libstore/build.cc +++ b/nix/libstore/build.cc @@ -447,6 +447,7 @@ private: string user; uid_t uid; gid_t gid; + std::vector supplementaryGIDs; public: UserLock(); @@ -460,6 +461,7 @@ public: string getUser() { return user; } uid_t getUID() { return uid; } uid_t getGID() { return gid; } + std::vector getSupplementaryGIDs() { return supplementaryGIDs; } bool enabled() { return uid != 0; } @@ -539,6 +541,18 @@ void UserLock::acquire() throw Error(format("the Nix user should not be a member of `%1%'") % settings.buildUsersGroup); + /* Get the list of supplementary groups of this build user. This + is usually either empty or contains a group such as "kvm". */ + supplementaryGIDs.resize(10); + int ngroups = supplementaryGIDs.size(); + int err = getgrouplist(pw->pw_name, pw->pw_gid, + &supplementaryGIDs.at(0), &ngroups); + if (err == -1) + throw Error(format("failed to get list of supplementary groups for `%1'") + % pw->pw_name); + + supplementaryGIDs.resize(ngroups); + return; } } @@ -2179,8 +2193,11 @@ void DerivationGoal::runChild() if (buildUser.enabled()) { printMsg(lvlChatty, format("switching to user `%1%'") % buildUser.getUser()); - if (setgroups(0, 0) == -1) - throw SysError("cannot clear the set of supplementary groups"); + /* Preserve supplementary groups of the build user, to allow + admins to specify groups such as "kvm". */ + if (setgroups(buildUser.getSupplementaryGIDs().size(), + &buildUser.getSupplementaryGIDs().at(0)) == -1) + throw SysError("cannot set supplementary groups of build user"); if (setgid(buildUser.getGID()) == -1 || getgid() != buildUser.getGID() || --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 01 10:54:21 2015 Received: (at 18994) by debbugs.gnu.org; 1 Jul 2015 14:54:21 +0000 Received: from localhost ([127.0.0.1]:36146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAJP3-0008SN-4t for submit@debbugs.gnu.org; Wed, 01 Jul 2015 10:54:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37597) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAJP0-0008S9-T1 for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 10:54:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAJOu-0003F8-8P for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 10:54:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAJOo-0003BM-At; Wed, 01 Jul 2015 10:54:06 -0400 Received: from nocat-out.u-bordeaux.fr ([147.210.179.68]:42658 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZAJOn-0003Ah-Nh; Wed, 01 Jul 2015 10:54:06 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eelco Dolstra Subject: Re: [PATCH] Preserve supplementary groups of build users References: <87ppcxsse0.fsf@gnu.org> <87vbe4w8a4.fsf@gnu.org> <5593E431.70200@logicblox.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Messidor an 223 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x3D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Wed, 01 Jul 2015 16:54:00 +0200 In-Reply-To: <5593E431.70200@logicblox.com> (Eelco Dolstra's message of "Wed, 01 Jul 2015 14:59:29 +0200") Message-ID: <87k2ukornb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 18994 Cc: 18994@debbugs.gnu.org, nix-dev@lists.science.uu.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Hi Eelco, Eelco Dolstra skribis: > On 01/07/15 11:12, Ludovic Court=C3=A8s wrote: > >>> Currently, the build environment made by the daemon does not preserve >>> supplementary groups of the build users. >>> >>> Thus, even though the standalone Guix system sets /dev/kvm 660, owned by >>> root:kvm, and adds the build users to the kvm group, build users are >>> unable to access it. >>=20 >> The following patch is an attempt to address this bug (see >> ) by preserving the supplementary groups of >> build users in the build environment. >>=20 >> In practice, I would expect that supplementary groups would contain only >> one or two groups: the build users group, and possibly the =E2=80=9Ckvm= =E2=80=9D group. > > Applied, thanks! Excellent, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 01 11:30:12 2015 Received: (at 18994) by debbugs.gnu.org; 1 Jul 2015 15:30:12 +0000 Received: from localhost ([127.0.0.1]:36205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAJxh-0000u1-Sb for submit@debbugs.gnu.org; Wed, 01 Jul 2015 11:30:11 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36329) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAHc1-0005eJ-Ba for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 08:59:38 -0400 Received: by widjy10 with SMTP id jy10so57021255wid.1 for <18994@debbugs.gnu.org>; Wed, 01 Jul 2015 05:59:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=orYH8jVdYvE324OqXW68cXXdmHV4wS770BTJLhspfIo=; b=QLUQ0y6AZfSRy77cK7h7PnMl+jo0XcMPqUs7TdBGhgwwEoDDBwykhHu4Z3jFvokN7a hfZl2oV5alDbAcPDEqcUNhzXJiTrIXQHvR4lH/IG+7vscYkGkvkNORRRu6IvsQdhNchb yE/oSjLVxhb40qWkk7gwtVzNz/UFS2vSAxi1HzlthnmL1f10wi+P6P9NrQq3MmofBlWy YEDJxnarH3MZI3oni4ibIf7J7J8/Aev3bAMG7kOru6oso+jQOhBrJL5uGa3hqIjxMWyq W0960VyfAvKBnoUR1vS2ZxaYEo6PZLUD4uIbhQWDc4qO4Zp853qZ3s7BO+4c4u/QO8qL zpJg== X-Gm-Message-State: ALoCoQlHvVY7H5F0vsjbz6wWyH+agyr93IBou5I3B1EP37g7OhklhtgRU0NWorcR6SEg6byudbgD X-Received: by 10.180.86.168 with SMTP id q8mr41569816wiz.80.1435755571562; Wed, 01 Jul 2015 05:59:31 -0700 (PDT) Received: from [192.168.1.115] (5353B536.cm-6-4c.dynamic.ziggo.nl. [83.83.181.54]) by mx.google.com with ESMTPSA id ul1sm2816736wjc.30.2015.07.01.05.59.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jul 2015 05:59:30 -0700 (PDT) Message-ID: <5593E431.70200@logicblox.com> Date: Wed, 01 Jul 2015 14:59:29 +0200 From: Eelco Dolstra User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= , 18994@debbugs.gnu.org Subject: Re: [PATCH] Preserve supplementary groups of build users References: <87ppcxsse0.fsf@gnu.org> <87vbe4w8a4.fsf@gnu.org> In-Reply-To: <87vbe4w8a4.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18994 X-Mailman-Approved-At: Wed, 01 Jul 2015 11:30:06 -0400 Cc: nix-dev@lists.science.uu.nl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, On 01/07/15 11:12, Ludovic Courtès wrote: >> Currently, the build environment made by the daemon does not preserve >> supplementary groups of the build users. >> >> Thus, even though the standalone Guix system sets /dev/kvm 660, owned by >> root:kvm, and adds the build users to the kvm group, build users are >> unable to access it. > > The following patch is an attempt to address this bug (see > ) by preserving the supplementary groups of > build users in the build environment. > > In practice, I would expect that supplementary groups would contain only > one or two groups: the build users group, and possibly the “kvm” group. Applied, thanks! -- Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 01 17:11:11 2015 Received: (at 18994) by debbugs.gnu.org; 1 Jul 2015 21:11:11 +0000 Received: from localhost ([127.0.0.1]:36457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAPHi-0007QX-Rp for submit@debbugs.gnu.org; Wed, 01 Jul 2015 17:11:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53380) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZAPHg-0007QI-KG for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 17:11:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAPHa-0005te-IK for 18994@debbugs.gnu.org; Wed, 01 Jul 2015 17:11:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([208.118.235.10]:51778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAPHa-0005tX-F8; Wed, 01 Jul 2015 17:11:02 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:37187 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZAPHZ-0006h9-O6; Wed, 01 Jul 2015 17:11:02 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Charles Strahan Subject: Re: [nix] Preserve supplementary groups of build users (9aed117) References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Messidor an 223 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x3D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Wed, 01 Jul 2015 23:10:52 +0200 In-Reply-To: (Charles Strahan's message of "Wed, 01 Jul 2015 12:03:24 -0700") Message-ID: <87k2ujmvmr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.10 X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 18994 Cc: 18994@debbugs.gnu.org, NixOS/nix , NixOS/nix X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Charles Strahan skribis: > Is there any reason we immediately throw here, instead of checking `ngrou= ps`, resizing the buffer accordingly, and then rerunning `getgrouplist`? I = would think that would be a bit more robust. Sorry, could you quote the code you=E2=80=99re referring to? If you talking about the =E2=80=98getgrouplist=E2=80=99 call, maybe we coul= d do that, but we would still need to put a hard limit on the maximum number of groups anyway. WDYT? Thanks, Ludo=E2=80=99. PS: Please keep 18994@debbugs.gnu.org Cc=E2=80=99d. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 19:02:22 2015 Received: (at control) by debbugs.gnu.org; 19 Aug 2015 23:02:22 +0000 Received: from localhost ([127.0.0.1]:32985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSCNB-0006P9-Um for submit@debbugs.gnu.org; Wed, 19 Aug 2015 19:02:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60932) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSCN9-0006P1-QS for control@debbugs.gnu.org; Wed, 19 Aug 2015 19:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSCN6-0005u6-M6 for control@debbugs.gnu.org; Wed, 19 Aug 2015 19:02:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSCN6-0005tw-EW for control@debbugs.gnu.org; Wed, 19 Aug 2015 19:02:16 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:35663 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZSCN5-0007OB-Sj for control@debbugs.gnu.org; Wed, 19 Aug 2015 19:02:16 -0400 Date: Thu, 20 Aug 2015 01:02:08 +0200 Message-Id: <87d1yi51cf.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #18994 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) close 18994 0.8.3 From unknown Mon Aug 11 21:13:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator