GNU bug report logs - #1899
url-cookie-retrieve is not prepared for missing localpart

Previous Next

Full log

View this message in rfc822 format

From: Klaus Straubinger <KSNetz <at> UseNet.ArcorNews.DE>
To: bug-gnu-emacs <at> gnu.org
Cc: 1899-reopen <at> debbugs.gnu.org, cyd <at> stupidchicken.com
Subject: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart)
Date: Thu, 15 Jan 2009 09:44:29 +0100 ()

Chong Yidong <cyd <at> stupidchicken.com> wrote:

>> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el)
>> is not prepared for the case that the parameter localpart could be
>> nil: (regexp-quote nil) is an error. This is especially problematic
>> since the corresponding function for setting cookies,
>> url-cookie-store, defines the parameter localpart as optional.
>
> I've checked in a fix.  Thanks.

Your fix changed the "string-match" to "equal" while keeping the
"regexp-quote". This will not work for all cases where "localpart" is
not empty.

I am afraid that this mail might not be the right way to reopen the bug.
I apologize for any inconvenience this might cause.

-- 
Klaus Straubinger

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.