From unknown Tue Jun 24 10:31:15 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1899: url-cookie-retrieve is not prepared for missing localpart Reply-To: Klaus Straubinger , 1899@debbugs.gnu.org Resent-From: Klaus Straubinger Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 14 Jan 2009 12:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 1899 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123193702930942 (code B ref -1); Wed, 14 Jan 2009 12:50:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jan 2009 12:43:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EChfBt030936 for ; Wed, 14 Jan 2009 04:43:43 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LN55x-0007lL-JV for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LN55u-0007kt-SC for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:41 -0500 Received: from [199.232.76.173] (port=41356 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LN55u-0007kc-KF for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:38 -0500 Received: from smtpde01.sap-ag.de ([155.56.68.171]:63848) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LN55u-0001XB-3C for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:38 -0500 Received: from mail.sap.corp by smtpde01.sap-ag.de (26) with ESMTP id n0EChSji021523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 14 Jan 2009 13:43:28 +0100 (MET) Message-ID: Date: Wed, 14 Jan 2009 13:43:27 +0100 () From: Klaus Straubinger To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Gnus/5.11 (Gnus v5.11) Emacs/22.3 X-Scanner: Virus Scanner virwal05 X-SAP: out X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) is not prepared for the case that the parameter localpart could be nil: (regexp-quote nil) is an error. This is especially problematic since the corresponding function for setting cookies, url-cookie-store, defines the parameter localpart as optional. Test example: (require 'url-cookie) (url-cookie-store "test" "42" nil "www.gnu.org") followed by (url-cookie-retrieve "www.gnu.org" nil) -- Klaus Straubinger From unknown Tue Jun 24 10:31:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Klaus Straubinger Subject: bug#1899 closed by Chong Yidong (Re: url-cookie-retrieve is not prepared for missing localpart) Message-ID: References: <87fxjlvcl7.fsf@cyd.mit.edu> X-Emacs-PR-Message: they-closed 1899 X-Emacs-PR-Package: emacs Reply-To: 1899@debbugs.gnu.org Date: Wed, 14 Jan 2009 20:55:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1231966504-25537-1" This is a multi-part message in MIME format... ------------=_1231966504-25537-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #1899: url-cookie-retrieve is not prepared for missing localpart It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 1899: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1899 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1231966504-25537-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1899-done) by emacsbugs.donarmstrong.com; 14 Jan 2009 20:47:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EKlmq7023992 for <1899-done@emacsbugs.donarmstrong.com>; Wed, 14 Jan 2009 12:47:49 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id DC59C57E1D7; Wed, 14 Jan 2009 15:48:04 -0500 (EST) From: Chong Yidong To: Klaus Straubinger Cc: 1899-done@debbugs.gnu.org Subject: Re: url-cookie-retrieve is not prepared for missing localpart Date: Wed, 14 Jan 2009 15:48:04 -0500 Message-ID: <87fxjlvcl7.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) > is not prepared for the case that the parameter localpart could be > nil: (regexp-quote nil) is an error. This is especially problematic > since the corresponding function for setting cookies, > url-cookie-store, defines the parameter localpart as optional. I've checked in a fix. Thanks. ------------=_1231966504-25537-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jan 2009 12:43:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EChfBt030936 for ; Wed, 14 Jan 2009 04:43:43 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LN55x-0007lL-JV for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LN55u-0007kt-SC for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:41 -0500 Received: from [199.232.76.173] (port=41356 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LN55u-0007kc-KF for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:38 -0500 Received: from smtpde01.sap-ag.de ([155.56.68.171]:63848) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LN55u-0001XB-3C for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:38 -0500 Received: from mail.sap.corp by smtpde01.sap-ag.de (26) with ESMTP id n0EChSji021523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 14 Jan 2009 13:43:28 +0100 (MET) Message-ID: Date: Wed, 14 Jan 2009 13:43:27 +0100 () From: Klaus Straubinger To: bug-gnu-emacs@gnu.org Subject: url-cookie-retrieve is not prepared for missing localpart MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Gnus/5.11 (Gnus v5.11) Emacs/22.3 X-Scanner: Virus Scanner virwal05 X-SAP: out X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) is not prepared for the case that the parameter localpart could be nil: (regexp-quote nil) is an error. This is especially problematic since the corresponding function for setting cookies, url-cookie-store, defines the parameter localpart as optional. Test example: (require 'url-cookie) (url-cookie-store "test" "42" nil "www.gnu.org") followed by (url-cookie-retrieve "www.gnu.org" nil) -- Klaus Straubinger ------------=_1231966504-25537-1-- From unknown Tue Jun 24 10:31:15 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart) Reply-To: Klaus Straubinger , 1899@debbugs.gnu.org Resent-From: Klaus Straubinger Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 15 Jan 2009 08:50:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1899 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123200910412509 (code B ref -1); Thu, 15 Jan 2009 08:50:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Jan 2009 08:45:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0F8j0Jk012370 for ; Thu, 15 Jan 2009 00:45:01 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNNqW-0000sP-7U for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:45:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNNqU-0000sA-OW for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:59 -0500 Received: from [199.232.76.173] (port=51402 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNNqU-0000s3-FX for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:58 -0500 Received: from mx20.gnu.org ([199.232.41.8]:4770) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNNqT-0005Fo-VC for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:58 -0500 Received: from smtpde01.sap-ag.de ([155.56.68.171]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNNqS-0003W9-ON for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:57 -0500 Received: from mail.sap.corp by smtpde01.sap-ag.de (26) with ESMTP id n0F8iWat016486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Jan 2009 09:44:32 +0100 (MET) Message-ID: Date: Thu, 15 Jan 2009 09:44:29 +0100 () From: Klaus Straubinger To: bug-gnu-emacs@gnu.org Cc: 1899-reopen@debbugs.gnu.org, cyd@stupidchicken.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: References: <87fxjlvcl7.fsf@cyd.mit.edu> X-Mailer: Gnus/5.11 (Gnus v5.11) Emacs/22.3 X-Scanner: Virus Scanner virwal05 X-SAP: out X-detected-kernel: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Chong Yidong wrote: >> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) >> is not prepared for the case that the parameter localpart could be >> nil: (regexp-quote nil) is an error. This is especially problematic >> since the corresponding function for setting cookies, >> url-cookie-store, defines the parameter localpart as optional. > > I've checked in a fix. Thanks. Your fix changed the "string-match" to "equal" while keeping the "regexp-quote". This will not work for all cases where "localpart" is not empty. I am afraid that this mail might not be the right way to reopen the bug. I apologize for any inconvenience this might cause. -- Klaus Straubinger