From Klaus.Straubinger@SAP.Com Wed Jan 14 04:43:49 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jan 2009 12:43:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EChfBt030936 for ; Wed, 14 Jan 2009 04:43:43 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LN55x-0007lL-JV for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LN55u-0007kt-SC for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:41 -0500 Received: from [199.232.76.173] (port=41356 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LN55u-0007kc-KF for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:38 -0500 Received: from smtpde01.sap-ag.de ([155.56.68.171]:63848) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LN55u-0001XB-3C for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 07:43:38 -0500 Received: from mail.sap.corp by smtpde01.sap-ag.de (26) with ESMTP id n0EChSji021523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 14 Jan 2009 13:43:28 +0100 (MET) Message-ID: Date: Wed, 14 Jan 2009 13:43:27 +0100 () From: Klaus Straubinger To: bug-gnu-emacs@gnu.org Subject: url-cookie-retrieve is not prepared for missing localpart MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Gnus/5.11 (Gnus v5.11) Emacs/22.3 X-Scanner: Virus Scanner virwal05 X-SAP: out X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) is not prepared for the case that the parameter localpart could be nil: (regexp-quote nil) is an error. This is especially problematic since the corresponding function for setting cookies, url-cookie-store, defines the parameter localpart as optional. Test example: (require 'url-cookie) (url-cookie-store "test" "42" nil "www.gnu.org") followed by (url-cookie-retrieve "www.gnu.org" nil) -- Klaus Straubinger From cyd@stupidchicken.com Wed Jan 14 12:47:55 2009 Received: (at 1899-done) by emacsbugs.donarmstrong.com; 14 Jan 2009 20:47:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0EKlmq7023992 for <1899-done@emacsbugs.donarmstrong.com>; Wed, 14 Jan 2009 12:47:49 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id DC59C57E1D7; Wed, 14 Jan 2009 15:48:04 -0500 (EST) From: Chong Yidong To: Klaus Straubinger Cc: 1899-done@debbugs.gnu.org Subject: Re: url-cookie-retrieve is not prepared for missing localpart Date: Wed, 14 Jan 2009 15:48:04 -0500 Message-ID: <87fxjlvcl7.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) > is not prepared for the case that the parameter localpart could be > nil: (regexp-quote nil) is an error. This is especially problematic > since the corresponding function for setting cookies, > url-cookie-store, defines the parameter localpart as optional. I've checked in a fix. Thanks. From Klaus.Straubinger@SAP.Com Thu Jan 15 00:45:04 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Jan 2009 08:45:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0F8j0Jk012370 for ; Thu, 15 Jan 2009 00:45:01 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNNqW-0000sP-7U for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:45:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNNqU-0000sA-OW for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:59 -0500 Received: from [199.232.76.173] (port=51402 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNNqU-0000s3-FX for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:58 -0500 Received: from mx20.gnu.org ([199.232.41.8]:4770) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNNqT-0005Fo-VC for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:58 -0500 Received: from smtpde01.sap-ag.de ([155.56.68.171]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNNqS-0003W9-ON for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:57 -0500 Received: from mail.sap.corp by smtpde01.sap-ag.de (26) with ESMTP id n0F8iWat016486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Jan 2009 09:44:32 +0100 (MET) Message-ID: Date: Thu, 15 Jan 2009 09:44:29 +0100 () From: Klaus Straubinger To: bug-gnu-emacs@gnu.org Cc: 1899-reopen@debbugs.gnu.org, cyd@stupidchicken.com Subject: Re: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: References: <87fxjlvcl7.fsf@cyd.mit.edu> X-Mailer: Gnus/5.11 (Gnus v5.11) Emacs/22.3 X-Scanner: Virus Scanner virwal05 X-SAP: out X-detected-kernel: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Chong Yidong wrote: >> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) >> is not prepared for the case that the parameter localpart could be >> nil: (regexp-quote nil) is an error. This is especially problematic >> since the corresponding function for setting cookies, >> url-cookie-store, defines the parameter localpart as optional. > > I've checked in a fix. Thanks. Your fix changed the "string-match" to "equal" while keeping the "regexp-quote". This will not work for all cases where "localpart" is not empty. I am afraid that this mail might not be the right way to reopen the bug. I apologize for any inconvenience this might cause. -- Klaus Straubinger From cyd@stupidchicken.com Thu Jan 15 06:01:35 2009 Received: (at 1899-done) by emacsbugs.donarmstrong.com; 15 Jan 2009 14:01:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0FE1WNi008724 for <1899-done@emacsbugs.donarmstrong.com>; Thu, 15 Jan 2009 06:01:34 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 5B87C57E21A; Thu, 15 Jan 2009 09:01:50 -0500 (EST) From: Chong Yidong To: Klaus Straubinger Cc: 1899-done@debbugs.gnu.org Subject: Re: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart) References: <87fxjlvcl7.fsf@cyd.mit.edu> Date: Thu, 15 Jan 2009 09:01:50 -0500 In-Reply-To: (Klaus Straubinger's message of "Thu, 15 Jan 2009 09:44:29 +0100 ()") Message-ID: <87eiz4oegh.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Klaus Straubinger writes: >> I've checked in a fix. Thanks. > > Your fix changed the "string-match" to "equal" while keeping the > "regexp-quote". This will not work for all cases where "localpart" is > not empty. The fix was wrong, indeed. I've made another checkin that should do the right thing. Thanks for checking. From unknown Tue Jun 24 10:31:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Feb 2009 15:24:08 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator